[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1481: MINIFICPP-1948 Add the UUID to the end of Processor and Controller Service log lines

2022-12-23 Thread GitBox 


fgerlits commented on code in PR #1481:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1481#discussion_r1055622646


##
libminifi/include/core/logging/LoggerConfiguration.h:
##
@@ -133,16 +132,21 @@ class LoggerConfiguration {
 
   class LoggerImpl : public Logger {
public:
-explicit LoggerImpl(std::string name, const std::shared_ptr 
, const std::shared_ptr )
+explicit LoggerImpl(std::string name, std::optional id, const 
std::shared_ptr , const 
std::shared_ptr )

Review Comment:
   I have changed everything to `Identifier` in 
8e2a3e25602436e36b686114ea7ad4daef5f6be8



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1481: MINIFICPP-1948 Add the UUID to the end of Processor and Controller Service log lines

2022-12-22 Thread GitBox 


fgerlits commented on code in PR #1481:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1481#discussion_r1055622646


##
libminifi/include/core/logging/LoggerConfiguration.h:
##
@@ -133,16 +132,21 @@ class LoggerConfiguration {
 
   class LoggerImpl : public Logger {
public:
-explicit LoggerImpl(std::string name, const std::shared_ptr 
, const std::shared_ptr )
+explicit LoggerImpl(std::string name, std::optional id, const 
std::shared_ptr , const 
std::shared_ptr )

Review Comment:
   I have changed everything to `Identifier` in 
9ad1b17b7f52b497d608e1201e0b525b301595d1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1481: MINIFICPP-1948 Add the UUID to the end of Processor and Controller Service log lines

2022-12-20 Thread GitBox 


fgerlits commented on code in PR #1481:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1481#discussion_r1053449250


##
libminifi/include/core/logging/LoggerConfiguration.h:
##
@@ -133,16 +132,21 @@ class LoggerConfiguration {
 
   class LoggerImpl : public Logger {
public:
-explicit LoggerImpl(std::string name, const std::shared_ptr 
, const std::shared_ptr )
+explicit LoggerImpl(std::string name, std::optional id, const 
std::shared_ptr , const 
std::shared_ptr )

Review Comment:
   I wanted to make it generic, so we could add other kinds of stuff, but it's 
true that it's already specialized to `Identifier` in `getLogger()`.  Should I 
change it to `Identifier` all the way, i.e. in the stored field and the return 
value of `get_id()`, as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org