[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2018-03-02 Thread Jorge Machado (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383776#comment-16383776
 ] 

Jorge Machado commented on NIFI-3380:
-

I guys, I saw this and I have multiple version of the same custom processor. 
When I try to check this out from the registry it says to me: 

 

Multiple versions of processorName exist. No exact match for 
default:processorName:unversioned.

 

 

How do I set a default version ? 

> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Matt Gilman
>Priority: Major
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-04-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978784#comment-15978784
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/1684
  
Thanks @mcgilman this has been merged to master.


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Matt Gilman
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-04-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978780#comment-15978780
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1684


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Matt Gilman
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-04-21 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978779#comment-15978779
 ] 

ASF subversion and git services commented on NIFI-3380:
---

Commit 0b95ccb90a7ef10039ca9941e4297aa90b2a0615 in nifi's branch 
refs/heads/master from [~mcgilman]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=0b95ccb ]

NIFI-3380:
- Fixing opening of Usage from the Controller Service and Reporting Task table.

Signed-off-by: Scott Aslan 

This closes #1684


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Matt Gilman
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-04-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978742#comment-15978742
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/1684
  
Reviewing...


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Matt Gilman
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-04-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977398#comment-15977398
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/1684

NIFI-3380: Fixing usage links from Controller Service and Reporting Tasks 
tables

NIFI-3380:
- Fixing opening of Usage from the Controller Service and Reporting Task 
table.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-3380

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1684.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1684


commit c3d4661f5c0d9c5405668581829b504be0467c71
Author: Matt Gilman 
Date:   2017-04-20T20:04:22Z

NIFI-3380:
- Fixing opening of Usage from the Controller Service and Reporting Task 
table.




> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Matt Gilman
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944006#comment-15944006
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1627


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Matt Gilman
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944001#comment-15944001
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1627
  
Looks good, will merge to master


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Matt Gilman
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943347#comment-15943347
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

GitHub user mcgilman opened a pull request:

https://github.com/apache/nifi/pull/1627

NIFI-3380: Fixing paths in generated documentation

NIFI-3380:
- Addressing issues with paths in generated documentation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mcgilman/nifi NIFI-3380

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1627.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1627


commit b03b9b70fb4529498cd6d1717afea25a19d8c73f
Author: Matt Gilman 
Date:   2017-03-27T14:21:01Z

NIFI-3380:
- Addressing issues with paths in generated documentation.




> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Matt Gilman
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-25 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941755#comment-15941755
 ] 

ASF subversion and git services commented on NIFI-3380:
---

Commit f0a1c14f025f6013ed3667ea4470cd34846756d7 in nifi's branch 
refs/heads/master from [~bbende]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=f0a1c14 ]

NIFI-3380 Fixing parent pom of nifi-standard-prioritizers to point to correct 
parent after moving under nifi-framework


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-24 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940513#comment-15940513
 ] 

ASF subversion and git services commented on NIFI-3380:
---

Commit d90cf846b9dcd49acdeac7bb5fcd13ee80dcdba6 in nifi's branch 
refs/heads/master from [~bbende]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=d90cf84 ]

NIFI-3380 Bumping NAR plugin to 1.2.0-SNAPSHOT development to leverage changes 
from master, adding buildnumber-maven-plugin to nifi-nar-bundles to properly 
set build info in MANIFEST of NARs
- Refactoring NarDetails to include all info from MANIFEST
- Adding the concept of a Bundle and refactoring NarClassLoaders to pass 
Bundles to ExtensionManager
- Adding logic to fail start-up when multiple NARs with same coordinates exist, 
moving Bundle classes to framework API
- Refactoring bundle API to classes and creating BundleCoordinate
- Updating FlowController to use BundleCoordinate

- Updating the UI and DTO model to support showing bundle details that loaded 
an extension type.
- Adding bundle details for processor canvas node, processor dialogs, 
controller service dialogs, and reporting task dialogs.
- Updating the formating of the bundle coordinates.
- Addressing text overflow in the configuration/details dialog.
- Fixing self referencing functions.
- Updating extension UI mapping to incorporate bundle coordinates.
- Discovering custom UIs through the supplied bundles.
- Adding verification methods for creating extensions through the rest api.
- Only returning extensions that are common amongst all nodes.
- Rendering the ghost processors using a dotted border.
- Adding bundle details to the flow.xml.
- Loading NiFi build and version details from the framework NAR.
- Removing properties for build and version details.
- Wiring together front end and back end changes.
- Including bundle coordinates in the component data model.
- Wiring together component data model and flow.xml.
- Addressing issue when resolve unvesioned dependent NARs.

Updating unit tests to pass based on framework changes
- Fixing logging of extension types during start up

- Allowing the application to start if there is a compatible bundle found. - 
Reporting missing bundle when the a compatible bundle is not found. - Fixing 
table height in new component dialogs.

Fixing chechstyle error and increasing test timeout for 
TestStandardControllerServiceProvider
- Adding ability to change processor type at runtime
- Adding backend code to change type for controller services

- Cleaning up instance classloaders for temp components.
- Creating a dialog for changing the version of a component.
- Updating the formatting of the component type and bundle throughout.
- Updating the new component dialogs to support selecting source group.
- Cleaning up new component dialogs.
- Cleaning up documentation in the cluster node endpoint.

Adding missing include in nifi-web-ui pom compressor plugin
- Refactoring so ConfigurableComponent provides getLogger() and so the nodes 
provide the ConfigurableComponent
- Creating LoggableComponent to pass around the component, logger, and 
coordinate with in the framework

- Finishing clean up following rebase.

Calling lifecycle methods for add and remove when changing versions of a 
component
- Introducing verifyCanUpdateBundle(coordinate) to ConfiguredComponent, and 
adding unit tests

- Ensuring documentation is available for all components. Including those of 
the same type that are loaded from different bundles.

Adding lookup from ClassLoader to Bundle, adding fix for instance class loading 
to include all parent NARs, and adding additional unit tests for FlowController
- Adding validation to ensure referenced controller services implement the 
required API
- Fixing template instantiation to look up compatible bundle

- Requiring services/reporting tasks to be disabled/stopped.
- Only supporting a change version option when the item has multiple versions 
available.
- Limiting the possible new controller services to the applicable API version.
- Showing the implemented API versions for Controller Services.
- Updating the property descriptor tooltip to indicate the required service 
requirements.
- Introducing version based sorting in the new component dialog, change version 
dialog, and new controller service dialog.
- Addressing remainder of the issues from recent rebase.

Ensuring bundles have been added to the flow before proposing a flow, and 
incorporating bundle information into flow fingerprinting
- Refactoring the way missing bundles work to retain the desired bundle if 
available
- Fixing logger.isDebugEnabled to be logger.isTraceEnabled

- Auditing when user changes the bundle. - Ensuring bundle details are present 
in templates.

Moving standard prioritizers to framework NAR and refactoring ExtensionManager 
logic to handle cases where an extension is in a JAR

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940515#comment-15940515
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1585


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940517#comment-15940517
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/1585
  
This all looks good. I've run through the standard cases of standalone and 
clustered instances. Ran through some crazy cases that I could think of. Didn't 
run into any unexpected problems. Code looks good. I especially paid attention 
to the *Node classes, StandardFlowService, and Fingerprint classes when 
reviewing code but found nothing concerning. +1 merged to master!


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-24 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940512#comment-15940512
 ] 

ASF subversion and git services commented on NIFI-3380:
---

Commit d90cf846b9dcd49acdeac7bb5fcd13ee80dcdba6 in nifi's branch 
refs/heads/master from [~bbende]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=d90cf84 ]

NIFI-3380 Bumping NAR plugin to 1.2.0-SNAPSHOT development to leverage changes 
from master, adding buildnumber-maven-plugin to nifi-nar-bundles to properly 
set build info in MANIFEST of NARs
- Refactoring NarDetails to include all info from MANIFEST
- Adding the concept of a Bundle and refactoring NarClassLoaders to pass 
Bundles to ExtensionManager
- Adding logic to fail start-up when multiple NARs with same coordinates exist, 
moving Bundle classes to framework API
- Refactoring bundle API to classes and creating BundleCoordinate
- Updating FlowController to use BundleCoordinate

- Updating the UI and DTO model to support showing bundle details that loaded 
an extension type.
- Adding bundle details for processor canvas node, processor dialogs, 
controller service dialogs, and reporting task dialogs.
- Updating the formating of the bundle coordinates.
- Addressing text overflow in the configuration/details dialog.
- Fixing self referencing functions.
- Updating extension UI mapping to incorporate bundle coordinates.
- Discovering custom UIs through the supplied bundles.
- Adding verification methods for creating extensions through the rest api.
- Only returning extensions that are common amongst all nodes.
- Rendering the ghost processors using a dotted border.
- Adding bundle details to the flow.xml.
- Loading NiFi build and version details from the framework NAR.
- Removing properties for build and version details.
- Wiring together front end and back end changes.
- Including bundle coordinates in the component data model.
- Wiring together component data model and flow.xml.
- Addressing issue when resolve unvesioned dependent NARs.

Updating unit tests to pass based on framework changes
- Fixing logging of extension types during start up

- Allowing the application to start if there is a compatible bundle found. - 
Reporting missing bundle when the a compatible bundle is not found. - Fixing 
table height in new component dialogs.

Fixing chechstyle error and increasing test timeout for 
TestStandardControllerServiceProvider
- Adding ability to change processor type at runtime
- Adding backend code to change type for controller services

- Cleaning up instance classloaders for temp components.
- Creating a dialog for changing the version of a component.
- Updating the formatting of the component type and bundle throughout.
- Updating the new component dialogs to support selecting source group.
- Cleaning up new component dialogs.
- Cleaning up documentation in the cluster node endpoint.

Adding missing include in nifi-web-ui pom compressor plugin
- Refactoring so ConfigurableComponent provides getLogger() and so the nodes 
provide the ConfigurableComponent
- Creating LoggableComponent to pass around the component, logger, and 
coordinate with in the framework

- Finishing clean up following rebase.

Calling lifecycle methods for add and remove when changing versions of a 
component
- Introducing verifyCanUpdateBundle(coordinate) to ConfiguredComponent, and 
adding unit tests

- Ensuring documentation is available for all components. Including those of 
the same type that are loaded from different bundles.

Adding lookup from ClassLoader to Bundle, adding fix for instance class loading 
to include all parent NARs, and adding additional unit tests for FlowController
- Adding validation to ensure referenced controller services implement the 
required API
- Fixing template instantiation to look up compatible bundle

- Requiring services/reporting tasks to be disabled/stopped.
- Only supporting a change version option when the item has multiple versions 
available.
- Limiting the possible new controller services to the applicable API version.
- Showing the implemented API versions for Controller Services.
- Updating the property descriptor tooltip to indicate the required service 
requirements.
- Introducing version based sorting in the new component dialog, change version 
dialog, and new controller service dialog.
- Addressing remainder of the issues from recent rebase.

Ensuring bundles have been added to the flow before proposing a flow, and 
incorporating bundle information into flow fingerprinting
- Refactoring the way missing bundles work to retain the desired bundle if 
available
- Fixing logger.isDebugEnabled to be logger.isTraceEnabled

- Auditing when user changes the bundle. - Ensuring bundle details are present 
in templates.

Moving standard prioritizers to framework NAR and refactoring ExtensionManager 
logic to handle cases where an extension is in a JAR

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938351#comment-15938351
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1585
  
@markap14 The PR has been updated to address your comments and to fix a 
couple of other issues that were identified, also rebased against master as of 
yesterday evening.

Here are the changes since your last review:

- 
https://github.com/apache/nifi/pull/1585/commits/fadf43d7ccc755b5a5e3b52692e6b8f814afb657
 (synchronization in node classes)
- 
https://github.com/apache/nifi/pull/1585/commits/b1ed76c2bc4ec3a639d360017fe899a8fd5777a7
 (CS bundled with API + restructure Hive NAR)
- 
https://github.com/apache/nifi/pull/1585/commits/6b2ac1fb77ee08ce4b183e3b78c7c178c38256ae
 (missing components in fingerprinting)
- 
https://github.com/apache/nifi/pull/1585/commits/8988cd9a88ab52825c07260b17b5179c5886
 (checkstyles and failing tests)

I'm going to continue testing today, but let me know if there is anything 
else to address.


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930334#comment-15930334
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/1585
  
@bbende I created a 3-node cluster. I added MyProcessor v2.0 to the flow. I 
then shut down node 3, removed the nifi-example-processors-nar-2.0.nar file 
from the lib/ directory and removed conf/flow.xml.gz. I then restarted Node 3. 
It fails to startup because the cluster flow cannot be inherited, due to the 
node not having v2.0 of the Processor. This, I think, is the expected behavior. 
However, it fails with the following error message in the logs:

```
2017-03-17 13:14:58,602 ERROR [main] 
o.a.nifi.controller.StandardFlowService Failed to load flow from cluster due 
to: org.apache.nifi.controller.UninheritableFlowException: Failed to connect 
node to cluster because local flow is different than cluster flow.
org.apache.nifi.controller.UninheritableFlowException: Failed to connect 
node to cluster because local flow is different than cluster flow.
at 
org.apache.nifi.controller.StandardFlowService.loadFromConnectionResponse(StandardFlowService.java:921)
 ~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at 
org.apache.nifi.controller.StandardFlowService.load(StandardFlowService.java:513)
 ~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at org.apache.nifi.web.server.JettyServer.start(JettyServer.java:780) 
[nifi-jetty-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at org.apache.nifi.NiFi.(NiFi.java:162) 
[nifi-runtime-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at org.apache.nifi.NiFi.main(NiFi.java:269) 
[nifi-runtime-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
Caused by: org.apache.nifi.controller.UninheritableFlowException: 
org.apache.nifi.processors.example.MyProcessor from 
org.apache.nifi:nifi-example-processors-nar:2.0 is not known to this NiFi 
instance.
at 
org.apache.nifi.controller.StandardFlowSynchronizer.checkBundleCompatibility(StandardFlowSynchronizer.java:431)
 ~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at 
org.apache.nifi.controller.StandardFlowSynchronizer.sync(StandardFlowSynchronizer.java:246)
 ~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at 
org.apache.nifi.controller.FlowController.synchronize(FlowController.java:1535) 
~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at 
org.apache.nifi.persistence.StandardXMLFlowConfigurationDAO.load(StandardXMLFlowConfigurationDAO.java:83)
 ~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at 
org.apache.nifi.controller.StandardFlowService.loadFromBytes(StandardFlowService.java:707)
 ~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at 
org.apache.nifi.controller.StandardFlowService.loadFromConnectionResponse(StandardFlowService.java:896)
 ~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
... 4 common frames omitted
Caused by: java.lang.IllegalStateException: 
org.apache.nifi.processors.example.MyProcessor from 
org.apache.nifi:nifi-example-processors-nar:2.0 is not known to this NiFi 
instance.
at 
org.apache.nifi.util.BundleUtils.findCompatibleBundle(BundleUtils.java:54) 
~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at org.apache.nifi.util.BundleUtils.getBundle(BundleUtils.java:88) 
~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at 
org.apache.nifi.controller.StandardFlowSynchronizer.checkBundleCompatibility(StandardFlowSynchronizer.java:429)
 ~[nifi-framework-core-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
... 9 common frames omitted
```

I find this error message confusing. It used to make sense when the local 
flow as different than the cluster flow and that was the only way we could get 
into this situation. However, it now is caused by failing to create the 
necessary Processor. We should use a different error message.

Either we could throw a different Exception (perhaps something that extends 
UninheritableFlowException?) and provide a different error message, or we 
should make the message more generic, such as: "Unable to update local flow to 
match the cluster's flow" instead of "Local flow is different from cluster 
flow," given that the local flow was empty and therefore should try to inherit 
the cluster flow.

Does that make sense?


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
> Attachments:

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930046#comment-15930046
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user markap14 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r106662774
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java
 ---
@@ -905,6 +932,14 @@ private void loadFromConnectionResponse(final 
ConnectionResponse response) throw
 
 }
 
+private void initialzeController() throws IOException {
--- End diff --

Typo in method name - initialze should be initialize 


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928668#comment-15928668
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user markap14 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r106506092
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/reporting/AbstractReportingTaskNode.java
 ---
@@ -125,7 +141,12 @@ public void setSchedulingPeriod(final String 
schedulingPeriod) {
 
 @Override
 public ReportingTask getReportingTask() {
-return reportingTask;
+return reportingTaskRef.get().getReportingTask();
+}
+
+@Override
+public void setReportingTask(final LoggableComponent 
reportingTask) {
+this.reportingTaskRef.set(new ReportingTaskDetails(reportingTask));
--- End diff --

We should make sure here that the Reporting Task is stopped, similar to 
Processors. And should also ensure that Controller Services are disabled when 
calling setControllerService.


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928662#comment-15928662
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user markap14 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r106505581
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java
 ---
@@ -1457,4 +1466,85 @@ public String getProcessGroupIdentifier() {
 final ProcessGroup group = getProcessGroup();
 return group == null ? null : group.getIdentifier();
 }
+
+private static final class ProcessorDetails {
--- End diff --

Similarly, for ControllerServiceDetails and ReportingTaskDetails


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928639#comment-15928639
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user markap14 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r106502862
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java
 ---
@@ -857,7 +858,13 @@ public Relationship getRelationship(final String 
relationshipName) {
 
 @Override
 public Processor getProcessor() {
-return this.processor;
+return processorRef.get().getProcessor();
+}
+
+@Override
+public void setProcessor(final LoggableComponent processor) 
{
+final ProcessorDetails processorDetails = new 
ProcessorDetails(processor);
--- End diff --

We should probably have some thread protection here to make sure that the 
Processor is indeed stopped. This would mean that we need to enter a 
synchronized block here, then verify that the processor is not running 
(!isRunning()) and then do the processorRef.set(processorDetails). We would 
also need to ensure that in the start() method that the act of changing the 
scheduledState from STOPPED to STARTED is also synchronized to ensure atomicity.


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar, 
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar, 
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar, 
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924676#comment-15924676
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r105980001
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js
 ---
@@ -939,27 +939,30 @@
 /**
  * Gets the available controller services that implement the specified 
type and
  * prompts the user to create one.
--- End diff --

Yeah, werid... Will restore.


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924678#comment-15924678
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r105980032
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/resources/filters/canvas.properties
 ---
@@ -28,6 +28,7 @@ nf.canvas.script.tags=\n\
 \n\
 \n\
+\n\
--- End diff --

Yup.


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924652#comment-15924652
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r105977072
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js
 ---
@@ -939,27 +939,30 @@
 /**
  * Gets the available controller services that implement the specified 
type and
  * prompts the user to create one.
--- End diff --

Why did you delete the param docs?


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924623#comment-15924623
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r105973908
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/resources/filters/canvas.properties
 ---
@@ -28,6 +28,7 @@ nf.canvas.script.tags=\n\
 \n\
 \n\
+\n\
--- End diff --

Will need to update the load order here as well...


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922857#comment-15922857
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r105759544
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-actions.js
 ---
@@ -1214,6 +1217,23 @@
 },
 
 /**
+ * Views the state for the specified processor.
+ *
+ * @param {selection} selection
+ */
+changeVersion: function (selection) {
+if (selection.size() !== 1 || 
!nf.CanvasUtils.isProcessor(selection)) {
+return;
+}
+
+// get the processor data
+var processor = selection.datum();
+
+// attempt to change the version of the specified component
+nf.ComponentVersion.promptForVersionChange(processor);
--- End diff --

Yup. Must have missed this one. Much of this was written prior to getting 
the modularization effort in. I went back through and updated each invocation 
using `nf.`. I'll update this one and make sure I didn't miss any others.


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922855#comment-15922855
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r105758869
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml
 ---
@@ -440,6 +440,7 @@
 
${staging.dir}/js/nf/canvas/nf-clipboard.js
 
${staging.dir}/js/nf/canvas/nf-custom-ui.js
 
${staging.dir}/js/nf/canvas/nf-canvas-utils.js
+
${staging.dir}/js/nf/canvas/nf-component-version.js
--- End diff --

Got it. I feel like it wasn't possible when I originally typed it up. 
However, this module went through a couple iterations during the development of 
this feature. I'll try updating the dependency injection with your suggestions 
now.


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922818#comment-15922818
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r105747481
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-actions.js
 ---
@@ -1214,6 +1217,23 @@
 },
 
 /**
+ * Views the state for the specified processor.
+ *
+ * @param {selection} selection
+ */
+changeVersion: function (selection) {
+if (selection.size() !== 1 || 
!nf.CanvasUtils.isProcessor(selection)) {
+return;
+}
+
+// get the processor data
+var processor = selection.datum();
+
+// attempt to change the version of the specified component
+nf.ComponentVersion.promptForVersionChange(processor);
--- End diff --

We should not be calling anything from the global scope. Instead we should 
have this module require('nf.ComponentVersion')...


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922820#comment-15922820
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r105746348
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml
 ---
@@ -440,6 +440,7 @@
 
${staging.dir}/js/nf/canvas/nf-clipboard.js
 
${staging.dir}/js/nf/canvas/nf-custom-ui.js
 
${staging.dir}/js/nf/canvas/nf-canvas-utils.js
+
${staging.dir}/js/nf/canvas/nf-component-version.js
--- End diff --

I think we can move this down in the order. If you move it below the 
nf-process-group-configuration.js. then in the nfProcessGroupConfiguration 
module you can load nfComponentVersion module. If you do this then you can 
avoid having to inject the nfProcessGroupConfiguration module into the 
nfComponentVersion module in the nf-canvas-bootstrap.js.


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922821#comment-15922821
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r105746988
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-component-version.js
 ---
@@ -0,0 +1,340 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* global nf */
+
+/**
+ * Views state for a given component.
+ */
+(function (root, factory) {
+if (typeof define === 'function' && define.amd) {
+define(['jquery',
+'nf.ErrorHandler',
+'nf.Common',
+'nf.Client',
+'nf.CanvasUtils',
+'nf.ng.Bridge'],
+function ($, Slick, nfErrorHandler, nfCommon, nfClient, 
nfCanvasUtils, nfNgBridge) {
+return (nf.ComponentState = factory($, nfErrorHandler, 
nfCommon, nfClient, nfCanvasUtils, nfNgBridge));
+});
+} else if (typeof exports === 'object' && typeof module === 'object') {
+module.exports = (nf.ComponentState =
+factory(require('jquery'),
+require('nf.ErrorHandler'),
+require('nf.Common',
+require('nf.Client'),
+require('nf.CanvasUtils'),
+require('nf.ng.Bridge';
+} else {
+nf.ComponentVersion = factory(root.$,
+root.nf.ErrorHandler,
+root.nf.Common,
+root.nf.Client,
+root.nf.CanvasUtils,
+root.nf.ng.Bridge);
+}
+}(this, function ($, nfErrorHandler, nfCommon, nfClient, nfCanvasUtils, 
nfNgBridge) {
+'use strict';
+
+var versionMap;
+var nfSettings;
+var nfProcessGroupConfiguration;
+
+/**
+ * Gets the URI for retrieving available types/bundles
+ *
+ * @param {object} componentEntity
+ * @returns {string} uri
+ */
+var getTypeUri = function (componentEntity) {
+if (componentEntity.type === 'ReportingTask') {
+return '../nifi-api/flow/reporting-task-types';
+} else if (componentEntity.type === 'ControllerService') {
+return '../nifi-api/flow/controller-service-types';
+} else {
+return '../nifi-api/flow/processor-types';
+}
+};
+
+/**
+ * Gets the field to use to access the returned types/bundles.
+ *
+ * @param {object} componentEntity
+ * @returns {string} field
+ */
+var getTypeField = function (componentEntity) {
+if (componentEntity.type === 'ReportingTask') {
+return 'reportingTaskTypes';
+} else if (componentEntity.type === 'ControllerService') {
+return 'controllerServiceTypes';
+} else {
+return 'processorTypes';
+}
+};
+
+/**
+ * Reset the dialog.
+ */
+var resetDialog = function () {
+// clear the versions
+var versions = versionMap.keys();
+$.each(versions, function (_, version) {
+versionMap.remove(version);
+});
+
+// clear the service apis
+$('#component-version-controller-service-apis').empty();
+$('#component-version-controller-service-apis-container').hide();
+
+// clear the fields
+$('#component-version-name').text('');
+$('#component-version-bundle').text('');
+$('#component-version-tags').text('');
+$('#component-version-restriction').removeClass('unset').text('');
+$('#component-version-description').text('');
+
+//

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922817#comment-15922817
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1585#discussion_r105746551
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-canvas-bootstrap.js
 ---
@@ -339,6 +342,7 @@
 nfActions.init();
 nfQueueListing.init();
 nfComponentState.init();
+nfComponentVersion.init(nfSettings, 
nfProcessGroupConfiguration);
--- End diff --

Should be able to remove the injection of the nfProcessGroupConfiguration 
module here.


> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

2017-03-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905625#comment-15905625
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

GitHub user bbende opened a pull request:

https://github.com/apache/nifi/pull/1585

NIFI-3380 Support Multiple Versions of the Same Component

This PR introduces support for running multiple versions of the same 
component. 

In order to make full use of this capability we need to release and updated 
version of the NAR Maven plugin (currently 1.1.0, need to release 1.2.0) and 
then update NiFi's master branch to use this new version. In this PR we have 
left it using the 1.1.0 NAR plugin, and NiFi is able to run as it normally 
does, but you can't actually run multiple versions of the same component yet 
because the framework needs the new information from the new NAR plugin.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbende/nifi NIFI-3380

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1585


commit f965f87f3cd85ac160218f0308e4651d1e4363e0
Author: Bryan Bende 
Date:   2017-01-23T15:33:12Z

NIFI-3380 Bumping NAR plugin to 1.2.0-SNAPSHOT development to leverage 
changes from master, adding buildnumber-maven-plugin to nifi-nar-bundles to 
properly set build info in MANIFEST of NARs
- Refactoring NarDetails to include all info from MANIFEST
- Adding the concept of a Bundle and refactoring NarClassLoaders to pass 
Bundles to ExtensionManager
- Adding logic to fail start-up when multiple NARs with same coordinates 
exist, moving Bundle classes to framework API
- Refactoring bundle API to classes and creating BundleCoordinate
- Updating FlowController to use BundleCoordinate

commit 98216f00ec8ea0e8e113d7b1a5ad75db84b38bd6
Author: Matt Gilman 
Date:   2017-01-24T18:58:57Z

NIFI-3380: - Updating the UI and DTO model to support showing bundle 
details that loaded an extension type.
- Adding bundle details for processor canvas node, processor dialogs, 
controller service dialogs, and reporting task dialogs.
- Updating the formating of the bundle coordinates.
- Addressing text overflow in the configuration/details dialog.
- Fixing self referencing functions.
- Updating extension UI mapping to incorporate bundle coordinates.
- Discovering custom UIs through the supplied bundles.
- Adding verification methods for creating extensions through the rest api.
- Only returning extensions that are common amongst all nodes.
- Rendering the ghost processors using a dotted border.
- Adding bundle details to the flow.xml.
- Loading NiFi build and version details from the framework NAR.
- Removing properties for build and version details.
- Wiring together front end and back end changes.
- Including bundle coordinates in the component data model.
- Wiring together component data model and flow.xml.
- Addressing issue when resolve unvesioned dependent NARs.

commit 95cf4007b6c16f73305fad9f2ff8ed66b0794b0d
Author: Bryan Bende 
Date:   2017-01-31T17:05:40Z

NIFI-3380 Updating unit tests to pass based on framework changes
- Fixing logging of extension types during start up

commit e1782b13c71b7897a7b5105012fd2a687c9c9961
Author: Matt Gilman 
Date:   2017-02-02T21:09:45Z

NIFI-3380: - Allowing the application to start if there is a compatible 
bundle found. - Reporting missing bundle when the a compatible bundle is not 
found. - Fixing table height in new component dialogs.

commit 4b188857f59fe85ca38303b0b20448867072e18d
Author: Bryan Bende 
Date:   2017-02-03T14:39:38Z

NIFI-3380 Fixing chechstyle error and increasing test timeout for 
TestStandardControllerServiceProvider
- Adding ability to change processor type at runtime
- Adding backend code to change type for controller services

commit d71ba9d33c811d0eee3a29378c7048b5443957aa
Author: Matt Gilman 
Date:   2017-02-09T18:58:59Z

NIFI-3380:
- Cleaning up instance classloaders for temp components.
- Creating a dialog for changing the version of a component.
- Updating the formatting of the component type and bundle throughout.
- Updating the new component dialogs to support selecting source group.
- Cleaning up new component dialogs.
- Cleaning up documentation in the cluster node endpoint.

commit 8892c4a64f861ac98c6cac9370298cda444e0da8
Author: Bryan Bende 
Date:   2017-02-09T20:07:20Z

NIFI-3380 Adding missing include in nifi-web-ui pom compressor