[jira] [Commented] (NIFI-5155) Bulletins do not include IP/hostname information
[ https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515702#comment-16515702 ] ASF GitHub Bot commented on NIFI-5155: -- Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2773 @markap14 How would we get at the value in NiFiProperties? They're not readily available from the FlowController (nor is the FlowController interface itself IIRC). Perhaps we call a static method on BulletinFactory? Agreed about storing away getHostAddress(), that was a hasty copy-pasty :) > Bulletins do not include IP/hostname information > > > Key: NIFI-5155 > URL: https://issues.apache.org/jira/browse/NIFI-5155 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > > There is an API call on Bulletin for setNodeAddress(), which is meant to set > the node on which a bulletin/error has occurred. The > SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to > the outgoing records (if available). However, the framework is not calling > setNodeAddress() anywhere, which results in the field being missing from the > outgoing records. > NiFi should add the appropriate node address information to the outgoing > bulletin information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5155) Bulletins do not include IP/hostname information
[ https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508230#comment-16508230 ] ASF GitHub Bot commented on NIFI-5155: -- Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2773 @mattyb149 I think this makes sense but have a couple of thoughts on the PR: - Probably should use the value set in NiFiProperties for the http/https hostname if it is populated. This would be more consistent with the value provided to the Cluster Coordinator and also is better for multi-homed environments. - If not available, I would do the `InetAddress.getLocalHost().getHostAddress()` address only once and stash away that value in a `final` member variable rather than performing the lookup for each Bulletin that is created. > Bulletins do not include IP/hostname information > > > Key: NIFI-5155 > URL: https://issues.apache.org/jira/browse/NIFI-5155 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > > There is an API call on Bulletin for setNodeAddress(), which is meant to set > the node on which a bulletin/error has occurred. The > SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to > the outgoing records (if available). However, the framework is not calling > setNodeAddress() anywhere, which results in the field being missing from the > outgoing records. > NiFi should add the appropriate node address information to the outgoing > bulletin information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5155) Bulletins do not include IP/hostname information
[ https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508112#comment-16508112 ] ASF GitHub Bot commented on NIFI-5155: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2773 @zenfenan Correct. The cluster coordinator handles setting the node address for the bulletins that are returned through the REST API. However, those are not the same objects that are available in the `SiteToSiteBulletinReportingTask`. I wasn't considering this in my previous response. > Bulletins do not include IP/hostname information > > > Key: NIFI-5155 > URL: https://issues.apache.org/jira/browse/NIFI-5155 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > > There is an API call on Bulletin for setNodeAddress(), which is meant to set > the node on which a bulletin/error has occurred. The > SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to > the outgoing records (if available). However, the framework is not calling > setNodeAddress() anywhere, which results in the field being missing from the > outgoing records. > NiFi should add the appropriate node address information to the outgoing > bulletin information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5155) Bulletins do not include IP/hostname information
[ https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506845#comment-16506845 ] ASF GitHub Bot commented on NIFI-5155: -- Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2773 @mcgilman Are you saying regardless of the `setNodeAddress` API not setting anything, the cluster coordinator takes care of populating it ? > Bulletins do not include IP/hostname information > > > Key: NIFI-5155 > URL: https://issues.apache.org/jira/browse/NIFI-5155 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > > There is an API call on Bulletin for setNodeAddress(), which is meant to set > the node on which a bulletin/error has occurred. The > SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to > the outgoing records (if available). However, the framework is not calling > setNodeAddress() anywhere, which results in the field being missing from the > outgoing records. > NiFi should add the appropriate node address information to the outgoing > bulletin information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5155) Bulletins do not include IP/hostname information
[ https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506052#comment-16506052 ] ASF GitHub Bot commented on NIFI-5155: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2773 I'm not exactly sure why the Bulletin itself has a `nodeAddress` field. However, I can offer that the corresponding BulletinDTO contains a `nodeAddress` to help differentiate between which node in the cluster is reporting the message. This is populated when the responses are merged at the cluster coordinator. In standalone mode, there is only a single instance so this field does not need to be populated. This is also how component `validationErrors` work. > Bulletins do not include IP/hostname information > > > Key: NIFI-5155 > URL: https://issues.apache.org/jira/browse/NIFI-5155 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > > There is an API call on Bulletin for setNodeAddress(), which is meant to set > the node on which a bulletin/error has occurred. The > SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to > the outgoing records (if available). However, the framework is not calling > setNodeAddress() anywhere, which results in the field being missing from the > outgoing records. > NiFi should add the appropriate node address information to the outgoing > bulletin information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5155) Bulletins do not include IP/hostname information
[ https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505754#comment-16505754 ] ASF GitHub Bot commented on NIFI-5155: -- Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2773 I'm not entirely sure if this poses an immediate threat, but in the future when other extensions try to use the `getNodeAddress()` API, it might possibly be an issue, especially on the user experience perspective i.e. chances of the user getting confused when all the bulletins print 127.0.0.1 are there, IMO. For the workaround, this feels like a good approach: https://stackoverflow.com/a/28346117 > Bulletins do not include IP/hostname information > > > Key: NIFI-5155 > URL: https://issues.apache.org/jira/browse/NIFI-5155 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > > There is an API call on Bulletin for setNodeAddress(), which is meant to set > the node on which a bulletin/error has occurred. The > SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to > the outgoing records (if available). However, the framework is not calling > setNodeAddress() anywhere, which results in the field being missing from the > outgoing records. > NiFi should add the appropriate node address information to the outgoing > bulletin information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5155) Bulletins do not include IP/hostname information
[ https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505635#comment-16505635 ] ASF GitHub Bot commented on NIFI-5155: -- Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2773 @zenfenan Good point. The reporting tasks haven't had this information available before, is this a "no-harm-no-foul" thing, and if not, how should it be handled? > Bulletins do not include IP/hostname information > > > Key: NIFI-5155 > URL: https://issues.apache.org/jira/browse/NIFI-5155 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > > There is an API call on Bulletin for setNodeAddress(), which is meant to set > the node on which a bulletin/error has occurred. The > SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to > the outgoing records (if available). However, the framework is not calling > setNodeAddress() anywhere, which results in the field being missing from the > outgoing records. > NiFi should add the appropriate node address information to the outgoing > bulletin information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5155) Bulletins do not include IP/hostname information
[ https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505506#comment-16505506 ] ASF GitHub Bot commented on NIFI-5155: -- GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/2773 NIFI-5155: Add host address info to bulletins Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI-5155 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2773.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2773 commit 2780f0218f60213ca6e85a32566d470cd51139fc Author: Matthew Burgess Date: 2018-06-07T23:37:19Z NIFI-5155: Add host address info to bulletins > Bulletins do not include IP/hostname information > > > Key: NIFI-5155 > URL: https://issues.apache.org/jira/browse/NIFI-5155 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > > There is an API call on Bulletin for setNodeAddress(), which is meant to set > the node on which a bulletin/error has occurred. The > SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to > the outgoing records (if available). However, the framework is not calling > setNodeAddress() anywhere, which results in the field being missing from the > outgoing records. > NiFi should add the appropriate node address information to the outgoing > bulletin information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5155) Bulletins do not include IP/hostname information
[ https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465915#comment-16465915 ] Josh Nicholson commented on NIFI-5155: -- [~sivaprasanna] As a user, it would be nice to also have the hostname be added for ease of use. In my case, I'm needing this for a flow I'm using to monitor disk usage within the NiFi cluster, as I am needing the hostname to easily distinguish which host is throwing the alert. > Bulletins do not include IP/hostname information > > > Key: NIFI-5155 > URL: https://issues.apache.org/jira/browse/NIFI-5155 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Matt Burgess >Priority: Major > > There is an API call on Bulletin for setNodeAddress(), which is meant to set > the node on which a bulletin/error has occurred. The > SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to > the outgoing records (if available). However, the framework is not calling > setNodeAddress() anywhere, which results in the field being missing from the > outgoing records. > NiFi should add the appropriate node address information to the outgoing > bulletin information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5155) Bulletins do not include IP/hostname information
[ https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464779#comment-16464779 ] Sivaprasanna Sethuraman commented on NIFI-5155: --- [~mattyb149] Yeah. A quick glance on the BulletinFactory reveals none of the createBulletin method never receives the hostname/IP as an argument and thus doesn't call the setNodeAddress(). I think, the createBulletin() doesn't need to receive the hostname/IP as an argument, rather those methods can simply get the IP using Java APIs and then set them using setNodeAddress(). Thoughts? > Bulletins do not include IP/hostname information > > > Key: NIFI-5155 > URL: https://issues.apache.org/jira/browse/NIFI-5155 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Matt Burgess >Priority: Major > > There is an API call on Bulletin for setNodeAddress(), which is meant to set > the node on which a bulletin/error has occurred. The > SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to > the outgoing records (if available). However, the framework is not calling > setNodeAddress() anywhere, which results in the field being missing from the > outgoing records. > NiFi should add the appropriate node address information to the outgoing > bulletin information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
