[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2023-01-03 Thread GitBox
exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1370171923 The latest PR build appears to be working as expected, it sounds like the other issues were unrelated intermittent failures. -- This is an automated message from the Apache Git

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364408883 > What did you have in mind for implementing a literal null as a function argument? I only question if it is more clearer than specifying to users to use an empty string which we

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364267630 Thanks for the reply @dan-s1. As you observed, the Expression Language parser does not support a literal `null` as a function argument. It would take a bit more work, but it

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-12-23 Thread GitBox
exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364167903 Thanks for clarifying the intent @dan-s1, constructing the complete URI in a single function makes sense. With that background, do you need all of the possible constructor

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-11-21 Thread GitBox
exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1322758227 Thanks the contribution @dan-s1, the general approach makes sense on a cursory review, but I would like to take a closer look, so I don't think this will make it in to 1.19.0. --