exceptionfactory commented on PR #6689: URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364267630
Thanks for the reply @dan-s1. As you observed, the Expression Language parser does not support a literal `null` as a function argument. It would take a bit more work, but it seems worth evaluating what it would take to support a literal `null` argument for `getUri`. It seems like it could be scoped to this function. For `getUri` itself, there does not seem to be much value in the three-argument non-hierarchical option for `mailto` and similar links. This could be added later, but I think it makes more sense to focus on the hierarchical URI constructors unless you have a specific use case in mind for non-hierarchical URIs. For hierarchical URIs, the four and five argument constructors appear to fall into the convenience category. For simplicity of the initial implementation, what do you think of limiting the implementation to the seven argument constructor? Although it is the most verbose, it provides the clearest implementation for documentation and usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
