[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #824: MINIFICPP-1256 - Apply fixes recommended by modernize-equals-default clang tidy check

2020-06-29 Thread GitBox
hunyadi-dev commented on a change in pull request #824: URL: https://github.com/apache/nifi-minifi-cpp/pull/824#discussion_r446839898 ## File path: libminifi/include/core/state/UpdatePolicy.h ## @@ -69,11 +69,9 @@ class UpdatePolicy { } protected: - explicit UpdatePolic

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #824: MINIFICPP-1256 - Apply fixes recommended by modernize-equals-default clang tidy check

2020-06-26 Thread GitBox
hunyadi-dev commented on a change in pull request #824: URL: https://github.com/apache/nifi-minifi-cpp/pull/824#discussion_r446232265 ## File path: extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp ## @@ -159,8 +159,7 @@ SourceInitiatedSubscriptionListen

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #824: MINIFICPP-1256 - Apply fixes recommended by modernize-equals-default clang tidy check

2020-06-26 Thread GitBox
hunyadi-dev commented on a change in pull request #824: URL: https://github.com/apache/nifi-minifi-cpp/pull/824#discussion_r446232208 ## File path: extensions/jni/jvm/JavaClass.h ## @@ -46,9 +46,7 @@ class JavaClass { public: JavaClass() - : class_ref_(nullptr) { -

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #824: MINIFICPP-1256 - Apply fixes recommended by modernize-equals-default clang tidy check

2020-06-26 Thread GitBox
hunyadi-dev commented on a change in pull request #824: URL: https://github.com/apache/nifi-minifi-cpp/pull/824#discussion_r446232077 ## File path: extensions/jni/jvm/JniProcessContext.h ## @@ -39,8 +39,7 @@ struct JniProcessContext { : nifi_processor_(nullptr),