szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r509157469
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool ope
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508708537
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool ope
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508697986
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool ope
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507815133
##
File path: libminifi/include/utils/SmallString.h
##
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507814242
##
File path: libminifi/src/core/ProcessSession.cpp
##
@@ -66,10 +66,12 @@ ProcessSession::~ProcessSession() {
}
void ProcessSession::add(const s
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507780131
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool ope
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507750504
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool ope
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507726059
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool ope