[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

szaszm commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1301432620 ## libminifi/include/utils/net/AsioSocketUtils.h: ## @@ -89,28 +94,71 @@ class AsioSocketConnection : public io::BaseStream { } private: +#ifndef WIN32

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

szaszm commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1301254315 ## libminifi/include/utils/net/AsioSocketUtils.h: ## @@ -63,6 +64,64 @@ asio::awaitable> handshake(SslSocket& socket, asio:: asio::ssl::context

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

szaszm commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1301181584 ## libminifi/include/utils/net/AsioSocketUtils.h: ## @@ -63,6 +64,64 @@ asio::awaitable> handshake(SslSocket& socket, asio:: asio::ssl::context

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

szaszm commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1280944175 ## libminifi/include/core/state/nodes/DeviceInformation.h: ## Review Comment: It would be nice to move the logic to the .cpp file, and avoid polluting

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

szaszm commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1280939992 ## libminifi/src/utils/net/DNS.cpp: ## @@ -127,4 +69,9 @@ nonstd::expected reverseDnsLookup(const asio::ip:: return results->host_name(); } +std::string

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

szaszm commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1279683509 ## libminifi/include/utils/net/Socket.h: ## Review Comment: `get_last_socket_error` doesn't seem to be used outside of `Socket.cpp` anymore. Maybe it