szaszm commented on code in PR #1599:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1280939992
##########
libminifi/src/utils/net/DNS.cpp:
##########
@@ -127,4 +69,9 @@ nonstd::expected<std::string, std::error_code>
reverseDnsLookup(const asio::ip::
return results->host_name();
}
+std::string getMyHostName() {
+ static const std::string HOSTNAME = asio::ip::host_name();
+ return HOSTNAME;
+}
Review Comment:
Hostname can change at runtime. On Linux, you can use the `hostname` command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
