Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1108
@joewitt when you have time can you have a final look on this one? LGTM and
I am happy to address the two remaining cosmetic comments as part of a separate
PR.
---
If your project is set up
Github user selim-namsi commented on the issue:
https://github.com/apache/nifi/pull/1108
@trixpan @joewitt Sorry for the long delay, I applied the changes that you
suggested such as, adding the custom validator in the processor class, use the
new version of grok and removing the
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1108
Looks like there are new merge issues, do you mind rebasing against the
latest master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user selim-namsi commented on the issue:
https://github.com/apache/nifi/pull/1108
@trixpan @markap14 I pushed the new changes.
Could you please check the changes ?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1108
@selim-namsi - good work. We are getting there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user selim-namsi commented on the issue:
https://github.com/apache/nifi/pull/1108
@markap14 Thanks for all this suggestions, I'll update the code ASAP and
push the changes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1108
@selim-namsi Thanks for contributing this! I have actually been very
interested in using NiFi to do some log parsing but hadn't really dug in very
much to understand the best way to go about it.
Github user selim-namsi commented on the issue:
https://github.com/apache/nifi/pull/1108
@trixpan I figured out how to rebase the pull request :)
Cheers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user selim-namsi commented on the issue:
https://github.com/apache/nifi/pull/1108
@trixpan could you please tell me how to rebase a PR ? I rebased my
[branch](https://github.com/selim-namsi/nifi/commits/nifi-2565) but I didn't
find how to rebase the PR.
sorry for the
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1108
Please rebase this PR so it only include your changes.
Cheers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1108
By the way, most of these modifications are already available here:
https://github.com/trixpan/nifi/commits/NIFI-2565
---
If your project is set up for it, you can reply to this email and
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1108
You can certainly include a file with the default patterns, however you
should not hardcode them. By hardcoding them you prevent the user from
optimising for speed by removing unused patterns from
Github user selim-namsi commented on the issue:
https://github.com/apache/nifi/pull/1108
@trixpan Thank you for all this useful feedback, I'll start working on
these modifications.
For the patterns, I hard coded the patterns because I was thinking about
adding by default some
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1108
@selim-namsi thanks for putting together. I was coding this processor but
happy to review it.
Few comments:
1. Your code is failing -Pcontrib-check. Can you please fix this?
14 matches
Mail list logo
