[GitHub] nifi issue #2166: NIFI-4395 - GenerateTableFetch can't fetch column type by ...

2017-09-22 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2166 The unit test doesn't pass when this PR is rebased against master, due to [NIFI-3484](https://issues.apache.org/jira/browse/NIFI-3484). I can fix this when I merge. +1 LGTM, verified

[GitHub] nifi issue #2166: NIFI-4395 - GenerateTableFetch can't fetch column type by ...

2017-09-21 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/2166 Thanks for the detail comment and suggestion. That helps me a lot. Some fix by suggestion like. 1 - put back StringmaxValueColumnNames to GenerateTableFetch to avoid NPE unit test

[GitHub] nifi issue #2166: NIFI-4395 - GenerateTableFetch can't fetch column type by ...

2017-09-21 Thread paulgibeault
Github user paulgibeault commented on the issue: https://github.com/apache/nifi/pull/2166 @ijokarumawak Thank you for the quick review. We will get right on these changes and resubmit. ---

[GitHub] nifi issue #2166: NIFI-4395 - GenerateTableFetch can't fetch column type by ...

2017-09-21 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2166 Hey @yjhyjhyjh0 - Don't worry about the CI builds - it has been failing for a while now. We should really find the reason why and fix it... but I didn't look into it yet. Regarding your PR, I

[GitHub] nifi issue #2166: NIFI-4395 - GenerateTableFetch can't fetch column type by ...

2017-09-21 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/2166 Not quite understand result from travis-ci. Seems it stuck at ANTLR Parser AttributeExpressionParser every time? ---

[GitHub] nifi issue #2166: NIFI-4395 - GenerateTableFetch can't fetch column type by ...

2017-09-21 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/2166 I've solved this issue by re-cache column type if needed and pass local unit and instance test. The root cause of this issue is that originally disign didn't recognize that column type