[GitHub] nifi issue #2467: NIFI-4862 Add Copy original attributtes to SelectHiveQL pr...

2018-04-09 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2467 Hi @jles01 , as I wrote on the Apache JIRA [NIFI-4862](https://issues.apache.org/jira/browse/NIFI-4862), Matt's PR has been merged in order to achieve the same goal with yours. Would you check

[GitHub] nifi issue #2467: NIFI-4862 Add Copy original attributtes to SelectHiveQL pr...

2018-04-02 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2467 It doesn't look like this branch was successfully rebased against the latest master, can you try to rebase such that only your new commits show up in the PR? If all else fails, you can create a

[GitHub] nifi issue #2467: NIFI-4862 Add Copy original attributtes to SelectHiveQL pr...

2018-02-27 Thread jles01
Github user jles01 commented on the issue: https://github.com/apache/nifi/pull/2467 Hi, I follwed your guidelines and corrected the problems which you highlighted. Best regards, Jakub ---

[GitHub] nifi issue #2467: NIFI-4862 Add Copy original attributtes to SelectHiveQL pr...

2018-02-13 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2467 Thanks for your first contribution to Apache NiFi. I have made some inline comments on the code. Please also add a unit test covering the new functionality you added. You can see existing unit