Re: [PR] NIFI-12211: add Validator.VALID to username/password on TinkerpopClientService [nifi]
asfgit closed pull request #7868: NIFI-12211: add Validator.VALID to username/password on TinkerpopClientService URL: https://github.com/apache/nifi/pull/7868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12211: add Validator.VALID to username/password on TinkerpopClientService [nifi]
ChrisSamo632 commented on code in PR #7868: URL: https://github.com/apache/nifi/pull/7868#discussion_r1355627921 ## nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java: ## @@ -167,6 +167,7 @@ public class TinkerpopClientService extends AbstractControllerService implements " Note: when using a remote.yaml file, this username value (if set) will overload any " + "username set in the YAML file.") .required(false) +.addValidator(Validator.VALID) Review Comment: Seems like `StandardValidators.ATTRIBUTE_EXPRESSION_LANGUAGE_VALIDATOR` or `StandardValidators.NON_EMPTY_VALIDATOR` would be better for these properties - this allows them to remain optional, but prevents empty values being set, which is probably not valid -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12211: add Validator.VALID to username/password on TinkerpopClientService [nifi]
levilentz opened a new pull request, #7868: URL: https://github.com/apache/nifi/pull/7868 # Summary This fixes a bug that was introduced in https://github.com/apache/nifi/pull/7677 [NIFI-12211](https://issues.apache.org/jira/browse/NIFI-12211) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [X] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [X] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [X] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
