Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
lhotari commented on PR #35: URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-1944190302 It would be nice to have a release where this is included. It would help the Apache Pulsar build too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
asfgit closed pull request #35: NIFI-12226: Add flag to skip doc generation URL: https://github.com/apache/nifi-maven/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
mattyb149 commented on PR #35: URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-1767342297 +1 on this PR from me, I can merge unless @nandorsoma wants to :) @nicoloboschi is this the only feature of NiFi that LangStream uses? For LangStream and Pulsar, is it the metadata and/or approach to classloader isolation that makes the NAR format useful? If so I definitely think we should we refactor this to be a generic "extension packager" or something and publish it as such (as @nandorsoma suggested), and we can add NiFi-specific stuff for the NiFi plugin and publish that too. If we want to get fancy we can accept extensions for doc generation (so it's not NiFi-specific) and even the supported annotations (to make it even more flexible). That's quite a bit of work though, I'd tackle it in my spare time but that's pretty sparse these days. Would be happy to review a "Feature Proposal" on the [wiki](https://cwiki.apache.org/confluence/display/NIFI/NiFi+Feature+Proposals) if someone wanted to put up a requirements and/or design document. For the "different context" to which Soma is referring, stay tuned and keep an eye on that Feature Proposals page ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
nicoloboschi commented on PR #35: URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-1766328766 @nandorsoma It's widely used also in Apache Pulsar for distributing connectors that run over Pulsar IO. https://pulsar.apache.org/docs/next/functions-package-java/#package-as-nar The documentation part is useless in Pulsar too so this change improves the build time there too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
nicoloboschi commented on PR #35: URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-1761300835 > Do you mind filing a NIFI JIRA for this change? done https://issues.apache.org/jira/browse/NIFI-12226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
