codecov-commenter edited a comment on pull request #5110:
URL: https://github.com/apache/openwhisk/pull/5110#issuecomment-834316259
#
codecov-commenter edited a comment on pull request #5110:
URL: https://github.com/apache/openwhisk/pull/5110#issuecomment-834316259
#
codecov-commenter edited a comment on pull request #5110:
URL: https://github.com/apache/openwhisk/pull/5110#issuecomment-834316259
#
style95 commented on a change in pull request #4058:
URL: https://github.com/apache/openwhisk/pull/4058#discussion_r639393933
##
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskAction.scala
##
@@ -351,6 +361,49 @@ object WhiskAction extends
frankfurtmacmoses commented on issue #5108:
URL: https://github.com/apache/openwhisk/issues/5108#issuecomment-848433168
Can you please help. I can't seem to be able to resolve this issue in four
days. I am getting the same error as above
--
This is an automated message from the
jiangpengcheng commented on pull request #4058:
URL: https://github.com/apache/openwhisk/pull/4058#issuecomment-848429860
one of my thought is that there is no need to add permissions controls for
action's "owner" since he/she can anyway update/remove/invoke his/her action
--
This is an
jiangpengcheng commented on a change in pull request #4058:
URL: https://github.com/apache/openwhisk/pull/4058#discussion_r639377253
##
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala
##
@@ -231,6 +234,157 @@ protected[core]
jiangpengcheng commented on a change in pull request #4058:
URL: https://github.com/apache/openwhisk/pull/4058#discussion_r639375736
##
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala
##
@@ -231,6 +234,157 @@ protected[core]
jiangpengcheng commented on a change in pull request #4058:
URL: https://github.com/apache/openwhisk/pull/4058#discussion_r639375466
##
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala
##
@@ -231,6 +234,157 @@ protected[core]
jiangpengcheng commented on a change in pull request #4058:
URL: https://github.com/apache/openwhisk/pull/4058#discussion_r639368738
##
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskAction.scala
##
@@ -351,6 +361,49 @@ object WhiskAction extends
jiangpengcheng commented on a change in pull request #4058:
URL: https://github.com/apache/openwhisk/pull/4058#discussion_r639368487
##
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskAction.scala
##
@@ -351,6 +361,49 @@ object WhiskAction extends
codecov-commenter edited a comment on pull request #5111:
URL: https://github.com/apache/openwhisk/pull/5111#issuecomment-838112791
#
codecov-commenter edited a comment on pull request #5111:
URL: https://github.com/apache/openwhisk/pull/5111#issuecomment-838112791
#
codecov-commenter edited a comment on pull request #5111:
URL: https://github.com/apache/openwhisk/pull/5111#issuecomment-838112791
#
codecov-commenter edited a comment on pull request #5110:
URL: https://github.com/apache/openwhisk/pull/5110#issuecomment-834316259
#
codecov-commenter edited a comment on pull request #5110:
URL: https://github.com/apache/openwhisk/pull/5110#issuecomment-834316259
#
codecov-commenter edited a comment on pull request #5110:
URL: https://github.com/apache/openwhisk/pull/5110#issuecomment-834316259
#
ningyougang commented on a change in pull request #5113:
URL: https://github.com/apache/openwhisk/pull/5113#discussion_r639344985
##
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesClient.scala
##
@@ -139,9 +139,11 @@ class
codecov-commenter edited a comment on pull request #5113:
URL: https://github.com/apache/openwhisk/pull/5113#issuecomment-840280988
#
style95 merged pull request #5074:
URL: https://github.com/apache/openwhisk/pull/5074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ningyougang commented on pull request #5113:
URL: https://github.com/apache/openwhisk/pull/5113#issuecomment-848385349
I think it is ready to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
codecov-commenter edited a comment on pull request #5113:
URL: https://github.com/apache/openwhisk/pull/5113#issuecomment-840280988
#
dgrove-oss edited a comment on pull request #485:
URL: https://github.com/apache/openwhisk-website/pull/485#issuecomment-847972110
right. that's why I made the minimal change to just label the graph
correctly and didn't touch anything else. The mislabeled graph was giving a
bad
dgrove-oss commented on pull request #485:
URL: https://github.com/apache/openwhisk-website/pull/485#issuecomment-847972110
right. that's why I made the minimal change to just label the graph
correctly and didn't touch anything else. The graph was giving a bad
impression, but having a
mrutkows commented on pull request #485:
URL: https://github.com/apache/openwhisk-website/pull/485#issuecomment-847948561
@here I was hoping to establish a new section of which the graph would be
one part ...
--
This is an automated message from the Apache Git Service.
To respond to the
rabbah commented on a change in pull request #485:
URL: https://github.com/apache/openwhisk-website/pull/485#discussion_r638843416
##
File path: _layouts/community.html
##
@@ -305,7 +305,7 @@ Project Wiki
Contributions
Review comment:
What about also
dgrove-oss commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638757828
##
File path: ansible/README.md
##
@@ -196,6 +196,42 @@ ansible-playbook -i environments/$ENVIRONMENT routemgmt.yml
- To use the API Gateway,
dgrove-oss merged pull request #322:
URL: https://github.com/apache/openwhisk-catalog/pull/322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
dgrove-oss merged pull request #485:
URL: https://github.com/apache/openwhisk-website/pull/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
codecov-commenter edited a comment on pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#issuecomment-822206043
#
codecov-commenter edited a comment on pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#issuecomment-822206043
#
codecov-commenter edited a comment on pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#issuecomment-822206043
#
codecov-commenter edited a comment on pull request #5113:
URL: https://github.com/apache/openwhisk/pull/5113#issuecomment-840280988
#
codecov-commenter edited a comment on pull request #5116:
URL: https://github.com/apache/openwhisk/pull/5116#issuecomment-847479803
#
codecov-commenter edited a comment on pull request #5116:
URL: https://github.com/apache/openwhisk/pull/5116#issuecomment-847479803
#
codecov-commenter edited a comment on pull request #5113:
URL: https://github.com/apache/openwhisk/pull/5113#issuecomment-840280988
#
codecov-commenter edited a comment on pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#issuecomment-822206043
#
style95 commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638638615
##
File path: ansible/roles/controller/tasks/deploy.yml
##
@@ -292,6 +292,19 @@
env: "{{ env | combine(elastic_env) }}"
when:
jiangpengcheng commented on a change in pull request #5116:
URL: https://github.com/apache/openwhisk/pull/5116#discussion_r638610238
##
File path:
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/CreationJobManager.scala
##
@@ -0,0 +1,268 @@
+/*
+ *
jiangpengcheng commented on a change in pull request #5116:
URL: https://github.com/apache/openwhisk/pull/5116#discussion_r638609940
##
File path:
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/CreationJobManager.scala
##
@@ -0,0 +1,268 @@
+/*
+ *
jiangpengcheng commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638605116
##
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/database/mongodb/MongoDBArtifactStore.scala
##
@@ -0,0 +1,661 @@
+/*
+ *
jiangpengcheng commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638604607
##
File path: ansible/roles/controller/tasks/deploy.yml
##
@@ -292,6 +292,19 @@
env: "{{ env | combine(elastic_env) }}"
when:
jiangpengcheng commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638598843
##
File path: ansible/README.md
##
@@ -196,6 +196,42 @@ ansible-playbook -i environments/$ENVIRONMENT routemgmt.yml
- To use the API Gateway,
style95 commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638599531
##
File path: ansible/roles/controller/tasks/deploy.yml
##
@@ -292,6 +292,19 @@
env: "{{ env | combine(elastic_env) }}"
when:
jiangpengcheng commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638598843
##
File path: ansible/README.md
##
@@ -196,6 +196,42 @@ ansible-playbook -i environments/$ENVIRONMENT routemgmt.yml
- To use the API Gateway,
jiangpengcheng commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638594384
##
File path: ansible/roles/controller/tasks/deploy.yml
##
@@ -292,6 +292,19 @@
env: "{{ env | combine(elastic_env) }}"
when:
ningyougang commented on pull request #5116:
URL: https://github.com/apache/openwhisk/pull/5116#issuecomment-847685819
LGTM with some small suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ningyougang commented on a change in pull request #5116:
URL: https://github.com/apache/openwhisk/pull/5116#discussion_r638590570
##
File path:
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/CreationJobManager.scala
##
@@ -0,0 +1,268 @@
+/*
+ *
ningyougang commented on a change in pull request #5116:
URL: https://github.com/apache/openwhisk/pull/5116#discussion_r638587620
##
File path:
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/CreationJobManager.scala
##
@@ -0,0 +1,268 @@
+/*
+ *
codecov-commenter edited a comment on pull request #5074:
URL: https://github.com/apache/openwhisk/pull/5074#issuecomment-834018480
#
codecov-commenter edited a comment on pull request #5074:
URL: https://github.com/apache/openwhisk/pull/5074#issuecomment-834018480
#
codecov-commenter edited a comment on pull request #5074:
URL: https://github.com/apache/openwhisk/pull/5074#issuecomment-834018480
#
codecov-commenter edited a comment on pull request #5074:
URL: https://github.com/apache/openwhisk/pull/5074#issuecomment-834018480
#
style95 commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638506913
##
File path: ansible/README.md
##
@@ -196,6 +196,42 @@ ansible-playbook -i environments/$ENVIRONMENT routemgmt.yml
- To use the API Gateway, you'll
codecov-commenter edited a comment on pull request #5116:
URL: https://github.com/apache/openwhisk/pull/5116#issuecomment-847479803
#
jiangpengcheng commented on a change in pull request #4963:
URL: https://github.com/apache/openwhisk/pull/4963#discussion_r638494150
##
File path: ansible/README.md
##
@@ -196,6 +196,42 @@ ansible-playbook -i environments/$ENVIRONMENT routemgmt.yml
- To use the API Gateway,
56 matches
Mail list logo