[GitHub] akrabat commented on issue #253: Api v2 management allows swagger config to have basepath and path both set to /

2017-08-03 Thread git
akrabat commented on issue #253: Api v2 management allows swagger config to have basepath and path both set to / URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/253#issuecomment-320163023 FWiW, I would like this to work. I can't remember the last time I created an

[GitHub] Katiyman commented on issue #2221: Unable to create trigger

2017-08-03 Thread git
Katiyman commented on issue #2221: Unable to create trigger URL: https://github.com/apache/incubator-openwhisk/issues/2221#issuecomment-320161921 @hsane2001 Actually we need not expose it as the ENV variable but rather in each command in the Dockerfile then this will not be the issue.

[GitHub] dubeejw commented on issue #2491: Limit length of HTTP body displayed when debugging.

2017-08-03 Thread git
dubeejw commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320141678 @bpoole16, how about doing it this way?

[GitHub] dubeejw commented on issue #2491: Limit length of HTTP body displayed when debugging.

2017-08-03 Thread git
dubeejw commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320141678 @bpoole16, how about doing it this way?

[GitHub] dubeejw commented on issue #2491: Limit length of HTTP body displayed when debugging.

2017-08-03 Thread git
dubeejw commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320141678 @bpoole16, how about doing it this way?

[GitHub] rabbah commented on issue #2517: Support client certificate verify on server side

2017-08-03 Thread git
rabbah commented on issue #2517: Support client certificate verify on server side URL: https://github.com/apache/incubator-openwhisk/pull/2517#issuecomment-320134974 Oops. I meant CLA https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md

[GitHub] ningyougang commented on issue #2517: Support client certificate verify on server side

2017-08-03 Thread git
ningyougang commented on issue #2517: Support client certificate verify on server side URL: https://github.com/apache/incubator-openwhisk/pull/2517#issuecomment-320134074 @rabbah What's mean for `do you have an Apache SLA already on file`? I use `google` to search it, seems mean:

[GitHub] drcariel commented on issue #2547: CLI Experimental api removal

2017-08-03 Thread git
drcariel commented on issue #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#issuecomment-320122694 passing build: PG2~1904 This is an automated message from the Apache Git

[GitHub] rabbah opened a new issue #2573: CLI invalid subcommand returns status code zero

2017-08-03 Thread git
rabbah opened a new issue #2573: CLI invalid subcommand returns status code zero URL: https://github.com/apache/incubator-openwhisk/issues/2573 The error status is properly reported if the first command name is invalid. However, if an invalid subcommand is specified the returned status

[GitHub] paulcastro commented on issue #24: Doesn't build with Xcode 8.3.2

2017-08-03 Thread git
paulcastro commented on issue #24: Doesn't build with Xcode 8.3.2 URL: https://github.com/apache/incubator-openwhisk-xcode/issues/24#issuecomment-320116373 Those are the steps that worked for me. This is an automated

[GitHub] troyibm commented on issue #24: Doesn't build with Xcode 8.3.2

2017-08-03 Thread git
troyibm commented on issue #24: Doesn't build with Xcode 8.3.2 URL: https://github.com/apache/incubator-openwhisk-xcode/issues/24#issuecomment-320115934 so I could just download the 1.7 source zip, unzip into the incubator-openwhisk-xcode directory git clone created (change name of

[GitHub] paulcastro opened a new pull request #25: Add version number to ZipArchive in README

2017-08-03 Thread git
paulcastro opened a new pull request #25: Add version number to ZipArchive in README URL: https://github.com/apache/incubator-openwhisk-xcode/pull/25 wsktool will only build with ZipArchive 1.7. This should be noted in the README for people testing out this code.

[GitHub] paulcastro commented on issue #24: Doesn't build with Xcode 8.3.2

2017-08-03 Thread git
paulcastro commented on issue #24: Doesn't build with Xcode 8.3.2 URL: https://github.com/apache/incubator-openwhisk-xcode/issues/24#issuecomment-320109602 Yes, it does appear that ZipArchive has changed. I downloaded ZipArchive version 1.7 just now and I'm able to build wsktools.

[GitHub] dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320108470 If we want to provide the eval option, why not `eval "source wsk_cli_bash_completion.sh"` instead of the entire

[GitHub] dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320108470 If want want to provide the eval option, why not `eval "source wsk_cli_bash_completion.sh"` instead of the entire

[GitHub] dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320108470 If want want to provide the eval option, why not `eval "source wsk_cli_bash_completion.sh"` instead of the entire

[GitHub] troyibm commented on issue #24: Doesn't build with Xcode 8.3.2

2017-08-03 Thread git
troyibm commented on issue #24: Doesn't build with Xcode 8.3.2 URL: https://github.com/apache/incubator-openwhisk-xcode/issues/24#issuecomment-320106305 I also think things have changed in the ZipArchive project since the WhiskSwiftTools.xcproject file has been created as the aes and

[GitHub] mdeuser commented on issue #253: Api v2 management allows swagger config to have basepath and path both set to /

2017-08-03 Thread git
mdeuser commented on issue #253: Api v2 management allows swagger config to have basepath and path both set to / URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/253#issuecomment-320105916 If an API happens to be created with a basepath and path of `/` each,

[GitHub] rabbah commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
rabbah commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320105250 this is a _one_ time setup - while i haven't followed closely +1 to @dubeejw's points - feels like over engineering

[GitHub] dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320104496 Inclined to say that `wsk sdk install autobash` should work as it currently does. Meaning it saves the auto-complete

[GitHub] dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320104496 Inclined to say that `wsk sdk install autobash` should work as it currently does. Meaning it saves the auto-complete

[GitHub] dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320104496 Inclined to say that `wsk sdk install autobash` should work as it currently does. Meaning it saves the auto-complete

[GitHub] DanLavine commented on issue #46: Deploy CouchDB manually

2017-08-03 Thread git
DanLavine commented on issue #46: Deploy CouchDB manually URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/46#issuecomment-320102906 my updates to travis failed. Will fix those up This is an automated

[GitHub] dubeejw commented on issue #2491: Limit length of HTTP body displayed when debugging.

2017-08-03 Thread git
dubeejw commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320099090 What I noticed was that when I ran an action get for an action that has a big zip file attached to it, I still had to

[GitHub] ddragosd commented on a change in pull request #46: Deploy CouchDB manually

2017-08-03 Thread git
ddragosd commented on a change in pull request #46: Deploy CouchDB manually URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/46#discussion_r131268233 ## File path: kubernetes/couchdb/docker/init.sh ## @@ -18,6 +24,30 @@ pushd /openwhisk echo

[GitHub] DanLavine commented on a change in pull request #46: Deploy CouchDB manually

2017-08-03 Thread git
DanLavine commented on a change in pull request #46: Deploy CouchDB manually URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/46#discussion_r131268025 ## File path: kubernetes/couchdb/README.md ## @@ -10,23 +10,33 @@ Pod. This can be done by running:

[GitHub] ddragosd commented on a change in pull request #46: Deploy CouchDB manually

2017-08-03 Thread git
ddragosd commented on a change in pull request #46: Deploy CouchDB manually URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/46#discussion_r131267712 ## File path: kubernetes/couchdb/README.md ## @@ -10,23 +10,33 @@ Pod. This can be done by running:

[GitHub] rabbah commented on issue #2517: Support client certificate verify on server side

2017-08-03 Thread git
rabbah commented on issue #2517: Support client certificate verify on server side URL: https://github.com/apache/incubator-openwhisk/pull/2517#issuecomment-320094389 @ningyougang can you verify that you have an Apache SLA on file?

[GitHub] rabbah closed pull request #2556: Fix bug on set_fact relative ansible task

2017-08-03 Thread git
rabbah closed pull request #2556: Fix bug on set_fact relative ansible task URL: https://github.com/apache/incubator-openwhisk/pull/2556 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] csantanapr closed pull request #61: code coverage

2017-08-03 Thread git
csantanapr closed pull request #61: code coverage URL: https://github.com/apache/incubator-openwhisk-client-js/pull/61 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] aml2732 commented on issue #61: code coverage

2017-08-03 Thread git
aml2732 commented on issue #61: code coverage URL: https://github.com/apache/incubator-openwhisk-client-js/pull/61#issuecomment-320088490 ### Summary of changes: **@justin**: There isn't too much detail on nyc that I could google, however, I've made changes such that the status of

[GitHub] codecov-io commented on issue #61: code coverage

2017-08-03 Thread git
codecov-io commented on issue #61: code coverage URL: https://github.com/apache/incubator-openwhisk-client-js/pull/61#issuecomment-320079968 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/61?src=pr=h1) Report > :exclamation: No coverage uploaded for pull

[GitHub] aml2732 commented on issue #61: code coverage

2017-08-03 Thread git
aml2732 commented on issue #61: code coverage URL: https://github.com/apache/incubator-openwhisk-client-js/pull/61#issuecomment-320088490 ### Summary of changes: **@justin**: There isn't too much detail on nyc that I could google, however, I've made changes such that the status of

[GitHub] troyibm commented on issue #24: Doesn't build with Xcode 8.3.2

2017-08-03 Thread git
troyibm commented on issue #24: Doesn't build with Xcode 8.3.2 URL: https://github.com/apache/incubator-openwhisk-xcode/issues/24#issuecomment-320088283 I tried to follow your instructions here @paulcastro and got totally lost. I notice that ZipArchive can be pulled in via Carthage.

[GitHub] csantanapr closed pull request #2439: Set user agent header in API GW requests

2017-08-03 Thread git
csantanapr closed pull request #2439: Set user agent header in API GW requests URL: https://github.com/apache/incubator-openwhisk/pull/2439 This is an automated message from the Apache Git Service. To respond to the

[GitHub] spattewar commented on issue #2569: 1 million per second event processing using openwhisk ??

2017-08-03 Thread git
spattewar commented on issue #2569: 1 million per second event processing using openwhisk ?? URL: https://github.com/apache/incubator-openwhisk/issues/2569#issuecomment-320083712 @perryibm thanks for your reponse. At this point in time we are still installing openwhisk locally and

[GitHub] dnwe commented on a change in pull request #202: Produce action fixes

2017-08-03 Thread git
dnwe commented on a change in pull request #202: Produce action fixes URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/202#discussion_r131248585 ## File path: action/kafkaProduce.py ## @@ -18,46 +18,96 @@ */ """ -import ssl import base64 +import

[GitHub] dnwe commented on a change in pull request #202: Produce action fixes

2017-08-03 Thread git
dnwe commented on a change in pull request #202: Produce action fixes URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/202#discussion_r131249653 ## File path: action/messageHubProduce.py ## @@ -18,64 +18,97 @@ */ """ -import ssl import base64

[GitHub] dnwe commented on a change in pull request #202: Produce action fixes

2017-08-03 Thread git
dnwe commented on a change in pull request #202: Produce action fixes URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/202#discussion_r131248441 ## File path: action/kafkaProduce.py ## @@ -18,46 +18,96 @@ */ """ -import ssl import base64 +import

[GitHub] dnwe commented on a change in pull request #202: Produce action fixes

2017-08-03 Thread git
dnwe commented on a change in pull request #202: Produce action fixes URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/202#discussion_r131250004 ## File path: action/messageHubProduce.py ## @@ -108,3 +147,64 @@ def validateParams(params):

[GitHub] codecov-io commented on issue #61: code coverage

2017-08-03 Thread git
codecov-io commented on issue #61: code coverage URL: https://github.com/apache/incubator-openwhisk-client-js/pull/61#issuecomment-320079968 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/61?src=pr=h1) Report > :exclamation: No coverage uploaded for pull

[GitHub] bjustin-ibm commented on a change in pull request #199: Return Requested Accept Type on Trigger Delete

2017-08-03 Thread git
bjustin-ibm commented on a change in pull request #199: Return Requested Accept Type on Trigger Delete URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/199#discussion_r131247258 ## File path: action/kafkaFeedWeb.js ## @@ -70,7 +70,14 @@ function

[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.

2017-08-03 Thread git
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320075351 To me this issue has gotten too specific. It's now only limiting in verbose for a certain field in resp body for

[GitHub] bjustin-ibm commented on issue #202: Produce action fixes

2017-08-03 Thread git
bjustin-ibm commented on issue #202: Produce action fixes URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/202#issuecomment-320075356 @dnwe please review. This is an automated message from the Apache

[GitHub] bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging.

2017-08-03 Thread git
bpoole16 commented on issue #2491: Limit length of HTTP body displayed when debugging. URL: https://github.com/apache/incubator-openwhisk/pull/2491#issuecomment-320075351 To me this issue has gotten too specific. It's now only limiting in verbose for a certain field in resp body for

[GitHub] csantanapr closed pull request #209: exponential backoff on trigger fire retry

2017-08-03 Thread git
csantanapr closed pull request #209: exponential backoff on trigger fire retry URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/209 This is an automated message from the Apache Git Service. To respond

[GitHub] csantanapr closed issue #207: look into making backoff exponential vs. linear

2017-08-03 Thread git
csantanapr closed issue #207: look into making backoff exponential vs. linear URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/207 This is an automated message from the Apache Git Service. To respond

[GitHub] rabbah commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
rabbah commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320073133 lol - ok now i'm going to ask: what precipitated these changes - as in what's wrong with the current approach?

[GitHub] rabbah commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
rabbah commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320073133 lol - ok now i'm going to ask: what precipitated these changes - as in what's wrong with the current approach?

[GitHub] dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320073028 I still do not like that as soon as I close my terminal, the auto-completion will be removed.

[GitHub] dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
dubeejw commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320072334 Not sure I like or see the point of `wsk sdk install bashauto` printing the auto complete script to the terminal.

[GitHub] csantanapr closed pull request #2564: Remove old scripts and unused config parameters

2017-08-03 Thread git
csantanapr closed pull request #2564: Remove old scripts and unused config parameters URL: https://github.com/apache/incubator-openwhisk/pull/2564 This is an automated message from the Apache Git Service. To respond to the

[GitHub] bjustin-ibm commented on issue #209: exponential backoff on trigger fire retry

2017-08-03 Thread git
bjustin-ibm commented on issue #209: exponential backoff on trigger fire retry URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/209#issuecomment-320068583 @csantanapr please review/merge. This is an

[GitHub] bjustin-ibm commented on a change in pull request #209: exponential backoff on trigger fire retry

2017-08-03 Thread git
bjustin-ibm commented on a change in pull request #209: exponential backoff on trigger fire retry URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/209#discussion_r131239034 ## File path: provider/consumer.py ## @@ -371,10 +369,11 @@ def

[GitHub] bjustin-ibm commented on a change in pull request #209: exponential backoff on trigger fire retry

2017-08-03 Thread git
bjustin-ibm commented on a change in pull request #209: exponential backoff on trigger fire retry URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/209#discussion_r131238589 ## File path: provider/thedoctor.py ## @@ -27,7 +27,8 @@ class TheDoctor

[GitHub] rabbah commented on issue #2556: Fix bug on set_fact relative ansible task

2017-08-03 Thread git
rabbah commented on issue #2556: Fix bug on set_fact relative ansible task URL: https://github.com/apache/incubator-openwhisk/pull/2556#issuecomment-320036382 pg2/1?90?3 ? This is an automated message from the Apache Git

[GitHub] csantanapr opened a new issue #253: Api v2 management allows swagger config to have basepath and path both set to /

2017-08-03 Thread git
csantanapr opened a new issue #253: Api v2 management allows swagger config to have basepath and path both set to / URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/253 When creating a new api, a swagger is sent to api management with both base path and operation path

[GitHub] markusthoemmes commented on a change in pull request #2414: SPI approach for pluggable implementations

2017-08-03 Thread git
markusthoemmes commented on a change in pull request #2414: SPI approach for pluggable implementations URL: https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r131227995 ## File path: docs/spi.md ## @@ -0,0 +1,75 @@ +# SPI extensions in OpenWhisk +

[GitHub] markusthoemmes commented on a change in pull request #2414: SPI approach for pluggable implementations

2017-08-03 Thread git
markusthoemmes commented on a change in pull request #2414: SPI approach for pluggable implementations URL: https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r131227962 ## File path: docs/spi.md ## @@ -0,0 +1,75 @@ +# SPI extensions in OpenWhisk +

[GitHub] markusthoemmes commented on a change in pull request #2414: SPI approach for pluggable implementations

2017-08-03 Thread git
markusthoemmes commented on a change in pull request #2414: SPI approach for pluggable implementations URL: https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r131227929 ## File path: docs/spi.md ## @@ -0,0 +1,75 @@ +# SPI extensions in OpenWhisk +

[GitHub] markusthoemmes commented on a change in pull request #2414: SPI approach for pluggable implementations

2017-08-03 Thread git
markusthoemmes commented on a change in pull request #2414: SPI approach for pluggable implementations URL: https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r131227724 ## File path: docs/spi.md ## @@ -0,0 +1,75 @@ +# SPI extensions in OpenWhisk +

[GitHub] dubeejw commented on a change in pull request #209: exponential backoff on trigger fire retry

2017-08-03 Thread git
dubeejw commented on a change in pull request #209: exponential backoff on trigger fire retry URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/209#discussion_r131226642 ## File path: provider/thedoctor.py ## @@ -27,7 +27,8 @@ class TheDoctor

[GitHub] dubeejw commented on a change in pull request #209: exponential backoff on trigger fire retry

2017-08-03 Thread git
dubeejw commented on a change in pull request #209: exponential backoff on trigger fire retry URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/209#discussion_r131224520 ## File path: provider/consumer.py ## @@ -371,10 +369,11 @@ def

[GitHub] mdeuser commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
mdeuser commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r131194973 ## File path: docs/cli.md ## @@ -38,6 +38,31 @@ you can run the following command

[GitHub] drcariel commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
drcariel commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131223753 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,16 +71,6 @@ import whisk.utils.retry

[GitHub] bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320050852 PG 4 628 Passed This is an automated message from

[GitHub] zachschultz opened a new issue #2572: Deploying OpenWhisk with Docker for Mac fails at apigateway.yml ansible step

2017-08-03 Thread git
zachschultz opened a new issue #2572: Deploying OpenWhisk with Docker for Mac fails at apigateway.yml ansible step URL: https://github.com/apache/incubator-openwhisk/issues/2572 ## Environment details: * Mac OS, Docker for Mac * docker --version: Docker version 17.06.0-ce, build

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-03 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320043982 With the implementation from this PR action1 will have annotations for key1, key2 and the web annotations when the

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-03 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320043982 With the implementation from this PR action1 will have annotations for key1, key2 and the web annotations when the

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-03 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320042920 What is here works and will fix the issue. Problem is that the action update command with the web flag specified will

[GitHub] rabbah commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
rabbah commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131208587 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,16 +71,6 @@ import whisk.utils.retry case

[GitHub] rabbah commented on issue #2556: Fix bug on set_fact relative ansible task

2017-08-03 Thread git
rabbah commented on issue #2556: Fix bug on set_fact relative ansible task URL: https://github.com/apache/incubator-openwhisk/pull/2556#issuecomment-320036382 pg2/1?90?2 ? This is an automated message from the Apache Git

[GitHub] rabbah commented on a change in pull request #2557: Fix ansible script for distributed environment

2017-08-03 Thread git
rabbah commented on a change in pull request #2557: Fix ansible script for distributed environment URL: https://github.com/apache/incubator-openwhisk/pull/2557#discussion_r131205639 ## File path: ansible/roles/cli/tasks/deploy.yml ## @@ -24,8 +24,4 @@ copy: src={{

[GitHub] markusthoemmes closed issue #1541: Implement new authentication schema throughout the codebase

2017-08-03 Thread git
markusthoemmes closed issue #1541: Implement new authentication schema throughout the codebase URL: https://github.com/apache/incubator-openwhisk/issues/1541 This is an automated message from the Apache Git Service. To

[GitHub] markusthoemmes commented on issue #2571: Add user agent header for CLI http client

2017-08-03 Thread git
markusthoemmes commented on issue #2571: Add user agent header for CLI http client URL: https://github.com/apache/incubator-openwhisk/issues/2571#issuecomment-320030576 duplicate of #2568? This is an automated message from

[GitHub] tysonnorris commented on a change in pull request #2517: Support client certificate verify on server side

2017-08-03 Thread git
tysonnorris commented on a change in pull request #2517: Support client certificate verify on server side URL: https://github.com/apache/incubator-openwhisk/pull/2517#discussion_r131200474 ## File path: core/controller/src/main/scala/whisk/core/controller/RestAPIs.scala

[GitHub] dubeejw commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
dubeejw commented on a change in pull request #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r131193807 ## File path: docs/cli.md ## @@ -38,6 +38,31 @@ you can run the following command

[GitHub] csantanapr opened a new issue #2571: Add user agent header for CLI http client

2017-08-03 Thread git
csantanapr opened a new issue #2571: Add user agent header for CLI http client URL: https://github.com/apache/incubator-openwhisk/issues/2571 It will be useful for operators to distinguish http client, this way we can see how many % of users/usage is using the CLI vs other type of http

[GitHub] drcariel commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
drcariel commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131190116 ## File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala ## @@ -149,9 +149,7 @@ class

[GitHub] drcariel commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
drcariel commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131189859 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,16 +71,6 @@ import whisk.utils.retry

[GitHub] mdeuser commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
mdeuser commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131187335 ## File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala ## @@ -149,9 +149,7 @@ class

[GitHub] csantanapr commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-03 Thread git
csantanapr commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320016380 bump @akrabat hit this again in the field. how can we move this one forward

[GitHub] hsane2001 opened a new issue #2570: Cannot install APIgateway if http_proxy variable set in native environment

2017-08-03 Thread git
hsane2001 opened a new issue #2570: Cannot install APIgateway if http_proxy variable set in native environment URL: https://github.com/apache/incubator-openwhisk/issues/2570 ## Environment details: * native Ubuntu * Docker version 1.12.0, build 8eab29e, Ubuntu 16.04

[GitHub] drcariel commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
drcariel commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131184910 ## File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala ## @@ -149,9 +149,7 @@ class

[GitHub] drcariel commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
drcariel commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131184910 ## File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala ## @@ -149,9 +149,7 @@ class

[GitHub] mdeuser commented on issue #2439: Set user agent header in API GW requests

2017-08-03 Thread git
mdeuser commented on issue #2439: Set user agent header in API GW requests URL: https://github.com/apache/incubator-openwhisk/pull/2439#issuecomment-320012704 pg2/1901 This is an automated message from the Apache Git

[GitHub] rabbah commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
rabbah commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131179737 ## File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala ## @@ -149,9 +149,7 @@ class

[GitHub] rabbah commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
rabbah commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131179737 ## File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala ## @@ -149,9 +149,7 @@ class

[GitHub] bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-319961791 Sounds good to me. Any ideas on what the flag should be called?

[GitHub] rabbah commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
rabbah commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131179357 ## File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala ## @@ -149,9 +149,7 @@ class

[GitHub] rabbah commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
rabbah commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131179005 ## File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala ## @@ -149,9 +149,7 @@ class

[GitHub] bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT

2017-08-03 Thread git
bpoole16 commented on issue #2520: Prints bashauto-completion install script to STDOUT URL: https://github.com/apache/incubator-openwhisk/pull/2520#issuecomment-320007201 @mdeuser @csantanapr Updated to have no flag. This

[GitHub] tysonnorris commented on a change in pull request #2414: SPI approach for pluggable implementations

2017-08-03 Thread git
tysonnorris commented on a change in pull request #2414: SPI approach for pluggable implementations URL: https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r131178209 ## File path: common/scala/src/main/scala/whisk/spi/SpiLoader.scala ## @@ -0,0 +1,94 @@

[GitHub] drcariel commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
drcariel commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131177911 ## File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala ## @@ -149,9 +149,7 @@ class

[GitHub] rabbah commented on a change in pull request #2564: Remove old scripts and unused config parameters

2017-08-03 Thread git
rabbah commented on a change in pull request #2564: Remove old scripts and unused config parameters URL: https://github.com/apache/incubator-openwhisk/pull/2564#discussion_r131175355 ## File path: ansible/templates/whisk.properties.j2 ## @@ -74,8 +74,6 @@

[GitHub] rabbah commented on issue #2564: Remove old scripts and unused config parameters

2017-08-03 Thread git
rabbah commented on issue #2564: Remove old scripts and unused config parameters URL: https://github.com/apache/incubator-openwhisk/pull/2564#issuecomment-320003523 PG3/952 ? This is an automated message from the Apache

[GitHub] rabbah commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
rabbah commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131174659 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,16 +71,6 @@ import whisk.utils.retry case

[GitHub] drcariel commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
drcariel commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131174270 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,16 +71,6 @@ import whisk.utils.retry

[GitHub] rabbah commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
rabbah commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131174431 ## File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala ## @@ -149,9 +149,7 @@ class

[GitHub] drcariel commented on a change in pull request #2547: CLI Experimental api removal

2017-08-03 Thread git
drcariel commented on a change in pull request #2547: CLI Experimental api removal URL: https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131174270 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,16 +71,6 @@ import whisk.utils.retry

  1   2   >