[GitHub] lzbj commented on issue #292: Undeploy (on failure) should have user prompt when "interactive" mode is true

2017-09-19 Thread git
lzbj commented on issue #292: Undeploy (on failure) should have user prompt when "interactive" mode is true URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/292#issuecomment-330762632 @mrutkows , ok thanks. --

[GitHub] lzbj commented on issue #344: Unit Test - misc.go

2017-09-19 Thread git
lzbj commented on issue #344: Unit Test - misc.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/344#issuecomment-330762427 close as pr #500 merged. This is an automated message from the Apache Git Serv

[GitHub] lzbj closed issue #344: Unit Test - misc.go

2017-09-19 Thread git
lzbj closed issue #344: Unit Test - misc.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/344 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] cbickel commented on a change in pull request #2735: Remove redundant view which predates db split into activations and assets.

2017-09-19 Thread git
cbickel commented on a change in pull request #2735: Remove redundant view which predates db split into activations and assets. URL: https://github.com/apache/incubator-openwhisk/pull/2735#discussion_r139883266 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskActiva

[GitHub] lzbj commented on issue #53: Add teraform plugin for wskdeploy tool.

2017-09-19 Thread git
lzbj commented on issue #53: Add teraform plugin for wskdeploy tool. URL: https://github.com/apache/incubator-openwhisk-devtools/pull/53#issuecomment-330755913 @mrutkows , please help review, thanks a lot. This is an automat

[GitHub] lzbj opened a new pull request #53: Add teraform plugin for wskdeploy tool.

2017-09-19 Thread git
lzbj opened a new pull request #53: Add teraform plugin for wskdeploy tool. URL: https://github.com/apache/incubator-openwhisk-devtools/pull/53 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] daisy-ycguo commented on issue #503: add cloudant case in integration test

2017-09-19 Thread git
daisy-ycguo commented on issue #503: add cloudant case in integration test URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/503#issuecomment-330749726 Please review and merge it. This is an automated message

[GitHub] vvraskin commented on a change in pull request #2531: Share bookkeeping data across controllers

2017-09-19 Thread git
vvraskin commented on a change in pull request #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#discussion_r139878225 ## File path: core/controller/src/main/scala/whisk/core/loadBalancer/SeedNodesProvider.scala

[GitHub] vvraskin commented on issue #2531: Share bookkeeping data across controllers

2017-09-19 Thread git
vvraskin commented on issue #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#issuecomment-330747652 @tysonnorris 1. Given that the cluster is now started from within the `LoadBalancerService`, it should be good enough for nea

[GitHub] daisy-ycguo commented on issue #498: Do we support manifest.yaml available as an HTTP link

2017-09-19 Thread git
daisy-ycguo commented on issue #498: Do we support manifest.yaml available as an HTTP link URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/498#issuecomment-330746622 I tested `./wskdeploy -m https://raw.githubusercontent.com/daisy-ycguo/wskdeploy-test/master/helloworld

[GitHub] daisy-ycguo closed pull request #500: misc unitary test.go

2017-09-19 Thread git
daisy-ycguo closed pull request #500: misc unitary test.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/500 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] vvraskin commented on issue #2531: Share bookkeeping data across controllers

2017-09-19 Thread git
vvraskin commented on issue #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#issuecomment-330744519 @bwmcadams 2. What I meant on additional complexity is that if we have cluster management outside of the actors, that could i

[GitHub] lzbj commented on issue #521: Updated .PHONY targets

2017-09-19 Thread git
lzbj commented on issue #521: Updated .PHONY targets URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/521#issuecomment-330735938 @GabrielNicolasAvellaneda , thanks for your PR. This is an automated message f

[GitHub] lzbj closed pull request #521: Updated .PHONY targets

2017-09-19 Thread git
lzbj closed pull request #521: Updated .PHONY targets URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/521 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] daisy-ycguo closed pull request #518: Fix typed parameters, add missing functional tests

2017-09-19 Thread git
daisy-ycguo closed pull request #518: Fix typed parameters, add missing functional tests URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/518 This is an automated message from the Apache Git Service. To res

[GitHub] daisy-ycguo closed issue #499: WIP: Do we support packages in manifest file?

2017-09-19 Thread git
daisy-ycguo closed issue #499: WIP: Do we support packages in manifest file? URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/499 This is an automated message from the Apache Git Service. To respond to the

[GitHub] daisy-ycguo closed pull request #519: Adding support for packages in manifest

2017-09-19 Thread git
daisy-ycguo closed pull request #519: Adding support for packages in manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/519 This is an automated message from the Apache Git Service. To respond to the

[GitHub] daisy-ycguo commented on issue #514: Rules and triggers are not created under the package defined in manifest

2017-09-19 Thread git
daisy-ycguo commented on issue #514: Rules and triggers are not created under the package defined in manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/514#issuecomment-330732315 It is by design now. We will keep this issue to track the discussions. -

[GitHub] mrutkows closed issue #504: Error message for manifest file not found does not reflect -m (or -p) file names

2017-09-19 Thread git
mrutkows closed issue #504: Error message for manifest file not found does not reflect -m (or -p) file names URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/504 This is an automated message from the Apac

[GitHub] mrutkows closed pull request #493: Modify the error messages

2017-09-19 Thread git
mrutkows closed pull request #493: Modify the error messages URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/493 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] GabrielNicolasAvellaneda opened a new pull request #521: Updated .PHONY targets

2017-09-19 Thread git
GabrielNicolasAvellaneda opened a new pull request #521: Updated .PHONY targets URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/521 All targets that do not represent file names should be phony targets This i

[GitHub] daisy-ycguo commented on issue #520: Refactor yamlparser_test.go

2017-09-19 Thread git
daisy-ycguo commented on issue #520: Refactor yamlparser_test.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/520#issuecomment-330719552 @pritidesai please review it. Thanks. This is an automated message

[GitHub] daisy-ycguo opened a new pull request #520: Refactor yamlparser_test.go

2017-09-19 Thread git
daisy-ycguo opened a new pull request #520: Refactor yamlparser_test.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/520 Closed issue #361 Classify the test cases in yamlparser_test.go, move them to manifest_parser_test.go if its manifest related test case and

[GitHub] pritidesai commented on issue #499: WIP: Do we support packages in manifest file?

2017-09-19 Thread git
pritidesai commented on issue #499: WIP: Do we support packages in manifest file? URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/499#issuecomment-330717913 PR # 519 is adding support for packages in manifest file. We still need a separate PR to add **deprecated warnin

[GitHub] daisy-ycguo closed pull request #517: Add the document to explain how to generate i18n_resources.go

2017-09-19 Thread git
daisy-ycguo closed pull request #517: Add the document to explain how to generate i18n_resources.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/517 This is an automated message from the Apache Git Serv

[GitHub] daisy-ycguo closed issue #509: Document how to generate i18n_resources.go each time new i18n messages are added or changed

2017-09-19 Thread git
daisy-ycguo closed issue #509: Document how to generate i18n_resources.go each time new i18n messages are added or changed URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/509 This is an automated message

[GitHub] pritidesai opened a new pull request #519: Adding support for packages in manifest

2017-09-19 Thread git
pritidesai opened a new pull request #519: Adding support for packages in manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/519 Closes #499 This is an automated message from the Apache Git Service.

[GitHub] ddragosd commented on issue #51: make quick-start fails at init-couchdb on task "find the ip of docker-machine"

2017-09-19 Thread git
ddragosd commented on issue #51: make quick-start fails at init-couchdb on task "find the ip of docker-machine" URL: https://github.com/apache/incubator-openwhisk-devtools/issues/51#issuecomment-330709454 thanks for reporting @alexkli . I've opened #52 to fix this issue. ---

[GitHub] ddragosd opened a new pull request #52: Pinned ansible version to fix #51

2017-09-19 Thread git
ddragosd opened a new pull request #52: Pinned ansible version to fix #51 URL: https://github.com/apache/incubator-openwhisk-devtools/pull/52 This PR encompasses 2 changes: 1. It fixes #51 2. It adds a new env var for the controller based on the changes in the upstream, master.

[GitHub] ddragosd commented on issue #51: make quick-start fails at init-couchdb on task "find the ip of docker-machine"

2017-09-19 Thread git
ddragosd commented on issue #51: make quick-start fails at init-couchdb on task "find the ip of docker-machine" URL: https://github.com/apache/incubator-openwhisk-devtools/issues/51#issuecomment-330701522 I believe this issue is caused by an ansible version mismatch in the `williamyeh/ans

[GitHub] alexkli commented on issue #51: make quick-start fails at init-couchdb on task "find the ip of docker-machine"

2017-09-19 Thread git
alexkli commented on issue #51: make quick-start fails at init-couchdb on task "find the ip of docker-machine" URL: https://github.com/apache/incubator-openwhisk-devtools/issues/51#issuecomment-330691134 With not much idea how all of this works, I tried to debug around. 1. De

[GitHub] ddragosd commented on issue #2689: first stage of support for dynamic invoker id assignment

2017-09-19 Thread git
ddragosd commented on issue #2689: first stage of support for dynamic invoker id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2689#issuecomment-330688389 Just a few weeks ago I experienced an issue with an OW controller that wouldn't start. It turns out it was due to

[GitHub] ddragosd commented on issue #2689: first stage of support for dynamic invoker id assignment

2017-09-19 Thread git
ddragosd commented on issue #2689: first stage of support for dynamic invoker id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2689#issuecomment-330686543 BTW, what's preventing the Controller and the Invoker to use host's IP Address as ID ? Does it have to be a numbe

[GitHub] tysonnorris commented on issue #2689: first stage of support for dynamic invoker id assignment

2017-09-19 Thread git
tysonnorris commented on issue #2689: first stage of support for dynamic invoker id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2689#issuecomment-330676522 Is there an assumption that the redis instance data is persistent? If so, would it be better to use zookeeper

[GitHub] alexkli opened a new issue #51: make quick-start fails on task "find the ip of docker-machine"

2017-09-19 Thread git
alexkli opened a new issue #51: make quick-start fails on task "find the ip of docker-machine" URL: https://github.com/apache/incubator-openwhisk-devtools/issues/51 This issue happens on [Travis build 412](https://travis-ci.org/apache/incubator-openwhisk-devtools/builds/277138691) and I s

[GitHub] bwmcadams commented on issue #2531: Share bookkeeping data across controllers

2017-09-19 Thread git
bwmcadams commented on issue #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#issuecomment-330672457 At the risk of a vapid comment, I need to do a bit of refresher research on this (also boarding an airplane). Let me give it so

[GitHub] mrutkows opened a new pull request #518: Fix typed parms

2017-09-19 Thread git
mrutkows opened a new pull request #518: Fix typed parms URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/518 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] houshengbo opened a new pull request #517: Add the document to explain how to generate i18n_resources.go

2017-09-19 Thread git
houshengbo opened a new pull request #517: Add the document to explain how to generate i18n_resources.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/517 Closes #509 This is an automated message from the

[GitHub] dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment

2017-09-19 Thread git
dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2689#issuecomment-330647740 rebased with master to resolve conflict in LoadBalancer.scala. --

[GitHub] houshengbo commented on issue #512: Integration test AlarmTrigger failed, which caused the failure of travis since this PR

2017-09-19 Thread git
houshengbo commented on issue #512: Integration test AlarmTrigger failed, which caused the failure of travis since this PR URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/512#issuecomment-330646701 @daisy-ycguo We found out that we have to use the full name as the names

[GitHub] houshengbo opened a new pull request #516: Correct the BLUEMIX_NAMESPACE

2017-09-19 Thread git
houshengbo opened a new pull request #516: Correct the BLUEMIX_NAMESPACE URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/516 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] ddragosd commented on issue #2531: Share bookkeeping data across controllers

2017-09-19 Thread git
ddragosd commented on issue #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#issuecomment-330637788 I'm also wondering what's the most performant model to distribute billions of records using distributed data with Akka. Should w

[GitHub] dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment

2017-09-19 Thread git
dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2689#issuecomment-330631211 pg1 2078 ? This is an automated message from

[GitHub] dubeejw commented on issue #2778: Test JSON values as web action body arguments

2017-09-19 Thread git
dubeejw commented on issue #2778: Test JSON values as web action body arguments URL: https://github.com/apache/incubator-openwhisk/pull/2778#issuecomment-330627891 PG3 1107 ? This is an automated message from the Apache Git

[GitHub] ddragosd commented on a change in pull request #2531: Share bookkeeping data across controllers

2017-09-19 Thread git
ddragosd commented on a change in pull request #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#discussion_r139766795 ## File path: core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala ##

[GitHub] dubeejw commented on issue #2748: Don't assume apihost is https for sdk and action urls

2017-09-19 Thread git
dubeejw commented on issue #2748: Don't assume apihost is https for sdk and action urls URL: https://github.com/apache/incubator-openwhisk/pull/2748#issuecomment-330617083 PG2 2093 ? This is an automated message from the A

[GitHub] dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment

2017-09-19 Thread git
dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2689#issuecomment-330613666 pg1 2078 ? This is an automated message from

[GitHub] ddragosd commented on issue #2531: Share bookkeeping data across controllers

2017-09-19 Thread git
ddragosd commented on issue #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#issuecomment-330615971 :+1: @bwmcadams @tysonnorris This is an automated message from

[GitHub] dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment

2017-09-19 Thread git
dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2689#issuecomment-330613666 pg1 2077 ? This is an automated message from

[GitHub] dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment

2017-09-19 Thread git
dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2689#issuecomment-330608467 pg 2076 ? investigating. This is an automated

[GitHub] rabbah commented on a change in pull request #2771: Echo Access-Control-Request-Headers as Access-Control-Allow-Headers

2017-09-19 Thread git
rabbah commented on a change in pull request #2771: Echo Access-Control-Request-Headers as Access-Control-Allow-Headers URL: https://github.com/apache/incubator-openwhisk/pull/2771#discussion_r139751909 ## File path: docs/webactions.md ## @@ -393,11 +393,13 @@ $ curl -k

[GitHub] tysonnorris commented on issue #2531: Share bookkeeping data across controllers

2017-09-19 Thread git
tysonnorris commented on issue #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#issuecomment-330598088 @vvraskin to your points: 1 - in controller immediately, no. In controller in the near future, yes, e.g. in a mesos case w

[GitHub] dubeejw commented on issue #2778: Test JSON values as web action body arguments

2017-09-19 Thread git
dubeejw commented on issue #2778: Test JSON values as web action body arguments URL: https://github.com/apache/incubator-openwhisk/pull/2778#issuecomment-330595585 PG3 1107 ? This is an automated message from the Apache Git

[GitHub] dubeejw opened a new pull request #2778: Test JSON values as web action body arguments

2017-09-19 Thread git
dubeejw opened a new pull request #2778: Test JSON values as web action body arguments URL: https://github.com/apache/incubator-openwhisk/pull/2778 Adds a unit test that ensures JSON strings, arrays, numbers, and arrays are acceptable body arguments with a `application/json` content type.

[GitHub] tysonnorris commented on a change in pull request #2531: Share bookkeeping data across controllers

2017-09-19 Thread git
tysonnorris commented on a change in pull request #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#discussion_r139744188 ## File path: core/controller/src/main/scala/whisk/core/loadBalancer/SeedNodesProvider.scala #

[GitHub] jessealva commented on issue #2462: Updating the way we print names in the Cli Fixes #1155

2017-09-19 Thread git
jessealva commented on issue #2462: Updating the way we print names in the Cli Fixes #1155 URL: https://github.com/apache/incubator-openwhisk/pull/2462#issuecomment-330593692 ugh, not clean, looking into this again This

[GitHub] markusthoemmes closed pull request #2773: Make blackbox invoker fraction configurable via Ansible

2017-09-19 Thread git
markusthoemmes closed pull request #2773: Make blackbox invoker fraction configurable via Ansible URL: https://github.com/apache/incubator-openwhisk/pull/2773 This is an automated message from the Apache Git Service. To res

[GitHub] markusthoemmes commented on issue #2747: Use non-blocking UUID generation in controller

2017-09-19 Thread git
markusthoemmes commented on issue #2747: Use non-blocking UUID generation in controller URL: https://github.com/apache/incubator-openwhisk/issues/2747#issuecomment-330587501 @rabbah and I have been debating a fix for this. Providing an alternative `SecureRandom` instance could help (espec

[GitHub] mrutkows closed issue #515: Env. Var concatenation (with dollar sign notation) has errors that are hidden

2017-09-19 Thread git
mrutkows closed issue #515: Env. Var concatenation (with dollar sign notation) has errors that are hidden URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/515 This is an automated message from the Apache

[GitHub] bwmcadams commented on issue #2747: Use non-blocking UUID generation in controller

2017-09-19 Thread git
bwmcadams commented on issue #2747: Use non-blocking UUID generation in controller URL: https://github.com/apache/incubator-openwhisk/issues/2747#issuecomment-330581802 It looks like from Java 8 onwards you can provide ?custom? SecureRandom instances which aren't blocking. Found a [simila

[GitHub] mrutkows opened a new issue #515: Env. Var concatenation (with dollar sign notation) has errors that are hidden

2017-09-19 Thread git
mrutkows opened a new issue #515: Env. Var concatenation (with dollar sign notation) has errors that are hidden URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/515 It appears that although concatenation works for the simplest cases. If an error occurs attempting t

[GitHub] dubeejw commented on a change in pull request #2771: Echo Access-Control-Request-Headers as Access-Control-Allow-Headers

2017-09-19 Thread git
dubeejw commented on a change in pull request #2771: Echo Access-Control-Request-Headers as Access-Control-Allow-Headers URL: https://github.com/apache/incubator-openwhisk/pull/2771#discussion_r139731890 ## File path: docs/webactions.md ## @@ -393,11 +393,13 @@ $ curl -k

[GitHub] dubeejw commented on a change in pull request #2771: Echo Access-Control-Request-Headers as Access-Control-Allow-Headers

2017-09-19 Thread git
dubeejw commented on a change in pull request #2771: Echo Access-Control-Request-Headers as Access-Control-Allow-Headers URL: https://github.com/apache/incubator-openwhisk/pull/2771#discussion_r139732278 ## File path: tests/src/test/scala/whisk/core/cli/test/WskWebActionsTests.sca

[GitHub] mrutkows closed issue #515: Env. Var concatenation (with dollar sign notation) has errors that are hidden

2017-09-19 Thread git
mrutkows closed issue #515: Env. Var concatenation (with dollar sign notation) has errors that are hidden URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/515 This is an automated message from the Apache

[GitHub] dubeejw commented on a change in pull request #2748: Don't assume apihost is https for sdk and action urls

2017-09-19 Thread git
dubeejw commented on a change in pull request #2748: Don't assume apihost is https for sdk and action urls URL: https://github.com/apache/incubator-openwhisk/pull/2748#discussion_r139724278 ## File path: tools/cli/go-whisk-cli/commands/commands.go ## @@ -33,7 +33,7 @@ con

[GitHub] dubeejw commented on issue #2748: Don't assume apihost is https for sdk and action urls

2017-09-19 Thread git
dubeejw commented on issue #2748: Don't assume apihost is https for sdk and action urls URL: https://github.com/apache/incubator-openwhisk/pull/2748#issuecomment-330576891 PG2 2093 ? This is an automated message from the A

[GitHub] dubeejw commented on a change in pull request #2748: Don't assume apihost is https for sdk and action urls

2017-09-19 Thread git
dubeejw commented on a change in pull request #2748: Don't assume apihost is https for sdk and action urls URL: https://github.com/apache/incubator-openwhisk/pull/2748#discussion_r139723934 ## File path: tools/cli/go-whisk/whisk/action.go ## @@ -122,33 +122,39 @@ func (ac

[GitHub] dubeejw commented on a change in pull request #2748: Don't assume apihost is https for sdk and action urls

2017-09-19 Thread git
dubeejw commented on a change in pull request #2748: Don't assume apihost is https for sdk and action urls URL: https://github.com/apache/incubator-openwhisk/pull/2748#discussion_r139724278 ## File path: tools/cli/go-whisk-cli/commands/commands.go ## @@ -33,7 +33,7 @@ con

[GitHub] dubeejw commented on a change in pull request #2748: Don't assume apihost is https for sdk and action urls

2017-09-19 Thread git
dubeejw commented on a change in pull request #2748: Don't assume apihost is https for sdk and action urls URL: https://github.com/apache/incubator-openwhisk/pull/2748#discussion_r139723934 ## File path: tools/cli/go-whisk/whisk/action.go ## @@ -122,33 +122,39 @@ func (ac

[GitHub] dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment

2017-09-19 Thread git
dgrove-oss commented on issue #2689: first stage of support for dynamic invoker id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2689#issuecomment-330572212 pg1 2076 ? This is an automated message from

[GitHub] dubeejw commented on issue #2748: Don't assume apihost is https for sdk and action urls

2017-09-19 Thread git
dubeejw commented on issue #2748: Don't assume apihost is https for sdk and action urls URL: https://github.com/apache/incubator-openwhisk/pull/2748#issuecomment-330571710 PG2 2092 ? This is an automated message from the A

[GitHub] mrutkows opened a new issue #515: Env. Var concatenation (with dollar sign notation) has errors that are hidden

2017-09-19 Thread git
mrutkows opened a new issue #515: Env. Var concatenation (with dollar sign notation) has errors that are hidden URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/515 It appears that although concatenation works for the simplest cases. If an error occurs attempting t

[GitHub] mrutkows closed pull request #513: Support string and env variable concatenation

2017-09-19 Thread git
mrutkows closed pull request #513: Support string and env variable concatenation URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/513 This is an automated message from the Apache Git Service. To respond to t

[GitHub] mrutkows closed issue #501: We don't support concatenation of an environment value and a string

2017-09-19 Thread git
mrutkows closed issue #501: We don't support concatenation of an environment value and a string URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/501 This is an automated message from the Apache Git Servic

[GitHub] mrutkows commented on a change in pull request #513: Support string and env variable concatenation

2017-09-19 Thread git
mrutkows commented on a change in pull request #513: Support string and env variable concatenation URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/513#discussion_r139705938 ## File path: utils/util_test.go ## @@ -57,6 +57,13 @@ func TestGetEnvVar(t *test

[GitHub] dgrove-oss commented on issue #2747: Use non-blocking UUID generation in controller

2017-09-19 Thread git
dgrove-oss commented on issue #2747: Use non-blocking UUID generation in controller URL: https://github.com/apache/incubator-openwhisk/issues/2747#issuecomment-330563565 One possibility could be to have a cache of precomputed UUIDs that is populated by a background thread. That should al

[GitHub] sven-lange-last commented on issue #2773: Make blackbox invoker fraction configurable via Ansible

2017-09-19 Thread git
sven-lange-last commented on issue #2773: Make blackbox invoker fraction configurable via Ansible URL: https://github.com/apache/incubator-openwhisk/pull/2773#issuecomment-330525163 @markusthoemmes PG3 - 1106 successful Thi

[GitHub] mrutkows commented on a change in pull request #513: Support string and env variable concatenation

2017-09-19 Thread git
mrutkows commented on a change in pull request #513: Support string and env variable concatenation URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/513#discussion_r139705938 ## File path: utils/util_test.go ## @@ -57,6 +57,13 @@ func TestGetEnvVar(t *test

[GitHub] mrutkows commented on issue #500: misc unitary test.go

2017-09-19 Thread git
mrutkows commented on issue #500: misc unitary test.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/500#issuecomment-330551852 @pritidesai I added a couple comments, but not a review... care to provide any comments? ---

[GitHub] mrutkows commented on a change in pull request #500: misc unitary test.go

2017-09-19 Thread git
mrutkows commented on a change in pull request #500: misc unitary test.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/500#discussion_r139703386 ## File path: utils/misc.go ## @@ -619,3 +619,42 @@ func GetDeploymentFilePath(projectPath string) string {

[GitHub] csantanapr opened a new issue #2777: enable verbose for build.sh in Travis to help debug

2017-09-19 Thread git
csantanapr opened a new issue #2777: enable verbose for build.sh in Travis to help debug URL: https://github.com/apache/incubator-openwhisk/issues/2777 Some builds in Travis are timeout after hours (i.e. 6 hours) it looks like all tests passed, so I'm suspecting is around dealing with logs

[GitHub] mrutkows commented on a change in pull request #500: misc unitary test.go

2017-09-19 Thread git
mrutkows commented on a change in pull request #500: misc unitary test.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/500#discussion_r139702173 ## File path: utils/misc_test.go ## @@ -72,3 +72,23 @@ func TestDependencies(t *testing.T) { assert

[GitHub] csantanapr opened a new issue #2776: apigateway missing from redo/wskdev

2017-09-19 Thread git
csantanapr opened a new issue #2776: apigateway missing from redo/wskdev URL: https://github.com/apache/incubator-openwhisk/issues/2776 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] csantanapr opened a new pull request #2775: fix wsk autocomplete for Vagrant

2017-09-19 Thread git
csantanapr opened a new pull request #2775: fix wsk autocomplete for Vagrant URL: https://github.com/apache/incubator-openwhisk/pull/2775 Closes #2774 This is an automated message from the Apache Git Service. To respond to t

[GitHub] csantanapr opened a new issue #2774: wsk autocomplete not setup in Vagrant env

2017-09-19 Thread git
csantanapr opened a new issue #2774: wsk autocomplete not setup in Vagrant env URL: https://github.com/apache/incubator-openwhisk/issues/2774 autocomplete not persistent, it needs to be setup in `~/.bashrc` This is an automat

[GitHub] bwmcadams commented on issue #2531: Share bookkeeping data across controllers

2017-09-19 Thread git
bwmcadams commented on issue #2531: Share bookkeeping data across controllers URL: https://github.com/apache/incubator-openwhisk/pull/2531#issuecomment-330544437 @vvraskin 1) I've been giving some thought to clustering usage? but still absorbing the code base. I may have some wisdo

[GitHub] csantanapr commented on issue #2768: add workaround for inserting space on autocomplete on Mac

2017-09-19 Thread git
csantanapr commented on issue #2768: add workaround for inserting space on autocomplete on Mac URL: https://github.com/apache/incubator-openwhisk/pull/2768#issuecomment-330540538 something weird with travis builds timing out after hours ---

[GitHub] csantanapr opened a new pull request #2768: add workaround for inserting space on autocomplete on Mac

2017-09-19 Thread git
csantanapr opened a new pull request #2768: add workaround for inserting space on autocomplete on Mac URL: https://github.com/apache/incubator-openwhisk/pull/2768 Closes #1323 This is an automated message from the Apache Git

[GitHub] csantanapr closed pull request #2768: add workaround for inserting space on autocomplete on Mac

2017-09-19 Thread git
csantanapr closed pull request #2768: add workaround for inserting space on autocomplete on Mac URL: https://github.com/apache/incubator-openwhisk/pull/2768 This is an automated message from the Apache Git Service. To respo

[GitHub] rabbah commented on issue #2658: Treat a timed out active ack as failed activation in invokerhealth protocol

2017-09-19 Thread git
rabbah commented on issue #2658: Treat a timed out active ack as failed activation in invokerhealth protocol URL: https://github.com/apache/incubator-openwhisk/pull/2658#issuecomment-324176866 The pings should carry a count indicating forward progress. I think treating timed out active ac

[GitHub] sven-lange-last commented on issue #2773: Make blackbox invoker fraction configurable via Ansible

2017-09-19 Thread git
sven-lange-last commented on issue #2773: Make blackbox invoker fraction configurable via Ansible URL: https://github.com/apache/incubator-openwhisk/pull/2773#issuecomment-330525163 PG3 - 1106 running This is an automated m

[GitHub] sven-lange-last opened a new pull request #2773: Make blackbox invoker fraction configurable via Ansible

2017-09-19 Thread git
sven-lange-last opened a new pull request #2773: Make blackbox invoker fraction configurable via Ansible URL: https://github.com/apache/incubator-openwhisk/pull/2773 Extend Ansible deploy playbook for controller role such that it passes the blackbox fraction setting as environment varia

[GitHub] GabrielNicolasAvellaneda commented on issue #2772: Fix issue with trailing spaces and handle comments in the property file.

2017-09-19 Thread git
GabrielNicolasAvellaneda commented on issue #2772: Fix issue with trailing spaces and handle comments in the property file. URL: https://github.com/apache/incubator-openwhisk/pull/2772#issuecomment-330514686 Got it. Sounds good! ---

[GitHub] rabbah commented on issue #2772: Fix issue with trailing spaces and handle comments in the property file.

2017-09-19 Thread git
rabbah commented on issue #2772: Fix issue with trailing spaces and handle comments in the property file. URL: https://github.com/apache/incubator-openwhisk/pull/2772#issuecomment-330513871 Your observation is right. The cli code is moving to its own repo and should have unit tests eventu

[GitHub] rabbah commented on issue #2772: Fix issue with trailing spaces and handle comments in the property file.

2017-09-19 Thread git
rabbah commented on issue #2772: Fix issue with trailing spaces and handle comments in the property file. URL: https://github.com/apache/incubator-openwhisk/pull/2772#issuecomment-330513871 Your observation is right. The cli code is moving to its own repo and should have unit tests eventu

[GitHub] GabrielNicolasAvellaneda commented on issue #2772: Fix issue with trailing spaces and handle comments in the property file.

2017-09-19 Thread git
GabrielNicolasAvellaneda commented on issue #2772: Fix issue with trailing spaces and handle comments in the property file. URL: https://github.com/apache/incubator-openwhisk/pull/2772#issuecomment-330511000 @rabbah Yes, I will do, I actually wanted to do a test for this. I think that sho

[GitHub] daisy-ycguo commented on issue #514: Rules and triggers are not created under the package defined in manifest

2017-09-19 Thread git
daisy-ycguo commented on issue #514: Rules and triggers are not created under the package defined in manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/514#issuecomment-330480610 I noticed there is a boolean `DeployActionInPackage` defined in `ServiceDeployer`(so

[GitHub] daisy-ycguo commented on issue #514: Rules and triggers are not created under the package defined in manifest

2017-09-19 Thread git
daisy-ycguo commented on issue #514: Rules and triggers are not created under the package defined in manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/514#issuecomment-330480610 I noticed there is a boolean `DeployActionInPackage` defined in `ServiceDeployer`(so

[GitHub] adriancole commented on a change in pull request #2282: Distributed tracing support #2192

2017-09-19 Thread git
adriancole commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r139637881 ## File path: common/scala/src/main/scala/whisk/common/tracing/TracingProvider.scala ## @@ -0,0 +1

[GitHub] daisy-ycguo opened a new issue #514: Rules and triggers are not created under default package

2017-09-19 Thread git
daisy-ycguo opened a new issue #514: Rules and triggers are not created under default package URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/514 I noticed that rules and triggers are not created under default package. For example, after deploying the cloudant use case,

  1   2   >