[GitHub] rabbah commented on issue #3950: Extend system testsuite

rabbah commented on issue #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#issuecomment-412819214 Thanks for the extra tests. I think I got through the comments that maybe of of the goals is better swagger coverage.

[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite

rabbah commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209893171 ## File path: tests/src/test/scala/common/rest/WskRestOperations.scala ## @@ -733,13 +738,23 @@ class

[GitHub] mhenke1 closed pull request #3905: Allow providers to fall back to the original entilement

mhenke1 closed pull request #3905: Allow providers to fall back to the original entilement URL: https://github.com/apache/incubator-openwhisk/pull/3905 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite

rabbah commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209893371 ## File path: tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala ## @@ -462,6 +462,57 @@

[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite

rabbah commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209893036 ## File path: tests/src/test/scala/common/rest/WskRestOperations.scala ## @@ -733,13 +738,23 @@ class

[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite

rabbah commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209892089 ## File path: tests/src/test/scala/whisk/core/cli/test/WskEntitlementTests.scala ## @@ -160,6 +160,46 @@ abstract

[GitHub] mhenke1 commented on issue #3905: Allow providers to fall back to the original entilement

mhenke1 commented on issue #3905: Allow providers to fall back to the original entilement URL: https://github.com/apache/incubator-openwhisk/pull/3905#issuecomment-412818950 Closing, since going the sub-classing route is another viable option.

[GitHub] mgencur commented on a change in pull request #3950: Extend system testsuite

mgencur commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209892859 ## File path: tests/src/test/scala/system/basic/WskActionTests.scala ## @@ -71,6 +71,21 @@ class WskActionTests

[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite

rabbah commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209890859 ## File path: tests/src/test/scala/system/basic/WskActionTests.scala ## @@ -210,6 +253,32 @@ class WskActionTests

[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite

rabbah commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209888951 ## File path: tests/src/test/scala/common/rest/WskRestOperations.scala ## @@ -707,18 +709,21 @@ class

[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite

rabbah commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209890129 ## File path: tests/src/test/scala/system/basic/WskActionTests.scala ## @@ -71,6 +71,21 @@ class WskActionTests

[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite

rabbah commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209888577 ## File path: tests/src/test/scala/common/WskCliOperations.scala ## @@ -480,12 +480,14 @@ class

[GitHub] style95 commented on issue #3671: Activation id in header

style95 commented on issue #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#issuecomment-412815528 How about separating ActivationID addition in headers and using same ID for `TransactionID` and `ActivationID`? I think there is not big

[GitHub] rabbah commented on a change in pull request #3950: Extend system testsuite

rabbah commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209888233 ## File path: tests/src/test/scala/common/WskOperations.scala ## @@ -313,6 +313,7 @@ trait ActivationOperations {

[GitHub] jthomas commented on a change in pull request #129: Iam enablement

jthomas commented on a change in pull request #129: Iam enablement URL: https://github.com/apache/incubator-openwhisk-client-js/pull/129#discussion_r209885724 ## File path: README.md ## @@ -64,6 +64,41 @@ var ow = openwhisk(options);

[GitHub] jthomas commented on a change in pull request #129: Iam enablement

jthomas commented on a change in pull request #129: Iam enablement URL: https://github.com/apache/incubator-openwhisk-client-js/pull/129#discussion_r209886278 ## File path: README.md ## @@ -64,6 +64,41 @@ var ow = openwhisk(options);

[GitHub] jthomas commented on a change in pull request #129: Iam enablement

jthomas commented on a change in pull request #129: Iam enablement URL: https://github.com/apache/incubator-openwhisk-client-js/pull/129#discussion_r209886730 ## File path: lib/client.js ## @@ -91,13 +92,13 @@ class Client { apigwSpaceGuid = apiKey.split(':')[0]

[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite

markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r209879476 ## File path: tests/dat/actions/argsInvokeOverride.json ## @@ -0,0 +1,4 @@ +{ + "param1": "value3", +

[GitHub] mgencur commented on issue #3950: Extend system testsuite

mgencur commented on issue #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#issuecomment-412804460 Hi, @markusthoemmes , the CI failure is fixed. This is ready for another review. I think only the last three commits are new. Let me know if I need

[GitHub] codecov-io edited a comment on issue #3950: Extend system testsuite

codecov-io edited a comment on issue #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#issuecomment-411691678 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3945: Treat action code as attachments

codecov-io edited a comment on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-410980593 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3945?src=pr=h1) Report > Merging

[GitHub] markusthoemmes closed pull request #3958: Add tracing component name to wskadmin-next

markusthoemmes closed pull request #3958: Add tracing component name to wskadmin-next URL: https://github.com/apache/incubator-openwhisk/pull/3958 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] markusthoemmes closed issue #3957: wskadmin-next configuration error

markusthoemmes closed issue #3957: wskadmin-next configuration error URL: https://github.com/apache/incubator-openwhisk/issues/3957 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] SchuhMichael commented on issue #221: Unable to create trigger from openwhisk kafka feed that listens to a Generic Kafka instance in a Local ubuntu installation

SchuhMichael commented on issue #221: Unable to create trigger from openwhisk kafka feed that listens to a Generic Kafka instance in a Local ubuntu installation URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/221#issuecomment-412784898 I had similar problems and

[GitHub] markusthoemmes commented on issue #3963: k8s: implement invoker-node affinity and eliminate usage of kubectl

markusthoemmes commented on issue #3963: k8s: implement invoker-node affinity and eliminate usage of kubectl URL: https://github.com/apache/incubator-openwhisk/pull/3963#issuecomment-412765015 @dgrove-oss what prevents us from removing the binary here?

<    1   2