[GitHub] davidbreitgand commented on issue #730: Multiple projects management

2018-02-13 Thread GitBox
davidbreitgand commented on issue #730: Multiple projects management URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/730#issuecomment-365262188 @pritidesai This is exactly what we had in mind. @lionelvillard The functionality we want to achieve is that there will be

[GitHub] rabbah commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
rabbah commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365241763 Excellent updated. Thank you! This is an

[GitHub] chetanmeh closed issue #16: Current master build failing in ansible command

2018-02-13 Thread GitBox
chetanmeh closed issue #16: Current master build failing in ansible command URL: https://github.com/apache/incubator-openwhisk-runtime-docker/issues/16 This is an automated message from the Apache Git Service. To respond to

[GitHub] csantanapr commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
csantanapr commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365209875 @markusthoemmes what?s the minimum change we need in the other repos? Just update ?settings.grale? ?

[GitHub] csantanapr commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
csantanapr commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365213002 @chetanmeh here is an example on of the other repos running Travis and leveraging the core repo source

[GitHub] markusthoemmes commented on a change in pull request #3258: Encrypt data in motion - Kafka

2018-02-13 Thread GitBox
markusthoemmes commented on a change in pull request #3258: Encrypt data in motion - Kafka URL: https://github.com/apache/incubator-openwhisk/pull/3258#discussion_r167824229 ## File path: common/scala/src/main/scala/whisk/connector/kafka/KafkaMessagingProvider.scala ##

[GitHub] daisy-ycguo commented on issue #34: List BSD / MIT licenses in LICENSE.txt if needed

2018-02-13 Thread GitBox
daisy-ycguo commented on issue #34: List BSD / MIT licenses in LICENSE.txt if needed URL: https://github.com/apache/incubator-openwhisk-release/issues/34#issuecomment-365232330 @mrutkows I didn't find an assembled XML file with all licenses in Spark project. So I doubt it is created with

[GitHub] cbickel commented on issue #3260: Enhance the RestResult with more information to debug failing tests e?

2018-02-13 Thread GitBox
cbickel commented on issue #3260: Enhance the RestResult with more information to debug failing tests e? URL: https://github.com/apache/incubator-openwhisk/pull/3260#issuecomment-365256637 PG5#95 ? This is an automated

[GitHub] chetanmeh opened a new issue #3277: Use Maven based dependency instead of gradle project based dependency

2018-02-13 Thread GitBox
chetanmeh opened a new issue #3277: Use Maven based dependency instead of gradle project based dependency URL: https://github.com/apache/incubator-openwhisk/issues/3277 Currently other OpenWhisk repositories refer to OpenWhisk modules like common, core and test via Gradle project

[GitHub] daisy-ycguo commented on issue #34: List BSD / MIT licenses in LICENSE.txt if needed

2018-02-13 Thread GitBox
daisy-ycguo commented on issue #34: List BSD / MIT licenses in LICENSE.txt if needed URL: https://github.com/apache/incubator-openwhisk-release/issues/34#issuecomment-365232330 @mrutkows I didn't find an assembled XML file with all licenses in Spark project. So I cannot confirm it is

[GitHub] markusthoemmes opened a new pull request #3278: Fix NullPointerException in ActivationFinisher.

2018-02-13 Thread GitBox
markusthoemmes opened a new pull request #3278: Fix NullPointerException in ActivationFinisher. URL: https://github.com/apache/incubator-openwhisk/pull/3278 The ActivationFinisher's code is racy. If shutdown and postStop are called concurrently a NullPointerException is possible.

[GitHub] allen-servedio commented on issue #729: Remove empty maps/interfaces from "export" manifest yaml

2018-02-13 Thread GitBox
allen-servedio commented on issue #729: Remove empty maps/interfaces from "export" manifest yaml URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/729#issuecomment-365273354 Just another comment on this... It is very unclear at what level you are supposed to define

[GitHub] rabbah commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
rabbah commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365241763 Excellent update. Thank you! This is an

[GitHub] mrutkows commented on issue #730: Multiple projects management

2018-02-13 Thread GitBox
mrutkows commented on issue #730: Multiple projects management URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/730#issuecomment-365272165 @pritidesai if we move to a nested map, as we discussed yesterday within the annotations, I would prefer that we attempt to

[GitHub] markusthoemmes closed pull request #3260: Enhance the RestResult with more information to debug failing tests e?

2018-02-13 Thread GitBox
markusthoemmes closed pull request #3260: Enhance the RestResult with more information to debug failing tests e? URL: https://github.com/apache/incubator-openwhisk/pull/3260 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365227172 Understand the problem now. As discussed on Slack the plan of action is to find out all other projects

[GitHub] mrutkows commented on issue #730: Multiple projects management

2018-02-13 Thread GitBox
mrutkows commented on issue #730: Multiple projects management URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/730#issuecomment-365272165 @pritidesai if we move to a nested map, as we discussed yesterday within the annotations, I would prefer that we attempt to

[GitHub] cbickel commented on a change in pull request #3077: Enable ssl on the path between edge and controllers

2018-02-13 Thread GitBox
cbickel commented on a change in pull request #3077: Enable ssl on the path between edge and controllers URL: https://github.com/apache/incubator-openwhisk/pull/3077#discussion_r167871456 ## File path: .gitignore ## @@ -2,6 +2,7 @@ nginx.conf whisk.properties

[GitHub] chetanmeh opened a new issue #16: Current master build failing in ansible command

2018-02-13 Thread GitBox
chetanmeh opened a new issue #16: Current master build failing in ansible command URL: https://github.com/apache/incubator-openwhisk-runtime-docker/issues/16 Current master build is [failing][1] with following error ``` fatal: [controller0]: FAILED! => {"failed": true, "msg":

[GitHub] chetanmeh commented on issue #16: Current master build failing in ansible command

2018-02-13 Thread GitBox
chetanmeh commented on issue #16: Current master build failing in ansible command URL: https://github.com/apache/incubator-openwhisk-runtime-docker/issues/16#issuecomment-365276303 Wrong project! This is an automated

[GitHub] chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365211929 > Merging this change will break all repositories which depend on the main repository.

[GitHub] csantanapr commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
csantanapr commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365215561 Perhaps @markusthoemmes can comment on errors he saw running tests locally from another repo using this PR

[GitHub] markusthoemmes opened a new pull request #3276: Use proper API host and reduce logging noise.

2018-02-13 Thread GitBox
markusthoemmes opened a new pull request #3276: Use proper API host and reduce logging noise. URL: https://github.com/apache/incubator-openwhisk/pull/3276 The API host was hardcoded to `WhiskProperties.getApiHost` which is not correct for all tests. It should use the one defined in

[GitHub] chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365227172 Under the problem now. As discussed on Slack the plan of action is to find out all other projects which

[GitHub] chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365227172 Understand the problem now. As discussed on Slack the plan of action is to find out all other projects

[GitHub] csantanapr commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
csantanapr commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365213561 And also https://github.com/apache/incubator-openwhisk-apigateway/blob/master/tools/travis/build.sh

[GitHub] markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365217747 Error is: ``` gradle :tests:compileTestScala FAILURE: Build failed with an exception.

[GitHub] markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365217747 Error is: ``` gradle :tests:compileTestScala FAILURE: Build failed with an exception.

[GitHub] markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365181126 @csantanapr @chetanmeh Merging this change will break **all** repositories which depend on the

[GitHub] chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats

2018-02-13 Thread GitBox
chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365214381 @csantanapr I saw that and using same pattern for a custom module. However not sure how this change would

[GitHub] daisy-ycguo commented on issue #17: Step 2: Verify the compliance of the source code

2018-02-13 Thread GitBox
daisy-ycguo commented on issue #17: Step 2: Verify the compliance of the source code URL: https://github.com/apache/incubator-openwhisk-release/issues/17#issuecomment-365285020 @houshengbo I know you implemented a gradle target `taredSources` to package source files into a compressed

[GitHub] cbickel commented on a change in pull request #3077: Enable ssl on the path between edge and controllers

2018-02-13 Thread GitBox
cbickel commented on a change in pull request #3077: Enable ssl on the path between edge and controllers URL: https://github.com/apache/incubator-openwhisk/pull/3077#discussion_r167871456 ## File path: .gitignore ## @@ -2,6 +2,7 @@ nginx.conf whisk.properties

[GitHub] cbickel commented on a change in pull request #3077: Enable ssl on the path between edge and controllers

2018-02-13 Thread GitBox
cbickel commented on a change in pull request #3077: Enable ssl on the path between edge and controllers URL: https://github.com/apache/incubator-openwhisk/pull/3077#discussion_r167889282 ## File path: common/scala/src/main/scala/whisk/core/WhiskConfig.scala ## @@ -98,6

[GitHub] chetanmeh opened a new issue #8: Current master build failing in ansible command

2018-02-13 Thread GitBox
chetanmeh opened a new issue #8: Current master build failing in ansible command URL: https://github.com/apache/incubator-openwhisk-runtime-java/issues/8 Current master build is [failing][1] with following error ``` fatal: [controller0]: FAILED! => {"failed": true, "msg": "the

[GitHub] chetanmeh opened a new issue #3279: Configure periodic travis builds for all projects

2018-02-13 Thread GitBox
chetanmeh opened a new issue #3279: Configure periodic travis builds for all projects URL: https://github.com/apache/incubator-openwhisk/issues/3279 Recently saw that master build for runtime java was failing (see apache/incubator-openwhisk-runtime-java#8). To avoid such cases in future

[GitHub] mrutkows commented on issue #729: Remove empty maps/interfaces from "export" manifest yaml

2018-02-13 Thread GitBox
mrutkows commented on issue #729: Remove empty maps/interfaces from "export" manifest yaml URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/729#issuecomment-365284834 @allen-servedio it i likely working as designed since "package" was supported at the top-level BEFORE

[GitHub] mrutkows commented on issue #730: Multiple projects management

2018-02-13 Thread GitBox
mrutkows commented on issue #730: Multiple projects management URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/730#issuecomment-365272165 @pritidesai if we move to a nested map, as we discussed yesterday within the annotations, I would prefer that we attempt to

[GitHub] lionelvillard commented on issue #730: Multiple projects management

2018-02-13 Thread GitBox
lionelvillard commented on issue #730: Multiple projects management URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/730#issuecomment-365304303 The idea of the explicit dependencies approach is to have only one project which include all your dependencies. Only one

[GitHub] mrutkows opened a new issue #734: Enable query of dynamic runtimes from deployment host

2018-02-13 Thread GitBox
mrutkows opened a new issue #734: Enable query of dynamic runtimes from deployment host URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/734 This API /endpoint should be working again... we should retry the query and if fails fall back on hardcoded list of runtimes.

[GitHub] chetanmeh opened a new pull request #17: Use Maven based dependency instead of gradle project based dependency

2018-02-13 Thread GitBox
chetanmeh opened a new pull request #17: Use Maven based dependency instead of gradle project based dependency URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/17 This is required for apache/incubator-openwhisk#3277

[GitHub] daisy-ycguo opened a new pull request #733: Enable Apache Rat plugin in gradle

2018-02-13 Thread GitBox
daisy-ycguo opened a new pull request #733: Enable Apache Rat plugin in gradle URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/733 After applying this PR, we can use below command to check headers: `gradle rat`

[GitHub] daisy-ycguo commented on issue #17: Step 2: Verify the compliance of the source code

2018-02-13 Thread GitBox
daisy-ycguo commented on issue #17: Step 2: Verify the compliance of the source code URL: https://github.com/apache/incubator-openwhisk-release/issues/17#issuecomment-365285020 @houshengbo I know you implemented a gradle target `taredSources` to package source files into a compressed

[GitHub] mrutkows opened a new issue #41: Can we anonymize the PGP key configuration?

2018-02-13 Thread GitBox
mrutkows opened a new issue #41: Can we anonymize the PGP key configuration? URL: https://github.com/apache/incubator-openwhisk-release/issues/41 Is there a way that we can anonymize (or use a dedicated key not from an individual at IBM)? tools/pgp_key_gen.conf ``` Showing

[GitHub] csantanapr closed pull request #126: optionally limit cron fields to 5 instead of 6

2018-02-13 Thread GitBox
csantanapr closed pull request #126: optionally limit cron fields to 5 instead of 6 URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/126 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller

2018-02-13 Thread GitBox
markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r167939781 ## File path:

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-13 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r167960137 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] davidbreitgand commented on issue #730: Multiple projects management

2018-02-13 Thread GitBox
davidbreitgand commented on issue #730: Multiple projects management URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/730#issuecomment-365322770 @lionelvillard I think that --override flag makes perfect sense. Also agreed that assets equality definition is required.

[GitHub] lionelvillard commented on issue #730: Multiple projects management

2018-02-13 Thread GitBox
lionelvillard commented on issue #730: Multiple projects management URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/730#issuecomment-365343069 @davidbreitgand in this model, there is only one project: ``` P --> A --> B |-> C --> B ``` then it's up

[GitHub] markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller

2018-02-13 Thread GitBox
markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r167940427 ## File path:

[GitHub] markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller

2018-02-13 Thread GitBox
markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r167940363 ## File path:

[GitHub] davidbreitgand commented on issue #730: Multiple projects management

2018-02-13 Thread GitBox
davidbreitgand commented on issue #730: Multiple projects management URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/730#issuecomment-365323635 @mrutkows Can you define the tag for @kpavel and my education (you probably discussed that within the team, so sorry for

[GitHub] mhamann commented on issue #273: A list of source files missing Apache license headers

2018-02-13 Thread GitBox
mhamann commented on issue #273: A list of source files missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/273#issuecomment-365338020 @daisy-ycguo is there an automated tool to add those license headers?

[GitHub] markusthoemmes opened a new pull request #3280: Replace asString and asBool with generic method.

2018-02-13 Thread GitBox
markusthoemmes opened a new pull request #3280: Replace asString and asBool with generic method. URL: https://github.com/apache/incubator-openwhisk/pull/3280 Mainly aims to reduce boilerplate in code which tries to extract non-primitive data from parameters/annotations. Any supported

[GitHub] csantanapr commented on issue #9: Fix travis build

2018-02-13 Thread GitBox
csantanapr commented on issue #9: Fix travis build URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/9#issuecomment-365348591 Thanks @chetanmeh ? This is an automated message from the Apache Git Service.

[GitHub] csantanapr closed issue #8: Current master build failing in ansible command

2018-02-13 Thread GitBox
csantanapr closed issue #8: Current master build failing in ansible command URL: https://github.com/apache/incubator-openwhisk-runtime-java/issues/8 This is an automated message from the Apache Git Service. To respond to the

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-13 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r167947560 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-13 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r167954793 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-13 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r167954945 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] mdeuser commented on issue #3262: Handle trigger activations with inactive rules

2018-02-13 Thread GitBox
mdeuser commented on issue #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#issuecomment-365371067 Updated `logs` field in the trigger activation record will look like the following for a trigger with one active and one

[GitHub] markusthoemmes commented on a change in pull request #3262: Handle trigger activations with inactive rules

2018-02-13 Thread GitBox
markusthoemmes commented on a change in pull request #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#discussion_r16797 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala

[GitHub] houshengbo opened a new pull request #42: Add the documentation to describe the manual mode of release

2018-02-13 Thread GitBox
houshengbo opened a new pull request #42: Add the documentation to describe the manual mode of release URL: https://github.com/apache/incubator-openwhisk-release/pull/42 This is an automated message from the Apache Git

[GitHub] markusthoemmes commented on a change in pull request #3262: Handle trigger activations with inactive rules

2018-02-13 Thread GitBox
markusthoemmes commented on a change in pull request #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#discussion_r16797 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala

[GitHub] mrutkows closed pull request #42: Add the documentation to describe the manual mode of release

2018-02-13 Thread GitBox
mrutkows closed pull request #42: Add the documentation to describe the manual mode of release URL: https://github.com/apache/incubator-openwhisk-release/pull/42 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] drcariel closed pull request #84: make travis more efficient

2018-02-13 Thread GitBox
drcariel closed pull request #84: make travis more efficient URL: https://github.com/apache/incubator-openwhisk-package-pushnotifications/pull/84 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mdeuser commented on issue #3262: Handle trigger activations with inactive rules

2018-02-13 Thread GitBox
mdeuser commented on issue #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#issuecomment-365370840 rebased on top of #3256 This is an automated message from

[GitHub] allen-servedio opened a new issue #735: Add support for credentials for private git repo dependencies

2018-02-13 Thread GitBox
allen-servedio opened a new issue #735: Add support for credentials for private git repo dependencies URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/735 Dependencies allows you to define a location and version of the artifact that you want to use. Here is an example:

[GitHub] mrutkows commented on a change in pull request #732: adding env. variable support in trigger feed

2018-02-13 Thread GitBox
mrutkows commented on a change in pull request #732: adding env. variable support in trigger feed URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/732#discussion_r167985232 ## File path: parsers/manifest_parser.go ## @@ -774,6 +774,10 @@ func (dm

[GitHub] mrutkows commented on a change in pull request #732: adding env. variable support in trigger feed

2018-02-13 Thread GitBox
mrutkows commented on a change in pull request #732: adding env. variable support in trigger feed URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/732#discussion_r167985426 ## File path: tests/dat/manifest_data_compose_triggers.yaml ## @@ -26,3 +26,8 @@

[GitHub] mrutkows commented on a change in pull request #732: adding env. variable support in trigger feed

2018-02-13 Thread GitBox
mrutkows commented on a change in pull request #732: adding env. variable support in trigger feed URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/732#discussion_r167985358 ## File path: parsers/manifest_parser_test.go ## @@ -1280,6 +1280,9 @@ func

[GitHub] jasonpet opened a new pull request #127: remove unused import from test

2018-02-13 Thread GitBox
jasonpet opened a new pull request #127: remove unused import from test URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/127 This is an automated message from the Apache Git Service. To respond to the

[GitHub] markusthoemmes closed pull request #2957: splunk logstore

2018-02-13 Thread GitBox
markusthoemmes closed pull request #2957: splunk logstore URL: https://github.com/apache/incubator-openwhisk/pull/2957 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] markusthoemmes commented on a change in pull request #3262: Handle trigger activations with inactive rules

2018-02-13 Thread GitBox
markusthoemmes commented on a change in pull request #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#discussion_r167970954 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala

[GitHub] rabbah closed pull request #3109: Add binary, image, and main properties to WhiskActionMetaData

2018-02-13 Thread GitBox
rabbah closed pull request #3109: Add binary, image, and main properties to WhiskActionMetaData URL: https://github.com/apache/incubator-openwhisk/pull/3109 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mrutkows closed pull request #732: adding env. variable support in trigger feed

2018-02-13 Thread GitBox
mrutkows closed pull request #732: adding env. variable support in trigger feed URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/732 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] markusthoemmes commented on a change in pull request #3262: Handle trigger activations with inactive rules

2018-02-13 Thread GitBox
markusthoemmes commented on a change in pull request #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#discussion_r167970273 ## File path: tests/src/test/scala/system/basic/WskBasicTests.scala ## @@ -748,6

[GitHub] pritidesai commented on issue #733: Enable Apache Rat plugin in gradle

2018-02-13 Thread GitBox
pritidesai commented on issue #733: Enable Apache Rat plugin in gradle URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/733#issuecomment-365373876 LGTM, thanks @daisy-ycguo This is an automated message from

[GitHub] mdeuser commented on issue #3275: WIP: GET trigger now returns matched rules in JSON payload

2018-02-13 Thread GitBox
mdeuser commented on issue #3275: WIP: GET trigger now returns matched rules in JSON payload URL: https://github.com/apache/incubator-openwhisk/pull/3275#issuecomment-365385500 @rabbah - i opened https://github.com/apache/incubator-openwhisk/issues/3281 to address the rules/trigger

[GitHub] mdeuser opened a new issue #3281: Consider limiting how many rules a single trigger can activate

2018-02-13 Thread GitBox
mdeuser opened a new issue #3281: Consider limiting how many rules a single trigger can activate URL: https://github.com/apache/incubator-openwhisk/issues/3281 From https://github.com/apache/incubator-openwhisk/pull/3275#issuecomment-365079127

[GitHub] lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs

2018-02-13 Thread GitBox
lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-365403918 Am I blocking this? I _think_ I've answered all the comments and this PR is ripe for another review, but

[GitHub] dubeejw commented on issue #3254: Preserve rule status when rule is updated

2018-02-13 Thread GitBox
dubeejw commented on issue #3254: Preserve rule status when rule is updated URL: https://github.com/apache/incubator-openwhisk/pull/3254#issuecomment-365413750 Turned out to be two different bugs. 1. Updating a rule with `wsk rule update` always returned a status of active. 2.

[GitHub] pritidesai opened a new pull request #737: adding info message with openwhisk url for runtimes

2018-02-13 Thread GitBox
pritidesai opened a new pull request #737: adding info message with openwhisk url for runtimes URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/737 Addressing two (todo) of converting const for HTTP headers. With this PR, `wskdeploy` produces info when the

[GitHub] dgrove-oss commented on issue #153: Add support for persistent storage.

2018-02-13 Thread GitBox
dgrove-oss commented on issue #153: Add support for persistent storage. URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/153#issuecomment-365431256 @ruromero - Thanks for the review. I think I will update to force it with selector.matchLabels. I was hoping to minimize

[GitHub] dubeejw commented on issue #3275: GET trigger now returns matched rules in JSON payload

2018-02-13 Thread GitBox
dubeejw commented on issue #3275: GET trigger now returns matched rules in JSON payload URL: https://github.com/apache/incubator-openwhisk/pull/3275#issuecomment-365404042 PG2 2804 ? This is an automated message from the

[GitHub] dubeejw commented on a change in pull request #3254: Preserve rule status when rule is updated

2018-02-13 Thread GitBox
dubeejw commented on a change in pull request #3254: Preserve rule status when rule is updated URL: https://github.com/apache/incubator-openwhisk/pull/3254#discussion_r168009396 ## File path: core/controller/src/main/scala/whisk/core/controller/Rules.scala ## @@ -85,11

[GitHub] mrutkows commented on issue #688: Move all hardcoded strings from Cobra commands and remaining .go files into i18n files.

2018-02-13 Thread GitBox
mrutkows commented on issue #688: Move all hardcoded strings from Cobra commands and remaining .go files into i18n files. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/688#issuecomment-365416835 Closes https://github.com/apache/incubator-openwhisk-wskdeploy/issues/683

[GitHub] mrutkows closed issue #683: wskdeply cobra command help missing i18n translations

2018-02-13 Thread GitBox
mrutkows closed issue #683: wskdeply cobra command help missing i18n translations URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/683 This is an automated message from the Apache Git Service. To respond

[GitHub] rabbah closed pull request #158: Add simple loadtesting jobs

2018-02-13 Thread GitBox
rabbah closed pull request #158: Add simple loadtesting jobs URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/158 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] dubeejw closed pull request #127: remove unused import from test

2018-02-13 Thread GitBox
dubeejw closed pull request #127: remove unused import from test URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/127 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] mrutkows opened a new pull request #736: Fix release document to clearly separate "git" command examples from command syntax

2018-02-13 Thread GitBox
mrutkows opened a new pull request #736: Fix release document to clearly separate "git" command examples from command syntax URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/736 This is an automated message

[GitHub] houshengbo closed pull request #736: Fix release document to clearly separate "git" command examples from command syntax

2018-02-13 Thread GitBox
houshengbo closed pull request #736: Fix release document to clearly separate "git" command examples from command syntax URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/736 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] csantanapr closed issue #15: Do not use own copy of actionProxy.py use common one from dockerskeleton

2018-02-13 Thread GitBox
csantanapr closed issue #15: Do not use own copy of actionProxy.py use common one from dockerskeleton URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/15 This is an automated message from the Apache

[GitHub] csantanapr commented on issue #15: Do not use own copy of actionProxy.py use common one from dockerskeleton

2018-02-13 Thread GitBox
csantanapr commented on issue #15: Do not use own copy of actionProxy.py use common one from dockerskeleton URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/15#issuecomment-365409992 Closed by #13

[GitHub] csantanapr commented on issue #19: move swift:4 to swift:4.0 add swift:4.1

2018-02-13 Thread GitBox
csantanapr commented on issue #19: move swift:4 to swift:4.0 add swift:4.1 URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/19#issuecomment-365411026 We can try add swift:4.1 as experimental which is still to be release, and create our image base on ubuntu until an

[GitHub] houshengbo opened a new pull request #43: Add the documentation to describe automated mode of release

2018-02-13 Thread GitBox
houshengbo opened a new pull request #43: Add the documentation to describe automated mode of release URL: https://github.com/apache/incubator-openwhisk-release/pull/43 This is an automated message from the Apache Git

[GitHub] dubeejw commented on a change in pull request #3254: Preserve rule status when rule is updated

2018-02-13 Thread GitBox
dubeejw commented on a change in pull request #3254: Preserve rule status when rule is updated URL: https://github.com/apache/incubator-openwhisk/pull/3254#discussion_r168010760 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -88,6 +88,35 @@

[GitHub] csantanapr opened a new pull request #20: rename swift4 o swift40 for kind and image

2018-02-13 Thread GitBox
csantanapr opened a new pull request #20: rename swift4 o swift40 for kind and image URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/20 Closes #19 This is an automated message from the Apache Git

[GitHub] csantanapr opened a new issue #19: move swift:4 to swift:4.0 add swift:4.1

2018-02-13 Thread GitBox
csantanapr opened a new issue #19: move swift:4 to swift:4.0 add swift:4.1 URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/19 With the recent release of swift 4.1 in Xcode Beta. I think is close to done, having `swift:4` it would be vague which version of swift

[GitHub] dubeejw commented on a change in pull request #3254: Preserve rule status when rule is updated

2018-02-13 Thread GitBox
dubeejw commented on a change in pull request #3254: Preserve rule status when rule is updated URL: https://github.com/apache/incubator-openwhisk/pull/3254#discussion_r168027670 ## File path: tests/src/test/scala/whisk/core/controller/test/RulesApiTests.scala ## @@

[GitHub] allen-servedio commented on issue #735: Add support for credentials for private git repo dependencies

2018-02-13 Thread GitBox
allen-servedio commented on issue #735: Add support for credentials for private git repo dependencies URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/735#issuecomment-365482729 Further, this should allow valid urls such as `https://username:passw...@example.com`. This

[GitHub] chetanmeh commented on issue #3283: Add implicit ClassTag for entity type

2018-02-13 Thread GitBox
chetanmeh commented on issue #3283: Add implicit ClassTag for entity type URL: https://github.com/apache/incubator-openwhisk/pull/3283#issuecomment-365508673 > Can you provide an implementation example of where a ClassTag would be needed? Have a look at [MongoDbStoreProvider][1]

  1   2   >