[GitHub] cbickel commented on issue #3427: Add Gatling tests to test performance.
cbickel commented on issue #3427: Add Gatling tests to test performance. URL: https://github.com/apache/incubator-openwhisk/pull/3427#issuecomment-381852285 @dubee Reopening this PR as WIP, as here is an additional Load Test and the ability to test action-related calls. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel opened a new pull request #3427: Add Gatling tests to test performance.
cbickel opened a new pull request #3427: Add Gatling tests to test performance. URL: https://github.com/apache/incubator-openwhisk/pull/3427 Add Gatling tests to test performance. ## Description This PR adds gatling to the project. It can be used to test the performance of an Openwhisk system. To easily write new tests, I also provided a small `OpenWhisk-Gatling-extension` and some example tests. ## Related issue and scope - [ ] I opened an issue to propose and discuss this change ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [x] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
chetanmeh commented on issue #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#issuecomment-381838488 @markusthoemmes If the PG test has passed can this PR be approved and merged? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #2855: Cache database attachments
chetanmeh commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381837539 > @chetanmeh, do you think fetching actions from disk will be faster than fetching them from CouchDB? For our usecase we would be pulling attachments from Azure Blob Storage where latency may be higher (based on my previous experience with S3). Would have a benchmark to compare before proceeding with a disk based cache. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3546: Fix vagrant not use runc
csantanapr commented on issue #3546: Fix vagrant not use runc URL: https://github.com/apache/incubator-openwhisk/pull/3546#issuecomment-381815538 I was able to figure out how to increase the size of the disk with a vagrant plugin. @mdeuser check if the plugin works on windows. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #274: Revert the Travis build due to the recent failures
daisy-ycguo closed pull request #274: Revert the Travis build due to the recent
failures
URL: https://github.com/apache/incubator-openwhisk-cli/pull/274
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index ecc08006..f1782d4d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -71,12 +71,25 @@ script:
after_success:
- export DEPLOY_BUILD_READY=true
+ - if [ "$TRAVIS_EVENT_TYPE" == "cron" ] ; then
+ export DEPLOY_BUILD_READY=false;
+fi
before_deploy:
- export RELEASE_PKG_FILE="$(cd "$TRAVIS_BUILD_DIR/release" && ls
${zip_file_name}-*.tgz ${zip_file_name}-*.zip)"
- echo "Deploying $RELEASE_PKG_FILE to GitHub releases."
- export GIT_TAG="latest"
- export TAG=false;
+ # This tag is automatically generated for the latest merged commit in master
branch.
+ - if [ "$TRAVIS_BRANCH" == "master" ] && [ "$TRAVIS_EVENT_TYPE" == "push" ]
&& [ "$TRAVIS_OS_NAME" == "linux" ] ; then
+ git config --global user.email "bui...@travis-ci.com";
+ git config --global user.name "Travis CI";
+ export GIT_TAG="latest";
+ git tag -d $GIT_TAG;
+ git push -q https://$api_...@github.com/apache/incubator-openwhisk-cli
:refs/tags/$GIT_TAG;
+ GIT_COMMITTER_DATE="$(git show --format=%aD | head -1)" git tag $GIT_TAG
-a -m "Generated tag from Travis CI build $TRAVIS_BUILD_NUMBER";
+ git push -f -q
https://$api_...@github.com/apache/incubator-openwhisk-cli $GIT_TAG;
+fi
- if [ ! -z "$TRAVIS_TAG" ] ; then
export GIT_TAG=$TRAVIS_TAG;
export TAG=true;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr closed pull request #181: configurable timeout for travis/build.sh
csantanapr closed pull request #181: configurable timeout for travis/build.sh
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/181
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/travis/build.sh b/tools/travis/build.sh
index e59c8d8..28f1d89 100755
--- a/tools/travis/build.sh
+++ b/tools/travis/build.sh
@@ -11,7 +11,7 @@ couchdbHealthCheck () {
PASSED=false
TIMEOUT=0
- until [ $TIMEOUT -eq 60 ]; do
+ until [ $TIMEOUT -eq $TIMEOUT_STEP_LIMIT ]; do
if [ -n "$(kubectl -n openwhisk logs $POD_NAME | grep "successfully setup
and configured CouchDB")" ]; then
PASSED=true
break
@@ -39,7 +39,7 @@ deploymentHealthCheck () {
PASSED=false
TIMEOUT=0
- until $PASSED || [ $TIMEOUT -eq 60 ]; do
+ until $PASSED || [ $TIMEOUT -eq $TIMEOUT_STEP_LIMIT ]; do
KUBE_DEPLOY_STATUS=$(kubectl -n openwhisk get pods -l name="$1" -o wide |
grep "$1" | awk '{print $3}')
if [ "$KUBE_DEPLOY_STATUS" == "Running" ]; then
PASSED=true
@@ -70,7 +70,7 @@ statefulsetHealthCheck () {
PASSED=false
TIMEOUT=0
- until $PASSED || [ $TIMEOUT -eq 60 ]; do
+ until $PASSED || [ $TIMEOUT -eq $TIMEOUT_STEP_LIMIT ]; do
KUBE_DEPLOY_STATUS=$(kubectl -n openwhisk get pods -l name="$1" -o wide |
grep "$1"-0 | awk '{print $3}')
if [ "$KUBE_DEPLOY_STATUS" == "Running" ]; then
PASSED=true
@@ -102,7 +102,7 @@ jobHealthCheck () {
PASSED=false
TIMEOUT=0
- until $PASSED || [ $TIMEOUT -eq 60 ]; do
+ until $PASSED || [ $TIMEOUT -eq $TIMEOUT_STEP_LIMIT ]; do
KUBE_SUCCESSFUL_JOB=$(kubectl -n openwhisk get jobs -o wide | grep "$1" |
awk '{print $3}')
if [ "$KUBE_SUCCESSFUL_JOB" == "1" ]; then
PASSED=true
@@ -138,6 +138,9 @@ ROOTDIR="$SCRIPTDIR/../../"
# Default to docker container factory if not specified
OW_CONTAINER_FACTORY=${OW_CONTAINER_FACTORY:="docker"}
+# Default timeout limit to 60 steps
+TIMEOUT_STEP_LIMIT=${TIMEOUT_STEP_LIMIT:=60}
+
cd $ROOTDIR
# Label invoker nodes (needed for DockerContainerFactory-based invoker
deployment)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #153: Add support for persistent storage.
csantanapr commented on issue #153: Add support for persistent storage. URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/153#issuecomment-381799893 bump @dgrove-oss This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #173: update runtimes.json with swift4
csantanapr commented on issue #173: update runtimes.json with swift4 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/173#issuecomment-381799750 Closed by #174 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #173: update runtimes.json with swift4
csantanapr closed issue #173: update runtimes.json with swift4 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/173 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #175: improve docs with macos specific instructions
csantanapr closed issue #175: improve docs with macos specific instructions URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/175 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #175: improve docs with macos specific instructions
csantanapr commented on issue #175: improve docs with macos specific instructions URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/175#issuecomment-381799578 Closed by #176 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #114: Initial markdown to track project LICENSES, NOTICES and provide summa…
mrutkows opened a new pull request #114: Initial markdown to track project LICENSES, NOTICES and provide summa… URL: https://github.com/apache/incubator-openwhisk-release/pull/114 …ry of notable references. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #113: Improve Maven/Java Tooling
ddragosd commented on issue #113: Improve Maven/Java Tooling URL: https://github.com/apache/incubator-openwhisk-devtools/pull/113#issuecomment-381773277 @klcodanr your proposal SGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd closed pull request #117: do docker pull for quick start
ddragosd closed pull request #117: do docker pull for quick start
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/117
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docker-compose/Makefile b/docker-compose/Makefile
index 848d9d1..0a0d52d 100644
--- a/docker-compose/Makefile
+++ b/docker-compose/Makefile
@@ -22,7 +22,7 @@ OPEN_WHISK_DB_PREFIX ?= local_
DOCKER_KERNEL ?= $(shell docker version --format "{{.Server.KernelVersion}}")
ifeq ("$(UNAME_STR)","Linux")
DOCKER_BINARY ?= $(shell (which docker))
-else
+else
DOCKER_BINARY ?= $(shell if [[ $(DOCKER_KERNEL) == *-moby ||
$(DOCKER_KERNEL) == *-boot2docker ]]; then (docker run --rm --privileged
--pid=host debian nsenter -t 1 -m -u -n -i sh -c "which docker"); else (which
docker); fi)
endif
ifndef VERBOSE
@@ -34,7 +34,7 @@ endif
# 2. then it starts all components using docker-compose
# 3. it runs a sample hello-world function
# To stop and cleanup the environment use: make destroy
-quick-start: download download-cli run quick-start-pause hello-world
quick-start-info
+quick-start: download download-cli docker_pull run quick-start-pause
hello-world quick-start-info
add-catalog: download-catalog init-catalog
@@ -73,10 +73,36 @@ quick-start-info:
echo "$$(tput setaf 2)To invoke the function again use: $$(tput setaf
4)make hello-world$$(tput sgr0)"
echo "$$(tput setaf 2)To stop openwhisk use: $$(tput setaf 4)make
destroy$$(tput sgr0)"
-docker:
- echo "building the docker images ... "
+docker_build:
+ echo "building the docker images short list ... "
+ cd $(OPENWHISK_PROJECT_HOME) && \
+ ./gradlew distDocker -PdockerImagePrefix=$(DOCKER_IMAGE_PREFIX)
-x :actionRuntimes:pythonAction:distDocker -x
:actionRuntimes:python2Action:distDocker -x
actionRuntimes:swift3.1.1Action:distDocker -x
actionRuntimes:swift4.1Action:distDocker -x
:actionRuntimes:javaAction:distDocker
+
+docker_build_full:
+ echo "building the docker images full list ... "
cd $(OPENWHISK_PROJECT_HOME) && \
- ./gradlew distdocker -x :core:swift3Action:distDocker -x
:core:swiftAction:distDocker
+ ./gradlew distDocker -PdockerImagePrefix=$(DOCKER_IMAGE_PREFIX)
+
+docker_pull:
+ echo "pulling the docker images short list... "
+ docker pull $(DOCKER_IMAGE_PREFIX)/controller
+ docker pull $(DOCKER_IMAGE_PREFIX)/invoker
+ docker pull $(DOCKER_IMAGE_PREFIX)/nodejs6action
+ docker pull $(DOCKER_IMAGE_PREFIX)/dockerskeleton
+
+docker_pull_full:
+ echo "pulling the docker images full list ... "
+ docker pull $(DOCKER_IMAGE_PREFIX)/controller
+ docker pull $(DOCKER_IMAGE_PREFIX)/invoker
+ docker pull $(DOCKER_IMAGE_PREFIX)/nodejs6action
+ docker pull $(DOCKER_IMAGE_PREFIX)/action-nodejs-v8
+ docker pull $(DOCKER_IMAGE_PREFIX)/python2action
+ docker pull $(DOCKER_IMAGE_PREFIX)/python3action
+ docker pull $(DOCKER_IMAGE_PREFIX)/action-swift-v3.1.1
+ docker pull $(DOCKER_IMAGE_PREFIX)/action-swift-v4.1
+ docker pull $(DOCKER_IMAGE_PREFIX)/java8action
+ docker pull $(DOCKER_IMAGE_PREFIX)/action-php-v7.1
+ docker pull $(DOCKER_IMAGE_PREFIX)/dockerskeleton
download-cli:
echo "downloading the CLI tool ... "
diff --git a/docker-compose/README.md b/docker-compose/README.md
index 7d0d08d..d0c58a0 100644
--- a/docker-compose/README.md
+++ b/docker-compose/README.md
@@ -81,15 +81,21 @@ make restart-controller
* Check the [issue
tracker](https://github.com/apache/incubator-openwhisk-devtools/issues) for
more.
-# Build
+# Build or Pull
+You can pull pre-built image
```bash
-make docker
+make docker_pull
```
-This command builds the docker containers for local testing and development.
+This command pulls the docker images for local testing and development.
+
+```bash
+make docker_build
+```
+
+This command builds the docker images for local testing and development.
-> NOTE: The build may skip some components such as Swift actions in order to
finish the build faster.
# Start
@@ -200,6 +206,6 @@ These 2 variable allow you to execute a JS action using the
container `registry.
## Local Docker containers for controllers and invokers
-By default this setup uses published images for controller and invokers from
`openwhisk` namespace i.e.
+By default this setup uses published images for controller and invokers from
`openwhisk` namespace i.e.
`openwhisk/controller` and `openwhisk/invoker`. To make use of locally build
images you can use `DOCKER_OW_IMAGE_PREFIX`
variable i.e. `DOCKER_OW_IMAGE_PREFIX=whisk make quick-start`
This is an
[GitHub] ddragosd closed issue #115: make docker failes with Project 'swift3Action' not found in project ':core'.
ddragosd closed issue #115: make docker failes with Project 'swift3Action' not found in project ':core'. URL: https://github.com/apache/incubator-openwhisk-devtools/issues/115 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #117: do docker pull for quick start
ddragosd commented on issue #117: do docker pull for quick start URL: https://github.com/apache/incubator-openwhisk-devtools/pull/117#issuecomment-381766191 @csantanapr This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd closed issue #116: docker compose make quick start hangs
ddragosd closed issue #116: docker compose make quick start hangs URL: https://github.com/apache/incubator-openwhisk-devtools/issues/116 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #866: Export blackbox
pritidesai commented on issue #866: Export blackbox URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/866#issuecomment-381763727 thanks @kpavel for fixing creating zip files, I am running into one more issue, when I try to deploy using exported manifest, whisk deploy fails with: ``` ./wskdeploy sync -m manifest.yaml --projectname AAA Info: The API host is [openwhisk.ng.bluemix.net], from .wskprops. Info: The auth key is set, from .wskprops. Info: The namespace is [*], from .wskprops. Info: The apigw access token is set, from .wskprops. Info: Unmarshal OpenWhisk runtimes from internet at https://openwhisk.ng.bluemix.net. Warning: The project name has been overridden. Using AAA Warning: The mandatory key [package license] should be set. Using default value [unlicensed]... Warning: The value for key [package version] is not saved in the current version of wskdeploy. Warning: Invalid or missing runtime [blackbox] specified in manifest for the action [CustomDockerAction2]. Error: manifestreader.go [78]: [ERROR_YAML_FILE_FORMAT_ERROR]: File: [manifest.yaml]: ==> manifest_parser.go [618]: [ERROR_YAML_INVALID_RUNTIME]: File: [manifest.yaml]: Invalid or missing runtime [blackbox] specified in manifest for the action [CustomDockerAction2]. ==> Action [CustomDockerAction2]: Runtime [blackbox]: Supported Runtimes [java, php:7.1, python, python:2, python:3, python-jessie:3, swift:3.1.1, swift:4.1, nodejs:6, nodejs:8] ==> ``` Can you please fix this error? Please update it so that runtime is set to empty string. You have docker set to the appropriate image which is sufficient in this case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #866: Export blackbox
pritidesai commented on issue #866: Export blackbox URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/866#issuecomment-381763727 thanks @kpavel for fixing creating zip files, I am running into one more issue, when I try to deploy using exported manifest, whisk deploy fails with: ``` ./wskdeploy sync -m manifest.yaml --projectname AAA Info: The API host is [openwhisk.ng.bluemix.net], from .wskprops. Info: The auth key is set, from .wskprops. Info: The namespace is [*], from .wskprops. Info: The apigw access token is set, from .wskprops. Info: Unmarshal OpenWhisk runtimes from internet at https://openwhisk.ng.bluemix.net. Warning: The project name has been overridden. Using AAA Warning: The mandatory key [package license] should be set. Using default value [unlicensed]... Warning: The value for key [package version] is not saved in the current version of wskdeploy. Warning: Invalid or missing runtime [blackbox] specified in manifest for the action [CustomDockerAction2]. Error: manifestreader.go [78]: [ERROR_YAML_FILE_FORMAT_ERROR]: File: [manifest.yaml]: ==> manifest_parser.go [618]: [ERROR_YAML_INVALID_RUNTIME]: File: [manifest.yaml]: Invalid or missing runtime [blackbox] specified in manifest for the action [CustomDockerAction2]. ==> Action [CustomDockerAction2]: Runtime [blackbox]: Supported Runtimes [java, php:7.1, python, python:2, python:3, python-jessie:3, swift:3.1.1, swift:4.1, nodejs:6, nodejs:8] ==> ``` Can you please fix this error? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #181: configurable timeout for travis/build.sh
dgrove-oss opened a new pull request #181: configurable timeout for travis/build.sh URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/181 Add hook to allow overriding the timeout value used when waiting for a pod to be successfully deployed. I've found when running locally on a fresh minikube VM, it can sometimes take an excessively long time to pull images from dockerhub into the docker registry within the minikube cluster. Setting a high timeout limit avoids needing to run the script multiple times to pull in the needed images. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3546: Fix vagrant not use runc
csantanapr commented on issue #3546: Fix vagrant not use runc URL: https://github.com/apache/incubator-openwhisk/pull/3546#issuecomment-381757084 >May be we can pin Docker version to one where runc works. As while working on Mac if I need to try/test out any runc related aspect I rely on Vagrant image. So if it works with some older version we can pin Docker to that and keep runc enabled The problem vagrant is using ubuntu16 and installs latest stable, for example 18.03.0-ce, so the invoker image would need to be rebuild with the matching version. If you are trying and testing runc related things, then is better to experiment with the latest stable release. I added docs for this special case, for an user to experiment with runc. The version we recommend and we currently test in Travis and have it pinned in the invoker is an older version 1.12 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #871: Create Markdown describing LICENSE file creation process
mrutkows opened a new issue #871: Create Markdown describing LICENSE file creation process URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/871 We need to capture our own rules/policies, conventions and procedures for creating LICENSE file for any repo. under the Apache OpenWhisk project. It should include how we handle well-known exception procesess (e.g., copy-left, etc.) with examples for MIT/Google, etc, type licenses, as well as create a TEMPLATE file that has sections to fill out that includes (our conventions): - Link back to the process page (that I am suggesting we create using this issue) - Sections for 1) listing source LICENSE exceptions 2) listing Binary file exceptions where the "binary" exception list clearly states "these are binary library dependencies" that we do not copy into source and do not alter the code for. Also, each license we list or copy should have a clear SEPARATOR, for example # - So readers can easily see where one license stops and another starts (when they are copied in by requirements). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #275: Add the latest build back
houshengbo closed pull request #275: Add the latest build back
URL: https://github.com/apache/incubator-openwhisk-cli/pull/275
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index ecc08006..13f77eef 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -71,12 +71,24 @@ script:
after_success:
- export DEPLOY_BUILD_READY=true
+ - if [ "$TRAVIS_EVENT_TYPE" == "cron" ] ; then
+ export DEPLOY_BUILD_READY=false;
+fi
before_deploy:
- export RELEASE_PKG_FILE="$(cd "$TRAVIS_BUILD_DIR/release" && ls
${zip_file_name}-*.tgz ${zip_file_name}-*.zip)"
- echo "Deploying $RELEASE_PKG_FILE to GitHub releases."
- export GIT_TAG="latest"
- export TAG=false;
+ - if [ "$TRAVIS_BRANCH" == "master" ] && [ "$TRAVIS_EVENT_TYPE" == "push" ]
&& [ "$TRAVIS_OS_NAME" == "linux" ] ; then
+ git config --global user.email "bui...@travis-ci.com";
+ git config --global user.name "Travis CI";
+ export GIT_TAG="latest";
+ git tag -d $GIT_TAG;
+ git push -q https://$api_...@github.com/apache/incubator-openwhisk-cli
:refs/tags/$GIT_TAG;
+ GIT_COMMITTER_DATE="$(git show --format=%aD | head -1)" git tag $GIT_TAG
-a -m "Generated tag from Travis CI build $TRAVIS_BUILD_NUMBER";
+ git push -f -q
https://$api_...@github.com/apache/incubator-openwhisk-cli $GIT_TAG;
+fi
- if [ ! -z "$TRAVIS_TAG" ] ; then
export GIT_TAG=$TRAVIS_TAG;
export TAG=true;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houshengbo opened a new pull request #275: Add the latest build back
houshengbo opened a new pull request #275: Add the latest build back URL: https://github.com/apache/incubator-openwhisk-cli/pull/275 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #274: Revert the Travis build due to the recent failures
houshengbo opened a new pull request #274: Revert the Travis build due to the recent failures URL: https://github.com/apache/incubator-openwhisk-cli/pull/274 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381743878 I'm not very concerned about the controller caching Java actions. Mostly the action invoke path is used in the controller. With that action invoke API in the controller, only action metadata is cached, which does not include the action code. @chetanmeh, do you think fetching actions from disk will be faster than fetching them from CouchDB? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381743878 I'm not very concerned about the controller caching Java actions. Mostly the action invoke path is used in the controller. With that action invoke API in the controller, only an action metadata is cached, which does not include the action code. @chetanmeh, do you think fetching actions from disk will be faster than fetching them from Cloudant? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381743878 I'm not very concerned about the controller caching Java actions. Mostly the action invoke path is used in the controller. With that action invoke API in the controller, only an action metadata is cached, which does not include the action code. @chetanmeh, do you think fetching actions from disk will be faster than fetching them from CouchDB? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381743878 I'm not very concerned about the controller caching Java actions. Mostly the action invoke path is used in the controller. With that action invoke API in the controller, only an action metadata is cached, which does not include the action code. @chetanmeh, do you think fetching from actions from disk will be faster than fetching them from Cloudant? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #113: Document project position on release of "test" files
mrutkows opened a new issue #113: Document project position on release of "test" files URL: https://github.com/apache/incubator-openwhisk-release/issues/113 We have decided not to package the test files with the source code artifacts (TAR). We should document this decision, along with supporting links or examples that show this decision is supported by Apache by policy (and perhaps by example in other projects). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #3553: README's Repo structure diagram incorrectly lists "openwhisk-swift"
mrutkows opened a new issue #3553: README's Repo structure diagram incorrectly lists "openwhisk-swift" URL: https://github.com/apache/incubator-openwhisk/issues/3553 ## Environment details: * local deployment, vagrant, native ubuntu, Mac OS, Bluemix, ... * version of docker, vagrant, ubuntu, ... ## Steps to reproduce the issue: 1. View README ## Provide the expected results and outputs: ``` Fix diagram to remove "openwhisk-swift" as a project repo. ``` ## Provide the actual results and outputs: ``` N/A ``` ## Additional information you deem important: * issue happens only occasionally or under certain circumstances * changes you did or observed in the environment This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #15: Add the license of dependencies into LICENSE file
houshengbo opened a new pull request #15: Add the license of dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/15 Partially-closes: apache/incubator-openwhisk-release#109 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381727877 @bbrowning, how many invokers are you using in your test cluster? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #44: Add the licenses of dependencies into LICENSE file
houshengbo opened a new pull request #44: Add the licenses of dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/44 Partially-closes: apache/incubator-openwhisk-release#109 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #3427: Add Gatling tests to test performance.
dubee closed pull request #3427: Add Gatling tests to test performance.
URL: https://github.com/apache/incubator-openwhisk/pull/3427
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/gatlingtests/README.md b/gatlingtests/README.md
new file mode 100644
index 00..808e9132f6
--- /dev/null
+++ b/gatlingtests/README.md
@@ -0,0 +1,55 @@
+# Gatling Tests
+
+These tests can be used to test the performance of a deployed OpenWhisk-system.
+
+## Simulations
+
+You can specify two thresholds for the simulations.
+The reason is, that Gatling is able to handle each assertion as a JUnit test.
+On using CI/CD pipelines (e.g. Jenkins) you will be able to set a threshold on
an amount of failed testcases to mark the build as stable, unstable and failed.
+
+### ApiV1Simulation
+
+This Simulation calls the `api/v1`.
+You can specify the endpoint, the amount of connections against the backend
and the duration of this burst.
+
+Available environment variables:
+
+```
+OPENWHISK_HOST (required)
+CONNECTIONS (required)
+SECONDS (default: 10)
+REQUESTS_PER_SEC(required)
+MIN_REQUESTS_PER_SEC(default: REQUESTS_PER_SEC)
+```
+
+You can run the simulation with
+```
+OPENWHISK_HOST="openwhisk.mydomain.com" CONNECTIONS="10" REQUESTS_PER_SEC="50"
./gradlew gatlingRun-ApiV1Simulation
+```
+
+### BlockingInvokeOneActionSimulation
+
+This simulation executes the same action with the same user over and over
again.
+The aim of this test is, to test the throughput of the system, if all
containers are always warm.
+
+The action that is invoked, writes one log line and returns a little json.
+
+The simulations creates the action in the beginning, invokes it as often as
possible for 5 seconds, to warm all containers up and invokes it afterwards for
the given amount of time.
+The warmup-phase will not be part of the assertions.
+
+To run the test, you can specify the amount of concurrent requests. Keep in
mind, that the actions are invoked blocking and the system is limited to
`AMOUNT_OF_INVOKERS * SLOTS_PER_INVOKER * NON_BLACKBOX_INVOKER_RATIO`
concurrent actions/requests.
+
+Available environment variables:
+```
+OPENWHISK_HOST (required)
+CONNECTIONS (required)
+SECONDS (default: 10)
+REQUESTS_PER_SEC(required)
+MIN_REQUESTS_PER_SEC(default: REQUESTS_PER_SEC)
+```
+
+You can run the simulation with
+```
+OPENWHISK_HOST="openwhisk.mydomain.com" CONNECTIONS="10" REQUESTS_PER_SEC="50"
./gradlew gatlingRun-BlockingInvokeOneActionSimulation
+```
diff --git a/gatlingtests/build.gradle b/gatlingtests/build.gradle
new file mode 100644
index 00..dc0616f07b
--- /dev/null
+++ b/gatlingtests/build.gradle
@@ -0,0 +1,25 @@
+buildscript {
+repositories {
+jcenter()
+}
+dependencies {
+classpath "cz.alenkacz:gradle-scalafmt:1.6.0"
+}
+}
+
+plugins {
+id "com.github.lkishalmi.gatling" version "0.7.1"
+}
+
+apply plugin: 'eclipse'
+apply plugin: 'scala'
+
+repositories {
+mavenCentral()
+}
+
+dependencies {
+compile "org.scala-lang:scala-library:2.12.4"
+compile "io.gatling.highcharts:gatling-charts-highcharts:2.2.5"
+gatling "io.spray:spray-json_2.12:1.3.4"
+}
diff --git a/gatlingtests/src/gatling/resources/conf/logback.xml
b/gatlingtests/src/gatling/resources/conf/logback.xml
new file mode 100644
index 00..62bd2b255d
--- /dev/null
+++ b/gatlingtests/src/gatling/resources/conf/logback.xml
@@ -0,0 +1,14 @@
+
+
+
+
+%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} -
%msg%n
+false
+
+
+
+
+
+
+
+
diff --git a/gatlingtests/src/gatling/resources/data/dosCPU.js
b/gatlingtests/src/gatling/resources/data/dosCPU.js
new file mode 100644
index 00..e70a64bcfb
--- /dev/null
+++ b/gatlingtests/src/gatling/resources/data/dosCPU.js
@@ -0,0 +1,17 @@
+function sleep(milliseconds) {
+var start = new Date().getTime();
+while (true) {
+var now = new Date().getTime();
+if ((now - start) > milliseconds) {
+break;
+}
+}
+}
+
+function main(msg) {
+var busytime = msg.busytime || 100;
+sleep(busytime);
+var res = '[OK] message terminated successfully after ' + busytime + '
ms.';
+console.log('dosCPU', 'result:', res);
+return { msg: res };
+}
diff --git a/gatlingtests/src/gatling/resources/data/nodeJSAction.js
b/gatlingtests/src/gatling/resources/data/nodeJSAction.js
new file mode 100644
index 00..4867a4ee04
--- /dev/null
+++ b/gatlingtests/src/gatling/resources/data/nodeJSAction.js
@@ -0,0 +1,8 @@
+function main(params) {
+var greeting = "Hello stranger!";
+if (params.text) {
+greeting = "Hello
[GitHub] dubee commented on issue #3427: Add Gatling tests to test performance.
dubee commented on issue #3427: Add Gatling tests to test performance. URL: https://github.com/apache/incubator-openwhisk/pull/3427#issuecomment-381719983 @cbickel, closing this PR since it looks like we went with https://github.com/apache/incubator-openwhisk/pull/3526. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3495: Update akka to 2.5.12 and akka-http to 10.1.1.
dubee commented on issue #3495: Update akka to 2.5.12 and akka-http to 10.1.1. URL: https://github.com/apache/incubator-openwhisk/pull/3495#issuecomment-381622789 PG3 2143 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #32: Add the licensesof the dependencies into LICENSE file
houshengbo opened a new pull request #32: Add the licensesof the dependencies into LICENSE file URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/32 Partially-closes: apache/incubator-openwhisk-release#109 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yadavvipinsonu commented on issue #2317: wsk api authentication issues
yadavvipinsonu commented on issue #2317: wsk api authentication issues
URL:
https://github.com/apache/incubator-openwhisk/issues/2317#issuecomment-381705113
@mdeuser thanks !
CLI is not installed correctly. when i run
ansible-playbook -i environments/local openwhisk.yml
Monday 16 April 2018 11:00:41 -0400 (0:00:00.574) 0:00:49.831
**
fatal: [controller0]: FAILED! => {"changed": false, "msg": "Error pulling
image whisk/controller:latest - 404 Client Error: Not Found
(\"{\"message\":\"pull access denied for whisk/controller, repository does not
exist or may require 'docker login'\"}\")"}
Error pulling image whisk/controller:latest - 404 Client Error: Not Found
("{"message":"pull access denied for whisk/controller, repository does not
exist
or may require 'docker login'"}")
i tried running routemgmnt.yml also , it failed with connection refused
error
ansible-playbook -i environments/local routemgmt.yml
TASK [cli-install : Grab the local CLI from the binaries unarchived into
nginx]
Monday 16 April 2018 11:16:18 -0400 (0:00:03.486) 0:00:10.615
**
fatal: [ansible]: FAILED! => {"changed": false, "dest":
"/home/mparuthickal/openwhisk/ansible/../bin", "gid": 0, "group": "root",
"mode": "0755", "msg": "Request failed: ", "owner": "root", "size": 4096, "state": "directory", "uid": 0,
"url": "https://172.17.0.1/cli/go/download/linux/amd64/wsk"}
Request failed:
--
Tried on cent-os 7 and ubuntu16.04 both.
It will be great if you can share some specific page you know which i can
follow to get openwhisk up and running including api mgmt .
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee closed pull request #273: Fix spray-json import to comply with newer versions.
dubee closed pull request #273: Fix spray-json import to comply with newer versions. URL: https://github.com/apache/incubator-openwhisk-cli/pull/273 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tests/src/test/scala/system/basic/WskCliBasicTests.scala b/tests/src/test/scala/system/basic/WskCliBasicTests.scala index decf8614..cf964e5d 100644 --- a/tests/src/test/scala/system/basic/WskCliBasicTests.scala +++ b/tests/src/test/scala/system/basic/WskCliBasicTests.scala @@ -34,7 +34,6 @@ import common.WskProps import common.WskTestHelpers import spray.json._ import spray.json.DefaultJsonProtocol._ -import spray.json.pimpAny import whisk.http.Messages This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] duynguyen opened a new pull request #3: Pin openwhisk version
duynguyen opened a new pull request #3: Pin openwhisk version URL: https://github.com/apache/incubator-openwhisk-deploy-mesos/pull/3 Updated env vars as of 04/16. Pinned openwhisk version for controller and invoker. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions
csantanapr closed pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java
runtime for Java actions
URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/24
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/javaAction/Dockerfile b/core/javaAction/Dockerfile
index 93add0f..e8f43a5 100644
--- a/core/javaAction/Dockerfile
+++ b/core/javaAction/Dockerfile
@@ -1,38 +1,23 @@
-FROM buildpack-deps:trusty-curl
+FROM adoptopenjdk/openjdk8-openj9:jdk8u162-b12_openj9-0.8.0
-ENV DEBIAN_FRONTEND noninteractive
+RUN rm -rf /var/lib/apt/lists/* && apt-get clean && apt-get update \
+ && apt-get install -y --no-install-recommends locales \
+ && rm -rf /var/lib/apt/lists/* \
+ && locale-gen en_US.UTF-8
-RUN locale-gen en_US.UTF-8
-ENV LANG en_US.UTF-8
-ENV LANGUAGE en_US:en
-ENV LC_ALL en_US.UTF-8
-
-ENV VERSION 8
-ENV UPDATE 131
-ENV BUILD 11
-
-ENV JAVA_HOME /usr/lib/jvm/java-${VERSION}-oracle
-ENV JRE_HOME ${JAVA_HOME}/jre
-
-RUN curl --silent --location --retry 3 --cacert
/etc/ssl/certs/GeoTrust_Global_CA.pem \
- --header "Cookie: oraclelicense=accept-securebackup-cookie;" \
-
http://download.oracle.com/otn-pub/java/jdk/"${VERSION}"u"${UPDATE}"-b"${BUILD}"/d54c1d3a095b4ff2b6607d096fa80163/server-jre-"${VERSION}"u"${UPDATE}"-linux-x64.tar.gz
\
- | tar xz -C /tmp && \
- mkdir -p /usr/lib/jvm && mv /tmp/jdk1.${VERSION}.0_${UPDATE} "${JAVA_HOME}"
&& \
- apt-get autoclean && apt-get --purge -y autoremove && \
- rm -rf /tmp/* /var/tmp/*
-
-RUN update-alternatives --install "/usr/bin/java" "java"
"${JRE_HOME}/bin/java" 1 && \
- update-alternatives --install "/usr/bin/javac" "javac"
"${JAVA_HOME}/bin/javac" 1 && \
- update-alternatives --set java "${JRE_HOME}/bin/java" && \
- update-alternatives --set javac "${JAVA_HOME}/bin/javac"
+ENV LANG="en_US.UTF-8" \
+ LANGUAGE="en_US:en" \
+ LC_ALL="en_US.UTF-8" \
+ VERSION=8 \
+ UPDATE=162 \
+ BUILD=12
ADD proxy /javaAction
-RUN rm -rf /javaAction/.classpath /javaAction/.gitignore /javaAction/.gradle
/javaAction/.project /javaAction/.settings /javaAction/Dockerfile
/javaAction/build
-
-RUN cd /javaAction; ./gradlew oneJar
-
-RUN rm -rf /javaAction/src
+RUN cd /javaAction \
+ && rm -rf .classpath .gitignore .gradle .project .settings Dockerfile
build \
+ && ./gradlew oneJar \
+ && rm -rf /javaAction/src \
+ && ./compileClassCache.sh
-CMD ["java", "-jar", "/javaAction/build/libs/javaAction-all.jar"]
+CMD ["java", "-Dfile.encoding=UTF-8",
"-Xshareclasses:cacheDir=/javaSharedCache,readonly", "-Xquickstart", "-jar",
"/javaAction/build/libs/javaAction-all.jar"]
diff --git a/core/javaAction/proxy/compileClassCache.sh
b/core/javaAction/proxy/compileClassCache.sh
new file mode 100755
index 000..bf1d4fa
--- /dev/null
+++ b/core/javaAction/proxy/compileClassCache.sh
@@ -0,0 +1,6 @@
+#!/bin/bash
+ Construct Class Cache with HTTP Server classes by starting the server
+java "-Xshareclasses:cacheDir=/javaSharedCache/" "-Xquickstart" "-jar"
"/javaAction/build/libs/javaAction-all.jar" &
+HTTP_PID=$!
+sleep 2
+kill $HTTP_PID
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee closed pull request #143: Fix spray-json import to comply with newer versions.
dubee closed pull request #143: Fix spray-json import to comply with newer
versions.
URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/143
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/system/health/AlarmsHealthFeedTests.scala
b/tests/src/test/scala/system/health/AlarmsHealthFeedTests.scala
index 3db4b0b..1520bf2 100644
--- a/tests/src/test/scala/system/health/AlarmsHealthFeedTests.scala
+++ b/tests/src/test/scala/system/health/AlarmsHealthFeedTests.scala
@@ -20,8 +20,8 @@ import common._
import org.junit.runner.RunWith
import org.scalatest.FlatSpec
import org.scalatest.junit.JUnitRunner
-import spray.json.DefaultJsonProtocol.{IntJsonFormat, LongJsonFormat,
StringJsonFormat}
-import spray.json.pimpAny
+import spray.json.DefaultJsonProtocol._
+import spray.json._
/**
* Tests for alarms trigger service
diff --git a/tests/src/test/scala/system/packages/AlarmsFeedNegativeTests.scala
b/tests/src/test/scala/system/packages/AlarmsFeedNegativeTests.scala
index d5730b1..2d4e24e 100644
--- a/tests/src/test/scala/system/packages/AlarmsFeedNegativeTests.scala
+++ b/tests/src/test/scala/system/packages/AlarmsFeedNegativeTests.scala
@@ -20,8 +20,8 @@ import common._
import org.junit.runner.RunWith
import org.scalatest.FlatSpec
import org.scalatest.junit.JUnitRunner
-import spray.json.DefaultJsonProtocol.{BooleanJsonFormat, IntJsonFormat,
LongJsonFormat, StringJsonFormat}
-import spray.json.{JsString, pimpAny}
+import spray.json.DefaultJsonProtocol._
+import spray.json._
/**
* Tests for alarms trigger service
diff --git a/tests/src/test/scala/system/packages/AlarmsFeedTests.scala
b/tests/src/test/scala/system/packages/AlarmsFeedTests.scala
index b9c9fbf..b5bf6d3 100644
--- a/tests/src/test/scala/system/packages/AlarmsFeedTests.scala
+++ b/tests/src/test/scala/system/packages/AlarmsFeedTests.scala
@@ -20,8 +20,8 @@ import common._
import org.junit.runner.RunWith
import org.scalatest.{FlatSpec, Inside}
import org.scalatest.junit.JUnitRunner
-import spray.json.DefaultJsonProtocol.{BooleanJsonFormat, IntJsonFormat,
LongJsonFormat, StringJsonFormat}
-import spray.json.{JsObject, JsString, pimpAny}
+import spray.json.DefaultJsonProtocol._
+import spray.json._
/**
* Tests for alarms trigger service
diff --git a/tests/src/test/scala/system/packages/AlarmsMultiWorkersTests.scala
b/tests/src/test/scala/system/packages/AlarmsMultiWorkersTests.scala
index d7cdd0f..5d00731 100644
--- a/tests/src/test/scala/system/packages/AlarmsMultiWorkersTests.scala
+++ b/tests/src/test/scala/system/packages/AlarmsMultiWorkersTests.scala
@@ -24,9 +24,8 @@ import common._
import org.junit.runner.RunWith
import org.scalatest.junit.JUnitRunner
import org.scalatest.{FlatSpec, Matchers}
-import spray.json.DefaultJsonProtocol.StringJsonFormat
import spray.json.DefaultJsonProtocol._
-import spray.json.{pimpAny, _}
+import spray.json._
import whisk.core.WhiskConfig
import whisk.core.database.test.ExtendedCouchDbRestClient
import whisk.utils.{JsHelpers, retry}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee closed pull request #269: Fix spray-json import to comply with newer versions.
dubee closed pull request #269: Fix spray-json import to comply with newer versions. URL: https://github.com/apache/incubator-openwhisk-catalog/pull/269 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tests/src/test/scala/packages/slack/SlackTests.scala b/tests/src/test/scala/packages/slack/SlackTests.scala index dbcdc40..1c2e7df 100644 --- a/tests/src/test/scala/packages/slack/SlackTests.scala +++ b/tests/src/test/scala/packages/slack/SlackTests.scala @@ -21,8 +21,8 @@ import org.junit.runner.RunWith import org.scalatest.BeforeAndAfterAll import org.scalatest.junit.JUnitRunner import common._ -import spray.json.DefaultJsonProtocol.StringJsonFormat -import spray.json.pimpAny +import spray.json.DefaultJsonProtocol._ +import spray.json._ @RunWith(classOf[JUnitRunner]) class SlackTests extends TestHelpers diff --git a/tests/src/test/scala/packages/watson/WatsonTests.scala b/tests/src/test/scala/packages/watson/WatsonTests.scala index 17e5a0c..83548bc 100644 --- a/tests/src/test/scala/packages/watson/WatsonTests.scala +++ b/tests/src/test/scala/packages/watson/WatsonTests.scala @@ -26,8 +26,8 @@ import common.Wsk import common.WskProps import common.WskTestHelpers import common.TestUtils -import spray.json.DefaultJsonProtocol.StringJsonFormat -import spray.json.pimpAny +import spray.json.DefaultJsonProtocol._ +import spray.json._ @RunWith(classOf[JUnitRunner]) class WatsonTests diff --git a/tests/src/test/scala/packages/weather/WeatherTests.scala b/tests/src/test/scala/packages/weather/WeatherTests.scala index ce9fe84..c2f7162 100644 --- a/tests/src/test/scala/packages/weather/WeatherTests.scala +++ b/tests/src/test/scala/packages/weather/WeatherTests.scala @@ -20,8 +20,8 @@ package packages.weather import common._ import org.junit.runner.RunWith import org.scalatest.junit.JUnitRunner -import spray.json.DefaultJsonProtocol.StringJsonFormat -import spray.json.pimpAny +import spray.json.DefaultJsonProtocol._ +import spray.json._ @RunWith(classOf[JUnitRunner]) class WeatherTests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #144: Fix Travis error
csantanapr closed pull request #144: Fix Travis error URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/144 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 954c1af..d30ce44 100644 --- a/.travis.yml +++ b/.travis.yml @@ -12,6 +12,7 @@ env: - secure: "jyY98VXK7W8vKEBx0/JTGOI0Xi0yPqFK7/SFG9j/iz0hgAeKrmXm1HJV6Cci1mpcEPhBqILYNuJGvFuyUWy1is0UCoVHtfrCbMon3Lh3pQarMEWbjjzdB6m51wogm+5ciDNBeQV9Eu4nhQfj3Yb6yu38utIcbAqhuVgM4E0iepuZYK9qkII2caoXnv2kO8RKggzSBarIT4jPvGlY30eejrEvAVRkvQBcgDIUaSX7XrpQCdry6fYwL0fO7hrOd90Q49FLPOkOtyMAQ69p2P8oc8JkZdyH59MPOqpgWszc9kiy7R4CKMCX1X1QAxiwFd84jsMi71kKbnyKtsD54H5Tmj3Ai6+Epzgd6Ey6JFycSQbWWsr16XV5e5wMUpXDMrY8vlmVIcikdVWFvRTR5pmWxAPq0Cx8PvxkCpDE31pevyEFRmbLqb4BxGN4LH1dUBL0bwknrALehSuJAS06M53284HUF0fiCSgY63E+sp+HyK1Y6R9qZeUXftxEGH0vovWYJ94NsqWa/+g4vGeFfhKPbnlK4+gVsTAHV1IRzCLIYTqdY/pFLoYyu6ZSVAvKzRRgyCerN48AUF4nTPuQtukU9d724Z6ZPsWi2i63HHsrDidqbnBWdbSFq9iljjbrGc23OWrDY3QwhHKcPn3Vn7WKuZcx71+Z/7GWLWaV4kGAHGg=" before_install: + - npm conf set strict-ssl false - ./tools/travis/setup.sh install: true @@ -30,4 +31,4 @@ deploy: script: ./tools/travis/deploy.sh openwhisk alarmprovider $TRAVIS_TAG on: tags: true - all_branches: true \ No newline at end of file + all_branches: true This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet commented on issue #144: Fix Travis error
jasonpet commented on issue #144: Fix Travis error URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/144#issuecomment-381655991 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee opened a new pull request #144: Fix Travis error
dubee opened a new pull request #144: Fix Travis error URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/144 Disables strict ssl use in Travis. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #168: Fix spray-json import to comply with newer versions.
dubee closed pull request #168: Fix spray-json import to comply with newer
versions.
URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/168
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/system/health/CloudantHealthFeedTests.scala
b/tests/src/test/scala/system/health/CloudantHealthFeedTests.scala
index 4c9e0b7..a0302bf 100644
--- a/tests/src/test/scala/system/health/CloudantHealthFeedTests.scala
+++ b/tests/src/test/scala/system/health/CloudantHealthFeedTests.scala
@@ -22,10 +22,8 @@ import org.junit.runner.RunWith
import org.scalatest.{BeforeAndAfterEach, FlatSpec, Inside}
import org.scalatest.junit.JUnitRunner
import common._
-import spray.json.DefaultJsonProtocol.IntJsonFormat
-import spray.json.DefaultJsonProtocol.StringJsonFormat
-import spray.json.DefaultJsonProtocol.BooleanJsonFormat
-import spray.json.{JsObject, JsString, pimpAny}
+import spray.json.DefaultJsonProtocol._
+import spray.json._
import system.CloudantUtil
/**
diff --git
a/tests/src/test/scala/system/packages/CloudantAccountActionsTests.scala
b/tests/src/test/scala/system/packages/CloudantAccountActionsTests.scala
index 343de72..1abea57 100644
--- a/tests/src/test/scala/system/packages/CloudantAccountActionsTests.scala
+++ b/tests/src/test/scala/system/packages/CloudantAccountActionsTests.scala
@@ -20,8 +20,8 @@ import common._
import org.junit.runner.RunWith
import org.scalatest.FlatSpec
import org.scalatest.junit.JUnitRunner
-import spray.json.DefaultJsonProtocol.StringJsonFormat
-import spray.json.{JsArray, JsNumber, JsString, JsValue, pimpAny}
+import spray.json.DefaultJsonProtocol._
+import spray.json._
import system.CloudantUtil
import whisk.utils.JsHelpers
diff --git a/tests/src/test/scala/system/packages/CloudantBindingTests.scala
b/tests/src/test/scala/system/packages/CloudantBindingTests.scala
index c619a09..52bff54 100644
--- a/tests/src/test/scala/system/packages/CloudantBindingTests.scala
+++ b/tests/src/test/scala/system/packages/CloudantBindingTests.scala
@@ -20,8 +20,8 @@ import common.{TestHelpers, Wsk, WskProps, WskTestHelpers}
import org.junit.runner.RunWith
import org.scalatest.FlatSpec
import org.scalatest.junit.JUnitRunner
-import spray.json.DefaultJsonProtocol.StringJsonFormat
-import spray.json.{JsObject, pimpAny}
+import spray.json.DefaultJsonProtocol._
+import spray.json._
import system.CloudantUtil
@RunWith(classOf[JUnitRunner])
diff --git
a/tests/src/test/scala/system/packages/CloudantDatabaseActionsTests.scala
b/tests/src/test/scala/system/packages/CloudantDatabaseActionsTests.scala
index 3bcbd4e..823860b 100644
--- a/tests/src/test/scala/system/packages/CloudantDatabaseActionsTests.scala
+++ b/tests/src/test/scala/system/packages/CloudantDatabaseActionsTests.scala
@@ -22,8 +22,8 @@ import common._
import org.junit.runner.RunWith
import org.scalatest.FlatSpec
import org.scalatest.junit.JUnitRunner
-import spray.json.DefaultJsonProtocol.{ByteJsonFormat, StringJsonFormat}
-import spray.json.{JsArray, JsBoolean, JsNumber, JsObject, JsString, pimpAny,
pimpString}
+import spray.json.DefaultJsonProtocol._
+import spray.json._
import system.CloudantUtil
import whisk.utils.JsHelpers
diff --git a/tests/src/test/scala/system/packages/CloudantFeedTests.scala
b/tests/src/test/scala/system/packages/CloudantFeedTests.scala
index 987291b..00c370a 100644
--- a/tests/src/test/scala/system/packages/CloudantFeedTests.scala
+++ b/tests/src/test/scala/system/packages/CloudantFeedTests.scala
@@ -21,8 +21,8 @@ import common._
import org.junit.runner.RunWith
import org.scalatest.{FlatSpec, Inside}
import org.scalatest.junit.JUnitRunner
-import spray.json.DefaultJsonProtocol.{IntJsonFormat, StringJsonFormat}
-import spray.json.{JsObject, JsString, pimpAny}
+import spray.json.DefaultJsonProtocol._
+import spray.json._
import system.CloudantUtil
/**
diff --git
a/tests/src/test/scala/system/packages/CloudantMultiWorkersTests.scala
b/tests/src/test/scala/system/packages/CloudantMultiWorkersTests.scala
index 42f3ed2..e2070ca 100644
--- a/tests/src/test/scala/system/packages/CloudantMultiWorkersTests.scala
+++ b/tests/src/test/scala/system/packages/CloudantMultiWorkersTests.scala
@@ -24,8 +24,8 @@ import common._
import org.junit.runner.RunWith
import org.scalatest.junit.JUnitRunner
import org.scalatest.{FlatSpec, Matchers}
-import spray.json.DefaultJsonProtocol.{StringJsonFormat, _}
-import spray.json.{pimpAny, _}
+import spray.json.DefaultJsonProtocol._
+import spray.json._
import system.CloudantUtil
import whisk.core.WhiskConfig
import whisk.core.database.test.ExtendedCouchDbRestClient
This is an automated message from the Apache Git
[GitHub] dubee closed pull request #263: Fix spray-json import to comply with newer versions.
dubee closed pull request #263: Fix spray-json import to comply with newer
versions.
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/263
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/system/packages/KafkaProduceTests.scala
b/tests/src/test/scala/system/packages/KafkaProduceTests.scala
index 223bd56..85d5007 100644
--- a/tests/src/test/scala/system/packages/KafkaProduceTests.scala
+++ b/tests/src/test/scala/system/packages/KafkaProduceTests.scala
@@ -35,7 +35,7 @@ import common.WskActorSystem
import common.WskProps
import common.WskTestHelpers
import spray.json.DefaultJsonProtocol._
-import spray.json.pimpAny
+import spray.json._
@RunWith(classOf[JUnitRunner])
class KafkaProduceTests
diff --git
a/tests/src/test/scala/system/packages/MessageHubMultiWorkersTest.scala
b/tests/src/test/scala/system/packages/MessageHubMultiWorkersTest.scala
index 7ea14ec..20caa7a 100644
--- a/tests/src/test/scala/system/packages/MessageHubMultiWorkersTest.scala
+++ b/tests/src/test/scala/system/packages/MessageHubMultiWorkersTest.scala
@@ -34,7 +34,7 @@ import common.WskActorSystem
import common.WskProps
import common.WskTestHelpers
import spray.json.DefaultJsonProtocol._
-import spray.json.{pimpAny, _}
+import spray.json._
import whisk.core.WhiskConfig
import whisk.core.database.test.ExtendedCouchDbRestClient
import whisk.utils.{JsHelpers, retry}
diff --git a/tests/src/test/scala/system/packages/MessageHubProduceTests.scala
b/tests/src/test/scala/system/packages/MessageHubProduceTests.scala
index 37a5bd9..214fc55 100644
--- a/tests/src/test/scala/system/packages/MessageHubProduceTests.scala
+++ b/tests/src/test/scala/system/packages/MessageHubProduceTests.scala
@@ -37,7 +37,7 @@ import common.WskProps
import common.WskTestHelpers
import spray.json.DefaultJsonProtocol._
-import spray.json.pimpAny
+import spray.json._
import java.util.Base64
import java.nio.charset.StandardCharsets
diff --git a/tests/src/test/scala/system/stress/StressTest.scala
b/tests/src/test/scala/system/stress/StressTest.scala
index d554d85..b174323 100644
--- a/tests/src/test/scala/system/stress/StressTest.scala
+++ b/tests/src/test/scala/system/stress/StressTest.scala
@@ -33,7 +33,7 @@ import common.WskActorSystem
import common.WskProps
import common.WskTestHelpers
import spray.json.DefaultJsonProtocol._
-import spray.json.pimpAny
+import spray.json._
@RunWith(classOf[JUnitRunner])
diff --git a/tests/src/test/scala/system/utils/KafkaUtils.scala
b/tests/src/test/scala/system/utils/KafkaUtils.scala
index ba8a6e9..be17d6c 100644
--- a/tests/src/test/scala/system/utils/KafkaUtils.scala
+++ b/tests/src/test/scala/system/utils/KafkaUtils.scala
@@ -29,9 +29,7 @@ import org.apache.kafka.clients.producer.KafkaProducer;
import scala.collection.mutable.ListBuffer
import spray.json.DefaultJsonProtocol._
-import spray.json.JsObject
-import spray.json.JsArray
-import spray.json.pimpAny
+import spray.json._
import whisk.utils.JsHelpers
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on issue #143: Fix spray-json import to comply with newer versions.
markusthoemmes commented on issue #143: Fix spray-json import to comply with newer versions. URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/143#issuecomment-381651280 Master seems broken with the same issue of `jshint` not found. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #88: Fix spray-json import to comply with newer versions.
dubee closed pull request #88: Fix spray-json import to comply with newer
versions.
URL:
https://github.com/apache/incubator-openwhisk-package-pushnotifications/pull/88
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/packages/PushNotificationsTests.scala
b/tests/src/test/scala/packages/PushNotificationsTests.scala
index 8da096e..699014e 100644
--- a/tests/src/test/scala/packages/PushNotificationsTests.scala
+++ b/tests/src/test/scala/packages/PushNotificationsTests.scala
@@ -19,8 +19,8 @@ package packages
import common.{TestHelpers, Wsk, WskProps, WskTestHelpers, _}
import org.junit.runner.RunWith
import org.scalatest.junit.JUnitRunner
-import spray.json.DefaultJsonProtocol.StringJsonFormat
-import spray.json.pimpAny
+import spray.json.DefaultJsonProtocol._
+import spray.json._
@RunWith(classOf[JUnitRunner])
class PushNotificationsTests
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee commented on a change in pull request #273: Fix spray-json import to comply with newer versions.
dubee commented on a change in pull request #273: Fix spray-json import to comply with newer versions. URL: https://github.com/apache/incubator-openwhisk-cli/pull/273#discussion_r181788129 ## File path: tests/src/test/scala/system/basic/WskCliBasicTests.scala ## @@ -34,7 +34,7 @@ import common.WskProps import common.WskTestHelpers import spray.json._ import spray.json.DefaultJsonProtocol._ -import spray.json.pimpAny +import spray.json._ Review comment: Checkout line 35 `import spray.json._` is already defined This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vvraskin opened a new pull request #3552: Emit activation metadata to Kafka
vvraskin opened a new pull request #3552: Emit activation metadata to Kafka URL: https://github.com/apache/incubator-openwhisk/pull/3552 ## Description This PR enables sending activation metadata to Kafka, which might be helpful to alleviate the exertion of CouchDB we observe today as well as to preserve user activations metadata for real time processing. At the moment I introduce a new kafka topic called `events` which will accept events of 2 types: Activations and Metrics. First corresponds to the metadata which is collected after an activation is finished (initTime, waitTime, responseCode, kind, etc), second stands for User related metrics of any kind (throttledActivations, concurrentActivations). The data is not aggregated, it is sent to Kafka instantly. ## My changes affect the following components - [ ] API - [x] Controller - [x] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [x] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #273: Fix spray-json import to comply with newer versions.
markusthoemmes opened a new pull request #273: Fix spray-json import to comply with newer versions. URL: https://github.com/apache/incubator-openwhisk-cli/pull/273 Needed to upgrade spray versions to 1.3.4. Refer to https://github.com/spray/spray-json/releases/tag/v1.3.4. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #269: Fix spray-json import to comply with newer versions.
markusthoemmes opened a new pull request #269: Fix spray-json import to comply with newer versions. URL: https://github.com/apache/incubator-openwhisk-catalog/pull/269 Needed to upgrade spray versions to 1.3.4. Refer to https://github.com/spray/spray-json/releases/tag/v1.3.4. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #88: Fix spray-json import to comply with newer versions.
markusthoemmes opened a new pull request #88: Fix spray-json import to comply with newer versions. URL: https://github.com/apache/incubator-openwhisk-package-pushnotifications/pull/88 Needed to upgrade spray versions to 1.3.4. Refer to https://github.com/spray/spray-json/releases/tag/v1.3.4. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #263: Fix spray-json import to comply with newer versions.
markusthoemmes opened a new pull request #263: Fix spray-json import to comply with newer versions. URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/263 Needed to upgrade spray versions to 1.3.4. Refer to https://github.com/spray/spray-json/releases/tag/v1.3.4. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #288: Apache release does not allow to have private license as the header
houshengbo commented on issue #288: Apache release does not allow to have private license as the header URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/288#issuecomment-381646520 Right, I think the header can be changed into: ``` Apache License Version 2.0, January 2004 http://www.apache.org/licenses/ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION 1. Definitions. "License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document. "Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License. "Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity. "You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License. "Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files. "Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types. "Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below). "Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof. "Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution." "Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work. 2. Grant of Copyright License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form. 3. Grant of Patent License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s)
[GitHub] houshengbo commented on issue #288: Apache release does not allow to have private license as the header
houshengbo commented on issue #288: Apache release does not allow to have private license as the header URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/288#issuecomment-381646520 Right, the header can be changed into: ``` Apache License Version 2.0, January 2004 http://www.apache.org/licenses/ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION 1. Definitions. "License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document. "Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License. "Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity. "You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License. "Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files. "Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types. "Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below). "Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof. "Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution." "Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work. 2. Grant of Copyright License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form. 3. Grant of Patent License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s) with the
[GitHub] markusthoemmes opened a new pull request #168: Fix spray-json import to comply with newer versions.
markusthoemmes opened a new pull request #168: Fix spray-json import to comply with newer versions. URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/168 Needed to upgrade spray versions to 1.3.4. Refer to https://github.com/spray/spray-json/releases/tag/v1.3.4. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #143: Fix spray-json import to comply with newer versions.
markusthoemmes opened a new pull request #143: Fix spray-json import to comply with newer versions. URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/143 Needed to upgrade spray versions to 1.3.4. Refer to https://github.com/spray/spray-json/releases/tag/v1.3.4. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3495: Update akka to 2.5.11 and akka-http to 10.1.0.
dubee commented on issue #3495: Update akka to 2.5.11 and akka-http to 10.1.0. URL: https://github.com/apache/incubator-openwhisk/pull/3495#issuecomment-381622789 PG3 2143 ⏳ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE
houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE URL: https://github.com/apache/incubator-openwhisk-cli/pull/271#issuecomment-381622654 @daisy-ycguo I have added a folder named licenses to host all the license content, with the references in the LICENSE.txt file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #3550: Add the licenses of the dependencies into LICENSE
houshengbo commented on issue #3550: Add the licenses of the dependencies into LICENSE URL: https://github.com/apache/incubator-openwhisk/pull/3550#issuecomment-381622590 @daisy-ycguo I have added a folder named licenses to host all the license content, with the references in the LICENSE.txt file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mcdan opened a new issue #119: Doesn't seem to work correctly on Windows
mcdan opened a new issue #119: Doesn't seem to work correctly on Windows URL: https://github.com/apache/incubator-openwhisk-devtools/issues/119 Process: 1. Install Docker for Windows, get it running 2. Install Ubuntu Linux subsystem 3. Update the makefile to work with new docker binary names: https://github.com/mcdan/incubator-openwhisk-devtools/tree/mcdan/feature/windows-support 4. The invokers still can't communicate with Docker for Windows: https://forums.docker.com/t/where-is-the-file-docker-sock/13061 https://github.com/docker/for-win/issues/453 https://github.com/moby/moby/commit/0906195fbbd6f379c163b80f23e4c5a60bcfc5f0 This is sort of a fundamental difference in how Windows and Linux works and you can't make Windows list on all adapters only localhost so we're sort of stuck. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mbwhite commented on issue #116: docker compose make quick start hangs
mbwhite commented on issue #116: docker compose make quick start hangs URL: https://github.com/apache/incubator-openwhisk-devtools/issues/116#issuecomment-381601355 I've cloned the repo just know and attempted to run the `make quick-start`. I'm not convinced that #117 has resolved the issue - puling that change in results in ``` Creating openwhisk_apigateway_1 ... done Creating openwhisk_invoker_1 ... done ... ``` ..and an ever increasing number of dots. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #2317: wsk api authentication issues
mdeuser commented on issue #2317: wsk api authentication issues URL: https://github.com/apache/incubator-openwhisk/issues/2317#issuecomment-381579653 @yadavvipinsonu - when running the `openwhisk.yml` playbook, was the "included" `routemgmt` playbook also run and was it successful? if it was not successful, you can run that `routemgmt.yml` playbook all by itself on this system - assuming the cli was successfully installed, which it seems it was. from the `ansible` folder, run ``` ansible-playbook -i environments/local routemgmt.yml ``` confirm the `apimgmt` package was installed by the `routemgmt.yml` playbook. from the `ansible` folder run ``` wsk -i package list --auth `cat files/auth.whisk.system` ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bbrowning commented on issue #2855: Cache database attachments
bbrowning commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381578265 Speaking of performance improvements, I thought I'd share some basic throughput numbers here. On my test cluster with a simple Hello World Java action I was only able to sustain about 25 action activations per second across the entire cluster before this change. Afterwards, I was able to sustain about 410 action activations per second. The Invoker load, end-user activation latency, and waitTime as reported in the activation results dropped dramatically as a result of this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bbrowning commented on issue #2855: Cache database attachments
bbrowning commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381577307 @markusthoemmes To answer your question above - yes, this change caches attachments in the controller as well. @chetanmeh mentioned in Slack that he'd like to followup on this change with another set of changes to cache attachments only in the Invoker and to store cached attachments on the filesystem instead of JVM heap. That second point - the fact that caches are stored in the heap - would be my only other concern in merging this patch. For environments with a limited number of functions this change isn't a big deal. But, if your OpenWhisk installation has many thousands of different functions that get invoked within the current 5 minute cache timeout then this may be an issue. Until or unless we test filesystem-based attachment caching, we may want to set a `maximumWeight` or `maximumSize` on the `Caffeine` cache instances so that cached attachments get evicted before relying on the JVM garbage collection of soft references and/or expiration time. In my opinion, the performance improvement for Java functions under load is worth figuring out these other details. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel closed pull request #3551: Bump timeout for creating a container to 60 seconds in tests.
cbickel closed pull request #3551: Bump timeout for creating a container to 60
seconds in tests.
URL: https://github.com/apache/incubator-openwhisk/pull/3551
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/actionContainers/ActionContainer.scala
b/tests/src/test/scala/actionContainers/ActionContainer.scala
index ccd6748be6..cba29d986d 100644
--- a/tests/src/test/scala/actionContainers/ActionContainer.scala
+++ b/tests/src/test/scala/actionContainers/ActionContainer.scala
@@ -27,7 +27,6 @@ import scala.concurrent.Future
import scala.concurrent.blocking
import scala.concurrent.duration.Duration
import scala.concurrent.duration.DurationInt
-import scala.language.postfixOps
import scala.sys.process.ProcessLogger
import scala.sys.process.stringToProcess
import scala.util.Random
@@ -53,19 +52,20 @@ trait ActionContainer {
trait ActionProxyContainerTestUtils extends FlatSpec with Matchers {
import ActionContainer.{filterSentinel, sentinel}
- def initPayload(code: String, main: String = "main") = {
+ def initPayload(code: String, main: String = "main"): JsObject =
JsObject(
"value" -> JsObject(
"code" -> { if (code != null) JsString(code) else JsNull },
"main" -> JsString(main),
"binary" -> JsBoolean(Exec.isBinaryCode(code
- }
- def runPayload(args: JsValue, other: Option[JsObject] = None) = {
+ def runPayload(args: JsValue, other: Option[JsObject] = None): JsObject =
JsObject(Map("value" -> args) ++ (other map { _.fields } getOrElse Map()))
- }
- def checkStreams(out: String, err: String, additionalCheck: (String, String)
=> Unit, sentinelCount: Int = 1) = {
+ def checkStreams(out: String,
+ err: String,
+ additionalCheck: (String, String) => Unit,
+ sentinelCount: Int = 1): Unit = {
withClue("expected number of stdout sentinels") {
sentinelCount shouldBe StringUtils.countMatches(out, sentinel)
}
@@ -74,26 +74,24 @@ trait ActionProxyContainerTestUtils extends FlatSpec with
Matchers {
}
val (o, e) = (filterSentinel(out), filterSentinel(err))
-o should not include (sentinel)
-e should not include (sentinel)
+o should not include sentinel
+e should not include sentinel
additionalCheck(o, e)
}
}
object ActionContainer {
private lazy val dockerBin: String = {
-List("/usr/bin/docker", "/usr/local/bin/docker")
- .find { bin =>
-new File(bin).isFile()
- }
- .getOrElse(???) // This fails if the docker binary couldn't be located.
+List("/usr/bin/docker", "/usr/local/bin/docker").find { bin =>
+ new File(bin).isFile
+}.get // This fails if the docker binary couldn't be located.
}
private lazy val dockerCmd: String = {
val version = WhiskProperties.getProperty("whisk.version.name")
// Check if we are running on docker-machine env.
val hostStr = if (version.toLowerCase().contains("mac")) {
- s" --host tcp://${WhiskProperties.getMainDockerEndpoint()} "
+ s" --host tcp://${WhiskProperties.getMainDockerEndpoint} "
} else {
" "
}
@@ -109,7 +107,7 @@ object ActionContainer {
val err = new ByteArrayOutputStream
val outW = new PrintWriter(out)
val errW = new PrintWriter(err)
- val v = cmd ! (ProcessLogger(outW.println, errW.println))
+ val v = cmd ! ProcessLogger(o => outW.println(o), e => errW.println(e))
outW.close()
errW.close()
(v, out.toString, err.toString)
@@ -125,21 +123,23 @@ object ActionContainer {
// Filters out the sentinel markers inserted by the container (see relevant
private code in Invoker.scala)
val sentinel = "XXX_THE_END_OF_A_WHISK_ACTIVATION_XXX"
- def filterSentinel(str: String) = str.replaceAll(sentinel, "").trim
+ def filterSentinel(str: String): String = str.replaceAll(sentinel, "").trim
def withContainer(imageName: String, environment: Map[String, String] =
Map.empty)(code: ActionContainer => Unit)(
implicit actorSystem: ActorSystem): (String, String) = {
val rand = { val r = Random.nextInt; if (r < 0) -r else r }
val name = imageName.toLowerCase.replaceAll("""[^a-z]""", "") + rand
-val envArgs = environment.toSeq.map {
- case (k, v) => s"-e ${k}=${v}"
-} mkString (" ")
+val envArgs = environment.toSeq
+ .map {
+case (k, v) => s"-e $k=$v"
+ }
+ .mkString(" ")
// We create the container... and find out its IP address...
def createContainer(portFwd: Option[Int] = None): Unit = {
val runOut = awaitDocker(
s"run ${portFwd.map(p => s"-p $p:8080").getOrElse("")} --name $name
$envArgs -d $imageName",
-10 seconds)
+
[GitHub] markusthoemmes commented on issue #3551: Bump timeout for creating a container to 60 seconds in tests.
markusthoemmes commented on issue #3551: Bump timeout for creating a container to 60 seconds in tests. URL: https://github.com/apache/incubator-openwhisk/pull/3551#issuecomment-381564051 PG1 2788 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats
codecov-io commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365147821 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3249?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@a8b3c0f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3249?src=pr=tree) ```diff @@Coverage Diff@@ ## master#3249 +/- ## = Coverage ? 74.26% = Files ? 122 Lines ? 5529 Branches ? 362 = Hits ? 4106 Misses? 1423 Partials ?0 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3249?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3249?src=pr=footer). Last update [a8b3c0f...902df74](https://codecov.io/gh/apache/incubator-openwhisk/pull/3249?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats
chetanmeh commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-381545634 Again rebased to current master to resolve the merge error :sweat:. Hopefully we can get this long pending PR merged this week! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #3551: Bump timeout for creating a container to 60 seconds in tests.
markusthoemmes opened a new pull request #3551: Bump timeout for creating a container to 60 seconds in tests. URL: https://github.com/apache/incubator-openwhisk/pull/3551 On very busy machines, creating a container can take quite long. For the sake of testing, its of no use to fail the test on a relatively tight timeout. Bumping this to 60 seconds should not harm the tests significance. ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [X] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [X] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [X] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [X] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] ~~I added tests to cover my changes.~~ - [ ] ~~My changes require further changes to the documentation.~~ - [ ] ~~I updated the documentation where necessary.~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
