[GitHub] csantanapr closed pull request #29: skip clean up for travis deploy
csantanapr closed pull request #29: skip clean up for travis deploy URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/29 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 9061cac..72184fc 100644 --- a/.travis.yml +++ b/.travis.yml @@ -30,17 +30,20 @@ script: after_failure: cat .gogradle/reports/test/index.html deploy: - provider: script + skip_cleanup: true script: "./tools/travis/publish.sh openwhisk ${TRAVIS_TAG%@*} ${TRAVIS_TAG##*@}" on: tags: true all_branches: true repo: apache/incubator-openwhisk-runtime-go - provider: script + skip_cleanup: true script: "./tools/travis/publish.sh openwhisk actionProxyLoop master" on: branch: master repo: apache/incubator-openwhisk-runtime-go - provider: script + skip_cleanup: true script: "./tools/travis/publish.sh openwhisk golang1.10 master" on: branch: master This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #29: skip clean up for travis deploy
csantanapr opened a new pull request #29: skip clean up for travis deploy URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #28: publish action loop also
csantanapr closed pull request #28: publish action loop also URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/28 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 1aa1a18..9061cac 100644 --- a/.travis.yml +++ b/.travis.yml @@ -34,10 +34,17 @@ deploy: on: tags: true all_branches: true +repo: apache/incubator-openwhisk-runtime-go - provider: script - script: "./tools/travis/publish.sh openwhisk 1.10 master" + script: "./tools/travis/publish.sh openwhisk actionProxyLoop master" on: branch: master +repo: apache/incubator-openwhisk-runtime-go +- provider: script + script: "./tools/travis/publish.sh openwhisk golang1.10 master" + on: +branch: master +repo: apache/incubator-openwhisk-runtime-go env: global: - secure: GNKMZjEW1BKBb8NSiFB/Bogh0V5co5TefLLaj9oYJrKCP8rheFY4mWwINR74dYwSFIVmBhuuwZCm62zZwzb2TTivjQihOwU9SeTaUvJHlcLu6j1T/gTcMX5dkDOrdzqZaKoU5NpMbvad1fnDfEG9oU/VE7fARAxziZ2yBXOGkt2p2whkGXrs43gMyRKJv7ytUwpjvzhD48hJHgn0Eq6EwVIYxO5gJfGAhiA0ucH75c3jI4yEz7sw7SaoFxAQRL7VICaTH8JI+tKWU673HCclIRiPeZWQ23rI/f3MV8SNTKJm0GtnjM8LA9uC96qV6f5aXMn1EdaMGoCQbR9jBeqZG7pq8O2QHA/1eNNDw5sCISS05plCJ2yz/G4PUndnuToKm/sx6/qbdRA3QzTrNQfwTTcuUi+j4mYEFANgT774CeGdnajfNy4cZoeVEFmBTXdi5V1DuFLujSQrzRSHddHHUQXGUMaz4qv5R8g2aQNNJzYfknGwG0AbqCKld5j3VNtrjpiUqPAHmAi2O1/4gNd5dM42h4ARNnX4S8M/SPqWmzTAbtXaLcJIKxsyh9Xb1FINiCDsLNiuYWHb2QIjnuiXXgQvy/F1FAn231hJOYq1p6gA0QT/WBaAE77yfDR6EKmvaoBfqUuFQgfjwDH9hdsBiPb9U1jS/74yJqMBFiyW0nU= diff --git a/tools/travis/publish.sh b/tools/travis/publish.sh index 3bc31e3..51690f2 100755 --- a/tools/travis/publish.sh +++ b/tools/travis/publish.sh @@ -21,15 +21,9 @@ set -eux # Build script for Travis-CI. IMAGE_PREFIX=$1 -RUNTIME_VERSION=$2 +RUNTIME=$2 IMAGE_TAG=$3 -if [ ${RUNTIME_VERSION} == "1.10" ]; then - RUNTIME="golang1.10" -elif [ ${RUNTIME_VERSION} == "1.11" ]; then - RUNTIME="golang1.11" -fi - if [[ ! -z ${DOCKER_USER} ]] && [[ ! -z ${DOCKER_PASSWORD} ]]; then docker login -u "${DOCKER_USER}" -p "${DOCKER_PASSWORD}" fi This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #28: publish action loop also
csantanapr opened a new pull request #28: publish action loop also URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #26: update to go 1.10.2
csantanapr closed issue #26: update to go 1.10.2 URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/26 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #27: update to use go 1.10.2
csantanapr closed pull request #27: update to use go 1.10.2 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/27 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index 1d716d0..1aa1a18 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,7 +17,7 @@ sudo: required language: go go: -- 1.10.1 +- 1.10.2 services: - docker notifications: diff --git a/README.md b/README.md index e74f7df..6200abd 100644 --- a/README.md +++ b/README.md @@ -35,7 +35,7 @@ You need a linux environment, with Java and Docker installed to build the source Prerequisites for running build and tests: - docker - jdk -- go 1.10.1 +- go 1.10.2 - bc (sudo apt-get install bc) To compile go proxy diff --git a/actionProxyLoop/Dockerfile b/actionProxyLoop/Dockerfile index d7f65fa..d81db8a 100644 --- a/actionProxyLoop/Dockerfile +++ b/actionProxyLoop/Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.10.1 +FROM golang:1.10.2 RUN apt-get update && apt-get install -y \ curl \ jq \ diff --git a/golang1.10/Dockerfile b/golang1.10/Dockerfile index 03be150..aef1102 100644 --- a/golang1.10/Dockerfile +++ b/golang1.10/Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.10.1 +FROM golang:1.10.2 RUN apt-get update && apt-get install -y \ curl \ jq \ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #27: update to use go 1.10.2
csantanapr opened a new pull request #27: update to use go 1.10.2 URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/27 Closes #26 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sciabarracom commented on issue #23: FAIL: Example_badinit_nocompiler
sciabarracom commented on issue #23: FAIL: Example_badinit_nocompiler URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/23#issuecomment-38762 Can I get a debug build? Will contact you on slack, you start the build I’m debug and give me ssh to connect to the temporary container. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #26: update to go 1.10.2
csantanapr opened a new issue #26: update to go 1.10.2 URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/26 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #23: FAIL: Example_badinit_nocompiler
csantanapr commented on issue #23: FAIL: Example_badinit_nocompiler URL: https://github.com/apache/incubator-openwhisk-runtime-go/issues/23#issuecomment-387620416 @sciabarra you have an update on this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #34: add openssh client for dockerskeleton
csantanapr opened a new pull request #34: add openssh client for dockerskeleton URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/34 Closes #26 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #26: git clone not working when using ssh git url (add ssh client)
csantanapr commented on issue #26: git clone not working when using ssh git url (add ssh client) URL: https://github.com/apache/incubator-openwhisk-runtime-docker/issues/26#issuecomment-387619448 It looks like `openssh-client` package in alpine only adds client no deamon. And this is what's require to get git clone working with ssh access. Here is an example: ``` docker run --rm -v ~/.ssh:/ssh dockerskeleton bash -c "export GIT_SSH_COMMAND=\"ssh -i /ssh/id_rsa -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no\";git clone --depth 1 g...@github.com:apache/incubator-openwhisk.git;cat incubator-openwhisk/README.md" ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3613: Split test jobs in Travis
csantanapr commented on a change in pull request #3613: Split test jobs in Travis URL: https://github.com/apache/incubator-openwhisk/pull/3613#discussion_r186927802 ## File path: tests/build.gradle ## @@ -33,8 +34,70 @@ def leanExcludes = [ '**/*WskCli*' ] +ext.testSets = [ +"REQUIRE_ONLY_DB" : [ +"includes" : [ +"actionContainers/**", +"ha/**", +"whisk/**" +], +"excludes" : [ +"whisk/core/admin/**", +"whisk/core/apigw/actions/test/**", +"whisk/core/cli/test/**", +"whisk/core/limits/**", +"**/*CacheConcurrencyTests*", +"**/*ControllerApiTests*", +] +], +"REQUIRE_SYSTEM" : [ +"includes" : [ +"apigw/healthtests/**", +"services/**", +"system/basic/**", +"system/rest/**", +"whisk/core/admin/**", +"whisk/core/cli/test/**", +"whisk/core/apigw/actions/test/**", +"whisk/core/limits/**", +"whisk/core/database/test/*CacheConcurrencyTests*", +"whisk/core/controller/test/*ControllerApiTests*", +] +], +"LEAN" : [ +"excludes" : leanExcludes +] +] + +testSets.each {setName, patterns -> +def excludes = patterns["excludes"] ?: new HashSet<>() +excludes.addAll(leanExcludes) +patterns["excludes"] = excludes +} + +//The value can be specified either via env variable +// ORG_GRADLE_PROJECT_testSetName +//Or via property -PtestSetName +if (!project.hasProperty("testSetName")) { Review comment: I think we still need to offer a way to run all tests. In our downstream we run `./gradlew tests:test` to run all tests. I tried this and it doesn't run all tests, only LEAN ``` $ ./gradlew tests:test > Configure project :tests Using testSet LEAN - { "excludes": [ "**/*Swift*", "**/*Python*", "**/*Java*", "**/*ThrottleTests*", "**/MaxActionDurationTests*", "**/*ApiGwRestBasicTests*", "**/*WskCli*", "**/*Swift*", "**/*Python*", "**/*Java*", "**/*ThrottleTests*", "**/MaxActionDurationTests*", "**/*ApiGwRestBasicTests*", "**/*WskCli*" ] } ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #3631: bump new version of ios staterapp
csantanapr opened a new pull request #3631: bump new version of ios staterapp URL: https://github.com/apache/incubator-openwhisk/pull/3631 Closes #3630 ## Description bump new version of ios staterapp in nginx ## Related issue and scope - [x] I opened an issue to propose and discuss this change (#3630 ) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [x] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). - [x] Maintenance ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [x] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new issue #3630: bump new version of swift/ios starter app
csantanapr opened a new issue #3630: bump new version of swift/ios starter app URL: https://github.com/apache/incubator-openwhisk/issues/3630 update nginx to point to latest version of swift/ios starter app https://github.com/apache/incubator-openwhisk-client-swift/releases/tag/0.3.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #56: fix tests using httpbin swiftyrequest
csantanapr opened a new pull request #56: fix tests using httpbin swiftyrequest URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/56 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #47: Update SDK to Swift 4
csantanapr closed issue #47: Update SDK to Swift 4 URL: https://github.com/apache/incubator-openwhisk-client-swift/issues/47 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #47: Update SDK to Swift 4
csantanapr commented on issue #47: Update SDK to Swift 4 URL: https://github.com/apache/incubator-openwhisk-client-swift/issues/47#issuecomment-387609605 Closed by #48 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #48: Fixes issue #47, updates code to latest syntax, build for iOS 11
csantanapr closed pull request #48: Fixes issue #47, updates code to latest syntax, build for iOS 11 URL: https://github.com/apache/incubator-openwhisk-client-swift/pull/48 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/OpenWhisk.podspec b/OpenWhisk.podspec index 2facc9c..b22dc63 100644 --- a/OpenWhisk.podspec +++ b/OpenWhisk.podspec @@ -1,21 +1,21 @@ Pod::Spec.new do |s| s.name = 'OpenWhisk' - s.version = '0.2.2' - s.summary = 'Mobile SDK to use OpenWhisk server-less environment' - s.homepage = 'http://www.ibm.com/mobilefirst/us/en/' + s.version = '0.3.0' + s.summary = 'Apache OpenWhisk Client SDK' + s.homepage = 'https://apache.openwhisk.org' s.license = { :type => 'Apache License, Version 2.0' } - s.authors = 'IBM' + s.authors = 'Apache OpenWhisk' s.description = <<-DESC OpenWhisk is a cloud-first distributed event-based programming service. OpenWhisk provides a programming model to upload event handlers to a cloud service, and register the handlers to respond to various events. DESC - s.ios.deployment_target = '9.0' - s.watchos.deployment_target = '3.0' + s.ios.deployment_target = '11.0' + s.watchos.deployment_target = '4.0' - s.source = { :git => 'https://github.com/openwhisk/openwhisk-client-swift.git', :tag => "#{s.version}" } + s.source = { :git => 'https://github.com/apache/incubator-openwhisk-client-swift.git', :tag => "#{s.version}" } s.source_files = 'OpenWhisk/*.{swift,h}' diff --git a/OpenWhisk.xcodeproj/project.pbxproj b/OpenWhisk.xcodeproj/project.pbxproj index f7747aa..e956ac2 100644 --- a/OpenWhisk.xcodeproj/project.pbxproj +++ b/OpenWhisk.xcodeproj/project.pbxproj @@ -205,16 +205,16 @@ isa = PBXProject; attributes = { LastSwiftUpdateCheck = 0720; - LastUpgradeCheck = 0800; + LastUpgradeCheck = 0930; ORGANIZATIONNAME = IBM; TargetAttributes = { D6E3E6351C72592300843E16 = { CreatedOnToolsVersion = 7.2.1; - LastSwiftMigration = 0800; + LastSwiftMigration = 0930; }; D6E3E63F1C72592300843E16 = { CreatedOnToolsVersion = 7.2.1; - LastSwiftMigration = 0800; + LastSwiftMigration = 0930; }; D6F56ADE1C76471B00F047B6 = { CreatedOnToolsVersion = 7.2.1; @@ -317,14 +317,22 @@ CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; CLANG_ENABLE_OBJC_ARC = YES; + CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; CLANG_WARN_BOOL_CONVERSION = YES; + CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; + CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; + CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; + CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; + CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; + CLANG_WARN_STRICT_PROTOTYPES = YES; CLANG_WARN_SUSPICIOUS_MOVE = YES; CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; @@ -348,7 +356,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES;
[GitHub] style95 opened a new issue #3629: [Feature requests] action protection
style95 opened a new issue #3629: [Feature requests] action protection URL: https://github.com/apache/incubator-openwhisk/issues/3629 It would be great if we can have feature to protect actions from accidental deletion. Since it can happen at anytime and the impact is critical when action is being used in production. Most of VM services have similar feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3208: Source files for images in docs folder
csantanapr commented on issue #3208: Source files for images in docs folder URL: https://github.com/apache/incubator-openwhisk/issues/3208#issuecomment-387595760 Also Photopea can be use to edit GIMP format (XCF) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3207: Remove Consul from "The Internal flow of processing" section diagram in about.md
csantanapr commented on issue #3207: Remove Consul from "The Internal flow of processing" section diagram in about.md URL: https://github.com/apache/incubator-openwhisk/issues/3207#issuecomment-387595386 @shazron go ahead and create new diagram with draw.io This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3208: Source files for images in docs folder
csantanapr commented on issue #3208: Source files for images in docs folder URL: https://github.com/apache/incubator-openwhisk/issues/3208#issuecomment-387595263 Let's use GIMP then for Logo This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shazron commented on issue #3208: Source files for images in docs folder
shazron commented on issue #3208: Source files for images in docs folder URL: https://github.com/apache/incubator-openwhisk/issues/3208#issuecomment-377846828 The only one I can think of is GIMP or Photopea (only the former is open source, the latter is free). If we want the real deal, not sure if there are we can get Apache to formally request from Adobe: https://www.techsoup.org/restrictions#adobe so all committers can get a copy UPDATE: Adobe techsoup requirements changed, no longer free for 501c3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo opened a new pull request #144: Update header scan policy document
daisy-ycguo opened a new pull request #144: Update header scan policy document URL: https://github.com/apache/incubator-openwhisk-release/pull/144 The PR includes below changes: - add `docker.gradle`, `settings.gradle`, `build.gradle` to the inclusion list. - add `gradlew` and `gradlew.bat` to the exclusion list - remove `*.conf` from the exclusion list - describe `source files of test actions` specifically - update the RAT pom.xml correspondingly. Closes issue #129 Closes issue #131 Closes issue #132 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #3628: Revert "Replace WALA Pair with clean new Pair."
csantanapr closed pull request #3628: Revert "Replace WALA Pair with clean new Pair." URL: https://github.com/apache/incubator-openwhisk/pull/3628 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3628: Revert "Replace WALA Pair with clean new Pair."
csantanapr commented on issue #3628: Revert "Replace WALA Pair with clean new Pair." URL: https://github.com/apache/incubator-openwhisk/pull/3628#issuecomment-387588450 downstreams already fixed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #2795: enable concurrent activation processing
codecov-io commented on issue #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#issuecomment-386889684 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=h1) Report > Merging [#2795](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7d9372f4ea7e49ad4dd691cba80526cc1c3e940c?src=pr=desc) will **increase** coverage by `0.33%`. > The diff coverage is `86.41%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/graphs/tree.svg?src=pr=l0YmsiSAso=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) ```diff @@Coverage Diff @@ ## master#2795 +/- ## == + Coverage 74.41% 74.74% +0.33% == Files 126 126 Lines5952 6007 +55 Branches 391 388 -3 == + Hits 4429 4490 +61 + Misses 1523 1517 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=tree) | Coverage Δ | | |---|---|---| | [...la/whisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `100% <ø> (ø)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...cala/whisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.6% <100%> (+1.79%)` | :arrow_up: | | [...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=) | `93.33% <100%> (+0.83%)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `81.11% <54.54%> (-4.78%)` | :arrow_down: | | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `80.55% <0%> (+22.22%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=footer). Last update [7d9372f...80af196](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed pull request #143: Update tracking information and make this repo scancode compliant.
pritidesai closed pull request #143: Update tracking information and make this repo scancode compliant. URL: https://github.com/apache/incubator-openwhisk-release/pull/143 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.md b/NOTICE.md index 57655ec..e5682ab 100644 --- a/NOTICE.md +++ b/NOTICE.md @@ -1,3 +1,21 @@ + + Apache OpenWhisk Release Copyright 2016-2018 The Apache Software Foundation diff --git a/README.md b/README.md index 15b7c36..a0762c0 100644 --- a/README.md +++ b/README.md @@ -21,7 +21,7 @@ [![License](https://img.shields.io/badge/license-Apache--2.0-blue.svg)](http://www.apache.org/licenses/LICENSE-2.0) [![Build Status](https://travis-ci.org/apache/incubator-openwhisk-release.svg?branch=master)](https://travis-ci.org/apache/incubator-openwhisk-release) -The primary goal of this project is to provide the Apache OpenWhisk project's Release Managers the automation needed to guarantee a release complies with both the Apache Software Foundation's (ASF) [Release Creation Process](http://www.apache.org/dev/release-publishing.html) and [Release Policy](http://www.apache.org/legal/release-policy.html). +The primary goal of this project is to provide the Apache OpenWhisk project's Release Managers the instructions and automation needed to guarantee a release complies with both the Apache Software Foundation's (ASF) [Release Creation Process](http://www.apache.org/dev/release-publishing.html) and [Release Policy](http://www.apache.org/legal/release-policy.html). Specifically, this repository provides Release Management of all designated Apache OpenWhisk project repositories, by automating: - Verification of the source code LICENSE and NOTICE files @@ -33,11 +33,14 @@ Specifically, this repository provides Release Management of all designated Apac all in accordance with Apache guidelines. -## Release Process Methodology + +# Release Process + +## Methodology This project uses Travis CI as the automated integration build tool to streamline the release process of Apache OpenWhisk. Stages can be applied to build different jobs, which are able to run either in sequential or parallel. Artifacts can be shared across different jobs by using the cache feature in Travis, as different jobs run on different virtual machines. -## Release publishing +## Publishing Staged candidate releases of Apache OpenWhisk artifacts are published to the approved staging repository path under Apache with all required PGP singatures: - https://dist.apache.org/repos/dist/dev/incubator/openwhisk/ @@ -45,17 +48,11 @@ Staged candidate releases of Apache OpenWhisk artifacts are published to the app Once candidates are approved, in accordance with required release processes and policies, their artifacts can be moved from the staging path to the approved release path: - https://dist.apache.org/repos/dist/release/incubator/openwhisk/. -# Instructions for Release Managers - -## Release Manager Tutorial -As a release manger of OpenWhisk, please visit [OpenWhisk Release tutorial](docs/tutorial.md). - -# Specifications to implement the above release process +# Instructions -To find the specifications about how to implement the Apache Release process for OpenWhisk project set, please visit the following page. +Please follow the [Instructions for Release Managers](docs/release_instructions.md). -- [General Specification](docs/general_spec.md) # Project status @@ -177,6 +174,7 @@ The following table can be used by Release Managers to get quickly check the sta - The ScanCode column text is hyperlinked to the corresponding repository's build file that executes the scancode utility. - The ASF scan configuration for all repos. can be found here: [ASF-Release.cfg](https://github.com/apache/incubator-openwhisk-utilities/blob/master/scancode/ASF-Release.cfg). - The Slack badge is hyperlinked to the corresponding repository's public Slack channel (if one exists). +- LICENSE and NOTICE file compliance tracking can be found here: [project_licenses.md](docs/project_licenses.md) # References - [Apache Release Creation Process](http://www.apache.org/dev/release-publishing.html) diff --git a/docs/general_spec.md b/docs/general_spec.md index 3802b42..9047d5d 100644 --- a/docs/general_spec.md +++ b/docs/general_spec.md @@ -16,18 +16,15 @@ # --> -# General plan to implement the Apache release process for OpenWhisk +# Release Process Specification -The purpose of this repository is to provide a one-stop entry tool to manage the release process of OpenWhisk in an automated -way. 1,000 people will probably have 1,000 ideas about how to fulfill it, since we are living in such an innovative world. -We believe they are all the valid
[GitHub] csantanapr closed pull request #123: Integrated OW GW and existing API Manangement
csantanapr closed pull request #123: Integrated OW GW and existing API Manangement URL: https://github.com/apache/incubator-openwhisk-devtools/pull/123 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docker-compose/Makefile b/docker-compose/Makefile index 2d8e870..25c80fe 100644 --- a/docker-compose/Makefile +++ b/docker-compose/Makefile @@ -123,7 +123,7 @@ download-cli: fi .PHONY: run -run: print-host check-required-ports setup start-docker-compose init-couchdb init-whisk-cli +run: print-host check-required-ports setup start-docker-compose init-couchdb init-whisk-cli init-api-management print-host: echo "host ip address: ${DOCKER_HOST_IP}" @@ -164,21 +164,39 @@ check-kafka-ports: done echo " ... OK" - - - .PHONY: setup setup: - mkdir -p ~/tmp/openwhisk/apigateway/ssl - $(OPENWHISK_PROJECT_HOME)/ansible/files/genssl.sh $(DOCKER_HOST_IP) server $(OPENWHISK_PROJECT_HOME)/ansible/roles/nginx/files - cp $(OPENWHISK_PROJECT_HOME)/ansible/roles/nginx/files/*.pem ~/tmp/openwhisk/apigateway/ssl - cp -r ./apigateway/* ~/tmp/openwhisk/apigateway/ + mkdir -p ~/tmp/openwhisk > ~/tmp/openwhisk/local.env printf "DOCKER_BINARY=$(DOCKER_BINARY)\n" >> ~/tmp/openwhisk/local.env printf "DOCKER_COMPOSE_HOST=$(DOCKER_HOST_IP)\n" >> ~/tmp/openwhisk/local.env printf "DOCKER_REGISTRY=$(DOCKER_REGISTRY)\n" >> ~/tmp/openwhisk/local.env printf "DOCKER_IMAGE_PREFIX=$(DOCKER_IMAGE_PREFIX)\n" >> ~/tmp/openwhisk/local.env + echo " ... preparing api-gateway configuration" + rm -rf ~/tmp/openwhisk/api-gateway-config + mkdir -p ~/tmp/openwhisk/api-gateway-config/api-gateway + cp -r ./apigateway/* ~/tmp/openwhisk/api-gateway-config/api-gateway/ + cp -r ./apigateway/rclone ~/tmp/openwhisk + $(shell cat ~/tmp/openwhisk/local.env) docker-compose --project-name openwhisk up minio 2>&1 > ~/tmp/openwhisk/setup.log & + until (curl --silent http://$(DOCKER_HOST_IP):9001/); do printf '.'; sleep 5; done + docker run --rm -v ~/tmp/openwhisk/rclone:/root/.config/rclone \ + --link="openwhisk_minio_1:minio.docker" --network=openwhisk_default \ + --entrypoint=rclone openwhisk/apigateway mkdir minio:api-gateway + docker run --rm -v ~/tmp/openwhisk/api-gateway-config/api-gateway/generated-conf.d:/etc/api-gateway/generated-conf.d \ + -v ~/tmp/openwhisk/rclone:/root/.config/rclone \ + --link="openwhisk_minio_1:minio.docker" --network=openwhisk_default \ + --entrypoint=rclone openwhisk/apigateway copy --exclude .git /etc/api-gateway/ minio:api-gateway/ + # $(shell cat ~/tmp/openwhisk/local.env) docker-compose --project-name openwhisk stop minio + # $(shell cat ~/tmp/openwhisk/local.env) docker-compose --project-name openwhisk rm -f minio + $(OPENWHISK_PROJECT_HOME)/ansible/files/genssl.sh $(DOCKER_HOST_IP) server $(OPENWHISK_PROJECT_HOME)/ansible/roles/nginx/files + mkdir -p ~/tmp/openwhisk/api-gateway-ssl + cp $(OPENWHISK_PROJECT_HOME)/ansible/roles/nginx/files/*.pem ~/tmp/openwhisk/api-gateway-ssl + +.PHONY: gw +gw: + $(shell cat ~/tmp/openwhisk/local.env) docker-compose --project-name openwhisk up apigateway + .PHONY: restart restart: stop rm start-docker-compose @@ -236,8 +254,14 @@ init-whisk-cli: echo "waiting for the Whisk controller to come up ... " until $$(curl --output /dev/null --silent --head --fail http://$(DOCKER_HOST_IP):/ping); do printf '.'; sleep 5; done echo "initializing CLI ... " - $(WSK_CLI) -v property set --namespace guest --auth `cat $(OPENWHISK_PROJECT_HOME)/ansible/files/auth.guest` --apihost $(DOCKER_HOST_IP):443 -i + $(WSK_CLI) -v property set --namespace guest --auth `cat $(OPENWHISK_PROJECT_HOME)/ansible/files/auth.guest` --apihost https://$(DOCKER_HOST_IP) -i +.PHONY: init-api-management +init-api-management: + $(WSK_CLI) -v property set --namespace whisk.system --auth `cat $(OPENWHISK_PROJECT_HOME)/ansible/files/auth.whisk.system` --apihost $(DOCKER_HOST_IP) -i + GW_USER="" GW_PWD="" GW_HOST_V2="http://$(DOCKER_HOST_IP):9000/v2" OPENWHISK_HOME=$(OPENWHISK_PROJECT_HOME) \ + $(OPENWHISK_PROJECT_HOME)/ansible/roles/routemgmt/files/installRouteMgmt.sh $(shell cat $(OPENWHISK_PROJECT_HOME)/ansible/files/auth.whisk.system) $(DOCKER_HOST_IP) /whisk.system $(WSK_CLI) + $(WSK_CLI) -v property set --namespace guest --auth `cat $(OPENWHISK_PROJECT_HOME)/ansible/files/auth.guest` --apihost
[GitHub] csantanapr commented on issue #123: Integrated OW GW and existing API Manangement
csantanapr commented on issue #123: Integrated OW GW and existing API Manangement URL: https://github.com/apache/incubator-openwhisk-devtools/pull/123#issuecomment-387584517 works for me locally on mac This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #187: include Helm-based deployment in TravisCI matrix
dgrove-oss commented on issue #187: include Helm-based deployment in TravisCI matrix URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/187#issuecomment-387581877 @rabbah @csantanapr -- could one of you please review this PR? I finally managed to find the right set of kludges to get Helm running on minikube under TravisCI on ubuntu 14.04. So it is now ready to be merged. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #187: include Helm-based deployment in TravisCI matrix
dgrove-oss commented on issue #187: include Helm-based deployment in TravisCI matrix URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/187#issuecomment-387581877 @rabbah @csantanapr -- could one of you please review this PR. I finally managed to find the right set of kludges to get Helm running minikube under TravisCI on 14.04. So it is now ready to be merged. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #123: Integrated OW GW and existing API Manangement
ddragosd commented on issue #123: Integrated OW GW and existing API Manangement URL: https://github.com/apache/incubator-openwhisk-devtools/pull/123#issuecomment-387580308 The build is fixed. The tests also include an additional check for web actions: ``` invoking: http://10.20.0.30:9090/api/23bc46b1-71f6-4ed5-8c54-816aa4f8c502/hello/world "payload": "Hello, World!" ./openwhisk-master/bin/wsk -i api list /hello ok: APIs Action Verb API Name URL /guest/hello get/hello http://10.20.0.30:9090/api/23bc46b1-71f6-4ed5-8c54-816aa4f8c502/hello/world ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #123: Integrated OW GW and existing API Manangement
csantanapr commented on issue #123: Integrated OW GW and existing API Manangement URL: https://github.com/apache/incubator-openwhisk-devtools/pull/123#issuecomment-387564884 @ddragosd there are problems in Travis This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd opened a new pull request #123: Integrated OW GW and existing API Mamangement
ddragosd opened a new pull request #123: Integrated OW GW and existing API Mamangement URL: https://github.com/apache/incubator-openwhisk-devtools/pull/123 Changes: - [x] API Gateway docker image uses `openwhisk/apigateway` container - [x] Added `make init-api-management`; it is executed by default as part of `make quick-start` - [x] Integrated `rclone` with the API Gateway and [Minio](https://docs.minio.io/) as an example on how the API Gateway can sync the configuration from a remote object store such as S3. `Minio` is simulating such a remote object store; it can be browsed locally on http://localhost:9001/minio/api-gateway - [ ] Update the tests to include a simple API Creation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3613: Split test jobs in Travis
codecov-io commented on issue #3613: Split test jobs in Travis URL: https://github.com/apache/incubator-openwhisk/pull/3613#issuecomment-386723418 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=h1) Report > Merging [#3613](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/375c180b7332b671c1878761fb1d891b59ba3478?src=pr=desc) will **increase** coverage by `0.2%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=tree) ```diff @@Coverage Diff@@ ## master#3613 +/- ## = + Coverage 74.39% 74.59% +0.2% = Files 125 126 +1 Lines5951 5952 +1 Branches 384 391 +7 = + Hits 4427 4440 +13 + Misses 1524 1512 -12 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../main/scala/whisk/core/controller/WebActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9XZWJBY3Rpb25zLnNjYWxh) | `88.53% <0%> (ø)` | :arrow_up: | | [...ain/scala/whisk/http/LenientSprayJsonSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvTGVuaWVudFNwcmF5SnNvblN1cHBvcnQuc2NhbGE=) | `100% <0%> (ø)` | | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `88.88% <0%> (+30.55%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=footer). Last update [375c180...2b925af](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #143: Update tracking information and make this repo scancode compliant.
mrutkows opened a new pull request #143: Update tracking information and make this repo scancode compliant. URL: https://github.com/apache/incubator-openwhisk-release/pull/143 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3619: Provide an activation store SPI
chetanmeh commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-387539747 @dubee Can you share some details on requirement of a new SPI as the `ActivationStoreProvider` introduced in this PR is having similar feature set as `ArtifactStore` based implementation. Is the intention to store the activation in a store other than CouchDB for std deployment This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet opened a new pull request #149: loosen restrictions on redis values
jasonpet opened a new pull request #149: loosen restrictions on redis values URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/149 Allow values other than just host0 and host1 for the field "active". Also allow user to specify a redis key prefix if they want instead of just using the db prefix as the default. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser closed pull request #292: Account for variable length timestamps when stripping logs
mdeuser closed pull request #292: Account for variable length timestamps when stripping logs URL: https://github.com/apache/incubator-openwhisk-cli/pull/292 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/commands/activation.go b/commands/activation.go index a360270f..dcf1ffa9 100644 --- a/commands/activation.go +++ b/commands/activation.go @@ -202,7 +202,12 @@ var activationLogsCmd = { return werr } - printActivationLogs(activation.Logs) + if !Flags.activation.strip { + printActivationLogs(activation.Logs) + } else { + printStrippedActivationLogs(activation.Logs) + } + return nil }, } diff --git a/commands/util.go b/commands/util.go index 570a93eb..a33ad23d 100644 --- a/commands/util.go +++ b/commands/util.go @@ -225,6 +225,19 @@ func makeDefaultHeader(collection interface{}) string { return defaultHeader } +func stripTimestamp(log string) (strippedLog string) { + regex := regexp.MustCompile("[a-zA-Z0-9\\s]*(stdout|stderr):\\s(.*)") + match := regex.FindStringSubmatch(log) + + if len(match) > 2 && len(match[2]) > 0 { + strippedLog = match[2] + } else { + strippedLog = log + } + + return strippedLog +} + func printFullList(collection interface{}) { switch collection := collection.(type) { case []whisk.Action: @@ -280,14 +293,15 @@ func printFullActivationList(activations []whisk.Activation) { } } -func printActivationLogs(logs []string) { +func printStrippedActivationLogs(logs []string) { for _, log := range logs { - if Flags.activation.strip { - fmt.Printf("%s\n", log[39:]) - } else { - fmt.Printf("%s\n", log) - } + fmt.Printf("%s\n", stripTimestamp(log)) + } +} +func printActivationLogs(logs []string) { + for _, log := range logs { + fmt.Printf("%s\n", log) } } diff --git a/commands/util_test.go b/commands/util_test.go new file mode 100644 index ..afdba359 --- /dev/null +++ b/commands/util_test.go @@ -0,0 +1,46 @@ + +build unit + +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package commands + +import ( + "github.com/stretchr/testify/assert" + "testing" +) + +func TestStripTimestamp(t *testing.T) { + logs := map[string]string{ + "2018-05-02T19:33:32.829992819Z stdout: this is stdout stderr: this is still stdout": "this is stdout stderr: this is still stdout", + "2018-05-02T19:33:32.829992819Z stderr: this is stderr stdout: this is still stderr": "this is stderr stdout: this is still stderr", + "2018-05-02T19:33:32.89Z stdout: this is stdout": "this is stdout", + "2018-05-02T19:33:32.89Z stderr: this is stderr": "this is stderr", + "anything stdout: this is stdout": "this is stdout", + "anything stderr: this is stderr": "this is stderr", + "stdout: this is stdout": "this is stdout", + "stderr: this is stderr": "this is stderr", + "this is stdout": "this is stdout", + "this is stderr": "this is stderr", + "something": "something", + "":
[GitHub] mdeuser closed issue #291: Activation log --strip command malforms output
mdeuser closed issue #291: Activation log --strip command malforms output URL: https://github.com/apache/incubator-openwhisk-cli/issues/291 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3232: Making prewarm kind (and count) configurable
codecov-io commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-387519362 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232?src=pr=h1) Report > Merging [#3232](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7d9372f4ea7e49ad4dd691cba80526cc1c3e940c?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `71.42%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3232 +/- ## == - Coverage 74.41% 74.39% -0.02% == Files 126 126 Lines5952 5953 +1 Branches 391 392 +1 == Hits 4429 4429 - Misses 1523 1524 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.2% <100%> (+0.09%)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `85.71% <100%> (-0.17%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `84.61% <0%> (-3.85%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232?src=pr=footer). Last update [7d9372f...c399b5f](https://codecov.io/gh/apache/incubator-openwhisk/pull/3232?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3613: Split test jobs in Travis
codecov-io commented on issue #3613: Split test jobs in Travis URL: https://github.com/apache/incubator-openwhisk/pull/3613#issuecomment-386723418 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=h1) Report > Merging [#3613](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/375c180b7332b671c1878761fb1d891b59ba3478?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/graphs/tree.svg?src=pr=150=650=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3613 +/- ## == - Coverage 74.39% 74.37% -0.02% == Files 125 126 +1 Lines5951 5952 +1 Branches 384 391 +7 == Hits 4427 4427 - Misses 1524 1525 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=tree) | Coverage Δ | | |---|---|---| | [...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh) | `84.61% <0%> (-15.39%)` | :arrow_down: | | [.../main/scala/whisk/core/controller/WebActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9XZWJBY3Rpb25zLnNjYWxh) | `88.53% <0%> (ø)` | :arrow_up: | | [...ain/scala/whisk/http/LenientSprayJsonSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvTGVuaWVudFNwcmF5SnNvblN1cHBvcnQuc2NhbGE=) | `100% <0%> (ø)` | | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=footer). Last update [375c180...ef17e79](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #49: Add ASF license headers to all Scala .conf files.
houshengbo closed pull request #49: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/49 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.scalafmt.conf b/.scalafmt.conf index 0dc41ec..7084efe 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,6 +1,9 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + style = intellij danglingParentheses = false maxColumn = 120 docstrings = JavaDoc rewrite.rules = [SortImports] -project.git = true \ No newline at end of file +project.git = true diff --git a/tests/src/test/resources/application.conf b/tests/src/test/resources/application.conf index 873d223..759f063 100644 --- a/tests/src/test/resources/application.conf +++ b/tests/src/test/resources/application.conf @@ -1,3 +1,5 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. whisk.spi { SimpleSpi = whisk.spi.SimpleSpiImpl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3628: Revert "Replace WALA Pair with clean new Pair."
codecov-io commented on issue #3628: Revert "Replace WALA Pair with clean new Pair." URL: https://github.com/apache/incubator-openwhisk/pull/3628#issuecomment-387504314 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3628?src=pr=h1) Report > Merging [#3628](https://codecov.io/gh/apache/incubator-openwhisk/pull/3628?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7d9372f4ea7e49ad4dd691cba80526cc1c3e940c?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3628/graphs/tree.svg?height=150=650=l0YmsiSAso=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3628?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3628 +/- ## === Coverage 74.41% 74.41% === Files 126 126 Lines5952 5952 Branches 391 391 === Hits 4429 4429 Misses 1523 1523 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3628?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3628?src=pr=footer). Last update [7d9372f...4a658ea](https://codecov.io/gh/apache/incubator-openwhisk/pull/3628?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3627: remove unused imports or dead variables as reported in travis build.
codecov-io commented on issue #3627: remove unused imports or dead variables as reported in travis build. URL: https://github.com/apache/incubator-openwhisk/pull/3627#issuecomment-387504099 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3627?src=pr=h1) Report > Merging [#3627](https://codecov.io/gh/apache/incubator-openwhisk/pull/3627?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7d9372f4ea7e49ad4dd691cba80526cc1c3e940c?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3627/graphs/tree.svg?token=l0YmsiSAso=pr=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3627?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#3627 +/- ## === Coverage 74.41% 74.41% === Files 126 126 Lines5952 5952 Branches 391 391 === Hits 4429 4429 Misses 1523 1523 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3627?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3627?src=pr=footer). Last update [7d9372f...c49a5b0](https://codecov.io/gh/apache/incubator-openwhisk/pull/3627?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet closed pull request #171: Remove reference to Pair and replace with bespoke class.
jasonpet closed pull request #171: Remove reference to Pair and replace with bespoke class. URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/171 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index ede5a15..4f86fab 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,6 @@ .gradle build/ node_modules/ -action/*.zip \ No newline at end of file +action/*.zip +.idea +*.iml diff --git a/tests/src/test/scala/system/CloudantUtil.java b/tests/src/test/scala/system/CloudantUtil.java index 7776203..a8c9c61 100755 --- a/tests/src/test/scala/system/CloudantUtil.java +++ b/tests/src/test/scala/system/CloudantUtil.java @@ -20,7 +20,6 @@ import com.cloudant.client.api.Database; import com.google.gson.*; import com.jayway.restassured.response.Response; -import common.Pair; import common.TestUtils; import java.io.*; @@ -53,9 +52,18 @@ public static final File VIEW_AND_SEARCH_DDOC_PATH = getFileRelativeToCloudantHome("tests/dat/searchdesigndoc.txt"); public static final File FILTER_DDOC_PATH = getFileRelativeToCloudantHome("tests/dat/filterdesigndoc.txt"); - private static Gson gson = new Gson(); +private static class ResponsePair { +public final Integer fst; +public final JsonObject snd; + +public ResponsePair(Integer a, JsonObject b) { +this.fst = a; +this.snd = b; +} +} + public static class Credential { public final String user; public final String password; @@ -96,7 +104,7 @@ public static void setUp(Credential credential) throws Exception { deleteTestDatabase(credential); for (int i = 0; i < 5; i++) { try { -Pairresponse = CloudantUtil.createTestDatabase(credential, false); +ResponsePair response = CloudantUtil.createTestDatabase(credential, false); if (response.fst == 201) return; // respond code is sometimes not 201 but still ok @@ -147,11 +155,11 @@ public static JsonObject deleteTestDatabase(Credential credential, String dbName * * @throws UnsupportedEncodingException */ -public static Pair createTestDatabase(Credential credential) throws UnsupportedEncodingException { +public static ResponsePair createTestDatabase(Credential credential) throws UnsupportedEncodingException { return createTestDatabase(credential, true); } -private static Pair createTestDatabase(Credential credential, boolean failIfCannotCreate) throws UnsupportedEncodingException { +private static ResponsePair createTestDatabase(Credential credential, boolean failIfCannotCreate) throws UnsupportedEncodingException { // Use PUT to create the database. // This could fail if the database already exists, but that's ok. String dbName = credential.dbname; @@ -160,7 +168,7 @@ public static JsonObject deleteTestDatabase(Credential credential, String dbName System.out.format("Response of create database %s: %s\n", dbName, response.asString()); if (failIfCannotCreate) assertTrue("failed to create database " + dbName, response.statusCode() == 201 || response.statusCode() == 202); -return Pair.make(response.statusCode(), (JsonObject) new JsonParser().parse(response.asString())); +return new ResponsePair(response.statusCode(), (JsonObject) new JsonParser().parse(response.asString())); } /** This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #3628: Revert "Replace WALA Pair with clean new Pair."
mrutkows commented on issue #3628: Revert "Replace WALA Pair with clean new Pair." URL: https://github.com/apache/incubator-openwhisk/pull/3628#issuecomment-387491504 @csantanapr Carlos, what do we need to do in IBM PG to fix this in order to merge in open? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #142: Replace or remove Pair.java from main openwhisk repo.
mrutkows commented on issue #142: Replace or remove Pair.java from main openwhisk repo. URL: https://github.com/apache/incubator-openwhisk-release/issues/142#issuecomment-387490624 The PR was reverted as it broke IBM's private playground build by @markusthoemmes so we need to continue to track this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #142: Replace or remove Pair.java from main openwhisk repo.
mrutkows opened a new issue #142: Replace or remove Pair.java from main openwhisk repo. URL: https://github.com/apache/incubator-openwhisk-release/issues/142 This file was coped from another project for testing purposes; its license cannot be removed or changed. Instead, the file itself needs to be replaced or removed. See discussion in this issue: [https://github.com/apache/incubator-openwhisk/pull/3620](https://github.com/apache/incubator-openwhisk/pull/3620) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes opened a new pull request #3628: Revert "Replace WALA Pair with clean new Pair."
markusthoemmes opened a new pull request #3628: Revert "Replace WALA Pair with clean new Pair." URL: https://github.com/apache/incubator-openwhisk/pull/3628 Reverts apache/incubator-openwhisk#3624 This broke some downstream repositories. Will fix those first before merging this (soon!) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #3627: remove unused imports or dead variables as reported in travis build.
rabbah opened a new pull request #3627: remove unused imports or dead variables as reported in travis build. URL: https://github.com/apache/incubator-openwhisk/pull/3627 I noticed in travis builds there are several python related warnings from the flake8 - so I removed them. ``` /tests/dat/actions/sleep.py:12:1: F401 'sys' imported but unused ./performance/gatling_tests/src/gatling/resources/data/pythonAction.py:4:1: F401 'sys' imported but unused ./actionRuntimes/actionProxy/invoke.py:39:1: F401 'traceback' imported but unused 3 F401 'traceback' imported but unused ./tools/admin/wskadmin:534:5: F841 local variable 'argsDict' is assigned to but never used ./tools/admin/wskadmin:553:5: F841 local variable 'argsDict' is assigned to but never used 2 F841 local variable 'argsDict' is assigned to but never used ``` ## Types of changes - [x ] Enhancement or new feature (adds new functionality). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #33: Add ASF license headers to all Scala .conf files.
houshengbo closed pull request #33: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/33 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.scalafmt.conf b/.scalafmt.conf index 0dc41ec..7084efe 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,6 +1,9 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + style = intellij danglingParentheses = false maxColumn = 120 docstrings = JavaDoc rewrite.rules = [SortImports] -project.git = true \ No newline at end of file +project.git = true diff --git a/tests/src/test/resources/application.conf b/tests/src/test/resources/application.conf index 873d223..759f063 100644 --- a/tests/src/test/resources/application.conf +++ b/tests/src/test/resources/application.conf @@ -1,3 +1,5 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. whisk.spi { SimpleSpi = whisk.spi.SimpleSpiImpl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #273: Add ASF license headers to all Scala .conf files.
houshengbo closed pull request #273: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-catalog/pull/273 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.scalafmt.conf b/.scalafmt.conf index 0dc41ec..7084efe 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,6 +1,9 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + style = intellij danglingParentheses = false maxColumn = 120 docstrings = JavaDoc rewrite.rules = [SortImports] -project.git = true \ No newline at end of file +project.git = true This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on a change in pull request #3416: Refactor and unit test PoolingRestClient
dubee commented on a change in pull request #3416: Refactor and unit test PoolingRestClient URL: https://github.com/apache/incubator-openwhisk/pull/3416#discussion_r186810288 ## File path: tests/src/test/scala/whisk/http/PoolingRestClientTests.scala ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.http + +import org.junit.runner.RunWith +import org.scalatest.{FlatSpecLike, Matchers} +import org.scalatest.concurrent.ScalaFutures +import org.scalatest.junit.JUnitRunner + +import akka.NotUsed +import akka.actor.ActorSystem +import akka.stream.scaladsl.Flow +import akka.stream.ActorMaterializer +import akka.testkit.TestKit +import akka.http.scaladsl.model._ +import akka.http.scaladsl.model.HttpMethods.{GET, POST} +import akka.http.scaladsl.model.StatusCodes.{InternalServerError, NotFound} +import akka.http.scaladsl.model.headers.RawHeader + +import common.StreamLogging + +import spray.json.JsObject +import spray.json.DefaultJsonProtocol._ + +import scala.concurrent.duration._ +import scala.concurrent.{Await, ExecutionContext, Future, Promise} +import scala.util.{Success, Try} + +import whisk.http.PoolingRestClient._ + +@RunWith(classOf[JUnitRunner]) +class PoolingRestClientTests +extends TestKit(ActorSystem("PoolingRestClientTests")) +with FlatSpecLike +with Matchers +with ScalaFutures +with StreamLogging { + implicit val ec: ExecutionContext = system.dispatcher + implicit val materializer: ActorMaterializer = ActorMaterializer() + + def testFlow(httpResponse: HttpResponse = HttpResponse(), httpRequest: HttpRequest = HttpRequest()) +: Flow[(HttpRequest, Promise[HttpResponse]), (Try[HttpResponse], Promise[HttpResponse]), NotUsed] = +Flow[(HttpRequest, Promise[HttpResponse])] + .mapAsyncUnordered(1) { +case (request, userContext) => + request shouldBe httpRequest + Future.successful((Success(httpResponse), userContext)) + } Review comment: Not sure where the error comes from. Can that be investigated separate from this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-387483534 @rabbah, looks like caching is enabled/disabled on the `WhiskAction` singleton level, which is common code shared among the controller and invoker. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2847: Treat action code as attachments for created/updated actions
dubee commented on issue #2847: Treat action code as attachments for created/updated actions URL: https://github.com/apache/incubator-openwhisk/pull/2847#issuecomment-387482679 @markusthoemmes, Travis is now passing. Awaiting more feed back. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #19: Add ASF license headers to all Scala .conf files.
houshengbo closed pull request #19: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/19 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.scalafmt.conf b/.scalafmt.conf index 0dc41ec..7084efe 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,6 +1,9 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + style = intellij danglingParentheses = false maxColumn = 120 docstrings = JavaDoc rewrite.rules = [SortImports] -project.git = true \ No newline at end of file +project.git = true diff --git a/tests/src/test/resources/application.conf b/tests/src/test/resources/application.conf index 873d223..759f063 100644 --- a/tests/src/test/resources/application.conf +++ b/tests/src/test/resources/application.conf @@ -1,3 +1,5 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. whisk.spi { SimpleSpi = whisk.spi.SimpleSpiImpl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #273: Add ASF license headers to all Scala .conf files.
mrutkows opened a new pull request #273: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-catalog/pull/273 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #33: Add ASF license headers to all Scala .conf files.
mrutkows opened a new pull request #33: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #48: Add ASF license headers to all Scala .conf files.
mrutkows opened a new pull request #48: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/48 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #49: Add ASF license headers to all Scala .conf files.
mrutkows opened a new pull request #49: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #103: Document LICENSE file Exclusions for incubator-openwhisk-runtime-php
mrutkows commented on issue #103: Document LICENSE file Exclusions for incubator-openwhisk-runtime-php URL: https://github.com/apache/incubator-openwhisk-release/issues/103#issuecomment-384091198 merged https://github.com/apache/incubator-openwhisk-runtime-php/pull/13#event-1579337468 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #19: Add ASF license headers to all Scala .conf files.
mrutkows opened a new pull request #19: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #21: Add ASF license headers to all Scala .conf files.
houshengbo closed pull request #21: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/21 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.scalafmt.conf b/.scalafmt.conf index 0dc41ec..7084efe 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,6 +1,9 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + style = intellij danglingParentheses = false maxColumn = 120 docstrings = JavaDoc rewrite.rules = [SortImports] -project.git = true \ No newline at end of file +project.git = true diff --git a/tests/src/test/resources/application.conf b/tests/src/test/resources/application.conf index 873d223..759f063 100644 --- a/tests/src/test/resources/application.conf +++ b/tests/src/test/resources/application.conf @@ -1,3 +1,5 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. whisk.spi { SimpleSpi = whisk.spi.SimpleSpiImpl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #21: Add ASF license headers to all Scala .conf files.
mrutkows opened a new pull request #21: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #3620: Remove Eclipse license header and IBM copyright from a test file
mrutkows closed pull request #3620: Remove Eclipse license header and IBM copyright from a test file URL: https://github.com/apache/incubator-openwhisk/pull/3620 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tests/src/test/scala/common/Pair.java b/tests/src/test/scala/common/Pair.java index 0853f49a0e..9172686583 100644 --- a/tests/src/test/scala/common/Pair.java +++ b/tests/src/test/scala/common/Pair.java @@ -15,16 +15,6 @@ * limitations under the License. */ -/*** - * Copyright (c) 2002 - 2006 IBM Corporation. - * All rights reserved. This program and the accompanying materials - * are made available under the terms of the Eclipse Public License v1.0 - * which accompanies this distribution, and is available at - * http://www.eclipse.org/legal/epl-v10.html - * - * Contributors: - * IBM Corporation - initial API and implementation - ***/ package common; import java.util.Iterator; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #142: Replace or remove Pair.java from main openwhisk repo.
mrutkows closed issue #142: Replace or remove Pair.java from main openwhisk repo. URL: https://github.com/apache/incubator-openwhisk-release/issues/142 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #3624: Replace WALA Pair with clean new Pair.
mrutkows commented on issue #3624: Replace WALA Pair with clean new Pair. URL: https://github.com/apache/incubator-openwhisk/pull/3624#issuecomment-387465388 closes #3620, closes apache/incubator-openwhisk-release#142 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #3624: Replace WALA Pair with clean new Pair.
mrutkows closed pull request #3624: Replace WALA Pair with clean new Pair. URL: https://github.com/apache/incubator-openwhisk/pull/3624 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tests/src/test/scala/common/Pair.java b/tests/src/test/scala/common/Pair.java index 0853f49a0e..e31f46c53c 100644 --- a/tests/src/test/scala/common/Pair.java +++ b/tests/src/test/scala/common/Pair.java @@ -15,87 +15,14 @@ * limitations under the License. */ -/*** - * Copyright (c) 2002 - 2006 IBM Corporation. - * All rights reserved. This program and the accompanying materials - * are made available under the terms of the Eclipse Public License v1.0 - * which accompanies this distribution, and is available at - * http://www.eclipse.org/legal/epl-v10.html - * - * Contributors: - * IBM Corporation - initial API and implementation - ***/ package common; -import java.util.Iterator; -import java.util.NoSuchElementException; - -public class Pair{ - -public final T fst; -public final U snd; - -protected Pair(T fst, U snd) { -this.fst = fst; -this.snd = snd; -} - -private boolean check(Object x, Object y) { -return (x == null) ? (y == null) : x.equals(y); -} - -@SuppressWarnings("rawtypes") -@Override -public boolean equals(Object o) { -return (o instanceof Pair) && check(fst, ((Pair) o).fst) -&& check(snd, ((Pair) o).snd); -} - -private int hc(Object o) { -return (o == null) ? 0 : o.hashCode(); -} - -@Override -public int hashCode() { -return hc(fst) * 7219 + hc(snd); -} - -public Iterator iterator() { -return new Iterator() { -byte next = 1; - -@Override -public boolean hasNext() { -return next > 0; -} - -@Override -public Object next() { -switch (next) { -case 1: -next++; -return fst; -case 2: -next = 0; -return snd; -default: -throw new NoSuchElementException(); -} -} - -@Override -public void remove() { -assert false; -} -}; -} - -@Override -public String toString() { -return "[" + fst + "," + snd + "]"; -} +public class Pair { +public final String fst; +public final String snd; -public static Pair make(T x, U y) { -return new Pair (x, y); +public Pair(String a, String b) { +this.fst = a; +this.snd = b; } } diff --git a/tests/src/test/scala/common/TestUtils.java b/tests/src/test/scala/common/TestUtils.java index 0042445469..4c379e9d50 100644 --- a/tests/src/test/scala/common/TestUtils.java +++ b/tests/src/test/scala/common/TestUtils.java @@ -218,8 +218,8 @@ protected RunResult(int exitCode, String stdout, String stderr) { this.stderr = stderr; } -public Pair logs() { -return Pair.make(stdout, stderr); +public Pair logs() { +return new Pair(stdout, stderr); } public void validateExitCode(int expectedExitCode) { diff --git a/tests/src/test/scala/common/WhiskProperties.java b/tests/src/test/scala/common/WhiskProperties.java index d8897bca5b..08a206948d 100644 --- a/tests/src/test/scala/common/WhiskProperties.java +++ b/tests/src/test/scala/common/WhiskProperties.java @@ -254,12 +254,12 @@ public static int getMaxActionInvokesPerMinute() { * read the contents of auth key file and return as a Pair * */ -public static Pair getBasicAuth() { +public static Pair getBasicAuth() { File f = getAuthFileForTesting(); String contents = readAuthKey(f); String[] parts = contents.split(":"); assert parts.length == 2; -return Pair.make(parts[0], parts[1]); +return new Pair(parts[0], parts[1]); } /** This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #3626: Add ASF license headers to all Scala .conf files.
houshengbo closed pull request #3626: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk/pull/3626 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.scalafmt.conf b/.scalafmt.conf index 0dc41ec0b2..7084efe600 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,6 +1,9 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + style = intellij danglingParentheses = false maxColumn = 120 docstrings = JavaDoc rewrite.rules = [SortImports] -project.git = true \ No newline at end of file +project.git = true diff --git a/common/scala/src/main/resources/application.conf b/common/scala/src/main/resources/application.conf index ea4bd46340..c61a60c546 100644 --- a/common/scala/src/main/resources/application.conf +++ b/common/scala/src/main/resources/application.conf @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + # default application configuration file for akka include "logging" diff --git a/common/scala/src/main/resources/logging.conf b/common/scala/src/main/resources/logging.conf index 1882262c4f..46b9fc9e42 100644 --- a/common/scala/src/main/resources/logging.conf +++ b/common/scala/src/main/resources/logging.conf @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + akka { loglevel = "DEBUG" loggers = ["akka.event.slf4j.Slf4jLogger"] diff --git a/common/scala/src/main/resources/reference.conf b/common/scala/src/main/resources/reference.conf index 8048d43bd4..35cf4f09a5 100644 --- a/common/scala/src/main/resources/reference.conf +++ b/common/scala/src/main/resources/reference.conf @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + whisk.spi { ArtifactStoreProvider = whisk.core.database.CouchDbStoreProvider MessagingProvider = whisk.connector.kafka.KafkaMessagingProvider diff --git a/core/controller/src/main/resources/application.conf b/core/controller/src/main/resources/application.conf index e72bbc3b38..faec173231 100644 --- a/core/controller/src/main/resources/application.conf +++ b/core/controller/src/main/resources/application.conf @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + # common logging configuration see common scala include "logging" include "akka-http-version" diff --git a/core/controller/src/main/resources/reference.conf b/core/controller/src/main/resources/reference.conf index ec7cd8a4cd..85712a4141 100644 --- a/core/controller/src/main/resources/reference.conf +++ b/core/controller/src/main/resources/reference.conf @@ -1,3 +1,5 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. whisk { cluster { diff --git a/core/invoker/src/main/resources/application.conf b/core/invoker/src/main/resources/application.conf index aaff48f287..ebd45e5838 100644 --- a/core/invoker/src/main/resources/application.conf +++ b/core/invoker/src/main/resources/application.conf @@ -1,3 +1,6 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + # common logging configuration see common scala include "logging" include "akka-http-version" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on a change in pull request #292: Account for variable length timestamps when stripping logs
mdeuser commented on a change in pull request #292: Account for variable length timestamps when stripping logs URL: https://github.com/apache/incubator-openwhisk-cli/pull/292#discussion_r186783736 ## File path: commands/util.go ## @@ -280,14 +280,22 @@ func printFullActivationList(activations []whisk.Activation) { } } -func printActivationLogs(logs []string) { +func printStrippedActivationLogs(logs []string) { for _, log := range logs { - if Flags.activation.strip { - fmt.Printf("%s\n", log[39:]) + regex := regexp.MustCompile("[a-zA-Z0-9\\s]*(stdout|stderr):\\s(.*)") + match := regex.FindStringSubmatch(log) + + if len(match) > 2 && len(match[2]) > 0 { + fmt.Printf("%s\n", match[2]) Review comment: what do you think about using a utility function for the individual log strip logic ``` func stripTimestamp(log string) strippedLog string { regex := regexp.MustCompile("[a-zA-Z0-9\\s]*(stdout|stderr):\\s(.*)") match := regex.FindStringSubmatch(log) if len(match) > 2 && len(match[2]) > 0 { strippedLog = match[2] } else { strippedLog = log } return strippedLog } ``` then the print function would become ``` func printStrippedActivationLogs(logs []string) { for _, log := range logs { fmt.Printf("%s\n", stripTimestamp(log)) } } ``` the unit test would just validate the utility function. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #55: Add ASF license headers to all Scala .conf files.
houshengbo closed pull request #55: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/55 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.scalafmt.conf b/.scalafmt.conf index 0dc41ec..7084efe 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,6 +1,9 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + style = intellij danglingParentheses = false maxColumn = 120 docstrings = JavaDoc rewrite.rules = [SortImports] -project.git = true \ No newline at end of file +project.git = true diff --git a/tests/src/test/resources/application.conf b/tests/src/test/resources/application.conf index 873d223..759f063 100644 --- a/tests/src/test/resources/application.conf +++ b/tests/src/test/resources/application.conf @@ -1,3 +1,5 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. whisk.spi { SimpleSpi = whisk.spi.SimpleSpiImpl This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3613: Split test jobs in Travis
csantanapr commented on issue #3613: Split test jobs in Travis URL: https://github.com/apache/incubator-openwhisk/pull/3613#issuecomment-387456127 This looks awesome @chetanmeh good progress. And took overall build time down to ~30 minutes ^^ @rabbah This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3623: Inconsistency in response of GET activations API call
rabbah commented on issue #3623: Inconsistency in response of GET activations API call URL: https://github.com/apache/incubator-openwhisk/issues/3623#issuecomment-387455464 ✅ a trigger or rule activation only has a `start` field and no `end` field, and the `statusCode` is omitted for triggers and rules as noted. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #172: add travis2slack webhook
rabbah commented on issue #172: add travis2slack webhook URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/172#issuecomment-387452746 thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #172: add travis2slack webhook
rabbah closed pull request #172: add travis2slack webhook URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/172 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.travis.yml b/.travis.yml index ce79a21..2b9de2a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,6 +6,13 @@ language: scala services: - docker +notifications: + email: false + webhooks: +urls: + # travis2slack webhook to enable DMs on openwhisk-team.slack.com to PR authors with TravisCI results + secure: "ZGbbsXqN4Vv0Vkz5USmtKa43X3/OpLtVm0ELME2vVTei09O41qhsF3Tm0MIm/EIKQkt/wdUXoF5GFImdzn9dXYevhapHBA3qOjzhyv0nMWMBYddb/b8kfGnRuhd1YpNMc1VMTj21CPE0zhlUe1NsfOW1KF901pKxaNg6pAHC8M7ngTI1vMJI2Y3B1gG2jgJBpbjxZsERo4FhFwmcYUZXNWFwqk7ERnwJPs5AxrLHb4d9+l20TgCQe+q/PKd7cyIGbeemxrDxjxijUV3tOFwN0aOrSjBOUDHUFiF7+UqzTUkjUtu3x0gOwS5dF8Dcg9sAGXZaal66bS1ckzNNnYvgGPO8NvnTll6Ootr/qC5pLw3+zh9TiXzrcQR7rIDeeei35SLyy1szWl67lGaVWXHSGXluCip+EbRixvTxK/Fyiztgq1S1SoNNvTX5J5wTSy2klEM7ZnCoT9iFMFr51nmcsmDZwD3abiO4rjFGI2G0ZewDy3gqOo87eoHksT46up4jmDlEz6XjQlPe8Of10ZrHRkIsETzMFeE+AMUX0aLFQ5QJPMlx1iUOhQcDzonstcOUV3F8+fVWkfeF2LTO1pJcyVtGr0wy6s1R+89U27IHTORoYHLi2YJY5a4Y0KUkT8E9Ni2CSL5sLicirsKsj2uL4rMx5zrS/1YjnXnp1DO27fw=" + env: global: - secure: "HLdKwdpaAKJrwUNYMFHEK2oR47FVzfKv5aovTfBngZJu+JkoXseL7UJyL8b3KJtBhE49QjWD5yTTV9CQUOtuemITHIzLGaHXa9gbrpgVHdxr6shzBo49Lgj++KgbHpyR+LxDCUJhLU2n7r02Rn5V+qEYkqF2zXJ9Pt2CUAHX2aDGkdEm/z8Rr9+2h9U5XUWSablHr9HAZd9H3Y4YjT8b0iAsrp/J0RgaOGhF7aSYiEVYnrxVI+aeSlH0Wj4RNzaCOaOUniJHoIWfQnAbHfn2F5pXmgjU+KWHrrXEaYuaPGS0bEelf8WAJjwsfDAJ/je/JcsG/nj6AxvB/EPSrT76XOFkeAUIBO8uE4ubBEytni80cPwRPXEVM6hZ6XmFykghYRqhq3uWhoiJf3TtGXzJBYH5WpBgOPFYMUAVM5a1B4VIr4l5GaFrG+95sPBQbFHWAdTDcByqXQhc9o4nCPve0C0EhHyaD/sCu97SMK+oqEXNBOS6M8I3kBrQpI1TZqf6Rl94pciD1QscVSjwI1Du7qSe1LKuaBqJ67H2EVVaHS04VbE2uR5wcJ2A9mFbtA+j5ipGjXFaJF6k9+Fo+m5Py8rWj6zWx/3QFkIPlS1PmI3gXwUIF4tSZGwLmIDsQMYsus1EA10Kr7FA9qRnSFS4avn57SwDJSvBLrYJrVVav/8=" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3613: Split test jobs in Travis
codecov-io commented on issue #3613: Split test jobs in Travis URL: https://github.com/apache/incubator-openwhisk/pull/3613#issuecomment-386723418 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=h1) Report > Merging [#3613](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/375c180b7332b671c1878761fb1d891b59ba3478?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3613 +/- ## == - Coverage 74.39% 74.37% -0.02% == Files 125 125 Lines5951 5951 Branches 384 384 == - Hits 4427 4426 -1 - Misses 1524 1525 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=tree) | Coverage Δ | | |---|---|---| | [...in/scala/whisk/utils/ExecutionContextFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL3V0aWxzL0V4ZWN1dGlvbkNvbnRleHRGYWN0b3J5LnNjYWxh) | `84.61% <0%> (-15.39%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=footer). Last update [375c180...f42ad35](https://codecov.io/gh/apache/incubator-openwhisk/pull/3613?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3615: Terminate route for invalid list skip values
codecov-io commented on issue #3615: Terminate route for invalid list skip values URL: https://github.com/apache/incubator-openwhisk/pull/3615#issuecomment-386757956 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr=h1) Report > Merging [#3615](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/375c180b7332b671c1878761fb1d891b59ba3478?src=pr=desc) will **increase** coverage by `0.15%`. > The diff coverage is `93.33%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/graphs/tree.svg?token=l0YmsiSAso=650=pr=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3615 +/- ## == + Coverage 74.39% 74.54% +0.15% == Files 125 125 Lines5951 5975 +24 Branches 384 385 +1 == + Hits 4427 4454 +27 + Misses 1524 1521 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr=tree) | Coverage Δ | | |---|---|---| | [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <100%> (+1.26%)` | :arrow_up: | | [...main/scala/whisk/core/controller/Activations.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3RpdmF0aW9ucy5zY2FsYQ==) | `96.61% <100%> (+0.05%)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/RestAPIs.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SZXN0QVBJcy5zY2FsYQ==) | `46.83% <100%> (+4.94%)` | :arrow_up: | | [...main/scala/whisk/core/entitlement/Collection.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXRsZW1lbnQvQ29sbGVjdGlvbi5zY2FsYQ==) | `85.71% <100%> (+0.34%)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/Packages.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9QYWNrYWdlcy5zY2FsYQ==) | `89.32% <100%> (+0.43%)` | :arrow_up: | | [...rc/main/scala/whisk/core/controller/Triggers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9UcmlnZ2Vycy5zY2FsYQ==) | `80.71% <87.5%> (+0.56%)` | :arrow_up: | | [...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh) | `91.28% <87.5%> (+0.18%)` | :arrow_up: | | [...r/src/main/scala/whisk/core/controller/Rules.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9SdWxlcy5zY2FsYQ==) | `89.26% <87.5%> (+0.29%)` | :arrow_up: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr=footer). Last update [375c180...e5a2a46](https://codecov.io/gh/apache/incubator-openwhisk/pull/3615?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #172: add travis2slack webhook
dgrove-oss opened a new pull request #172: add travis2slack webhook URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/172 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #172: add travis2slack webhook
dgrove-oss commented on issue #172: add travis2slack webhook URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/172#issuecomment-387449258 Good to go. ![screen shot 2018-05-08 at 11 47 14 am](https://user-images.githubusercontent.com/5099100/39767804-988d3d64-52b5-11e8-97e3-239f1e69c8e5.png) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3626: Add ASF license headers to all Scala .conf files.
codecov-io commented on issue #3626: Add ASF license headers to all Scala .conf files. URL: https://github.com/apache/incubator-openwhisk/pull/3626#issuecomment-387448696 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3626?src=pr=h1) Report > Merging [#3626](https://codecov.io/gh/apache/incubator-openwhisk/pull/3626?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/375c180b7332b671c1878761fb1d891b59ba3478?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3626/graphs/tree.svg?token=l0YmsiSAso=pr=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3626?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3626 +/- ## = + Coverage 74.39% 74.4% +0.01% = Files 125 125 Lines59515951 Branches 384 384 = + Hits 44274428 +1 + Misses 15241523 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3626?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3626/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3626?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3626?src=pr=footer). Last update [375c180...eb3b403](https://codecov.io/gh/apache/incubator-openwhisk/pull/3626?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #172: add travis2slack webhook
dgrove-oss commented on issue #172: add travis2slack webhook URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/172#issuecomment-387447164 I'll post a screenshot here once the hook succeeds. Please don't merge before then in case I messed up the URL. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3613: Split test jobs in Travis
csantanapr commented on a change in pull request #3613: Split test jobs in Travis URL: https://github.com/apache/incubator-openwhisk/pull/3613#discussion_r186773922 ## File path: .travis.yml ## @@ -48,18 +48,32 @@ notifications: before_install: - pip install --upgrade pip setuptools six - pip3 install --upgrade pip setuptools six - - ./tools/travis/flake8.sh # Check Python files for style and stop the build on syntax errors install: - ./tools/travis/setup.sh jobs: include: - script: -- ./tools/travis/build.sh +- export ORG_GRADLE_PROJECT_testSetName="REQUIRE_ONLY_DB" +- ./tools/travis/scan.sh +- ./tools/travis/setupPrereq.sh +- ./tools/travis/distDocker.sh +- ./tools/travis/runTests.sh - ansible-playbook -i ansible/environments/local ansible/logs.yml # collect logs regardless of build exit -- ./tools/travis/box-upload.py "$TRAVIS_BUILD_DIR/logs" "$TRAVIS_BUILD_ID-$TRAVIS_BRANCH.tar.gz" - env: DESCRIPTION="Execute test suite." +- tools/build/checkLogs.py logs db Review comment: Not consistent `./tools` starting with `./` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #114: docker-compose doesn't work unless I close chrome
csantanapr closed issue #114: docker-compose doesn't work unless I close chrome URL: https://github.com/apache/incubator-openwhisk-devtools/issues/114 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #120: removed port check for ports 80 and 443
csantanapr closed pull request #120: removed port check for ports 80 and 443 URL: https://github.com/apache/incubator-openwhisk-devtools/pull/120 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docker-compose/Makefile b/docker-compose/Makefile index 0a0d52d..2d8e870 100644 --- a/docker-compose/Makefile +++ b/docker-compose/Makefile @@ -131,7 +131,7 @@ print-host: .PHONY: check-required-ports check-required-ports: echo "checking required ports ... " - for port in 80 443 2888 5984 8085 9092 2888 8001; do \ + for port in 2888 5984 8085 9092 2888 8001; do \ pid=`lsof -Pi :$$port -sTCP:LISTEN -t` ; \ if [ ! -z "$$pid" ]; then echo "$$(tput setaf 1)Port $$port is taken by PID:$$pid.$$(tput sgr0)"; exit 1; fi; \ done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3613: Split test jobs in Travis
chetanmeh commented on issue #3613: Split test jobs in Travis URL: https://github.com/apache/incubator-openwhisk/pull/3613#issuecomment-387433061 Post splitting of `build.sh` time has come down to ~ 31 mins (current master is at 46 mins) https://user-images.githubusercontent.com/664531/39765094-e19f51f6-5295-11e8-8c63-6bf2aaebb110.png;> Build Scan * [Unit Tests][1] - 944 tests (11 mins) * [System Tests][2] - 298 tests (14 mins) So total 1242 tests. Current master has 1247 tests. So looking into what is missing [1]: https://scans.gradle.com/s/5jgt74h5xslbg/tests [2]: https://scans.gradle.com/s/drads72h73z76/tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #3609: Support "+json" content-types as WebAction input.
rabbah closed pull request #3609: Support "+json" content-types as WebAction input. URL: https://github.com/apache/incubator-openwhisk/pull/3609 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/common/scala/src/main/scala/whisk/http/LenientSprayJsonSupport.scala b/common/scala/src/main/scala/whisk/http/LenientSprayJsonSupport.scala new file mode 100644 index 00..596058b559 --- /dev/null +++ b/common/scala/src/main/scala/whisk/http/LenientSprayJsonSupport.scala @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.http + +import akka.http.scaladsl.marshallers.sprayjson.SprayJsonSupport +import akka.http.scaladsl.unmarshalling.{FromEntityUnmarshaller, Unmarshaller} +import spray.json.JsValue + +object LenientSprayJsonSupport extends SprayJsonSupport { + // Removes the mandatory application/json content-type for unmarshalling + override implicit def sprayJsValueUnmarshaller: FromEntityUnmarshaller[JsValue] = +Unmarshaller.byteStringUnmarshaller + .andThen(sprayJsValueByteStringUnmarshaller) +} diff --git a/core/controller/src/main/scala/whisk/core/controller/WebActions.scala b/core/controller/src/main/scala/whisk/core/controller/WebActions.scala index 708ad71df8..d74815c293 100644 --- a/core/controller/src/main/scala/whisk/core/controller/WebActions.scala +++ b/core/controller/src/main/scala/whisk/core/controller/WebActions.scala @@ -21,7 +21,6 @@ import java.util.Base64 import scala.concurrent.Future import scala.util.{Failure, Success, Try} - import akka.http.scaladsl.model.HttpEntity.Empty import akka.http.scaladsl.server.Directives import akka.http.scaladsl.model.HttpMethod @@ -36,7 +35,6 @@ import akka.http.scaladsl.model.headers._ import akka.http.scaladsl.model.Uri.Query import akka.http.scaladsl.model.HttpEntity import akka.http.scaladsl.server.Route -import akka.http.scaladsl.marshallers.sprayjson.SprayJsonSupport._ import akka.http.scaladsl.model.headers.`Content-Type` import akka.http.scaladsl.model.headers.`Timeout-Access` import akka.http.scaladsl.model.ContentType @@ -45,13 +43,10 @@ import akka.http.scaladsl.model.FormData import akka.http.scaladsl.model.HttpMethods.{DELETE, GET, HEAD, OPTIONS, PATCH, POST, PUT} import akka.http.scaladsl.model.HttpCharsets import akka.http.scaladsl.model.HttpResponse - import spray.json._ import spray.json.DefaultJsonProtocol._ - import WhiskWebActionsApi.MediaExtension import RestApiCommons.{jsonPrettyResponsePrinter => jsonPrettyPrinter} - import whisk.common.TransactionId import whisk.core.controller.actions.PostActionActivation import whisk.core.database._ @@ -59,6 +54,7 @@ import whisk.core.entity._ import whisk.core.entity.types._ import whisk.http.ErrorResponse.terminate import whisk.http.Messages +import whisk.http.LenientSprayJsonSupport._ import whisk.utils.JsHelpers._ protected[controller] sealed class WebApiDirectives(prefix: String = "__ow_") { @@ -290,7 +286,7 @@ protected[core] object WhiskWebActionsApi extends Directives { } } - private def isJsonFamily(mt: MediaType) = { + def isJsonFamily(mt: MediaType): Boolean = { mt == `application/json` || mt.value.endsWith("+json") } @@ -574,7 +570,7 @@ trait WhiskWebActionsApi extends Directives with ValidateRequestSize with PostAc case Empty => process(None, isRawHttpAction) -case HttpEntity.Strict(ContentTypes.`application/json`, json) if !isRawHttpAction => +case HttpEntity.Strict(ct, json) if WhiskWebActionsApi.isJsonFamily(ct.mediaType) && !isRawHttpAction => if (json.nonEmpty) { entity(as[JsValue]) { body => process(Some(body), isRawHttpAction) diff --git a/tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala b/tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala index 0dd58486ca..7f8cde005e 100644 --- a/tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala +++
[GitHub] markusthoemmes commented on issue #3609: Support "+json" content-types as WebAction input.
markusthoemmes commented on issue #3609: Support "+json" content-types as WebAction input. URL: https://github.com/apache/incubator-openwhisk/pull/3609#issuecomment-387441853 PG2 3101 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3613: Split test jobs in Travis
chetanmeh commented on issue #3613: Split test jobs in Travis URL: https://github.com/apache/incubator-openwhisk/pull/3613#issuecomment-387433061 Post splitting of `build.sh` time has come down to ~ 31 mins (current master is at 46 mins) https://user-images.githubusercontent.com/664531/39765094-e19f51f6-5295-11e8-8c63-6bf2aaebb110.png;> Build Scan * [Unit Tests][1] - 944 tests (11 mins) * [System Tests][2] - 298 tests (14 mins) So total 1242 tests [1]: https://scans.gradle.com/s/5jgt74h5xslbg/tests [2]: https://scans.gradle.com/s/drads72h73z76/tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd closed pull request #297: refactor travis setup
ddragosd closed pull request #297: refactor travis setup URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/297 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/travis/build.sh b/tools/travis/build.sh index f5f91e2..29f9813 100755 --- a/tools/travis/build.sh +++ b/tools/travis/build.sh @@ -16,22 +16,23 @@ # limitations under the License. # -set -e -set -x +set -ex # Build script for Travis-CI. SCRIPTDIR="$(cd "$(dirname "$0")" && pwd)" ROOTDIR="$SCRIPTDIR/../.." HOMEDIR="$ROOTDIR/.." -WHISKDIR="$ROOTDIR/../openwhisk" -UTILDIR="$ROOTDIR/../incubator-openwhisk-utilities" +WHISKDIR="$HOMEDIR/openwhisk" +UTILDIR="$HOMEDIR/incubator-openwhisk-utilities" +# Set Environment +export OPENWHISK_HOME=$WHISKDIR # run scancode util. against project source using the ASF strict configuration cd $UTILDIR scancode/scanCode.py --config scancode/ASF-Release.cfg $ROOTDIR # Install OpenWhisk -cd $WHISKDIR/ansible +cd $OPENWHISK_HOME/ansible ANSIBLE_CMD="ansible-playbook -i environments/local -e docker_image_prefix=openwhisk" @@ -56,11 +57,10 @@ $ANSIBLE_CMD apigateway.yml -e apigateway_local_build=true $ANSIBLE_CMD wipe.yml $ANSIBLE_CMD openwhisk.yml -e cli_installation_mode=remote -e controllerProtocolForSetup=http -# Set Environment -export OPENWHISK_HOME=$WHISKDIR + # Tests -cd $WHISKDIR +cd $OPENWHISK_HOME cat whisk.properties WSK_TESTS_DEPS_EXCLUDE="-x :actionRuntimes:pythonAction:distDocker -x :actionRuntimes:javaAction:distDocker -x :actionRuntimes:nodejs6Action:distDocker -x :actionRuntimes:nodejs8Action:distDocker -x :actionRuntimes:actionProxy:distDocker -x :sdk:docker:distDocker -x :actionRuntimes:python2Action:distDocker -x :tests:dat:blackbox:badaction:distDocker -x :tests:dat:blackbox:badproxy:distDocker" diff --git a/tools/travis/setup.sh b/tools/travis/setup.sh index 1358ef1..27d7b10 100755 --- a/tools/travis/setup.sh +++ b/tools/travis/setup.sh @@ -17,7 +17,7 @@ # SCRIPTDIR=$(cd $(dirname "$0") && pwd) -HOMEDIR="$SCRIPTDIR/../../../" +HOMEDIR="$SCRIPTDIR/../../.." sudo gpasswd -a travis docker sudo -E bash -c 'echo '\''DOCKER_OPTS="-H tcp://0.0.0.0:4243 -H unix:///var/run/docker.sock --storage-driver=overlay --userns-remap=default"'\'' > /etc/default/docker' @@ -31,20 +31,15 @@ docker version echo "Docker Info:" docker info -# Python -pip install --user jsonschema -pip install --user couchdb - -# Ansible -pip install --user ansible==2.5.0 - # jshint support sudo apt-get -y install nodejs npm sudo npm install -g jshint -# clone OpenWhisk main repo. +# clone OpenWhisk utilities repo. in order to run scanCode cd $HOMEDIR -git clone --depth=1 https://github.com/apache/incubator-openwhisk.git openwhisk - -# clone the openwhisk utilities repo. git clone https://github.com/apache/incubator-openwhisk-utilities.git + +# clone main openwhisk repo. for testing purposes +git clone --depth=1 https://github.com/apache/incubator-openwhisk.git openwhisk +cd openwhisk +./tools/travis/setup.sh This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3613: Split test jobs in Travis
chetanmeh commented on issue #3613: Split test jobs in Travis URL: https://github.com/apache/incubator-openwhisk/pull/3613#issuecomment-387433061 Post splitting of `build.sh` time has come down to ~ 31 mins (current master is at 46 mins) https://user-images.githubusercontent.com/664531/39765094-e19f51f6-5295-11e8-8c63-6bf2aaebb110.png;> Build Scan * [Unit Tests][1] - 944 tests (11 mins) * [System Tests][2] - 298 tests (14 mins) [1]: https://scans.gradle.com/s/5jgt74h5xslbg/tests [2]: https://scans.gradle.com/s/drads72h73z76/tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3613: Split test jobs in Travis
chetanmeh commented on issue #3613: Split test jobs in Travis URL: https://github.com/apache/incubator-openwhisk/pull/3613#issuecomment-387433061 Post splitting of `build.sh` time has come down to ~ 31 mins https://user-images.githubusercontent.com/664531/39765094-e19f51f6-5295-11e8-8c63-6bf2aaebb110.png;> Build Scan * [Unit Tests][1] - 944 tests (11 mins) * [System Tests][2] - 298 tests (14 mins) [1]: https://scans.gradle.com/s/5jgt74h5xslbg/tests [2]: https://scans.gradle.com/s/drads72h73z76/tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3613: Split test jobs in Travis
chetanmeh commented on issue #3613: Split test jobs in Travis URL: https://github.com/apache/incubator-openwhisk/pull/3613#issuecomment-387433061 Post splitting of `build.sh` time has come down to ~ 31 mins https://user-images.githubusercontent.com/664531/39765094-e19f51f6-5295-11e8-8c63-6bf2aaebb110.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3625: Bump Ansible to 2.5.2
codecov-io commented on issue #3625: Bump Ansible to 2.5.2 URL: https://github.com/apache/incubator-openwhisk/pull/3625#issuecomment-387429533 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=h1) Report > Merging [#3625](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/375c180b7332b671c1878761fb1d891b59ba3478?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625/graphs/tree.svg?token=l0YmsiSAso=650=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3625 +/- ## = + Coverage 74.39% 74.4% +0.01% = Files 125 125 Lines59515951 Branches 384 384 = + Hits 44274428 +1 + Misses 15241523 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=footer). Last update [375c180...4a9373e](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3625: Bump Ansible to 2.5.2
codecov-io commented on issue #3625: Bump Ansible to 2.5.2 URL: https://github.com/apache/incubator-openwhisk/pull/3625#issuecomment-387429533 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=h1) Report > Merging [#3625](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/375c180b7332b671c1878761fb1d891b59ba3478?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625/graphs/tree.svg?width=650=pr=l0YmsiSAso=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3625 +/- ## = + Coverage 74.39% 74.4% +0.01% = Files 125 125 Lines59515951 Branches 384 384 = + Hits 44274428 +1 + Misses 15241523 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=footer). Last update [375c180...4a9373e](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3625: Bump Ansible to 2.5.2
codecov-io commented on issue #3625: Bump Ansible to 2.5.2 URL: https://github.com/apache/incubator-openwhisk/pull/3625#issuecomment-387429533 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=h1) Report > Merging [#3625](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/375c180b7332b671c1878761fb1d891b59ba3478?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625/graphs/tree.svg?token=l0YmsiSAso=650=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3625 +/- ## = + Coverage 74.39% 74.4% +0.01% = Files 125 125 Lines59515951 Branches 384 384 = + Hits 44274428 +1 + Misses 15241523 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=footer). Last update [375c180...4a9373e](https://codecov.io/gh/apache/incubator-openwhisk/pull/3625?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3624: Replace WALA Pair with clean new Pair.
rabbah commented on issue #3624: Replace WALA Pair with clean new Pair. URL: https://github.com/apache/incubator-openwhisk/pull/3624#issuecomment-387427873 This will need a PG. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3624: Replace WALA Pair with clean new Pair.
codecov-io commented on issue #3624: Replace WALA Pair with clean new Pair. URL: https://github.com/apache/incubator-openwhisk/pull/3624#issuecomment-387426839 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3624?src=pr=h1) Report > Merging [#3624](https://codecov.io/gh/apache/incubator-openwhisk/pull/3624?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/375c180b7332b671c1878761fb1d891b59ba3478?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3624/graphs/tree.svg?token=l0YmsiSAso=pr=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3624?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #3624 +/- ## == Coverage74.4% 74.4% == Files 125 125 Lines59515951 Branches 384 384 == Hits 44284428 Misses 15231523 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3624?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3624?src=pr=footer). Last update [375c180...49d67db](https://codecov.io/gh/apache/incubator-openwhisk/pull/3624?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services