[GitHub] csantanapr commented on issue #3696: Move the files under performance to tests/performance
csantanapr commented on issue #3696: Move the files under performance to tests/performance URL: https://github.com/apache/incubator-openwhisk/pull/3696#issuecomment-391484203 PG PG1 2945 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #803: Report - Parameters in JSON form
mrutkows closed issue #803: Report - Parameters in JSON form URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/803 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #924: binary releases for a platform include binaries for all other platforms
rabbah commented on issue #924: binary releases for a platform include binaries for all other platforms URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/924#issuecomment-391502867 https://user-images.githubusercontent.com/4959922/40452180-f50f1f6c-5eae-11e8-8cce-9c5c61f36919.png;> checked another and it's also bloated with other binaries --- is this intentional? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser closed pull request #304: Run unit and native tests separately
mdeuser closed pull request #304: Run unit and native tests separately URL: https://github.com/apache/incubator-openwhisk-cli/pull/304 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/travis/test_openwhisk.sh b/tools/travis/test_openwhisk.sh index 095295b7..9bad3d0d 100755 --- a/tools/travis/test_openwhisk.sh +++ b/tools/travis/test_openwhisk.sh @@ -73,7 +73,8 @@ cd $TRAVIS_BUILD_DIR # # Run Unit and native tests # -./gradlew --console=plain --info goTest -PgoTags=unit,native +./gradlew --console=plain --info goTest -PgoTags=unit +./gradlew --console=plain --info goTest -PgoTags=native # # Set up the OpenWhisk environment for integration testing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new pull request #3697: Add equals method to ensure that ByteSize instances satisfy Comparable contract
rabbah opened a new pull request #3697: Add equals method to ensure that ByteSize instances satisfy Comparable contract URL: https://github.com/apache/incubator-openwhisk/pull/3697 The ByteSize method did not satisfy this requirement for Comparables: ``` * It is strongly recommended, but not strictly required that * (x.compareTo(y)==0) == (x.equals(y)). Generally speaking, any * class that implements the Comparable interface and violates * this condition should clearly indicate this fact. The recommended * language is "Note: this class has a natural ordering that is * inconsistent with equals." ``` This wasn't caught by the tests because they weren't actually asserting the invariants - `equals` vs `should be` or some equivalent variant. Adjusted tests and added equals method. ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [x] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [x] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [x] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [x] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3669: Make stemcells configurable by deployment
codecov-io commented on issue #3669: Make stemcells configurable by deployment URL: https://github.com/apache/incubator-openwhisk/pull/3669#issuecomment-389936897 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=h1) Report > Merging [#3669](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/0b302c1f5b81bafc070b86b7dc2d0cb3cddb397c?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `81.25%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3669 +/- ## == + Coverage74.5% 74.54% +0.03% == Files 126 126 Lines5994 6003 +9 Branches 392 388 -4 == + Hits 4466 4475 +9 Misses 1528 1528 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `85.88% <100%> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `96.38% <100%> (+0.28%)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=) | `96% <75%> (-1.83%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=footer). Last update [0b302c1...313dc79](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3697: Add equals method to ensure that ByteSize instances satisfy Comparable contract
codecov-io commented on issue #3697: Add equals method to ensure that ByteSize instances satisfy Comparable contract URL: https://github.com/apache/incubator-openwhisk/pull/3697#issuecomment-391501095 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=h1) Report > Merging [#3697](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `83.33%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3697 +/- ## == + Coverage 74.49% 74.51% +0.02% == Files 126 126 Lines5994 6000 +6 Branches 392 393 +1 == + Hits 4465 4471 +6 Misses 1529 1529 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=) | `96.15% <83.33%> (-1.68%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=footer). Last update [8a3b447...ea31810](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE
rabbah commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/809#issuecomment-391506667 suggested workaround is using `--config` flag. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3694: Add retries to CLI test framework for network errors
codecov-io commented on issue #3694: Add retries to CLI test framework for network errors URL: https://github.com/apache/incubator-openwhisk/pull/3694#issuecomment-391475522 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=h1) Report > Merging [#3694](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3694 +/- ## = + Coverage 74.49% 74.5% +0.01% = Files 126 126 Lines59945994 Branches 392 392 = + Hits 44654466 +1 + Misses 15291528 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=footer). Last update [8a3b447...ee2559e](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #898: wskdeploy export doesn't support multiple packages in a single project
pritidesai commented on issue #898: wskdeploy export doesn't support multiple packages in a single project URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/898#issuecomment-391496807 again, @kpavel has fixed it, let me know if you run into any issues. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #924: binary releases for a platform include binaries for all other platforms
rabbah commented on issue #924: binary releases for a platform include binaries for all other platforms URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/924#issuecomment-391503205 worse, the binary is the wrong format: ``` file wskdeploy wskdeploy: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, with debug_info, not stripped ``` considering this a bug. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3694: Add retries to CLI test framework for network errors
codecov-io commented on issue #3694: Add retries to CLI test framework for network errors URL: https://github.com/apache/incubator-openwhisk/pull/3694#issuecomment-391475522 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=h1) Report > Merging [#3694](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3694 +/- ## = + Coverage 74.49% 74.5% +0.01% = Files 126 126 Lines59945994 Branches 392 392 = + Hits 44654466 +1 + Misses 15291528 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=footer). Last update [8a3b447...ee2559e](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #91: Fix invalid warning message
mdeuser commented on issue #91: Fix invalid warning message URL: https://github.com/apache/incubator-openwhisk-client-go/pull/91#issuecomment-391493877 @dubee - is there a pg for this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #925: better error messages
rabbah opened a new issue #925: better error messages URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/925 run `wskdeploy` with no manifest file and you get this ``` Error: root.go [140]: [ERROR_MANIFEST_FILE_NOT_FOUND]: File: [openwhisk_wskdeploy-latest-mac-386]: Manifest file not found at path [/Users/rabbah/Downloads/openwhisk_wskdeploy-latest-mac-386]. ``` I was expecting a "usage" method/help. In any case, I suggest a better error message. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #161: Verify we do not include any tooling dot `.` configuration files in source release
mrutkows opened a new issue #161: Verify we do not include any tooling dot `.` configuration files in source release URL: https://github.com/apache/incubator-openwhisk-release/issues/161 Please make sure we do not include the following files which are for config. tooling: ``` .bin .dockerignore .git .gitattributes .github .gitignore .jshintrc .pydevproject .rat-excludes ``` or similar files prefixed with a dor `.` character. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #3696: Move the files under performance to tests/performance
houshengbo opened a new pull request #3696: Move the files under performance to tests/performance URL: https://github.com/apache/incubator-openwhisk/pull/3696 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3695: Use method links and correct method name.
codecov-io commented on issue #3695: Use method links and correct method name. URL: https://github.com/apache/incubator-openwhisk/pull/3695#issuecomment-391476286 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3695?src=pr=h1) Report > Merging [#3695](https://codecov.io/gh/apache/incubator-openwhisk/pull/3695?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3695?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3695 +/- ## = + Coverage 74.49% 74.5% +0.01% = Files 126 126 Lines59945994 Branches 392 392 = + Hits 44654466 +1 + Misses 15291528 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3695?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3695/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `32.54% <ø> (ø)` | :arrow_up: | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3695/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3695?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3695?src=pr=footer). Last update [8a3b447...2998ab7](https://codecov.io/gh/apache/incubator-openwhisk/pull/3695?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #152: Lightbend copyright appears, no LICENSE attribution
houshengbo commented on issue #152: Lightbend copyright appears, no LICENSE attribution URL: https://github.com/apache/incubator-openwhisk-release/issues/152#issuecomment-391495974 @markusthoemmes Could you change the implementation of this file? Change it or remove it. If not, we need to add the license and notice for this file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on a change in pull request #91: Fix invalid warning message
mdeuser commented on a change in pull request #91: Fix invalid warning message
URL:
https://github.com/apache/incubator-openwhisk-client-go/pull/91#discussion_r190398547
##
File path: whisk/client.go
##
@@ -652,10 +652,16 @@ func IsHttpRespSuccess(r *http.Response) bool {
func IsResponseResultSuccess(data []byte) bool {
errResp := new(WhiskErrorResponse)
err := json.Unmarshal(data, )
- if err == nil && errResp.Response != nil {
+
+ if err != nil {
+ Debug(DbgWarn, "IsResponseResultSuccess: failed to parse
response result: %v\n", err)
+ return false
+ }
+
+ if errResp.Response != nil {
return errResp.Response.Success
}
- Debug(DbgWarn, "IsResponseResultSuccess: failed to parse response
result: %v\n", err)
+
Review comment:
let's see... the affected method is only looking for a whisk response
(i.e. correct unmarshalled json with a "result" object).. the warning message
is provided when that condition is not met. so maybe at this spot the message
should be
```Debug(DbgWarn, "IsResponseResultSuccess: http response did not contain a
'response' field; assuming successful response\n")``` ???
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai commented on issue #899: wskdeploy export fails to export the `main` attribute for Java actions
pritidesai commented on issue #899: wskdeploy export fails to export the `main` attribute for Java actions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/899#issuecomment-391496171 Hi @brunogirin I have verified that @kpavel's changes has fixed this issue, the main function is now initialized in exported manifest: ``` actions: helloJava: name: helloJava location: "" version: 0.0.1 function: IntegrationTestExportHelloWorld/helloJava.jar code: "" runtime: java namespace: _/IntegrationTestExportHelloWorld credential: "" exposedUrl: "" web-export: "" web: "" main: Hello ``` Please verify ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #924: binary releases for a platform include binaries for all other platforms
rabbah opened a new issue #924: binary releases for a platform include binaries for all other platforms URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/924 ``` > unzip openwhisk_wskdeploy-latest-mac-amd64.zip > ls openwhisk_wskdeploy-latest-mac-amd64 LICENSE.txt docs wskdeploy-0.9.3.1-linux-amd64.tgz wskdeploy-0.9.3.1-windows-386.zip NOTICE.txt wskdeploy wskdeploy-0.9.3.1-mac-386.zip wskdeploy-0.9.3.1-windows-amd64.zip README.md wskdeploy-0.9.3.1-linux-386.tgz wskdeploy-0.9.3.1-mac-amd64.zip This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE
rabbah commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/809#issuecomment-391505734 bump - this is really a show stopper trying to deploy to multiple configurations. Is there a suggested workaround that doesn't muck around with my `.wksprops` file? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed pull request #923: Enable API Gateway integration test in Travis
mrutkows closed pull request #923: Enable API Gateway integration test in Travis
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/923
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/integration/apigateway/apigateway_test.go
b/tests/src/integration/apigateway/apigateway_test.go
index a75a033e..6bc33558 100644
--- a/tests/src/integration/apigateway/apigateway_test.go
+++ b/tests/src/integration/apigateway/apigateway_test.go
@@ -1,4 +1,4 @@
-// +build skip_integration
+// +build integration
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
diff --git a/tests/src/integration/apigateway/manifest.yml
b/tests/src/integration/apigateway/manifest.yml
index defdff8f..888ab869 100644
--- a/tests/src/integration/apigateway/manifest.yml
+++ b/tests/src/integration/apigateway/manifest.yml
@@ -39,4 +39,5 @@ packages:
deleteBooks: DELETE
members:
listMembers: GET
+allMembers:
listAllMembers: GET
diff --git a/tests/src/integration/export/export_test.go
b/tests/src/integration/export/export_test.go
index 63f8fceb..7e2a0bc3 100644
--- a/tests/src/integration/export/export_test.go
+++ b/tests/src/integration/export/export_test.go
@@ -116,7 +116,7 @@ var (
targetManifestFolder = os.Getenv("GOPATH") +
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/tmp/"
targetManifestPath = targetManifestFolder + "manifest.yaml"
- manifestHelloWorldPath = os.Getenv("GOPATH") +
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/helloworld/manifest.yaml"
+ manifestHelloWorldPath = os.Getenv("GOPATH") +
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/manifest_helloworld.yaml"
targetManifestHelloWorldPath = targetManifestFolder + "manifest.yaml"
manifest2PackPath= os.Getenv("GOPATH") +
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/manifest_2pack.yaml"
target2PackManifestPath = targetManifestFolder +
"exported2packmanifest.yaml"
diff --git a/tests/src/integration/export/manifest_helloworld.yaml
b/tests/src/integration/export/manifest_helloworld.yaml
new file mode 100644
index ..32011cd4
--- /dev/null
+++ b/tests/src/integration/export/manifest_helloworld.yaml
@@ -0,0 +1,153 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
+packages:
+ IntegrationTestExportHelloWorld:
+ actions:
+# helloworld action in NodeJS
+helloNodejs:
+ function: ../helloworld/actions/hello.js
+ runtime: nodejs:6
+ inputs:
+name:
+ type: string
+ description: name of a person
+place:
+ type: string
+ description: location of a person
+ outputs:
+payload:
+ type: string
+ description: a simple greeting message, Hello World!
+helloNodejsWithCode:
+ code: |
+function main(params) {
+msg = "Hello, " + params.name + " from " + params.place;
+console.log(msg)
+return { payload: msg };
+}
+ runtime: nodejs:6
+ inputs:
+name:
+ type: string
+ description: name of a person
+place:
+ type: string
+ description: location of a person
+ outputs:
+payload:
+ type: string
+ description: a simple greeting message, Hello World!
+# helloworld action in Java
+helloJava:
+ function: ../helloworld/actions/hello.jar
+ main: Hello
+ runtime: java
+ inputs:
+name:
+ type: string
+ description: name of a person
+ outputs:
+payload:
+ type: string
+ description: a simple greeting message, Hello Bob!
+# Uncomment Java With Code once action creation is fixed.
+# this is failing with internal server application problem.
+#helloJavaWithCode:
+# code: |
+#import com.google.gson.JsonObject;
+#public class Hello {
+#private JsonObject response;
+#public static JsonObject main(JsonObject args) {
+#String name = "stranger";
+#if (args.has("name"))
+#name =
[GitHub] mrutkows closed issue #725: API Gateway - Enable integration test
mrutkows closed issue #725: API Gateway - Enable integration test URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/725 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE
rabbah commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/809#issuecomment-391505734 bump - this is really a show stopper trying to deploy to multiple configurations. Is there a suggested workaround that doesn't muck around with my `.wksprops` file? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE
rabbah commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/809#issuecomment-391506667 suggested workaround is using `-c` flag. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh opened a new pull request #3689: Extend env 3477
chetanmeh opened a new pull request #3689: Extend env 3477 URL: https://github.com/apache/incubator-openwhisk/pull/3689 Provides a way to extend the environment variable set for Controller and Invoker ## Description As mentioned in #3477 for some set of deployments like those using CosmosDB we need to add some extra environment variables like `CONFIG_whisk_spi_ArtifactStoreProvider`. To support that ansible playbook now supports add a set of environment variables conditionally. ### Usage To add extra environment variables user need to define them under `group_vars/all` for specific environment ```yaml cosmos: CONFIG_whisk_spi_ArtifactStoreProvider: whisk.core.database.cosmosdb.CosmosDBArtifactStoreProvider CONFIG_whisk_cosmosdb_endpoint : "https://.documents.azure.com:443/" CONFIG_whisk_cosmosdb_key : "some secret" CONFIG_whisk_cosmosdb_db : openwhisk ``` Here `cosmos` is the name of the environment variable set related to CosmosDB. To enable this set user needs to set an environment vairable ``` OPENWHISK_EXTRA_ENV_SETS=cosmos ``` Here `OPENWHISK_EXTRA_ENV_SETS` refers to a comma separated list of environment variable set which need to be added. If configured then all variables defined under `cosmos` key would be added to env of controller and invoker ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#3477) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [x] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] style95 closed pull request #3671: Activation id in header
style95 closed pull request #3671: Activation id in header
URL: https://github.com/apache/incubator-openwhisk/pull/3671
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/controller/src/main/scala/whisk/core/controller/Actions.scala
b/core/controller/src/main/scala/whisk/core/controller/Actions.scala
index 25be8fa4ee..17da20e358 100644
--- a/core/controller/src/main/scala/whisk/core/controller/Actions.scala
+++ b/core/controller/src/main/scala/whisk/core/controller/Actions.scala
@@ -28,7 +28,6 @@ import akka.http.scaladsl.model.StatusCodes._
import akka.http.scaladsl.server.RequestContext
import akka.http.scaladsl.server.RouteResult
import akka.http.scaladsl.marshallers.sprayjson.SprayJsonSupport._
-import
akka.http.scaladsl.marshallers.sprayjson.SprayJsonSupport.sprayJsonMarshaller
import akka.http.scaladsl.unmarshalling._
import spray.json._
import spray.json.DefaultJsonProtocol._
@@ -257,24 +256,31 @@ trait WhiskActionsApi extends WhiskCollectionAPI with
PostActionActivation with
onComplete(invokeAction(user, actionWithMergedParams, payload,
waitForResponse, cause = None)) {
case Success(Left(activationId)) =>
// non-blocking invoke or blocking invoke which got queued instead
-complete(Accepted, activationId.toJsObject)
+
+respondWithActivationIdHeader(activationId) {
+ // note that if header defined a content-type, it will be ignored
+ // since the type must be compatible with the data response
+ complete(Accepted, activationId.toJsObject)
+}
+
case Success(Right(activation)) =>
val response = if (result) activation.resultAsJson else
activation.toExtendedJson
-
-if (activation.response.isSuccess) {
- complete(OK, response)
-} else if (activation.response.isApplicationError) {
- // actions that result is ApplicationError status are considered a
'success'
- // and will have an 'error' property in the result - the HTTP status
is OK
- // and clients must check the response status if it exists
- // NOTE: response status will not exist in the JSON object if
?result == true
- // and instead clients must check if 'error' is in the JSON
- // PRESERVING OLD BEHAVIOR and will address defect in separate change
- complete(BadGateway, response)
-} else if (activation.response.isContainerError) {
- complete(BadGateway, response)
-} else {
- complete(InternalServerError, response)
+respondWithActivationIdHeader(activation) {
+ if (activation.response.isSuccess) {
+complete(OK, response)
+ } else if (activation.response.isApplicationError) {
+// actions that result is ApplicationError status are considered a
'success'
+// and will have an 'error' property in the result - the HTTP
status is OK
+// and clients must check the response status if it exists
+// NOTE: response status will not exist in the JSON object if
?result == true
+// and instead clients must check if 'error' is in the JSON
+// PRESERVING OLD BEHAVIOR and will address defect in separate
change
+complete(BadGateway, response)
+ } else if (activation.response.isContainerError) {
+complete(BadGateway, response)
+ } else {
+complete(InternalServerError, response)
+ }
}
case Failure(t: RecordTooLargeException) =>
logging.debug(this, s"[POST] action payload was too large")
diff --git
a/core/controller/src/main/scala/whisk/core/controller/Entities.scala
b/core/controller/src/main/scala/whisk/core/controller/Entities.scala
index cd9a72a08d..f9f0ccc3bc 100644
--- a/core/controller/src/main/scala/whisk/core/controller/Entities.scala
+++ b/core/controller/src/main/scala/whisk/core/controller/Entities.scala
@@ -20,9 +20,9 @@ package whisk.core.controller
import scala.concurrent.Future
import scala.language.postfixOps
import scala.util.Try
-
import akka.http.scaladsl.marshallers.sprayjson.SprayJsonSupport._
import akka.http.scaladsl.model.StatusCodes.RequestEntityTooLarge
+import akka.http.scaladsl.model.headers.RawHeader
import akka.http.scaladsl.server.Directive0
import akka.http.scaladsl.server.Directives
import akka.http.scaladsl.server.RequestContext
@@ -65,6 +65,16 @@ protected[controller] trait ValidateRequestSize extends
Directives {
protected val fieldDescriptionForSizeError = "Request"
}
+protected trait CustomHeaders extends Directives {
+
+ /** Add activation ID in headers */
+ protected def respondWithActivationIdHeader(activation: WhiskActivation):
Directive0 =
+
[GitHub] style95 opened a new pull request #3671: Activation id in header
style95 opened a new pull request #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671 This closes #3582 ## Description This change will add activation id in the response headers. Since same logic needs to be used in both collection API and web action API, I created dedicated trait for custom headers. ## Related issue and scope - [x] I opened an issue to propose and discuss this change (#3582) ## My changes affect the following components - [ ] API - [x] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [x] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [x] I added tests to cover my changes. - [x] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3689: Enable extending environment variables of Controller and Invoker
chetanmeh commented on a change in pull request #3689: Enable extending
environment variables of Controller and Invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3689#discussion_r190155278
##
File path: ansible/roles/controller/tasks/deploy.yml
##
@@ -236,6 +236,14 @@
"CONFIG_whisk_transactions_header": "{{ transactions.header }}"
+- name: merge extra env variables
+ set_fact:
+controller_env: "{{ controller_env | default({}) | combine(item) }}"
+ with_items: "{{ extraEnvSets.split(',') | map('trim') | map('extract',
vars)| list }}"
+ loop_control:
+label: redacted
Review comment:
Ansible would by default emit the item value to stdout. As the values may
contain secrets set the label to a constant
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3689: Enable extending environment variables of Controller and Invoker
codecov-io commented on issue #3689: Enable extending environment variables of Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3689#issuecomment-391266601 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=h1) Report > Merging [#3689](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3689 +/- ## = + Coverage 74.49% 74.5% +0.01% = Files 126 126 Lines59945994 Branches 392 392 = + Hits 44654466 +1 + Misses 15291528 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=footer). Last update [8a3b447...dd40675](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3562: ArtifactStore implementation for CosmosDB
chetanmeh commented on a change in pull request #3562: ArtifactStore
implementation for CosmosDB
URL:
https://github.com/apache/incubator-openwhisk/pull/3562#discussion_r190470634
##
File path:
common/scala/src/main/scala/whisk/core/database/cosmosdb/CosmosDBArtifactStoreProvider.scala
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database.cosmosdb
+
+import java.io.Closeable
+
+import akka.actor.ActorSystem
+import akka.stream.ActorMaterializer
+import com.microsoft.azure.cosmosdb.rx.AsyncDocumentClient
+import spray.json.RootJsonFormat
+import whisk.common.Logging
+import whisk.core.database._
+import pureconfig._
+import whisk.core.ConfigKeys
+import whisk.core.database.cosmosdb.CosmosDBUtil.createClient
+import whisk.core.entity.{DocumentReader, WhiskActivation, WhiskAuth,
WhiskEntity}
+
+import scala.reflect.ClassTag
+
+case class CosmosDBConfig(endpoint: String, key: String, db: String)
+
+case class ClientHolder(client: AsyncDocumentClient) extends Closeable {
+ override def close(): Unit = client.close()
+}
+
+object CosmosDBArtifactStoreProvider extends ArtifactStoreProvider {
+ type DocumentClientRef = ReferenceCounted[ClientHolder]#CountedReference
+ private lazy val config =
loadConfigOrThrow[CosmosDBConfig](ConfigKeys.cosmosdb)
+ private var clientRef: ReferenceCounted[ClientHolder] = _
Review comment:
I think post `close` no other operation is performed so it does not show up
any issue. All clients are closed in `affterAll` i.e. once all methods in suite
have run
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] augustin-taiwan opened a new pull request #128: Remove duplicated port setting
augustin-taiwan opened a new pull request #128: Remove duplicated port setting URL: https://github.com/apache/incubator-openwhisk-devtools/pull/128 Port 2888 is duplicated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on a change in pull request #3689: Enable extending environment variables of Controller and Invoker
chetanmeh commented on a change in pull request #3689: Enable extending
environment variables of Controller and Invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3689#discussion_r190466946
##
File path: ansible/environments/local/group_vars/all
##
@@ -2,6 +2,7 @@
# license agreements; and to You under the Apache License, Version 2.0.
whisk_version_name: local
+extraEnvSets: "{{ lookup('env', 'OPENWHISK_EXTRA_ENV_SETS')|default(false,
true) }}"
Review comment:
Makes sense. Update PR to support specific env for controller and invoker.
By default they both rely on `OPENWHISK_EXTRA_ENV`. However one can change the
setting in environment specific file.
Not sure on best practices for placing the vars in ansible ... for now I
have added them to `local/group_vars/all` such that one can use a different
setting in specific env
```
ansible/environments/custom/group_vars
controller:
extraEnv: "cosmos,splunk"
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh commented on issue #3523: KafkaConnectorTests heisenbug
chetanmeh commented on issue #3523: KafkaConnectorTests heisenbug URL: https://github.com/apache/incubator-openwhisk/issues/3523#issuecomment-391594542 Another failure seen at https://scans.gradle.com/s/6sfxa7kccvlji/tests/xaqugzlgs2zw6-6k6x5jmp5qe2c due to same reason as one above This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3562: ArtifactStore implementation for CosmosDB
chetanmeh commented on issue #3562: ArtifactStore implementation for CosmosDB URL: https://github.com/apache/incubator-openwhisk/pull/3562#issuecomment-391595062 @tysonnorris I agree current ref count based shutdown handling is not desirable and we should relook into how `ArtifactStore` are closed. May be we deal with this in a separate issue and use existing approach in this PR for now? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sechunOH commented on issue #3579: Using non root user in controller
sechunOH commented on issue #3579: Using non root user in controller URL: https://github.com/apache/incubator-openwhisk/pull/3579#issuecomment-391595004 @fmaschler not processes as root on the host, but as root in containers. It is for preventing privilege-escalation attacks from within a container. > https://docs.docker.com/engine/security/userns-remap/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed pull request #160: Clean up Openwhisk repo. ASF license header inclusion/exclusion tables
pritidesai closed pull request #160: Clean up Openwhisk repo. ASF license header inclusion/exclusion tables URL: https://github.com/apache/incubator-openwhisk-release/pull/160 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/license_compliance.md b/docs/license_compliance.md index 09f820a..a74d4df 100644 --- a/docs/license_compliance.md +++ b/docs/license_compliance.md @@ -48,8 +48,8 @@ In addition, the recommended type of approved ASF license header (i.e., "full" o | File type | ASF Header Type | Rationale | | :--- | :--- | :--- | | Source code (e.g., `*.scala`, `*.go`, `*.java`, `*.py`, etc.) | Full | Source code. | -| Action functions (source) (e.g., `.js`, `.py`, `.swift`, etc, particularly under `tests/dat` folder.) | Mini | Source codeUse "Mini" header as best practice for performance reasons. | -| Ansible Group vars. (`*/group_vars/all`) | Mini | Project convention. | +| Action functions (source) (e.g., `.js`, `.py`, `.swift`, etc, particularly under `tests/dat` folder.) | Mini | Source code.Use "Mini" header as best practice for performance reasons. | +| Ansible Group vars. (YAML) (`*/group_vars/all`) | Mini | Project convention. | | Docker image build file (`dockerfile`) | Mini | May contain functional (script) code. | | Documentation (e.g., `*.md`) | Full | Intellectual property. | | Gradle files (`build.gradle`, `*.gradle`) | Full | May contain functional scripts and code (e.g., Groovy, Kotlin).Includes build (`build.gradle`) and settings (`settings.gradle`)files. | @@ -75,20 +75,22 @@ In accordance with Apache LICENSE policies, the table below lists general exclus | TAG | File type | Rationale | |:---|:---|:---| -| ANS.1 | Ansible (host) Inventory Files (`*.ini`) | Configuration files. Not much creativity.Example: [incubator-openwhisk/ansible/environments/local/hosts.j2.ini](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/local/hosts.j2.ini) | -| ANS.2| Ansible Configuration Files (`*.cfg`) | Configuration files. Not much creativity.Example: [incubator-openwhisk/ansible/ansible.cfg](https://github.com/apache/incubator-openwhisk/blob/master/ansible/ansible.cfg) | -| ANS.3 | Ansible Group Variable (YAML) files (`group_vars/all`) | Configuration files. Not much creativity.Example [ansible/environments/local/group_vars/all](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/local/group_vars/all) | -| ANS.4 | Ansible hosts files (`hosts`) | Configuration files. Not much creativity.Example: [incubator-openwhisk/ansible/environments/distributed/hosts](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/distributed/hosts) | -| ANS.5 | Ansible environment files (`*.env`) | Configuration files. Not much creativity.Example: [ansible/environments/distributed/files/openstack/openstack.env](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/distributed/files/openstack/openstack.env) | -| DATA.1 | Empty (zero-length) test files | Empty test data file.Example: [incubator-openwhisk/tests/dat/actions/empty.js](https://github.com/apache/incubator-openwhisk/blob/master/tests/dat/actions/empty.js) | +| ANS.INI | Ansible (host) Inventory Files (`*.ini`) | Configuration files. Not much creativity.Example: [incubator-openwhisk/ansible/environments/local/hosts.j2.ini](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/local/hosts.j2.ini) | +| ANS.CFG| Ansible Configuration Files (`*.cfg`) | Configuration files. Not much creativity.Example: [incubator-openwhisk/ansible/ansible.cfg](https://github.com/apache/incubator-openwhisk/blob/master/ansible/ansible.cfg) | +| ANS.HOSTS | Ansible hosts files (`hosts`) | Configuration files. Not much creativity.Example: [incubator-openwhisk/ansible/environments/distributed/hosts](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/distributed/hosts) | +| ANS.ENV | Ansible environment files (`*.env`) | Configuration files. Not much creativity.Example: [ansible/environments/distributed/files/openstack/openstack.env](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/distributed/files/openstack/openstack.env) | +| DATA.TEST | Empty (zero-length) test files | Empty test data file.Example: [incubator-openwhisk/tests/dat/actions/empty.js](https://github.com/apache/incubator-openwhisk/blob/master/tests/dat/actions/empty.js) | +| DATA.AUTH | API Auth. key | Configuration data.Example: [ansible/files/auth.guest](https://github.com/apache/incubator-openwhisk/blob/master/ansible/files/auth.guest) | | GIT.1 | Git configuration (`.gitattributes`, `.gitignore`) | Configuration file. Not much creativity.
[GitHub] rabbah opened a new issue #929: if manifest read fails, wskdeploy should fail
rabbah opened a new issue #929: if manifest read fails, wskdeploy should fail URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/929 wskdeploy fetches the runtime manifest from hardcoded values here should it fail reading from the API host. https://github.com/apache/incubator-openwhisk-wskdeploy/blob/b9fd4d317888319ddd3fea3ad8458b2b661ec407/utils/runtimes.go#L229 this is startling - instead `wskdeploy` should fail --- the hardcoded values could be very different from the deployment wrt action default, supported actions, etc... isn't this dangerous?! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3502: Immutable attachments via putAndAttach
chetanmeh commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-391295950 Can this PR be reviewed and approved? As this is required for some other PRs #3453, Attachment In lining and S3AttachmentStore (branch exist but PR pending) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #2282: Distributed tracing support #2192
codecov-io commented on issue #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#issuecomment-391308983 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=h1) Report > Merging [#2282](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **decrease** coverage by `0.49%`. > The diff coverage is `30.3%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=tree) ```diff @@Coverage Diff@@ ## master#2282 +/- ## = - Coverage 74.49% 73.99% -0.5% = Files 126 127 +1 Lines5994 6053 +59 Branches 392 406 +14 = + Hits 4465 4479 +14 - Misses 1529 1574 +45 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0% <0%> (ø)` | :arrow_up: | | [...er/src/main/scala/whisk/core/invoker/Invoker.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyLnNjYWxh) | `0% <0%> (ø)` | :arrow_up: | | [.../main/scala/whisk/core/controller/Controller.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9Db250cm9sbGVyLnNjYWxh) | `0% <0%> (ø)` | :arrow_up: | | [.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `92.3% <100%> (+0.05%)` | :arrow_up: | | [.../src/main/scala/whisk/core/connector/Message.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `25.49% <100%> (ø)` | :arrow_up: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `87.12% <100%> (+0.09%)` | :arrow_up: | | [...la/src/main/scala/whisk/common/TransactionId.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9UcmFuc2FjdGlvbklkLnNjYWxh) | `93.33% <100%> (+0.35%)` | :arrow_up: | | [...ala/whisk/common/tracing/OpenTracingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi90cmFjaW5nL09wZW5UcmFjaW5nUHJvdmlkZXIuc2NhbGE=) | `15.68% <15.68%> (ø)` | | | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=footer). Last update [8a3b447...b491ef6](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] allustin commented on issue #126: Docker-Compose: Migrate to dockerize instead of curl
allustin commented on issue #126: Docker-Compose: Migrate to dockerize instead of curl URL: https://github.com/apache/incubator-openwhisk-devtools/issues/126#issuecomment-391334866 this is a loop wtihout timeout, for example https://github.com/apache/incubator-openwhisk-devtools/blob/master/docker-compose/Makefile#L68 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] duglin opened a new issue #3690: Change current working dir to location of exec
duglin opened a new issue #3690: Change current working dir to location of exec URL: https://github.com/apache/incubator-openwhisk/issues/3690 I have a function that I deploy via a Docker container (ie. I do: `wsk action update mydemo exec.zip --native`). Inside of that zip I have some files that my function needs to access at runtime. Those files appear at the root of the location of where the zip file is extracted/expanded. However, when the function's code (`exec`) is run, the current working dir is someplace else in the filesystem. In order for my app to locate its needed files I need to get the program's `args[0]` and strip off the `/exec` at the end to find where I should look for the files. While obviously do-able, this isn't the greatest UX. It would be nicer if the current working dir was the root of where the zip file was expanded. Then the function author doesn't need to jump through hoops to find the data from their zip file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fmaschler commented on issue #3579: Using non root user in controller
fmaschler commented on issue #3579: Using non root user in controller URL: https://github.com/apache/incubator-openwhisk/pull/3579#issuecomment-391314107 I'm not an expert in namespaces but I see what you mean. Though those container processes run as root on the host. Even if they may not have the same privilege inside the container this should be changed if there is no reason about it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] allustin opened a new issue #126: Docker-Compose: Migrate to dockerize instead of curl
allustin opened a new issue #126: Docker-Compose: Migrate to dockerize instead of curl URL: https://github.com/apache/incubator-openwhisk-devtools/issues/126 in current makefile there is curl --silent with un-ended loop. please migrate to https://github.com/jwilder/dockerize - it has function `dockerize -wait ` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new pull request #926: Overwriting Deployment file inputs
pritidesai opened a new pull request #926: Overwriting Deployment file inputs URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/926 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #930: wskdeploy should fail if host info does not parse or cannot be retrieved,
rabbah opened a new issue #930: wskdeploy should fail if host info does not parse or cannot be retrieved, URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/930 This method should exist `wskdeploy` if there is an error - it should not proceed and surely not silently without even warning you of the error. https://github.com/apache/incubator-openwhisk-wskdeploy/blob/c3459f0c200eaea8e63b5bf7b6e75e852adb067d/cmd/root.go#L123-L128 which can happen if this line fails https://github.com/apache/incubator-openwhisk-wskdeploy/blob/b9fd4d317888319ddd3fea3ad8458b2b661ec407/utils/runtimes.go#L124 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #927: action deploy even when runtime is deprecated
rabbah opened a new issue #927: action deploy even when runtime is deprecated
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/927
I can reproduce by deploying openwhisk with the following manifest:
```
> cat ansible/files/runtimes.json
{
"runtimes": {
"nodejs": [
{
"kind": "nodejs",
"image": {
"name": "nodejs6action"
},
"deprecated": true
},
{
"kind": "nodejs:6",
"default": true,
"image": {
"name": "nodejs6action"
},
"deprecated": false
}
]
},
"blackboxes": [
{
"name": "dockerskeleton"
}
]
}
```
and the following wskdeploy manifest
```
packages:
p:
actions:
hello:
function: hello.js
runtime: nodejs
```
this is the output from `wskdeploy`:
```
Info: The API host is [https://localhost], from .wskprops.
Info: The auth key is set, from .wskprops.
Info: The namespace is [_], from .wskprops.
Info: Unmarshal OpenWhisk runtimes from local values.
Warning: The mandatory key [package version] should be set. Using default
value [0.0.1]...
Warning: The value for key [package version] is not saved in the current
version of wskdeploy.
Warning: The mandatory key [package license] should be set. Using default
value [unlicensed]...
Warning: The value for key [package version] is not saved in the current
version of wskdeploy.
Warning: Invalid or missing runtime [nodejs] specified in manifest for the
action [hello].
Warning: Runtime changed to [nodejs:6] based on the action's source file
extension for action [hello].
Info: Deploying package [p] ...
Info: package [p] has been successfully deployed.
Info: Deploying action [p/hello] ...
Info: action [p/hello] has been successfully deployed.
Success: Deployment completed successfully.
```
Note the `Warning: Invalid or missing runtime [nodejs] specified in manifest
for the action [hello].` is correct but I think the action should not
automatically deploy without an override from the user as there may be
incompatible or breaking changes relative to the source code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #3696: Move the files under performance to tests/performance
csantanapr commented on issue #3696: Move the files under performance to tests/performance URL: https://github.com/apache/incubator-openwhisk/pull/3696#issuecomment-391551311 @houshengbo Travis is failing to deploy.sh You need the relative directory here https://github.com/apache/incubator-openwhisk/blob/master/performance/preparation/deploy.sh#L20 From ``` ROOTDIR="$SCRIPTDIR/../.." ``` To ``` ROOTDIR="$SCRIPTDIR/../../.." ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3696: Move the files under performance to tests/performance
csantanapr commented on issue #3696: Move the files under performance to tests/performance URL: https://github.com/apache/incubator-openwhisk/pull/3696#issuecomment-391551311 @houshengbo You need the relative directory here https://github.com/apache/incubator-openwhisk/blob/master/performance/preparation/deploy.sh#L20 From ``` ROOTDIR="$SCRIPTDIR/../.." ``` To ``` ROOTDIR="$SCRIPTDIR/../../.." ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #926: Overwriting Deployment file inputs
houshengbo closed pull request #926: Overwriting Deployment file inputs
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/926
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/deployers/deploymentreader.go b/deployers/deploymentreader.go
index 19579f6f..0c02e400 100644
--- a/deployers/deploymentreader.go
+++ b/deployers/deploymentreader.go
@@ -177,6 +177,8 @@ func (reader *DeploymentReader)
bindPackageInputsAndAnnotations(paramsCLI interf
}
packageInputs = append(packageInputs,
kv)
}
+ } else {
+ packageInputs = keyValArr
}
serviceDeployPack.Package.Parameters = packageInputs
@@ -245,6 +247,8 @@ func (reader *DeploymentReader)
bindActionInputsAndAnnotations(paramsCLI interfa
}
actionInputs =
append(actionInputs, kv)
}
+ } else {
+ actionInputs = keyValArr
}
wskAction.Action.Parameters =
actionInputs
@@ -267,9 +271,9 @@ func (reader *DeploymentReader)
bindActionInputsAndAnnotations(paramsCLI interfa
}
}
wskAction.Action.Annotations = keyValArr
+ } else {
+
displayEntityNotFoundInDeploymentWarning(parsers.YAML_KEY_ACTION, actionName)
}
- } else {
-
displayEntityNotFoundInDeploymentWarning(parsers.YAML_KEY_ACTION, actionName)
}
}
}
@@ -321,6 +325,8 @@ func (reader *DeploymentReader)
bindTriggerInputsAndAnnotations(paramsCLI interf
}
triggerInputs =
append(triggerInputs, kv)
}
+ } else {
+ triggerInputs = keyValArr
}
wskTrigger.Parameters = triggerInputs
@@ -343,9 +349,9 @@ func (reader *DeploymentReader)
bindTriggerInputsAndAnnotations(paramsCLI interf
}
}
wskTrigger.Annotations = keyValArr
+ } else {
+
displayEntityNotFoundInDeploymentWarning(parsers.YAML_KEY_TRIGGER, triggerName)
}
- } else {
-
displayEntityNotFoundInDeploymentWarning(parsers.YAML_KEY_TRIGGER, triggerName)
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] augustin-taiwan opened a new issue #127: there are two 2888. it is duplicated.
augustin-taiwan opened a new issue #127: there are two 2888. it is duplicated. URL: https://github.com/apache/incubator-openwhisk-devtools/issues/127 https://github.com/apache/incubator-openwhisk-devtools/blob/3227c032a0cee9a52c13ae5f8257f7d9a4b1485c/docker-compose/Makefile#L134 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3696: Move the files under performance to tests/performance
codecov-io commented on issue #3696: Move the files under performance to tests/performance URL: https://github.com/apache/incubator-openwhisk/pull/3696#issuecomment-391564547 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3696?src=pr=h1) Report > Merging [#3696](https://codecov.io/gh/apache/incubator-openwhisk/pull/3696?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3696?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #3696 +/- ## == Coverage74.5% 74.5% == Files 126 126 Lines59945994 Branches 392 392 == Hits 44664466 Misses 15281528 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3696?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3696?src=pr=footer). Last update [8a3b447...6f5ec9b](https://codecov.io/gh/apache/incubator-openwhisk/pull/3696?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed pull request #921: Add ASF license header to .gradle files.
pritidesai closed pull request #921: Add ASF license header to .gradle files. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/921 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/ansible/environments/local/group_vars/all b/ansible/environments/local/group_vars/all index a5552d98..8b4ad10d 100755 --- a/ansible/environments/local/group_vars/all +++ b/ansible/environments/local/group_vars/all @@ -1,18 +1,5 @@ -# # Licensed to the Apache Software Foundation (ASF) under one or more contributor -# license agreements. See the NOTICE file distributed with this work for additional -# information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this -# file except in compliance with the License. You may obtain a copy of the License -# at: -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software distributed -# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR -# CONDITIONS OF ANY KIND, either express or implied. See the License for the -# specific language governing permissions and limitations under the License. -# +# license agreements; and to You under the Apache License, Version 2.0. whisk_version_name: local config_root_dir: /tmp/wskconf diff --git a/gradle.properties b/gradle.properties index dd6667aa..63aca458 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1 +1,4 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements; and to You under the Apache License, Version 2.0. + systemProp.gogradle.alias=true diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index abeaf301..21e0e869 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,21 +1,18 @@ # -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at # -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. +# http://www.apache.org/licenses/LICENSE-2.0 # +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. # #Wed Mar 21 16:31:41 EDT 2018 diff --git a/tests/dat/wskpropsnokeycert b/tests/dat/wskpropsnokeycert index fc008094..0cdc9f79 100644 --- a/tests/dat/wskpropsnokeycert +++ b/tests/dat/wskpropsnokeycert @@ -1,17 +1,18 @@ # -# Licensed to the Apache Software Foundation (ASF) under one or more contributor -# license agreements. See the NOTICE file distributed with this work for additional -# information regarding copyright ownership. The ASF licenses this file to you -# under the Apache License, Version 2.0 (the # "License"); you may not use this -# file except in compliance with the License. You may obtain a copy of the License -# at: +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at # -# http://www.apache.org/licenses/LICENSE-2.0 +# http://www.apache.org/licenses/LICENSE-2.0 # -# Unless required by applicable law or agreed
[GitHub] rabbah opened a new issue #928: hardcoded protocol does not allow for http to be used
rabbah opened a new issue #928: hardcoded protocol does not allow for http to be used URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/928 this line hardcodes `https` as the protocol. https://github.com/apache/incubator-openwhisk-wskdeploy/blob/b9fd4d317888319ddd3fea3ad8458b2b661ec407/utils/runtimes.go#L85 if the api host already includes a protocol, wskdeploy fetches the runtime manifest from hardcoded values here: https://github.com/apache/incubator-openwhisk-wskdeploy/blob/b9fd4d317888319ddd3fea3ad8458b2b661ec407/utils/runtimes.go#L229 this is startling - instead `wskdeploy` should fail --- the hardcoded values could be very different from the deployment wrt action default, supported actions, etc... isn't this dangerous?! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #925: better error messages
rabbah commented on issue #925: better error messages URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/925#issuecomment-391536541 many error messages could be reported better fwiw. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #931: schema encoding of the runtime manifest schema uses uint16
rabbah opened a new issue #931: schema encoding of the runtime manifest schema uses uint16 URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/931 https://github.com/apache/incubator-openwhisk-wskdeploy/blob/b9fd4d317888319ddd3fea3ad8458b2b661ec407/utils/runtimes.go#L48-L52 uint16!? this is too low. fwiw as I've noted for the CLI and go SDK - the encoding of these types as structs in mostly unnecessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] augustin-taiwan commented on a change in pull request #120: removed port check for ports 80 and 443
augustin-taiwan commented on a change in pull request #120: removed port check for ports 80 and 443 URL: https://github.com/apache/incubator-openwhisk-devtools/pull/120#discussion_r190450107 ## File path: docker-compose/Makefile ## @@ -131,7 +131,7 @@ print-host: .PHONY: check-required-ports check-required-ports: echo "checking required ports ... " - for port in 80 443 2888 5984 8085 9092 2888 8001; do \ + for port in 2888 5984 8085 9092 2888 8001; do \ Review comment: there are two 2888 port checking This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3635: Recommendations for configuration of pre-warmed pool
rabbah commented on issue #3635: Recommendations for configuration of pre-warmed pool URL: https://github.com/apache/incubator-openwhisk/issues/3635#issuecomment-391295292 This pr https://github.com/apache/incubator-openwhisk/pull/3669 will allow you to set stem cells for any runtime. The count really depends on your expected load and mix of runtimes. For example do you have 90% node actions vs 50% node and 50% python? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3691: README: Available typo
rabbah commented on issue #3691: README: Available typo URL: https://github.com/apache/incubator-openwhisk/pull/3691#issuecomment-391355597 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #23: Last files to need ASF License headers.
houshengbo closed pull request #23: Last files to need ASF License headers.
URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/23
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/environments/local/group_vars/all
b/ansible/environments/local/group_vars/all
index a334a66..bccaacf 100755
--- a/ansible/environments/local/group_vars/all
+++ b/ansible/environments/local/group_vars/all
@@ -1,3 +1,6 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
whisk_version_name: local
openwhisk_tmp_dir: "{{ lookup('env', 'OPENWHISK_TMP_DIR')|default('/tmp',
true) }}"
config_root_dir: "{{ openwhisk_tmp_dir }}/wskconf"
diff --git a/build.gradle b/build.gradle
index 300a1ce..4ebd4b8 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
buildscript {
repositories {
jcenter()
diff --git a/core/php7.1Action/build.gradle b/core/php7.1Action/build.gradle
index 1e4c161..a6e9292 100644
--- a/core/php7.1Action/build.gradle
+++ b/core/php7.1Action/build.gradle
@@ -1,2 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
ext.dockerImageName = 'action-php-v7.1'
apply from: '../../gradle/docker.gradle'
diff --git a/gradle/docker.gradle b/gradle/docker.gradle
index f716c7b..6ad6850 100644
--- a/gradle/docker.gradle
+++ b/gradle/docker.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
import groovy.time.*
/**
diff --git a/gradle/wrapper/gradle-wrapper.properties
b/gradle/wrapper/gradle-wrapper.properties
index f16d266..d7cc33f 100644
--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -1,3 +1,6 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
diff --git a/settings.gradle b/settings.gradle
index df2bd3b..6cb69be 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the
[GitHub] rabbah commented on issue #3691: README: Available typo
rabbah commented on issue #3691: README: Available typo URL: https://github.com/apache/incubator-openwhisk/pull/3691#issuecomment-391355597 Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #39: Last files to need ASF License headers.
houshengbo closed pull request #39: Last files to need ASF License headers.
URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/39
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/environments/local/group_vars/all
b/ansible/environments/local/group_vars/all
index 9979c20..753e4d7 100755
--- a/ansible/environments/local/group_vars/all
+++ b/ansible/environments/local/group_vars/all
@@ -1,3 +1,6 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
whisk_version_name: local
config_root_dir: /tmp/wskconf
whisk_logs_dir: /tmp/wsklogs
@@ -44,4 +47,4 @@ runtimes_manifest:
name: "nodejs6action"
deprecated: false
blackboxes:
-- name: "dockerskeleton"
\ No newline at end of file
+- name: "dockerskeleton"
diff --git a/build.gradle b/build.gradle
index 300a1ce..4ebd4b8 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
buildscript {
repositories {
jcenter()
diff --git a/core/actionProxy/build.gradle b/core/actionProxy/build.gradle
index 0fe825e..80b022a 100644
--- a/core/actionProxy/build.gradle
+++ b/core/actionProxy/build.gradle
@@ -1,2 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
ext.dockerImageName = 'dockerskeleton'
apply from: '../../gradle/docker.gradle'
diff --git a/gradle/docker.gradle b/gradle/docker.gradle
index f716c7b..6ad6850 100644
--- a/gradle/docker.gradle
+++ b/gradle/docker.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
import groovy.time.*
/**
diff --git a/gradle/wrapper/gradle-wrapper.properties
b/gradle/wrapper/gradle-wrapper.properties
index f16d266..d7cc33f 100644
--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -1,3 +1,6 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
diff --git a/sdk/docker/build.gradle b/sdk/docker/build.gradle
index a8cc3d7..befc316 100644
--- a/sdk/docker/build.gradle
+++ b/sdk/docker/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the
[GitHub] houshengbo closed pull request #54: Last files to need ASF License headers.
houshengbo closed pull request #54: Last files to need ASF License headers.
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/54
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/environments/local/group_vars/all
b/ansible/environments/local/group_vars/all
index 7bcd941..091cb4b 100755
--- a/ansible/environments/local/group_vars/all
+++ b/ansible/environments/local/group_vars/all
@@ -1,3 +1,6 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
whisk_version_name: local
openwhisk_tmp_dir: "{{ lookup('env', 'OPENWHISK_TMP_DIR')|default('/tmp',
true) }}"
config_root_dir: "{{ openwhisk_tmp_dir }}/wskconf"
diff --git a/build.gradle b/build.gradle
index 300a1ce..4ebd4b8 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
buildscript {
repositories {
jcenter()
diff --git a/core/nodejs6Action/build.gradle b/core/nodejs6Action/build.gradle
index b271f5e..1f1e22c 100644
--- a/core/nodejs6Action/build.gradle
+++ b/core/nodejs6Action/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
apply plugin: 'eclipse'
eclipse {
project {
diff --git a/core/nodejs8Action/build.gradle b/core/nodejs8Action/build.gradle
index b4dd28a..b37befe 100644
--- a/core/nodejs8Action/build.gradle
+++ b/core/nodejs8Action/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
apply plugin: 'eclipse'
eclipse {
project {
diff --git a/core/nodejsActionBase/build.gradle
b/core/nodejsActionBase/build.gradle
index f6ae7ee..3a9873e 100644
--- a/core/nodejsActionBase/build.gradle
+++ b/core/nodejsActionBase/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT
[GitHub] houshengbo closed pull request #54: Last files to need ASF License headers.
houshengbo closed pull request #54: Last files to need ASF License headers.
URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/54
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/environments/local/group_vars/all
b/ansible/environments/local/group_vars/all
index ce84e87..306a849 100755
--- a/ansible/environments/local/group_vars/all
+++ b/ansible/environments/local/group_vars/all
@@ -1,3 +1,6 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
whisk_version_name: local
openwhisk_tmp_dir: "{{ lookup('env', 'OPENWHISK_TMP_DIR')|default('/tmp',
true) }}"
config_root_dir: "{{ openwhisk_tmp_dir }}/wskconf"
diff --git a/build.gradle b/build.gradle
index 300a1ce..4ebd4b8 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
buildscript {
repositories {
jcenter()
diff --git a/gradle/docker.gradle b/gradle/docker.gradle
index f716c7b..6ad6850 100644
--- a/gradle/docker.gradle
+++ b/gradle/docker.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
import groovy.time.*
/**
diff --git a/gradle/wrapper/gradle-wrapper.properties
b/gradle/wrapper/gradle-wrapper.properties
index bf3de21..15c07a0 100644
--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -1,3 +1,6 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-bin.zip
diff --git a/java8/build.gradle b/java8/build.gradle
index 57276bc..3a4ae0f 100644
--- a/java8/build.gradle
+++ b/java8/build.gradle
@@ -1,2 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
ext.dockerImageName = 'java8action'
apply from: '../gradle/docker.gradle'
diff --git a/java8/proxy/build.gradle b/java8/proxy/build.gradle
index 922908b..0df3105 100644
--- a/java8/proxy/build.gradle
+++ b/java8/proxy/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF
[GitHub] houshengbo closed pull request #63: Last files to need ASF License headers.
houshengbo closed pull request #63: Last files to need ASF License headers.
URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/63
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/environments/local/group_vars/all
b/ansible/environments/local/group_vars/all
index 2085010..4cd7674 100755
--- a/ansible/environments/local/group_vars/all
+++ b/ansible/environments/local/group_vars/all
@@ -1,3 +1,6 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
whisk_version_name: local
openwhisk_tmp_dir: "{{ lookup('env', 'OPENWHISK_TMP_DIR')|default('/tmp',
true) }}"
config_root_dir: "{{ openwhisk_tmp_dir }}/wskconf"
diff --git a/build.gradle b/build.gradle
index 300a1ce..4ebd4b8 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
buildscript {
repositories {
jcenter()
diff --git a/core/swift3.1.1Action/build.gradle
b/core/swift3.1.1Action/build.gradle
index ecc3760..678d0ad 100755
--- a/core/swift3.1.1Action/build.gradle
+++ b/core/swift3.1.1Action/build.gradle
@@ -1,2 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
ext.dockerImageName = 'action-swift-v3.1.1'
apply from: '../../gradle/docker.gradle'
diff --git a/core/swift3.1.1Action/spm-build/Package.swift
b/core/swift3.1.1Action/spm-build/Package.swift
index 4f0a576..3931ba4 100755
--- a/core/swift3.1.1Action/spm-build/Package.swift
+++ b/core/swift3.1.1Action/spm-build/Package.swift
@@ -1,9 +1,12 @@
/*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
diff --git a/core/swift3.1.1Action/spm-build/_WhiskJSONUtils.swift
b/core/swift3.1.1Action/spm-build/_WhiskJSONUtils.swift
index 6ab95d4..58fbe29 100644
--- a/core/swift3.1.1Action/spm-build/_WhiskJSONUtils.swift
+++ b/core/swift3.1.1Action/spm-build/_WhiskJSONUtils.swift
@@ -1,9 +1,12 @@
/*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
[GitHub] houshengbo closed pull request #278: Add ASF license header to .gradle files.
houshengbo closed pull request #278: Add ASF license header to .gradle files.
URL: https://github.com/apache/incubator-openwhisk-catalog/pull/278
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/gradle/wrapper/gradle-wrapper.properties
b/gradle/wrapper/gradle-wrapper.properties
index f16d266..d7cc33f 100644
--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -1,3 +1,6 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
diff --git a/packages/samples/hello/java/build.gradle
b/packages/samples/hello/java/build.gradle
index dc2588c..e6596e8 100644
--- a/packages/samples/hello/java/build.gradle
+++ b/packages/samples/hello/java/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
apply plugin: 'java'
repositories {
diff --git a/settings.gradle b/settings.gradle
index 17488fc..8fc6f8f 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
include 'tests'
rootProject.name = 'openwhisk-catalog'
diff --git a/tests/build.gradle b/tests/build.gradle
index a11f24a..84926c5 100644
--- a/tests/build.gradle
+++ b/tests/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
apply plugin: 'scala'
apply plugin: 'eclipse'
compileTestScala.options.encoding = 'UTF-8'
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows commented on issue #10: Some source files miss Apache license headers
mrutkows commented on issue #10: Some source files miss Apache license headers URL: https://github.com/apache/incubator-openwhisk-runtime-python/issues/10#issuecomment-391377174 @daisy-ycguo can we close this issue? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] starpit opened a new issue #119: add support for retries
starpit opened a new issue #119: add support for retries URL: https://github.com/apache/incubator-openwhisk-client-js/issues/119 in some scenarios, the connection to openwhisk may be unreliable. for example, certain versions of nodejs on linux yield routine ETIMEDOUT or ESOCKETTIMEOUT or ECONNRESET (especially the last one); all of these errors are transient, and can be addressed via retry. i propose that we can support retries with only a few lines of code change, e.g. by wrapping the `rp` call in client.request with a `promise-retry`. PR pending This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new issue #203: travis smoke test should include apigw
dgrove-oss opened a new issue #203: travis smoke test should include apigw URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/203 The smoke tests run by tools/travis/build-helm.sh should include `wsk api create` and invoking an API via curl. There's a commented out attempt to test this at the bottom of the file, but there's some quirk in the travis testing environment that is causing it to not work. Need to get back to this, debug, and enable the test case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] starpit closed pull request #118: add User-Agent to request header
starpit closed pull request #118: add User-Agent to request header
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/118
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/lib/client.js b/lib/client.js
index 900173c..48723e3 100644
--- a/lib/client.js
+++ b/lib/client.js
@@ -124,6 +124,7 @@ class Client {
url: this.pathUrl(path),
rejectUnauthorized: !this.options.ignoreCerts,
headers: {
+'User-Agent': (options && options['User-Agent']) ||
'openwhisk-client-js',
Authorization: this.authHeader()
}
}, options)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] starpit opened a new pull request #118: add User-Agent to request header
starpit opened a new pull request #118: add User-Agent to request header URL: https://github.com/apache/incubator-openwhisk-client-js/pull/118 This imposes a default User-Agent, if the client did not specify one. We could change this to leave it blank if not specified; but my opinion right now would be to always specify something. Fixes #117 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #202: Kuberentes v1.9.7 Deployment
dgrove-oss commented on issue #202: Kuberentes v1.9.7 Deployment URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/202#issuecomment-391420724 ICLA now on file; merging PR. Thanks for the contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] starpit closed pull request #118: add User-Agent to request header
starpit closed pull request #118: add User-Agent to request header
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/118
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/lib/client.js b/lib/client.js
index 900173c..48723e3 100644
--- a/lib/client.js
+++ b/lib/client.js
@@ -124,6 +124,7 @@ class Client {
url: this.pathUrl(path),
rejectUnauthorized: !this.options.ignoreCerts,
headers: {
+'User-Agent': (options && options['User-Agent']) ||
'openwhisk-client-js',
Authorization: this.authHeader()
}
}, options)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] starpit opened a new pull request #118: add User-Agent to request header
starpit opened a new pull request #118: add User-Agent to request header URL: https://github.com/apache/incubator-openwhisk-client-js/pull/118 This imposes a default User-Agent, if the client did not specify one. We could change this to leave it blank if not specified; but my opinion right now would be to always specify something. Fixes #117 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss closed pull request #202: Kuberentes v1.9.7 Deployment
dgrove-oss closed pull request #202: Kuberentes v1.9.7 Deployment URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/202 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/kubernetes/apigateway/apigateway.yml b/kubernetes/apigateway/apigateway.yml index 4a4f5bf..b746759 100644 --- a/kubernetes/apigateway/apigateway.yml +++ b/kubernetes/apigateway/apigateway.yml @@ -49,12 +49,23 @@ spec: values: - apigateway topologyKey: "kubernetes.io/hostname" - volumes: - name: redis-data persistentVolumeClaim: claimName: pv-apigateway-01 - + initContainers: + - name: redis-init +image: busybox +command: + - chown + - -v + - -R + - 999:999 + - /data +volumeMounts: +- mountPath: /data + name: redis-data + readOnly: false containers: - name: redis imagePullPolicy: IfNotPresent @@ -62,6 +73,7 @@ spec: volumeMounts: - mountPath: /data name: redis-data + readOnly: false - name: apigateway imagePullPolicy: Always image: openwhisk/apigateway This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] matt-boyd opened a new pull request #3691: README: Available typo
matt-boyd opened a new pull request #3691: README: Available typo URL: https://github.com/apache/incubator-openwhisk/pull/3691 Updating avaiable to available. ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jthomas commented on issue #126: Docker-Compose: Migrate to dockerize instead of curl
jthomas commented on issue #126: Docker-Compose: Migrate to dockerize instead of curl URL: https://github.com/apache/incubator-openwhisk-devtools/issues/126#issuecomment-391354524 Hello @allustin, thanks for raising this issue. Is this something you are familiar with? Would you like to have a go at submitting a PR with the change? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] matt-boyd commented on issue #3691: README: Available typo
matt-boyd commented on issue #3691: README: Available typo URL: https://github.com/apache/incubator-openwhisk/pull/3691#issuecomment-391356727 No problem! :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3691: README: Available typo
codecov-io commented on issue #3691: README: Available typo URL: https://github.com/apache/incubator-openwhisk/pull/3691#issuecomment-391367357 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3691?src=pr=h1) Report > Merging [#3691](https://codecov.io/gh/apache/incubator-openwhisk/pull/3691?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3691?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3691 +/- ## = + Coverage 74.49% 74.5% +0.01% = Files 126 126 Lines59945994 Branches 392 392 = + Hits 44654466 +1 + Misses 15291528 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3691?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3691/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3691?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3691?src=pr=footer). Last update [8a3b447...6ff7746](https://codecov.io/gh/apache/incubator-openwhisk/pull/3691?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #25: Last files to need ASF License headers.
houshengbo closed pull request #25: Last files to need ASF License headers.
URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/25
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/environments/local/group_vars/all
b/ansible/environments/local/group_vars/all
index b83d824..6375ab6 100755
--- a/ansible/environments/local/group_vars/all
+++ b/ansible/environments/local/group_vars/all
@@ -1,3 +1,6 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
whisk_version_name: local
openwhisk_tmp_dir: "{{ lookup('env', 'OPENWHISK_TMP_DIR')|default('/tmp',
true) }}"
config_root_dir: "{{ openwhisk_tmp_dir }}/wskconf"
diff --git a/build.gradle b/build.gradle
index 300a1ce..4ebd4b8 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
buildscript {
repositories {
jcenter()
diff --git a/core/python2Action/build.gradle b/core/python2Action/build.gradle
index ca5fb2f..32ab1b5 100644
--- a/core/python2Action/build.gradle
+++ b/core/python2Action/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
ext.dockerImageName = 'python2action'
apply from: '../../gradle/docker.gradle'
distDocker.dependsOn 'copyFiles'
@@ -15,4 +32,3 @@ task copyFiles(type: Copy) {
task rmFiles(type: Delete) {
delete runners.collect { it.getName() }
}
-
diff --git a/core/pythonAction/build.gradle b/core/pythonAction/build.gradle
index f3a5724..f120d86 100644
--- a/core/pythonAction/build.gradle
+++ b/core/pythonAction/build.gradle
@@ -1,2 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
ext.dockerImageName = 'python3action'
apply from: '../../gradle/docker.gradle'
diff --git a/gradle/docker.gradle b/gradle/docker.gradle
index f716c7b..6ad6850 100644
--- a/gradle/docker.gradle
+++ b/gradle/docker.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+
[GitHub] houshengbo closed pull request #305: Add ASF license header to .gradle files.
houshengbo closed pull request #305: Add ASF license header to .gradle files.
URL: https://github.com/apache/incubator-openwhisk-cli/pull/305
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.gradle b/build.gradle
index 27a6f9b4..d666bf09 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
plugins {
id 'com.github.blindpirate.gogradle' version '0.8.1'
}
diff --git a/gradle.properties b/gradle.properties
index dd6667aa..63aca458 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -1 +1,4 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
systemProp.gogradle.alias=true
diff --git a/gradle/docker.gradle b/gradle/docker.gradle
index f716c7b4..6ad68506 100644
--- a/gradle/docker.gradle
+++ b/gradle/docker.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
import groovy.time.*
/**
diff --git a/gradle/wrapper/gradle-wrapper.properties
b/gradle/wrapper/gradle-wrapper.properties
index f16d2666..d7cc33fe 100644
--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -1,3 +1,6 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
diff --git a/settings.gradle b/settings.gradle
index 38de3080..60529dab 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
include 'tests'
rootProject.name = 'openwhisk-cli'
diff --git a/tests/build.gradle b/tests/build.gradle
index 1dc5ef7b..f41535a0 100644
--- a/tests/build.gradle
+++ b/tests/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
[GitHub] starpit opened a new pull request #118: add User-Agent to request header
starpit opened a new pull request #118: add User-Agent to request header URL: https://github.com/apache/incubator-openwhisk-client-js/pull/118 Fixes #117 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3669: Make stemcells configurable by deployment
markusthoemmes commented on a change in pull request #3669: Make stemcells
configurable by deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/3669#discussion_r190341384
##
File path: common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
##
@@ -262,13 +283,16 @@ protected[core] object ExecManifest {
}
}
-val manifests: Map[String, RuntimeManifest] = {
- runtimes.flatMap {
-_.versions.map { m =>
- m.kind -> m
-}
- }.toMap
-}
+/**
+ * Collects all runtimes for which there is a stemcell configuration
defined
+ *
+ * @return list of runtime manifests with stemcell configurations
+ */
+def stemcells[T](f: (RuntimeManifest, List[StemCell]) => List[T]): List[T]
= {
+ manifests.collect {
+case (_, m @ RuntimeManifest(_, _, _, _, _, _, _, Some(stemCells))) if
stemCells.nonEmpty => f(m, stemCells)
+ }
+}.flatten.toList
Review comment:
Would it make sense to make this "just" return `List[(RuntimeManifest,
List[StemCell])]` to enable the same functionality but with more flexibility
and clarity?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3669: Make stemcells configurable by deployment
markusthoemmes commented on a change in pull request #3669: Make stemcells
configurable by deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/3669#discussion_r190336091
##
File path: common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
##
@@ -285,6 +309,24 @@ protected[core] object ExecManifest {
private val defaultSplitter = "([a-z0-9]+):default".r
}
+ protected[entity] implicit val stemCellSerdes = new RootJsonFormat[StemCell]
{
Review comment:
Doesn't a default `jsonFormat` work here? Meanwhile there should be a
JsonFormat for `ByteSize`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3669: Make stemcells configurable by deployment
markusthoemmes commented on a change in pull request #3669: Make stemcells
configurable by deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/3669#discussion_r190343332
##
File path: common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
##
@@ -262,13 +283,16 @@ protected[core] object ExecManifest {
}
}
-val manifests: Map[String, RuntimeManifest] = {
- runtimes.flatMap {
-_.versions.map { m =>
- m.kind -> m
-}
- }.toMap
-}
+/**
+ * Collects all runtimes for which there is a stemcell configuration
defined
+ *
+ * @return list of runtime manifests with stemcell configurations
+ */
+def stemcells[T](f: (RuntimeManifest, List[StemCell]) => List[T]): List[T]
= {
+ manifests.collect {
+case (_, m @ RuntimeManifest(_, _, _, _, _, _, _, Some(stemCells))) if
stemCells.nonEmpty => f(m, stemCells)
+ }
Review comment:
If my suggestion below is adopted, this can be simplified to:
```scala
manifests.filter(_._2.stemCells.map(_.nonEmpty).getOrElse(false))
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3669: Make stemcells configurable by deployment
markusthoemmes commented on a change in pull request #3669: Make stemcells
configurable by deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/3669#discussion_r190335820
##
File path: common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
##
@@ -285,6 +309,24 @@ protected[core] object ExecManifest {
private val defaultSplitter = "([a-z0-9]+):default".r
}
+ protected[entity] implicit val stemCellSerdes = new RootJsonFormat[StemCell]
{
+def write(cell: StemCell) =
+ JsObject("count" -> JsNumber(cell.count), "memory" ->
JsString(cell.memory.toString))
+
+def read(value: JsValue): StemCell = {
+ Try {
+value.asJsObject.getFields("count", "memory") match {
+ case Seq(JsNumber(count), JsString(memory)) =>
+require(count.isWhole && count.intValue > 0, "stem cell count must
be whole number greater than zero")
+StemCell(count.intValue, ByteSize.fromString(memory))
+}
+ } match {
+case Success(c) => c
+case Failure(t) => throw t
+ }
Review comment:
Why even wrap in a `Try` then? This should be equivalent without the `Try` +
`match`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah opened a new issue #3693: new invokers cause load balanacer to reallocate black box invokers
rabbah opened a new issue #3693: new invokers cause load balanacer to reallocate black box invokers URL: https://github.com/apache/incubator-openwhisk/issues/3693 The logic to update the set of managed and black box invokers will cause new invokers (when a sufficient number is added) to become black box invokers, and reallocates ones that were black box invokers as managed invokers. https://github.com/apache/incubator-openwhisk/blob/166189a8f15c99d9237e7020865a34c5bc92a0c2/core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala#L422-L431 This can cause new invokers to re-pull images, and activations which might have been warn start on previous invokers now become cold starts. Updating this test https://github.com/apache/incubator-openwhisk/blob/f64722498bc2f5eadc356b3ae26ebb85de1bcdbf/tests/src/test/scala/whisk/core/loadBalancer/test/ShardingContainerPoolBalancerTests.scala#L45 ``` // apply third update, growing the state val update3 = IndexedSeq(healthy(0), healthy(1), healthy(2)) state.updateInvokers(update3) state.invokers shouldBe update3 state.managedInvokers shouldBe update3.dropRight(1) state.blackboxInvokers shouldBe IndexedSeq(update3.last) ``` shows the change in invoker sets. @markusthoemmes had a good suggestion in Slack which is better long term. I'll leave it to him to document in a future comment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #3562: ArtifactStore implementation for CosmosDB
tysonnorris commented on a change in pull request #3562: ArtifactStore
implementation for CosmosDB
URL:
https://github.com/apache/incubator-openwhisk/pull/3562#discussion_r190358559
##
File path:
common/scala/src/main/scala/whisk/core/database/cosmosdb/CosmosDBArtifactStoreProvider.scala
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.database.cosmosdb
+
+import java.io.Closeable
+
+import akka.actor.ActorSystem
+import akka.stream.ActorMaterializer
+import com.microsoft.azure.cosmosdb.rx.AsyncDocumentClient
+import spray.json.RootJsonFormat
+import whisk.common.Logging
+import whisk.core.database._
+import pureconfig._
+import whisk.core.ConfigKeys
+import whisk.core.database.cosmosdb.CosmosDBUtil.createClient
+import whisk.core.entity.{DocumentReader, WhiskActivation, WhiskAuth,
WhiskEntity}
+
+import scala.reflect.ClassTag
+
+case class CosmosDBConfig(endpoint: String, key: String, db: String)
+
+case class ClientHolder(client: AsyncDocumentClient) extends Closeable {
+ override def close(): Unit = client.close()
+}
+
+object CosmosDBArtifactStoreProvider extends ArtifactStoreProvider {
+ type DocumentClientRef = ReferenceCounted[ClientHolder]#CountedReference
+ private lazy val config =
loadConfigOrThrow[CosmosDBConfig](ConfigKeys.cosmosdb)
+ private var clientRef: ReferenceCounted[ClientHolder] = _
Review comment:
I guess I favor multiple shutdown calls vs the reference tracking.
I tested changing the provider to:
```
private val config = loadConfigOrThrow[CosmosDBConfig](ConfigKeys.cosmosdb)
private val clientRef = createClient(config)
```
and it seems to run fine in `CosmosDBArtifactStoreTests` - it ends up
calling `client.close()` multiple times, as expected, and seems to operate
properly.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss opened a new pull request #3692: Slightly expand description of ICLA process.
dgrove-oss opened a new pull request #3692: Slightly expand description of ICLA process. URL: https://github.com/apache/incubator-openwhisk/pull/3692 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #201: apigateway working with helm+minikube (NodePort)
dgrove-oss commented on issue #201: apigateway working with helm+minikube (NodePort) URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/201#issuecomment-391426736 @csantanapr -- this is ready to merge when you have time. I gave up on adding the apigateway test for now and opened issue #203 to remind me to get back to it. There's something subtly different in the travis environment I haven't managed to figure out, but I don't want to hold up on the fixes any longer. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss closed issue #63: Helm chart to orchestrate deployment
dgrove-oss closed issue #63: Helm chart to orchestrate deployment URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/63 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3689: Enable extending environment variables of Controller and Invoker
csantanapr commented on a change in pull request #3689: Enable extending
environment variables of Controller and Invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3689#discussion_r190335870
##
File path: ansible/environments/local/group_vars/all
##
@@ -2,6 +2,7 @@
# license agreements; and to You under the Apache License, Version 2.0.
whisk_version_name: local
+extraEnvSets: "{{ lookup('env', 'OPENWHISK_EXTRA_ENV_SETS')|default(false,
true) }}"
Review comment:
We should not assume that is one top level set and force on both controller
and invoker
Maybe user wants to set certain config or secret that is intended for
controller but not invoker.
Or you want to set the same variable ie apikey to the db and is different
for both controller and invoker.
What about having namespace with option to override
```
invoker:
extraEnv: "{{ invoker_extra_env | lookup('env', 'OPENWHISK_EXTRA_ENV') |
default(false, true) }}"
controller:
extraEnv: "{{ controller_extra_env | lookup('env', 'OPENWHISK_EXTRA_ENV')
| default(false, true) }}"
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #3692: Slightly expand description of ICLA process.
codecov-io commented on issue #3692: Slightly expand description of ICLA process. URL: https://github.com/apache/incubator-openwhisk/pull/3692#issuecomment-391436468 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3692?src=pr=h1) Report > Merging [#3692](https://codecov.io/gh/apache/incubator-openwhisk/pull/3692?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/8a3b4472d5ef420f0216cc8e42932d87f428ed30?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3692?src=pr=tree) ```diff @@Coverage Diff@@ ## master #3692 +/- ## = + Coverage 74.49% 74.5% +0.01% = Files 126 126 Lines59945994 Branches 392 392 = + Hits 44654466 +1 + Misses 15291528 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3692?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3692/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3692?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3692?src=pr=footer). Last update [8a3b447...6434e78](https://codecov.io/gh/apache/incubator-openwhisk/pull/3692?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #919: GitHub "revert" task/code fails; "code: already_exists"
pritidesai commented on issue #919: GitHub "revert" task/code fails; "code: already_exists" URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/919#issuecomment-391455560 It creates this weird draft release on release page:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #3562: ArtifactStore implementation for CosmosDB
tysonnorris commented on issue #3562: ArtifactStore implementation for CosmosDB URL: https://github.com/apache/incubator-openwhisk/pull/3562#issuecomment-391457832 I think adding `ArtifactStoreProvider.shutdown()` seems like a fine addition, if calling `client.close()` multiple times is not reliable. The tests will need to know that some artifact stores have client bound to provider, and others have client bound to store, which I think is not great, but it is OK given that nothing is invoking shutdown currently, and the behavior is different amongst the stores currently. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3669: Make stemcells configurable by deployment
rabbah commented on a change in pull request #3669: Make stemcells configurable
by deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/3669#discussion_r190365020
##
File path: common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
##
@@ -285,6 +309,24 @@ protected[core] object ExecManifest {
private val defaultSplitter = "([a-z0-9]+):default".r
}
+ protected[entity] implicit val stemCellSerdes = new RootJsonFormat[StemCell]
{
+def write(cell: StemCell) =
+ JsObject("count" -> JsNumber(cell.count), "memory" ->
JsString(cell.memory.toString))
+
+def read(value: JsValue): StemCell = {
+ Try {
+value.asJsObject.getFields("count", "memory") match {
+ case Seq(JsNumber(count), JsString(memory)) =>
+require(count.isWhole && count.intValue > 0, "stem cell count must
be whole number greater than zero")
+StemCell(count.intValue, ByteSize.fromString(memory))
+}
+ } match {
+case Success(c) => c
+case Failure(t) => throw t
+ }
Review comment:
路♂️ will nuke.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3669: Make stemcells configurable by deployment
rabbah commented on a change in pull request #3669: Make stemcells configurable
by deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/3669#discussion_r190364979
##
File path: common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
##
@@ -285,6 +309,24 @@ protected[core] object ExecManifest {
private val defaultSplitter = "([a-z0-9]+):default".r
}
+ protected[entity] implicit val stemCellSerdes = new RootJsonFormat[StemCell]
{
Review comment:
there isn't but will add one and replace this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3669: Make stemcells configurable by deployment
rabbah commented on a change in pull request #3669: Make stemcells configurable
by deployment
URL:
https://github.com/apache/incubator-openwhisk/pull/3669#discussion_r190365264
##
File path: common/scala/src/main/scala/whisk/core/entity/ExecManifest.scala
##
@@ -262,13 +283,16 @@ protected[core] object ExecManifest {
}
}
-val manifests: Map[String, RuntimeManifest] = {
- runtimes.flatMap {
-_.versions.map { m =>
- m.kind -> m
-}
- }.toMap
-}
+/**
+ * Collects all runtimes for which there is a stemcell configuration
defined
+ *
+ * @return list of runtime manifests with stemcell configurations
+ */
+def stemcells[T](f: (RuntimeManifest, List[StemCell]) => List[T]): List[T]
= {
+ manifests.collect {
+case (_, m @ RuntimeManifest(_, _, _, _, _, _, _, Some(stemCells))) if
stemCells.nonEmpty => f(m, stemCells)
+ }
+}.flatten.toList
Review comment:
ok will adopt.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai opened a new pull request #923: an attempt to enable api gateway test in travis
pritidesai opened a new pull request #923: an attempt to enable api gateway test in travis URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/923 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
