[GitHub] codecov-io commented on issue #3950: Extend system testsuite

2018-08-09 Thread GitBox
codecov-io commented on issue #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#issuecomment-411691678 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr=h1) Report > Merging

[GitHub] jvdgeest opened a new pull request #271: Correctly writing custom OpenWhisk authentication keys (for the guest…

2018-08-09 Thread GitBox
jvdgeest opened a new pull request #271: Correctly writing custom OpenWhisk authentication keys (for the guest… URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/271 … and whisk.system users) into the CouchDB database. With this fix, custom auth keys that are

[GitHub] codecov-io commented on issue #3955: Add an variable to set the timezone for all of components

2018-08-09 Thread GitBox
codecov-io commented on issue #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#issuecomment-411667536 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr=h1) Report > Merging

[GitHub] chetanmeh commented on issue #3798: Allow for activation store to accept user and request information

2018-08-09 Thread GitBox
chetanmeh commented on issue #3798: Allow for activation store to accept user and request information URL: https://github.com/apache/incubator-openwhisk/pull/3798#issuecomment-411672562 > where do you think the UserContext case class should live Adding it to `ActivationStore` looks

[GitHub] codecov-io commented on issue #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
codecov-io commented on issue #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#issuecomment-411695432 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951?src=pr=h1) Report > Merging

[GitHub] chetanmeh opened a new pull request #3958: Add tracing component name to wskadmin-next

2018-08-09 Thread GitBox
chetanmeh opened a new pull request #3958: Add tracing component name to wskadmin-next URL: https://github.com/apache/incubator-openwhisk/pull/3958 `wskadmin-next` fails to start with configuration exception. This config is required for each independent component which depends on common

[GitHub] fmaschler commented on issue #2926: Missing document for wskadmin

2018-08-09 Thread GitBox
fmaschler commented on issue #2926: Missing document for wskadmin URL: https://github.com/apache/incubator-openwhisk/issues/2926#issuecomment-411676875 I came across this issue using the docker-compose quick-start. I guess it's deprecated with the new tool `wskadmin-next`? Since neither

[GitHub] codecov-io edited a comment on issue #3814: wskadmin scala db command to export and import

2018-08-09 Thread GitBox
codecov-io edited a comment on issue #3814: wskadmin scala db command to export and import URL: https://github.com/apache/incubator-openwhisk/pull/3814#issuecomment-400666862 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3950: Extend system testsuite

2018-08-09 Thread GitBox
codecov-io edited a comment on issue #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#issuecomment-411691678 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr=h1) Report > Merging

[GitHub] chetanmeh commented on issue #2926: Missing document for wskadmin

2018-08-09 Thread GitBox
chetanmeh commented on issue #2926: Missing document for wskadmin URL: https://github.com/apache/incubator-openwhisk/issues/2926#issuecomment-411695146 My mistake ... I mean `wskadmin` is yet not deprecated and should work for your usecase

[GitHub] jiangpengcheng commented on a change in pull request #3955: Add an variable to set the timezone for all of components

2018-08-09 Thread GitBox
jiangpengcheng commented on a change in pull request #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#discussion_r208845167 ## File path: ansible/roles/apigateway/tasks/deploy.yml ## @@ -28,3

[GitHub] fmaschler opened a new issue #3957: wskadmin-next configuration error

2018-08-09 Thread GitBox
fmaschler opened a new issue #3957: wskadmin-next configuration error URL: https://github.com/apache/incubator-openwhisk/issues/3957 The tool `wskadmin-next` failed to list namespaces when following the steps in the

[GitHub] fmaschler commented on issue #2926: Missing document for wskadmin

2018-08-09 Thread GitBox
fmaschler commented on issue #2926: Missing document for wskadmin URL: https://github.com/apache/incubator-openwhisk/issues/2926#issuecomment-411684133 Of course `wskadmin-next` ist not deprecated, I referred to `wskadmin`. The verbose flag did help to find the mistake in the

[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208862176 ## File path: tests/src/test/scala/system/basic/WskRestBasicTests.scala ## @@ -320,6 +320,40 @@ class

[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208861341 ## File path: tests/src/test/scala/system/basic/WskActionTests.scala ## @@ -71,6 +71,49 @@ class

[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208863005 ## File path: tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala ## @@ -462,6

[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208860665 ## File path: tests/src/test/scala/common/rest/WskRestOperations.scala ## @@ -733,13 +738,23 @@ class

[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208862427 ## File path: tests/src/test/scala/whisk/core/cli/test/WskEntitlementTests.scala ## @@ -160,6 +160,46 @@

[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208863182 ## File path: tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala ## @@ -462,6

[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208861393 ## File path: tests/src/test/scala/system/basic/WskActivationTests.scala ## @@ -21,6 +21,7 @@ import

[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208862658 ## File path: tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala ## @@ -462,6

[GitHub] rahulqelfo opened a new pull request #3956: Ow karate

2018-08-09 Thread GitBox
rahulqelfo opened a new pull request #3956: Ow karate URL: https://github.com/apache/incubator-openwhisk/pull/3956 This PR consists of functional test cases using Karate BDD Framework. ## Description This PR intends to complement the existing functional tests cases using the

[GitHub] markusthoemmes commented on a change in pull request #3955: Add an variable to set the timezone for all of components

2018-08-09 Thread GitBox
markusthoemmes commented on a change in pull request #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#discussion_r208838373 ## File path: ansible/roles/apigateway/tasks/deploy.yml ## @@ -28,3

[GitHub] chetanmeh commented on issue #2926: Missing document for wskadmin

2018-08-09 Thread GitBox
chetanmeh commented on issue #2926: Missing document for wskadmin URL: https://github.com/apache/incubator-openwhisk/issues/2926#issuecomment-411678781 `wskadmin-next` is not deprecated. You need to have required properties in `whisk.properties` file. Can you share output of `wskadmin -v

[GitHub] jiangpengcheng opened a new pull request #3955: Add an variable to set the timezone for all of components

2018-08-09 Thread GitBox
jiangpengcheng opened a new pull request #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955 This makes it easy to analyze when errors were happened from logs ## Description All components except CouchDB

[GitHub] mgencur commented on issue #3950: Extend system testsuite

2018-08-09 Thread GitBox
mgencur commented on issue #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#issuecomment-411656682 @markusthoemmes thanks, I can see the API tests now. Will try to move some tests there.

[GitHub] markusthoemmes commented on issue #3958: Add tracing component name to wskadmin-next

2018-08-09 Thread GitBox
markusthoemmes commented on issue #3958: Add tracing component name to wskadmin-next URL: https://github.com/apache/incubator-openwhisk/pull/3958#issuecomment-411732911 Why is this needed if tracing is disabled? Do we have a bug somewhere else?

[GitHub] chetanmeh commented on issue #3958: Add tracing component name to wskadmin-next

2018-08-09 Thread GitBox
chetanmeh commented on issue #3958: Add tracing component name to wskadmin-next URL: https://github.com/apache/incubator-openwhisk/pull/3958#issuecomment-411724410 > Could this be included in the generated conf file? Can be but its more of a constant config so better part of

[GitHub] mgencur commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
mgencur commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208905795 ## File path: tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala ## @@ -462,6 +462,58 @@

[GitHub] rabbah closed issue #2882: redact information in test log message

2018-08-09 Thread GitBox
rabbah closed issue #2882: redact information in test log message URL: https://github.com/apache/incubator-openwhisk/issues/2882 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] rabbah commented on issue #2882: redact information in test log message

2018-08-09 Thread GitBox
rabbah commented on issue #2882: redact information in test log message URL: https://github.com/apache/incubator-openwhisk/issues/2882#issuecomment-411763485 Thanks for the contribution and fix. This is an automated message

[GitHub] chetanmeh commented on issue #3958: Add tracing component name to wskadmin-next

2018-08-09 Thread GitBox
chetanmeh commented on issue #3958: Add tracing component name to wskadmin-next URL: https://github.com/apache/incubator-openwhisk/pull/3958#issuecomment-411763212 @markusthoemmes This is due to how currently tracing is configured. It requires a component name which is provided via

[GitHub] chetanmeh edited a comment on issue #3957: wskadmin-next configuration error

2018-08-09 Thread GitBox
chetanmeh edited a comment on issue #3957: wskadmin-next configuration error URL: https://github.com/apache/incubator-openwhisk/issues/3957#issuecomment-411724078 I had currently [fixed it][1] as part of work in #3814. Now created a separate PR #3958 to fix this specifically [1]:

[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208909320 ## File path: tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala ## @@ -462,6

[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208900516 ## File path: tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala ## @@ -462,6

[GitHub] rabbah commented on a change in pull request #3955: Add an variable to set the timezone for all of components

2018-08-09 Thread GitBox
rabbah commented on a change in pull request #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#discussion_r208915212 ## File path: ansible/README.md ## @@ -359,3 +359,11 @@ limits: - The

[GitHub] rabbah closed pull request #3173: incubator-openwhisk-2882 Delete printlns

2018-08-09 Thread GitBox
rabbah closed pull request #3173: incubator-openwhisk-2882 Delete printlns URL: https://github.com/apache/incubator-openwhisk/pull/3173 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] mgencur commented on a change in pull request #3950: Extend system testsuite

2018-08-09 Thread GitBox
mgencur commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208896992 ## File path: tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala ## @@ -462,6 +462,58 @@

[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208926172 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with

[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208928955 ## File path: docs/actions.md ## @@ -340,7 +344,7 @@ is skipped if an action is dispatched to a

[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208927670 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with

[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208928501 ## File path: docs/actions.md ## @@ -233,8 +240,11 @@ Each action invocation results in an activation

[GitHub] rabbah commented on issue #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
rabbah commented on issue #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#issuecomment-411758033 Thanks for improving the docs - this is important and appreciated. This

[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208926821 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with

[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208927943 ## File path: docs/actions.md ## @@ -233,8 +240,11 @@ Each action invocation results in an activation

[GitHub] chetanmeh commented on issue #3957: wskadmin-next configuration error

2018-08-09 Thread GitBox
chetanmeh commented on issue #3957: wskadmin-next configuration error URL: https://github.com/apache/incubator-openwhisk/issues/3957#issuecomment-411724078 I had currently [fixed it][1] as part of work in #3814. Now created a separate PR #3958 to fix this specifically [1]:

[GitHub] csantanapr commented on a change in pull request #3955: Add an variable to set the timezone for all of components

2018-08-09 Thread GitBox
csantanapr commented on a change in pull request #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#discussion_r208926951 ## File path: ansible/roles/apigateway/tasks/deploy.yml ## @@ -28,3 +29,6

[GitHub] rabbah edited a comment on issue #3173: incubator-openwhisk-2882 Delete printlns

2018-08-09 Thread GitBox
rabbah edited a comment on issue #3173: incubator-openwhisk-2882 Delete printlns URL: https://github.com/apache/incubator-openwhisk/pull/3173#issuecomment-411764105 @vooolll do you have an Apache CLA on file? This is an

[GitHub] rabbah commented on issue #3173: incubator-openwhisk-2882 Delete printlns

2018-08-09 Thread GitBox
rabbah commented on issue #3173: incubator-openwhisk-2882 Delete printlns URL: https://github.com/apache/incubator-openwhisk/pull/3173#issuecomment-411764105 @vooolll do you have an Apache CLA? This is an automated

[GitHub] mdeuser closed pull request #3760: Separate routemgmt.yml out from openwhisk.yml playbook

2018-08-09 Thread GitBox
mdeuser closed pull request #3760: Separate routemgmt.yml out from openwhisk.yml playbook URL: https://github.com/apache/incubator-openwhisk/pull/3760 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rabbah edited a comment on issue #3173: incubator-openwhisk-2882 Delete printlns

2018-08-09 Thread GitBox
rabbah edited a comment on issue #3173: incubator-openwhisk-2882 Delete printlns URL: https://github.com/apache/incubator-openwhisk/pull/3173#issuecomment-411764105 @vooolll do you have an Apache CLA on file? Could you please file an Apache CLA as described here:

[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208948995 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting

[GitHub] csantanapr opened a new pull request #10: remove hardcoded env variables for run handler

2018-08-09 Thread GitBox
csantanapr opened a new pull request #10: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-ruby/pull/10 This allows for the customized invoker with an SPI to send more variables in the run handler @eweiter could you review this

[GitHub] csantanapr opened a new pull request #55: remove hardcoded env variables for run handler

2018-08-09 Thread GitBox
csantanapr opened a new pull request #55: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/55 This allows for the customized invoker with an SPI to send more variables in the run handler @eweiter could you review this

[GitHub] junoyoon commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-08-09 Thread GitBox
junoyoon commented on issue #3880: Modify that web action in the bound package can be accessed. URL: https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-411795589 @upgle is it done? This is an automated

[GitHub] csantanapr opened a new pull request #7: remove hardcoded env variables for run handler

2018-08-09 Thread GitBox
csantanapr opened a new pull request #7: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-ballerina/pull/7 This allows for a customized invoker with an SPI to send more variables in the run handler

[GitHub] codecov-io edited a comment on issue #3919: Allow raw JSON string as response for webaction without base64 encoding.

2018-08-09 Thread GitBox
codecov-io edited a comment on issue #3919: Allow raw JSON string as response for webaction without base64 encoding. URL: https://github.com/apache/incubator-openwhisk/pull/3919#issuecomment-409779533 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr=h1)

[GitHub] codecov-io edited a comment on issue #3919: Allow raw JSON string as response for webaction without base64 encoding.

2018-08-09 Thread GitBox
codecov-io edited a comment on issue #3919: Allow raw JSON string as response for webaction without base64 encoding. URL: https://github.com/apache/incubator-openwhisk/pull/3919#issuecomment-409779533 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr=h1)

[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208947806 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting

[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208948137 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting

[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208949514 ## File path: docs/actions.md ## @@ -233,8 +240,11 @@ Each action invocation results in an activation

[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208949464 ## File path: docs/actions.md ## @@ -233,8 +240,11 @@ Each action invocation results in an activation

[GitHub] csantanapr opened a new pull request #78: remove hardcoded env variables for run handler

2018-08-09 Thread GitBox
csantanapr opened a new pull request #78: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/78 This allows for the customized invoker with an SPI to send more variables in the run handler @eweiter could you review this

[GitHub] csantanapr opened a new pull request #67: remove hardcoded env variables for run handler

2018-08-09 Thread GitBox
csantanapr opened a new pull request #67: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/67 This allows for the customized invoker with an SPI to send more variables in the run handler @eweiter could you review this

[GitHub] pritidesai closed pull request #291: ADjust colors for yaml and bash; add bash highlighting

2018-08-09 Thread GitBox
pritidesai closed pull request #291: ADjust colors for yaml and bash; add bash highlighting URL: https://github.com/apache/incubator-openwhisk-website/pull/291 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rabbah commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-08-09 Thread GitBox
rabbah commented on issue #3880: Modify that web action in the bound package can be accessed. URL: https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-411796869 The last commit looks a lot better now - I'll review more thoroughly.

[GitHub] dgrove-oss commented on issue #271: Correctly writing custom OpenWhisk authentication keys (for the guest…

2018-08-09 Thread GitBox
dgrove-oss commented on issue #271: Correctly writing custom OpenWhisk authentication keys (for the guest… URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/271#issuecomment-411770579 Thanks; change makes sense to me. Could you please file an Apache CLA as

[GitHub] fmaschler opened a new pull request #147: Use 0.9.0 release as default sources

2018-08-09 Thread GitBox
fmaschler opened a new pull request #147: Use 0.9.0 release as default sources URL: https://github.com/apache/incubator-openwhisk-devtools/pull/147 Now with the first official release one could use that to download sources in the quick-start deployment.

[GitHub] csantanapr commented on issue #7: remove hardcoded env variables for run handler

2018-08-09 Thread GitBox
csantanapr commented on issue #7: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-ballerina/pull/7#issuecomment-411775479 @eweiter could you review this PR. This is

[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations

2018-08-09 Thread GitBox
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208948722 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with

[GitHub] mrutkows opened a new pull request #296: adjust header flow layout margins to match content

2018-08-09 Thread GitBox
mrutkows opened a new pull request #296: adjust header flow layout margins to match content URL: https://github.com/apache/incubator-openwhisk-website/pull/296 This is an automated message from the Apache Git Service. To

[GitHub] jiangpengcheng commented on a change in pull request #3656: Adjust the ForcibleSemaphore mechanism

2018-08-09 Thread GitBox
jiangpengcheng commented on a change in pull request #3656: Adjust the ForcibleSemaphore mechanism URL: https://github.com/apache/incubator-openwhisk/pull/3656#discussion_r209126748 ## File path: common/scala/src/main/scala/whisk/common/ForcableSemaphore.scala ## @@

[GitHub] dubee commented on a change in pull request #353: Create triggers on update if do not exist

2018-08-09 Thread GitBox
dubee commented on a change in pull request #353: Create triggers on update if do not exist URL: https://github.com/apache/incubator-openwhisk-cli/pull/353#discussion_r209136587 ## File path: build.gradle ## @@ -222,6 +226,12 @@ task goLint(type:

[GitHub] dubee commented on a change in pull request #353: Create triggers on update if do not exist

2018-08-09 Thread GitBox
dubee commented on a change in pull request #353: Create triggers on update if do not exist URL: https://github.com/apache/incubator-openwhisk-cli/pull/353#discussion_r209136514 ## File path: commands/trigger_test.go ## @@ -0,0 +1,67 @@ +package commands_test Review

[GitHub] dubee closed pull request #3919: Allow raw JSON string as response for webaction without base64 encoding.

2018-08-09 Thread GitBox
dubee closed pull request #3919: Allow raw JSON string as response for webaction without base64 encoding. URL: https://github.com/apache/incubator-openwhisk/pull/3919 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] pritidesai closed pull request #296: adjust header flow layout margins to match content

2018-08-09 Thread GitBox
pritidesai closed pull request #296: adjust header flow layout margins to match content URL: https://github.com/apache/incubator-openwhisk-website/pull/296 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] upgle commented on issue #3880: Modify that web action in the bound package can be accessed.

2018-08-09 Thread GitBox
upgle commented on issue #3880: Modify that web action in the bound package can be accessed. URL: https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-411977645 @junoyoon no, i'm waiting for review. @rabbah ok, tell me if I missed something.

[GitHub] codecov-io edited a comment on issue #3955: Add an variable to set the timezone for all of components

2018-08-09 Thread GitBox
codecov-io edited a comment on issue #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#issuecomment-411667536 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr=h1) Report > Merging

[GitHub] dubee closed pull request #99: Replace trigger service type with interface

2018-08-09 Thread GitBox
dubee closed pull request #99: Replace trigger service type with interface URL: https://github.com/apache/incubator-openwhisk-client-go/pull/99 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] jiangpengcheng opened a new pull request #319: Add package tzdata to the image

2018-08-09 Thread GitBox
jiangpengcheng opened a new pull request #319: Add package tzdata to the image URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/319 Then users can set the timezone for the container The reason why add this package is this PR:

[GitHub] ningyougang commented on issue #3619: Provide an activation store SPI

2018-08-09 Thread GitBox
ningyougang commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-411965011 @dubee

[GitHub] mrutkows commented on issue #274: Need to provide links/method to point to releases

2018-08-09 Thread GitBox
mrutkows commented on issue #274: Need to provide links/method to point to releases URL: https://github.com/apache/incubator-openwhisk-website/issues/274#issuecomment-411860127 IMO, we should do a "dropdown" from the "Downloads" menu on the home page like shown here:

[GitHub] mrutkows closed issue #255: WHAT, HOW, WHY Install OpenWhisk on the main page.

2018-08-09 Thread GitBox
mrutkows closed issue #255: WHAT, HOW, WHY Install OpenWhisk on the main page. URL: https://github.com/apache/incubator-openwhisk-website/issues/255 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mrutkows commented on issue #255: WHAT, HOW, WHY Install OpenWhisk on the main page.

2018-08-09 Thread GitBox
mrutkows commented on issue #255: WHAT, HOW, WHY Install OpenWhisk on the main page. URL: https://github.com/apache/incubator-openwhisk-website/issues/255#issuecomment-411865132 With the redesign of website I believe we fixed all these issues. If we missed any, I would suggest opening

[GitHub] dubee commented on issue #3941: to address #3918, reuse a container on applicationError

2018-08-09 Thread GitBox
dubee commented on issue #3941: to address #3918, reuse a container on applicationError URL: https://github.com/apache/incubator-openwhisk/pull/3941#issuecomment-411868731 @csantanapr any comments on this one? This is an

[GitHub] mrutkows opened a new issue #293: Need list (or link to one) of all project Committers as per ASF reqs.

2018-08-09 Thread GitBox
mrutkows opened a new issue #293: Need list (or link to one) of all project Committers as per ASF reqs. URL: https://github.com/apache/incubator-openwhisk-website/issues/293 This is an automated message from the Apache Git

[GitHub] mrutkows commented on issue #241: Revisit the web site Incubator graduation checklist, and add issues as needed

2018-08-09 Thread GitBox
mrutkows commented on issue #241: Revisit the web site Incubator graduation checklist, and add issues as needed URL: https://github.com/apache/incubator-openwhisk-website/issues/241#issuecomment-411872137 Added individual issues against the recommended checklist.

[GitHub] mrutkows closed issue #222: Verify Ruby installed command not correct for OSX (homebrew)

2018-08-09 Thread GitBox
mrutkows closed issue #222: Verify Ruby installed command not correct for OSX (homebrew) URL: https://github.com/apache/incubator-openwhisk-website/issues/222 This is an automated message from the Apache Git Service. To

[GitHub] mrutkows closed issue #241: Revisit the web site Incubator graduation checklist, and add issues as needed

2018-08-09 Thread GitBox
mrutkows closed issue #241: Revisit the web site Incubator graduation checklist, and add issues as needed URL: https://github.com/apache/incubator-openwhisk-website/issues/241 This is an automated message from the Apache

[GitHub] dubee commented on issue #3173: incubator-openwhisk-2882 Delete printlns

2018-08-09 Thread GitBox
dubee commented on issue #3173: incubator-openwhisk-2882 Delete printlns URL: https://github.com/apache/incubator-openwhisk/pull/3173#issuecomment-411853578 This could have used a PG. Looks like upstream dependancies are broken as a result of these changes.

[GitHub] mrutkows commented on issue #268: Add Quotes (somewhere) and remove old pages

2018-08-09 Thread GitBox
mrutkows commented on issue #268: Add Quotes (somewhere) and remove old pages URL: https://github.com/apache/incubator-openwhisk-website/issues/268#issuecomment-411862139 Quotes are problematic since we have no means to keep them current and the ones we have are over 2+ years old and 1/3

[GitHub] mrutkows opened a new issue #292: Project Website requires License page (or link to)

2018-08-09 Thread GitBox
mrutkows opened a new issue #292: Project Website requires License page (or link to) URL: https://github.com/apache/incubator-openwhisk-website/issues/292 See Apache Spark (for ideas..): https://spark.apache.org/ With the "Apache Software Foundation" menu and drop-down with

[GitHub] mrutkows commented on issue #219: Add IBM logo to supporters web page

2018-08-09 Thread GitBox
mrutkows commented on issue #219: Add IBM logo to supporters web page URL: https://github.com/apache/incubator-openwhisk-website/issues/219#issuecomment-411868859 Added the IBM Logo (with hyperlink to IBM Cloud Functions as part of the redesign dropped Aug. 2018.

[GitHub] mrutkows opened a new issue #294: Need FAQ to adhere to ASF reqs.

2018-08-09 Thread GitBox
mrutkows opened a new issue #294: Need FAQ to adhere to ASF reqs. URL: https://github.com/apache/incubator-openwhisk-website/issues/294 Perhaps provide a link from Documentation page? [] FAQ: frequently asked questions are answered here. the old FAQ (before redesign) was not

[GitHub] mrutkows commented on issue #212: Update Apache Incubator logo

2018-08-09 Thread GitBox
mrutkows commented on issue #212: Update Apache Incubator logo URL: https://github.com/apache/incubator-openwhisk-website/issues/212#issuecomment-411872887 With the website redesign, I would recommend placing the "incubator" logo in the Footer (alongside the disclaimer). See

[GitHub] mrutkows edited a comment on issue #220: Add dates/links for China OpenWhisk Academy events / videos / slides /transcripts

2018-08-09 Thread GitBox
mrutkows edited a comment on issue #220: Add dates/links for China OpenWhisk Academy events / videos / slides /transcripts URL: https://github.com/apache/incubator-openwhisk-website/issues/220#issuecomment-411875210 Perhaps add an invitation at the top of the Community page like:

[GitHub] mrutkows closed issue #284: Add code highlighting

2018-08-09 Thread GitBox
mrutkows closed issue #284: Add code highlighting URL: https://github.com/apache/incubator-openwhisk-website/issues/284 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] mrutkows commented on issue #284: Add code highlighting

2018-08-09 Thread GitBox
mrutkows commented on issue #284: Add code highlighting URL: https://github.com/apache/incubator-openwhisk-website/issues/284#issuecomment-411858817 We added syntax highlighting using Jekyll Rouge and Pygmentation based CSS See PR:

[GitHub] mrutkows commented on issue #270: Create README Templates for Deployment methods

2018-08-09 Thread GitBox
mrutkows commented on issue #270: Create README Templates for Deployment methods URL: https://github.com/apache/incubator-openwhisk-website/issues/270#issuecomment-411861632 We should reach out to Dave Grove, Brendan/Ben and Dragos when developing the template (perhaps not all at once but

[GitHub] mrutkows commented on issue #268: Add Quotes (somewhere) and remove old pages

2018-08-09 Thread GitBox
mrutkows commented on issue #268: Add Quotes (somewhere) and remove old pages URL: https://github.com/apache/incubator-openwhisk-website/issues/268#issuecomment-411861876 Perhaps add to the "Community" page? This is an

  1   2   >