[GitHub] markusthoemmes commented on a change in pull request #3196: Fixes #3195 - create config object for docker in the invoker and get ?
markusthoemmes commented on a change in pull request #3196: Fixes #3195 -
create config object for docker in the invoker and get ?
URL:
https://github.com/apache/incubator-openwhisk/pull/3196#discussion_r170839538
##
File path: common/scala/src/main/resources/application.conf
##
@@ -131,4 +131,4 @@ whisk {
max = 512 m
std = 256 m
}
-}
+}
Review comment:
Please remove that change as its not an intended change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3196: Fixes #3195 - create config object for docker in the invoker and get ?
markusthoemmes commented on a change in pull request #3196: Fixes #3195 -
create config object for docker in the invoker and get ?
URL:
https://github.com/apache/incubator-openwhisk/pull/3196#discussion_r170839462
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerClientWithFileAccess.scala
##
@@ -24,19 +24,14 @@ import akka.actor.ActorSystem
import akka.stream.alpakka.file.scaladsl.FileTailSource
import akka.stream.scaladsl.{FileIO, Source => AkkaSource}
import akka.util.ByteString
-
-import scala.concurrent.ExecutionContext
-import scala.concurrent.Future
-import scala.concurrent.blocking
import spray.json.DefaultJsonProtocol._
import spray.json._
-import whisk.common.Logging
-import whisk.common.TransactionId
-import whisk.core.containerpool.ContainerId
-import whisk.core.containerpool.ContainerAddress
+import whisk.common.{Logging, TransactionId}
+import whisk.core.containerpool.{ContainerAddress, ContainerId}
-import scala.io.Source
+import scala.concurrent.{blocking, ExecutionContext, Future}
import scala.concurrent.duration.FiniteDuration
+import scala.io.Source
Review comment:
Can you remove the push on this file? Seems like no change intended anyway?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3196: Fixes #3195 - create config object for docker in the invoker and get ?
markusthoemmes commented on a change in pull request #3196: Fixes #3195 - create config object for docker in the invoker and get ? URL: https://github.com/apache/incubator-openwhisk/pull/3196#discussion_r170839390 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala ## @@ -261,6 +265,8 @@ class DockerContainer(protected val id: ContainerId, // FramingException can also mean exceeding the limits, we cannot decide which case happened so we resort // to the general error message. This will be the last element of the stream. ByteString(LogLine(Instant.now.toString, "stderr", Messages.logFailure).toJson.compactPrint) +case _: RuntimeException => + ByteString(LogLine(Instant.now.toString, "stderr", "Ouch.").toJson.compactPrint) Review comment: Those two need to be removed I reckon? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #3347: Generic Pooling REST Client
dubeejw commented on issue #3347: Generic Pooling REST Client URL: https://github.com/apache/incubator-openwhisk/pull/3347#issuecomment-368761340 PG2 2862 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jiangpengcheng opened a new pull request #3354: Cli ansible enhancement
jiangpengcheng opened a new pull request #3354: Cli ansible enhancement URL: https://github.com/apache/incubator-openwhisk/pull/3354 Copy the cli archive files to nginx directory too This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #49: Add NOTICE file
daisy-ycguo closed pull request #49: Add NOTICE file URL: https://github.com/apache/incubator-openwhisk-release/pull/49 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.md b/NOTICE.md new file mode 100644 index 000..57655ec --- /dev/null +++ b/NOTICE.md @@ -0,0 +1,5 @@ +Apache OpenWhisk Release +Copyright 2016-2018 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #49: Add NOTICE file
houshengbo opened a new pull request #49: Add NOTICE file URL: https://github.com/apache/incubator-openwhisk-release/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kameshsampath commented on issue #12: [Epic] Improvements to Java Runtime avoud com.sun.* and support MANIFEST main
kameshsampath commented on issue #12: [Epic] Improvements to Java Runtime avoud com.sun.* and support MANIFEST main URL: https://github.com/apache/incubator-openwhisk-runtime-java/issues/12#issuecomment-368740930 guys, my first target for this EPIC would be to rebase the OpenWhisk Java runtime with https://hub.docker.com/r/fabric8/java-jboss-openjdk8-jdk/ as this will solve two issues #5 and we aligning to openjdk for all community bits. @csantanapr can you please add this https://github.com/apache/incubator-openwhisk-runtime-java/issues/18 to the Epic ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kameshsampath opened a new issue #18: Rebase OW JavaRuntime to fabric8 java image
kameshsampath opened a new issue #18: Rebase OW JavaRuntime to fabric8 java image URL: https://github.com/apache/incubator-openwhisk-runtime-java/issues/18 Rebase OW JavaRuntime to fabric8 java image will help us to solve #5 as well making our community runtime image based out of openjdk. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kameshsampath commented on issue #12: [Epic] Improvements to Java Runtime avoud com.sun.* and support MANIFEST main
kameshsampath commented on issue #12: [Epic] Improvements to Java Runtime avoud com.sun.* and support MANIFEST main URL: https://github.com/apache/incubator-openwhisk-runtime-java/issues/12#issuecomment-368740930 guys, my first target for this EPIC would be to rebase the OpenWhisk Java runtime with https://hub.docker.com/r/fabric8/java-jboss-openjdk8-jdk/ as this will solve two issues #5 and we aligning to openjdk for all community bits This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #8: Add the NOTICE file
daisy-ycguo closed pull request #8: Add the NOTICE file URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/8 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.md b/NOTICE.md new file mode 100644 index 000..124d3b8 --- /dev/null +++ b/NOTICE.md @@ -0,0 +1,5 @@ +Apache OpenWhisk Runtime Python +Copyright 2016-2018 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #3347: Generic Pooling REST Client
dubeejw commented on issue #3347: Generic Pooling REST Client URL: https://github.com/apache/incubator-openwhisk/pull/3347#issuecomment-368396899 PG3 1920 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #260: Add the LICENSE and NOTICE files
daisy-ycguo closed pull request #260: Add the LICENSE and NOTICE files URL: https://github.com/apache/incubator-openwhisk-catalog/pull/260 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/LICENSE.txt b/LICENSE.txt new file mode 100644 index 000..d645695 --- /dev/null +++ b/LICENSE.txt @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such
[GitHub] daisy-ycguo closed pull request #275: Add the NOTICE file
daisy-ycguo closed pull request #275: Add the NOTICE file URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/275 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.md b/NOTICE.md new file mode 100644 index 000..d063c89 --- /dev/null +++ b/NOTICE.md @@ -0,0 +1,5 @@ +Apache OpenWhisk API Gateway +Copyright 2016-2018 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #6: Add NOTICE file to this repo
daisy-ycguo closed pull request #6: Add NOTICE file to this repo URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/6 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.md b/NOTICE.md new file mode 100644 index 000..511e1fd --- /dev/null +++ b/NOTICE.md @@ -0,0 +1,5 @@ +Apache OpenWhisk Runtime PHP +Copyright 2016-2018 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #22: Add the NOTICE file
daisy-ycguo closed pull request #22: Add the NOTICE file URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/22 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.md b/NOTICE.md new file mode 100644 index 000..ad5fa16 --- /dev/null +++ b/NOTICE.md @@ -0,0 +1,5 @@ +Apache OpenWhisk Runtime NodeJS +Copyright 2016-2018 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #18: Add the NOTICE file
daisy-ycguo closed pull request #18: Add the NOTICE file URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/18 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.md b/NOTICE.md new file mode 100644 index 000..59c6d70 --- /dev/null +++ b/NOTICE.md @@ -0,0 +1,5 @@ +Apache OpenWhisk Runtime Docker +Copyright 2016-2018 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #17: Add license notice
daisy-ycguo closed pull request #17: Add license notice URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/17 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.md b/NOTICE.md new file mode 100644 index 000..586a653 --- /dev/null +++ b/NOTICE.md @@ -0,0 +1,5 @@ +Apache OpenWhisk Runtime Java +Copyright 2016-2018 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo closed pull request #230: Add the LICENSE file and NOTICE file
daisy-ycguo closed pull request #230: Add the LICENSE file and NOTICE file URL: https://github.com/apache/incubator-openwhisk-cli/pull/230 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/LICENSE.txt b/LICENSE.txt new file mode 100644 index ..d6456956 --- /dev/null +++ b/LICENSE.txt @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such
[GitHub] rabbah commented on issue #3353: Fix the TLS issue with the CLI download
rabbah commented on issue #3353: Fix the TLS issue with the CLI download URL: https://github.com/apache/incubator-openwhisk/pull/3353#issuecomment-368733349 Thanks @ddragosd this fixes the symptom that I was also observing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd opened a new pull request #3353: Fix the TLS issue with the CLI download
ddragosd opened a new pull request #3353: Fix the TLS issue with the CLI download URL: https://github.com/apache/incubator-openwhisk/pull/3353 Due to https://github.com/blog/2498-weak-cryptographic-standards-removal-notice ansible setup fails with: ``` Failed to validate the SSL certificate for github.com:443...The exception msg was: [SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version ``` This PR provides a workaround for this problem by using `local_action` with `curl -o` to download the CLI. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #3335: Allow container tests to run without a proxy.
ddragosd commented on issue #3335: Allow container tests to run without a proxy. URL: https://github.com/apache/incubator-openwhisk/pull/3335#issuecomment-368728037 ? from me as well. This should make it easier for any new developer. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lionelvillard closed issue #137: Add support for package registry interaction
lionelvillard closed issue #137: Add support for package registry interaction URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/137 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lionelvillard commented on issue #175: Add --save flag to persist defaults into the manifest
lionelvillard commented on issue #175: Add --save flag to persist defaults into the manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/175#issuecomment-368722306 I think we still need the "sync" capability, but it's not critical. I don't think we need a flag. Instead it should be a new command. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lionelvillard commented on issue #186: Proposal: add `keywords` key in `package`
lionelvillard commented on issue #186: Proposal: add `keywords` key in `package` URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/186#issuecomment-368721902 I could be associated to the special package/action tracking deployments. It's not clear to me if this is needed or not. Maybe we should wait and gather more use cases before implementing this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #3346: Integrate kube deployment?
ddragosd commented on issue #3346: Integrate kube deployment? URL: https://github.com/apache/incubator-openwhisk/issues/3346#issuecomment-368721561 ? any thoughts on Apache Mesos ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #760: Pkg tests
mrutkows opened a new pull request #760: Pkg tests URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/760 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new pull request #759: removing support for use-default flag
pritidesai opened a new pull request #759: removing support for use-default flag URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/759 Removing `--use-default` mode and all the code associated to this flag. Its no longer needed and is replaced with managed deployments and export manifest file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang commented on issue #3337: Put active-ack consumers in their own consumer-groups.
ningyougang commented on issue #3337: Put active-ack consumers in their own consumer-groups. URL: https://github.com/apache/incubator-openwhisk/pull/3337#issuecomment-368711811 Oh.good solution, i also found the problem one month again(`cause a rebalancing pause for the other`). but use another solution. anyway, this solution is better. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang commented on issue #3337: Put active-ack consumers in their own consumer-groups.
ningyougang commented on issue #3337: Put active-ack consumers in their own consumer-groups. URL: https://github.com/apache/incubator-openwhisk/pull/3337#issuecomment-368711811 Oh.good solution, i also found the problem one month again. but use another solution. anyway, this solution is better. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #27: Add the NOTICE file
csantanapr closed pull request #27: Add the NOTICE file URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/27 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.md b/NOTICE.md new file mode 100644 index 000..2198613 --- /dev/null +++ b/NOTICE.md @@ -0,0 +1,5 @@ +Apache OpenWhisk Runtime Swift +Copyright 2016-2018 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #3211: implement ContainerFactory.cpuShare to fix #3110
tysonnorris commented on issue #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#issuecomment-368706474 @markusthoemmes this is all fixed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jcrossley3 commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer
jcrossley3 commented on a change in pull request #3338: implement
suspend/resume for KubernetesContainer
URL:
https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r170781626
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient.scala
##
@@ -99,43 +116,139 @@ class KubernetesClient(
}
protected val kubectlCmd = Seq(findKubectlCmd)
- def run(name: String, image: String, args: Seq[String] = Seq.empty[String])(
-implicit transid: TransactionId): Future[ContainerId] = {
-runCmd(Seq("run", name, s"--image=$image") ++ args, timeouts.run)
- .map(_ => ContainerId(name))
- }
+ def run(name: String,
+ image: String,
+ memory: ByteSize = 256.MB,
+ environment: Map[String, String] = Map(),
+ labels: Map[String, String] = Map())(implicit transid:
TransactionId): Future[KubernetesContainer] = {
+
+val envVars = environment.map {
+ case (key, value) => new
EnvVarBuilder().withName(key).withValue(value).build()
+}.toSeq
+
+val pod = new PodBuilder()
+ .withNewMetadata()
+ .withName(name)
+ .addToLabels("name", name)
+ .addToLabels(labels.asJava)
+ .endMetadata()
+ .withNewSpec()
+ .withRestartPolicy("Always")
+ .addNewContainer()
+ .withNewResources()
+ .withLimits(Map("memory" -> new Quantity(memory.toMB + "Mi")).asJava)
+ .endResources()
+ .withName("user-action")
+ .withImage(image)
+ .withEnv(envVars.asJava)
+ .addNewPort()
+ .withContainerPort(8080)
+ .withName("action")
+ .endPort()
+ .endContainer()
+ .endSpec()
+ .build()
+
+kubeRestClient.pods.inNamespace("openwhisk").create(pod)
- def inspectIPAddress(id: ContainerId)(implicit transid: TransactionId):
Future[ContainerAddress] = {
Future {
blocking {
-val pod =
-
kubeRestClient.pods().withName(id.asString).waitUntilReady(timeouts.inspect.length,
timeouts.inspect.unit)
-ContainerAddress(pod.getStatus().getPodIP())
+val createdPod = kubeRestClient.pods
+ .inNamespace("openwhisk")
+ .withName(name)
+ .waitUntilReady(config.timeouts.run.length, config.timeouts.run.unit)
+toContainer(createdPod)
}
}.recoverWith {
case e =>
-log.error(this, s"Failed to get IP of Pod '${id.asString}' within
timeout: ${e.getClass} - ${e.getMessage}")
-Future.failed(new Exception(s"Failed to get IP of Pod
'${id.asString}'"))
+log.error(this, s"Failed create pod for '$name': ${e.getClass} -
${e.getMessage}")
+Future.failed(new Exception(s"Failed to create pod '$name'"))
+}
+ }
+
+ def rm(container: KubernetesContainer)(implicit transid: TransactionId):
Future[Unit] = {
+runCmd(Seq("delete", "--now", "pod", container.id.asString),
config.timeouts.rm).map(_ => ())
+ }
+
+ def rm(key: String, value: String)(implicit transid: TransactionId):
Future[Unit] = {
+if (config.invokerAgent.enabled) {
+ Future {
+blocking {
+ kubeRestClient
+.inNamespace("openwhisk")
Review comment:
And here :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jcrossley3 commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer
jcrossley3 commented on a change in pull request #3338: implement
suspend/resume for KubernetesContainer
URL:
https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r170781549
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient.scala
##
@@ -99,43 +116,139 @@ class KubernetesClient(
}
protected val kubectlCmd = Seq(findKubectlCmd)
- def run(name: String, image: String, args: Seq[String] = Seq.empty[String])(
-implicit transid: TransactionId): Future[ContainerId] = {
-runCmd(Seq("run", name, s"--image=$image") ++ args, timeouts.run)
- .map(_ => ContainerId(name))
- }
+ def run(name: String,
+ image: String,
+ memory: ByteSize = 256.MB,
+ environment: Map[String, String] = Map(),
+ labels: Map[String, String] = Map())(implicit transid:
TransactionId): Future[KubernetesContainer] = {
+
+val envVars = environment.map {
+ case (key, value) => new
EnvVarBuilder().withName(key).withValue(value).build()
+}.toSeq
+
+val pod = new PodBuilder()
+ .withNewMetadata()
+ .withName(name)
+ .addToLabels("name", name)
+ .addToLabels(labels.asJava)
+ .endMetadata()
+ .withNewSpec()
+ .withRestartPolicy("Always")
+ .addNewContainer()
+ .withNewResources()
+ .withLimits(Map("memory" -> new Quantity(memory.toMB + "Mi")).asJava)
+ .endResources()
+ .withName("user-action")
+ .withImage(image)
+ .withEnv(envVars.asJava)
+ .addNewPort()
+ .withContainerPort(8080)
+ .withName("action")
+ .endPort()
+ .endContainer()
+ .endSpec()
+ .build()
+
+kubeRestClient.pods.inNamespace("openwhisk").create(pod)
- def inspectIPAddress(id: ContainerId)(implicit transid: TransactionId):
Future[ContainerAddress] = {
Future {
blocking {
-val pod =
-
kubeRestClient.pods().withName(id.asString).waitUntilReady(timeouts.inspect.length,
timeouts.inspect.unit)
-ContainerAddress(pod.getStatus().getPodIP())
+val createdPod = kubeRestClient.pods
+ .inNamespace("openwhisk")
Review comment:
Here, too
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jcrossley3 commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer
jcrossley3 commented on a change in pull request #3338: implement
suspend/resume for KubernetesContainer
URL:
https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r170781443
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient.scala
##
@@ -99,43 +116,139 @@ class KubernetesClient(
}
protected val kubectlCmd = Seq(findKubectlCmd)
- def run(name: String, image: String, args: Seq[String] = Seq.empty[String])(
-implicit transid: TransactionId): Future[ContainerId] = {
-runCmd(Seq("run", name, s"--image=$image") ++ args, timeouts.run)
- .map(_ => ContainerId(name))
- }
+ def run(name: String,
+ image: String,
+ memory: ByteSize = 256.MB,
+ environment: Map[String, String] = Map(),
+ labels: Map[String, String] = Map())(implicit transid:
TransactionId): Future[KubernetesContainer] = {
+
+val envVars = environment.map {
+ case (key, value) => new
EnvVarBuilder().withName(key).withValue(value).build()
+}.toSeq
+
+val pod = new PodBuilder()
+ .withNewMetadata()
+ .withName(name)
+ .addToLabels("name", name)
+ .addToLabels(labels.asJava)
+ .endMetadata()
+ .withNewSpec()
+ .withRestartPolicy("Always")
+ .addNewContainer()
+ .withNewResources()
+ .withLimits(Map("memory" -> new Quantity(memory.toMB + "Mi")).asJava)
+ .endResources()
+ .withName("user-action")
+ .withImage(image)
+ .withEnv(envVars.asJava)
+ .addNewPort()
+ .withContainerPort(8080)
+ .withName("action")
+ .endPort()
+ .endContainer()
+ .endSpec()
+ .build()
+
+kubeRestClient.pods.inNamespace("openwhisk").create(pod)
Review comment:
I don't love the hardcoded namespace here. If we must have it, can we at
least make it configurable?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #154: container network/dns converted to PureConfig
tysonnorris commented on a change in pull request #154: container network/dns converted to PureConfig URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/154#discussion_r170778534 ## File path: kubernetes/invoker/invoker.yml ## @@ -93,12 +93,12 @@ spec: key: api_host # Docker-related options - - name: "INVOKER_CONTAINER_NETWORK" + - name: "CONFIG_whisk_containerFactory_containerArgs_network" valueFrom: configMapKeyRef: name: invoker.config key: invoker_container_network - - name: "INVOKER_CONTAINER_DNS" + - name: "CONFIG_whisk_containerFactory_containerArgs_dnsServers" valueFrom: configMapKeyRef: name: invoker.config Review comment: Sorry for the delay! I can't tell whether configMapKeyRef will 'do the right thing' here; in this case 'the right thing' may not be obvious, but should be something like: ``` CONFIG_whisk_containerFactory_containerArgs_dnsServers_0=8.8.8.8 CONFIG_whisk_containerFactory_containerArgs_dnsServers_1=8.8.4.4 ``` AFAIK this is the only way to produce an array typed value in lightbend config, and currently this is an array typed value. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new issue #758: Deprecate interactive mode in wskdeploy
pritidesai opened a new issue #758: Deprecate interactive mode in wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/758 We started Whisk Deploy with interactive mode a year back but now, we have come long way from prototyping mode to running in production. As of now, we have no use case for Interactive mode, so from code maintenance perspective, we have decided to deprecate and remove support for interactive mode from Whisk Deploy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #650: Refactor Whisk Deploy errors into new package to avoid cyclic dependencies
pritidesai closed issue #650: Refactor Whisk Deploy errors into new package to avoid cyclic dependencies URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/650 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #634: Support more complex annotations
pritidesai commented on issue #634: Support more complex annotations URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/634#issuecomment-368690226 Lets add a sample manifest with annotations in JSON, Array, etc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new issue #634: Support more complex annotations
pritidesai opened a new issue #634: Support more complex annotations URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/634 Right now we have unit tests and integration tests to validate wskdeploy functionality for simple annotations like: ``` annotations: action_annotation_1: this is annotation 1 action_annotation_2: this is annotation 2 ``` Check if we support arrays and JSON blob in annotations, clarify with @lionelvillard the format of annotations and add support if not supported. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #634: Support more complex annotations
pritidesai commented on issue #634: Support more complex annotations
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/634#issuecomment-368689629
This doc
[here](https://github.com/apache/incubator-openwhisk/blob/master/docs/annotations.md)
specifies different formats of annotations allowed:
```
wsk action create echo echo.js \
-a description 'An action which returns its input. Useful for logging
input to enable debug/replay.' \
-a parameters '[{ "required":false, "description": "Any JSON entity"
}]' \
-a sampleInput '{ "msg": "Five fuzzy felines"}' \
-a sampleOutput '{ "msg": "Five fuzzy felines"}'
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai closed issue #634: Support more complex annotations
pritidesai closed issue #634: Support more complex annotations URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/634 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on a change in pull request #176: Only fetch action code when saving an action
dubeejw commented on a change in pull request #176: Only fetch action code when
saving an action
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/176#discussion_r170769779
##
File path: tests/src/test/scala/system/basic/WskActionTests.scala
##
@@ -230,8 +230,6 @@ abstract class WskActionTests extends TestHelpers with
WskTestHelpers with JsHel
assetHelper.withCleaner(wsk.action, name) { (action, _) =>
action.create(name, Some(TestCLIUtils.getTestActionFilename("empty.js")))
}
-val rr = wsk.action.get(name)
-wsk.parseJsonString(rr.stdout).getFieldPath("exec", "code") shouldBe
Some(JsString(""))
Review comment:
Validation happens above these lines during the create as a 200 status code
is returned. Also there is a REST test here
https://github.com/apache/incubator-openwhisk/blob/master/tests/src/test/scala/system/basic/WskActionTests.scala#L227.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #176: Only fetch action code when saving an action
dubeejw commented on a change in pull request #176: Only fetch action code when
saving an action
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/176#discussion_r170769831
##
File path: tests/src/test/scala/system/basic/WskBasicTests.scala
##
@@ -313,7 +313,7 @@ class WskBasicTests extends TestHelpers with
WskTestHelpers {
wsk.action.get(name, fieldFilter = Some("exec")).stdout should
include(s"""$successMsg""")
wsk.action
.get(name, fieldFilter = Some("exec"))
-.stdout should include regex (s"""$successMsg
exec\n\\{\\s+"kind":\\s+"nodejs:6",\\s+"code":\\s+"\\/\\*\\*[r]*n \\*
Hello, world.[r]*n \\*\\/[r]*nfunction main\\(params\\)
\\{[r]*ngreeting \\= 'hello, ' \\+ params.payload \\+
'!'[r]*nconsole.log\\(greeting\\);[r]*nreturn
\\{payload: greeting\\}[r]*n\\}""")
+.stdout should include regex (s"""$successMsg
exec\n\\{\\s+"kind":\\s+"nodejs:6",\\s+"binary":\\s+false\\s+\\}""")
Review comment:
It's new to the CLI.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on a change in pull request #176: Only fetch action code when saving an action
dubeejw commented on a change in pull request #176: Only fetch action code when
saving an action
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/176#discussion_r170769779
##
File path: tests/src/test/scala/system/basic/WskActionTests.scala
##
@@ -230,8 +230,6 @@ abstract class WskActionTests extends TestHelpers with
WskTestHelpers with JsHel
assetHelper.withCleaner(wsk.action, name) { (action, _) =>
action.create(name, Some(TestCLIUtils.getTestActionFilename("empty.js")))
}
-val rr = wsk.action.get(name)
-wsk.parseJsonString(rr.stdout).getFieldPath("exec", "code") shouldBe
Some(JsString(""))
Review comment:
Validation happens above these lines during the create as a 200 status code
is returned. Also three is a REST test here
https://github.com/apache/incubator-openwhisk/blob/master/tests/src/test/scala/system/basic/WskActionTests.scala#L227.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai closed issue #618: Allow "headless" yaml tree for "projects" (f.k.a. "applications")
pritidesai closed issue #618: Allow "headless" yaml tree for "projects" (f.k.a. "applications") URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/618 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #618: Allow "headless" yaml tree for "projects" (f.k.a. "applications")
pritidesai commented on issue #618: Allow "headless" yaml tree for "projects" (f.k.a. "applications") URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/618#issuecomment-368683853 We do support headless yaml tree such as: ``` packages: package-1: actions: ``` along with: ``` project: name: myProject packages: package-1: actions: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #581: Inconsistent behaviors when "runtime" value is mismatched with function language
pritidesai commented on issue #581: Inconsistent behaviors when "runtime" value is mismatched with function language URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/581#issuecomment-368683167 This was fixed with PR #669. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #577: Colorize Success/Warning/Failure/Status outputs
pritidesai commented on issue #577: Colorize Success/Warning/Failure/Status outputs URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/577#issuecomment-368682528 This is fixed with @mrutkows recent effort on error reporting overhaul. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #26: Switch to Maven based dependency
csantanapr closed pull request #26: Switch to Maven based dependency
URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/26
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/README.md b/README.md
index 558b548..2ae5780 100644
--- a/README.md
+++ b/README.md
@@ -174,7 +174,7 @@ To use as a kind action
wsk action update myAction myAction.swift --kind swift:3.1.1
```
-### Local development
+## Local development
```
./gradlew core:swiftAction:distDocker
```
@@ -208,6 +208,37 @@ ln -s ${ROOTDIR}/ansible/environments/local
${OPENWHISK_HOME}/ansible/environmen
wskdev fresh -t local-swift
```
+### Testing
+Install dependencies from the root directory on $OPENWHISK_HOME repository
+```
+./gradlew :common:scala:install :core:controller:install :core:invoker:install
:tests:install
+```
+
+Using gradle for the ActionContainer tests you need to use a proxy if running
on Mac, if Linux then don't use proxy options
+You can pass the flags `-Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128`
directly in gradle command.
+Or save in your `$HOME/.gradle/gradle.properties`
+```
+systemProp.http.proxyHost=localhost
+systemProp.http.proxyPort=3128
+```
+Using gradle to run all tests
+```
+./gradlew :tests:test
+```
+Using gradle to run some tests
+```
+./gradlew :tests:test --tests *ActionContainerTests*
+```
+Using IntelliJ:
+- Import project as gradle project.
+- Make sure working directory is root of the project/repo
+- Add the following Java VM properties in ScalaTests Run Configuration,
easiest is to change the Defaults for all ScalaTests to use this VM properties
+```
+-Dhttp.proxyHost=localhost
+-Dhttp.proxyPort=3128
+```
+
+ Using container image to test
To use as docker action push to your own dockerhub account
```
docker tag whisk/action-swift-v3.1.1 $user_prefix/action-swift-v3.1.1
diff --git a/settings.gradle b/settings.gradle
index 3ebed6d..6476232 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -1,11 +1,3 @@
-def owPath = System.getenv("OPENWHISK_HOME") ?: '../open'
-def owDirectory = new File(owPath)
-
-include 'common:scala'; project(':common:scala').projectDir = new
File(owDirectory, 'common/scala')
-include 'core:controller'; project(':core:controller').projectDir = new
File(owDirectory, 'core/controller')
-include 'core:invoker'; project(':core:invoker').projectDir = new
File(owDirectory, 'core/invoker')
-include 'whisktests'; project(':whisktests').projectDir = new
File(owDirectory, 'tests')
-
include 'tests'
include 'core:swift3.1.1Action'
@@ -15,6 +7,10 @@ include 'core:swift41Action'
rootProject.name = 'runtime-swift'
+gradle.ext.openwhisk = [
+version: '1.0.0-SNAPSHOT'
+]
+
gradle.ext.scala = [
version: '2.11.8',
compileFlags: ['-feature', '-unchecked', '-deprecation',
'-Xfatal-warnings', '-Ywarn-unused-import']
diff --git a/tests/build.gradle b/tests/build.gradle
index 124229c..3b60d6c 100644
--- a/tests/build.gradle
+++ b/tests/build.gradle
@@ -2,10 +2,9 @@ apply plugin: 'scala'
apply plugin: 'eclipse'
compileTestScala.options.encoding = 'UTF-8'
-evaluationDependsOn(':whisktests')
-
repositories {
mavenCentral()
+mavenLocal()
}
tasks.withType(Test) {
@@ -19,8 +18,8 @@ tasks.withType(Test) {
dependencies {
compile "org.scala-lang:scala-library:${gradle.scala.version}"
-compile project(':whisktests')
-compile project(':whisktests').sourceSets.test.output
+compile
"org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:tests"
+compile
"org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:test-sources"
}
tasks.withType(ScalaCompile) {
diff --git a/tools/travis/build.sh b/tools/travis/build.sh
index f0aa297..7f87bbb 100755
--- a/tools/travis/build.sh
+++ b/tools/travis/build.sh
@@ -11,15 +11,6 @@ export OPENWHISK_HOME=$WHISKDIR
IMAGE_PREFIX="testing"
-# Build runtime
-cd $ROOTDIR
-TERM=dumb ./gradlew \
-:core:swift3.1.1Action:distDocker \
-:core:swift40Action:distDocker \
-:core:swift41Action:distDocker \
--PdockerImagePrefix=${IMAGE_PREFIX}
-
-
# Build OpenWhisk
cd $WHISKDIR
@@ -31,6 +22,16 @@ docker tag openwhisk/invoker ${IMAGE_PREFIX}/invoker
docker pull openwhisk/nodejs6action
docker tag openwhisk/nodejs6action ${IMAGE_PREFIX}/nodejs6action
+TERM=dumb ./gradlew \
+:common:scala:install \
+:core:controller:install \
+:core:invoker:install \
+:tests:install
-
-
+# Build runtime
+cd $ROOTDIR
+TERM=dumb ./gradlew \
+:core:swift3.1.1Action:distDocker \
+:core:swift40Action:distDocker \
+:core:swift41Action:distDocker \
+-PdockerImagePrefix=${IMAGE_PREFIX}
This is an automated message from the Apache Git Service.
To respond to the message,
[GitHub] csantanapr commented on a change in pull request #3352: API GW doc update to include path parameter example
csantanapr commented on a change in pull request #3352: API GW doc update to
include path parameter example
URL:
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r170764745
##
File path: docs/apigateway.md
##
@@ -104,52 +103,61 @@ You have a series of actions to implement your backend
for the book club:
| putBooks| PUT | updates book details |
| deleteBooks | DELETE | deletes a book |
-Let's create an API for the book club, named `Book Club`, with `/club` as its
HTTP URL base path and `books` as its resource.
+Let's create an API for the book club, named `Book Club`, with `/club` as its
HTTP URL base path and `books` as its resource and `{isbn}` as a path parameter
used to identify a specific book by its ISBN.
+
+When using path parameters, the API must be defined with a response type of
`http`, and the path, including the actual path parameter value(s), will be
available in the `__ow_path` field of the action's JSON parameter.
```
-wsk api create -n "Book Club" /club /books get getBooks --response-type http
-wsk api create /club /books post postBooks --response-type http
-wsk api create /club /books put putBooks--response-type http
-wsk api create /club /books delete deleteBooks --response-type http
+wsk api create -n "Book Club" /club /books/{isbn} get getBooks --response-type
http
+wsk api create /club /books get getBooks --response-type
http
+wsk api create /club /books post postBooks --response-type
http
Review comment:
Make `post` use path param so you can use later in create new book
`/books/{isbn} post postBooks`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3352: API GW doc update to include path parameter example
csantanapr commented on a change in pull request #3352: API GW doc update to
include path parameter example
URL:
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r170764261
##
File path: docs/apigateway.md
##
@@ -104,52 +103,61 @@ You have a series of actions to implement your backend
for the book club:
| putBooks| PUT | updates book details |
| deleteBooks | DELETE | deletes a book |
-Let's create an API for the book club, named `Book Club`, with `/club` as its
HTTP URL base path and `books` as its resource.
+Let's create an API for the book club, named `Book Club`, with `/club` as its
HTTP URL base path and `books` as its resource and `{isbn}` as a path parameter
used to identify a specific book by its ISBN.
+
+When using path parameters, the API must be defined with a response type of
`http`, and the path, including the actual path parameter value(s), will be
available in the `__ow_path` field of the action's JSON parameter.
```
-wsk api create -n "Book Club" /club /books get getBooks --response-type http
-wsk api create /club /books post postBooks --response-type http
-wsk api create /club /books put putBooks--response-type http
-wsk api create /club /books delete deleteBooks --response-type http
+wsk api create -n "Book Club" /club /books/{isbn} get getBooks --response-type
http
+wsk api create /club /books get getBooks --response-type
http
+wsk api create /club /books post postBooks --response-type
http
+wsk api create /club /books/{isbn} put putBooks--response-type
http
+wsk api create /club /books/{isbn} delete deleteBooks --response-type
http
```
Notice that the first action exposed with base path `/club` gets the API label
with name `Book Club` any other actions exposed under `/club` will be
associated with `Book Club`
Let's list all the actions that we just exposed.
```
-wsk api list -f
+wsk api list /club -f
```
```
ok: APIs
+Action: getBooks
+ API Name: Book Club
+ Base path: /club
+ Path: /books/{isbn}
+ Verb: get
+ URL: https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books/{isbn}
Action: getBooks
API Name: Book Club
Base path: /club
Path: /books
Verb: get
- URL: https://${APIHOST}:9001/api/21ef035/club/books
+ URL: https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
Action: postBooks
API Name: Book Club
Base path: /club
Path: /books
Verb: post
- URL: https://${APIHOST}:9001/api/21ef035/club/books
+ URL: https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
Action: putBooks
API Name: Book Club
Base path: /club
- Path: /books
+ Path: /books/{isbn}
Verb: put
- URL: https://${APIHOST}:9001/api/21ef035/club/books
+ URL: https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books/{isbn}
Action: deleteBooks
API Name: Book Club
Base path: /club
- Path: /books
+ Path: /books/{isbn}
Verb: delete
- URL: https://${APIHOST}:9001/api/21ef035/club/books
+ URL: https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books/{isbn}
```
Now just for fun let's add a new book `JavaScript: The Good Parts` with a HTTP
__POST__
```
-curl -X POST -d '{"name":"JavaScript: The Good Parts",
"isbn":"978-0596517748"}' https://${APIHOST}:9001/api/21ef035/club/books
+curl -X POST -d '{"name":"JavaScript: The Good Parts",
"isbn":"978-0596517748"}' -H "Content-Type: application/json"
https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
Review comment:
For creating a new book use path parameter, I think that's the value add of
using path param
```
curl -X POST -d '{"name":"JavaScript: The Good Parts"}' -H "Content-Type:
application/json"
"https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books/978-0596517748;
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3352: API GW doc update to include path parameter example
csantanapr commented on a change in pull request #3352: API GW doc update to
include path parameter example
URL:
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r170764964
##
File path: docs/apigateway.md
##
@@ -209,8 +224,9 @@ wsk api list /club
```
ok: apis
ActionVerb API NameURL
-getBooks get Book Club
https://${APIHOST}:9001/api/21ef035/club/books
-postBooks post Book Club
https://${APIHOST}:9001/api/21ef035/club/books
-putBooks put Book Club
https://${APIHOST}:9001/api/21ef035/club/books
-deleteBooks delete Book Club
https://${APIHOST}:9001/api/21ef035/club/books
+getBooks get Book Club
https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+postBooks post Book Club
https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
Review comment:
same here have `post` have path param `/books/{isbn}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3352: API GW doc update to include path parameter example
csantanapr commented on a change in pull request #3352: API GW doc update to
include path parameter example
URL:
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r170763683
##
File path: docs/apigateway.md
##
@@ -104,52 +103,61 @@ You have a series of actions to implement your backend
for the book club:
| putBooks| PUT | updates book details |
| deleteBooks | DELETE | deletes a book |
-Let's create an API for the book club, named `Book Club`, with `/club` as its
HTTP URL base path and `books` as its resource.
+Let's create an API for the book club, named `Book Club`, with `/club` as its
HTTP URL base path and `books` as its resource and `{isbn}` as a path parameter
used to identify a specific book by its ISBN.
+
+When using path parameters, the API must be defined with a response type of
`http`, and the path, including the actual path parameter value(s), will be
available in the `__ow_path` field of the action's JSON parameter.
Review comment:
Add something that shows an example of what the actual value of `__ow_path`
would be is not clear if it's going to include everything or just the last
portion, I just tested this and it looks ls the last portion,
__For example if the api is call with
`https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books/123-abc` the value
of `__ow_path` will be `/club/books/123-abc`__
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3352: API GW doc update to include path parameter example
csantanapr commented on a change in pull request #3352: API GW doc update to
include path parameter example
URL:
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r170761652
##
File path: docs/apigateway.md
##
@@ -57,21 +57,20 @@ Follow the instructions in [Configure
CLI](./README.md#setting-up-the-openwhisk-
The `--response-type` flag controls the target URL of the web action to be
proxied by the API Gateway. Using `--response-type json` as above returns the
full result of the action in JSON format and automatically sets the
Content-Type header to `application/json` which enables you to easily get
started.
- Once you get started, you will want to have full control over the HTTP
response properties like `statusCode`, `headers` and return different content
types in the `body`. You can do this by using `--response-type http`, this will
configure the target URL of the web action with the `http` extension.
+ Once you get started, you will want to have full control over the HTTP
response properties like `statusCode` and `headers`, and you may want to return
different content types in the `body`. You can do this by using
`--response-type http`, this will configure the target URL of the web action
with the `http` extension.
You can choose to change the code of the action to comply with the return of
web actions with `http` extension or include the action in a sequence passing
its result to a new action that transforms the result to be properly formatted
for an HTTP response. You can read more about response types and web actions
extensions in the [Web Actions](webactions.md) documentation.
Change the code for the `hello.js` returning the JSON properties `body`,
`statusCode` and `headers`
```javascript
function main({name:name='Serverless API'}) {
return {
-body: new Buffer(JSON.stringify({payload:`Hello world
${name}`})).toString('base64'),
+body: {payload:`Hello world ${name}`},
Review comment:
Thanks +1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai commented on issue #337: support more various manifest file names.
pritidesai commented on issue #337: support more various manifest file names. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/337#issuecomment-368680904 We do support various manifest and deployment file names, outside of most used `manifest.yaml` and `deployment.yaml`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #337: support more various manifest file names.
pritidesai closed issue #337: support more various manifest file names. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/337 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #2833: MesosContainerFactory
tysonnorris commented on a change in pull request #2833: MesosContainerFactory
URL:
https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r170763841
##
File path:
common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.mesos
+
+import akka.actor.ActorRef
+import akka.actor.ActorSystem
+import akka.pattern.ask
+import com.adobe.api.platform.runtime.mesos.MesosClient
+import com.adobe.api.platform.runtime.mesos.Subscribe
+import com.adobe.api.platform.runtime.mesos.SubscribeComplete
+import com.adobe.api.platform.runtime.mesos.Teardown
+import java.time.Instant
+import pureconfig.loadConfigOrThrow
+import scala.concurrent.Await
+import scala.concurrent.ExecutionContext
+import scala.concurrent.Future
+import scala.concurrent.TimeoutException
+import scala.concurrent.duration._
+import scala.util.Try
+import whisk.common.Counter
+import whisk.common.Logging
+import whisk.common.TransactionId
+import whisk.core.ConfigKeys
+import whisk.core.WhiskConfig
+import whisk.core.containerpool.Container
+import whisk.core.containerpool.ContainerArgsConfig
+import whisk.core.containerpool.ContainerFactory
+import whisk.core.containerpool.ContainerFactoryProvider
+import whisk.core.entity.ByteSize
+import whisk.core.entity.ExecManifest
+import whisk.core.entity.InstanceId
+import whisk.core.entity.UUID
+
+/**
+ * Configuration for MesosClient
+ * @param masterUrl The mesos url e.g. http://leader.mesos:5050.
+ * @param masterPublicUrl A public facing mesos url (which may be different
that the internal facing url) e.g. http://mymesos:5050.
+ * @param role The role used by this framework (see
http://mesos.apache.org/documentation/latest/roles/#associating-frameworks-with-roles).
+ * @param failoverTimeoutSeconds Timeout allowed for framework to reconnect
after disconnection.
+ * @param mesosLinkLogMessage If true, display a link to mesos in the static
log message, otherwise do not include a link to mesos.
+ */
+case class MesosConfig(masterUrl: String,
+ masterPublicUrl: Option[String] = None,
+ role: String = "*",
+ failoverTimeoutSeconds: FiniteDuration = 0.seconds,
+ mesosLinkLogMessage: Boolean = true)
+
+class MesosContainerFactory(config: WhiskConfig,
+actorSystem: ActorSystem,
+logging: Logging,
+parameters: Map[String, Set[String]],
+containerArgs: ContainerArgsConfig =
+
loadConfigOrThrow[ContainerArgsConfig](ConfigKeys.containerArgs),
+mesosConfig: MesosConfig =
loadConfigOrThrow[MesosConfig](ConfigKeys.mesos),
+clientFactory: (ActorSystem, MesosConfig) =>
ActorRef = MesosContainerFactory.createClient,
+taskIdGenerator: () => String =
MesosContainerFactory.taskIdGenerator)
+extends ContainerFactory {
+
+ val subscribeTimeout = 10.seconds
+ val teardownTimeout = 30.seconds
+
+ //init mesos framework:
+ implicit val as: ActorSystem = actorSystem
+ implicit val ec: ExecutionContext = actorSystem.dispatcher
+
+ //mesos master url to subscribe the framework to
+ val mesosMaster = mesosConfig.masterUrl
+ //public mesos url where developers can browse logs (till there is way to
delegate log retrieval to an external system)
+ val mesosMasterPublic = mesosConfig.masterPublicUrl
+
+ val mesosClientActor = clientFactory(as, mesosConfig)
+
+ subscribe()
Review comment:
Mesos tasks can be submitted to the client even if the client is not yet
subscribed. Regardless of subscription status, submitting a task to mesos is an
async process anyways (framework must wait for offers that have required
resources before any launch can be issued). The offer handling may be tuned at
the mesos-actor config in the future, e.g. to allow "holding" offers, instead
of immediately accepting/declining them, to optimize for cases where no task is
queued at offer receipt time, but an task arrives shortly
[GitHub] mdeuser commented on issue #3351: Fix intermitent test failures due to non-unique entity names
mdeuser commented on issue #3351: Fix intermitent test failures due to non-unique entity names URL: https://github.com/apache/incubator-openwhisk/pull/3351#issuecomment-368680572 pg4/1417 in progress This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #335: delete dead code verifier.go
pritidesai commented on issue #335: delete dead code verifier.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/335#issuecomment-368680188 `verifier.go` no longer exists, was deleted as part of PR #698. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #335: delete dead code verifier.go
pritidesai closed issue #335: delete dead code verifier.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/335 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #2833: MesosContainerFactory
tysonnorris commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r170762841 ## File path: common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.core.mesos + +import akka.actor.ActorRef +import akka.actor.ActorSystem +import akka.pattern.ask +import com.adobe.api.platform.runtime.mesos.MesosClient +import com.adobe.api.platform.runtime.mesos.Subscribe +import com.adobe.api.platform.runtime.mesos.SubscribeComplete +import com.adobe.api.platform.runtime.mesos.Teardown +import java.time.Instant +import pureconfig.loadConfigOrThrow +import scala.concurrent.Await +import scala.concurrent.ExecutionContext +import scala.concurrent.Future +import scala.concurrent.TimeoutException +import scala.concurrent.duration._ +import scala.util.Try +import whisk.common.Counter +import whisk.common.Logging +import whisk.common.TransactionId +import whisk.core.ConfigKeys +import whisk.core.WhiskConfig +import whisk.core.containerpool.Container +import whisk.core.containerpool.ContainerArgsConfig +import whisk.core.containerpool.ContainerFactory +import whisk.core.containerpool.ContainerFactoryProvider +import whisk.core.entity.ByteSize +import whisk.core.entity.ExecManifest +import whisk.core.entity.InstanceId +import whisk.core.entity.UUID + +/** + * Configuration for MesosClient + * @param masterUrl The mesos url e.g. http://leader.mesos:5050. + * @param masterPublicUrl A public facing mesos url (which may be different that the internal facing url) e.g. http://mymesos:5050. + * @param role The role used by this framework (see http://mesos.apache.org/documentation/latest/roles/#associating-frameworks-with-roles). + * @param failoverTimeoutSeconds Timeout allowed for framework to reconnect after disconnection. + * @param mesosLinkLogMessage If true, display a link to mesos in the static log message, otherwise do not include a link to mesos. + */ +case class MesosConfig(masterUrl: String, + masterPublicUrl: Option[String] = None, + role: String = "*", + failoverTimeoutSeconds: FiniteDuration = 0.seconds, + mesosLinkLogMessage: Boolean = true) Review comment: It seems weird to have a bunch of unused configs there - e.g. defaults configs that are not used by the default spi impl. But I see that kube has started doing that, so if other impls are going to have actual defaults (even when they are not in use) I can put the mesos ones there as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #323: Delete unused marshal and unmarshal methods from manifest_parser.go
pritidesai commented on issue #323: Delete unused marshal and unmarshal methods from manifest_parser.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/323#issuecomment-368679403 No longer applicable see PR #642 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #321: Delete unused ComposeWskAction from Manifest Parser
pritidesai closed issue #321: Delete unused ComposeWskAction from Manifest Parser URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/321 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #321: Delete unused ComposeWskAction from Manifest Parser
pritidesai commented on issue #321: Delete unused ComposeWskAction from Manifest Parser URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/321#issuecomment-368678553 Yup, `ComposeWskAction` is no longer there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #208: Provide a way to deploy actions already deployed.
pritidesai commented on issue #208: Provide a way to deploy actions already deployed. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/208#issuecomment-368677907 @mrutkows is this still pending after adding managed deployments? Managed deployment addresses updates in manifest file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #186: Proposal: add `keywords` key in `package`
pritidesai commented on issue #186: Proposal: add `keywords` key in `package` URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/186#issuecomment-368677217 @lionelvillard as part of this enhancement, after we add `keywords` in `package`, how can the value of `keywords` be associated with deployed package, annotations? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser opened a new pull request #3352: API GW doc update to include path parameter example
mdeuser opened a new pull request #3352: API GW doc update to include path parameter example URL: https://github.com/apache/incubator-openwhisk/pull/3352 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #175: Add --save flag to persist defaults into the manifest
pritidesai commented on issue #175: Add --save flag to persist defaults into the manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/175#issuecomment-368676408 Hi @lionelvillard after adding managed deployments, do we still need support for these different flags? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #234: Support concept of modular projects in deployment.yaml
pritidesai closed issue #234: Support concept of modular projects in deployment.yaml URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/234 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #234: Support concept of modular projects in deployment.yaml
pritidesai commented on issue #234: Support concept of modular projects in deployment.yaml URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/234#issuecomment-368675803 With PR #519, we added support for `packages` such as: ``` packages: package-1: actions: action-1: ... package-2: actions: action-2: ... package-3: actions: action-3: ... ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #137: Add support for package registry interaction
pritidesai commented on issue #137: Add support for package registry interaction URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/137#issuecomment-368672176 @lionelvillard is this still relevant? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #2992: create SPI for SeedNodesProvider; MarathonSeedNodesProvider to provid?
tysonnorris commented on issue #2992: create SPI for SeedNodesProvider; MarathonSeedNodesProvider to provid? URL: https://github.com/apache/incubator-openwhisk/pull/2992#issuecomment-368670562 Will review in context of mesos HA controller deployment. If this shared data aspect is going away, it can become embedded into mesos support for special purpose there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #122: Implement namespace swap command
pritidesai closed issue #122: Implement namespace swap command URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/122 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #122: Implement namespace swap command
pritidesai commented on issue #122: Implement namespace swap command URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/122#issuecomment-368670145 We have a way to specify which `namespace` should have all the entities deployed on command line using `--namespace`. Also, namespace is read in the following precedence order: (1) wskdeploy command line `wskdeploy --apihost --namespace --auth` (2) deployment file (3) manifest file (4) .wskprops Closing this issue as this feature is supported in Whisk Deploy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new issue #757: Managed Deployments (Project Sync)
pritidesai opened a new issue #757: Managed Deployments (Project Sync) URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/757 This epic is created to track issues and enhancements regarding managed deployments of Whisk Deploy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new issue #756: API Gateway
pritidesai opened a new issue #756: API Gateway URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/756 This epic is created to track API Gateway related issues, features, and enhancements in Whisk Deploy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #739: Missing NOTICE file
pritidesai commented on issue #739: Missing NOTICE file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/739#issuecomment-368666153 Hi @houshengbo, did we address this issue with your PR #753 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #740: Segfault when root package is not defined
pritidesai closed issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #740: Segfault when root package is not defined
pritidesai commented on issue #740: Segfault when root package is not defined URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/740#issuecomment-368665452 Please refer to my previous comment, (fixed with PR #744), closing this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3338: implement suspend/resume for KubernetesContainer
dgrove-oss commented on issue #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#issuecomment-368649095 rebased to latest master and consolidated small commits made while addressing review comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw closed pull request #251: More test improvements
dubeejw closed pull request #251: More test improvements
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/251
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/src/test/scala/system/health/BasicHealthTest.scala
b/tests/src/test/scala/system/health/BasicHealthTest.scala
index 52b176d..02183d2 100644
--- a/tests/src/test/scala/system/health/BasicHealthTest.scala
+++ b/tests/src/test/scala/system/health/BasicHealthTest.scala
@@ -87,8 +87,14 @@ class BasicHealthTest
activation =>
// should be successful
activation.response.success shouldBe true
+
+ // It takes a moment for the consumer to fully initialize.
+ println("Giving the consumer a moment to get ready")
+ Thread.sleep(consumerInitTime)
+
val uuid =
activation.response.result.get.fields.get("uuid").get.toString().replaceAll("\"",
"")
+ println("Checking health endpoint(s) for existence of consumer uuid")
// get /health endpoint(s) and ensure it contains the new uuid
val healthUrls =
System.getProperty("health_url").split("\\s*,\\s*").filterNot(_.isEmpty)
healthUrls shouldNot be(empty)
@@ -111,7 +117,7 @@ class BasicHealthTest
uuids should contain(uuid)
- }, N = 3, waitBeforeRetry = Some(1.second))
+ }, N = 10, waitBeforeRetry = Some(1.second))
}
}
diff --git a/tests/src/test/scala/system/packages/MessageHubProduceTests.scala
b/tests/src/test/scala/system/packages/MessageHubProduceTests.scala
index eb4bcd1..3c2aac8 100644
--- a/tests/src/test/scala/system/packages/MessageHubProduceTests.scala
+++ b/tests/src/test/scala/system/packages/MessageHubProduceTests.scala
@@ -200,7 +200,7 @@ class MessageHubProduceTests
// verify trigger fired
println("Polling for activations")
val activations = wsk.activation.pollFor(N = 1, Some(triggerName),
retries = maxRetries)
-assert(activations.length == 1)
+assert(activations.length > 0)
val matchingActivations = for {
id <- activations
@@ -269,7 +269,7 @@ class MessageHubProduceTests
// verify trigger fired
println("Polling for activations")
val activations = wsk.activation.pollFor(N = 1, Some(triggerName),
retries = maxRetries)
-assert(activations.length == 1)
+assert(activations.length > 0)
val matchingActivations = for {
id <- activations
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mdeuser opened a new pull request #3351: Fix intermitent test failures due to non-unique entity names
mdeuser opened a new pull request #3351: Fix intermitent test failures due to non-unique entity names URL: https://github.com/apache/incubator-openwhisk/pull/3351 - leverage the `withTimestamp` method in a few more tests - move `withTimestamp` into common module and remove copies This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #259: Update CURL Tests
dubeejw commented on issue #259: Update CURL Tests
URL:
https://github.com/apache/incubator-openwhisk-catalog/pull/259#issuecomment-368636268
Could be a DNS problem
`packages.samples.CurlTest.samples curl should Return Could not resolve host
when sending no parameter`
```
org.scalatest.exceptions.TestFailedException: "{"msg":" % Total%
Received % Xferd Average Speed TimeTime Time Current\n
Dload Upload Total SpentLeft Speed\n\r 0 0
0 00 0 0 0 --:--:-- --:--:-- --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- --:--:-- --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:01 --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:02 --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:04 --:--:-- 0\ncurl: (28)
Resolving timed out after 3513 milliseconds\n"}" did not include substring
"Could not resolve host"
```
Note `Resolving timed out after 3513 milliseconds`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai opened a new issue #755: Whisk Deploy Export Functionality
pritidesai opened a new issue #755: Whisk Deploy Export Functionality URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/755 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubeejw commented on issue #259: Update CURL Tests
dubeejw commented on issue #259: Update CURL Tests
URL:
https://github.com/apache/incubator-openwhisk-catalog/pull/259#issuecomment-368636268
Could be a DNS problem
`packages.samples.CurlTest.samples curl should Return Could not resolve host
when sending no parameter`
```
org.scalatest.exceptions.TestFailedException: "{"msg":" % Total%
Received % Xferd Average Speed TimeTime Time Current\n
Dload Upload Total SpentLeft Speed\n\r 0 0
0 00 0 0 0 --:--:-- --:--:-- --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- --:--:-- --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:01 --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:02 --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:04 --:--:-- 0\ncurl: (28)
Resolving timed out after 3513 milliseconds\n"}" did not include substring
"Could not resolve host"
```
Note `Could not resolve host`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on issue #259: Update CURL Tests
dubeejw commented on issue #259: Update CURL Tests
URL:
https://github.com/apache/incubator-openwhisk-catalog/pull/259#issuecomment-368636268
Could be a DNS problem
`packages.samples.CurlTest.samples curl should Return Could not resolve host
when sending no parameter`
```
org.scalatest.exceptions.TestFailedException: "{"msg":" % Total%
Received % Xferd Average Speed TimeTime Time Current\n
Dload Upload Total SpentLeft Speed\n\r 0 0
0 00 0 0 0 --:--:-- --:--:-- --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- --:--:-- --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:01 --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:02 --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:04 --:--:-- 0\ncurl: (28)
Resolving timed out after 3513 milliseconds\n"}" did not include substring
"Could not resolve host"
```
Note `Could not resolve host.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubeejw commented on issue #259: Update CURL Tests
dubeejw commented on issue #259: Update CURL Tests
URL:
https://github.com/apache/incubator-openwhisk-catalog/pull/259#issuecomment-368636268
Could be a DNS problem
`packages.samples.CurlTest.samples curl should Return Could not resolve host
when sending no parameter`
```
org.scalatest.exceptions.TestFailedException: "{"msg":" % Total%
Received % Xferd Average Speed TimeTime Time Current\n
Dload Upload Total SpentLeft Speed\n\r 0 0
0 00 0 0 0 --:--:-- --:--:-- --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- --:--:-- --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:01 --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:02 --:--:-- 0\r 0 0
0 00 0 0 0 --:--:-- 0:00:04 --:--:-- 0\ncurl: (28)
Resolving timed out after 3513 milliseconds\n"}" did not include substring
"Could not resolve host"
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] beemarie opened a new issue #21: Defect: When a non preinstalled is run after preinstalled, the directory for preinstalled is deleted.
beemarie opened a new issue #21: Defect: When a non preinstalled is run after preinstalled, the directory for preinstalled is deleted. URL: https://github.com/apache/incubator-openwhisk-package-deploy/issues/21 Solution: we only want to delete the TMP directory for non preinstalled repos. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beemarie opened a new pull request #20: defect for delete of preinstalled directory
beemarie opened a new pull request #20: defect for delete of preinstalled directory URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/20 This PR includes: - updates for the delete of preinstalled directory (in both deploy & deployWeb) - required updates for deploy tests. - some formatting issues. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd closed pull request #97: Added maven archetype for Java Action
ddragosd closed pull request #97: Added maven archetype for Java Action
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/97
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
index 9e9a503..24ad037 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,3 +4,4 @@ openwhisk-master*
*.iml
.idea
.vscode
+**/.sts4-cache
diff --git a/.travis.yml b/.travis.yml
index 1d678b6..c3eaff3 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,6 +5,7 @@ env:
- DOCKER_COMPOSE_VERSION: 1.13.0
matrix:
- TOOL: docker-compose
+- TOOL: java-action-archetype
services:
- docker
diff --git a/java-action-archetype/.editorconfig
b/java-action-archetype/.editorconfig
new file mode 100644
index 000..3e5b662
--- /dev/null
+++ b/java-action-archetype/.editorconfig
@@ -0,0 +1,25 @@
+# EditorConfig is awesome: http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# Unix-style newlines with a newline ending every file
+[*]
+end_of_line = lf
+insert_final_newline = false
+
+# Matches multiple files with brace expansion notation
+# Set default charset
+[*.{java}]
+charset = utf-8
+
+# 4 space indentation
+[*.java]
+indent_style = space
+indent_size = 2
+insert_final_newline = true
+
+# Indentation style for yaml, yml
+[*.{js,xml,html,json,yaml,yml}]
+indent_style = space
+indent_size = 2
\ No newline at end of file
diff --git a/java-action-archetype/.gitignore b/java-action-archetype/.gitignore
new file mode 100644
index 000..1de5659
--- /dev/null
+++ b/java-action-archetype/.gitignore
@@ -0,0 +1 @@
+target
\ No newline at end of file
diff --git a/java-action-archetype/.travis/build.sh
b/java-action-archetype/.travis/build.sh
new file mode 100755
index 000..d29d3fc
--- /dev/null
+++ b/java-action-archetype/.travis/build.sh
@@ -0,0 +1,10 @@
+#!/bin/bash
+
+SCRIPTDIR=$(cd $(dirname "$0") && pwd)
+TOOLDIR="$SCRIPTDIR/../"
+
+cd $TOOLDIR
+
+mvn -V test
+
+#TODO steps that can push this artifact to nexus
diff --git a/java-action-archetype/.travis/setup.sh
b/java-action-archetype/.travis/setup.sh
new file mode 100755
index 000..f2c7951
--- /dev/null
+++ b/java-action-archetype/.travis/setup.sh
@@ -0,0 +1,10 @@
+#!/bin/bash
+set -x -e
+uname -sm
+
+SCRIPTDIR=$(cd $(dirname "$0") && pwd)
+TOOLDIR="$SCRIPTDIR/../"
+
+cd $TOOLDIR
+
+mvn -DskipTests=true -Dmaven.javadoc.skip=true -B -V clean install
diff --git a/java-action-archetype/README.md b/java-action-archetype/README.md
new file mode 100644
index 000..67bf3da
--- /dev/null
+++ b/java-action-archetype/README.md
@@ -0,0 +1,39 @@
+# Maven Archetype for Java Action
+
+This archetype helps to generate the Java Action template project.
+
+## Pre-requisite
+
+The following softwares are required to build and deploy a Java Action to
OpenWhisk:
+
+* (Maven v3.3.x)[https://maven.apache.org] or above
+* Java 8 or above
+
+[WSK
CLI](https://github.com/apache/incubator-openwhisk/blob/master/docs/cli.md) is
configured
+
+## Generate project
+
+```sh
+mvn archetype:generate \
+ -DarchetypeGroupId=org.apache.openwhisk.java \
+ -DarchetypeArtifactId=java-action-archetype \
+ -DarchetypeVersion=1.0-SNAPSHOT \
+ -DgroupId=com.example \
+ -DartifactId=demo-function
+```
+
+## Deploying function to OpenWhisk
+
+The following step shows how to deploy the function to OpenWhisk
+
+```sh
+cd demo-function
+mvn clean install
+wsk action create demo target/demo-function.jar --main com.example.FunctionApp
+```
+
+After successful deployment of the function, we can invoke the same via `wsk
action invoke demo --result` to see the response as:
+
+```json
+{"greetings": "Hello! Welcome to OpenWhisk" }
+```
\ No newline at end of file
diff --git a/java-action-archetype/pom.xml b/java-action-archetype/pom.xml
new file mode 100644
index 000..badbf92
--- /dev/null
+++ b/java-action-archetype/pom.xml
@@ -0,0 +1,28 @@
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;>
+ 4.0.0
+ org.apache.openwhisk.java
+ java-action-archetype
+ 1.0-SNAPSHOT
+ maven-archetype
+ OpenWhisk:: Maven Archetype - Java Action
+ http://openwhisk.apache.org
+
+
+
+org.apache.maven.archetype
+archetype-packaging
+3.0.1
+
+
+
+
+
+ maven-archetype-plugin
+ 3.0.1
+
+
+
+
+
\ No newline at end of file
diff --git
a/java-action-archetype/src/main/resources/META-INF/maven/archetype.xml
b/java-action-archetype/src/main/resources/META-INF/maven/archetype.xml
new file mode 100644
index 000..065922a
--- /dev/null
+++
[GitHub] pritidesai commented on issue #742: Add top level package definition and it ignores packages
pritidesai commented on issue #742: Add top level package definition and it ignores packages URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/742#issuecomment-368632034 With @mrutkows recent changes, top level `package` definition is now not supported and reported as fatal error: `manifest.yaml`: ``` package: name: test packages: IntegrationTestHelloWorld: actions: # helloworld action in NodeJS helloNodejs: function: actions/hello.js runtime: nodejs:6 inputs: name: type: string description: name of a person place: type: string description: location of a person outputs: payload: type: string description: a simple greeting message, Hello World! ``` ``` ./wskdeploy -m manifest.yaml Info: The API host is [openwhisk.ng.bluemix.net], from .wskprops. Info: The auth key is set, from .wskprops. Info: The namespace is [_], from .wskprops. Info: The apigw access token is set, from .wskprops. Info: Unmarshal OpenWhisk runtimes from internet at https://openwhisk.ng.bluemix.net. Error: manifest_parser.go [104]: [ERROR_YAML_PARSER_ERROR]: File: [manifest.yaml]: ==> yaml: unmarshal errors: ==> line 17: field package not found in struct parsers.YAML ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #742: Add top level package definition and it ignores packages
pritidesai closed issue #742: Add top level package definition and it ignores packages URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/742 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed pull request #753: Add the empty NOTICE for further development
pritidesai closed pull request #753: Add the empty NOTICE for further development URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/753 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.md b/NOTICE.md new file mode 100644 index ..3b2d6685 --- /dev/null +++ b/NOTICE.md @@ -0,0 +1,5 @@ +Apache OpenWhisk Wskdeploy +Copyright 2016-2018 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on a change in pull request #259: Update CURL Tests
houshengbo commented on a change in pull request #259: Update CURL Tests
URL:
https://github.com/apache/incubator-openwhisk-catalog/pull/259#discussion_r170714130
##
File path: tests/src/test/scala/packages/samples/CurlTest.scala
##
@@ -34,17 +37,27 @@ class CurlTest extends TestHelpers with WskTestHelpers {
it should "Return Could not resolve host when sending no parameter" in {
val expectedError = "Could not resolve host"
-val run = wsk.action.invoke(greetingAction, Map())
-withActivation(wsk.activation, run) {
-_.response.result.get.toString should include(expectedError)
-}
+
+retry(
+{
+val run = wsk.action.invoke(greetingAction, Map())
+withActivation(wsk.activation, run) {
+_.response.result.get.toString should
include(expectedError)
+}
+})
}
it should "Return the web content when sending the public google as the
payload" in {
val expectedBody = ""
-val run = wsk.action.invoke(greetingAction, Map("payload" ->
"google.com".toJson))
-withActivation(wsk.activation, run) {
-_.response.result.get.toString should include(expectedBody)
-}
+val host = WhiskProperties.getEdgeHost
Review comment:
The purpose of this curl test is to see if curl action can reach out to the
public website, like google. If we use edge node, there is no meaning the test
against a local node.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houshengbo opened a new pull request #18: Add the NOTICE file
houshengbo opened a new pull request #18: Add the NOTICE file URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #3339: Add the NOTICE file for future development
csantanapr closed pull request #3339: Add the NOTICE file for future development URL: https://github.com/apache/incubator-openwhisk/pull/3339 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/NOTICE.md b/NOTICE.md new file mode 100644 index 00..e6d7bdb961 --- /dev/null +++ b/NOTICE.md @@ -0,0 +1,5 @@ +Apache OpenWhisk +Copyright 2016-2018 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #27: Add the NOTICE file
houshengbo opened a new pull request #27: Add the NOTICE file URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #6: Add NOTICE file to this repo
houshengbo opened a new pull request #6: Add NOTICE file to this repo URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #8: Add the NOTICE file
houshengbo opened a new pull request #8: Add the NOTICE file URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
