[GitHub] Param-S commented on issue #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions
Param-S commented on issue #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/24#issuecomment-374488571 @jonpspri which testcase fails with the latest Docker image. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
chetanmeh commented on issue #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#issuecomment-374475817 Updated the readme based on review feedback. Future PR would not miss on the dots ... :dart: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3083: allow parent/child transaction ids
rabbah commented on issue #3083: allow parent/child transaction ids URL: https://github.com/apache/incubator-openwhisk/issues/3083#issuecomment-374465533 @Jiri-Kremser i had a chance to review #2413 again. Indeed the invoke next action in a sequence generates a new span. I think this is close but also wondering if 1. can we bury the span inside a transaction id, and 2. we use somehow ties the start/end markers in so we don't have two mechanism doing the same thing. It may be best to separate 1 & 2 in terms of the doing the work on the implementation but it makes sense to me to think about both in terms of the design. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3381: Transfer-Encoding: chunked causes error
rabbah commented on issue #3381: Transfer-Encoding: chunked causes error URL: https://github.com/apache/incubator-openwhisk/issues/3381#issuecomment-374463823 it's all just a matter of code 😅 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #319: plugable model for adding action language support
rabbah commented on issue #319: plugable model for adding action language support URL: https://github.com/apache/incubator-openwhisk/issues/319#issuecomment-374463620 It looks like you figured it out https://medium.com/@imesh/apache-openwhisk-runtime-for-ballerinalang-3f18be2d556c?source=linkShare-76041f7388eb-1521463545. @sciabarracom has offered to write it up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-374462780
Thinking through this a bit more - because it will have breaking changes to
downstream projects, I think we should do the break change once. Let's move the
stem cells to the runtime manifest.
We could do this by adding an additional property for a kind, `stemCells: [
{memory, count} ]` since the kind already specifies the image name. The
invoker's `preWarmConfig` is:
```
case class PrewarmingConfig(count: Int, exec: CodeExec[_], memoryLimit:
ByteSize)
```
so it is sufficient to add the fields I note above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3232: Making prewarm kind (and count) configurable
rabbah commented on a change in pull request #3232: Making prewarm kind (and
count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#discussion_r171994115
##
File path: ansible/group_vars/all
##
@@ -36,6 +36,11 @@ whisk:
#
runtimesManifest: "{{ runtimes_manifest | default(lookup('file', '{{
openwhisk_home }}/ansible/files/runtimes.json') | from_json) }}"
+##
+# Prewarm configuration
+prewarmKind: "{{prewarm_kind | default('nodejs:6')}}"
Review comment:
@markusthoemmes should we include these as examples?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #2254: Reevaluate the need of Consul in our deployment
rabbah commented on issue #2254: Reevaluate the need of Consul in our deployment URL: https://github.com/apache/incubator-openwhisk/issues/2254#issuecomment-374461093 yes we should but we need the sources; related to #3208. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #3402: Create '_users' database for singleton ephemeral couchdb v 2+
rabbah closed pull request #3402: Create '_users' database for singleton
ephemeral couchdb v 2+
URL: https://github.com/apache/incubator-openwhisk/pull/3402
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/roles/couchdb/tasks/deploy.yml
b/ansible/roles/couchdb/tasks/deploy.yml
index 1add44321b..0dedb7cf26 100644
--- a/ansible/roles/couchdb/tasks/deploy.yml
+++ b/ansible/roles/couchdb/tasks/deploy.yml
@@ -51,6 +51,16 @@
retries: 12
delay: 5
+- name: create '_users' database for singleton mode
+ uri:
+url: "{{ db_protocol }}://{{ ansible_host }}:{{ db_port }}/_users"
+method: PUT
+status_code: 201
+user: "{{ db_username }}"
+password: "{{ db_password }}"
+force_basic_auth: yes
+ when: (couchdb.version|version_compare('2.0','>=')) and (db.instances|int ==
1)
+
- name: enable the cluster setup mode
uri:
url: "{{ db_protocol }}://{{ ansible_host }}:{{ db_port }}/_cluster_setup"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows closed pull request #67: Add the config option to determine whether to push the artifacts or not
mrutkows closed pull request #67: Add the config option to determine whether to
push the artifacts or not
URL: https://github.com/apache/incubator-openwhisk-release/pull/67
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/config.json b/tools/config.json
index 6fdbed9..cac2d34 100644
--- a/tools/config.json
+++ b/tools/config.json
@@ -1,4 +1,5 @@
{
+ "publish_stage": "false",
"stage_url": "https://dist.apache.org/repos/dist/dev/incubator/openwhisk";,
"release_url":
"https://dist.apache.org/repos/dist/release/incubator/openwhisk";,
"version": {
diff --git a/tools/load_config.sh b/tools/load_config.sh
index 43b233d..6e19354 100755
--- a/tools/load_config.sh
+++ b/tools/load_config.sh
@@ -17,10 +17,10 @@
#
WORK_DIR=${1:-"$HOME"}
-SCRIPTDIR="$(cd $(dirname "$0")/ && pwd)"
-
+DIR="$(cd $(dirname "$0")/ && pwd)"
SVN_USERNAME=$2
SVN_PASSWORD=$3
+SCRIPTDIR=${4:-"$DIR"}
CREDENTIALS=""
if [ ! -z "$SVN_USERNAME" ] && [ ! -z "$SVN_PASSWORD" ];then
@@ -35,6 +35,7 @@ OPENWHISK_SVN="$OPENWHISK_RELEASE_DIR/openwhisk"
source "$SCRIPTDIR/util.sh"
CONFIG=$(read_file $SCRIPTDIR/config.json)
+PUBLISH_STAGE=$(json_by_key "$CONFIG" "publish_stage")
repos=$(echo $(json_by_key "$CONFIG" "RepoList") | sed 's/[][]//g')
STAGE_URL=$(json_by_key "$CONFIG" "stage_url")
diff --git a/tools/travis/package_source_code.sh
b/tools/travis/package_source_code.sh
index aa0585d..79bd7ec 100755
--- a/tools/travis/package_source_code.sh
+++ b/tools/travis/package_source_code.sh
@@ -27,16 +27,19 @@ PARENTDIR="$(dirname "$SCRIPTDIR")"
SVN_USERNAME=$2
SVN_PASSWORD=$3
+source "$PARENTDIR/load_config.sh" "$WORK_DIR" "$SVN_USERNAME" "$SVN_PASSWORD"
"$PARENTDIR"
+
"$PARENTDIR/install_dependencies.sh"
-"$PARENTDIR/download_source_code.sh" $WORK_DIR
-"$PARENTDIR/checkout_svn.sh" $WORK_DIR $SVN_USERNAME $SVN_PASSWORD
+"$PARENTDIR/download_source_code.sh" "$WORK_DIR"
+"$PARENTDIR/checkout_svn.sh" "$WORK_DIR" "$SVN_USERNAME" "$SVN_PASSWORD"
+
-"$PARENTDIR/package_source_code.sh" $WORK_DIR $SVN_USERNAME $SVN_PASSWORD
+"$PARENTDIR/package_source_code.sh" "$WORK_DIR" "$SVN_USERNAME" "$SVN_PASSWORD"
-if [ "$TRAVIS_EVENT_TYPE" == "push" ] ; then
+if [ "$TRAVIS_EVENT_TYPE" == "push" ] && [ "$PUBLISH_STAGE" == "true" ] ; then
"$SCRIPTDIR/import_pgp_key.sh"
-"$PARENTDIR/sign_artifacts.sh" $WORK_DIR
-"$PARENTDIR/upload_artifacts.sh" $WORK_DIR $SVN_USERNAME $SVN_PASSWORD
+"$PARENTDIR/sign_artifacts.sh" "$WORK_DIR"
+"$PARENTDIR/upload_artifacts.sh" "$WORK_DIR" "$SVN_USERNAME"
"$SVN_PASSWORD"
fi
-"$PARENTDIR/verify_source_code.sh" $WORK_DIR
+"$PARENTDIR/verify_source_code.sh" "$WORK_DIR"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3442: Add -o option to overwrite target files
rabbah commented on issue #3442: Add -o option to overwrite target files URL: https://github.com/apache/incubator-openwhisk/pull/3442#issuecomment-374459231 @jonpspri can you review this please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3435: CLI docs update and markdown linting.
rabbah commented on a change in pull request #3435: CLI docs update and markdown linting. URL: https://github.com/apache/incubator-openwhisk/pull/3435#discussion_r175645388 ## File path: ansible/README.md ## @@ -172,24 +172,44 @@ Use `ansible-playbook -i environments/ openwhisk.yml` to avoid wipi ### Configuring the installation of `wsk` CLI There are two installation modes to install `wsk` CLI: remote and local. -The mode "remote" means to download the `wsk` binaries from available web links. By default, OpenWhisk sets -the installation mode to remote and downloads the binaries from the CLI [release page](https://github.com/apache/incubator-openwhisk-cli/releases), where OpenWhisk publishes the official `wsk` binaries. +The mode "remote" means to download the `wsk` binaries from available web links. +By default, OpenWhisk sets the installation mode to remote and downloads the +binaries from the CLI +[release page](https://github.com/apache/incubator-openwhisk-cli/releases), +where OpenWhisk publishes the official `wsk` binaries. -The mode "local" means to build and install the `wsk` binaries from local CLI project. You can download the source code -of OpenWhisk CLI via [this link](https://github.com/apache/incubator-openwhisk-cli). Let's assume your OpenWhisk CLI home directory is . After you download the source code, use the gradle command to build the binaries: +The mode "local" means to build and install the `wsk` binaries from local CLI Review comment: from 'a' local CLI project. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #3456: Ignore controller Certificate Signing Requests in git
rabbah closed pull request #3456: Ignore controller Certificate Signing Requests in git URL: https://github.com/apache/incubator-openwhisk/pull/3456 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index 6a973302b2..960bb0178b 100644 --- a/.gitignore +++ b/.gitignore @@ -64,6 +64,7 @@ ansible/roles/nginx/files/*.p12 ansible/roles/nginx/files/*cert.pem ansible/roles/nginx/files/*p12 ansible/roles/kafka/files/* +ansible/roles/controller/files/*.csr ansible/roles/controller/files/*.pem ansible/roles/controller/files/*.key ansible/roles/controller/files/*.p12 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3464: Add wsk action get to CLI docs
rabbah commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175644508
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
+"binary": false
+},
+"annotations": [
+{
+"key": "exec",
+"value": "nodejs:6"
+}
+],
+"limits": {
+"timeout": 6,
+"memory": 256,
+"logs": 10
+},
+"publish": false
+}
+```
+
+### Getting an action URL
+
+An action can be invoked through the REST interface via an HTTPS request. To
get an action URL, execute the following command:
Review comment:
the CLI doesn't offer the non-webaction url for a web action does it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3464: Add wsk action get to CLI docs
rabbah commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175644552
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
+"binary": false
+},
+"annotations": [
+{
+"key": "exec",
+"value": "nodejs:6"
+}
+],
+"limits": {
+"timeout": 6,
+"memory": 256,
+"logs": 10
+},
+"publish": false
+}
+```
+
+### Getting an action URL
+
+An action can be invoked through the REST interface via an HTTPS request. To
get an action URL, execute the following command:
+
+```
+wsk action get actionName --url
+```
+```
+ok: got action actionName
+https://${APIHOST}/api/v1/namespaces/${NAMESPACE}/actions/actionName
+```
+
+**Note:** Authentication must be provided when invoking an action via an HTTPS
request. For more information regarding
Review comment:
I think a caveat is warranted.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3464: Add wsk action get to CLI docs
rabbah commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175644610
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
+"binary": false
+},
+"annotations": [
+{
+"key": "exec",
+"value": "nodejs:6"
+}
+],
+"limits": {
+"timeout": 6,
+"memory": 256,
+"logs": 10
+},
+"publish": false
+}
+```
+
+### Getting an action URL
+
+An action can be invoked through the REST interface via an HTTPS request. To
get an action URL, execute the following command:
+
+```
+wsk action get actionName --url
+```
+```
+ok: got action actionName
+https://${APIHOST}/api/v1/namespaces/${NAMESPACE}/actions/actionName
+```
+
+**Note:** Authentication must be provided when invoking an action via an HTTPS
request. For more information regarding
+action invocations using the REST interface, see
+[Using REST APIs with OpenWhisk](rest_api.md#actions).
+
+### Saving action code
+
+Code associated with an existing action is fetched and saved locally. Saving
is performed on all actions except sequences and docker actions. When saving
action code to a file, the code is saved in the current working directory, and
the saved file path is displayed.
Review comment:
I agree +1 for can or may.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3464: Add wsk action get to CLI docs
rabbah commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175644423
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
+"binary": false
+},
+"annotations": [
+{
+"key": "exec",
+"value": "nodejs:6"
+}
+],
+"limits": {
+"timeout": 6,
+"memory": 256,
+"logs": 10
+},
+"publish": false
+}
+```
+
+### Getting an action URL
+
+An action can be invoked through the REST interface via an HTTPS request. To
get an action URL, execute the following command:
Review comment:
so this can be confusing... since the standard url is shown but if this is a
web action it will be a different url and no auth may be required.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3464: Add wsk action get to CLI docs
rabbah commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175644766
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
+"binary": false
+},
+"annotations": [
+{
+"key": "exec",
+"value": "nodejs:6"
+}
+],
+"limits": {
+"timeout": 6,
+"memory": 256,
+"logs": 10
+},
+"publish": false
+}
+```
+
+### Getting an action URL
+
+An action can be invoked through the REST interface via an HTTPS request. To
get an action URL, execute the following command:
+
+```
+wsk action get actionName --url
+```
+```
+ok: got action actionName
+https://${APIHOST}/api/v1/namespaces/${NAMESPACE}/actions/actionName
+```
+
+**Note:** Authentication must be provided when invoking an action via an HTTPS
request. For more information regarding
+action invocations using the REST interface, see
+[Using REST APIs with OpenWhisk](rest_api.md#actions).
+
+### Saving action code
+
+Code associated with an existing action is fetched and saved locally. Saving
is performed on all actions except sequences and docker actions. When saving
action code to a file, the code is saved in the current working directory, and
the saved file path is displayed.
Review comment:
How about this:
The code for an action may be retrieved and saved locally. Unless a
destination is provided, the code is saved to the current working directory and
assumes the name of the action. An extension is added to match the action's
runtime (e.g., `js` for Node, `jar` for Java, and `zip` for Zip files).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3459: Wrap producer.send with Future
rabbah commented on issue #3459: Wrap producer.send with Future URL: https://github.com/apache/incubator-openwhisk/pull/3459#issuecomment-374456632 Thanks for this patch. The culprit is `waitOnMetadata` in the `send` method ``` ClusterAndWaitTime clusterAndWaitTime = waitOnMetadata(record.topic(), record.partition(), maxBlockTimeMs); ``` I generally agree then with the fix. Since now the code would use a Scala future, we can eliminate the callback passed to the Java future and just use `andThen`. @markusthoemmes @cbickel one of you please also have a look. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3453: [wip] Introduce a AttachmentStore SPI
rabbah commented on a change in pull request #3453: [wip] Introduce a
AttachmentStore SPI
URL:
https://github.com/apache/incubator-openwhisk/pull/3453#discussion_r175643061
##
File path:
common/scala/src/main/scala/whisk/core/database/AttachmentStore.scala
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package whisk.core.database
+
+import akka.http.scaladsl.model.ContentType
+import akka.stream.scaladsl.{Sink, Source}
+import akka.util.ByteString
+import whisk.common.TransactionId
+import whisk.core.entity.DocInfo
+
+import scala.concurrent.{ExecutionContext, Future}
+
+trait AttachmentStore {
+
+ /** Execution context for futures */
+ protected[core] implicit val executionContext: ExecutionContext
+
+ /**
+ * Attaches a "file" of type `contentType` to an existing document. The
revision for the document must be set.
+ */
+ protected[core] def attach(doc: DocInfo, name: String, contentType:
ContentType, docStream: Source[ByteString, _])(
+implicit transid: TransactionId): Future[DocInfo]
+
+ /**
+ * Retrieves a saved attachment, streaming it into the provided Sink.
+ */
+ protected[core] def readAttachment[T](doc: DocInfo, name: String, sink:
Sink[ByteString, Future[T]])(
+implicit transid: TransactionId): Future[(ContentType, T)]
+
+ /**
+ * Deletes all attachments linked to given document
+ */
+ protected[core] def deleteAttachments(doc: DocInfo)(implicit transid:
TransactionId): Future[Boolean]
Review comment:
rename to `detach`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah closed pull request #3396: Self-generate random strings without going through a UUID.
rabbah closed pull request #3396: Self-generate random strings without going
through a UUID.
URL: https://github.com/apache/incubator-openwhisk/pull/3396
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/common/scala/src/main/scala/whisk/common/RandomString.scala
b/common/scala/src/main/scala/whisk/common/RandomString.scala
new file mode 100644
index 00..b30f432458
--- /dev/null
+++ b/common/scala/src/main/scala/whisk/common/RandomString.scala
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.common
+
+import java.security.SecureRandom
+
+import org.apache.commons.codec.binary.Hex
+
+object RandomString {
+ private val generator = new ThreadLocal[SecureRandom] {
+override def initialValue() = new SecureRandom()
+ }
+
+ val lowercase: IndexedSeq[Char] = 'a' to 'z'
+ val uppercase: IndexedSeq[Char] = 'A' to 'Z'
+ val digits: IndexedSeq[Char] = '0' to '9'
+ val alphanumeric: IndexedSeq[Char] = lowercase ++ uppercase ++ digits
+
+ /**
+ * Generates a random string of hexadecimal characters and the given length.
+ *
+ * Vastly optimized for raw speed over the other generate methods. For that
optimization, the length of the string
+ * needs to be divisible by 2 (4 bits make one hex character and a byte
consists of 8 bits). If the number is not
+ * divisible by two, the outcome string will be one character shorter than
expected.
+ *
+ * @param length length of the string to generate
+ * @return a random string
+ */
+ def generateHexadecimal(length: Int): String = {
+val bytes = Array.ofDim[Byte](length / 2)
+generator.get().nextBytes(bytes)
+Hex.encodeHexString(bytes)
+ }
+
+ /**
+ * Generates a random string of the given character range and the given
length.
+ *
+ * @param characters the characters to build the target string of
+ * @param length length of the target string
+ * @return a random string
+ */
+ def generate(characters: IndexedSeq[Char])(length: Int): String = {
+val random = generator.get()
+
Stream.continually(characters(random.nextInt(characters.length))).take(length).mkString
+ }
+}
diff --git a/common/scala/src/main/scala/whisk/core/entity/ActivationId.scala
b/common/scala/src/main/scala/whisk/core/entity/ActivationId.scala
index 85c59beb7b..e5ad3a79be 100644
--- a/common/scala/src/main/scala/whisk/core/entity/ActivationId.scala
+++ b/common/scala/src/main/scala/whisk/core/entity/ActivationId.scala
@@ -19,8 +19,8 @@ package whisk.core.entity
import spray.json.DefaultJsonProtocol.StringJsonFormat
import spray.json._
+import whisk.common.RandomString
import whisk.http.Messages
-
import whisk.core.entity.size._
import scala.util.{Failure, Success, Try}
@@ -74,7 +74,7 @@ protected[core] object ActivationId {
*
* @return new ActivationId
*/
- protected[core] def generate(): ActivationId = new
ActivationId(UUIDs.randomUUID().toString.filterNot(_ == '-'))
+ protected[core] def generate(): ActivationId = new
ActivationId(RandomString.generateHexadecimal(32))
protected[core] implicit val serdes: RootJsonFormat[ActivationId] = new
RootJsonFormat[ActivationId] {
def write(d: ActivationId) = JsString(d.toString)
diff --git a/common/scala/src/main/scala/whisk/core/entity/Secret.scala
b/common/scala/src/main/scala/whisk/core/entity/Secret.scala
index aac4e7f7e8..c320b76dfb 100644
--- a/common/scala/src/main/scala/whisk/core/entity/Secret.scala
+++ b/common/scala/src/main/scala/whisk/core/entity/Secret.scala
@@ -19,6 +19,7 @@ package whisk.core.entity
import spray.json._
import spray.json.DefaultJsonProtocol._
+import whisk.common.RandomString
/**
* Secret, a cryptographic string such as a key used for authentication.
@@ -57,19 +58,11 @@ protected[core] object Secret {
new Secret(str)
}
- /**
- * Creates a new random secret.
- *
- * @return Secret
- */
- protected[core] def apply(): Secret = {
-Secret(rand.alphanumeric.take(MIN_LENGTH).mkSt
[GitHub] rabbah commented on issue #3396: Self-generate random strings without going through a UUID.
rabbah commented on issue #3396: Self-generate random strings without going through a UUID. URL: https://github.com/apache/incubator-openwhisk/pull/3396#issuecomment-374455020 Leaving as UUID factory based for now. Reopen if you disagree. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #2833: MesosContainerFactory
rabbah closed pull request #2833: MesosContainerFactory
URL: https://github.com/apache/incubator-openwhisk/pull/2833
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/common/scala/build.gradle b/common/scala/build.gradle
index 8e0aeede68..c907bd05bb 100644
--- a/common/scala/build.gradle
+++ b/common/scala/build.gradle
@@ -44,6 +44,8 @@ dependencies {
compile 'io.fabric8:kubernetes-client:2.5.7'
compile 'io.kamon:kamon-core_2.11:0.6.7'
compile 'io.kamon:kamon-statsd_2.11:0.6.7'
+//for mesos
+compile 'com.adobe.api.platform.runtime:mesos-actor:0.0.4'
}
tasks.withType(ScalaCompile) {
diff --git a/common/scala/src/main/resources/application.conf
b/common/scala/src/main/resources/application.conf
index 402ae5d6cc..4c36319523 100644
--- a/common/scala/src/main/resources/application.conf
+++ b/common/scala/src/main/resources/application.conf
@@ -155,4 +155,12 @@ whisk {
max = 512 m
std = 256 m
}
+
+mesos {
+master-url = "http://localhost:5050"; //your mesos master
+master-public-url = "http://localhost:5050"; // if
mesos-link-log-message == true, this link will be included with the static log
message (may or may not be different from master-url)
+role = "*" //see
http://mesos.apache.org/documentation/latest/roles/#associating-frameworks-with-roles
+failover-timeout = 0 seconds //Timeout allowed for framework to
reconnect after disconnection.
+mesos-link-log-message = true //If true, display a link to mesos in
the static log message, otherwise do not include a link to mesos.
+}
}
diff --git a/common/scala/src/main/resources/reference.conf
b/common/scala/src/main/resources/reference.conf
index 9821b8fb77..8048d43bd4 100644
--- a/common/scala/src/main/resources/reference.conf
+++ b/common/scala/src/main/resources/reference.conf
@@ -1,4 +1,4 @@
-whisk.spi{
+whisk.spi {
ArtifactStoreProvider = whisk.core.database.CouchDbStoreProvider
MessagingProvider = whisk.connector.kafka.KafkaMessagingProvider
ContainerFactoryProvider =
whisk.core.containerpool.docker.DockerContainerFactoryProvider
diff --git a/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
b/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
index 4c4b4e8cf0..7e6148038d 100644
--- a/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
+++ b/common/scala/src/main/scala/whisk/core/WhiskConfig.scala
@@ -247,4 +247,6 @@ object ConfigKeys {
val logStore = "whisk.logstore"
val splunk = s"$logStore.splunk"
+
+ val mesos = "whisk.mesos"
}
diff --git
a/common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala
b/common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala
new file mode 100644
index 00..9d6204b00c
--- /dev/null
+++ b/common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.core.mesos
+
+import akka.actor.ActorRef
+import akka.actor.ActorSystem
+import akka.pattern.ask
+import com.adobe.api.platform.runtime.mesos.MesosClient
+import com.adobe.api.platform.runtime.mesos.Subscribe
+import com.adobe.api.platform.runtime.mesos.SubscribeComplete
+import com.adobe.api.platform.runtime.mesos.Teardown
+import java.time.Instant
+import pureconfig.loadConfigOrThrow
+import scala.concurrent.Await
+import scala.concurrent.ExecutionContext
+import scala.concurrent.Future
+import scala.concurrent.TimeoutException
+import scala.concurrent.duration._
+import scala.util.Try
+import whisk.common.Counter
+import whisk.common.Logging
+import whisk.common.TransactionId
+import whisk.core.ConfigKeys
+import whisk.core.WhiskConfig
+import whisk.core.containerpool.Container
+import whisk.core.containerpool.ContainerArgsConfig
+import whisk.core.containerpool.ContainerFactory
+import whisk.core.containerpool.ContainerFactoryProvider
+import whisk.core.entity.ByteSize
+import whisk.core.entity.ExecManifest
+import
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175641684 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your +project is file based (uses ipr files) then you can convert it to directory based via _File -> Save as Directory-Based Format_ + +### Usage + +First setup OpenWhisk so that Controller and Invoker containers are up and running. Then run the script + +./gradlew -p tools/dev intellij + +It would inspect the running docker containers and then generate the launch configs with name 'controller0' Review comment: `.` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175642499 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your Review comment: can you add a tip: how do you use the run configurations that are generated? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175641730 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your +project is file based (uses ipr files) then you can convert it to directory based via _File -> Save as Directory-Based Format_ + +### Usage + +First setup OpenWhisk so that Controller and Invoker containers are up and running. Then run the script + +./gradlew -p tools/dev intellij + +It would inspect the running docker containers and then generate the launch configs with name 'controller0' +and 'invoker0' + +Key points to note + +1. Uses ~/tmp/openwhisk/controller (or invoker) as working directory Review comment: `,` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r171198414 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your Review comment: s/j/J This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175641855 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your +project is file based (uses ipr files) then you can convert it to directory based via _File -> Save as Directory-Based Format_ + +### Usage + +First setup OpenWhisk so that Controller and Invoker containers are up and running. Then run the script + +./gradlew -p tools/dev intellij + +It would inspect the running docker containers and then generate the launch configs with name 'controller0' +and 'invoker0' + +Key points to note + +1. Uses ~/tmp/openwhisk/controller (or invoker) as working directory +2. Changes the PORT to linked one. So controller gets started at 10001 only just like container + +Now the docker container can be stopped and application can be launched from within the IDE + +**Note** - Currently only controller can be run from IDE. Invoker posses some [problems][2] Review comment: s/only controller/only the controller and `.` at end of sentence 🙏 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175641739 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your +project is file based (uses ipr files) then you can convert it to directory based via _File -> Save as Directory-Based Format_ + +### Usage + +First setup OpenWhisk so that Controller and Invoker containers are up and running. Then run the script + +./gradlew -p tools/dev intellij + +It would inspect the running docker containers and then generate the launch configs with name 'controller0' +and 'invoker0' + +Key points to note + +1. Uses ~/tmp/openwhisk/controller (or invoker) as working directory +2. Changes the PORT to linked one. So controller gets started at 10001 only just like container Review comment: `.` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175641904 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your +project is file based (uses ipr files) then you can convert it to directory based via _File -> Save as Directory-Based Format_ + +### Usage + +First setup OpenWhisk so that Controller and Invoker containers are up and running. Then run the script + +./gradlew -p tools/dev intellij + +It would inspect the running docker containers and then generate the launch configs with name 'controller0' +and 'invoker0' + +Key points to note + +1. Uses ~/tmp/openwhisk/controller (or invoker) as working directory +2. Changes the PORT to linked one. So controller gets started at 10001 only just like container + +Now the docker container can be stopped and application can be launched from within the IDE + +**Note** - Currently only controller can be run from IDE. Invoker posses some [problems][2] + +### Configuration + +The script allows some local customization of the launch configuration. This can be done by creating a [config][4] file +`intellij-run-config.groovy` in project root directory. Below is an example of _/intellij-run-config.groovy_ +file to customize the logging and db port used for CouchDB Review comment: `.` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175641702 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your +project is file based (uses ipr files) then you can convert it to directory based via _File -> Save as Directory-Based Format_ + +### Usage + +First setup OpenWhisk so that Controller and Invoker containers are up and running. Then run the script Review comment: `:` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175641668 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your +project is file based (uses ipr files) then you can convert it to directory based via _File -> Save as Directory-Based Format_ Review comment: do you mind ending sentences with `.` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175642142 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your +project is file based (uses ipr files) then you can convert it to directory based via _File -> Save as Directory-Based Format_ + +### Usage + +First setup OpenWhisk so that Controller and Invoker containers are up and running. Then run the script + +./gradlew -p tools/dev intellij + +It would inspect the running docker containers and then generate the launch configs with name 'controller0' +and 'invoker0' + +Key points to note + +1. Uses ~/tmp/openwhisk/controller (or invoker) as working directory Review comment: why you use system temp directory? anyway, minor issue... worked fine for me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175641714 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your +project is file based (uses ipr files) then you can convert it to directory based via _File -> Save as Directory-Based Format_ + +### Usage + +First setup OpenWhisk so that Controller and Invoker containers are up and running. Then run the script + +./gradlew -p tools/dev intellij + +It would inspect the running docker containers and then generate the launch configs with name 'controller0' +and 'invoker0' + +Key points to note Review comment: `:` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker URL: https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175641763 ## File path: tools/dev/README.md ## @@ -41,3 +41,71 @@ Sample output Processing whisks_design_document_for_activations_db_filters_v2.1.0.json - whisks-filters.v2.1.0-activations.js Generated view json files in /path/too/tools/build/views + +## IntelliJ Run Config Generator + +This script enables creation of [Intellij Launch Configuration][1] in _/.idea/runConfigurations_ +with name controller0 and invoker0. For this to work your Intellij project should be [directory based][3]. If your +project is file based (uses ipr files) then you can convert it to directory based via _File -> Save as Directory-Based Format_ + +### Usage + +First setup OpenWhisk so that Controller and Invoker containers are up and running. Then run the script + +./gradlew -p tools/dev intellij + +It would inspect the running docker containers and then generate the launch configs with name 'controller0' +and 'invoker0' + +Key points to note + +1. Uses ~/tmp/openwhisk/controller (or invoker) as working directory +2. Changes the PORT to linked one. So controller gets started at 10001 only just like container + +Now the docker container can be stopped and application can be launched from within the IDE Review comment: `.` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3306: Script to generate IntelliJ Run Configuration for Controller and Invoker
rabbah commented on a change in pull request #3306: Script to generate IntelliJ
Run Configuration for Controller and Invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3306#discussion_r175641933
##
File path: tools/dev/README.md
##
@@ -41,3 +41,71 @@ Sample output
Processing whisks_design_document_for_activations_db_filters_v2.1.0.json
- whisks-filters.v2.1.0-activations.js
Generated view json files in /path/too/tools/build/views
+
+## IntelliJ Run Config Generator
+
+This script enables creation of [Intellij Launch Configuration][1] in
_/.idea/runConfigurations_
+with name controller0 and invoker0. For this to work your Intellij project
should be [directory based][3]. If your
+project is file based (uses ipr files) then you can convert it to directory
based via _File -> Save as Directory-Based Format_
+
+### Usage
+
+First setup OpenWhisk so that Controller and Invoker containers are up and
running. Then run the script
+
+./gradlew -p tools/dev intellij
+
+It would inspect the running docker containers and then generate the launch
configs with name 'controller0'
+and 'invoker0'
+
+Key points to note
+
+1. Uses ~/tmp/openwhisk/controller (or invoker) as working directory
+2. Changes the PORT to linked one. So controller gets started at 10001 only
just like container
+
+Now the docker container can be stopped and application can be launched from
within the IDE
+
+**Note** - Currently only controller can be run from IDE. Invoker posses some
[problems][2]
+
+### Configuration
+
+The script allows some local customization of the launch configuration. This
can be done by creating a [config][4] file
+`intellij-run-config.groovy` in project root directory. Below is an example of
_/intellij-run-config.groovy_
+file to customize the logging and db port used for CouchDB
+
+```groovy
+//Configures the settings for controller application
+controller {
+//Base directory used for controller process
+workingDir = "/path/to/controller"
+//System properties to be set
+props = [
+'logback.configurationFile':'/path/to/custom/logback.xml'
+]
+//Environment variables to be set
+env = [
+'DB_PORT' : '5989'
+]
+}
+
+invoker {
+workingDir = "/path/to/invoker"
+props = [
+'logback.configurationFile':'/path/to/custom/logback.xml'
+]
+env = [
+'DB_PORT' : '5989'
+]
+}
+
+```
+
+The config allows following properties
Review comment:
`:`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah closed pull request #3460: Ensure java8 is installed instead of 9
rabbah closed pull request #3460: Ensure java8 is installed instead of 9 URL: https://github.com/apache/incubator-openwhisk/pull/3460 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tools/macos/README.md b/tools/macos/README.md index 4dda67fa9e..b575d8d469 100644 --- a/tools/macos/README.md +++ b/tools/macos/README.md @@ -41,8 +41,10 @@ echo ' /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)" # install cask brew tap caskroom/cask +# install for finding alternative versions (java8) +brew tap caskroom/versions # install java 8 -brew cask install java +brew cask install java8 # install scala brew install scala # install pip This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3460: Ensure java8 is installed instead of 9
rabbah commented on issue #3460: Ensure java8 is installed instead of 9 URL: https://github.com/apache/incubator-openwhisk/pull/3460#issuecomment-374452987 Thanks for fixing this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3451: Fix several loadbalancer bugs.
rabbah commented on a change in pull request #3451: Fix several loadbalancer
bugs.
URL:
https://github.com/apache/incubator-openwhisk/pull/3451#discussion_r175640847
##
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
##
@@ -331,9 +338,10 @@ object ShardingContainerPoolBalancer extends
LoadBalancerProvider {
val healthyInvokers = invokers.filter(_.status == Healthy)
if (healthyInvokers.nonEmpty) {
// Choose a healthy invoker randomly
-val random =
ThreadLocalRandom.current().nextInt(healthyInvokers.size)
-dispatched(random).forceAcquire()
-Some(healthyInvokers(random).id)
+val random =
healthyInvokers(ThreadLocalRandom.current().nextInt(healthyInvokers.size)).id
+dispatched(random.toInt).forceAcquire()
+logging.warn(this, s"system is overloaded. Chosen
invoker${random.toInt} by random.")
Review comment:
Chosen invoker${random.toInt} by random. -> Chose invoker${random.toInt} by
random assignment.
(or just randomly).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3451: Fix several loadbalancer bugs.
rabbah commented on a change in pull request #3451: Fix several loadbalancer
bugs.
URL:
https://github.com/apache/incubator-openwhisk/pull/3451#discussion_r175640739
##
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
##
@@ -247,17 +254,17 @@ class ShardingContainerPoolBalancer(config: WhiskConfig,
controllerInstance: Ins
activations.remove(aid) match {
case Some(entry) =>
+totalActivations.decrement()
+activationsPerNamespace.get(entry.namespaceId).foreach(_.decrement())
+schedulingState.invokerSlots.lift(invoker.toInt).foreach(_.release())
Review comment:
this is moved up to release the slot as early as possible?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee closed pull request #164: updates to query_params validation
dubee closed pull request #164: updates to query_params validation
URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/164
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/actions/changesWebAction.js b/actions/changesWebAction.js
index 73b24ac..f69e286 100644
--- a/actions/changesWebAction.js
+++ b/actions/changesWebAction.js
@@ -38,19 +38,17 @@ function main(params) {
var query_params;
if (params.filter) {
-if (typeof params.query_params === 'object') {
-query_params = params.query_params;
-}
-else if (typeof params.query_params === 'string') {
+query_params = params.query_params;
+if (typeof queryParams === 'string') {
try {
query_params = JSON.parse(params.query_params);
}
catch (e) {
return sendError(400, 'The query_params parameter cannot
be parsed. Ensure it is valid JSON.');
}
-if (typeof query_params !== 'object') {
-return sendError(400, 'The query_params parameter is not
valid JSON');
-}
+}
+if (typeof query_params !== 'object') {
+return sendError(400, 'The query_params parameter is not valid
JSON');
}
}
else if (params.query_params) {
@@ -162,20 +160,19 @@ function main(params) {
}
if (params.query_params) {
if (updatedParams.filter) {
-if (typeof params.query_params === 'object') {
-updatedParams.query_params =
params.query_params;
-}
-else if (typeof params.query_params === 'string') {
+var query_params = params.query_params;
+if (typeof query_params === 'string') {
try {
-updatedParams.query_params =
JSON.parse(params.query_params);
+query_params =
JSON.parse(params.query_params);
}
catch (e) {
reject(sendError(400, 'The query_params
parameter cannot be parsed. Ensure it is valid JSON.'));
}
-if (typeof updatedParams.query_params !==
'object') {
-reject(sendError(400, 'The query_params
parameter is not valid JSON'));
-}
}
+if (typeof query_params !== 'object') {
+reject(sendError(400, 'The query_params
parameter is not valid JSON'));
+}
+updatedParams.query_params = query_params;
} else {
reject(sendError(400, 'The query_params parameter
is only allowed if the filter parameter is defined'));
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jasonpet opened a new pull request #164: updates to query_params validation
jasonpet opened a new pull request #164: updates to query_params validation URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/164 return an error message when query_params is not a string or object This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new pull request #811: Deprecating WithinOpenWhisk flag
pritidesai opened a new pull request #811: Deprecating WithinOpenWhisk flag URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/811 Closes #791 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #807: Deprecating Interactive Mode and introducing Preview
pritidesai commented on issue #807: Deprecating Interactive Mode and introducing Preview URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/807#issuecomment-374428887 thanks @mrutkows I have renamed the flag, this PR is ready to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set
pritidesai commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/791#issuecomment-374426597 So once this issue is fixed, `wskdeploy` wouldn't crash when you are running locally with these env. variables (__OW*) set. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set
pritidesai commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/791#issuecomment-374426444 Thanks @beemarie, I have verified that package deploy is not invoking `wskdeploy` as an OpenWhisk action and it is safe to deprecate this code path. @ScottChapman, [here](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/cmd/root.go#L103) in `init()` function, `WithinOpenWhisk` is getting set depending on whether env. variable `__OW_API_HOST` is set or not. This was introduced when `wsksdeploy` was just a concept and could be run as an action like: ``` wsk action create wskdeploy wsk action invoke wskdeploy --param ``` This code path hasn't been tested or maintained during the development cycle and since its not used anywhere, its safe to deprecate and delete flag `WithinOpenWhisk`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jonpspri commented on issue #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions
jonpspri commented on issue #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/24#issuecomment-374414328 Running into the unicode failure again using jdk8u162-b12_openj9-0.8.0. The environment variables mentioned above are set in the runtime and also in the test compile environment. Any thoughts on additional potential causes? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ScottChapman commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set
ScottChapman commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/791#issuecomment-374408650 I'm not entirely clear on where this gets set: https://github.com/apache/incubator-openwhisk-wskdeploy/blob/c08d8053dec6fb478702e662f89d5bdb5cea8741/utils/flags.go#L26 But it appears it is getting set when it detects that both HOST & KEY are set. Just not sure how that is getting set... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo closed pull request #66: Remove the redundant configuration loadings
houshengbo closed pull request #66: Remove the redundant configuration loadings
URL: https://github.com/apache/incubator-openwhisk-release/pull/66
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/checkout_svn.sh b/tools/checkout_svn.sh
index e08003e..d0c2d54 100755
--- a/tools/checkout_svn.sh
+++ b/tools/checkout_svn.sh
@@ -23,7 +23,7 @@ echo "Checkout the SVN to the local directory."
WORK_DIR=${1:-"$HOME"}
SCRIPTDIR="$(cd $(dirname "$0")/ && pwd)"
-source "$SCRIPTDIR/load_config.sh" $1 $2 $3
+#source "$SCRIPTDIR/load_config.sh" $1 $2 $3
if [[ `wget -S --spider $CURRENT_VERSION_URL 2>&1 | grep 'HTTP/1.1 404 Not
Found'` ]]; then
# Create an empty folder named ${REMOTE_PATH} in the remote staging folder
diff --git a/tools/download_source_code.sh b/tools/download_source_code.sh
index f019e4e..a392be9 100755
--- a/tools/download_source_code.sh
+++ b/tools/download_source_code.sh
@@ -21,7 +21,15 @@ set -e
WORK_DIR=${1:-"$HOME"}
SCRIPTDIR="$(cd $(dirname "$0")/ && pwd)"
-source "$SCRIPTDIR/load_config.sh" $1
+
+if [[ "$CONFIG_LOADED" != "true" ]]; then
+echo "reload config."
+echo "$CONFIG_LOADED"
+source "$SCRIPTDIR/load_config.sh" $1 $2 $3
+else
+echo "already loaded config."
+echo "$CONFIG_LOADED"
+fi
clone_depth=${2:-"100"}
diff --git a/tools/load_config.sh b/tools/load_config.sh
index 43b233d..e04ea0d 100755
--- a/tools/load_config.sh
+++ b/tools/load_config.sh
@@ -17,10 +17,14 @@
#
WORK_DIR=${1:-"$HOME"}
-SCRIPTDIR="$(cd $(dirname "$0")/ && pwd)"
+DIR="$(cd $(dirname "$0")/ && pwd)"
SVN_USERNAME=$2
SVN_PASSWORD=$3
+
+
+SCRIPTDIR=${4:-"$DIR"}
+echo "4 is $4"
CREDENTIALS=""
if [ ! -z "$SVN_USERNAME" ] && [ ! -z "$SVN_PASSWORD" ];then
@@ -32,6 +36,7 @@
OPENWHISK_SOURCE_DIR="$OPENWHISK_RELEASE_DIR/openwhisk_sources"
OPENWHISK_CLEANED_SOURCE_DIR="$OPENWHISK_RELEASE_DIR/openwhisk_cleaned_sources"
OPENWHISK_SVN="$OPENWHISK_RELEASE_DIR/openwhisk"
+echo "SCRIPTDIR is $SCRIPTDIR"
source "$SCRIPTDIR/util.sh"
CONFIG=$(read_file $SCRIPTDIR/config.json)
@@ -47,3 +52,5 @@ REMOTE_PATH="openwhisk-$version"
CURRENT_VERSION_URL="$STAGE_URL/${REMOTE_PATH}/"
CURRENT_VERSION_DIR="$OPENWHISK_SVN/openwhisk-$version"
+
+CONFIG_LOADED="true"
diff --git a/tools/package_source_code.sh b/tools/package_source_code.sh
index d04307a..89d43ce 100755
--- a/tools/package_source_code.sh
+++ b/tools/package_source_code.sh
@@ -21,7 +21,7 @@ set -e
echo "Package the artifacts."
SCRIPTDIR="$(cd $(dirname "$0")/ && pwd)"
-source "$SCRIPTDIR/load_config.sh" $1 $2 $3
+#source "$SCRIPTDIR/load_config.sh" $1 $2 $3
# Clean up all the source code by excluding unnecessary files and folders
# Remove all the hidden files and folder
diff --git a/tools/sign_artifacts.sh b/tools/sign_artifacts.sh
index e2a1975..ede2e97 100755
--- a/tools/sign_artifacts.sh
+++ b/tools/sign_artifacts.sh
@@ -21,10 +21,10 @@ set -e
echo "Sign the artifacts with PGP."
WORK_DIR=${1:-"$HOME"}
-passphrase=${2:-"openwhisk"}
SCRIPTDIR="$(cd $(dirname "$0")/ && pwd)"
-source "$SCRIPTDIR/load_config.sh" $1
+#source "$SCRIPTDIR/load_config.sh" $1 $2 $3
+passphrase="openwhisk"
# Sign all the artifacts with the PGP key.
export GPG_TTY=$(tty)
diff --git a/tools/travis/package_source_code.sh
b/tools/travis/package_source_code.sh
index aa0585d..a6695b6 100755
--- a/tools/travis/package_source_code.sh
+++ b/tools/travis/package_source_code.sh
@@ -27,16 +27,19 @@ PARENTDIR="$(dirname "$SCRIPTDIR")"
SVN_USERNAME=$2
SVN_PASSWORD=$3
-"$PARENTDIR/install_dependencies.sh"
-"$PARENTDIR/download_source_code.sh" $WORK_DIR
+echo "PARENTDIR is $PARENTDIR"
+source "$PARENTDIR/load_config.sh" $WORK_DIR $SVN_USERNAME $SVN_PASSWORD
$PARENTDIR
+
+#"$PARENTDIR/install_dependencies.sh"
+"$PARENTDIR/download_source_code.sh" $WORK_DIR $SVN_USERNAME $SVN_PASSWORD
"$PARENTDIR/checkout_svn.sh" $WORK_DIR $SVN_USERNAME $SVN_PASSWORD
"$PARENTDIR/package_source_code.sh" $WORK_DIR $SVN_USERNAME $SVN_PASSWORD
if [ "$TRAVIS_EVENT_TYPE" == "push" ] ; then
"$SCRIPTDIR/import_pgp_key.sh"
-"$PARENTDIR/sign_artifacts.sh" $WORK_DIR
+"$PARENTDIR/sign_artifacts.sh" $WORK_DIR $SVN_USERNAME $SVN_PASSWORD
"$PARENTDIR/upload_artifacts.sh" $WORK_DIR $SVN_USERNAME $SVN_PASSWORD
fi
-"$PARENTDIR/verify_source_code.sh" $WORK_DIR
+"$PARENTDIR/verify_source_code.sh" $WORK_DIR $SVN_USERNAME $SVN_PASSWORD
diff --git a/tools/upload_artifacts.sh b/tools/upload_artifacts.sh
index 2f0e66a..df8b37c 100755
--- a/tools/upload_artifacts.sh
+++ b/tools/upload_artifacts.sh
@@ -23,7 +23,7 @@ echo "Upload the artifacts."
WORK_DIR=${1:-"$HOME"}
SCRIPTDIR="$(cd $(dirname "$0")/ && pwd)"
-source "$SCRIPTDIR/load_config.sh" $1 $2 $3
+#source "$SCRIPTDIR/load_config.sh" $1 $2 $3
cd $OPENWHISK
[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175602013
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
Review comment:
if so, i'm thinking the example reflect that..
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175601826
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
+"binary": false
+},
+"annotations": [
+{
+"key": "exec",
+"value": "nodejs:6"
+}
+],
+"limits": {
+"timeout": 6,
+"memory": 256,
+"logs": 10
+},
+"publish": false
+}
+```
+
+### Getting an action URL
+
+An action can be invoked through the REST interface via an HTTPS request. To
get an action URL, execute the following command:
+
+```
+wsk action get actionName --url
+```
+```
+ok: got action actionName
+https://${APIHOST}/api/v1/namespaces/${NAMESPACE}/actions/actionName
+```
+
+**Note:** Authentication must be provided when invoking an action via an HTTPS
request. For more information regarding
+action invocations using the REST interface, see
+[Using REST APIs with OpenWhisk](rest_api.md#actions).
+
+### Saving action code
+
+Code associated with an existing action is fetched and saved locally. Saving
is performed on all actions except sequences and docker actions. When saving
action code to a file, the code is saved in the current working directory, and
the saved file path is displayed.
Review comment:
lol. imho, the `is` is a bit misleading as the code is only saved when the
`--save` or `--save-as` flag is used. let's see what @jpkessle says.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows commented on issue #804: Fix for 730
mrutkows commented on issue #804: Fix for 730 URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/804#issuecomment-374392332 @davidbreitgand I do not like introducing a -r flag and somehow differentiating from static or dynamically linked dependent packages. IMO, and after discussing with Priti, we should track all depenedencies using the managed annotations. There should be no confusion to the end user as dependencies that are referenced at a location are given a local name and bound and there is not external location they are searched for in the public packages and bound to a local name as well. This should solve any use case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #807: Deprecating Interactive Mode and introducing Dry Run
mrutkows commented on issue #807: Deprecating Interactive Mode and introducing Dry Run URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/807#issuecomment-374384064 @pritidesai as we discussed, let us use "preview" as it is more formal and will not have any translation issues. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #67: Add the config option to determine whether to push the artifacts or not
houshengbo opened a new pull request #67: Add the config option to determine whether to push the artifacts or not URL: https://github.com/apache/incubator-openwhisk-release/pull/67 This PR adds a config option "publish_stage" in the configuration file to determine whether this commit will push new artifacts into the staging URL or not. By default, it is set to false, meaning it will not push new artifacts. We can set it to true in order to push new artifacts. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ScottChapman commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set
ScottChapman commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/791#issuecomment-374373819 Just to be clear, I am running code locally which uses the nodejs client NPM module. It leverages the API & KEY variables to be able to connect to the OW I am testing against. wskdeploy just shouldn't crash if I am running it locally with those set. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] beemarie commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set
beemarie commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/791#issuecomment-374359777 @pritidesai & I discussed offline. incubator-openwhisk-package-deploy uses exec command to call wskdeploy. This should not result in wskdeploy being called as an openwhisk action. Priti is going to quickly look over package-deploy to confirm before deprecating. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #163: validate that query_params is valid JSON
dubee closed pull request #163: validate that query_params is valid JSON
URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/163
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/actions/changesWebAction.js b/actions/changesWebAction.js
index 3f02994..73b24ac 100644
--- a/actions/changesWebAction.js
+++ b/actions/changesWebAction.js
@@ -48,6 +48,9 @@ function main(params) {
catch (e) {
return sendError(400, 'The query_params parameter cannot
be parsed. Ensure it is valid JSON.');
}
+if (typeof query_params !== 'object') {
+return sendError(400, 'The query_params parameter is not
valid JSON');
+}
}
}
else if (params.query_params) {
@@ -169,6 +172,9 @@ function main(params) {
catch (e) {
reject(sendError(400, 'The query_params
parameter cannot be parsed. Ensure it is valid JSON.'));
}
+if (typeof updatedParams.query_params !==
'object') {
+reject(sendError(400, 'The query_params
parameter is not valid JSON'));
+}
}
} else {
reject(sendError(400, 'The query_params parameter
is only allowed if the filter parameter is defined'));
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houshengbo opened a new pull request #66: Remove the redundant configuration loadings
houshengbo opened a new pull request #66: Remove the redundant configuration loadings URL: https://github.com/apache/incubator-openwhisk-release/pull/66 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet opened a new pull request #163: validate that query_params is valid JSON
jasonpet opened a new pull request #163: validate that query_params is valid JSON URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/163 If invalid JSON for query_params is passed to the cloudant-follow API it will throw an exception and crash the provider. /cloudantTrigger/node_modules/cloudant-follow/lib/feed.js:234 query_params[key] = self[key]; ^ TypeError: Cannot create property 'feed' on string 'tweet' at /cloudantTrigger/node_modules/cloudant-follow/lib/feed.js:234:25 at Array.forEach () at Feed.query_feed [as query] (/cloudantTrigger/node_modules/cloudant-follow/lib/feed.js:232:8) at Request.db_response [as _callback] (/cloudantTrigger/node_modules/cloudant-follow/lib/feed.js:216:17) at Request.self.callback (/cloudantTrigger/node_modules/request/request.js:186:22) at emitTwo (events.js:126:13) at Request.emit (events.js:214:7) at Request. (/cloudantTrigger/node_modules/request/request.js:1163:10) at emitOne (events.js:116:13) at Request.emit (events.js:211:7) at IncomingMessage. (/cloudantTrigger/node_modules/request/request.js:1085:12) at Object.onceWrapper (events.js:313:30) at emitNone (events.js:111:20) at IncomingMessage.emit (events.js:208:7) at endReadableNT (_stream_readable.js:1064:12) at _combinedTickCallback (internal/process/next_tick.js:138:11) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE
mrutkows commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/809#issuecomment-374347856 See https://github.com/apache/incubator-openwhisk/blob/master/docs/cli.md#setting-up-the-openwhisk-cli documented as a "tip" ``` Tip: The OpenWhisk CLI stores the properties set in ~/.wskprops by default. The location of this file can be altered by setting the WSK_CONFIG_FILE environment variable. ``` documented Mar2017: https://github.com/apache/incubator-openwhisk/pull/2000 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #807: Deprecating Interactive Mode and introducing Dry Run
mrutkows commented on issue #807: Deprecating Interactive Mode and introducing Dry Run URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/807#issuecomment-374344097 @pritidesai seeing "dry run" as a top-level command when export is avail (target file) and could be a variant (target screen); seems like it is an export variant… how hard would it be to make it a subcommand of export? In addition, "dry run" is a concept that may not translate well... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new pull request #71: Changing default namespace from guest to _
pritidesai opened a new pull request #71: Changing default namespace from guest to _ URL: https://github.com/apache/incubator-openwhisk-client-go/pull/71 Addressing @rabbah's comment from here https://github.com/apache/incubator-openwhisk-wskdeploy/issues/810 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs
dubee commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175545924
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
Review comment:
This is correct.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs
dubee commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175545520
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
+"binary": false
+},
+"annotations": [
+{
+"key": "exec",
+"value": "nodejs:6"
+}
+],
+"limits": {
+"timeout": 6,
+"memory": 256,
+"logs": 10
+},
+"publish": false
+}
+```
+
+### Getting an action URL
+
+An action can be invoked through the REST interface via an HTTPS request. To
get an action URL, execute the following command:
+
+```
+wsk action get actionName --url
+```
+```
+ok: got action actionName
+https://${APIHOST}/api/v1/namespaces/${NAMESPACE}/actions/actionName
+```
+
+**Note:** Authentication must be provided when invoking an action via an HTTPS
request. For more information regarding
+action invocations using the REST interface, see
+[Using REST APIs with OpenWhisk](rest_api.md#actions).
+
+### Saving action code
+
+Code associated with an existing action is fetched and saved locally. Saving
is performed on all actions except sequences and docker actions. When saving
action code to a file, the code is saved in the current working directory, and
the saved file path is displayed.
Review comment:
@mdeuser, I remember @jpkessle saying `is` instead of `can be`. See
https://github.com/apache/incubator-openwhisk/pull/2873.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows commented on issue #810: wskdeploy assumed "guest" namespace if one is not set
mrutkows commented on issue #810: wskdeploy assumed "guest" namespace if one is not set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/810#issuecomment-374322281 @rabbah yes, it is in Go client, we make not assumptions in wskdeploy; however, at one point we copied the code from Go client (no longer) and still have a legacy comment that we default to guest (perhaps the "we" is collectively including the known behavior from Go client): grep -rn "guest" . ``` ./wski18n/resources/en_US.all.json:236:"translation": "\nPlease provide a namespace [default value is guest]: " ./parsers/manifest_parser.go:248://The namespace for this package is absent, so we use default guest here. ./parsers/manifest_parser.go:968: * "namespace":"guest", ``` @pritidesai We do need to remove the translated string that indicates we default to guest as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #810: wskdeploy assumed "guest" namespace if one is not set
mrutkows commented on issue #810: wskdeploy assumed "guest" namespace if one is not set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/810#issuecomment-374322281 @rabbah yes, it is in Go client, we make not assumptions in wskdeploy; however, at one point we copied the code from Go client (no longer) and still have a legacy comment that we default to guest (perhaps the "we" is collectively including the known behavior from Go client): grep -rn "guest" . ``` ./wski18n/resources/en_US.all.json:236:"translation": "\nPlease provide a namespace [default value is guest]: " ./deployers/whiskclient_test.go:46: WSKPROPS_NAMESPACE = "guest" ./parsers/manifest_parser.go:248://The namespace for this package is absent, so we use default guest here. ./parsers/manifest_parser.go:968: * "namespace":"guest", ``` @pritidesai We do need to remove the translated string that indicates we default to guest as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser closed issue #3462: Update "limit" flag description to include default, min, max behavior
mdeuser closed issue #3462: Update "limit" flag description to include default, min, max behavior URL: https://github.com/apache/incubator-openwhisk/issues/3462 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser closed pull request #3463: Update API v1 swagger "limit" parameter description
mdeuser closed pull request #3463: Update API v1 swagger "limit" parameter
description
URL: https://github.com/apache/incubator-openwhisk/pull/3463
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/controller/src/main/resources/apiv1swagger.json
b/core/controller/src/main/resources/apiv1swagger.json
index 599330b3b6..f19c3e2436 100644
--- a/core/controller/src/main/resources/apiv1swagger.json
+++ b/core/controller/src/main/resources/apiv1swagger.json
@@ -79,7 +79,7 @@
{
"name": "limit",
"in": "query",
-"description": "Number of entities to include in the
result.",
+"description": "Number of entities to include in the
result (0-200). The default limit is 30. A value of 0 sets the limit to the
maximum.",
"required": false,
"type": "integer"
},
@@ -384,7 +384,7 @@
{
"name": "limit",
"in": "query",
-"description": "Number of entities to include in the
result.",
+"description": "Number of entities to include in the
result (0-200). The default limit is 30. A value of 0 sets the limit to the
maximum.",
"required": false,
"type": "integer"
},
@@ -646,7 +646,7 @@
{
"name": "limit",
"in": "query",
-"description": "Number of entities to include in the
result.",
+"description": "Number of entities to include in the
result (0-200). The default limit is 30. A value of 0 sets the limit to the
maximum.",
"required": false,
"type": "integer"
},
@@ -916,7 +916,7 @@
{
"name": "limit",
"in": "query",
-"description": "Number of entities to include in the
result.",
+"description": "Number of entities to include in the
result (0-200). The default limit is 30. A value of 0 sets the limit to the
maximum.",
"required": false,
"type": "integer"
},
@@ -1130,7 +1130,7 @@
{
"name": "limit",
"in": "query",
-"description": "Number of entities to include in the
result.",
+"description": "Number of entities to include in the
result (0-200). The default limit is 30. A value of 0 sets the limit to the
maximum.",
"required": false,
"type": "integer"
},
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai commented on issue #810: wskdeploy assumed "guest" namespace if one is not set
pritidesai commented on issue #810: wskdeploy assumed "guest" namespace if one is not set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/810#issuecomment-374321035 Default namespace "guest" is coming from [Go Client](https://github.com/apache/incubator-openwhisk-client-go/blob/master/whisk/wskprops.go#L41). Changing in Go Client. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3453: [wip] Introduce a AttachmentStore SPI
chetanmeh commented on issue #3453: [wip] Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-374316859 All the test (non containers ones) [passed][0] with [use of `MemoryAttachmentStore`][1] in a separate branch. This PR for now just introduces `MemoryAttachmentStore` and refactors `CouchDbRestStore` to use the `AttachmentStore` abstraction. It does not switch to memory one for test for now [0]: https://travis-ci.org/chetanmeh/incubator-openwhisk/builds/355356744 [1]: https://github.com/chetanmeh/incubator-openwhisk/compare/attachment-store...chetanmeh:attachment-store-memory This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3453: [wip] Introduce a AttachmentStore SPI
chetanmeh commented on issue #3453: [wip] Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-374316859 All the test (non containers ones) [passed][0] with [use of `MemoryAttachmentStore`][1] [0]: https://travis-ci.org/chetanmeh/incubator-openwhisk/builds/355356744 [1]: https://github.com/chetanmeh/incubator-openwhisk/compare/attachment-store...chetanmeh:attachment-store-memory This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175532243
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
+"binary": false
+},
+"annotations": [
+{
+"key": "exec",
+"value": "nodejs:6"
+}
+],
+"limits": {
+"timeout": 6,
+"memory": 256,
+"logs": 10
+},
+"publish": false
+}
+```
+
+### Getting an action URL
+
+An action can be invoked through the REST interface via an HTTPS request. To
get an action URL, execute the following command:
+
+```
+wsk action get actionName --url
+```
+```
+ok: got action actionName
+https://${APIHOST}/api/v1/namespaces/${NAMESPACE}/actions/actionName
+```
+
+**Note:** Authentication must be provided when invoking an action via an HTTPS
request. For more information regarding
+action invocations using the REST interface, see
+[Using REST APIs with OpenWhisk](rest_api.md#actions).
+
+### Saving action code
+
+Code associated with an existing action is fetched and saved locally. Saving
is performed on all actions except sequences and docker actions. When saving
action code to a file, the code is saved in the current working directory, and
the saved file path is displayed.
Review comment:
"Code associated with an existing action `can be` fetched and saved locally."
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175532475
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
+"binary": false
+},
+"annotations": [
+{
+"key": "exec",
+"value": "nodejs:6"
+}
+],
+"limits": {
+"timeout": 6,
+"memory": 256,
+"logs": 10
+},
+"publish": false
+}
+```
+
+### Getting an action URL
+
+An action can be invoked through the REST interface via an HTTPS request. To
get an action URL, execute the following command:
+
+```
+wsk action get actionName --url
+```
+```
+ok: got action actionName
+https://${APIHOST}/api/v1/namespaces/${NAMESPACE}/actions/actionName
+```
+
+**Note:** Authentication must be provided when invoking an action via an HTTPS
request. For more information regarding
+action invocations using the REST interface, see
+[Using REST APIs with OpenWhisk](rest_api.md#actions).
+
+### Saving action code
+
+Code associated with an existing action is fetched and saved locally. Saving
is performed on all actions except sequences and docker actions. When saving
action code to a file, the code is saved in the current working directory, and
the saved file path is displayed.
+
+1. Save action code to a filename that corresponds with an existing action
name. A file extension that corresponds to the action kind is used, or an
extension of `.zip` will be used for action code that is a zip file.
Review comment:
extra space in `...action kind is used..`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175529235
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
Review comment:
by default, for `nodejs` kinds, is the `code` also returned?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175533787
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
+"binary": false
+},
+"annotations": [
+{
+"key": "exec",
+"value": "nodejs:6"
+}
+],
+"limits": {
+"timeout": 6,
+"memory": 256,
+"logs": 10
+},
+"publish": false
+}
+```
+
+### Getting an action URL
+
+An action can be invoked through the REST interface via an HTTPS request. To
get an action URL, execute the following command:
+
+```
+wsk action get actionName --url
+```
+```
+ok: got action actionName
+https://${APIHOST}/api/v1/namespaces/${NAMESPACE}/actions/actionName
+```
+
+**Note:** Authentication must be provided when invoking an action via an HTTPS
request. For more information regarding
Review comment:
if the action is a web action, authentication is not required... not sure
how/if web action caveats need to be in this doc..
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI
docs
URL:
https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175533109
##
File path: docs/actions.md
##
@@ -1219,6 +1184,71 @@ This command starts a polling loop that continuously
checks for logs from activa
Similarly, whenever you run the poll utility, you see in real time the logs
for any actions running on your behalf in OpenWhisk.
+## Getting actions
+
+Metadata that describes existing actions can be retrieved via the `wsk action
get` command.
+
+```
+wsk action get hello
+ok: got action hello
+{
+"namespace": "u...@email.com",
+"name": "hello",
+"version": "0.0.1",
+"exec": {
+"kind": "nodejs:6",
+"binary": false
+},
+"annotations": [
+{
+"key": "exec",
+"value": "nodejs:6"
+}
+],
+"limits": {
+"timeout": 6,
+"memory": 256,
+"logs": 10
+},
+"publish": false
+}
+```
+
+### Getting an action URL
+
+An action can be invoked through the REST interface via an HTTPS request. To
get an action URL, execute the following command:
+
+```
+wsk action get actionName --url
+```
+```
+ok: got action actionName
+https://${APIHOST}/api/v1/namespaces/${NAMESPACE}/actions/actionName
+```
+
+**Note:** Authentication must be provided when invoking an action via an HTTPS
request. For more information regarding
+action invocations using the REST interface, see
+[Using REST APIs with OpenWhisk](rest_api.md#actions).
+
+### Saving action code
+
+Code associated with an existing action is fetched and saved locally. Saving
is performed on all actions except sequences and docker actions. When saving
action code to a file, the code is saved in the current working directory, and
the saved file path is displayed.
+
+1. Save action code to a filename that corresponds with an existing action
name. A file extension that corresponds to the action kind is used, or an
extension of `.zip` will be used for action code that is a zip file.
+ ```
+ wsk action get actionName --save
+ ```
+ ```
+ ok: saved action code to /absolutePath/currentDirectory/actionName.js
+ ```
+
+2. Instead of allowing the CLI to determine the filename and extension of the
saved code, a custom filename and extension can be provided by using the
`--save-as` flag.
Review comment:
extra space in `..filename and extension of the saved code..`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs
dubee commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175523710 ## File path: docs/actions.md ## @@ -31,6 +31,7 @@ Learn how to create, invoke, and debug actions in your preferred development env In addition, learn about: * [Watching action output](#watching-action-output) +* [Getting actions](#getting-actions) Review comment: @mdeuser, was just following the pattern that is already use in the doc. For instance, see `Deleting actions`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] develpr closed issue #3465: Provisioning new VM with vagrant fails because there is no `vagrant` user
develpr closed issue #3465: Provisioning new VM with vagrant fails because there is no `vagrant` user URL: https://github.com/apache/incubator-openwhisk/issues/3465 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] develpr commented on issue #3465: Provisioning new VM with vagrant fails because there is no `vagrant` user
develpr commented on issue #3465: Provisioning new VM with vagrant fails because there is no `vagrant` user URL: https://github.com/apache/incubator-openwhisk/issues/3465#issuecomment-374298412 Confirmed! That was indeed the issue. I for some reason thought that Vagrant would automatically force an upgrade of the base box, or that the base box version constraint was somehow part of the `Vagrantfile`. For anybody who finds this in the future, `vagrant box remove ubuntu/xenial64` and then `vagrant up` (or `./hello`) seems to have resolved this issue for me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3421: Add ElasticSearch Log Store
dubee commented on issue #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#issuecomment-374297655 PG3 2010 🔵 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #162: updates to cloudant health monitoring
dubee closed pull request #162: updates to cloudant health monitoring
URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/162
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/provider/app.js b/provider/app.js
index 0bfd33d..fc9149d 100644
--- a/provider/app.js
+++ b/provider/app.js
@@ -35,7 +35,7 @@ var dbPrefix = process.env.DB_PREFIX;
var databaseName = dbPrefix + constants.TRIGGER_DB_SUFFIX;
var redisUrl = process.env.REDIS_URL;
var monitoringAuth = process.env.MONITORING_AUTH;
-var monitoringInterval = process.env.MONITORING_INTERVAL;
+var monitoringInterval = process.env.MONITORING_INTERVAL ||
constants.MONITOR_INTERVAL;
var filterDDName = '_design/' + constants.FILTERS_DESIGN_DOC;
var viewDDName = '_design/' + constants.VIEWS_DESIGN_DOC;
@@ -219,8 +219,8 @@ function init(server) {
if (monitoringAuth) {
setInterval(function () {
-providerHealth.monitor(monitoringAuth);
-}, monitoringInterval || constants.MONITOR_INTERVAL);
+providerHealth.monitor(monitoringAuth, monitoringInterval);
+}, monitoringInterval);
}
})
.catch(err => {
diff --git a/provider/lib/health.js b/provider/lib/health.js
index eb2832d..b13d6ad 100644
--- a/provider/lib/health.js
+++ b/provider/lib/health.js
@@ -45,7 +45,7 @@ module.exports = function(logger, utils) {
});
};
-this.monitor = function(apikey) {
+this.monitor = function(apikey, monitoringInterval) {
var method = 'monitor';
var auth = apikey.split(':');
@@ -63,9 +63,6 @@ module.exports = function(logger, utils) {
var existingTriggerID = `:_:${triggerName}`;
var existingCanaryID = canaryDocID;
-//delete trigger feed from database
-healthMonitor.deleteDocFromDB(existingTriggerID, 0);
-
//delete the trigger
var uri = utils.uriHost + '/api/v1/namespaces/_/triggers/' +
triggerName;
healthMonitor.deleteTrigger(existingTriggerID, uri, auth, 0);
@@ -89,7 +86,14 @@ module.exports = function(logger, utils) {
.then(info => {
logger.info(method, triggerID, info);
var newTrigger = healthMonitor.createCloudantTrigger(triggerID,
apikey);
-healthMonitor.createDocInDB(triggerID, newTrigger);
+utils.createTrigger(newTrigger);
+setTimeout(function () {
+var canaryDoc = {
+isCanaryDoc: true,
+host: utils.host
+};
+healthMonitor.createDocInDB(canaryDocID, canaryDoc);
+}, monitoringInterval / 3);
})
.catch(err => {
logger.error(method, triggerID, err);
@@ -114,6 +118,8 @@ module.exports = function(logger, utils) {
filter: constants.MONITOR_DESIGN_DOC + '/' +
constants.DOCS_FOR_MONITOR,
query_params: {host: utils.host},
maxTriggers: 1,
+triggersLeft: 1,
+since: 'now',
worker: utils.worker,
monitor: utils.host
};
@@ -151,15 +157,6 @@ module.exports = function(logger, utils) {
utils.db.insert(doc, docID, function (err) {
if (!err) {
logger.info(method, docID, 'was successfully inserted');
-if (doc.monitor) {
-setTimeout(function () {
-var canaryDoc = {
-isCanaryDoc: true,
-host: utils.host
-};
-healthMonitor.createDocInDB(canaryDocID, canaryDoc);
-}, 1000 * 60);
-}
}
else {
logger.error(method, docID, err);
diff --git a/provider/lib/utils.js b/provider/lib/utils.js
index 7906c36..3e38e1a 100644
--- a/provider/lib/utils.js
+++ b/provider/lib/utils.js
@@ -73,6 +73,9 @@ module.exports = function(logger, triggerDB, redisClient) {
feed.on('confirm', function () {
logger.info(method, 'Added cloudant data trigger',
dataTrigger.id, 'listening for changes in database', dataTrigger.dbname);
+if (utils.isMonitoringTrigger(dataTrigger.monitor,
dataTrigger.id)) {
+utils.monitorStatus.triggerStarted = "success";
+}
resolve(dataTrigger.id);
});
});
@@ -100,8 +103,7 @@ module.exports = function(logger, triggerDB, redisClient) {
maxTriggers: maxTriggers,
triggersLeft: maxTriggers,
filter: newTrigger.filter,
-query_params: newTrigger.query_par
[GitHub] vvraskin commented on a change in pull request #3451: Fix several loadbalancer bugs.
vvraskin commented on a change in pull request #3451: Fix several loadbalancer
bugs.
URL:
https://github.com/apache/incubator-openwhisk/pull/3451#discussion_r175506456
##
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
##
@@ -71,6 +72,10 @@ class ShardingContainerPoolBalancer(config: WhiskConfig,
controllerInstance: Ins
/** State needed for scheduling. */
private val schedulingState = ShardingContainerPoolBalancerState()()
+ actorSystem.scheduler.schedule(0.seconds, 10.seconds) {
Review comment:
It might be better to use 60s interval on par with the statsd interval due
to the way kamon ingests the metrics to statsd. It sends both histogram and
gauges as timers, which forces our statsd plugin to take an average over all
received values since the last push which might cause some noise in the
resulting metric value, e.g. result in non-integer values after rounding.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mdeuser commented on issue #244: Add --web-secure option to action create/update
mdeuser commented on issue #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#issuecomment-374287285 @dubee - here's a pass at a doc update that should reflect the current cli syntax https://github.com/mdeuser/openwhisk/commit/b18a5dc9534c0e2ac7c44b0d4b4f841ad85ced1e This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3465: Provisioning new VM with vagrant fails because there is no `vagrant` user
chetanmeh commented on issue #3465: Provisioning new VM with vagrant fails because there is no `vagrant` user URL: https://github.com/apache/incubator-openwhisk/issues/3465#issuecomment-374280591 @develpr Whats the version of `ubuntu/xenial64` on your setup. It seems there was an [issue][1] with earlier version where vagrant user was not provisioned. This was fixed with v20180112.0.0. On my setup (ubuntu as base machine) with recent version it works as expected ``` $ vagrant box list | grep xenial ubuntu/xenial64 (virtualbox, 20180309.0.0) ``` [1]: https://bugs.launchpad.net/cloud-images/+bug/1569237 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE
rabbah commented on issue #809: wskdeploy does not respect WSK_CONFIG_FILE URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/809#issuecomment-374262525 Thanks @lionelvillard - yes, I corrected the title and description. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lionelvillard commented on issue #809: wskdeploy does not respect WSK_CONFIG
lionelvillard commented on issue #809: wskdeploy does not respect WSK_CONFIG URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/809#issuecomment-374261915 Have you tried `WSK_CONFIG_FILE`? @rabbah This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] develpr opened a new issue #3465: Provisioning new VM with vagrant fails because there is no `vagrant` user
develpr opened a new issue #3465: Provisioning new VM with vagrant fails because there is no `vagrant` user URL: https://github.com/apache/incubator-openwhisk/issues/3465 ## Environment details: *Vagrant install quick start method used* Host: macOS High Sierra Vagrant: 2.0.2 VirtualBox: 5.2.8 ## Steps to reproduce the issue: 1. clone `https://github.com/apache/incubator-openwhisk` 2. cd `/tools/vagrant` 3. `./hello` ## Provide the expected results and outputs: I expected the results outlined in the readme / quick start ## Provide the actual results and outputs: From what I can tell, the `vagrant` user isn't created during provisioning. I googled a bit but it's not clear to me "why" - I actually had thought that the creation of the `vagrant` user was a default part of provisioning a new VM via Vagrant, but... here we are: ``` ...SNIP SNIP SNIP... default: ++ echo OPENWHISK_TMP_DIR=/home/vagrant/.openwhisk/ansible/tmp default: ++ echo PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/snap/bin:/home/vagrant/bin:/home/vagrant/openwhisk/tools/build default: ++ cd /home/vagrant/openwhisk default: ++ cd tools/ubuntu-setup default: ++ su vagrant -c 'source all.sh' default: No passwd entry for user 'vagrant' ``` If I `vagrant ssh` into the box, and use this command which I _think_ will list all users: ```ubuntu@ubuntu-xenial:~$ cut -d: -f1 /etc/passwd root daemon bin sys sync games man lp mail news uucp proxy www-data backup list irc gnats nobody systemd-timesync systemd-network systemd-resolve systemd-bus-proxy syslog _apt lxd messagebus uuidd dnsmasq sshd pollinate ubuntu vboxadd``` Note there is no `vagrant` user on the list. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #810: wskdeploy assumed "guest" namespace if one is not set
rabbah opened a new issue #810: wskdeploy assumed "guest" namespace if one is not set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/810 if you have a .wskprops file without a NAMESPACE defined, it appears wskdeploy assumes "guest" as the namespace which is incorrect. It should use "_" or do an actual look up and retrieve the namespace. ``` > wskdeploy export Info: The API host is [https://openwhisk.ng.bluemix.net], from .wskprops. Info: The auth key is set, from .wskprops. Info: The namespace is [guest], from .wskprops. Info: Unmarshal OpenWhisk runtimes from local values. Error: The supplied authentication is not authorized to access 'guest'. (code 2898491) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah opened a new issue #809: wskdeploy does not respect WSK_CONFIG
rabbah opened a new issue #809: wskdeploy does not respect WSK_CONFIG URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/809 if you set `WSK_CONFIG`, the `wsk` cli will use its settings for wskprops. It appears that wskdeploy ignores this setting and always uses `~/.wskprops`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #755: Whisk Deploy Export Functionality
rabbah commented on issue #755: Whisk Deploy Export Functionality URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/755#issuecomment-374255312 Is this expected to work? ``` > wskdeploy export Info: The API host is [https://openwhisk.ng.bluemix.net], from .wskprops. Info: The auth key is set, from .wskprops. Info: The namespace is [rabbah_dev], from .wskprops. Info: Unmarshal OpenWhisk runtimes from local values. Manifest exported to: ``` directory is empty at that point. It doesn't look like anything happened. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175470396 ## File path: docs/actions.md ## @@ -31,6 +31,7 @@ Learn how to create, invoke, and debug actions in your preferred development env In addition, learn about: * [Watching action output](#watching-action-output) +* [Getting actions](#getting-actions) Review comment: currently, only one action can be retrieved at a time... plural not needed here..? i.e. `Getting an action` `Getting` vs `Retrieving` or `Obtaining`..? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #244: Add --web-secure option to action create/update
mdeuser commented on issue #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#issuecomment-374245598 @dubee - agree.. a doc update will be needed once we all agree on the updated cli syntax This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davidbreitgand commented on issue #804: Fix for 730
davidbreitgand commented on issue #804: Fix for 730 URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/804#issuecomment-374245199 @pritidesai My two cents: "dependency" will become an over-loaded term if we use it beyond describing dependencies on packages from github and whisk.system. For that reason we thought of using "relationships" and defining all relationships between projects explicitly at the granularity of an asset and not necessarily a package. IMHO, introducing a separate [optional] relationship manifest minimizes impact on the existing code and gets us backward compatibility, while the alternative (although definitely doable and reasonable) has much more impact on the current code base. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee opened a new pull request #3464: Add wsk action get to CLI docs
dubee opened a new pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464 Adds an `wsk action get` example to the docs. Also groups examples of getting an action URL and saving action code around the new section. ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jasonpet opened a new pull request #162: updates to cloudant health monitoring
jasonpet opened a new pull request #162: updates to cloudant health monitoring URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/162 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3421: Add ElasticSearch Log Store
dubee commented on issue #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#issuecomment-374233516 @markusthoemmes, I think this one is ready to go unless you have anymore comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3404: bump dockerskeleton to pick up curl and wget 1.2.0
csantanapr commented on issue #3404: bump dockerskeleton to pick up curl and wget 1.2.0 URL: https://github.com/apache/incubator-openwhisk/pull/3404#issuecomment-374228991 Thank you @dubee This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #3404: bump dockerskeleton to pick up curl and wget 1.2.0
dubee closed pull request #3404: bump dockerskeleton to pick up curl and wget 1.2.0 URL: https://github.com/apache/incubator-openwhisk/pull/3404 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/actionRuntimes/actionProxy/Dockerfile b/actionRuntimes/actionProxy/Dockerfile index 9d28b0acce..b7634a28c9 100644 --- a/actionRuntimes/actionProxy/Dockerfile +++ b/actionRuntimes/actionProxy/Dockerfile @@ -1,2 +1,2 @@ # Dockerfile for docker skeleton (useful for running blackbox binaries, scripts, or Python 3 actions) . -FROM openwhisk/dockerskeleton:1.1.0 +FROM openwhisk/dockerskeleton:1.2.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’
rabbah commented on issue #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’ URL: https://github.com/apache/incubator-openwhisk/pull/3457#issuecomment-374222344 This should probably get a PG for good measure. LGTM otherwise. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #3449: Code clean up
csantanapr closed pull request #3449: Code clean up
URL: https://github.com/apache/incubator-openwhisk/pull/3449
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/roles/controller/tasks/deploy.yml
b/ansible/roles/controller/tasks/deploy.yml
index 68d7efa572..a02cf79592 100644
--- a/ansible/roles/controller/tasks/deploy.yml
+++ b/ansible/roles/controller/tasks/deploy.yml
@@ -49,14 +49,14 @@
when: kafka.protocol == 'SSL'
copy:
src: "{{ openwhisk_home }}/ansible/roles/kafka/files/{{
kafka.ssl.keystore.name }}"
-dest: "{{ controller.confdir }}/controller{{
groups['controllers'].index(inventory_hostname) }}"
+dest: "{{ controller.confdir }}/{{ controller_name }}"
- name: copy nginx certificate keystore
when: controller.protocol == 'https'
copy:
src: files/{{ controllerKeystoreName }}
mode: 0666
-dest: "{{ controller.confdir }}/controller{{
groups['controllers'].index(inventory_hostname) }}"
+dest: "{{ controller.confdir }}/{{ controller_name }}"
become: "{{ controller.dir.become }}"
- name: copy certificates
@@ -64,7 +64,7 @@
copy:
src: "{{ openwhisk_home }}/ansible/roles/controller/files/{{ item }}"
mode: 0666
-dest: "{{ controller.confdir }}/controller{{
groups['controllers'].index(inventory_hostname) }}"
+dest: "{{ controller.confdir }}/{{ controller_name }}"
with_items:
- "{{ controller.ssl.cert }}"
- "{{ controller.ssl.key }}"
@@ -208,10 +208,10 @@
- name: wait until the Controller in this host is up and running
uri:
-url: "{{ controller.protocol }}://{{ ansible_host }}:{{
controller.basePort + groups['controllers'].index(inventory_hostname) }}/ping"
+url: "{{ controller.protocol }}://{{ ansible_host }}:{{
controller.basePort + (controller_index | int) }}/ping"
validate_certs: no
-client_key: "{{ controller.confdir }}/controller{{
groups['controllers'].index(inventory_hostname) }}/{{ controller.ssl.key }}"
-client_cert: "{{ controller.confdir }}/controller{{
groups['controllers'].index(inventory_hostname) }}/{{ controller.ssl.cert }}"
+client_key: "{{ controller.confdir }}/{{ controller_name }}/{{
controller.ssl.key }}"
+client_cert: "{{ controller.confdir }}/{{ controller_name }}/{{
controller.ssl.cert }}"
register: result
until: result.status == 200
retries: 12
diff --git a/tests/src/test/scala/common/rest/WskRest.scala
b/tests/src/test/scala/common/rest/WskRest.scala
index 71ec04a7b1..c2d72b837d 100644
--- a/tests/src/test/scala/common/rest/WskRest.scala
+++ b/tests/src/test/scala/common/rest/WskRest.scala
@@ -1272,7 +1272,7 @@ class RunWskRestCmd() extends FlatSpec with RunWskCmd
with Matchers with ScalaFu
val entity = body map { b =>
HttpEntity(ContentTypes.`application/json`, b)
-} getOrElse HttpEntity(ContentTypes.`application/json`, "")
+} getOrElse HttpEntity.Empty
val request =
HttpRequest(
diff --git a/tests/src/test/scala/system/basic/WskRuleTests.scala
b/tests/src/test/scala/system/basic/WskRuleTests.scala
index c0fc9d020e..a454008789 100644
--- a/tests/src/test/scala/system/basic/WskRuleTests.scala
+++ b/tests/src/test/scala/system/basic/WskRuleTests.scala
@@ -91,7 +91,7 @@ abstract class WskRuleTests extends TestHelpers with
WskTestHelpers {
val active = Some("active".toJson)
val inactive = Some("inactive".toJson)
val statusPermutations =
- Seq((triggerName, active), (triggerName, inactive), (triggerName2,
active), (triggerName2, inactive))
+ Seq((triggerName, active), (triggerName, inactive), (triggerName2,
active), (triggerName, inactive))
ruleSetup(Seq((ruleName, triggerName, (actionName, actionName,
defaultAction))), assetHelper)
assetHelper.withCleaner(wsk.trigger, triggerName2) { (trigger, name) =>
diff --git
a/tests/src/test/scala/whisk/core/connector/test/MessageFeedTests.scala
b/tests/src/test/scala/whisk/core/connector/test/MessageFeedTests.scala
index c6743aadab..048554fa2e 100644
--- a/tests/src/test/scala/whisk/core/connector/test/MessageFeedTests.scala
+++ b/tests/src/test/scala/whisk/core/connector/test/MessageFeedTests.scala
@@ -1,11 +1,12 @@
/*
- * Copyright 2015-2016 IBM Corporation
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compli
