[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] csantanapr closed pull request #3744: Bump reference for PHP 7.1 image

csantanapr closed pull request #3744: Bump reference for PHP 7.1 image URL: https://github.com/apache/incubator-openwhisk/pull/3744 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] csantanapr closed pull request #3467: Remove actionControllers tests from incubator-openwhisk repo

csantanapr closed pull request #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] csantanapr commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

csantanapr commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-395938557 PG 5 374  This is an automated message

[GitHub] rabbah commented on a change in pull request #3741: Cleaning up the test related classes

rabbah commented on a change in pull request #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#discussion_r194212930 ## File path: tests/src/test/scala/common/WskCliOperations.scala ## @@ -62,18 +65,17 @@ import

[GitHub] rabbah commented on a change in pull request #3741: Cleaning up the test related classes

rabbah commented on a change in pull request #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#discussion_r194212933 ## File path: tests/src/test/scala/common/WskCliOperations.scala ## @@ -161,68 +162,11 @@ trait

[GitHub] rabbah commented on a change in pull request #3741: Cleaning up the test related classes

rabbah commented on a change in pull request #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#discussion_r194213004 ## File path: tests/src/test/scala/common/rest/WskRestOperations.scala ## @@ -1186,34 +1170,34 @@

[GitHub] rabbah commented on a change in pull request #3741: Cleaning up the test related classes

rabbah commented on a change in pull request #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#discussion_r194212918 ## File path: tests/src/test/scala/common/RunCliCmd.scala ## @@ -0,0 +1,118 @@ +/* + * Licensed to

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] tysonnorris opened a new pull request #94: Add Concurrency to Limits

tysonnorris opened a new pull request #94: Add Concurrency to Limits URL: https://github.com/apache/incubator-openwhisk-client-go/pull/94 Adds a --concurrency flag to `wsk action create` to specify the concurrency limit for the action. Blocked by: *

[GitHub] codecov-io commented on issue #3744: Bump reference for PHP 7.1 image

codecov-io commented on issue #3744: Bump reference for PHP 7.1 image URL: https://github.com/apache/incubator-openwhisk/pull/3744#issuecomment-395909455 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3744?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3507: allow use of string for controller id

codecov-io commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3507: allow use of string for controller id

codecov-io commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr=h1) Report > Merging

[GitHub] akrabat opened a new pull request #3744: Bump reference for PHP image

akrabat opened a new pull request #3744: Bump reference for PHP image URL: https://github.com/apache/incubator-openwhisk/pull/3744 Updating the PHP 7.1 runtime version from 7.1.9 to 7.1.18. See https://github.com/apache/incubator-openwhisk-runtime-php/compare/7.1@1.0.0...7.1@1.0.1

[GitHub] akrabat commented on issue #29: remove the test filter for 7.1

akrabat commented on issue #29: remove the test filter for 7.1 URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/29#issuecomment-395899614 Note that I have incorporated this into https://github.com/apache/incubator-openwhisk-runtime-php/pull/28

[GitHub] akrabat commented on issue #28: Add PHP 7.2.6 runtime

akrabat commented on issue #28: Add PHP 7.2.6 runtime URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/28#issuecomment-395899400 @csantanapr Tests added now! This is an automated message from the Apache

[GitHub] tysonnorris commented on a change in pull request #3507: allow use of string for controller id

tysonnorris commented on a change in pull request #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r194187839 ## File path: common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala ## @@

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] tysonnorris commented on a change in pull request #3507: allow use of string for controller id

tysonnorris commented on a change in pull request #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r194186386 ## File path: tests/src/test/scala/whisk/core/entity/test/ControllerInstanceIdTests.scala ##

[GitHub] tysonnorris commented on a change in pull request #3507: allow use of string for controller id

tysonnorris commented on a change in pull request #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r194186156 ## File path: core/controller/src/main/scala/whisk/core/controller/Controller.scala ## @@

[GitHub] dgrove-oss opened a new pull request #216: Stop testing non-Helm based deployments

dgrove-oss opened a new pull request #216: Stop testing non-Helm based deployments URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/216 Only very minor gaps left wrt the non-Helm deploy, and if the non-Helm deploy is broken by an upstream change, it is not worth

[GitHub] tysonnorris commented on a change in pull request #3507: allow use of string for controller id

tysonnorris commented on a change in pull request #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r194184826 ## File path: common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala ## @@

[GitHub] tysonnorris commented on a change in pull request #3507: allow use of string for controller id

tysonnorris commented on a change in pull request #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r194181785 ## File path: common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala ## @@

[GitHub] csantanapr closed pull request #215: Document persistent volumes and use of external db

csantanapr closed pull request #215: Document persistent volumes and use of external db URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/215 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] akrabat commented on a change in pull request #28: Add PHP 7.2.6 runtime

akrabat commented on a change in pull request #28: Add PHP 7.2.6 runtime URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/28#discussion_r194178772 ## File path: core/php7.2Action/php.ini ## @@ -0,0 +1,1948 @@ +; Licensed to the Apache Software

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] dgrove-oss opened a new pull request #215: Document persistent volumes and use of external db

dgrove-oss opened a new pull request #215: Document persistent volumes and use of external db URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/215 1. Add support for using an external database and document it. 2. Document support for using persistent volumes.

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3741: Cleaning up the test related classes

codecov-io commented on issue #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741#issuecomment-395872642 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3741?src=pr=h1) Report > Merging

[GitHub] mcdan opened a new pull request #3743: Fixes #3742 - just reomve the time range part of the query, each acti…

mcdan opened a new pull request #3743: Fixes #3742 - just reomve the time range part of the query, each acti… URL: https://github.com/apache/incubator-openwhisk/pull/3743 …vation is keyed with its activation ID already. ## Description Just remove the time

[GitHub] mcdan opened a new issue #3742: Splunk Log Sore may return an empty result set if the time zones are not the same

mcdan opened a new issue #3742: Splunk Log Sore may return an empty result set if the time zones are not the same URL: https://github.com/apache/incubator-openwhisk/issues/3742 ## Environment details: * local deployment, vagrant, native ubuntu, Mac OS, Bluemix, ... *

[GitHub] codecov-io commented on issue #3619: Provide an activation store SPI

codecov-io commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-387224274 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3740: Exclude logback-test.xml from test sources jar

codecov-io commented on issue #3740: Exclude logback-test.xml from test sources jar URL: https://github.com/apache/incubator-openwhisk/pull/3740#issuecomment-395860681 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3740?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3740: Exclude logback-test.xml from test sources jar

codecov-io commented on issue #3740: Exclude logback-test.xml from test sources jar URL: https://github.com/apache/incubator-openwhisk/pull/3740#issuecomment-395860681 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3740?src=pr=h1) Report > Merging

[GitHub] rabbah opened a new pull request #3741: Cleaning up the test related classes

rabbah opened a new pull request #3741: Cleaning up the test related classes URL: https://github.com/apache/incubator-openwhisk/pull/3741 This is a pass to clean up some of the type hierarchies that resulted from splitting of the tests between CLI and REST. In this PR, I removed

[GitHub] codecov-io commented on issue #2795: enable concurrent activation processing

codecov-io commented on issue #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#issuecomment-386889684 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2795?src=pr=h1) Report > Merging

[GitHub] chetanmeh opened a new pull request #3740: Exclude logback-test.xml from test sources jar

chetanmeh opened a new pull request #3740: Exclude logback-test.xml from test sources jar URL: https://github.com/apache/incubator-openwhisk/pull/3740 Excludes logback-test.xml from being packaged in test sources jar ## Description Fixes #3739 by avoiding `logback-test.xml`

[GitHub] dubee commented on a change in pull request #3619: Provide an activation store SPI

dubee commented on a change in pull request #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#discussion_r194139866 ## File path: common/scala/src/main/scala/whisk/core/entity/ActivationId.scala ## @@ -35,7 +35,7 @@

[GitHub] dubee commented on a change in pull request #3619: Provide an activation store SPI

dubee commented on a change in pull request #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#discussion_r194140528 ## File path: common/scala/src/main/scala/whisk/core/entity/ActivationId.scala ## @@ -35,7 +35,7 @@

[GitHub] dubee commented on a change in pull request #3619: Provide an activation store SPI

dubee commented on a change in pull request #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#discussion_r194140528 ## File path: common/scala/src/main/scala/whisk/core/entity/ActivationId.scala ## @@ -35,7 +35,7 @@

[GitHub] dubee commented on a change in pull request #3619: Provide an activation store SPI

dubee commented on a change in pull request #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#discussion_r194139866 ## File path: common/scala/src/main/scala/whisk/core/entity/ActivationId.scala ## @@ -35,7 +35,7 @@

[GitHub] tysonnorris commented on a change in pull request #2795: enable concurrent activation processing

tysonnorris commented on a change in pull request #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r194137386 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala ##

[GitHub] csantanapr commented on issue #28: Add PHP 7.2.6 runtime

csantanapr commented on issue #28: Add PHP 7.2.6 runtime URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/28#issuecomment-395840102 The new test file should look like this if there it's the same set of tests as 7.1 ```scala package runtime.actionContainers

[GitHub] csantanapr opened a new pull request #29: remove the filter for 7.1

csantanapr opened a new pull request #29: remove the filter for 7.1 URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/29 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] csantanapr opened a new issue #3739: all runtime repos have extra log statements in tests

csantanapr opened a new issue #3739: all runtime repos have extra log statements in tests URL: https://github.com/apache/incubator-openwhisk/issues/3739 For example https://travis-ci.org/apache/incubator-openwhisk-runtime-php/builds/389824675#L4837 At the start of the gradle tests

[GitHub] csantanapr closed pull request #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3

csantanapr closed pull request #27: Update to PHP 7.1.18, Uuid 3.7.3 & Guzzle 6.3.3 URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/27 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] tysonnorris commented on a change in pull request #2795: enable concurrent activation processing

tysonnorris commented on a change in pull request #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r194128903 ## File path: common/scala/src/main/scala/whisk/core/containerpool/ContainerFactory.scala

[GitHub] csantanapr closed pull request #17: update Travis to push master tag on Docker when master branch has cha…

csantanapr closed pull request #17: update Travis to push master tag on Docker when master branch has cha… URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/17 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] dubee commented on a change in pull request #3619: Provide an activation store SPI

dubee commented on a change in pull request #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#discussion_r194124702 ## File path: core/controller/src/main/scala/whisk/core/controller/Activations.scala ## @@ -159,40

[GitHub] dubee commented on a change in pull request #3619: Provide an activation store SPI

dubee commented on a change in pull request #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#discussion_r194124702 ## File path: core/controller/src/main/scala/whisk/core/controller/Activations.scala ## @@ -159,40

[GitHub] codecov-io commented on issue #3619: Provide an activation store SPI

codecov-io commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-387224274 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3704: Invoker graceful shutdown and drain mode

codecov-io commented on issue #3704: Invoker graceful shutdown and drain mode URL: https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-391821150 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=h1) Report > Merging

[GitHub] tysonnorris commented on a change in pull request #2795: enable concurrent activation processing

tysonnorris commented on a change in pull request #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r194111203 ## File path: tests/src/test/scala/whisk/core/containerpool/test/ContainerProxyTests.scala

[GitHub] tysonnorris commented on a change in pull request #2795: enable concurrent activation processing

tysonnorris commented on a change in pull request #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r194110006 ## File path: tests/src/test/scala/whisk/core/containerpool/test/ContainerProxyTests.scala

[GitHub] tysonnorris commented on a change in pull request #2795: enable concurrent activation processing

tysonnorris commented on a change in pull request #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r194109162 ## File path: tests/src/test/scala/whisk/core/containerpool/test/ContainerProxyTests.scala

[GitHub] tysonnorris commented on issue #2282: Distributed tracing support #2192

tysonnorris commented on issue #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#issuecomment-395804871 @sandeep-paliwal can you add the ability to leverage the "extra logging" header to force a trace generation on demand? (since sample

[GitHub] dubee commented on a change in pull request #3704: Invoker graceful shutdown and drain mode

dubee commented on a change in pull request #3704: Invoker graceful shutdown and drain mode URL: https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r194101322 ## File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala ## @@ -284,4

[GitHub] ddragosd commented on issue #132: Fix to fallback when LOCAL_IP cannot be obtained

ddragosd commented on issue #132: Fix to fallback when LOCAL_IP cannot be obtained URL: https://github.com/apache/incubator-openwhisk-devtools/pull/132#issuecomment-395803272 @apercova thank you very much for fixing the local IP issue. I'll be taking a look at it today.

[GitHub] codecov-io commented on issue #3704: Invoker graceful shutdown and drain mode

codecov-io commented on issue #3704: Invoker graceful shutdown and drain mode URL: https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-391821150 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3704: Invoker graceful shutdown and drain mode

codecov-io commented on issue #3704: Invoker graceful shutdown and drain mode URL: https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-391821150 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr=h1) Report > Merging

[GitHub] remore commented on a change in pull request #3725: Add Ruby2.5 runtime support

remore commented on a change in pull request #3725: Add Ruby2.5 runtime support URL: https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r194095317 ## File path: actionRuntimes/ruby2.5Action/build.gradle ## @@ -0,0 +1,2 @@ +ext.dockerImageName =

[GitHub] remore commented on a change in pull request #3725: Add Ruby2.5 runtime support

remore commented on a change in pull request #3725: Add Ruby2.5 runtime support URL: https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r194095264 ## File path: tests/src/test/scala/actionContainers/Ruby25ActionContainerTests.scala ## @@ -0,0 +1,408 @@

[GitHub] dgrove-oss opened a new pull request #181: Add openwhisk-kube-deploy to list of release repos.

dgrove-oss opened a new pull request #181: Add openwhisk-kube-deploy to list of release repos. URL: https://github.com/apache/incubator-openwhisk-release/pull/181 I believe the openwhisk-kube-deploy is compliant with all the requirements to be included as part of a release. I think it

[GitHub] dgrove-oss commented on a change in pull request #3507: allow use of string for controller id

dgrove-oss commented on a change in pull request #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r194089393 ## File path: common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala ## @@

[GitHub] rabbah opened a new issue #3738: Wsk object in tests doesn't permit for overriding CLI localtion

rabbah opened a new issue #3738: Wsk object in tests doesn't permit for overriding CLI localtion URL: https://github.com/apache/incubator-openwhisk/issues/3738 Tests from the CLI repo (and perhaps others) should be more explicit in which CLI they are using - otherwise, a newly built CLI

[GitHub] rabbah opened a new issue #3737: tests package needs some cleanup

rabbah opened a new issue #3737: tests package needs some cleanup URL: https://github.com/apache/incubator-openwhisk/issues/3737 The tests suite currently include api gateway tests which belong in the CLI test suite since they are just actions. The cli.tests package should be

[GitHub] dubee commented on a change in pull request #3694: Add retries to CLI test framework for network errors

dubee commented on a change in pull request #3694: Add retries to CLI test framework for network errors URL: https://github.com/apache/incubator-openwhisk/pull/3694#discussion_r194072596 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -1036,13 +1036,28 @@ trait

[GitHub] rabbah opened a new issue #316: running tests locally uses the wrong wsk binnary

rabbah opened a new issue #316: running tests locally uses the wrong wsk binnary URL: https://github.com/apache/incubator-openwhisk-cli/issues/316 When you run the scala tests in this repo, they pick up the `wsk` binary from, and worse, they use the settings from ~/.wskprops. The tests

[GitHub] daisy-ycguo closed pull request #214: Add Notice file

daisy-ycguo closed pull request #214: Add Notice file URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/214 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] markusthoemmes commented on a change in pull request #3507: allow use of string for controller id

markusthoemmes commented on a change in pull request #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r194047248 ## File path: common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala ## @@

[GitHub] akrabat opened a new pull request #3736: Add support for PHP 7.2 runtime

akrabat opened a new pull request #3736: Add support for PHP 7.2 runtime URL: https://github.com/apache/incubator-openwhisk/pull/3736 ## Description This PR adds PHP 7.2 as a new kind and sets the default PHP runtime to version 7.2. I have not provided runtime tests here as they

[GitHub] chetanmeh commented on a change in pull request #3722: Scala based admin tooling

chetanmeh commented on a change in pull request #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#discussion_r194026717 ## File path: core/admin/src/main/scala/whisk/core/cli/Main.scala ## @@ -0,0 +1,161 @@ +/* + * Licensed to

[GitHub] akrabat opened a new pull request #28: Add PHP 7.2.6 runtime

akrabat opened a new pull request #28: Add PHP 7.2.6 runtime URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/28 This runtime uses an updated router.php which runs the action code in the same process and enables PHP's OPcache byte-code cache. We also read the /init

[GitHub] codecov-io commented on issue #3453: Introduce a AttachmentStore SPI

codecov-io commented on issue #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-395695075 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=h1) Report > Merging

[GitHub] chetanmeh commented on a change in pull request #3704: Invoker graceful shutdown and drain mode

chetanmeh commented on a change in pull request #3704: Invoker graceful shutdown and drain mode URL: https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r194020514 ## File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala ## @@

[GitHub] codecov-io commented on issue #3453: Introduce a AttachmentStore SPI

codecov-io commented on issue #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-395695075 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3453: Introduce a AttachmentStore SPI

codecov-io commented on issue #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-395695075 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=h1) Report > Merging

[GitHub] chetanmeh commented on a change in pull request #3704: Invoker graceful shutdown and drain mode

chetanmeh commented on a change in pull request #3704: Invoker graceful shutdown and drain mode URL: https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r194017951 ## File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala ## @@

[GitHub] chetanmeh commented on a change in pull request #3704: Invoker graceful shutdown and drain mode

chetanmeh commented on a change in pull request #3704: Invoker graceful shutdown and drain mode URL: https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r194017675 ## File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala ## @@

[GitHub] chetanmeh commented on issue #3453: Introduce a AttachmentStore SPI

chetanmeh commented on issue #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-395718044 @rabbah This PR is now ready for review. This is an automated message

[GitHub] tz70s commented on issue #3712: Make it easier to configure max action exec size for a deployment

tz70s commented on issue #3712: Make it easier to configure max action exec size for a deployment URL: https://github.com/apache/incubator-openwhisk/issues/3712#issuecomment-395704029 It's kind of duplicate to #3530. I've done the config loading inside the Scala code. Do we need to

[GitHub] codecov-io commented on issue #3453: Introduce a AttachmentStore SPI

codecov-io commented on issue #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-395695075 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3453: Introduce a AttachmentStore SPI

codecov-io commented on issue #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-395695075 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3453?src=pr=h1) Report > Merging

[GitHub] rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support

rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support URL: https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193989185 ## File path: actionRuntimes/ruby2.5Action/build.gradle ## @@ -0,0 +1,2 @@ +ext.dockerImageName =

[GitHub] rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support

rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support URL: https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193988616 ## File path: tests/src/test/scala/actionContainers/Ruby25ActionContainerTests.scala ## @@ -0,0 +1,408 @@

[GitHub] rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support

rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support URL: https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193989185 ## File path: actionRuntimes/ruby2.5Action/build.gradle ## @@ -0,0 +1,2 @@ +ext.dockerImageName =

[GitHub] tz70s commented on issue #3530: factor out max code blob size to a deployment configuration

tz70s commented on issue #3530: factor out max code blob size to a deployment configuration URL: https://github.com/apache/incubator-openwhisk/issues/3530#issuecomment-395688771 Got it, thanks! This is an automated message

[GitHub] rabbah commented on a change in pull request #3507: allow use of string for controller id

rabbah commented on a change in pull request #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193981557 ## File path: common/scala/src/main/scala/whisk/core/entity/InvokerInstanceId.scala ## @@ -0,0

[GitHub] brunogirin commented on issue #899: wskdeploy export fails to export the `main` attribute for Java actions

brunogirin commented on issue #899: wskdeploy export fails to export the `main` attribute for Java actions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/899#issuecomment-395681714 @pritidesai I'll do that when I can, which may not be before next week.

  1   2   >