[GitHub] chetanmeh commented on a change in pull request #3619: Provide an activation store SPI

2018-06-12 Thread GitBox
chetanmeh commented on a change in pull request #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#discussion_r194952988 ## File path: common/scala/src/main/scala/whisk/core/entity/ActivationStore.scala ## @@ -0,0 +1,126

[GitHub] dubee commented on issue #3619: Provide an activation store SPI

2018-06-12 Thread GitBox
dubee commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-396799104 PG2 3237  This is an automated message from the Apache Git Service. To

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-06-12 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-396754172 @rabbah Yes, this is ready for review minus a final commit to address the tests (along with a small

[GitHub] mdeuser closed pull request #3694: Add retries to CLI test framework for network errors

2018-06-12 Thread GitBox
mdeuser closed pull request #3694: Add retries to CLI test framework for network errors URL: https://github.com/apache/incubator-openwhisk/pull/3694 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mdeuser commented on issue #3694: Add retries to CLI test framework for network errors

2018-06-12 Thread GitBox
mdeuser commented on issue #3694: Add retries to CLI test framework for network errors URL: https://github.com/apache/incubator-openwhisk/pull/3694#issuecomment-396751498 pg :large_blue_circle: :+1: This is an automated

[GitHub] apercova commented on issue #132: Fix to fallback when LOCAL_IP cannot be obtained

2018-06-12 Thread GitBox
apercova commented on issue #132: Fix to fallback when LOCAL_IP cannot be obtained URL: https://github.com/apache/incubator-openwhisk-devtools/pull/132#issuecomment-396318882 Hi @ddragosd thank you for reviewing the fix. I wonder if you could give me an insight on what SO's are you

[GitHub] rabbah commented on a change in pull request #324: Git pre-commit hook to format src.

2018-06-12 Thread GitBox
rabbah commented on a change in pull request #324: Git pre-commit hook to format src. URL: https://github.com/apache/incubator-openwhisk-cli/pull/324#discussion_r194901730 ## File path: tests/src/test/scala/whisk/core/cli/test/WskApiGwTests.scala ## @@ -42,6 +42,7 @@

[GitHub] mdeuser commented on a change in pull request #324: Git pre-commit hook to format src.

2018-06-12 Thread GitBox
mdeuser commented on a change in pull request #324: Git pre-commit hook to format src. URL: https://github.com/apache/incubator-openwhisk-cli/pull/324#discussion_r194899361 ## File path: tests/src/test/scala/whisk/core/cli/test/WskApiGwTests.scala ## @@ -42,6 +42,7 @@

[GitHub] rabbah commented on a change in pull request #311: Display appropriate message for trigger fire when 204 is returned

2018-06-12 Thread GitBox
rabbah commented on a change in pull request #311: Display appropriate message for trigger fire when 204 is returned URL: https://github.com/apache/incubator-openwhisk-cli/pull/311#discussion_r194896146 ## File path: commands/trigger.go ## @@ -92,13 +92,24 @@ var

[GitHub] mdeuser commented on a change in pull request #311: Display appropriate message for trigger fire when 204 is returned

2018-06-12 Thread GitBox
mdeuser commented on a change in pull request #311: Display appropriate message for trigger fire when 204 is returned URL: https://github.com/apache/incubator-openwhisk-cli/pull/311#discussion_r194895661 ## File path: commands/trigger.go ## @@ -92,13 +92,24 @@ var

[GitHub] mdeuser commented on issue #2941: Add api gateway test that uses custom package for action

2018-06-12 Thread GitBox
mdeuser commented on issue #2941: Add api gateway test that uses custom package for action URL: https://github.com/apache/incubator-openwhisk/pull/2941#issuecomment-396740833 @drcariel - i believe this test was created after the rest/cli refactoring and may need additional work to enable

[GitHub] mdeuser commented on a change in pull request #2941: Add api gateway test that uses custom package for action

2018-06-12 Thread GitBox
mdeuser commented on a change in pull request #2941: Add api gateway test that uses custom package for action URL: https://github.com/apache/incubator-openwhisk/pull/2941#discussion_r194894738 ## File path: tests/src/test/scala/whisk/core/cli/test/ApiGwRestBasicTests.scala

[GitHub] Ahmed-elsayed-mahmoud opened a new issue #3755: Change the load balancer to reduce invoker activation queueing

2018-06-12 Thread GitBox
Ahmed-elsayed-mahmoud opened a new issue #3755: Change the load balancer to reduce invoker activation queueing URL: https://github.com/apache/incubator-openwhisk/issues/3755 ## Problem statement: The current workflow of queueing activations to per-invoker topics has some

[GitHub] bwmcadams commented on issue #3515: Introduce separate Akka dispatchers for CouchDB and Kafka Clients (#2954)

2018-06-12 Thread GitBox
bwmcadams commented on issue #3515: Introduce separate Akka dispatchers for CouchDB and Kafka Clients (#2954) URL: https://github.com/apache/incubator-openwhisk/pull/3515#issuecomment-396726514 Makes sense to me. I know it occurred to me while I was putting this together, and tunable

[GitHub] bwmcadams commented on issue #3515: Introduce separate Akka dispatchers for CouchDB and Kafka Clients (#2954)

2018-06-12 Thread GitBox
bwmcadams commented on issue #3515: Introduce separate Akka dispatchers for CouchDB and Kafka Clients (#2954) URL: https://github.com/apache/incubator-openwhisk/pull/3515#issuecomment-396726514 Makes sense to me. I know it occurred to me while I was putting this together, and tunable

[GitHub] codecov-io commented on issue #3694: Add retries to CLI test framework for network errors

2018-06-12 Thread GitBox
codecov-io commented on issue #3694: Add retries to CLI test framework for network errors URL: https://github.com/apache/incubator-openwhisk/pull/3694#issuecomment-391475522 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr=h1) Report > Merging

[GitHub] houshengbo closed pull request #183: Adjust docs to reflect addition of Kube deployment to release repos.

2018-06-12 Thread GitBox
houshengbo closed pull request #183: Adjust docs to reflect addition of Kube deployment to release repos. URL: https://github.com/apache/incubator-openwhisk-release/pull/183 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] dgrove-oss commented on issue #3680: Adjust invoker playbook to pull docker images when a prefix and tag is specified.

2018-06-12 Thread GitBox
dgrove-oss commented on issue #3680: Adjust invoker playbook to pull docker images when a prefix and tag is specified. URL: https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-396717914 Looks like this would be straightforward for kube. We'd need to update the copies of

[GitHub] dubee commented on issue #3694: Add retries to CLI test framework for network errors

2018-06-12 Thread GitBox
dubee commented on issue #3694: Add retries to CLI test framework for network errors URL: https://github.com/apache/incubator-openwhisk/pull/3694#issuecomment-396717194 PG4 1807 ⏳ This is an automated message from the

[GitHub] rabbah commented on a change in pull request #3694: Add retries to CLI test framework for network errors

2018-06-12 Thread GitBox
rabbah commented on a change in pull request #3694: Add retries to CLI test framework for network errors URL: https://github.com/apache/incubator-openwhisk/pull/3694#discussion_r194439940 ## File path: common/scala/src/main/scala/whisk/utils/Retry.scala ## @@ -31,15

[GitHub] dgrove-oss commented on issue #3747: Memory based loadbalancing

2018-06-12 Thread GitBox
dgrove-oss commented on issue #3747: Memory based loadbalancing URL: https://github.com/apache/incubator-openwhisk/pull/3747#issuecomment-396712826 Would love to see this get pushed through. There are some compensating changes we will need in kube-deploy; I will be happy to take care of

[GitHub] dgrove-oss commented on issue #3747: Memory based loadbalancing

2018-06-12 Thread GitBox
dgrove-oss commented on issue #3747: Memory based loadbalancing URL: https://github.com/apache/incubator-openwhisk/pull/3747#issuecomment-396712826 Would love to see this get merged. There are some compensating changes we will need in kube-deploy; I will be happy to take care of them

[GitHub] dgrove-oss commented on issue #3622: make containers' timezone sync with the docker host

2018-06-12 Thread GitBox
dgrove-oss commented on issue #3622: make containers' timezone sync with the docker host URL: https://github.com/apache/incubator-openwhisk/pull/3622#issuecomment-396711180 For kube the ansible changes obviously won't do anything. What we would need to do is add pairs of stanza like

[GitHub] dgrove-oss commented on issue #3622: make containers' timezone sync with the docker host

2018-06-12 Thread GitBox
dgrove-oss commented on issue #3622: make containers' timezone sync with the docker host URL: https://github.com/apache/incubator-openwhisk/pull/3622#issuecomment-396711180 For kube the ansible changes obviously won't do anything. What we would need to do is add pairs of stanza like

[GitHub] rabbah closed pull request #3568: Add activation result integration test

2018-06-12 Thread GitBox
rabbah closed pull request #3568: Add activation result integration test URL: https://github.com/apache/incubator-openwhisk/pull/3568 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] rabbah closed pull request #3056: Move routemgmt install files to incubator-openwhisk-cli; Modify ansible scripts accordingly

2018-06-12 Thread GitBox
rabbah closed pull request #3056: Move routemgmt install files to incubator-openwhisk-cli; Modify ansible scripts accordingly URL: https://github.com/apache/incubator-openwhisk/pull/3056 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] rabbah commented on issue #3056: Move routemgmt install files to incubator-openwhisk-cli; Modify ansible scripts accordingly

2018-06-12 Thread GitBox
rabbah commented on issue #3056: Move routemgmt install files to incubator-openwhisk-cli; Modify ansible scripts accordingly URL: https://github.com/apache/incubator-openwhisk/pull/3056#issuecomment-396708733 Closing for now.

[GitHub] houshengbo opened a new pull request #184: Add the explanation to the PGP key configuration

2018-06-12 Thread GitBox
houshengbo opened a new pull request #184: Add the explanation to the PGP key configuration URL: https://github.com/apache/incubator-openwhisk-release/pull/184 Closes: #88 This is an automated message from the Apache Git

[GitHub] rabbah commented on issue #3530: factor out max code blob size to a deployment configuration

2018-06-12 Thread GitBox
rabbah commented on issue #3530: factor out max code blob size to a deployment configuration URL: https://github.com/apache/incubator-openwhisk/issues/3530#issuecomment-396691828 closing as duplicate https://github.com/apache/incubator-openwhisk/issues/3712.

[GitHub] rabbah closed issue #3530: factor out max code blob size to a deployment configuration

2018-06-12 Thread GitBox
rabbah closed issue #3530: factor out max code blob size to a deployment configuration URL: https://github.com/apache/incubator-openwhisk/issues/3530 This is an automated message from the Apache Git Service. To respond to

[GitHub] codecov-io commented on issue #3619: Provide an activation store SPI

2018-06-12 Thread GitBox
codecov-io commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-387224274 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3619?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3579: Using non root user in controller

2018-06-12 Thread GitBox
codecov-io commented on issue #3579: Using non root user in controller URL: https://github.com/apache/incubator-openwhisk/pull/3579#issuecomment-396667857 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3579?src=pr=h1) Report > Merging

[GitHub] dgrove-oss closed pull request #218: Fix the copyright and the disclaimer

2018-06-12 Thread GitBox
dgrove-oss closed pull request #218: Fix the copyright and the disclaimer URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/218 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] rabbah commented on issue #2941: Add api gateway test that uses custom package for action

2018-06-12 Thread GitBox
rabbah commented on issue #2941: Add api gateway test that uses custom package for action URL: https://github.com/apache/incubator-openwhisk/pull/2941#issuecomment-396636076 Thanks for the contribution and sorry it sat for so long. I'm ready to merge this but could not verify that you

[GitHub] rabbah commented on issue #2941: Add api gateway test that uses custom package for action

2018-06-12 Thread GitBox
rabbah commented on issue #2941: Add api gateway test that uses custom package for action URL: https://github.com/apache/incubator-openwhisk/pull/2941#issuecomment-396636076 @jsanda do you have an Apache CLA? This is an

[GitHub] mrutkows closed pull request #217: add license header

2018-06-12 Thread GitBox
mrutkows closed pull request #217: add license header URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/217 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] houshengbo opened a new pull request #218: Fix the copyright and the disclaimer

2018-06-12 Thread GitBox
houshengbo opened a new pull request #218: Fix the copyright and the disclaimer URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/218 This PR changes the copyright from IBM to Apache foundation, and gives the disclaimer the correct name for this repository.

[GitHub] houshengbo closed issue #161: Verify we do not include any tooling dot `.` configuration files in source release

2018-06-12 Thread GitBox
houshengbo closed issue #161: Verify we do not include any tooling dot `.` configuration files in source release URL: https://github.com/apache/incubator-openwhisk-release/issues/161 This is an automated message from the

[GitHub] houshengbo commented on issue #113: Document project position on release of "test" files

2018-06-12 Thread GitBox
houshengbo commented on issue #113: Document project position on release of "test" files URL: https://github.com/apache/incubator-openwhisk-release/issues/113#issuecomment-396617033 Apache does not demand us to release the tests or not to release the tests. This can be purely decided by

[GitHub] mrutkows closed pull request #182: Exclude specification/archive and specification/diagrams for wskdeploy

2018-06-12 Thread GitBox
mrutkows closed pull request #182: Exclude specification/archive and specification/diagrams for wskdeploy URL: https://github.com/apache/incubator-openwhisk-release/pull/182 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] mrutkows closed issue #175: Remove wskdeploy specification PDFs (archives) and diagram from source release

2018-06-12 Thread GitBox
mrutkows closed issue #175: Remove wskdeploy specification PDFs (archives) and diagram from source release URL: https://github.com/apache/incubator-openwhisk-release/issues/175 This is an automated message from the Apache

[GitHub] houshengbo commented on issue #129: "Test data files" that need ASF license not well described

2018-06-12 Thread GitBox
houshengbo commented on issue #129: "Test data files" that need ASF license not well described URL: https://github.com/apache/incubator-openwhisk-release/issues/129#issuecomment-396615669 We do not release the test data files for the first release. We can revisit this issue in future if

[GitHub] mhenke1 commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
mhenke1 commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#discussion_r194765182 ## File path: tests/src/test/scala/whisk/core/limits/ActionLimitsTests.scala ## @@

[GitHub] mhenke1 commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
mhenke1 commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#discussion_r194765182 ## File path: tests/src/test/scala/whisk/core/limits/ActionLimitsTests.scala ## @@

[GitHub] houshengbo closed pull request #57: Add the DISCLAIMER file for Apache incubator project

2018-06-12 Thread GitBox
houshengbo closed pull request #57: Add the DISCLAIMER file for Apache incubator project URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/57 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] houshengbo closed pull request #28: Add the DISCLAIMER file for Apache incubator project

2018-06-12 Thread GitBox
houshengbo closed pull request #28: Add the DISCLAIMER file for Apache incubator project URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/28 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] houshengbo closed pull request #65: Add the DISCLAIMER file for Apache incubator project

2018-06-12 Thread GitBox
houshengbo closed pull request #65: Add the DISCLAIMER file for Apache incubator project URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/65 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] houshengbo closed pull request #44: Add the DISCLAIMER file for Apache incubator project

2018-06-12 Thread GitBox
houshengbo closed pull request #44: Add the DISCLAIMER file for Apache incubator project URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/44 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] houshengbo closed issue #97: Track LICENSE and NOTICE issues for `incubator-openwhisk-cli`

2018-06-12 Thread GitBox
houshengbo closed issue #97: Track LICENSE and NOTICE issues for `incubator-openwhisk-cli` URL: https://github.com/apache/incubator-openwhisk-release/issues/97 This is an automated message from the Apache Git Service. To

[GitHub] houshengbo commented on issue #97: Track LICENSE and NOTICE issues for `incubator-openwhisk-cli`

2018-06-12 Thread GitBox
houshengbo commented on issue #97: Track LICENSE and NOTICE issues for `incubator-openwhisk-cli` URL: https://github.com/apache/incubator-openwhisk-release/issues/97#issuecomment-396614326 We can close this issue since all PRs have been merged.

[GitHub] houshengbo closed pull request #312: Add the DISCLAIMER file for Apache incubator project

2018-06-12 Thread GitBox
houshengbo closed pull request #312: Add the DISCLAIMER file for Apache incubator project URL: https://github.com/apache/incubator-openwhisk-cli/pull/312 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] houshengbo commented on issue #138: Fix the copyright issues in all the .conf files

2018-06-12 Thread GitBox
houshengbo commented on issue #138: Fix the copyright issues in all the .conf files URL: https://github.com/apache/incubator-openwhisk-release/issues/138#issuecomment-396613765 This issue can be closed, since we have fixed all the license and copyright issues across all the repos.

[GitHub] houshengbo closed issue #138: Fix the copyright issues in all the .conf files

2018-06-12 Thread GitBox
houshengbo closed issue #138: Fix the copyright issues in all the .conf files URL: https://github.com/apache/incubator-openwhisk-release/issues/138 This is an automated message from the Apache Git Service. To respond to the

[GitHub] houshengbo closed issue #111: Document how license and notice files are assembled

2018-06-12 Thread GitBox
houshengbo closed issue #111: Document how license and notice files are assembled URL: https://github.com/apache/incubator-openwhisk-release/issues/111 This is an automated message from the Apache Git Service. To respond to

[GitHub] houshengbo commented on issue #111: Document how license and notice files are assembled

2018-06-12 Thread GitBox
houshengbo commented on issue #111: Document how license and notice files are assembled URL: https://github.com/apache/incubator-openwhisk-release/issues/111#issuecomment-396612698 We have been implementing the policy written here:

[GitHub] codecov-io commented on issue #3680: Adjust invoker playbook to pull docker images when a prefix and tag is specified.

2018-06-12 Thread GitBox
codecov-io commented on issue #3680: Adjust invoker playbook to pull docker images when a prefix and tag is specified. URL: https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-390292471 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=h1)

[GitHub] dgrove-oss commented on issue #217: add license header

2018-06-12 Thread GitBox
dgrove-oss commented on issue #217: add license header URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/217#issuecomment-396582139 hold off on merging this for a few minutes. working on an improvement as suggested by Daisy.

[GitHub] houshengbo commented on issue #98: Track LICENSE and NOTICE issues for `incubator-openwhisk-client-go`

2018-06-12 Thread GitBox
houshengbo commented on issue #98: Track LICENSE and NOTICE issues for `incubator-openwhisk-client-go` URL: https://github.com/apache/incubator-openwhisk-release/issues/98#issuecomment-396610858 We can close this issue, since all the PRs have been merged.

[GitHub] houshengbo closed issue #98: Track LICENSE and NOTICE issues for `incubator-openwhisk-client-go`

2018-06-12 Thread GitBox
houshengbo closed issue #98: Track LICENSE and NOTICE issues for `incubator-openwhisk-client-go` URL: https://github.com/apache/incubator-openwhisk-release/issues/98 This is an automated message from the Apache Git Service.

[GitHub] houshengbo commented on issue #96: Track LICENSE and NOTICE issues for `incubator-openwhisk-catalog`

2018-06-12 Thread GitBox
houshengbo commented on issue #96: Track LICENSE and NOTICE issues for `incubator-openwhisk-catalog` URL: https://github.com/apache/incubator-openwhisk-release/issues/96#issuecomment-396610391 We can close this issue, since all the PRs are merged. The old open issue is no longer valid,

[GitHub] houshengbo closed issue #96: Track LICENSE and NOTICE issues for `incubator-openwhisk-catalog`

2018-06-12 Thread GitBox
houshengbo closed issue #96: Track LICENSE and NOTICE issues for `incubator-openwhisk-catalog` URL: https://github.com/apache/incubator-openwhisk-release/issues/96 This is an automated message from the Apache Git Service.

[GitHub] houshengbo closed issue #95: Track LICENSE and NOTICE issues for `incubator-openwhisk-apigateway`

2018-06-12 Thread GitBox
houshengbo closed issue #95: Track LICENSE and NOTICE issues for `incubator-openwhisk-apigateway` URL: https://github.com/apache/incubator-openwhisk-release/issues/95 This is an automated message from the Apache Git

[GitHub] houshengbo commented on issue #95: Track LICENSE and NOTICE issues for `incubator-openwhisk-apigateway`

2018-06-12 Thread GitBox
houshengbo commented on issue #95: Track LICENSE and NOTICE issues for `incubator-openwhisk-apigateway` URL: https://github.com/apache/incubator-openwhisk-release/issues/95#issuecomment-396608748 The Issue #168 will have a separate PR to fix. All the other PRs have been merged, so we can

[GitHub] houshengbo commented on issue #94: Track LICENSE and NOTICE issues for `incubator-openwhisk-wskdeploy`

2018-06-12 Thread GitBox
houshengbo commented on issue #94: Track LICENSE and NOTICE issues for `incubator-openwhisk-wskdeploy` URL: https://github.com/apache/incubator-openwhisk-release/issues/94#issuecomment-396607743 We can close this issue, since all the PRs have been merged. The issue

[GitHub] dgrove-oss commented on issue #217: add license header

2018-06-12 Thread GitBox
dgrove-oss commented on issue #217: add license header URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/217#issuecomment-396599601 added the NOTICE.txt block as suggested by Daisy. When we deploy with Helm, the user will now see the text below. ```

[GitHub] rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#discussion_r194742820 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskAuth.scala ## @@

[GitHub] rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#discussion_r194744183 ## File path: tests/src/test/scala/whisk/core/limits/ActionLimitsTests.scala ## @@

[GitHub] rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#discussion_r194742820 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskAuth.scala ## @@

[GitHub] rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#discussion_r194738098 ## File path: common/scala/src/main/scala/whisk/core/entity/Identity.scala ## @@

[GitHub] rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#discussion_r194743295 ## File path: core/controller/src/main/scala/whisk/core/controller/Actions.scala ##

[GitHub] codecov-io commented on issue #3753: Retry `ensureTopic` on transient, retriable exceptions.

2018-06-12 Thread GitBox
codecov-io commented on issue #3753: Retry `ensureTopic` on transient, retriable exceptions. URL: https://github.com/apache/incubator-openwhisk/pull/3753#issuecomment-396582836 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3753?src=pr=h1) Report > Merging

[GitHub] dgrove-oss commented on issue #217: add license header

2018-06-12 Thread GitBox
dgrove-oss commented on issue #217: add license header URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/217#issuecomment-396582139 hold off on merging this for a few minutes. working on an improvement as suggested by Daisy.

[GitHub] rabbah commented on issue #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
rabbah commented on issue #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#issuecomment-396560662 Thanks for the explanation and the context is more clear now. Definitely bring this to the dev list as there is

[GitHub] cbickel closed pull request #3686: Refactor `ensureTopic` to expose failure details.

2018-06-12 Thread GitBox
cbickel closed pull request #3686: Refactor `ensureTopic` to expose failure details. URL: https://github.com/apache/incubator-openwhisk/pull/3686 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] markusthoemmes commented on issue #3686: Refactor `ensureTopic` to expose failure details.

2018-06-12 Thread GitBox
markusthoemmes commented on issue #3686: Refactor `ensureTopic` to expose failure details. URL: https://github.com/apache/incubator-openwhisk/pull/3686#issuecomment-396558595 PG1 3013  This is an automated message from

[GitHub] mhenke1 commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
mhenke1 commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#discussion_r194703110 ## File path: common/scala/src/main/scala/whisk/core/entity/Identity.scala ## @@

[GitHub] mhenke1 commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
mhenke1 commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#discussion_r194703021 ## File path: common/scala/src/main/scala/whisk/core/entity/Identity.scala ## @@

[GitHub] rabbah commented on issue #262: Missing "type": "object" in Swagger definition for KeyValue.value

2018-06-12 Thread GitBox
rabbah commented on issue #262: Missing "type": "object" in Swagger definition for KeyValue.value URL: https://github.com/apache/incubator-openwhisk/issues/262#issuecomment-396551493 The comment here suggested the fix

[GitHub] chetanmeh commented on issue #3722: Scala based admin tooling

2018-06-12 Thread GitBox
chetanmeh commented on issue #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#issuecomment-396551429 @rabbah @markusthoemmes This PR is now ready for review. Currently it supports all of `user` and `limits` command. Dumping db content

[GitHub] rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#discussion_r194694527 ## File path: common/scala/src/main/scala/whisk/core/entity/Identity.scala ## @@

[GitHub] rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
rabbah commented on a change in pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#discussion_r194695492 ## File path: common/scala/src/main/scala/whisk/core/entity/Identity.scala ## @@

[GitHub] chetanmeh commented on issue #3515: Introduce separate Akka dispatchers for CouchDB and Kafka Clients (#2954)

2018-06-12 Thread GitBox
chetanmeh commented on issue #3515: Introduce separate Akka dispatchers for CouchDB and Kafka Clients (#2954) URL: https://github.com/apache/incubator-openwhisk/pull/3515#issuecomment-396540431 > this might be of use for other datastores so I wonder if we should rename the couch

[GitHub] chetanmeh commented on issue #3286: Treat action code as attachments for created/updated actions

2018-06-12 Thread GitBox
chetanmeh commented on issue #3286: Treat action code as attachments for created/updated actions URL: https://github.com/apache/incubator-openwhisk/pull/3286#issuecomment-396540067 @dubee Yes this would be useful as document size limitation is impacting nodejs kind also for us. So would

[GitHub] chetanmeh commented on issue #3619: Provide an activation store SPI

2018-06-12 Thread GitBox
chetanmeh commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-396538106 > Rewriting a stream from CouchDB could be done with

[GitHub] daisy-ycguo commented on issue #217: add license header

2018-06-12 Thread GitBox
daisy-ycguo commented on issue #217: add license header URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/217#issuecomment-396534708 I think it's a generated NOTICE.txt during helm deployment. I wonder if we need header in NOTICE.txt.

[GitHub] daisy-ycguo commented on issue #262: Missing "type": "object" in Swagger definition for KeyValue.value

2018-06-12 Thread GitBox
daisy-ycguo commented on issue #262: Missing "type": "object" in Swagger definition for KeyValue.value URL: https://github.com/apache/incubator-openwhisk/issues/262#issuecomment-396530099

[GitHub] daisy-ycguo commented on issue #262: Missing "type": "object" in Swagger definition for KeyValue.value

2018-06-12 Thread GitBox
daisy-ycguo commented on issue #262: Missing "type": "object" in Swagger definition for KeyValue.value URL: https://github.com/apache/incubator-openwhisk/issues/262#issuecomment-396530099

[GitHub] codecov-io commented on issue #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
codecov-io commented on issue #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#issuecomment-396516436 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3752?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3722: Scala based admin tooling

2018-06-12 Thread GitBox
codecov-io commented on issue #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#issuecomment-394275882 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3722?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3722: Scala based admin tooling

2018-06-12 Thread GitBox
codecov-io commented on issue #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#issuecomment-394275882 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3722?src=pr=h1) Report > Merging

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

2018-06-12 Thread GitBox
chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r194667851 ## File path: common/scala/src/main/scala/whisk/common/tracing/TracingCacheProvider.scala ## @@

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

2018-06-12 Thread GitBox
chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r194665739 ## File path: common/scala/src/main/scala/whisk/common/tracing/TracingCacheProvider.scala ## @@

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

2018-06-12 Thread GitBox
chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r194664618 ## File path: common/scala/src/main/scala/whisk/common/tracing/OpenTracingProvider.scala ## @@

[GitHub] daisy-ycguo commented on issue #19: support go actions

2018-06-12 Thread GitBox
daisy-ycguo commented on issue #19: support go actions URL: https://github.com/apache/incubator-openwhisk/issues/19#issuecomment-396518000 @csantanapr I wonder if we are able to close this issue, since we have [runtime-go](https://github.com/apache/incubator-openwhisk-runtime-go) repo.

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

2018-06-12 Thread GitBox
chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r194662887 ## File path: common/scala/src/main/scala/whisk/common/tracing/OpenTracingProvider.scala ## @@

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

2018-06-12 Thread GitBox
chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r194661744 ## File path: common/scala/src/main/resources/application.conf ## @@ -186,4 +186,14 @@ whisk {

[GitHub] codecov-io commented on issue #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
codecov-io commented on issue #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752#issuecomment-396516436 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3752?src=pr=h1) Report > Merging

[GitHub] mhenke1 opened a new pull request #3752: Move uuid into namespace to decouple it from authkey

2018-06-12 Thread GitBox
mhenke1 opened a new pull request #3752: Move uuid into namespace to decouple it from authkey URL: https://github.com/apache/incubator-openwhisk/pull/3752 This PR makes the uuid an explicit part of a namespace object containing name and uuid of a namespace. ## Description In

[GitHub] markusthoemmes commented on issue #3619: Provide an activation store SPI

2018-06-12 Thread GitBox
markusthoemmes commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-396500685 @chetanmeh that should indeed be possible, will require quite some work on top of this (i.e. the list would need to be rewritten

[GitHub] chetanmeh commented on issue #3619: Provide an activation store SPI

2018-06-12 Thread GitBox
chetanmeh commented on issue #3619: Provide an activation store SPI URL: https://github.com/apache/incubator-openwhisk/pull/3619#issuecomment-396498156 @dubee I had provided some feedback on the [DL mail. thread][1]. > In some cases we are seeing large activation responses when

  1   2   >