[GitHub] dubee closed pull request #3913: Bump kafka-clients version to 2.0.0.

dubee closed pull request #3913: Bump kafka-clients version to 2.0.0. URL: https://github.com/apache/incubator-openwhisk/pull/3913 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] codecov-io edited a comment on issue #3913: Bump kafka-clients version to 2.0.0.

codecov-io edited a comment on issue #3913: Bump kafka-clients version to 2.0.0. URL: https://github.com/apache/incubator-openwhisk/pull/3913#issuecomment-408813148 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3913?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3890: Use ArtifactStore to manipulate data in NamespaceBlacklistTests

codecov-io edited a comment on issue #3890: Use ArtifactStore to manipulate data in NamespaceBlacklistTests URL: https://github.com/apache/incubator-openwhisk/pull/3890#issuecomment-406973059 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3890?src=pr=h1) Report >

[GitHub] codecov-io edited a comment on issue #3890: Use ArtifactStore to manipulate data in NamespaceBlacklistTests

codecov-io edited a comment on issue #3890: Use ArtifactStore to manipulate data in NamespaceBlacklistTests URL: https://github.com/apache/incubator-openwhisk/pull/3890#issuecomment-406973059 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3890?src=pr=h1) Report >

[GitHub] daisy-ycguo closed pull request #269: remove obsolete LIMITS_ACTIONS_INVOKES_CONCURRENTINSYSTEM

daisy-ycguo closed pull request #269: remove obsolete LIMITS_ACTIONS_INVOKES_CONCURRENTINSYSTEM URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/269 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] daisy-ycguo closed pull request #262: add check for healthy invoker to build-helm.sh

daisy-ycguo closed pull request #262: add check for healthy invoker to build-helm.sh URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/262 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rabbah commented on a change in pull request #3919: Allow raw JSON string as response for webaction without base64 encoding.

rabbah commented on a change in pull request #3919: Allow raw JSON string as response for webaction without base64 encoding. URL: https://github.com/apache/incubator-openwhisk/pull/3919#discussion_r206704023 ## File path:

[GitHub] rabbah commented on a change in pull request #3919: Allow raw JSON string as response for webaction without base64 encoding.

rabbah commented on a change in pull request #3919: Allow raw JSON string as response for webaction without base64 encoding. URL: https://github.com/apache/incubator-openwhisk/pull/3919#discussion_r206359836 ## File path:

[GitHub] dgrove-oss commented on a change in pull request #265: Add alarm provider

dgrove-oss commented on a change in pull request #265: Add alarm provider URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/265#discussion_r206700925 ## File path: helm/providers/charts/alarm/README.md ## @@ -0,0 +1,43 @@ + + +# Use Helm to deploy alarm

[GitHub] dgrove-oss commented on a change in pull request #265: Add alarm provider

dgrove-oss commented on a change in pull request #265: Add alarm provider URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/265#discussion_r206702044 ## File path: tools/travis/build-helm.sh ## @@ -119,7 +119,7 @@ ROOTDIR="$SCRIPTDIR/../../"

[GitHub] houshengbo closed pull request #226: Release 0.9.0 artifacts for cli and client go

houshengbo closed pull request #226: Release 0.9.0 artifacts for cli and client go URL: https://github.com/apache/incubator-openwhisk-release/pull/226 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dgrove-oss commented on a change in pull request #265: Add alarm provider

dgrove-oss commented on a change in pull request #265: Add alarm provider URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/265#discussion_r206701609 ## File path: helm/providers/charts/alarm/templates/pkgAlarmProvider.yaml ## @@ -0,0 +1,79 @@ +#

[GitHub] violagao opened a new pull request #226: Release 0.9.0 artifacts for cli and client go

violagao opened a new pull request #226: Release 0.9.0 artifacts for cli and client go URL: https://github.com/apache/incubator-openwhisk-release/pull/226 This is an automated message from the Apache Git Service. To respond

[GitHub] markusthoemmes commented on issue #3932: eliminate setting of COMPONENT_NAME

markusthoemmes commented on issue #3932: eliminate setting of COMPONENT_NAME URL: https://github.com/apache/incubator-openwhisk/pull/3932#issuecomment-409386561 The "COMPONENT" part of log-lines is extracted from the logline itself and is essentially the class that logs (i.e.

[GitHub] dgrove-oss commented on issue #3932: eliminate setting of COMPONENT_NAME

dgrove-oss commented on issue #3932: eliminate setting of COMPONENT_NAME URL: https://github.com/apache/incubator-openwhisk/pull/3932#issuecomment-409385387 Any recollection of how? I did some recursive greps that came up empty, but that might not be conclusive.

[GitHub] houshengbo closed pull request #225: Release the modules client go and cli for 0.9.0

houshengbo closed pull request #225: Release the modules client go and cli for 0.9.0 URL: https://github.com/apache/incubator-openwhisk-release/pull/225 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] csantanapr commented on issue #3932: eliminate setting of COMPONENT_NAME

csantanapr commented on issue #3932: eliminate setting of COMPONENT_NAME URL: https://github.com/apache/incubator-openwhisk/pull/3932#issuecomment-409379665 I thought it’s used on log lines This is an automated message from

[GitHub] dgrove-oss opened a new pull request #3932: eliminate setting of COMPONENT_NAME

dgrove-oss opened a new pull request #3932: eliminate setting of COMPONENT_NAME URL: https://github.com/apache/incubator-openwhisk/pull/3932 Small cleanup: As best as I can tell, this envvar is set when deploying the invoker/controller but the value is never actually used.

[GitHub] dgrove-oss opened a new pull request #270: set invoker's --uniqueName to $INVOKER_NAME; eliminate setting of COM…

dgrove-oss opened a new pull request #270: set invoker's --uniqueName to $INVOKER_NAME; eliminate setting of COM… URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/270 …PONENT_NAME This is an automated

[GitHub] dubee closed pull request #3922: Improve robustness of KafkaConsumerConnector

dubee closed pull request #3922: Improve robustness of KafkaConsumerConnector URL: https://github.com/apache/incubator-openwhisk/pull/3922 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] markusthoemmes commented on issue #3924: Fix CacheConcurrencyTest cleanup.

markusthoemmes commented on issue #3924: Fix CacheConcurrencyTest cleanup. URL: https://github.com/apache/incubator-openwhisk/pull/3924#issuecomment-409352099 @rabbah this didn't quite fix it yet. Will look tomorrow. This is

[GitHub] markusthoemmes commented on issue #3886: Proposing Lean OpenWhisk

markusthoemmes commented on issue #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#issuecomment-409351880 @kpavel that's fine, it just moves everything that involves any code to the core, which is I think desirable? Having one file out seems

[GitHub] houshengbo opened a new pull request #225: Release the modules client go and cli for 0.9.0

houshengbo opened a new pull request #225: Release the modules client go and cli for 0.9.0 URL: https://github.com/apache/incubator-openwhisk-release/pull/225 This PR picked up the commit IDs for client go and cli modules and updated the installation guide.

[GitHub] kpavel edited a comment on issue #3886: Proposing Lean OpenWhisk

kpavel edited a comment on issue #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#issuecomment-409341999 Thanks for the review @markusthoemme. Regarding moving the LeanBalancer into the core code: we can move it to the core code, but we

[GitHub] kpavel commented on issue #3886: Proposing Lean OpenWhisk

kpavel commented on issue #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#issuecomment-409341999 Regarding moving the LeanBalancer into the core code: We can move it to the core code, but we still have to have separate build.gradle +

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206651414 ## File path: ansible/roles/lean/tasks/deploy.yml ## @@ -0,0 +1,265 @@ +# Licensed to the Apache Software

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206651316 ## File path: ansible/tasks/invoker_lean.yml ## @@ -0,0 +1,141 @@ +# Licensed to the Apache Software Foundation

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206651316 ## File path: ansible/tasks/invoker_lean.yml ## @@ -0,0 +1,141 @@ +# Licensed to the Apache Software Foundation

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206651195 ## File path: core/lean/src/main/scala/whisk/core/loadBalancer/LeanBalancer.scala ## @@ -0,0 +1,256 @@ +/* + *

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206651119 ## File path: core/lean/init.sh ## @@ -0,0 +1,10 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206651168 ## File path: core/lean/src/main/scala/whisk/core/loadBalancer/LeanBalancer.scala ## @@ -0,0 +1,256 @@ +/* + *

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206651267 ## File path: tests/build.gradle ## @@ -64,21 +77,14 @@ ext.testSets = [ ] ],

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206651094 ## File path: core/lean/src/main/resources/reference.conf ## @@ -0,0 +1,15 @@ +# Licensed to the Apache Software

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206651061 ## File path: core/lean/build.gradle ## @@ -0,0 +1,31 @@ +apply plugin: 'scala' +apply plugin: 'application'

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206650918 ## File path: common/scala/src/main/scala/whisk/connector/lean/LeanConsumer.scala ## @@ -0,0 +1,49 @@ +/* + *

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206650831 ## File path: common/scala/src/main/scala/whisk/connector/lean/LeanProducer.scala ## @@ -0,0 +1,60 @@ +/* + *

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206650973 ## File path: core/lean/build.gradle ## @@ -0,0 +1,31 @@ +apply plugin: 'scala' +apply plugin: 'application'

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206650945 ## File path: common/scala/src/main/scala/whisk/connector/lean/LeanProducer.scala ## @@ -0,0 +1,60 @@ +/* + *

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206650884 ## File path: core/lean/src/main/scala/whisk/core/loadBalancer/LeanBalancer.scala ## @@ -0,0 +1,256 @@ +/* + *

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206650808 ## File path: common/scala/src/main/scala/whisk/connector/lean/LeanProducer.scala ## @@ -0,0 +1,60 @@ +/* + *

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206650748 ## File path: common/scala/src/main/scala/whisk/connector/lean/LeanProducer.scala ## @@ -0,0 +1,60 @@ +/* + *

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206650701 ## File path: common/scala/src/main/scala/whisk/connector/lean/LeanMessagingProvider.scala ## @@ -0,0 +1,67 @@

[GitHub] kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk

kpavel commented on a change in pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#discussion_r206650723 ## File path: common/scala/src/main/scala/whisk/connector/lean/LeanMessagingProvider.scala ## @@ -0,0 +1,67 @@

[GitHub] codecov-io edited a comment on issue #3886: Proposing Lean OpenWhisk

codecov-io edited a comment on issue #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#issuecomment-406254669 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=h1) Report > Merging

[GitHub] pritidesai closed pull request #354: Update the commit ID of openwhisk client go for 0.9.0

pritidesai closed pull request #354: Update the commit ID of openwhisk client go for 0.9.0 URL: https://github.com/apache/incubator-openwhisk-cli/pull/354 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] codecov-io edited a comment on issue #3878: Validate the Controller Swagger spec matches the impl

codecov-io edited a comment on issue #3878: Validate the Controller Swagger spec matches the impl URL: https://github.com/apache/incubator-openwhisk/pull/3878#issuecomment-404963809 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3878?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3878: Validate the Controller Swagger spec matches the impl

codecov-io edited a comment on issue #3878: Validate the Controller Swagger spec matches the impl URL: https://github.com/apache/incubator-openwhisk/pull/3878#issuecomment-404963809 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3878?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3814: wskadmin scala db command to export and import

codecov-io edited a comment on issue #3814: wskadmin scala db command to export and import URL: https://github.com/apache/incubator-openwhisk/pull/3814#issuecomment-400666862 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr=h1) Report > Merging

[GitHub] dgrove-oss opened a new pull request #269: remove obsolete LIMITS_ACTIONS_INVOKES_CONCURRENTINSYSTEM

dgrove-oss opened a new pull request #269: remove obsolete LIMITS_ACTIONS_INVOKES_CONCURRENTINSYSTEM URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/269 This config values was made obsolete by upstream PR#3875.

[GitHub] houshengbo opened a new pull request #354: Update the commit ID of openwhisk client go for 0.9.0

houshengbo opened a new pull request #354: Update the commit ID of openwhisk client go for 0.9.0 URL: https://github.com/apache/incubator-openwhisk-cli/pull/354 This is an automated message from the Apache Git Service. To

[GitHub] houshengbo closed pull request #96: Update the doc of client go to make it clear for 0.9.0

houshengbo closed pull request #96: Update the doc of client go to make it clear for 0.9.0 URL: https://github.com/apache/incubator-openwhisk-client-go/pull/96 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dgrove-oss commented on issue #262: add check for healthy invoker to build-helm.sh

dgrove-oss commented on issue #262: add check for healthy invoker to build-helm.sh URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/262#issuecomment-409310817 rebased to pick up fixes from #268 This is

[GitHub] dgrove-oss closed issue #267: Invoker failling with error

dgrove-oss closed issue #267: Invoker failling with error URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/267 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] dgrove-oss closed issue #266: Controller waiting for couchdb giving unauthorised

dgrove-oss closed issue #266: Controller waiting for couchdb giving unauthorised URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/266 This is an automated message from the Apache Git Service. To respond

[GitHub] dgrove-oss closed pull request #268: Fix for #266 and #267

dgrove-oss closed pull request #268: Fix for #266 and #267 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/268 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] bbrowning commented on issue #3878: Validate the Controller Swagger spec matches the impl

bbrowning commented on issue #3878: Validate the Controller Swagger spec matches the impl URL: https://github.com/apache/incubator-openwhisk/pull/3878#issuecomment-409306884 I've updated the implementation based on feedback and rebased on top of latest master as a conflict had been

[GitHub] chetanmeh commented on issue #143: Cannot install on windows

chetanmeh commented on issue #143: Cannot install on windows URL: https://github.com/apache/incubator-openwhisk-devtools/issues/143#issuecomment-409304869 Most likely build would not work on Windows. Instead of direct build it may be better to use the [Vagrant way][1] as there most work

[GitHub] zak93kost opened a new issue #143: Cannot install on windows

zak93kost opened a new issue #143: Cannot install on windows URL: https://github.com/apache/incubator-openwhisk-devtools/issues/143 I am trying to build openwhisk on windows but all of my tries end up with no solution. Is it possible for anyone to let us know the steps of building it on

[GitHub] zak93kost commented on issue #119: Doesn't seem to work correctly on Windows

zak93kost commented on issue #119: Doesn't seem to work correctly on Windows URL: https://github.com/apache/incubator-openwhisk-devtools/issues/119#issuecomment-409302125 I am having the same issue, Did you by any chance solve it?

[GitHub] codecov-io edited a comment on issue #3910: Allow non-json skip_pull_runtimes to be passed as True.

codecov-io edited a comment on issue #3910: Allow non-json skip_pull_runtimes to be passed as True. URL: https://github.com/apache/incubator-openwhisk/pull/3910#issuecomment-408682227 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3910?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3910: Allow non-json skip_pull_runtimes to be passed as True.

codecov-io edited a comment on issue #3910: Allow non-json skip_pull_runtimes to be passed as True. URL: https://github.com/apache/incubator-openwhisk/pull/3910#issuecomment-408682227 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3910?src=pr=h1) Report > Merging

[GitHub] bbrowning commented on issue #2: Deploy on private network

bbrowning commented on issue #2: Deploy on private network URL: https://github.com/apache/incubator-openwhisk-deploy-openshift/issues/2#issuecomment-409298845 I don't know of an easy way to pull all images from the template, although perhaps some shell scripting and template parsing could

[GitHub] chetanmeh commented on issue #3931: Configure static code analysis as part of code scan

chetanmeh commented on issue #3931: Configure static code analysis as part of code scan URL: https://github.com/apache/incubator-openwhisk/issues/3931#issuecomment-409297535 For configuring scala compiler plugin in Gradle see [here][1] and [here][2] [1]:

[GitHub] codecov-io edited a comment on issue #3910: Allow non-json skip_pull_runtimes to be passed as True.

codecov-io edited a comment on issue #3910: Allow non-json skip_pull_runtimes to be passed as True. URL: https://github.com/apache/incubator-openwhisk/pull/3910#issuecomment-408682227 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3910?src=pr=h1) Report > Merging

[GitHub] chetanmeh commented on issue #3928: Replace List() occurrences with List.empty

chetanmeh commented on issue #3928: Replace List() occurrences with List.empty URL: https://github.com/apache/incubator-openwhisk/pull/3928#issuecomment-409294906 Opened #3931 to track configuring a code analysis plugin This

[GitHub] chetanmeh opened a new issue #3931: Configure static code analysis as part of code scan

chetanmeh opened a new issue #3931: Configure static code analysis as part of code scan URL: https://github.com/apache/incubator-openwhisk/issues/3931 Currently OpenWhisk build run a [scalafmt][1] check to enforce a consistent code style. We should look into configuring some static code

[GitHub] dgrove-oss edited a comment on issue #268: Fix for #266 and #267

dgrove-oss edited a comment on issue #268: Fix for #266 and #267 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/268#issuecomment-409292577 Agreed. @bbrowning I can do a squash and merge from the Github UI if we want this in quickly with sanitized single-commit.

[GitHub] dgrove-oss commented on issue #268: Fix for #266 and #267

dgrove-oss commented on issue #268: Fix for #266 and #267 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/268#issuecomment-409292577 Agreed. @bbrowning I can do a squash and merge from the Github UI if we want this in quickly. @cduque89 - we tend to use git

[GitHub] cduque89 commented on issue #266: Controller waiting for couchdb giving unauthorised

cduque89 commented on issue #266: Controller waiting for couchdb giving unauthorised URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/266#issuecomment-409287867 We have opened a PR that fix this. #268 it fixed everything for us. If you have a look and agree with the

[GitHub] csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own

csantanapr commented on a change in pull request #73: Don't override runtime npm packages when user provides their own URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/73#discussion_r206600515 ## File path:

[GitHub] dgrove-oss commented on issue #266: Controller waiting for couchdb giving unauthorised

dgrove-oss commented on issue #266: Controller waiting for couchdb giving unauthorised URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/266#issuecomment-409287106 There have been a couple of upstream PRs merged that need adjustment for in kube-deploy. i'm working on

[GitHub] codecov-io commented on issue #3930: Replace Set() occurrences with Set.empty

codecov-io commented on issue #3930: Replace Set() occurrences with Set.empty URL: https://github.com/apache/incubator-openwhisk/pull/3930#issuecomment-409280319 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3930?src=pr=h1) Report > Merging

[GitHub] bbrowning commented on issue #268: Fix for #266 and #267

bbrowning commented on issue #268: Fix for #266 and #267 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/268#issuecomment-409280285 Thanks for the fix! I just ran into these issues locally and was able to quickly verify that this fix works.

[GitHub] codecov-io commented on issue #3929: Replace JsArray() occurrences with JsArray.empty

codecov-io commented on issue #3929: Replace JsArray() occurrences with JsArray.empty URL: https://github.com/apache/incubator-openwhisk/pull/3929#issuecomment-409279516 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3929?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3928: Replace List() occurrences with List.empty

codecov-io commented on issue #3928: Replace List() occurrences with List.empty URL: https://github.com/apache/incubator-openwhisk/pull/3928#issuecomment-409279258 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3928?src=pr=h1) Report > Merging

[GitHub] rabbah commented on issue #3928: Replace List() occurrences with List.empty

rabbah commented on issue #3928: Replace List() occurrences with List.empty URL: https://github.com/apache/incubator-openwhisk/pull/3928#issuecomment-409278114 @dubee can we combine all the prs into one? This is an automated

[GitHub] codecov-io commented on issue #3926: Replace Seq() occurrences with Seq.empty

codecov-io commented on issue #3926: Replace Seq() occurrences with Seq.empty URL: https://github.com/apache/incubator-openwhisk/pull/3926#issuecomment-409277518 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3926?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3927: Replace Vector() occurrences with Vector.empty

codecov-io edited a comment on issue #3927: Replace Vector() occurrences with Vector.empty URL: https://github.com/apache/incubator-openwhisk/pull/3927#issuecomment-409277585 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3927?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3927: Replace Vector() occurrences with Vector.empty

codecov-io commented on issue #3927: Replace Vector() occurrences with Vector.empty URL: https://github.com/apache/incubator-openwhisk/pull/3927#issuecomment-409277585 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3927?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3925: Replace Map() occurrences with Map.empty

codecov-io commented on issue #3925: Replace Map() occurrences with Map.empty URL: https://github.com/apache/incubator-openwhisk/pull/3925#issuecomment-409276378 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3925?src=pr=h1) Report > Merging

[GitHub] chetanmeh edited a comment on issue #3928: Replace List() occurrences with List.empty

chetanmeh edited a comment on issue #3928: Replace List() occurrences with List.empty URL: https://github.com/apache/incubator-openwhisk/pull/3928#issuecomment-409273589 Given that this is a recurring work (see #3359) should we look into configuring a code style check plugin. For example

[GitHub] chetanmeh commented on issue #3928: Replace List() occurrences with List.empty

chetanmeh commented on issue #3928: Replace List() occurrences with List.empty URL: https://github.com/apache/incubator-openwhisk/pull/3928#issuecomment-409273589 Given that this is a recurring work #3359 should we look into configuring a code style check plugin. For example

[GitHub] codecov-io edited a comment on issue #3922: Improve robustness of KafkaConsumerConnector

codecov-io edited a comment on issue #3922: Improve robustness of KafkaConsumerConnector URL: https://github.com/apache/incubator-openwhisk/pull/3922#issuecomment-409164389 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3922?src=pr=h1) Report > Merging

[GitHub] cduque89 opened a new pull request #268: Fix for #266 and #267

cduque89 opened a new pull request #268: Fix for #266 and #267 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/268 fixed readiness probe for couch db issue: #266 fixed invoker init.sh parameter needs uniqueName issue: #267

[GitHub] cduque89 commented on issue #267: Invoker failling with error

cduque89 commented on issue #267: Invoker failling with error URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/267#issuecomment-409257075 Ok perfect. Will open a PR in the next couple of minutes. Thanks for the help.

[GitHub] dubee opened a new pull request #3930: Replace Set() occurrences with Set.empty

dubee opened a new pull request #3930: Replace Set() occurrences with Set.empty URL: https://github.com/apache/incubator-openwhisk/pull/3930 ## Description Use Set.empty, which is provided by a persistent singleton object, instead of creating new case classes by using

[GitHub] dubee opened a new pull request #3928: Replace List() occurrences with List.empty

dubee opened a new pull request #3928: Replace List() occurrences with List.empty URL: https://github.com/apache/incubator-openwhisk/pull/3928 ## Description Use List.empty, which is provided by a persistent singleton object, instead of creating new case classes by

[GitHub] dubee opened a new pull request #3929: Replace JsArray() occurrences with JsArray.empty

dubee opened a new pull request #3929: Replace JsArray() occurrences with JsArray.empty URL: https://github.com/apache/incubator-openwhisk/pull/3929 ## Description Use JsArray.empty, which is provided by a persistent singleton object, instead of creating new case

[GitHub] dubee opened a new pull request #3926: Replace Seq() occurrences with Seq.empty

dubee opened a new pull request #3926: Replace Seq() occurrences with Seq.empty URL: https://github.com/apache/incubator-openwhisk/pull/3926 ## Description Use Seq.empty, which is provided by a persistent singleton object, instead of creating new case classes by using

[GitHub] dubee opened a new pull request #3927: Replace Vector() occurrences with Vector.empty

dubee opened a new pull request #3927: Replace Vector() occurrences with Vector.empty URL: https://github.com/apache/incubator-openwhisk/pull/3927 ## Description Use Vector.empty, which is provided by a persistent singleton object, instead of creating new case classes

[GitHub] dubee opened a new pull request #3925: Replace Map() occurrences with Map.empty

dubee opened a new pull request #3925: Replace Map() occurrences with Map.empty URL: https://github.com/apache/incubator-openwhisk/pull/3925 ## Description Use Map.empty, which is provided by a persistent singleton object, instead of creating new case classes by using

[GitHub] dgrove-oss commented on issue #262: add check for healthy invoker to build-helm.sh

dgrove-oss commented on issue #262: add check for healthy invoker to build-helm.sh URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/262#issuecomment-409255286 investigating travisci failure. initial guess is that kube-deploy got out-of-synch with upstream repo while I

[GitHub] markusthoemmes commented on issue #267: Invoker failling with error

markusthoemmes commented on issue #267: Invoker failling with error URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/267#issuecomment-409250552 @cduque89 Note how today the invoker is not passed an id at all. The only thing you need to do is pass `INVOKER_NAME` as the

[GitHub] cduque89 commented on issue #267: Invoker failling with error

cduque89 commented on issue #267: Invoker failling with error URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/267#issuecomment-409249884 Ok just checked your code and saw you have the following: parse(tail, c.copy(id = Some(id.toInt)))

[GitHub] cduque89 commented on issue #267: Invoker failling with error

cduque89 commented on issue #267: Invoker failling with error URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/267#issuecomment-409245761 Hi @markusthoemmes. We tried but now we get the following error: [ERROR] [#tid_sid_invoker] [Invoker] Error

[GitHub] sven-lange-last commented on issue #3922: Improve robustness of KafkaConsumerConnector

sven-lange-last commented on issue #3922: Improve robustness of KafkaConsumerConnector URL: https://github.com/apache/incubator-openwhisk/pull/3922#issuecomment-409245129 PG 3 / 2592 running. This is an automated message

[GitHub] upgle commented on issue #3880: Modify that web action in the bound package can be accessed.

upgle commented on issue #3880: Modify that web action in the bound package can be accessed. URL: https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-409237580 @rabbah Maybe it's done. could you please review it again? 

[GitHub] sven-lange-last commented on a change in pull request #3922: Improve robustness of KafkaConsumerConnector

sven-lange-last commented on a change in pull request #3922: Improve robustness of KafkaConsumerConnector URL: https://github.com/apache/incubator-openwhisk/pull/3922#discussion_r206545343 ## File path:

[GitHub] chetanmeh closed issue #3243: Collect test code coverage data

chetanmeh closed issue #3243: Collect test code coverage data URL: https://github.com/apache/incubator-openwhisk/issues/3243 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] chetanmeh commented on issue #3243: Collect test code coverage data

chetanmeh commented on issue #3243: Collect test code coverage data URL: https://github.com/apache/incubator-openwhisk/issues/3243#issuecomment-409230784 With #3685 merged all planned tasks under this issue are done This is

  1   2   >