[GitHub] inaspic closed issue #374: Error during "Deploy with Helm"
inaspic closed issue #374: Error during "Deploy with Helm" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/374 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] inaspic commented on issue #374: Error during "Deploy with Helm"
inaspic commented on issue #374: Error during "Deploy with Helm" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/374#issuecomment-442735730 I still got the same error even after implementing your suggestion, but I cleared/reset my k8s node and tried deploy again. This time the tests passed. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on a change in pull request #4088: Make activation polling for blocking invocations configurable
tysonnorris commented on a change in pull request #4088: Make activation
polling for blocking invocations configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/4088#discussion_r237374726
##
File path:
core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
##
@@ -593,11 +596,15 @@ protected[actions] trait PrimitiveActions {
//in case of an incomplete active-ack (record too large for example).
activeAckResponse.foreach {
case Right(activation) => result.trySuccess(Right(activation))
- case _ => pollActivation(docid, context, result, i =>
1.seconds + (2.seconds * i), maxRetries = 4)
+ case _ if (controllerActivationConfig.pollingFromDb) =>
+pollActivation(docid, context, result, i => 1.seconds + (2.seconds *
i), maxRetries = 4)
Review comment:
I'm looking at a case right now where if this pollActivation is removed, the
acks are received in the wrong order in some cases (completion before result) -
have you seen anything similar? unfortunately, it is something weird where it
only happens on first run of the controller - subsequent runs of same or
different actions don't exhibit the problem. Restarting controller, and the
first invocation always gets the acks in wrong order again.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] cbickel closed pull request #4135: Ensure ResultMessage is processed
cbickel closed pull request #4135: Ensure ResultMessage is processed
URL: https://github.com/apache/incubator-openwhisk/pull/4135
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
b/core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
index 35a45472a7..4010cc1e54 100644
---
a/core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
+++
b/core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
@@ -175,6 +175,8 @@ class ShardingContainerPoolBalancer(
/** State related to invocations and throttling */
protected[loadBalancer] val activations = TrieMap[ActivationId,
ActivationEntry]()
+ protected[loadBalancer] val blockingPromises =
+TrieMap[ActivationId, Promise[Either[ActivationId, WhiskActivation]]]()
private val activationsPerNamespace = TrieMap[UUID, LongAdder]()
private val totalActivations = new LongAdder()
private val totalActivationMemory = new LongAdder()
@@ -262,9 +264,13 @@ class ShardingContainerPoolBalancer(
chosen
.map { invoker =>
-val entry = setupActivation(msg, action, invoker)
+setupActivation(msg, action, invoker)
sendActivationToInvoker(messageProducer, msg, invoker).map { _ =>
- entry.promise.future
+ if (msg.blocking) {
+blockingPromises.getOrElseUpdate(msg.activationId,
Promise[Either[ActivationId, WhiskActivation]]()).future
+ } else {
+Future.successful(Left(msg.activationId))
+ }
}
}
.getOrElse {
@@ -313,8 +319,7 @@ class ShardingContainerPoolBalancer(
action.limits.memory.megabytes.MB,
action.limits.concurrency.maxConcurrent,
action.fullyQualifiedName(true),
- timeoutHandler,
- Promise[Either[ActivationId, WhiskActivation]]())
+ timeoutHandler)
})
}
@@ -387,9 +392,7 @@ class ShardingContainerPoolBalancer(
// Resolve the promise to send the result back to the user
// The activation will be removed from `activations`-map later, when we
receive the completion message, because the
// slot of the invoker is not yet free for new activations.
-activations.get(aid).map { entry =>
- entry.promise.trySuccess(response)
-}
+blockingPromises.remove(aid).map(_.trySuccess(response))
logging.info(this, s"received result ack for '$aid'")(tid)
}
@@ -422,13 +425,9 @@ class ShardingContainerPoolBalancer(
.foreach(_.releaseConcurrent(entry.fullyQualifiedEntityName,
entry.maxConcurrent, entry.memory.toMB.toInt))
if (!forced) {
entry.timeoutHandler.cancel()
- // If the action was blocking and the Resultmessage has been
received before nothing will happen here.
- // If the action was blocking and the ResultMessage is still
missing, we pass the ActivationId. With this Id,
- // the controller will get the result out of the database.
- // If the action was non-blocking, we will close the promise here.
- entry.promise.trySuccess(Left(aid))
} else {
- entry.promise.tryFailure(new Throwable("no completion ack received"))
+ // remove blocking promise when timeout, if the ResultMessage is
already processed, this will do nothing
+ blockingPromises.remove(aid).foreach(_.tryFailure(new Throwable("no
completion ack received")))
}
logging.info(this, s"${if (!forced) "received" else "forced"}
completion ack for '$aid'")(tid)
@@ -717,7 +716,6 @@ case class
ShardingContainerPoolBalancerConfig(blackboxFraction: Double, timeout
* @param namespaceId namespace that invoked the action
* @param invokerName invoker the action is scheduled to
* @param timeoutHandler times out completion of this activation, should be
canceled on good paths
- * @param promise the promise to be completed by the activation
*/
case class ActivationEntry(id: ActivationId,
namespaceId: UUID,
@@ -725,5 +723,4 @@ case class ActivationEntry(id: ActivationId,
memory: ByteSize,
maxConcurrent: Int,
fullyQualifiedEntityName: FullyQualifiedEntityName,
- timeoutHandler: Cancellable,
- promise: Promise[Either[ActivationId,
WhiskActivation]])
+ timeoutHandler: Cancellable)
This is an automated message from the
[GitHub] csantanapr closed pull request #375: Document pv configuration in k8s-docker-for-mac
csantanapr closed pull request #375: Document pv configuration in k8s-docker-for-mac URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/375 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/k8s-docker-for-mac.md b/docs/k8s-docker-for-mac.md index 67831c9..ccbcc6f 100644 --- a/docs/k8s-docker-for-mac.md +++ b/docs/k8s-docker-for-mac.md @@ -64,6 +64,21 @@ nginx: httpsNodePort: 31001 ``` +Since OpenWhisk deployment enables PersistentVolumes by default, you +should set the defaultStorageClass for your Kubernetes in Docker by adding +below configuration to mycluster.yaml: +```yaml +k8s: + persistence: +defaultStorageClass: hostpath +``` +or disable the default persistence by below configuration: +```yaml +k8s: + persistence: +enabled: false +``` + ## Hints and Tips One nice feature of using Kubernetes in Docker, is that the @@ -96,4 +111,3 @@ from outside the cluster (with the `wsk` cli) and from inside the cluster (in `mycluster.yaml`). Continuing the example from above, when setting the `--apihost` for the `wsk` cli, you would use `localhost:31001`. - This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo opened a new pull request #375: Document pv configuration in k8s-docker-for-mac
daisy-ycguo opened a new pull request #375: Document pv configuration in k8s-docker-for-mac URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/375 Resolves issue #374 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4141: Use Stricter Retry Logic in ApacheBlockingContainerClient
codecov-io commented on issue #4141: Use Stricter Retry Logic in ApacheBlockingContainerClient URL: https://github.com/apache/incubator-openwhisk/pull/4141#issuecomment-442721117 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141?src=pr=h1) Report > Merging [#4141](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/eff21ec7481d3b72ae0273dba8bcae09b87e73e0?src=pr=desc) will **increase** coverage by `3.38%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141?src=pr=tree) ```diff @@Coverage Diff@@ ## master #4141 +/- ## = + Coverage 77.91% 81.3% +3.38% = Files 151 151 Lines72777280 +3 Branches 468 466 -2 = + Hits 56705919 +249 + Misses 16071361 -246 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../containerpool/ApacheBlockingContainerClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9BcGFjaGVCbG9ja2luZ0NvbnRhaW5lckNsaWVudC5zY2FsYQ==) | `72.41% <100%> (+1.5%)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.54%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-62.5%)` | :arrow_down: | | [...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh) | `40% <0%> (-20%)` | :arrow_down: | | [...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...che/openwhisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `73.73% <0%> (+0.5%)` | :arrow_up: | | [...a/org/apache/openwhisk/core/controller/Rules.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9SdWxlcy5zY2FsYQ==) | `89.93% <0%> (+0.67%)` | :arrow_up: | | ... and [45 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4141?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] daisy-ycguo edited a comment on issue #374: Error during "Deploy with Helm"
daisy-ycguo edited a comment on issue #374: Error during "Deploy with Helm" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/374#issuecomment-442703048 @inaspic docker-for-desk doesn't have persistence volume configured by default. You can set `k8s.persistence.enabled` to false in your configuration file `mycluster.yaml`. Add below three lines to your `mycluster.yaml`, delete your deployment and try again. ``` k8s: persistence: enabled: false ``` `mycluster.yaml` file looks like below: ``` whisk: ingress: type: NodePort apiHostName: 192.168.65.3 apiHostPort: 31001 nginx: httpsNodePort: 31001 k8s: persistence: enabled: false ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ningyougang commented on issue #4135: Ensure ResultMessage is processed
ningyougang commented on issue #4135: Ensure ResultMessage is processed URL: https://github.com/apache/incubator-openwhisk/pull/4135#issuecomment-442707542 @cbickel ,can be merged? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] npearce commented on issue #1005: Action has no kind set - Error decoding runtimes with Local Values
npearce commented on issue #1005: Action has no kind set - Error decoding runtimes with Local Values URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1005#issuecomment-442705866 I believe I ran into the same problem with a fresh docker-compose install today. You can work around this with `--strict` Verbose '-v' output below - note the missing runtimes.json warning: ``` $ wskdeploy -m manifest.yml -v Info: deploy using deployment file []... Info: Configuration: > ApiHost: [] > Auth: [] > Namespace: [] > ApiVersion: [] > CfgFile: [/Users/npearce/.wskprops] > CliVersion: [0.9.9] > ProjectPath: [.] > DeploymentPath: [] > ManifestPath: [manifest.yml] > Preview: [false] > Strict: [false] > Key: [] > Cert: [] > Managed: [false] > ProjectName: [] > ApigwAccessToken: [] > Verbose: [true] > Trace: [false] > Sync: [false] > Report: [false] > Param: [[]] > ParamFile: [] Info: The API host is [xx], from .wskprops. Info: The auth key is set, from .wskprops. Info: The namespace is [guest], from .wskprops. Info: Unmarshal OpenWhisk runtimes from local values. Warning: open /private/tmp/wskdeploy-20181108-94023-1cdcxf7/incubator-openwhisk-wskdeploy-0.9.9/src/github.com/apache/incubator-openwhisk-wskdeploy/runtimes/runtimes.json: no such file or directory Warning: Invalid or missing runtime [nodejs:6] specified in manifest for the action [hello_world]. Warning: Runtime changed to [] based on the action's source file extension for action [hello_world]. Error: manifestreader.go [123]: [ERROR_YAML_FILE_FORMAT_ERROR]: File: [manifest.yml]: ==> manifestreader.go [334]: [ERROR_YAML_PARSER_ERROR]: File: [manifest.yml]: Action [hello_world] has no kind set. ==> $ ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo edited a comment on issue #374: Error during "Deploy with Helm"
daisy-ycguo edited a comment on issue #374: Error during "Deploy with Helm" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/374#issuecomment-442703048 @inaspic docker-for-desk doesn't have persistence volume configured. You have to set `k8s.persistence.enabled` to false in your configuration file `mycluster.yaml`. Add below three lines to your `mycluster.yaml`, delete your deployment and try again. ``` k8s: persistence: enabled: false ``` `mycluster.yaml` file looks like below: ``` whisk: ingress: type: NodePort apiHostName: 192.168.65.3 apiHostPort: 31001 nginx: httpsNodePort: 31001 k8s: persistence: enabled: false ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #374: Error during "Deploy with Helm"
daisy-ycguo commented on issue #374: Error during "Deploy with Helm" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/374#issuecomment-442703048 @inaspic docker-for-desk doesn't have persistence volume configured. You have to set `k8s.persistence.enabled` to false in your configuration file `mycluster.yaml`. Add below three lines to your `mycluster.yaml`, delete your deployment and try again. ``` k8s: persistence: enabled: false ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #4122: Protect Package Bindings from containing circular references
chetanmeh commented on issue #4122: Protect Package Bindings from containing circular references URL: https://github.com/apache/incubator-openwhisk/pull/4122#issuecomment-442697015 @asteed Should we also update swagger definition for 422 status code response in package api? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] inaspic commented on issue #374: Error during "Deploy with Helm"
inaspic commented on issue #374: Error during "Deploy with Helm" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/374#issuecomment-442687114 I have one node (docker-for-desk): Kernel Version: 4.9.125-linuxkit OS Image: Docker for Mac Container Runtime Version: docker://18.9.0 Kubelet Version: v1.10.3 Kube-Proxy Version: v1.10.3 Operating system: linux Architecture: amd64 and mycluster.yaml is: whisk: ingress: type: NodePort apiHostName: 192.168.65.3 apiHostPort: 31001 nginx: httpsNodePort: 31001 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd opened a new pull request #4142: tools/dev - updated intellij script to accommodate docker-compose
ddragosd opened a new pull request #4142: tools/dev - updated intellij script to accommodate docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/4142 ## Description This PR updates `gradlew :tools:dev:intellij` to work with `docker-compose`. It basically makes the generation of IntelliJ configuration a bit more generic. ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [x] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daisy-ycguo commented on issue #374: Error during "Deploy with Helm"
daisy-ycguo commented on issue #374: Error during "Deploy with Helm" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/374#issuecomment-442676165 @inaspic Can you explain more about your K8s environment? e.g. how many worker nodes, which version, the mycluster.yaml you are using. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] inaspic opened a new issue #374: Error during "Deploy with Helm"
inaspic opened a new issue #374: Error during "Deploy with Helm" URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/374 I'm following the steps in the README to deploy OpenWhisk. I ran the following: `helm install ./helm/openwhisk --namespace=openwhisk --name=owdev -f mycluster.yaml` but I get the following error in the controller: `Liveness probe failed: Get http://10.1.0.170:8080/ping: dial tcp 10.1.0.170:8080: connect: connection refused Back-off restarting failed container` Here is the log: Picked up JAVA_TOOL_OPTIONS: -XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap [2018-11-29T01:43:35.126Z] [INFO] Initializing Kamon... [INFO] [11/29/2018 01:43:38.471] [main] [StatsDExtension(akka://kamon)] Starting the Kamon(StatsD) extension [2018-11-29T01:43:38.824Z] [INFO] Slf4jLogger started [2018-11-29T01:43:39.863Z] [INFO] [#tid_sid_unknown] [Config] environment set value for limits.triggers.fires.perMinute [2018-11-29T01:43:39.870Z] [INFO] [#tid_sid_unknown] [Config] environment set value for limits.actions.sequence.maxLength [2018-11-29T01:43:39.871Z] [INFO] [#tid_sid_unknown] [Config] environment set value for limits.actions.invokes.concurrent [2018-11-29T01:43:39.873Z] [INFO] [#tid_sid_unknown] [Config] environment set value for controller.instances [2018-11-29T01:43:39.874Z] [INFO] [#tid_sid_unknown] [Config] environment set value for limits.actions.invokes.perMinute [2018-11-29T01:43:39.875Z] [INFO] [#tid_sid_unknown] [Config] environment set value for runtimes.manifest [2018-11-29T01:43:39.876Z] [INFO] [#tid_sid_unknown] [Config] environment set value for kafka.hosts [2018-11-29T01:43:39.878Z] [INFO] [#tid_sid_unknown] [Config] environment set value for port [2018-11-29T01:43:41.958Z] [INFO] [#tid_sid_unknown] [KafkaMessagingProvider] topic completed0 already existed [2018-11-29T01:43:42.311Z] [INFO] [#tid_sid_unknown] [KafkaMessagingProvider] topic health already existed [2018-11-29T01:43:42.696Z] [INFO] [#tid_sid_unknown] [KafkaMessagingProvider] topic cacheInvalidation already existed [2018-11-29T01:43:43.156Z] [INFO] [#tid_sid_unknown] [KafkaMessagingProvider] topic events already existed [2018-11-29T01:43:46.316Z] [INFO] [#tid_sid_controller] [Controller] starting controller instance 0 [marker:controller_startup0_count:6458] [2018-11-29T01:43:47.615Z] [INFO] [#tid_sid_unknown] [Controller] Shutting down Kamon with coordinated shutdown [INFO] [11/29/2018 01:43:48.308] [kamon-akka.actor.default-dispatcher-3] [akka://kamon/user/metrics] Message [kamon.metric.SubscriptionsDispatcher$Tick$] without sender to Actor[akka://kamon/user/metrics#1262782540] was not delivered. [1] dead letters encountered. This logging can be turned off or adjusted with configuration settings 'akka.log-dead-letters' and 'akka.log-dead-letters-during-shutdown'. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris closed pull request #4114: Update KindRestrictor to merge namespace and default whitelists
tysonnorris closed pull request #4114: Update KindRestrictor to merge namespace
and default whitelists
URL: https://github.com/apache/incubator-openwhisk/pull/4114
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/KindRestrictor.scala
b/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/KindRestrictor.scala
index 8154cd8b86..88ba6d63aa 100644
---
a/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/KindRestrictor.scala
+++
b/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/KindRestrictor.scala
@@ -46,10 +46,8 @@ case class KindRestrictor(whitelist: Option[Set[String]] =
None)(implicit loggin
})(TransactionId.controller)
def check(user: Identity, kind: String): Boolean = {
-user.limits.allowedKinds
- .orElse(whitelist)
- .map(allowed => allowed.contains(kind))
- .getOrElse(true)
+val kindList =
user.limits.allowedKinds.getOrElse(Set.empty).union(whitelist.getOrElse(Set.empty))
+kindList.isEmpty || kindList.contains(kind)
}
}
diff --git
a/tests/src/test/scala/org/apache/openwhisk/core/controller/test/KindRestrictorTests.scala
b/tests/src/test/scala/org/apache/openwhisk/core/controller/test/KindRestrictorTests.scala
index 40084b3564..ebdc85a1fa 100644
---
a/tests/src/test/scala/org/apache/openwhisk/core/controller/test/KindRestrictorTests.scala
+++
b/tests/src/test/scala/org/apache/openwhisk/core/controller/test/KindRestrictorTests.scala
@@ -49,16 +49,16 @@ class KindRestrictorTests extends FlatSpec with Matchers
with StreamLogging {
allKinds.foreach(k => kr.check(subject, k) shouldBe true)
}
- it should "not grant subject access to any kinds if limit is the empty set"
in {
+ it should "grant subject access to any kinds if limit is the empty set" in {
val subject = WhiskAuthHelpers.newIdentity().copy(limits =
UserLimits(allowedKinds = Some(Set.empty)))
val kr = KindRestrictor()
-allKinds.foreach(k => kr.check(subject, k) shouldBe false)
+allKinds.foreach(k => kr.check(subject, k) shouldBe true)
}
- it should "not grant subject access to any kinds if white list is the empty
set" in {
+ it should "grant subject access to any kinds if white list is the empty set"
in {
val subject = WhiskAuthHelpers.newIdentity()
val kr = KindRestrictor(Set[String]())
-allKinds.foreach(k => kr.check(subject, k) shouldBe false)
+allKinds.foreach(k => kr.check(subject, k) shouldBe true)
}
it should "grant subject access only to subject-limited kinds" in {
@@ -75,11 +75,11 @@ class KindRestrictorTests extends FlatSpec with Matchers
with StreamLogging {
disallowedKinds.foreach(k => kr.check(subject, k) shouldBe false)
}
- it should "grant subject access only to explicitly limited kind" in {
+ it should "grant subject access both explicitly limited kinds and default
whitelisted kinds" in {
val explicitKind = allowedKinds.head
val subject = WhiskAuthHelpers.newIdentity().copy(limits =
UserLimits(allowedKinds = Some(Set(explicitKind
val kr = KindRestrictor(allowedKinds.tail)
-allKinds.foreach(k => kr.check(subject, k) shouldBe (k == explicitKind))
+allKinds.foreach(k => kr.check(subject, k) shouldBe
allowedKinds.contains(k))
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss commented on issue #3886: Proposing Lean OpenWhisk
dgrove-oss commented on issue #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#issuecomment-442634542 PG1 3699 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #4108: Making Redis password protected
dgrove-oss commented on issue #4108: Making Redis password protected URL: https://github.com/apache/incubator-openwhisk/pull/4108#issuecomment-442629728 PG1 3698 looks clean to me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on a change in pull request #388: Save Code Associated with Blackbox Actions
dubee commented on a change in pull request #388: Save Code Associated with
Blackbox Actions
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/388#discussion_r237270989
##
File path: commands/action.go
##
@@ -692,7 +692,7 @@ func saveCode(action whisk.Action, filename string) (err
error) {
exec = *action.Exec
runtime = strings.Split(exec.Kind, ":")[0]
- if strings.ToLower(runtime) == BLACKBOX {
+ if strings.ToLower(runtime) == BLACKBOX && exec.Code == nil &&
*exec.Binary == false {
Review comment:
Yes, the binary field should always have a value. @mdeuser
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io edited a comment on issue #3886: Proposing Lean OpenWhisk
codecov-io edited a comment on issue #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886#issuecomment-406254669 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=h1) Report > Merging [#3886](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/83de20ef2b7ef383a5708b59f36ba38e4cc279a8?src=pr=desc) will **decrease** coverage by `6.61%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=tree) ```diff @@Coverage Diff @@ ## master#3886 +/- ## == - Coverage 86.48% 79.87% -6.62% == Files 151 155 +4 Lines7272 7452 +180 Branches 468 473 +5 == - Hits 6289 5952 -337 - Misses983 1500 +517 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=tree) | Coverage Δ | | |---|---|---| | [...apache/openwhisk/connector/lean/LeanConsumer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9sZWFuL0xlYW5Db25zdW1lci5zY2FsYQ==) | `0% <0%> (ø)` | | | [...che/openwhisk/core/loadBalancer/LeanBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xlYW5CYWxhbmNlci5zY2FsYQ==) | `0% <0%> (ø)` | | | [...apache/openwhisk/connector/lean/LeanProducer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9sZWFuL0xlYW5Qcm9kdWNlci5zY2FsYQ==) | `0% <0%> (ø)` | | | [...enwhisk/connector/lean/LeanMessagingProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9sZWFuL0xlYW5NZXNzYWdpbmdQcm92aWRlci5zY2FsYQ==) | `0% <0%> (ø)` | | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.54%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-62.5%)` | :arrow_down: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `59.7% <0%> (-25.38%)` | :arrow_down: | | ... and [12 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3886?src=pr=footer). Last update
[GitHub] pritidesai opened a new issue #1016: Whisk Client Refactor including Platform Agnostic Home Dir location
pritidesai opened a new issue #1016: Whisk Client Refactor including Platform Agnostic Home Dir location URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1016 After go client is upgraded to use platform independent library to determine the home directory (see issue # https://github.com/apache/incubator-openwhisk-client-go/issues/108), update whisk deploy to adopt those changes. Also, @mrutkows and I discovered there is a discrepancy in initializing and creating whisk client object in whisk deploy. There are calls in multiple places which overrides the previous calls. `initConfig` at https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/cmd/root.go#L102 reading `.wskprops` right when whisk deploy is invoked even before reading manifest file. Again, while deploying openwhisk assets, new whisk config object is created at https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/cmd/root.go#L223 The same object is initialized while undeployment at https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/cmd/root.go#L278 and at https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/cmd/root.go#L335 Validate whether reading `.wskprops` in `initConfig` is of any use and document what is it used for. Discard it if not needed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai opened a new issue #108: Platform Agnostic - determine home dir location
pritidesai opened a new issue #108: Platform Agnostic - determine home dir location URL: https://github.com/apache/incubator-openwhisk-client-go/issues/108 @jthomas discovered `wskdeploy` was looking for `.wskprops` file under current directory instead of user's home for 386 version of OS (https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014). @mrutkows applied a quick fix to unblock @jthomas so that he can continue working on his presentation (https://github.com/apache/incubator-openwhisk-wskdeploy/pull/1015). But in long term, we would like to fix this in right way which is adding it in Go client so that the same functionality can be used by the CLI and also by Whisk Deploy. We are looking at changing `GetPropsFromWskprops` located at https://github.com/apache/incubator-openwhisk-client-go/blob/master/whisk/wskprops.go#L162 Add functionality of reading `.wskprops` path using homedir.Expand() like it done in CLI at https://github.com/apache/incubator-openwhisk-cli/blob/461f94fafe405feb3c664a43f6c117bac4d3c27f/commands/property.go#L402. After the go client is changed, we need to update Whisk Deploy and CLI to use this functionality from here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #4111: Update to Gradle 4.10.2
csantanapr commented on a change in pull request #4111: Update to Gradle 4.10.2
URL:
https://github.com/apache/incubator-openwhisk/pull/4111#discussion_r237249794
##
File path: tests/src/main/scala/org/apache/openwhisk/GradleWorkaround.scala
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.openwhisk
+
+/**
+ * This class is a workaround for https://github.com/gradle/gradle/issues/6849
+ */
+class GradleWorkaround {}
Review comment:
臘♂️ 路♂️
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] kpavel opened a new pull request #3886: Proposing Lean OpenWhisk
kpavel opened a new pull request #3886: Proposing Lean OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3886 The proposition is to get rid of Kafka, have controller and invoker compiled together into a "lean" controller-invoker (have a Gradle project for that) with controller calling the invoker's method directly via an in-memory object (a queue, which is also loaded via SPI) via a new pluggable load balancer that is selected via SPI using configuration file property setting. For more information here is a [blog](https://medium.com/@davidbr_9022/lean-openwhisk-open-source-faas-for-edge-computing-fb823c6bbb9b) As well, briefly discussed it in this [thread](https://lists.apache.org/thread.html/516efc0ed9afb09fe52e30d10eb9fe5091af91df53a46c07e1701122@%3Cdev.openwhisk.apache.org%3E) ## Description The goal is to avoid changes in the core components as much as possible. Rather this PR adds a few components. The main additions are as follows: - LeanBalancer SPI: provides LoadBalancer to communicate with Invoker directly without Kafka in the middle (Invoker does not exist as a separate entity; it is built together with Controller) - LeanMessagingProvider SPI: provides Producer/Consumer implementers to communicate via in-memory queue instead of Kafka. - Ansible deployment: added controller-lean.yml and other files required for the Ansible deployment. Since lean controller is a combination of the controller + invoker projects, its ansible deploy.yml requires most of the values from both. Currently this problem is resolved by partially replicating variables from the regular invoker's deploy.yml to the tasks/invoker-lean.yml. Probably it would be better to avoid this duplication by having everything we need for lean in the regular deploy.yml. - Dockerfile: to build Lean controller docker image, which is a merge of the regular invoker + controller Dockerfile - Vagrantfile: a small change to make Lean available using environment variable ## My changes affect the following components - [ ] API - [x] Controller - [ ] Message Bus (e.g., Kafka) - [x] Loadbalancer - [x] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [x] Deployment - [ ] CLI - [ ] General tooling - [x] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [x] My changes require further changes to the documentation. - [x] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kpavel closed pull request #3886: Proposing Lean OpenWhisk
kpavel closed pull request #3886: Proposing Lean OpenWhisk
URL: https://github.com/apache/incubator-openwhisk/pull/3886
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ansible/README.md b/ansible/README.md
index eeca95ff2c..fb7145c8aa 100644
--- a/ansible/README.md
+++ b/ansible/README.md
@@ -280,6 +280,17 @@ This is usually not necessary, however in case you want to
uninstall all prereqs
ansible-playbook -i environments/ prereq.yml -e mode=clean
```
+### Lean Setup
+To have a lean setup (no Kafka, Zookeeper and no Invokers as separate
entities):
+
+At [Deploying Using CouchDB](ansible/README.md#deploying-using-cloudant) step,
replace:
+```
+ansible-playbook -i environments/ openwhisk.yml
+```
+by:
+```
+ansible-playbook -i environments/ openwhisk-lean.yml
+```
### Troubleshooting
Some of the more common problems and their solution are listed here.
diff --git a/ansible/controller-lean.yml b/ansible/controller-lean.yml
new file mode 100644
index 00..0aa588ddea
--- /dev/null
+++ b/ansible/controller-lean.yml
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+---
+# This playbook deploys Openwhisk Controllers.
+
+- hosts: controllers
+ vars:
+#
+# host_group - usually "{{ groups['...'] }}" where '...' is what was used
+# for 'hosts' above. The hostname of each host will be looked up in this
+# group to assign a zero-based index. That index will be used in concert
+# with 'name_prefix' below to assign a host/container name.
+host_group: "{{ groups['controllers'] }}"
+#
+# name_prefix - a unique prefix for this set of controllers. The prefix
+# will be used in combination with an index (determined using
+# 'host_group' above) to name host/controllers.
+name_prefix: "controller"
+#
+# controller_index_base - the deployment process allocates host docker
+# ports to individual controllers based on their indices. This is an
+# additional offset to prevent collisions between different controller
+# groups. Usually 0 if only one group is being deployed, otherwise
+# something like "{{ groups['firstcontrollergroup']|length }}"
+controller_index_base: 0
+#
+# select which additional capabilities (from the controller role) need
+# to be added to the controller. Plugin will override default
+# configuration settings. (Plugins are found in the
+# 'roles/controller/tasks' directory for now.)
+controller_plugins:
+ # Join an akka cluster rather than running standalone akka
+ - "lean"
+
+image_name: "lean"
+lean: true
+
+ roles:
+- controller
diff --git a/ansible/openwhisk-lean.yml b/ansible/openwhisk-lean.yml
new file mode 100644
index 00..9dd87cf25c
--- /dev/null
+++ b/ansible/openwhisk-lean.yml
@@ -0,0 +1,12 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+---
+# This playbook deploys Lean Openwhisk stack.
+# It assumes you have already set up your database with the respective db
provider playbook (currently cloudant.yml or couchdb.yml)
+# It assumes that wipe.yml have being deployed at least once
+
+- import_playbook: controller-lean.yml
+
+- import_playbook: edge.yml
+
+- import_playbook: downloadcli.yml
diff --git a/ansible/roles/controller/tasks/deploy.yml
b/ansible/roles/controller/tasks/deploy.yml
index 0fb2ebbdf1..4ec8a11373 100644
--- a/ansible/roles/controller/tasks/deploy.yml
+++ b/ansible/roles/controller/tasks/deploy.yml
@@ -6,14 +6,15 @@
- import_tasks: docker_login.yml
-- name: get controller name and index
+- name: get controller name, index and image name
set_fact:
controller_name: "{{ name_prefix ~ host_group.index(inventory_hostname) }}"
controller_index:
"{{ (controller_index_base|int) + host_group.index(inventory_hostname)
}}"
+image_name: "{{ image_name | default('controller') }}"
-- name: "pull the {{ docker.image.tag }} image of controller"
- shell: "docker pull {{docker_registry}}{{ docker.image.prefix
}}/controller:{{docker.image.tag}}"
+- name: pull the {{ image_name }}:{{ docker.image.tag }} image of controller
+ shell: "docker pull {{docker_registry}}{{ docker.image.prefix
}}/{{image_name}}:{{docker.image.tag}}"
when: docker_registry != ""
register: result
until: (result.rc == 0)
@@ -276,26 +277,32 @@
controller_volumes: "{{ controller_volumes|default({}) +
[coverage_logs_dir+'/controller:/coverage'] }}"
when: coverage_enabled
+- name: populate controller docker container parameters
+ set_fact:
[GitHub] tysonnorris closed pull request #4122: Protect Package Bindings from containing circular references
tysonnorris closed pull request #4122: Protect Package Bindings from containing
circular references
URL: https://github.com/apache/incubator-openwhisk/pull/4122
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/scala/src/main/scala/org/apache/openwhisk/http/ErrorResponse.scala
b/common/scala/src/main/scala/org/apache/openwhisk/http/ErrorResponse.scala
index b14d338e12..a877630cb1 100644
--- a/common/scala/src/main/scala/org/apache/openwhisk/http/ErrorResponse.scala
+++ b/common/scala/src/main/scala/org/apache/openwhisk/http/ErrorResponse.scala
@@ -112,6 +112,7 @@ object Messages {
val requestedBindingIsNotValid = "Cannot bind to a resource that is not a
package."
val notAllowedOnBinding = "Operation not permitted on package binding."
def packageNameIsReserved(name: String) = s"Package name '$name' is
reserved."
+ def packageBindingCircularReference(name: String) = s"Package binding
'$name' contains a circular reference."
/** Error messages for triggers */
def triggerWithInactiveRule(rule: String, action: String) = {
diff --git
a/core/controller/src/main/scala/org/apache/openwhisk/core/controller/Packages.scala
b/core/controller/src/main/scala/org/apache/openwhisk/core/controller/Packages.scala
index 6a07e5d344..b1e555bbbe 100644
---
a/core/controller/src/main/scala/org/apache/openwhisk/core/controller/Packages.scala
+++
b/core/controller/src/main/scala/org/apache/openwhisk/core/controller/Packages.scala
@@ -242,8 +242,8 @@ trait WhiskPackagesApi extends WhiskCollectionAPI with
ReferencedEntities {
val validateBinding = content.binding map { binding =>
wp.binding map {
// pre-existing entity is a binding, check that new binding is valid
-b =>
- checkBinding(b.fullyQualifiedName)
+_ =>
+ checkBinding(binding.fullyQualifiedName)
} getOrElse {
// pre-existing entity is a package, cannot make it a binding
Future.failed(RejectRequest(Conflict,
Messages.packageCannotBecomeBinding))
@@ -299,9 +299,14 @@ trait WhiskPackagesApi extends WhiskCollectionAPI with
ReferencedEntities {
case b: Binding =>
val docid = b.fullyQualifiedName.toDocId
logging.debug(this, s"fetching package '$docid' for reference")
-getEntity(WhiskPackage.get(entityStore, docid), Some {
- mergePackageWithBinding(Some { wp }) _
-})
+if (docid == wp.docid) {
+ logging.error(this, s"unexpected package binding refers to itself:
$docid")
+ terminate(UnprocessableEntity,
Messages.packageBindingCircularReference(b.fullyQualifiedName.toString))
+} else {
+ getEntity(WhiskPackage.get(entityStore, docid), Some {
+mergePackageWithBinding(Some { wp }) _
+ })
+}
} getOrElse {
val pkg = ref map { _ inherit wp.parameters } getOrElse wp
logging.debug(this, s"fetching package actions in '${wp.fullPath}'")
diff --git
a/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/PackageCollection.scala
b/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/PackageCollection.scala
index 7dfb0c873d..b53dcbc7d3 100644
---
a/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/PackageCollection.scala
+++
b/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/PackageCollection.scala
@@ -98,7 +98,15 @@ class PackageCollection(entityStore: EntityStore)(implicit
logging: Logging) ext
val pkgOwner = namespaces.contains(binding.namespace.asString)
val pkgDocid = binding.docid
logging.debug(this, s"checking subject has privilege '$right' for
bound package '$pkgDocid'")
- checkPackageReadPermission(namespaces, pkgOwner, pkgDocid)
+ if (doc == pkgDocid) {
+logging.error(this, s"unexpected package binding refers to itself:
$doc")
+Future.failed(
+ RejectRequest(
+UnprocessableEntity,
+
Messages.packageBindingCircularReference(binding.fullyQualifiedName.toString)))
+ } else {
+checkPackageReadPermission(namespaces, pkgOwner, pkgDocid)
+ }
} else {
logging.debug(this, s"entitlement check on package binding, '$right'
allowed?: false")
Future.successful(false)
diff --git
a/tests/src/test/scala/org/apache/openwhisk/core/controller/test/PackagesApiTests.scala
b/tests/src/test/scala/org/apache/openwhisk/core/controller/test/PackagesApiTests.scala
index dd1439713d..8117993190 100644
---
a/tests/src/test/scala/org/apache/openwhisk/core/controller/test/PackagesApiTests.scala
+++
[GitHub] dubee commented on a change in pull request #4141: Use Stricter Retry Logic in ApacheBlockingContainerClient
dubee commented on a change in pull request #4141: Use Stricter Retry Logic in
ApacheBlockingContainerClient
URL:
https://github.com/apache/incubator-openwhisk/pull/4141#discussion_r237238880
##
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/ApacheBlockingContainerClient.scala
##
@@ -149,11 +152,13 @@ protected class ApacheBlockingContainerClient(hostname:
String,
} match {
case Success(response) => response
case Failure(t: RetryableConnectionError) if retry =>
+val waitTime = (Instant.now.toEpochMilli -
start.toEpochMilli).milliseconds
val sleepTime = 50.milliseconds
if (timeout > Duration.Zero) {
Thread.sleep(sleepTime.toMillis)
- val newTimeout = timeout - sleepTime
- execute(request, newTimeout, maxConcurrent, retry = true)
+ val newTimeout = timeout - sleepTime - waitTime
+ val newRetryCount = retryCount + 1
+ execute(request, newTimeout, maxConcurrent, retry = newRetryCount <
3 , retryCount = newRetryCount)
Review comment:
Three may be too low of a threshold?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dubee opened a new pull request #4141: Use Stricter Retry Logic in ApacheBlockingContainerClient
dubee opened a new pull request #4141: Use Stricter Retry Logic in ApacheBlockingContainerClient URL: https://github.com/apache/incubator-openwhisk/pull/4141 ## Description The `execute` method in `ApacheBlockingContainerClient` allows the invoker to retry communication attempts to a user container. This retry logic proves to be problematic when a user container exits before the invoker is able to connect to it. Such an event may happen if a user container exits very quickly. In this case the invoker retries an exorbitant amount of times needless as the container has already exited, resulting in the waste of resources in the invoker. For retries, these changes take in to consideration the amount of time taken during the connection attempt from the invoker to a user container. There is also a cap introduced on the number of retries allowed. As a result, retries will be performed a maximum of three times or less if the action timeout is exceeded when taking into consideration the amount of time each connection attempt takes. ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version
mrutkows commented on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014#issuecomment-442567652 Looks like James Dubee added this lib. and "Expand()" to the CLI as part of the Go formatting PR: https://github.com/apache/incubator-openwhisk-cli/commit/c615efb697af7ef05c9b238005d5c8efe506c323 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss closed pull request #12: Fix incorrect path handling in fsm synthesis
dgrove-oss closed pull request #12: Fix incorrect path handling in fsm synthesis
URL: https://github.com/apache/incubator-openwhisk-composer/pull/12
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/conductor.js b/conductor.js
index 0764018..a70f5a7 100644
--- a/conductor.js
+++ b/conductor.js
@@ -153,7 +153,11 @@ function main (composition) {
function compile (parent, node) {
if (arguments.length === 1) return [{ parent, type: 'empty' }]
-if (arguments.length === 2) return
Object.assign(compiler[node.type](node.path || parent, node), { path: node.path
})
+if (arguments.length === 2) {
+ const fsm = compiler[node.type](node.path || parent, node)
+ if (node.path !== undefined) fsm[0].path = node.path
+ return fsm
+}
return Array.prototype.slice.call(arguments, 1).reduce((fsm, node) => {
fsm.push(...compile(parent, node)); return fsm }, [])
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pritidesai closed pull request #1015: Quickfix: Add fallback method to find wskprops when go-client fails
pritidesai closed pull request #1015: Quickfix: Add fallback method to find
wskprops when go-client fails
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/1015
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/utils/misc.go b/utils/misc.go
index 715db303..b32c0921 100644
--- a/utils/misc.go
+++ b/utils/misc.go
@@ -60,10 +60,19 @@ type RuleRecord struct {
Packagename string
}
+func fallbackHome() string {
+ if home := os.Getenv("HOME"); home != "" {
+ return home
+ }
+ // For Windows.
+ return os.Getenv("UserProfile")
+}
+
func GetHomeDirectory() string {
usr, err := user.Current()
if err != nil {
- return ""
+
+ return fallbackHome()
}
return usr.HomeDir
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io edited a comment on issue #4122: Protect Package Bindings from containing circular references
codecov-io edited a comment on issue #4122: Protect Package Bindings from containing circular references URL: https://github.com/apache/incubator-openwhisk/pull/4122#issuecomment-439671190 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122?src=pr=h1) Report > Merging [#4122](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/83de20ef2b7ef383a5708b59f36ba38e4cc279a8?src=pr=desc) will **decrease** coverage by `5.38%`. > The diff coverage is `57.14%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122?src=pr=tree) ```diff @@Coverage Diff@@ ## master #4122 +/- ## = - Coverage 86.48% 81.1% -5.39% = Files 151 151 Lines72727276 +4 Branches 468 467 -1 = - Hits 62895901 -388 - Misses9831375 +392 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122?src=pr=tree) | Coverage Δ | | |---|---|---| | [...openwhisk/core/entitlement/PackageCollection.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXRsZW1lbnQvUGFja2FnZUNvbGxlY3Rpb24uc2NhbGE=) | `100% <ø> (ø)` | :arrow_up: | | [...cala/org/apache/openwhisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `92.22% <0%> (-1.04%)` | :arrow_down: | | [...rg/apache/openwhisk/core/controller/Packages.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9QYWNrYWdlcy5zY2FsYQ==) | `88.57% <66.66%> (-0.65%)` | :arrow_down: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.54%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-62.5%)` | :arrow_down: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `59.7% <0%> (-25.38%)` | :arrow_down: | | [...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh) | `40% <0%> (-20%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4122?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] mrutkows edited a comment on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version
mrutkows edited a comment on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014#issuecomment-442549656 @jthomas @pritidesai be aware we believe that the long-term fix (i.e., use a robust library like the one you found) within go-client is the correct fix and that would cause us then to clean up wskdeploy to not have ANY fallback methods. That is, we would only use the ReadProps from go-client exclusively (once it impl. a platform-aware solution) where as today we use a hybrid of the (failing) go-client and rely upon the utils/misc.go code you found For now, we have a PR to do a quick fix. Priti volunteered to open issues address this in go-client and then leveraged afterwards in wskdeploy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version
mrutkows commented on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014#issuecomment-442549656 @jthomas @pritidesai be aware we believe that the long-term fix (i.e., use a robust library like the one you found) within go-client is the correct fix and that would cause us then to clean up wskdeploy to not have ANY fallback methods. For now, we have a PR to do a quick fix. Priti volunteered to open issues address this in go-client and then leveraged afterwards in wskdeploy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tardieu opened a new pull request #12: Fix incorrect path handling in fsm synthesis
tardieu opened a new pull request #12: Fix incorrect path handling in fsm synthesis URL: https://github.com/apache/incubator-openwhisk-composer/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #1015: Quickfix: Add fallback method to find wskprops when go-client fails
mrutkows commented on issue #1015: Quickfix: Add fallback method to find wskprops when go-client fails URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/1015#issuecomment-442548655 quick fix to resolve: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014 Fixes #1014 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #1015: Quickfix: Add fallback method to find wskprops when go-client fails
mrutkows opened a new pull request #1015: Quickfix: Add fallback method to find wskprops when go-client fails URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/1015 We need a longer-term fix that starts in the Go Client (which we use in some cases) where Go client needs to be made more robust and perhaps look to packages such [ (i.e., https://github.com/mitchellh/go-homedir) it appears to be a single file under MIT license which if we switch to we would need to note.](https://github.com/mitchellh/go-homedir). Which is used by the CLI and appears to be a single file under MIT license which if we switch to we would need to note. This means go-client, and CLI may need to be cleaned up and once that is done wskdeploy would strictly rely upon go-client ReadProp() impl. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Juice10 commented on a change in pull request #61: Performance boost
Juice10 commented on a change in pull request #61: Performance boost
URL:
https://github.com/apache/incubator-openwhisk-runtime-go/pull/61#discussion_r237192968
##
File path: examples/benchmark/Makefile
##
@@ -0,0 +1,23 @@
+IMG?=whisk/actionloop-golang-v1.11
+IMG2?=whisk/actionloop
+
+all: golang bash
+
+test.lua:
+ echo 'wrk.method = "POST"'>test.lua
+ echo "wrk.body = '{\"value\":{\"name\":\"Mike\"}}'">>test.lua
+ echo 'wrk.headers["Content-Type"] = "application/json"'>>test.lua
+
+golang: test.lua
+ docker run -d --name under-test --rm -p 8080:8080 $(IMG)
+ invoke init main.go
Review comment:
Would be nice to include the `invoke` file/command in this PR
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #4122: Protect Package Bindings from containing circular references
rabbah commented on a change in pull request #4122: Protect Package Bindings
from containing circular references
URL:
https://github.com/apache/incubator-openwhisk/pull/4122#discussion_r237191013
##
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Packages.scala
##
@@ -299,9 +299,14 @@ trait WhiskPackagesApi extends WhiskCollectionAPI with
ReferencedEntities {
case b: Binding =>
val docid = b.fullyQualifiedName.toDocId
logging.debug(this, s"fetching package '$docid' for reference")
-getEntity(WhiskPackage.get(entityStore, docid), Some {
- mergePackageWithBinding(Some { wp }) _
-})
+if (docid == wp.docid) {
+ logging.error(this, "unexpected package binding refers to itself:
$docid")
Review comment:
pushed a commit to fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #4122: Protect Package Bindings from containing circular references
rabbah commented on a change in pull request #4122: Protect Package Bindings
from containing circular references
URL:
https://github.com/apache/incubator-openwhisk/pull/4122#discussion_r237190957
##
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/PackageCollection.scala
##
@@ -98,7 +98,15 @@ class PackageCollection(entityStore: EntityStore)(implicit
logging: Logging) ext
val pkgOwner = namespaces.contains(binding.namespace.asString)
val pkgDocid = binding.docid
logging.debug(this, s"checking subject has privilege '$right' for
bound package '$pkgDocid'")
- checkPackageReadPermission(namespaces, pkgOwner, pkgDocid)
+ if (doc == pkgDocid) {
+logging.error(this, "unexpected package binding refers to itself:
$docid")
Review comment:
pushed a commit to fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows edited a comment on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version
mrutkows edited a comment on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014#issuecomment-442511091 @jthomas Yeah was grepping around, will look at as well.. it appears to be a single file under MIT license which if we switch to we would need to note. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #4122: Protect Package Bindings from containing circular references
rabbah commented on a change in pull request #4122: Protect Package Bindings
from containing circular references
URL:
https://github.com/apache/incubator-openwhisk/pull/4122#discussion_r237182829
##
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Packages.scala
##
@@ -299,9 +299,14 @@ trait WhiskPackagesApi extends WhiskCollectionAPI with
ReferencedEntities {
case b: Binding =>
val docid = b.fullyQualifiedName.toDocId
logging.debug(this, s"fetching package '$docid' for reference")
-getEntity(WhiskPackage.get(entityStore, docid), Some {
- mergePackageWithBinding(Some { wp }) _
-})
+if (docid == wp.docid) {
+ logging.error(this, "unexpected package binding refers to itself:
$docid")
Review comment:
this won't interpolate correctly - you're missing an s"..." in the log
message.
same below.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #4122: Protect Package Bindings from containing circular references
rabbah commented on a change in pull request #4122: Protect Package Bindings
from containing circular references
URL:
https://github.com/apache/incubator-openwhisk/pull/4122#discussion_r237182954
##
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/PackageCollection.scala
##
@@ -98,7 +98,15 @@ class PackageCollection(entityStore: EntityStore)(implicit
logging: Logging) ext
val pkgOwner = namespaces.contains(binding.namespace.asString)
val pkgDocid = binding.docid
logging.debug(this, s"checking subject has privilege '$right' for
bound package '$pkgDocid'")
- checkPackageReadPermission(namespaces, pkgOwner, pkgDocid)
+ if (doc == pkgDocid) {
+logging.error(this, "unexpected package binding refers to itself:
$docid")
Review comment:
same as above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] drcariel commented on issue #365: include test from incubator-openwhisk PR#2941
drcariel commented on issue #365: include test from incubator-openwhisk PR#2941 URL: https://github.com/apache/incubator-openwhisk-cli/pull/365#issuecomment-442520726 @houshengbo done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #4135: Ensure ResultMessage is processed
codecov-io edited a comment on issue #4135: Ensure ResultMessage is processed URL: https://github.com/apache/incubator-openwhisk/pull/4135#issuecomment-441649029 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135?src=pr=h1) Report > Merging [#4135](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7bd49718232d0381b53794f9353c014a1abfef15?src=pr=desc) will **decrease** coverage by `4.89%`. > The diff coverage is `85.71%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4135 +/- ## = - Coverage 86.17% 81.28% -4.9% = Files 151 151 Lines7271 7272 +1 Branches 469 468 -1 = - Hits 6266 5911-355 - Misses 1005 1361+356 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `85.09% <85.71%> (ø)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.54%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-62.5%)` | :arrow_down: | | [...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh) | `40% <0%> (-20%)` | :arrow_down: | | [...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...rg/apache/openwhisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `92.3% <0%> (-3.85%)` | :arrow_down: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `86.71% <0%> (-0.7%)` | :arrow_down: | | ... and [1 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] codecov-io edited a comment on issue #4135: Ensure ResultMessage is processed
codecov-io edited a comment on issue #4135: Ensure ResultMessage is processed URL: https://github.com/apache/incubator-openwhisk/pull/4135#issuecomment-441649029 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135?src=pr=h1) Report > Merging [#4135](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/7bd49718232d0381b53794f9353c014a1abfef15?src=pr=desc) will **decrease** coverage by `4.89%`. > The diff coverage is `85.71%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4135 +/- ## = - Coverage 86.17% 81.28% -4.9% = Files 151 151 Lines7271 7272 +1 Branches 469 468 -1 = - Hits 6266 5911-355 - Misses 1005 1361+356 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/loadBalancer/ShardingContainerPoolBalancer.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL1NoYXJkaW5nQ29udGFpbmVyUG9vbEJhbGFuY2VyLnNjYWxh) | `85.09% <85.71%> (ø)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.54%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-62.5%)` | :arrow_down: | | [...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh) | `40% <0%> (-20%)` | :arrow_down: | | [...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...rg/apache/openwhisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `92.3% <0%> (-3.85%)` | :arrow_down: | | [...isk/core/controller/actions/PrimitiveActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1ByaW1pdGl2ZUFjdGlvbnMuc2NhbGE=) | `86.71% <0%> (-0.7%)` | :arrow_down: | | ... and [1 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4135?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] mrutkows commented on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version
mrutkows commented on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014#issuecomment-442511091 Yeah was grepping around, will look at as well This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jthomas commented on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version
jthomas commented on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014#issuecomment-442500661 Looks like the `wsk` CLI handles this using an external library. https://github.com/apache/incubator-openwhisk-cli/blob/461f94fafe405feb3c664a43f6c117bac4d3c27f/commands/property.go#L26 We might want to follow that approach instead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Juice10 opened a new pull request #181: create minio directory
Juice10 opened a new pull request #181: create minio directory URL: https://github.com/apache/incubator-openwhisk-devtools/pull/181 On Travis CI a number of directories get created by rclone in docker-compose and this leads to issues as those directories get set to root and are then not able to be edited. https://github.com/apache/incubator-openwhisk-devtools/pull/178 fixed the `api-gateway-ssl`. This fixes the `minio` file. Travis CI Logs: https://travis-ci.org/apache/incubator-openwhisk-devtools/jobs/459983182#L617-L625 ``` ls -l ~/tmp/openwhisk /home/travis/tmp/openwhisk: total 24 drwxrwxr-x 3 travis travis 4096 Nov 26 22:26 api-gateway-config drwxr-xr-x 2 root root 4096 Nov 26 22:27 api-gateway-ssl -rw-rw-r-- 1 travis travis 109 Nov 26 22:26 local.env drwxr-xr-x 4 root root 4096 Nov 26 22:27 minio drwxrwxr-x 2 travis travis 4096 Nov 26 22:26 rclone -rw-rw-r-- 1 travis travis 1904 Nov 26 22:27 setup.log ``` It's not just a Travis CI problem. Some people have been experiencing issues due to the minio directory being created by rclone: https://github.com/apache/incubator-openwhisk-devtools/issues/116#issuecomment-442045047 This PR fixes that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version
mrutkows commented on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014#issuecomment-442481132 and I believe while we are at it, we should emit a warning if we drop into looking for a "fallback" method and add Verbose/Trace to indicate where we ended up finding the value we will attempt to use (and the value itself) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows edited a comment on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version
mrutkows edited a comment on issue #1014: wskdeploy failing to read
configuration file from user home directory for 386 version
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014#issuecomment-442480492
Thanks James... and it looks easy to slot in that fallback function on error
```
func GetHomeDirectory() string {
usr, err := user.Current()
if err != nil {
return fallbackHome()
}
return usr.HomeDir
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mrutkows commented on issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version
mrutkows commented on issue #1014: wskdeploy failing to read configuration file
from user home directory for 386 version
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014#issuecomment-442480492
Thanks James... and it looks easy to slot in that fallback function on error
```
func GetHomeDirectory() string {
usr, err := user.Current()
if err != nil {
return fallbackHome()
}
return usr.HomeDir
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] dgrove-oss closed pull request #372: Helm chart providers
dgrove-oss closed pull request #372: Helm chart providers
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/372
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/helm/openwhisk/Chart.yaml b/helm/openwhisk/Chart.yaml
index 9069bac..73cbf7c 100644
--- a/helm/openwhisk/Chart.yaml
+++ b/helm/openwhisk/Chart.yaml
@@ -13,4 +13,4 @@ maintainers:
- name: Apache OpenWhisk committers
email: d...@openwhisk.apache.org
tillerVersion: ">=2.9.0"
-kubeVersion: "1.10 - 1.11.*"
+kubeVersion: ">=1.10.0"
diff --git a/helm/openwhisk/templates/_helpers.tpl
b/helm/openwhisk/templates/_helpers.tpl
index 6e2bfb9..6437287 100644
--- a/helm/openwhisk/templates/_helpers.tpl
+++ b/helm/openwhisk/templates/_helpers.tpl
@@ -131,5 +131,5 @@ app: {{ template "openwhisk.fullname" . }}
{{/* tlssecretname for ingress */}}
{{- define "openwhisk.tls_secret_name" -}}
-{{ .Values.whisk.ingress.tlssecretname | default "ow-ingress-tls-secret" |
quote }}
+{{ .Values.whisk.ingress.tls.secretname | default "ow-ingress-tls-secret" |
quote }}
{{- end -}}
diff --git a/helm/openwhisk/templates/install-packages-job.yaml
b/helm/openwhisk/templates/install-packages-job.yaml
index dac0960..c3ee617 100644
--- a/helm/openwhisk/templates/install-packages-job.yaml
+++ b/helm/openwhisk/templates/install-packages-job.yaml
@@ -6,6 +6,7 @@ kind: Job
metadata:
name: install-packages
labels:
+name: install-packages
{{ include "openwhisk.label_boilerplate" . | indent 4 }}
spec:
activeDeadlineSeconds: 900
@@ -13,6 +14,7 @@ spec:
metadata:
name: install-packages
labels:
+name: install-packages
{{ include "openwhisk.label_boilerplate" . | indent 8 }}
spec:
restartPolicy: Never
diff --git a/helm/openwhisk/templates/invoker-agent-pod.yaml
b/helm/openwhisk/templates/invoker-agent-pod.yaml
index 613ec0e..8643e4a 100644
--- a/helm/openwhisk/templates/invoker-agent-pod.yaml
+++ b/helm/openwhisk/templates/invoker-agent-pod.yaml
@@ -40,7 +40,7 @@ spec:
containers:
- name: {{ .Values.invoker.containerFactory.kubernetes.agent.name |
quote }}
image: "{{-
.Values.invoker.containerFactory.kubernetes.agent.imageName -}}:{{-
.Values.invoker.containerFactory.kubernetes.agent.imageTag -}}"
-imagePullPolicy: {{ .Values.invoker.imagePullPolicy | quote }}
+imagePullPolicy: {{
.Values.invoker.containerFactory.kubernetes.agent.imagePullPolicy | quote }}
securityContext:
privileged: true
ports:
diff --git a/helm/openwhisk/values.yaml b/helm/openwhisk/values.yaml
index 07ebb29..e114f29 100644
--- a/helm/openwhisk/values.yaml
+++ b/helm/openwhisk/values.yaml
@@ -28,6 +28,18 @@ whisk:
apiHostPort: 31001
apiHostProto: "https"
type: NodePort
+annotations:
+ key: value
+domain: "domain"
+tls:
+ enabled: false
+ secretenabled: false
+ createsecret: false
+ secretname: "ow-ingress-tls-secret"
+ secrettype: "type"
+ crt: "crt"
+ key: "key"
+
# Production deployments _MUST_ override these default auth values
auth:
@@ -242,11 +254,11 @@ providers:
db:
external: false
# Define the rest of these values if you are using external couchdb
instance
-# host: "10.10.10.10"
-# port: 5984
-# protocol: "http"
-# username: "admin"
-# password: "secret"
+host: "10.10.10.10"
+port: 5984
+protocol: "http"
+username: "admin"
+password: "secret"
# Alarm provider configurations
alarm:
enabled: false
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jthomas opened a new issue #1014: wskdeploy failing to read configuration file from user home directory for 386 version
jthomas opened a new issue #1014: wskdeploy failing to read configuration file
from user home directory for 386 version
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1014
The 386 release of the tool fails to retrieve the user's home directory from
the system. This causes it to expect the `wskprops` file in the current
directory rather than the user's home directory.
## example
- Run a `docker run -it ubuntu` container and retrieve the latest release
archive of the tool from the release page.
- Using a simple manifest run the 386 & amd64 versions of the tool with the
`-v` flag and check the different `CfgFile` property values.
```
root@8651a121af02:~/wskdeploy/linux/amd64# ./wskdeploy -v -m manifest.yaml
Info: deploy using deployment file []...
Info: Configuration:
> ApiHost: []
> Auth: []
> Namespace: []
> ApiVersion: []
> CfgFile: [/root/.wskprops]
> CliVersion: [latest]
> ProjectPath: [.]
> DeploymentPath: []
> ManifestPath: [manifest.yaml]
> Preview: [false]
> Strict: [false]
> Key: []
> Cert: []
> Managed: [false]
> ProjectName: []
> ApigwAccessToken: []
> Verbose: [true]
> Trace: [false]
> Sync: [false]
> Report: [false]
> Param: [[]]
> ParamFile: []
```
```
./wskdeploy -v -m ../amd64/manifest.yaml
Info: deploy using deployment file []...
Info: Configuration:
> ApiHost: []
> Auth: []
> Namespace: []
> ApiVersion: []
> CfgFile: [.wskprops]
> CliVersion: [latest]
> ProjectPath: [.]
> DeploymentPath: []
> ManifestPath: [../amd64/manifest.yaml]
> Preview: [false]
> Strict: [false]
> Key: []
> Cert: []
> Managed: [false]
> ProjectName: []
> ApigwAccessToken: []
> Verbose: [true]
> Trace: [false]
> Sync: [false]
> Report: [false]
> Param: [[]]
> ParamFile: []
```
## cause
The cause is due to `user.Current` method [not being
available](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/utils/misc.go#L65-L67)
for 386.
Here's a test file to show the issue...
```go
package main
import "fmt"
import "os"
import "os/user"
func main() {
usr, err := user.Current()
if err != nil {
fmt.Println(err)
os.Exit(1)
}
fmt.Println(usr.HomeDir)
}
```
```
# GOOS=linux GOARCH=386 go build main.go
# ./main
user: Current not implemented on linux/386
```
## solution
I've found an existing workaround in another project - that we might want to
add:
https://github.com/schachmat/ingo/blob/4b355b487cca8ac509823a2b410a1d9c79fb214c/in.go#L35-L41
```go
func fallbackHome() string {
if home := os.Getenv("HOME"); home != "" {
return home
}
// For Windows.
return os.Getenv("UserProfile")
}
```
This can be used when `user.Current()` returns an error.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah closed pull request #4138: Fix pattern for system basic tests
rabbah closed pull request #4138: Fix pattern for system basic tests URL: https://github.com/apache/incubator-openwhisk/pull/4138 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/tests/build.gradle b/tests/build.gradle index 648b112318..e427d723ba 100644 --- a/tests/build.gradle +++ b/tests/build.gradle @@ -96,7 +96,7 @@ ext.testSets = [ ], "REQUIRE_SYSTEM_BASIC" : [ "includes" : [ -"org/apache/openwhisk/testEntities/system/basic/**" +"system/basic/**" ] ] ] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4138: Fix pattern for system basic tests
codecov-io commented on issue #4138: Fix pattern for system basic tests URL: https://github.com/apache/incubator-openwhisk/pull/4138#issuecomment-442436219 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138?src=pr=h1) Report > Merging [#4138](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/a183b3e17daa18625476d31629385e130c5a01ed?src=pr=desc) will **decrease** coverage by `4.49%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4138 +/- ## = - Coverage 86.16% 81.66% -4.5% = Files 151 151 Lines7272 7272 Branches 468 468 = - Hits 6266 5939-327 - Misses 1006 1333+327 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.54%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-62.5%)` | :arrow_down: | | [...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh) | `40% <0%> (-20%)` | :arrow_down: | | [...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...che/openwhisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `73.73% <0%> (+0.5%)` | :arrow_up: | | [...enwhisk/core/loadBalancer/InvokerSupervision.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0ludm9rZXJTdXBlcnZpc2lvbi5zY2FsYQ==) | `96.55% <0%> (+0.68%)` | :arrow_up: | | [...pache/openwhisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `82.24% <0%> (+0.93%)` | :arrow_up: | | ... and [4 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4138?src=pr=footer).
[GitHub] chetanmeh commented on issue #4111: Update to Gradle 4.10.2
chetanmeh commented on issue #4111: Update to Gradle 4.10.2 URL: https://github.com/apache/incubator-openwhisk/pull/4111#issuecomment-442434003 @csantanapr Can you try again now a PG run with updated PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #4111: Update to Gradle 4.10.2
codecov-io edited a comment on issue #4111: Update to Gradle 4.10.2 URL: https://github.com/apache/incubator-openwhisk/pull/4111#issuecomment-438527889 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111?src=pr=h1) Report > Merging [#4111](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/a183b3e17daa18625476d31629385e130c5a01ed?src=pr=desc) will **decrease** coverage by `4.88%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4111 +/- ## == - Coverage 86.16% 81.28% -4.89% == Files 151 151 Lines7272 7272 Branches 468 468 == - Hits 6266 5911 -355 - Misses 1006 1361 +355 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111?src=pr=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.54%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-62.5%)` | :arrow_down: | | [...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh) | `40% <0%> (-20%)` | :arrow_down: | | [...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `59.7% <0%> (-1.5%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111?src=pr=footer). Last update [a183b3e...d53a883](https://codecov.io/gh/apache/incubator-openwhisk/pull/4111?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3246: ActionLimitsTests memory test failing
chetanmeh commented on issue #3246: ActionLimitsTests memory test failing URL: https://github.com/apache/incubator-openwhisk/issues/3246#issuecomment-442432562 @markusthoemmes This test is failing multiple times for me in my travis builds. I see this was added for #2827. From error it appears now that large array allocation failure is properly handled by Node JS runtime (may be newer version have more resiliency). Should we adapt the test case to cause true OOM is some other way? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3246: ActionLimitsTests memory test failing
chetanmeh commented on issue #3246: ActionLimitsTests memory test failing URL: https://github.com/apache/incubator-openwhisk/issues/3246#issuecomment-442431409 Yet another failure https://scans.gradle.com/s/57yozr36s3y7i/tests/xaqugzlgs2zxa-wlc37iylaskqa This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh opened a new issue #4140: ContainerProxyTests Heisenbug
chetanmeh opened a new issue #4140: ContainerProxyTests Heisenbug URL: https://github.com/apache/incubator-openwhisk/issues/4140 Seen failure in `ContainerProxyTest` at https://scans.gradle.com/s/4lb3ctstu5cqc/tests/xaqugzlgs2zxa-igyfqphtwknzs?openStackTraces=WzBd ``` java.util.NoSuchElementException: None.getClose stacktrace at scala.None$.get(Option.scala:349) at scala.None$.get(Option.scala:347) at org.apache.openwhisk.core.containerpool.test.ContainerProxyTests.$anonfun$new$11(ContainerProxyTests.scala:379) at akka.testkit.TestKitBase.poll$2(TestKit.scala:312) at akka.testkit.TestKitBase.awaitAssert(TestKit.scala:329) at akka.testkit.TestKitBase.awaitAssert$(TestKit.scala:301) at akka.testkit.TestKit.awaitAssert(TestKit.scala:896) at org.apache.openwhisk.core.containerpool.test.ContainerProxyTests.$anonfun$new$10(ContainerProxyTests.scala:366) at akka.testkit.TestKitBase.within(TestKit.scala:360) at akka.testkit.TestKitBase.within$(TestKit.scala:348) at akka.testkit.TestKit.within(TestKit.scala:896) at akka.testkit.TestKitBase.within(TestKit.scala:374) at akka.testkit.TestKitBase.within$(TestKit.scala:374) at akka.testkit.TestKit.within(TestKit.scala:896) at org.apache.openwhisk.core.containerpool.test.ContainerProxyTests.$anonfun$new$9(ContainerProxyTests.scala:340) at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85) at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83) at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104) at org.scalatest.Transformer.apply(Transformer.scala:22) at org.scalatest.Transformer.apply(Transformer.scala:20) at org.scalatest.FlatSpecLike$$anon$1.apply(FlatSpecLike.scala:1682) at org.scalatest.TestSuite.withFixture(TestSuite.scala:196) at org.scalatest.TestSuite.withFixture$(TestSuite.scala:195) at org.apache.openwhisk.core.containerpool.test.ContainerProxyTests.withFixture(ContainerProxyTests.scala:49) at org.scalatest.FlatSpecLike.invokeWithFixture$1(FlatSpecLike.scala:1680) at org.scalatest.FlatSpecLike.$anonfun$runTest$1(FlatSpecLike.scala:1692) at org.scalatest.SuperEngine.runTestImpl(Engine.scala:289) [2018-11-28T12:01:35.803Z] [INFO] [#tid_sid_testing] [ContainerProxy] [marker:invoker_collectLogs_start:194] [2018-11-28T12:01:35.804Z] [INFO] [#tid_sid_testing] [ContainerProxy] [marker:invoker_collectLogs_finish:194:0] [2018-11-28T12:01:35.808Z] [INFO] [#tid_sid_testing] [ContainerProxy] [marker:invoker_collectLogs_start:199] [2018-11-28T12:01:35.809Z] [INFO] [#tid_sid_testing] [ContainerProxy] [marker:invoker_collectLogs_finish:199:0] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #4137: Remove busy loop in case the invoker is overloaded.
rabbah commented on a change in pull request #4137: Remove busy loop in case the invoker is overloaded. URL: https://github.com/apache/incubator-openwhisk/pull/4137#discussion_r237056960 ## File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerProxy.scala ## @@ -161,7 +162,7 @@ class ContainerProxy( // cold start (no container to reuse or available stem cell container) case Event(job: Run, _) => - implicit val transid = job.msg.transid + implicit val transId: TransactionId = job.msg.transid Review comment: Small nit but we use sid and transid consistently throughout (no camel case) so I wouldn’t make this change (unless it’s done everywhere). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #4137: Remove busy loop in case the invoker is overloaded.
rabbah commented on a change in pull request #4137: Remove busy loop in case the invoker is overloaded. URL: https://github.com/apache/incubator-openwhisk/pull/4137#discussion_r237058344 ## File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala ## @@ -99,13 +99,16 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef, // their requests and send them back to the pool for rescheduling (this may happen if "docker" operations // fail for example, or a container has aged and was destroying itself when a new request was assigned) case r: Run => - // Check if the message is resent from the buffer. Only the first message on the buffer can be resent. - val isResentFromBuffer = runBuffer.nonEmpty && runBuffer.dequeueOption.exists(_._1.msg == r.msg) + // Checks if the current message is the first in the queue + val isFirstInQueue = runBuffer.dequeueOption.exists(_._1.msg == r.msg) + // A resend is only valid, if the message is the first one in the queue. Otherwise it is a result of a race condition. + val isValidResent = r.fromQueue && isFirstInQueue Review comment: I don’t understand the comment about a resend by a race. I may be miopic here as I’ve read only the comments so far. A resend (which happens when the proxy can’t schedule the message) will get queued at the back of the line. Do you mean race in the sense that the message was simply resent to the queue? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh opened a new issue #4139: ThrottleTests heisenbug
chetanmeh opened a new issue #4139: ThrottleTests heisenbug URL: https://github.com/apache/incubator-openwhisk/issues/4139 Seen failure in `limits.ThrottleTest` ``` org.scalatest.exceptions.TestFailedException : error waiting for activation 1eb40fc18d684c39b40fc18d683c3927 for 5 minutes: Cannot find activation id from 'null' Open stacktrace exitCode = 173 stderr = Too many concurrent requests in flight (count: 31, allowed: 30). exitCode = 173 stderr = Too many concurrent requests in flight (count: 33, allowed: 30). Executed 36 requests, maximum was 36, need to retry 0 (retries left: 3) 36 slow invokes (dur = 19 sec) took 2 seconds to issue Sleeping for 15 sec exitCode = 173 stderr = Too many concurrent requests in flight (count: 34, allowed: 30). exitCode = 173 stderr = Too many concurrent requests in flight (count: 34, allowed: 30). exitCode = 173 stderr = Too many concurrent requests in flight (count: 34, allowed: 30). exitCode = 173 stderr = Too many concurrent requests in flight (count: 34, allowed: 30). Executed 4 requests, maximum was 4, need to retry 0 (retries left: 3) 4 fast invokes (dur = 4 sec) took 0 seconds to issue number of throttled activations: 6 out of 40 Waiting for 44 seconds, already waited for 15 seconds clearing activations waiting for activations to complete Exception occurred during test execution: org.scalatest.exceptions.TestFailedException: error waiting for activation 1eb40fc18d684c39b40fc18d683c3927 for 5 minutes: Cannot find activation id from 'null' org.scalatest.exceptions.TestFailedException: error waiting for activation 1eb40fc18d684c39b40fc18d683c3927 for 5 minutes: Cannot find activation id from 'null' at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:528) at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:527) at org.scalatest.FlatSpec.newAssertionFailedException(FlatSpec.scala:1685) at org.scalatest.Assertions.fail(Assertions.scala:1089) at org.scalatest.Assertions.fail$(Assertions.scala:1085) ``` https://scans.gradle.com/s/m3phkzpg3v52i/tests/xaqugzlgs2zw6-6whyek7tx2eem This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #4138: Fix pattern for system basic tests
chetanmeh commented on issue #4138: Fix pattern for system basic tests URL: https://github.com/apache/incubator-openwhisk/pull/4138#issuecomment-442424574 Not sure if those tests are used downstream or not. So better to keep the current structure for tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh edited a comment on issue #4111: Update to Gradle 4.10.2
chetanmeh edited a comment on issue #4111: Update to Gradle 4.10.2 URL: https://github.com/apache/incubator-openwhisk/pull/4111#issuecomment-44242 @csantanapr mentioned that install task fails for test module with error ``` * What went wrong: Execution failed for task ':tests:install'. > Could not publish configuration 'archives' > Cannot publish artifact 'compileScala.mapping' (/Users/chetanm/git/apache/openwhisk/openwhisk/tests/build/tmp/scala/compilerAnalysis/compileScala.mapping) as it does not exist. ``` The build fails in install due to gradle/gradle#6849. There is a possible workaround ``` As a workaround, you can create a src/main/scala/ScalaForTestsWorkaround.scala with something like class ScalaForTestsWorkaround in it. ``` Now I see [Gradle 5 also released](https://docs.gradle.org/5.0/release-notes.html) on Nov 26. May be we switch to that as it shows good performance improvement (though referred bug still exist there) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #4111: Update to Gradle 4.10.2
chetanmeh commented on issue #4111: Update to Gradle 4.10.2 URL: https://github.com/apache/incubator-openwhisk/pull/4111#issuecomment-44242 The build fails in install due to gradle/gradle#6849. There is a possible workaround ``` As a workaround, you can create a src/main/scala/ScalaForTestsWorkaround.scala with something like class ScalaForTestsWorkaround in it. ``` Now I see [Gradle 5 also released](https://docs.gradle.org/5.0/release-notes.html) on Nov 26. May be we switch to that as it shows good performance improvement (though referred bug still exist there) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #4138: Fix pattern for system basic tests
rabbah commented on issue #4138: Fix pattern for system basic tests URL: https://github.com/apache/incubator-openwhisk/pull/4138#issuecomment-442422776 Should we instead move the tests? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh opened a new pull request #4138: Fix pattern for system basic tests
chetanmeh opened a new pull request #4138: Fix pattern for system basic tests URL: https://github.com/apache/incubator-openwhisk/pull/4138 As part of package rename done in #4073 the pattern for system basic tests was incorrectly set to ` "org/apache/openwhisk/testEntities/system/basic/**` instead of `system/basic/**`. As the package name for system basic test was not changed this PR reverts the change in pattern there ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel commented on a change in pull request #4137: Remove busy loop in case the invoker is overloaded.
cbickel commented on a change in pull request #4137: Remove busy loop in case the invoker is overloaded. URL: https://github.com/apache/incubator-openwhisk/pull/4137#discussion_r237028430 ## File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala ## @@ -99,13 +99,16 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef, // their requests and send them back to the pool for rescheduling (this may happen if "docker" operations // fail for example, or a container has aged and was destroying itself when a new request was assigned) case r: Run => - // Check if the message is resent from the buffer. Only the first message on the buffer can be resent. - val isResentFromBuffer = runBuffer.nonEmpty && runBuffer.dequeueOption.exists(_._1.msg == r.msg) + // Checks if the current message is the first in the queue + val isFirstInQueue = runBuffer.dequeueOption.exists(_._1.msg == r.msg) + // A resend is only valid, if the message is the first one in the queue. Otherwise it is a result of a race condition. + val isValidResent = r.fromQueue && isFirstInQueue Review comment: I also thought about this after I was finished. The only concern with this that came into my mind was, that one more message is sent for every activation. But I don't think, that this will be a bottleneck. I think it's worth this change to get the code more clear. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #4137: Remove busy loop in case the invoker is overloaded.
markusthoemmes commented on a change in pull request #4137: Remove busy loop in case the invoker is overloaded. URL: https://github.com/apache/incubator-openwhisk/pull/4137#discussion_r237025725 ## File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala ## @@ -99,13 +99,16 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef, // their requests and send them back to the pool for rescheduling (this may happen if "docker" operations // fail for example, or a container has aged and was destroying itself when a new request was assigned) case r: Run => - // Check if the message is resent from the buffer. Only the first message on the buffer can be resent. - val isResentFromBuffer = runBuffer.nonEmpty && runBuffer.dequeueOption.exists(_._1.msg == r.msg) + // Checks if the current message is the first in the queue + val isFirstInQueue = runBuffer.dequeueOption.exists(_._1.msg == r.msg) + // A resend is only valid, if the message is the first one in the queue. Otherwise it is a result of a race condition. + val isValidResent = r.fromQueue && isFirstInQueue Review comment: Since you already switched to using a `runFirstMessageOfQueue` method, can we simplify our logic towards this: 1. On getting a run message, we always append to the buffer 2. After appending, we'll run the `runFirstMessageOfQueue` method I imagine that that way, we don't need the `isFirstInQueue` and `isValidResent` checks, as that guarantees that we always send messages off of a queue. (The `Run` handler could of course optimize, and bypass the queue if it knows it's empty) WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] neeraj-laad commented on a change in pull request #372: Helm chart providers
neeraj-laad commented on a change in pull request #372: Helm chart providers URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/372#discussion_r236987858 ## File path: helm/openwhisk/values.yaml ## @@ -242,14 +254,14 @@ providers: db: external: false # Define the rest of these values if you are using external couchdb instance -# host: "10.10.10.10" -# port: 5984 -# protocol: "http" -# username: "admin" -# password: "secret" +host: "10.10.10.10" +port: 5984 +protocol: "http" +username: "admin" +password: "secret" # Alarm provider configurations alarm: -enabled: false +enabled: true Review comment: Given we are switching back to docker, and we do not have an automated way to enable them using docker container factory. I'll disable them for now.. We can review this again once #370 is merged in. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jiangpengcheng commented on issue #4135: Ensure ResultMessage is processed
jiangpengcheng commented on issue #4135: Ensure ResultMessage is processed URL: https://github.com/apache/incubator-openwhisk/pull/4135#issuecomment-442367251 yes, we don't need that promise This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] neeraj-laad commented on a change in pull request #372: Helm chart providers
neeraj-laad commented on a change in pull request #372: Helm chart providers URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/372#discussion_r236986945 ## File path: helm/openwhisk/values.yaml ## @@ -242,14 +254,14 @@ providers: db: external: false # Define the rest of these values if you are using external couchdb instance -# host: "10.10.10.10" -# port: 5984 -# protocol: "http" -# username: "admin" -# password: "secret" +host: "10.10.10.10" +port: 5984 +protocol: "http" +username: "admin" +password: "secret" # Alarm provider configurations alarm: -enabled: false +enabled: true Review comment: @csantanapr @dgrove-oss Is there a reason to have the providers switched off by default? I thought it would be much easier for users to get started if things worked out of the box. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] neeraj-laad commented on a change in pull request #372: Helm chart providers
neeraj-laad commented on a change in pull request #372: Helm chart providers URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/372#discussion_r236986070 ## File path: helm/openwhisk/values.yaml ## @@ -197,7 +209,7 @@ invoker: containerFactory: dind: false useRunc: false -impl: "docker" +impl: "kubernetes" Review comment: Ok.. switching it back to docker This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel commented on issue #4135: Ensure ResultMessage is processed
cbickel commented on issue #4135: Ensure ResultMessage is processed URL: https://github.com/apache/incubator-openwhisk/pull/4135#issuecomment-442355268 Ah wait. One more thing came into my mind. Do we still need to store the promise in the `ActivationEntry` with this change? I think it would be enough to store it in `blockingPromises`, right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4137: Remove busy loop in case the invoker is overloaded.
codecov-io commented on issue #4137: Remove busy loop in case the invoker is overloaded. URL: https://github.com/apache/incubator-openwhisk/pull/4137#issuecomment-442353920 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137?src=pr=h1) Report > Merging [#4137](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/a183b3e17daa18625476d31629385e130c5a01ed?src=pr=desc) will **decrease** coverage by `4.87%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4137 +/- ## == - Coverage 86.16% 81.29% -4.88% == Files 151 151 Lines7272 7276 +4 Branches 468 465 -3 == - Hits 6266 5915 -351 - Misses 1006 1361 +355 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/openwhisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh) | `92.85% <100%> (+0.23%)` | :arrow_up: | | [.../openwhisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.42% <100%> (ø)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.54%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-83.34%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-62.5%)` | :arrow_down: | | [...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh) | `40% <0%> (-20%)` | :arrow_down: | | [...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...whisk/connector/kafka/KafkaConsumerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYUNvbnN1bWVyQ29ubmVjdG9yLnNjYWxh) | `59.7% <0%> (-1.5%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4137?src=pr=footer). Last update
