Re: [PR] Test Spark 4.0.0-SNAPSHOT [orc]

2024-04-30 Thread via GitHub
cxzl25 commented on code in PR #1909: URL: https://github.com/apache/orc/pull/1909#discussion_r1585891903 ## java/bench/spark/src/java/org/apache/orc/bench/spark/SparkBenchmark.java: ## @@ -74,7 +74,8 @@ @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.MICROSECONDS)

Re: [PR] Test Spark 4.0.0-SNAPSHOT [orc]

2024-04-30 Thread via GitHub
dongjoon-hyun commented on code in PR #1909: URL: https://github.com/apache/orc/pull/1909#discussion_r1585891308 ## java/bench/spark/src/java/org/apache/orc/bench/spark/SparkBenchmark.java: ## @@ -74,7 +74,8 @@ @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.MICROSEC

Re: [PR] Test Spark 4.0.0-SNAPSHOT [orc]

2024-04-30 Thread via GitHub
dongjoon-hyun commented on PR #1909: URL: https://github.com/apache/orc/pull/1909#issuecomment-2087977008 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Test Spark 4.0.0-SNAPSHOT [orc]

2024-04-30 Thread via GitHub
dongjoon-hyun commented on PR #1909: URL: https://github.com/apache/orc/pull/1909#issuecomment-2086108729 Hi, @cxzl25 . Sorry for asking this, but could you rebase this PR once more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Test Spark 4.0.0-SNAPSHOT [orc]

2024-04-25 Thread via GitHub
cxzl25 commented on code in PR #1909: URL: https://github.com/apache/orc/pull/1909#discussion_r1580471014 ## java/bench/spark/pom.xml: ## @@ -171,8 +171,9 @@ META-INF/NOTICE-binary META-INF/NOTICE.md META-INF/NOTICE.

Re: [PR] Test Spark 4.0.0-SNAPSHOT [orc]

2024-04-24 Thread via GitHub
cxzl25 commented on code in PR #1909: URL: https://github.com/apache/orc/pull/1909#discussion_r1577523579 ## java/bench/spark/pom.xml: ## @@ -171,8 +171,9 @@ META-INF/NOTICE-binary META-INF/NOTICE.md META-INF/NOTICE.