[
https://issues.apache.org/jira/browse/ORC-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851989#comment-15851989
]
Sergey Shelukhin commented on ORC-141:
--
[~owen.omalley] these writers have no path, so there's no way to
[
https://issues.apache.org/jira/browse/ORC-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-141:
-
Attachment: ORC-141.patch
There's actually an issue in Hive code where some paths are protected by
[
https://issues.apache.org/jira/browse/ORC-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854593#comment-15854593
]
Sergey Shelukhin commented on ORC-141:
--
+1. Comment is not updated. I am not sure it makes sense to
[
https://issues.apache.org/jira/browse/ORC-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749216#comment-15749216
]
Sergey Shelukhin commented on ORC-119:
--
1) How is appendDataStream used? If it's just called repeatedly
[
https://issues.apache.org/jira/browse/ORC-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15750047#comment-15750047
]
Sergey Shelukhin commented on ORC-119:
--
Hmm, actually that seems to make the information about
[
https://issues.apache.org/jira/browse/ORC-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733924#comment-15733924
]
Sergey Shelukhin commented on ORC-119:
--
Response to the last comment in the jira - can you elaborate on
[
https://issues.apache.org/jira/browse/ORC-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733924#comment-15733924
]
Sergey Shelukhin edited comment on ORC-119 at 12/9/16 1:17 AM:
---
Response to the
[
https://issues.apache.org/jira/browse/ORC-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-166:
-
Attachment: ORC-166.patch
The patch. [~prasanth_j] [~owen.omalley] can you take a look?
The problem
[
https://issues.apache.org/jira/browse/ORC-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin reassigned ORC-166:
> add codec pool to ORC; make sure end is called on underlying codecs
>
[
https://issues.apache.org/jira/browse/ORC-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930690#comment-15930690
]
Sergey Shelukhin commented on ORC-166:
--
cc [~rajesh.balamohan] [~gopalv]
> add codec pool to ORC; make
[
https://issues.apache.org/jira/browse/ORC-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-165:
-
Attachment: ORC-165.patch
[~owen.omalley] [~prasanth_j] can you take a look?
> add eclipse files to
[
https://issues.apache.org/jira/browse/ORC-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930920#comment-15930920
]
Sergey Shelukhin commented on ORC-166:
--
Will do, probably next week. Side note from some testing -
[
https://issues.apache.org/jira/browse/ORC-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933598#comment-15933598
]
Sergey Shelukhin commented on ORC-166:
--
Fixed the map; the comment is actually relevant at the fields,
[
https://issues.apache.org/jira/browse/ORC-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-158:
-
Description: For example, arrayOffset() usage causes errors with direct
buffers. (was: For example,
[
https://issues.apache.org/jira/browse/ORC-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-148:
-
Priority: Blocker (was: Major)
> Move ORC PPD failure messages from WARN to DEBUG level
>
[
https://issues.apache.org/jira/browse/ORC-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900334#comment-15900334
]
Sergey Shelukhin commented on ORC-148:
--
I think logging it once per sarg (i.e. once per split?) should
[
https://issues.apache.org/jira/browse/ORC-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900379#comment-15900379
]
Sergey Shelukhin commented on ORC-148:
--
This also happens on task side... I am looking at some query
[
https://issues.apache.org/jira/browse/ORC-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900308#comment-15900308
]
Sergey Shelukhin commented on ORC-148:
--
In case of Hive, these cannot be fixed during schema
[
https://issues.apache.org/jira/browse/ORC-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112041#comment-16112041
]
Sergey Shelukhin commented on ORC-209:
--
Can you post an RB? thanks
> Add Decimal64
[
https://issues.apache.org/jira/browse/ORC-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-158:
-
Attachment: ORC-158.patch
[~prasanth_j] [~owen.omalley] can you take a look? small patch
> do not
[
https://issues.apache.org/jira/browse/ORC-197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin resolved ORC-197.
--
Resolution: Duplicate
Will fix in ORC-158
> ensureOrcFooter bug
> ---
>
>
[
https://issues.apache.org/jira/browse/ORC-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-158:
-
Description:
For example, arrayOffset() usage causes errors with direct buffers.
Another useful
[
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin reassigned ORC-243:
> incorrect isRepeating handling in decimal reader
>
[
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-243:
-
Attachment: ORC-243.patch
[~prasanth_j] [~mmccline] can you take a look? Thanks
> incorrect
[
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192446#comment-16192446
]
Sergey Shelukhin commented on ORC-243:
--
[~mmccline] the else if just below the change checks
[
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195016#comment-16195016
]
Sergey Shelukhin edited comment on ORC-243 at 10/6/17 6:43 PM:
---
Actually,
[
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195017#comment-16195017
]
Sergey Shelukhin commented on ORC-243:
--
I think this patch is still necessary, but partialReset makes
[
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin reopened ORC-243:
--
Summary after an IM discussion from my side.
1) Maintaining this contract could adversely affect perf
[
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193406#comment-16193406
]
Sergey Shelukhin commented on ORC-243:
--
Ok I'm clearly missing something here...
If isRepeating is
[
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193673#comment-16193673
]
Sergey Shelukhin commented on ORC-243:
--
This is a version from when the code was in Hive :) However, the
[
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194055#comment-16194055
]
Sergey Shelukhin edited comment on ORC-243 at 10/6/17 2:23 AM:
---
I'm not
[
https://issues.apache.org/jira/browse/ORC-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483137#comment-16483137
]
Sergey Shelukhin commented on ORC-362:
--
The problem is not indexes, it's that useless values are written
[
https://issues.apache.org/jira/browse/ORC-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514593#comment-16514593
]
Sergey Shelukhin commented on ORC-378:
--
After talking to [~t3rmin4t0r], refactored to make main path
[
https://issues.apache.org/jira/browse/ORC-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514290#comment-16514290
]
Sergey Shelukhin commented on ORC-378:
--
Some of these failures appear to be because tests examine
[
https://issues.apache.org/jira/browse/ORC-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514359#comment-16514359
]
Sergey Shelukhin commented on ORC-378:
--
Some places in the code also blindly unset isRepeating, which
[
https://issues.apache.org/jira/browse/ORC-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-378:
-
Attachment: (was: ORC-378.patch)
> translate ShortRepeat/Delta integer encoding into
[
https://issues.apache.org/jira/browse/ORC-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513250#comment-16513250
]
Sergey Shelukhin edited comment on ORC-378 at 6/15/18 2:38 AM:
---
Changed one
[
https://issues.apache.org/jira/browse/ORC-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513250#comment-16513250
]
Sergey Shelukhin edited comment on ORC-378 at 6/15/18 2:41 AM:
---
Changed one
[
https://issues.apache.org/jira/browse/ORC-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513250#comment-16513250
]
Sergey Shelukhin edited comment on ORC-378 at 6/15/18 2:35 AM:
---
Changed one
[
https://issues.apache.org/jira/browse/ORC-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-378:
-
Attachment: ORC-378.patch
> translate ShortRepeat/Delta integer encoding into isRepeating on LongCV
[
https://issues.apache.org/jira/browse/ORC-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513250#comment-16513250
]
Sergey Shelukhin commented on ORC-378:
--
Changed one method for now.
May need to change other methods;
[
https://issues.apache.org/jira/browse/ORC-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502309#comment-16502309
]
Sergey Shelukhin commented on ORC-373:
--
Hmm, I could swear LLAP IO text re-encoding was disabling
[
https://issues.apache.org/jira/browse/ORC-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin reassigned ORC-296:
> work around HADOOP-15171; also fix stream contract
>
[
https://issues.apache.org/jira/browse/ORC-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-296:
-
Attachment: ORC-296.patch
> work around HADOOP-15171; also fix stream contract
>
[
https://issues.apache.org/jira/browse/ORC-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344256#comment-16344256
]
Sergey Shelukhin commented on ORC-296:
--
[~prasanth_j] [~gopalv] can you take a look?
> work around
[
https://issues.apache.org/jira/browse/ORC-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-296:
-
Attachment: (was: ORC-296.patch)
> work around HADOOP-15171; also fix stream contract
>
[
https://issues.apache.org/jira/browse/ORC-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-296:
-
Attachment: ORC-296.01.patch
> work around HADOOP-15171; also fix stream contract
>
[
https://issues.apache.org/jira/browse/ORC-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351062#comment-16351062
]
Sergey Shelukhin commented on ORC-296:
--
Updated the patch - we need to call reset on the codec for every
[
https://issues.apache.org/jira/browse/ORC-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin resolved ORC-296.
--
Resolution: Fixed
Fix Version/s: 1.5.0
1.4.3
Committed to master. Thanks
[
https://issues.apache.org/jira/browse/ORC-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-296:
-
Attachment: ORC-296.patch
> work around HADOOP-15171; also fix stream contract
>
[
https://issues.apache.org/jira/browse/ORC-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344322#comment-16344322
]
Sergey Shelukhin commented on ORC-296:
--
[~gopalv] it's pretty rare. I think on the original workload we
[
https://issues.apache.org/jira/browse/ORC-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589474#comment-16589474
]
Sergey Shelukhin commented on ORC-378:
--
Updated the pull request, not sure why it doesn't update here.
[
https://issues.apache.org/jira/browse/ORC-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548198#comment-16548198
]
Sergey Shelukhin commented on ORC-378:
--
The change is to assume the vector is repeating and populate
[
https://issues.apache.org/jira/browse/ORC-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin reassigned ORC-310:
> better error handling for codec
> ---
>
> Key:
[
https://issues.apache.org/jira/browse/ORC-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397390#comment-16397390
]
Sergey Shelukhin commented on ORC-310:
--
This now addresses two issues.
First of all, there's issue with
[
https://issues.apache.org/jira/browse/ORC-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397390#comment-16397390
]
Sergey Shelukhin edited comment on ORC-310 at 3/13/18 6:06 PM:
---
This now
[
https://issues.apache.org/jira/browse/ORC-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400828#comment-16400828
]
Sergey Shelukhin commented on ORC-310:
--
Thnx, looks good to me.
> better error handling and lifecycle
[
https://issues.apache.org/jira/browse/ORC-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399150#comment-16399150
]
Sergey Shelukhin commented on ORC-310:
--
Updated the PR
> better error handling and lifecycle management
[
https://issues.apache.org/jira/browse/ORC-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-310:
-
Description:
When there's a failure potentially involving the codec, the codec object may be
left
[
https://issues.apache.org/jira/browse/ORC-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384169#comment-16384169
]
Sergey Shelukhin commented on ORC-310:
--
[~owen.omalley] ping?
> better error handling for codec
>
[
https://issues.apache.org/jira/browse/ORC-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated ORC-408:
-
Summary: hard limit on memory use by ORC writers (was: hard limit on
memory use by ORC writers per
[
https://issues.apache.org/jira/browse/ORC-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629304#comment-16629304
]
Sergey Shelukhin commented on ORC-408:
--
cc [~prasanth_j]
> hard limit on memory use by ORC writers per
62 matches
Mail list logo
