[
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193406#comment-16193406
]
Sergey Shelukhin commented on ORC-243:
--------------------------------------
Ok I'm clearly missing something here...
If isRepeating is supposed to be reset somewhere earlier, how does it square
with this method checking isRepeating? Also this method calls super.nextVector
that actually sets isRepeating, too. It doesn't matter if someone resets
isRepeating, super.nextVector can still set it as far as I see.
Can you elaborate how reset would help in this case, and why is this method
checking isRepeating if it should have been reset?
> incorrect isRepeating handling in decimal reader
> ------------------------------------------------
>
> Key: ORC-243
> URL: https://issues.apache.org/jira/browse/ORC-243
> Project: ORC
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Blocker
> Attachments: ORC-243.patch
>
>
> This can lead to incorrect results.
> I need to look at other readers, will do tomorrow if this looks ok in general.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
