[
https://issues.apache.org/jira/browse/PHOENIX-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731157#comment-17731157
]
Istvan Toth commented on PHOENIX-6974:
--
I'm fine with deleting them.
> Move PBaseColumn to test
>
[
https://issues.apache.org/jira/browse/PHOENIX-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731139#comment-17731139
]
Viraj Jasani commented on PHOENIX-6973:
---
[~payert] provided you with the contributor access and
[
https://issues.apache.org/jira/browse/PHOENIX-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731051#comment-17731051
]
Viraj Jasani commented on PHOENIX-6973:
---
apologies for the confusion [~payert] [~stoty]
> Add
[
https://issues.apache.org/jira/browse/PHOENIX-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731048#comment-17731048
]
Jing Yu edited comment on PHOENIX-6974 at 6/9/23 5:51 PM:
--
[~stoty] , some of
[
https://issues.apache.org/jira/browse/PHOENIX-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731048#comment-17731048
]
Jing Yu commented on PHOENIX-6974:
--
Some of its descendants are never used (even by tests). Should we
[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731047#comment-17731047
]
ASF GitHub Bot commented on PHOENIX-6962:
-
virajjasani merged PR #1619:
URL:
virajjasani merged PR #1619:
URL: https://github.com/apache/phoenix/pull/1619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731045#comment-17731045
]
ASF GitHub Bot commented on PHOENIX-6962:
-
virajjasani commented on PR #1619:
URL:
virajjasani commented on PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#issuecomment-1584936776
@shahrs87 anything from you sir before closing this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731044#comment-17731044
]
ASF GitHub Bot commented on PHOENIX-6962:
-
virajjasani commented on PR #1619:
URL:
virajjasani commented on PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#issuecomment-1584936377
Thank you @jinggou, +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
tkhurana commented on PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#issuecomment-1584929401
Thanks @jinggou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731043#comment-17731043
]
ASF GitHub Bot commented on PHOENIX-6962:
-
tkhurana commented on PR #1619:
URL:
virajjasani commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1224545944
##
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##
@@ -354,7 +354,12 @@ private List
getClientSideMaintainedIndexes(TableRef
[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731032#comment-17731032
]
ASF GitHub Bot commented on PHOENIX-6962:
-
virajjasani commented on code in PR #1619:
URL:
[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731033#comment-17731033
]
ASF GitHub Bot commented on PHOENIX-6962:
-
tkhurana commented on code in PR #1619:
URL:
tkhurana commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1224546560
##
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##
@@ -872,6 +887,12 @@ public QueryPlan getQueryPlan() {
}
}
+/**
+
[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731031#comment-17731031
]
ASF GitHub Bot commented on PHOENIX-6962:
-
virajjasani commented on code in PR #1619:
URL:
virajjasani commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1224545944
##
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##
@@ -354,7 +354,12 @@ private List
getClientSideMaintainedIndexes(TableRef
[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731030#comment-17731030
]
ASF GitHub Bot commented on PHOENIX-6962:
-
tkhurana commented on code in PR #1619:
URL:
tkhurana commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1224545078
##
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##
@@ -872,6 +887,12 @@ public QueryPlan getQueryPlan() {
}
}
+/**
+
tkhurana commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1224542740
##
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##
@@ -872,6 +887,12 @@ public QueryPlan getQueryPlan() {
}
}
+/**
+
[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731027#comment-17731027
]
ASF GitHub Bot commented on PHOENIX-6962:
-
tkhurana commented on code in PR #1619:
URL:
[
https://issues.apache.org/jira/browse/PHOENIX-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17731025#comment-17731025
]
ASF GitHub Bot commented on PHOENIX-6962:
-
tkhurana commented on code in PR #1619:
URL:
tkhurana commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1224539883
##
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##
@@ -354,7 +354,12 @@ private List
getClientSideMaintainedIndexes(TableRef tableRef)
[
https://issues.apache.org/jira/browse/PHOENIX-6910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730859#comment-17730859
]
ASF GitHub Bot commented on PHOENIX-6910:
-
stoty commented on PR #1607:
URL:
stoty commented on PR #1607:
URL: https://github.com/apache/phoenix/pull/1607#issuecomment-1584151076
I have attached local-verify-run.gz to the ticket.
It only fails on the known flakey permission ITs.
(It seems that we have tests that tend to fail on slow machines, and also
ones
27 matches
Mail list logo
