[
https://issues.apache.org/jira/browse/PHOENIX-6151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215638#comment-17215638
]
Lars Hofhansl edited comment on PHOENIX-6151 at 10/16/20, 8:20 PM:
---
[
https://issues.apache.org/jira/browse/PHOENIX-6151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215630#comment-17215630
]
Lars Hofhansl commented on PHOENIX-6151:
Looks like this *dramatically* slows down package
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208408#comment-17208408
]
Lars Hofhansl commented on PHOENIX-5712:
The ptr you get might point into a larger byte-array,
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205675#comment-17205675
]
Lars Hofhansl edited comment on PHOENIX-5712 at 10/1/20, 5:09 PM:
--
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205675#comment-17205675
]
Lars Hofhansl commented on PHOENIX-5712:
Perhaps we should break this into two jiras. (1) Fix
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205666#comment-17205666
]
Lars Hofhansl edited comment on PHOENIX-5712 at 10/1/20, 4:35 PM:
--
I
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205666#comment-17205666
]
Lars Hofhansl commented on PHOENIX-5712:
I hope I understand correctly what you are asking...
[
https://issues.apache.org/jira/browse/PHOENIX-6141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199093#comment-17199093
]
Lars Hofhansl commented on PHOENIX-6141:
Agreed that we do not want to rely on a transaction
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197241#comment-17197241
]
Lars Hofhansl commented on PHOENIX-5712:
[~yanxinyi] are you planning to work on this?
> Got
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196602#comment-17196602
]
Lars Hofhansl commented on PHOENIX-5712:
After some more brainstorming with [~yanxinyi],
[
https://issues.apache.org/jira/browse/PHOENIX-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196578#comment-17196578
]
Lars Hofhansl edited comment on PHOENIX-5923 at 9/15/20, 10:38 PM:
---
[
https://issues.apache.org/jira/browse/PHOENIX-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196578#comment-17196578
]
Lars Hofhansl commented on PHOENIX-5923:
Another part to consider is client compatibility.
[
https://issues.apache.org/jira/browse/PHOENIX-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196578#comment-17196578
]
Lars Hofhansl edited comment on PHOENIX-5923 at 9/15/20, 10:37 PM:
---
[
https://issues.apache.org/jira/browse/PHOENIX-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196577#comment-17196577
]
Lars Hofhansl commented on PHOENIX-6120:
[~giskender] and I discussed this today.
The tests
[
https://issues.apache.org/jira/browse/PHOENIX-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194610#comment-17194610
]
Lars Hofhansl commented on PHOENIX-6123:
[~sandeep.guggilam] one more scenario to add the
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194609#comment-17194609
]
Lars Hofhansl commented on PHOENIX-5712:
Yep. That sounds right.
We still have two fix two
[
https://issues.apache.org/jira/browse/PHOENIX-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194606#comment-17194606
]
Lars Hofhansl commented on PHOENIX-6120:
Interesting that none of our many index tests caught
[
https://issues.apache.org/jira/browse/PHOENIX-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193733#comment-17193733
]
Lars Hofhansl commented on PHOENIX-6089:
Great. I'll double check. Unfortunately we'll likely
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193314#comment-17193314
]
Lars Hofhansl commented on PHOENIX-5712:
-WIP works, it keeps the view index as long in the
[
https://issues.apache.org/jira/browse/PHOENIX-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193176#comment-17193176
]
Lars Hofhansl commented on PHOENIX-5171:
Tests passed (and last patch only changed nits), going
[
https://issues.apache.org/jira/browse/PHOENIX-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193168#comment-17193168
]
Lars Hofhansl commented on PHOENIX-5171:
Yep. Lemme just fix that up, so that we get it in (I
[
https://issues.apache.org/jira/browse/PHOENIX-6089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193161#comment-17193161
]
Lars Hofhansl commented on PHOENIX-6089:
[~stoty], should we wait for PHOENIX-6063, or commit
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193117#comment-17193117
]
Lars Hofhansl edited comment on PHOENIX-5712 at 9/9/20, 7:01 PM:
-
So
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193117#comment-17193117
]
Lars Hofhansl commented on PHOENIX-5712:
So what do we do here? There are at least two
[
https://issues.apache.org/jira/browse/PHOENIX-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193018#comment-17193018
]
Lars Hofhansl commented on PHOENIX-5171:
Reuploading the patch for master for a test-run.
What
[
https://issues.apache.org/jira/browse/PHOENIX-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192579#comment-17192579
]
Lars Hofhansl commented on PHOENIX-5171:
Patch looks good to me. Still applies to master (with
[
https://issues.apache.org/jira/browse/PHOENIX-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192533#comment-17192533
]
Lars Hofhansl commented on PHOENIX-5171:
Wrong data, marking as blocker.
> SkipScan
[
https://issues.apache.org/jira/browse/PHOENIX-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192531#comment-17192531
]
Lars Hofhansl commented on PHOENIX-5171:
This is not just a 5.1.x issues, no? Also a problem in
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190959#comment-17190959
]
Lars Hofhansl edited comment on PHOENIX-5712 at 9/5/20, 1:54 AM:
-
Ah
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190959#comment-17190959
]
Lars Hofhansl commented on PHOENIX-5712:
Ah crap. Forgot about 4.15. We're in a mess :)
> Got
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190952#comment-17190952
]
Lars Hofhansl commented on PHOENIX-5712:
So another option is to instead of adding
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190951#comment-17190951
]
Lars Hofhansl commented on PHOENIX-5712:
Yep. I see this:
{code}
if
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190947#comment-17190947
]
Lars Hofhansl commented on PHOENIX-5712:
BTW. What I am also not seeing is that
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190941#comment-17190941
]
Lars Hofhansl commented on PHOENIX-5712:
This one is not version compatibility issue. I do
[
https://issues.apache.org/jira/browse/PHOENIX-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190907#comment-17190907
]
Lars Hofhansl commented on PHOENIX-6067:
Skimmed through the changes. All looks reasonable.
>
[
https://issues.apache.org/jira/browse/PHOENIX-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190838#comment-17190838
]
Lars Hofhansl commented on PHOENIX-6067:
Cool. I'll apply the giant patch locally and run it
[
https://issues.apache.org/jira/browse/PHOENIX-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190808#comment-17190808
]
Lars Hofhansl edited comment on PHOENIX-6067 at 9/4/20, 4:13 PM:
-
After
[
https://issues.apache.org/jira/browse/PHOENIX-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190808#comment-17190808
]
Lars Hofhansl commented on PHOENIX-6067:
After a quick sweep there are "only" 23 issues marked
[
https://issues.apache.org/jira/browse/PHOENIX-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190801#comment-17190801
]
Lars Hofhansl commented on PHOENIX-5876:
I see this change in master as well. So did we add it
[
https://issues.apache.org/jira/browse/PHOENIX-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190790#comment-17190790
]
Lars Hofhansl commented on PHOENIX-5997:
Looks like this is in master. Marking it as such.
>
[
https://issues.apache.org/jira/browse/PHOENIX-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190788#comment-17190788
]
Lars Hofhansl commented on PHOENIX-6067:
I'm doing a quick sweep-through that list. Just
[
https://issues.apache.org/jira/browse/PHOENIX-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190783#comment-17190783
]
Lars Hofhansl commented on PHOENIX-6000:
Oops. Yes. My apologies.
> Client side DELETEs should
[
https://issues.apache.org/jira/browse/PHOENIX-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190777#comment-17190777
]
Lars Hofhansl commented on PHOENIX-6067:
BTW. Here's a Jira query for all 4.16.0 issues that
[
https://issues.apache.org/jira/browse/PHOENIX-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190519#comment-17190519
]
Lars Hofhansl commented on PHOENIX-6067:
Wow. Thanks for doing that. What do you need in terms
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190399#comment-17190399
]
Lars Hofhansl edited comment on PHOENIX-5712 at 9/3/20, 9:44 PM:
-
Test.
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190399#comment-17190399
]
Lars Hofhansl commented on PHOENIX-5712:
Test. Could someone please have a look? (I'm trying to
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189627#comment-17189627
]
Lars Hofhansl edited comment on PHOENIX-5712 at 9/2/20, 11:06 PM:
--
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189753#comment-17189753
]
Lars Hofhansl edited comment on PHOENIX-5712 at 9/2/20, 11:02 PM:
--
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189753#comment-17189753
]
Lars Hofhansl commented on PHOENIX-5712:
(Looked a bit during a meeting)
The problem is that
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189677#comment-17189677
]
Lars Hofhansl commented on PHOENIX-5712:
In fact I cannot make a test fail with setting
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189627#comment-17189627
]
Lars Hofhansl commented on PHOENIX-5712:
This is quite confusing. When I test on master that
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189567#comment-17189567
]
Lars Hofhansl commented on PHOENIX-5712:
Happens in master too. Let's start with a simple test.
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189378#comment-17189378
]
Lars Hofhansl commented on PHOENIX-5712:
[~sandeep.guggilam], another backwards compatibility
[
https://issues.apache.org/jira/browse/PHOENIX-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188096#comment-17188096
]
Lars Hofhansl commented on PHOENIX-6115:
-v2 should be good. Passes tests I ran as well as
[
https://issues.apache.org/jira/browse/PHOENIX-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188018#comment-17188018
]
Lars Hofhansl commented on PHOENIX-6116:
Turns out there are tests, but they do not expose this
[
https://issues.apache.org/jira/browse/PHOENIX-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188006#comment-17188006
]
Lars Hofhansl commented on PHOENIX-6115:
In fact I find now that deleting from a local index
[
https://issues.apache.org/jira/browse/PHOENIX-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188005#comment-17188005
]
Lars Hofhansl commented on PHOENIX-6115:
In fact I find now that deleting from a local index
[
https://issues.apache.org/jira/browse/PHOENIX-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187982#comment-17187982
]
Lars Hofhansl commented on PHOENIX-6115:
Hmm... To be effective it's a bit more complicated
[
https://issues.apache.org/jira/browse/PHOENIX-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187912#comment-17187912
]
Lars Hofhansl commented on PHOENIX-6115:
Something like this.
Need to carefully look at this
[
https://issues.apache.org/jira/browse/PHOENIX-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187906#comment-17187906
]
Lars Hofhansl commented on PHOENIX-6115:
[~kozdemir], [~chrajeshbab...@gmail.com] FYI
> Avoid
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186055#comment-17186055
]
Lars Hofhansl commented on PHOENIX-6107:
Awesome! Thanks for coming up with a better patch than
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186000#comment-17186000
]
Lars Hofhansl commented on PHOENIX-6107:
Yep. I don't think it's related.
I'm still +1 on your
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185996#comment-17185996
]
Lars Hofhansl commented on PHOENIX-6107:
Looks like build 61 failed with java.sql.SQLException:
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185976#comment-17185976
]
Lars Hofhansl commented on PHOENIX-6107:
Cool. Let's commit the rest :)
> Discuss speed up of
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185944#comment-17185944
]
Lars Hofhansl commented on PHOENIX-6107:
Why is the change to BasePermissionsIT needed?
>
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185943#comment-17185943
]
Lars Hofhansl commented on PHOENIX-6107:
Nice! And runtime is still under 2h.
Patch looks good
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185630#comment-17185630
]
Lars Hofhansl edited comment on PHOENIX-6107 at 8/27/20, 6:22 AM:
--
The
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185630#comment-17185630
]
Lars Hofhansl commented on PHOENIX-6107:
The entire suite finished in less then 2h. It's
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185593#comment-17185593
]
Lars Hofhansl commented on PHOENIX-6107:
That's a good call.
Not a fan of giant classes, but
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185587#comment-17185587
]
Lars Hofhansl edited comment on PHOENIX-6107 at 8/27/20, 4:12 AM:
--
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185587#comment-17185587
]
Lars Hofhansl commented on PHOENIX-6107:
Looks like precommit is broken... Trunk compilation
[
https://issues.apache.org/jira/browse/PHOENIX-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185452#comment-17185452
]
Lars Hofhansl commented on PHOENIX-6106:
Test only change with no loss of coverage.
Going to
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185451#comment-17185451
]
Lars Hofhansl commented on PHOENIX-6107:
Locally IntArithmeticIT finished in 4.5 minutes as
[
https://issues.apache.org/jira/browse/PHOENIX-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185441#comment-17185441
]
Lars Hofhansl edited comment on PHOENIX-6106 at 8/26/20, 7:48 PM:
--
[
https://issues.apache.org/jira/browse/PHOENIX-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185441#comment-17185441
]
Lars Hofhansl commented on PHOENIX-6106:
Just this. No loss of coverage.
> Speed up
[
https://issues.apache.org/jira/browse/PHOENIX-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185439#comment-17185439
]
Lars Hofhansl commented on PHOENIX-6107:
[~stoty], [~elserj], [~gjacoby], [~kozdemir], please
[
https://issues.apache.org/jira/browse/PHOENIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185376#comment-17185376
]
Lars Hofhansl commented on PHOENIX-6034:
Looks like the last run took just about 3 minutes.
[
https://issues.apache.org/jira/browse/PHOENIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185361#comment-17185361
]
Lars Hofhansl commented on PHOENIX-6034:
Thanks for picking this up [~an...@apache.org] (and
[
https://issues.apache.org/jira/browse/PHOENIX-6101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184165#comment-17184165
]
Lars Hofhansl commented on PHOENIX-6101:
-v2 is very slightly better.
> Avoid duplicate work
[
https://issues.apache.org/jira/browse/PHOENIX-6101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183678#comment-17183678
]
Lars Hofhansl commented on PHOENIX-6101:
[~kozdemir] please have a careful look.
> Avoid
[
https://issues.apache.org/jira/browse/PHOENIX-6097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183451#comment-17183451
]
Lars Hofhansl commented on PHOENIX-6097:
Pushed to 4.x and master to cover the PHOENIX-6090
[
https://issues.apache.org/jira/browse/PHOENIX-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183437#comment-17183437
]
Lars Hofhansl commented on PHOENIX-6094:
Hi [~stoty] , first thanks for working on this (fixing
[
https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183415#comment-17183415
]
Lars Hofhansl commented on PHOENIX-6064:
{quote}Anyone who wants to make Tephra work can show
[
https://issues.apache.org/jira/browse/PHOENIX-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182819#comment-17182819
]
Lars Hofhansl commented on PHOENIX-6090:
[~kozdemir], [~gjacoby], let me know which other
[
https://issues.apache.org/jira/browse/PHOENIX-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182814#comment-17182814
]
Lars Hofhansl edited comment on PHOENIX-6094 at 8/23/20, 6:39 PM:
--
[
https://issues.apache.org/jira/browse/PHOENIX-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182814#comment-17182814
]
Lars Hofhansl commented on PHOENIX-6094:
Pushed to master. I'll test a bit on 4.x. (with JDK 8)
[
https://issues.apache.org/jira/browse/PHOENIX-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182800#comment-17182800
]
Lars Hofhansl commented on PHOENIX-6094:
Happy to update both branches. It seems precommit does
[
https://issues.apache.org/jira/browse/PHOENIX-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182531#comment-17182531
]
Lars Hofhansl commented on PHOENIX-6094:
[~stoty], any insight into this one?
> Update jacoco
[
https://issues.apache.org/jira/browse/PHOENIX-6096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182529#comment-17182529
]
Lars Hofhansl commented on PHOENIX-6096:
There's no "I'm an idiot" reason, so I used "Invalid".
[
https://issues.apache.org/jira/browse/PHOENIX-6096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182527#comment-17182527
]
Lars Hofhansl commented on PHOENIX-6096:
Hmmm... Yes, I did run into a problem. Perhaps I was
[
https://issues.apache.org/jira/browse/PHOENIX-6096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182517#comment-17182517
]
Lars Hofhansl commented on PHOENIX-6096:
[~stoty], FYI.
Should we fix the enforcer or the
[
https://issues.apache.org/jira/browse/PHOENIX-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182437#comment-17182437
]
Lars Hofhansl commented on PHOENIX-6090:
Looks like pre-commit is broken. I have no time to
[
https://issues.apache.org/jira/browse/PHOENIX-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182419#comment-17182419
]
Lars Hofhansl commented on PHOENIX-6090:
Let's get a test run in.
I'm going to apply this to
[
https://issues.apache.org/jira/browse/PHOENIX-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182418#comment-17182418
]
Lars Hofhansl commented on PHOENIX-6094:
Just this. Please have a look.
> Update jacoco plugin
[
https://issues.apache.org/jira/browse/PHOENIX-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182238#comment-17182238
]
Lars Hofhansl commented on PHOENIX-6090:
-v4 does that. It also avoids works that is not needed
[
https://issues.apache.org/jira/browse/PHOENIX-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182190#comment-17182190
]
Lars Hofhansl edited comment on PHOENIX-6090 at 8/22/20, 1:26 AM:
--
[
https://issues.apache.org/jira/browse/PHOENIX-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182193#comment-17182193
]
Lars Hofhansl commented on PHOENIX-6090:
-v3 is the full fix.
[~kozdemir] please have a look.
[
https://issues.apache.org/jira/browse/PHOENIX-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182190#comment-17182190
]
Lars Hofhansl commented on PHOENIX-6090:
Here's what happens in this code:
{code}
//
[
https://issues.apache.org/jira/browse/PHOENIX-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182185#comment-17182185
]
Lars Hofhansl commented on PHOENIX-6090:
[~kozdemir] suggested to instead move all local
[
https://issues.apache.org/jira/browse/PHOENIX-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182136#comment-17182136
]
Lars Hofhansl commented on PHOENIX-6090:
Here's a fix for 4.x. Keeps holding the locks if
201 - 300 of 1713 matches
Mail list logo
