kadirozde merged PR #1767:
URL: https://github.com/apache/phoenix/pull/1767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ranganathg commented on PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#issuecomment-1864695870
> @ranganathg - If you keep the JSON, exceptions to the license check can be
added here: https://github.com/apache/phoenix/blob/master/pom.xml#L636
What is the right change
ranganathg commented on PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#issuecomment-1864535679
> It is not easy to read the test when the input is in a non-java file that
cannot be accessed with a shortcut or link. If the input is large then this is
acceptable but for a tiny
ranganathg commented on PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#issuecomment-1864534572
> @ranganathg - If you keep the JSON, exceptions to the license check can be
added here: https://github.com/apache/phoenix/blob/master/pom.xml#L636
This is nice. Thank you
gjacoby126 commented on PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#issuecomment-1864513749
@ranganathg - If you keep the JSON, exceptions to the license check can be
added here: https://github.com/apache/phoenix/blob/master/pom.xml#L636
--
This is an automated message
ranganathg commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1432709956
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java:
##
@@ -764,4 +768,174 @@ public void testPartialIndexPreferredOverFullIndex()
kadirozde commented on PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#issuecomment-1864419068
> I would prefer to have json data in separate json files itself. If it's
within a Java file, its not readable and IDE support to modify JSON with java
static map wouldn't be
kadirozde commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1432665955
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java:
##
@@ -764,4 +768,174 @@ public void testPartialIndexPreferredOverFullIndex()
ranganathg commented on PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#issuecomment-1864129962
> We should also add JSON specific tests to
WhereCompilerTest#testWhereInclusion().
Pushed new changes for this.
--
This is an automated message from the Apache Git Service.
ranganathg commented on PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#issuecomment-1864002932
> We can eliminate the json file and use a static map (see BaseTest) or an
array instead.
I would prefer to have json data in separate json files itself. If it's
within a Java
kadirozde commented on PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#issuecomment-1863992169
> > Haven't had a chance to look at the patch, but wanted to point out that
we have Apache License failures on this PR coming from the new JSON files.
>
> Thanks @gjacoby126 . As
ranganathg commented on PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#issuecomment-1863737286
> Haven't had a chance to look at the patch, but wanted to point out that we
have Apache License failures on this PR coming from the new JSON files.
Thanks @gjacoby126 . As per
ranganathg commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1431326736
##
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java:
##
@@ -110,6 +111,8 @@ private String getValue(PDataType type) {
ranganathg commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430371350
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java:
##
@@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()
ranganathg commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430370140
##
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java:
##
@@ -110,6 +111,8 @@ private String getValue(PDataType type) {
kadirozde commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430335984
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java:
##
@@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()
kadirozde commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430334103
##
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java:
##
@@ -110,6 +111,8 @@ private String getValue(PDataType type) {
kadirozde commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430324025
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java:
##
@@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()
kadirozde commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430324025
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java:
##
@@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()
kadirozde commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430321012
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java:
##
@@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()
kadirozde commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430318335
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java:
##
@@ -764,4 +768,180 @@ public void testPartialIndexPreferredOverFullIndex()
ranganathg opened a new pull request, #1767:
URL: https://github.com/apache/phoenix/pull/1767
[PHOENIX-7155](https://issues.apache.org/jira/browse/PHOENIX-7155)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
22 matches
Mail list logo
