adutra merged PR #2233:
URL: https://github.com/apache/polaris/pull/2233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apac
adutra commented on PR #2233:
URL: https://github.com/apache/polaris/pull/2233#issuecomment-3155214806
Hi, since this PR is generating constant rebase conflicts with other ongoing
PRs, I'm going to go ahead and merge it. I hope that's ok for everybody. 🙏
--
This is an automated message f
snazy commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2252055913
##
runtime/service/src/main/java/org/apache/polaris/service/task/TaskExecutorImpl.java:
##
@@ -52,18 +62,28 @@ public class TaskExecutorImpl implements TaskExecutor {
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251844836
##
runtime/service/src/test/java/org/apache/polaris/service/exception/ExceptionMapperTest.java:
##
@@ -48,6 +48,7 @@ public class ExceptionMapperTest {
public void te
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251844836
##
runtime/service/src/test/java/org/apache/polaris/service/exception/ExceptionMapperTest.java:
##
@@ -48,6 +48,7 @@ public class ExceptionMapperTest {
public void te
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251696582
##
runtime/service/src/test/java/org/apache/polaris/service/exception/ExceptionMapperTest.java:
##
@@ -48,6 +48,7 @@ public class ExceptionMapperTest {
public void te
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251696582
##
runtime/service/src/test/java/org/apache/polaris/service/exception/ExceptionMapperTest.java:
##
@@ -48,6 +48,7 @@ public class ExceptionMapperTest {
public void te
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251691689
##
runtime/service/src/main/java/org/apache/polaris/service/task/TaskExecutorImpl.java:
##
@@ -52,18 +62,28 @@ public class TaskExecutorImpl implements TaskExecutor {
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251115234
##
runtime/service/src/main/java/org/apache/polaris/service/config/RawFeaturesConfiguration.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251114513
##
runtime/service/src/main/java/org/apache/polaris/service/config/BehaviorChangesConfiguration.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundat
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251113794
##
runtime/service/src/main/java/org/apache/polaris/service/config/RawBehaviorChangesConfiguration.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foun
snazy commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2250723965
##
runtime/service/src/main/java/org/apache/polaris/service/task/TaskExecutorImpl.java:
##
@@ -36,13 +44,15 @@
import org.apache.polaris.service.events.AfterTaskAttempte
adutra commented on PR #2233:
URL: https://github.com/apache/polaris/pull/2233#issuecomment-3146507864
FYI: the flaky test should be fixed by #2241.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
adutra commented on PR #2233:
URL: https://github.com/apache/polaris/pull/2233#issuecomment-3146447186
> I did not check every single file 😅
I hope you didn't ! 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
adutra commented on PR #2233:
URL: https://github.com/apache/polaris/pull/2233#issuecomment-3146447024
> The failing test does not fail to me locally:
`testCreateGcpCredentialsFromStaticToken` – I am investigating.
>
> EDIT: not failing anymore 😆 🤷♂️
Failing again :-(
adutra commented on PR #2233:
URL: https://github.com/apache/polaris/pull/2233#issuecomment-3144571544
The failing test does not fail to me locally:
`testCreateGcpCredentialsFromStaticToken` – I am investigating.
--
This is an automated message from the Apache Git Service.
To respond to t
16 matches
Mail list logo
