[GitHub] sebbASF commented on issue #429: Do less aggressive subject nesting

2018-01-07 Thread GitBox
sebbASF commented on issue #429: Do less aggressive subject nesting URL: https://github.com/apache/incubator-ponymail/pull/429#issuecomment-355861618 There will only be 100 unconnected threads if the mailers are broken and don't provide Reference headers. Are there many such broken clients

[GitHub] sebbASF commented on issue #428: Initial stab at fixing #426

2018-01-07 Thread GitBox
sebbASF commented on issue #428: Initial stab at fixing #426 URL: https://github.com/apache/incubator-ponymail/pull/428#issuecomment-355861136 As per my comment on #426, there should be no padding at all. Having a maximum is a separate feature, and a sensible value will depend on th

[GitHub] Humbedooh commented on issue #429: Do less aggressive subject nesting

2018-01-07 Thread GitBox
Humbedooh commented on issue #429: Do less aggressive subject nesting URL: https://github.com/apache/incubator-ponymail/pull/429#issuecomment-355861021 That will only be true if there is no IRT or References header. It's by no means perfect, but would you prefer the alternative that we c

[GitHub] sebbASF commented on issue #429: Do less aggressive subject nesting

2018-01-07 Thread GitBox
sebbASF commented on issue #429: Do less aggressive subject nesting URL: https://github.com/apache/incubator-ponymail/pull/429#issuecomment-355860932 I don't think it makes sense to match by subject even if there is a reply prefix indicator. If there are two identical subjects, they

[GitHub] Humbedooh commented on issue #427: Bug: GUI gets threading wrong if mail happens to have same subject

2018-01-07 Thread GitBox
Humbedooh commented on issue #427: Bug: GUI gets threading wrong if mail happens to have same subject URL: https://github.com/apache/incubator-ponymail/issues/427#issuecomment-355860563 It is primarily driven by that yes - sometimes those headers are missing from replies, and we improvise

[GitHub] sebbASF commented on issue #426: Bug: GUI squashes deeply nested conversations

2018-01-07 Thread GitBox
sebbASF commented on issue #426: Bug: GUI squashes deeply nested conversations URL: https://github.com/apache/incubator-ponymail/issues/426#issuecomment-355860543 IMO the nested bodies should all have the same RH margins; only the LH margin needs to change in order to support the nesting m

[GitHub] sebbASF commented on issue #427: Bug: GUI gets threading wrong if mail happens to have same subject

2018-01-07 Thread GitBox
sebbASF commented on issue #427: Bug: GUI gets threading wrong if mail happens to have same subject URL: https://github.com/apache/incubator-ponymail/issues/427#issuecomment-355860198 Surely the nesting needs to be driven by the Reference headers instead of the subject? Looking for

[GitHub] Humbedooh opened a new pull request #429: Do less aggressive subject nesting

2018-01-07 Thread GitBox
Humbedooh opened a new pull request #429: Do less aggressive subject nesting URL: https://github.com/apache/incubator-ponymail/pull/429 This addresses #427 by only allowing sort-by-subject to happen if we can establish that an email is a reply. ---

[GitHub] Humbedooh commented on issue #427: Bug: GUI gets threading wrong if mail happens to have same subject

2018-01-07 Thread GitBox
Humbedooh commented on issue #427: Bug: GUI gets threading wrong if mail happens to have same subject URL: https://github.com/apache/incubator-ponymail/issues/427#issuecomment-355834572 The subject finders need to be less aggressive, only try to find parent via subject if 'Re:, Fwd:, AW:'

[GitHub] incubator-ponymail issue #426: Bug: GUI squashes deeply nested conversations

2018-01-07 Thread Humbedooh
Github user Humbedooh commented on the issue: https://github.com/apache/incubator-ponymail/issues/426 Suggestion: add a max_nesting var (set it to something sane, like 12) when levels go above that, remove the bs-callout and padding from the email, letting it retain the same di

[GitHub] incubator-ponymail issue #427: Bug: GUI gets threading wrong if mail happens...

2018-01-07 Thread sebbASF
GitHub user sebbASF opened an issue: https://github.com/apache/incubator-ponymail/issues/427 Bug: GUI gets threading wrong if mail happens to have same subject Two e-mail threads with the same subject: 'mod_lua and subprocess_env' [1] In the threaded and treeview modes, they

[GitHub] incubator-ponymail issue #426: Bug: GUI squashes deeply nested conversations

2018-01-07 Thread sebbASF
GitHub user sebbASF opened an issue: https://github.com/apache/incubator-ponymail/issues/426 Bug: GUI squashes deeply nested conversations Something is wrong with the layout of threaded mode. If a conversation is deeply nested (e.g. [1]), the RHS margin of the message text