[jira] [Created] (ROCKETMQ-134) the offset of message filter by tags may be not commit to broker
Jie.Tang created ROCKETMQ-134: - Summary: the offset of message filter by tags may be not commit to broker Key: ROCKETMQ-134 URL: https://issues.apache.org/jira/browse/ROCKETMQ-134 Project: Apache RocketMQ Issue Type: Bug Components: rocketmq-client Affects Versions: 4.0.0-incubating Reporter: Jie.Tang Assignee: Xiaorui Wang Priority: Trivial when different string has a same hash code.the message commit offset of filtered message may be not commit to broker. for example: 1.consumer pull message from broker, broker return status FOUND and messages filter by tags hash code 2.consumer client get the messages and than processPullResult will filter message by tags. 3.PullCallback may get a pullResult which status is FOUND but messageList is empty.(filter by tags) but only NO_MATCHED_MSG and NO_NEW_MSG will correctTagsOffset we can't commit the right with status of FOUND(for messageList is empty). Is that so? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900806#comment-15900806 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 @yilingfeng Great :+1: But let's have a new PR for that, as @vongosling commented above (if I understood it correctly)? > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900795#comment-15900795 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user yilingfeng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 Sorry, I’ve modified the unit tests. @shroman > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900752#comment-15900752 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 @vongosling I meant "If I were you, I would ..." :) Anyway, I don't see why this pr can be merged if a unit test can be easily written. I think we have to accept PRs with tests, except for the cases when they cannot be implemented. Ok, then let's close this pr? and tests can be submitted in another one. @yilingfeng I have a quick look, and here is what I think. Better name the file `MessageClientIDSetterTest.java` and have tests for `getNearlyTimeFromID()` etc. instead of implementing another method in your unit test class. > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900737#comment-15900737 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 thanks @yilingfeng . Consider this PR has been merged, we will commit your unit-test in another commit. @shroman I have a same understand as @zhouxinyu about your unit-test said :-) > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900718#comment-15900718 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user yilingfeng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 Ok,I've added a unit test. @lizhanhui @shroman > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900576#comment-15900576 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 @zhouxinyu Probably you misunderstood what I meant :) -- this PR needs unit tests. I think it's the responsibility of the person who submitted PR to create them, whenever possible, since it reflects his/her intentions. @yilingfeng Can you please add unit tests? > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ROCKETMQ-133) Support message ttl
Eason Chen created ROCKETMQ-133: --- Summary: Support message ttl Key: ROCKETMQ-133 URL: https://issues.apache.org/jira/browse/ROCKETMQ-133 Project: Apache RocketMQ Issue Type: Improvement Components: rocketmq-broker, rocketmq-store Reporter: Eason Chen Assignee: yukon we do not need the message when it is time out，delete it automatically by broker -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ROCKETMQ-132) Support request/response invoke mode like sync RPC
Eason Chen created ROCKETMQ-132: --- Summary: Support request/response invoke mode like sync RPC Key: ROCKETMQ-132 URL: https://issues.apache.org/jira/browse/ROCKETMQ-132 Project: Apache RocketMQ Issue Type: Wish Reporter: Eason Chen Assignee: vongosling Mostly business need to wait a response after send a request,just like sync RPC -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ROCKETMQ-131) Hit brief pause when delete expire file periodicity
Eason Chen created ROCKETMQ-131: --- Summary: Hit brief pause when delete expire file periodicity Key: ROCKETMQ-131 URL: https://issues.apache.org/jira/browse/ROCKETMQ-131 Project: Apache RocketMQ Issue Type: Bug Components: rocketmq-store Reporter: Eason Chen Assignee: yukon Hit brief pause when delete expire file periodicity, meanwhile producer and consumer latency will become higher than normal -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ROCKETMQ-130) Support depth control by topic level
Eason Chen created ROCKETMQ-130: --- Summary: Support depth control by topic level Key: ROCKETMQ-130 URL: https://issues.apache.org/jira/browse/ROCKETMQ-130 Project: Apache RocketMQ Issue Type: Improvement Reporter: Eason Chen Assignee: vongosling Faster producer topic will impact slower producer topic when they are in the same broker, so we need depth control to limit the faster guy. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ROCKETMQ-128) Support HA switch automatically
Eason Chen created ROCKETMQ-128: --- Summary: Support HA switch automatically Key: ROCKETMQ-128 URL: https://issues.apache.org/jira/browse/ROCKETMQ-128 Project: Apache RocketMQ Issue Type: Wish Components: rocketmq-broker Affects Versions: 4.0.0-incubating Reporter: Eason Chen Assignee: yukon Fix For: 4.1.0-incubating Ha is an very important feature in production , when server crash, how to keep continuity of business is the first job. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
