[jira] [Commented] (ROCKETMQ-213) Typo in QueueData#topicSynFlag

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108414#comment-16108414
 ] 

ASF GitHub Bot commented on ROCKETMQ-213:
-

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/124
  
if any update for this pr, we will close it~


> Typo in QueueData#topicSynFlag
> --
>
> Key: ROCKETMQ-213
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-213
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-commons
>Affects Versions: 4.0.0-incubating, 4.1.0-incubating, 4.2.0-incubating, 
> 4.3.0-incubating
> Environment: All Environments
>Reporter: binzhaomobile
>Assignee: Jixiang Jin
>Priority: Minor
>
> In class QueueData, the member  topicSynFlag should be topicSysFlag



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-214) Improvement to help client to switch balance strategy smoothly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108413#comment-16108413
 ] 

ASF GitHub Bot commented on ROCKETMQ-214:
-

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/122
  
if any update for this pr, we will close it~


> Improvement to help client to switch balance strategy smoothly
> --
>
> Key: ROCKETMQ-214
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-214
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-client
>Reporter: Jaskey Lam
>Assignee: Xiaorui Wang
>
> In current implementations, rocketmq consumer will allocate message queue in 
> client itself by fetching all clientid and all mq.
> While when user hopes to switch balance strategy,  some problem will be 
> suffered in the intermediate state before all client instance have been 
> change to the same new strategy.
> Say there are there clients with Strategy `AllocateMessageQueueAveragely`, 
> when users needs to use their own `AllocateMessageQueueStrategy`, and they 
> upgrade the client1 , and some mq will be missing to allocate or some mq 
> allocate to multiple client instances, which will result in message 
> duplication or message accumulation that fail to be consumed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-28) Transportation Layer Security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108400#comment-16108400
 ] 

ASF GitHub Bot commented on ROCKETMQ-28:


Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/118
  
LGTM


> Transportation Layer Security
> -
>
> Key: ROCKETMQ-28
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-28
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-remoting
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
> Fix For: 4.2.0-incubating
>
>
> RocketMQ delivers data in clear text for now, which requires internal network 
> environment. As use scenarios expand, end-to-end security is in bad need. 
> This issue is to introduce features making RocketMQ security for various use 
> cases and sacrificing as few as possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-224) Client log4j2 logging

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108349#comment-16108349
 ] 

ASF GitHub Bot commented on ROCKETMQ-224:
-

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/120#discussion_r130515522
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java ---
@@ -27,16 +28,19 @@
 public static final String CLIENT_LOG_ROOT = "rocketmq.client.logRoot";
 public static final String CLIENT_LOG_MAXINDEX = 
"rocketmq.client.logFileMaxIndex";
 public static final String CLIENT_LOG_LEVEL = 
"rocketmq.client.logLevel";
+
 private static Logger log;
 
-static {
-log = createLogger(LoggerName.CLIENT_LOGGER_NAME);
+public static Class logClass = null;
--- End diff --

Add logClass and its getter for test purpose only?


> Client log4j2 logging
> -
>
> Key: ROCKETMQ-224
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
> Environment: Jdk 1.7
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If 
> we using log4j2,there is no client log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-224) Client log4j2 logging

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108348#comment-16108348
 ] 

ASF GitHub Bot commented on ROCKETMQ-224:
-

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/120#discussion_r130515214
  
--- Diff: 
client/src/test/java/org/apache/rocketmq/client/log/ClientLogTest.java ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.client.log;
+
+import junit.framework.Assert;
--- End diff --

We'd better use org.junit.Assert.


> Client log4j2 logging
> -
>
> Key: ROCKETMQ-224
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
> Environment: Jdk 1.7
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If 
> we using log4j2,there is no client log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-28) Transportation Layer Security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108342#comment-16108342
 ] 

ASF GitHub Bot commented on ROCKETMQ-28:


Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/118
  

[![Coverage 
Status](https://coveralls.io/builds/12633575/badge)](https://coveralls.io/builds/12633575)

Coverage increased (+0.02%) to 38.744% when pulling 
**3cc04e2efd4005bb3ae26c9db6c3ebefb8787eba on lizhanhui:tls** into 
**118bdec96005ce695295bcf0d9082e0230e69bf7 on apache:develop**.



> Transportation Layer Security
> -
>
> Key: ROCKETMQ-28
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-28
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-remoting
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
> Fix For: 4.2.0-incubating
>
>
> RocketMQ delivers data in clear text for now, which requires internal network 
> environment. As use scenarios expand, end-to-end security is in bad need. 
> This issue is to introduce features making RocketMQ security for various use 
> cases and sacrificing as few as possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-28) Transportation Layer Security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108340#comment-16108340
 ] 

ASF GitHub Bot commented on ROCKETMQ-28:


Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/118
  

[![Coverage 
Status](https://coveralls.io/builds/12633575/badge)](https://coveralls.io/builds/12633575)

Coverage increased (+0.02%) to 38.744% when pulling 
**3cc04e2efd4005bb3ae26c9db6c3ebefb8787eba on lizhanhui:tls** into 
**118bdec96005ce695295bcf0d9082e0230e69bf7 on apache:develop**.



> Transportation Layer Security
> -
>
> Key: ROCKETMQ-28
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-28
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-remoting
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
> Fix For: 4.2.0-incubating
>
>
> RocketMQ delivers data in clear text for now, which requires internal network 
> environment. As use scenarios expand, end-to-end security is in bad need. 
> This issue is to introduce features making RocketMQ security for various use 
> cases and sacrificing as few as possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-28) Transportation Layer Security

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108341#comment-16108341
 ] 

ASF GitHub Bot commented on ROCKETMQ-28:


Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/118
  

[![Coverage 
Status](https://coveralls.io/builds/12633575/badge)](https://coveralls.io/builds/12633575)

Coverage increased (+0.02%) to 38.744% when pulling 
**3cc04e2efd4005bb3ae26c9db6c3ebefb8787eba on lizhanhui:tls** into 
**118bdec96005ce695295bcf0d9082e0230e69bf7 on apache:develop**.



> Transportation Layer Security
> -
>
> Key: ROCKETMQ-28
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-28
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-remoting
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
> Fix For: 4.2.0-incubating
>
>
> RocketMQ delivers data in clear text for now, which requires internal network 
> environment. As use scenarios expand, end-to-end security is in bad need. 
> This issue is to introduce features making RocketMQ security for various use 
> cases and sacrificing as few as possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-242) mqclient can not fetch nameSrvAddr periodly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108299#comment-16108299
 ] 

ASF GitHub Bot commented on ROCKETMQ-242:
-

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/139#discussion_r130507692
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
 ---
@@ -255,19 +255,17 @@ public void start() throws MQClientException {
 }
 
 private void startScheduledTask() {
-if (null == this.clientConfig.getNamesrvAddr()) {
--- End diff --

If name server addresses have been manually specified, why should we still 
periodically fetch name server addresses from web endpoint?


> mqclient can not fetch nameSrvAddr periodly
> ---
>
> Key: ROCKETMQ-242
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-242
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.0.0-incubating, 4.1.0-incubating
> Environment: test and production
>Reporter: Eason Chen
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> when mqclientinstance start, it getNameSrvAddr once by bellow code:
>  if (null == this.clientConfig.getNamesrvAddr()) {
> 
> this.clientConfig.setNamesrvAddr(this.mQClientAPIImpl.fetchNameServerAddr());
> }
> but in startScheduledTask()，it will not start the schedule task if 
> namesrvAddr is not null
> code=
> {code:java}
> public void start() throws MQClientException {
> synchronized (this) {
> switch (this.serviceState) {
> case CREATE_JUST:
> this.serviceState = ServiceState.START_FAILED;
> // If not specified,looking address from name server
>*{color:red} if (null == 
> this.clientConfig.getNamesrvAddr()) {
> 
> this.clientConfig.setNamesrvAddr(this.mQClientAPIImpl.fetchNameServerAddr());
> }{color}*
> // Start request-response channel
> this.mQClientAPIImpl.start();
> // Start various schedule tasks
> this.startScheduledTask();
> // Start pull service
> this.pullMessageService.start();
> // Start rebalance service
> this.rebalanceService.start();
> // Start push service
> 
> this.defaultMQProducer.getDefaultMQProducerImpl().start(false);
> log.info("the client factory [{}] start OK", 
> this.clientId);
> this.serviceState = ServiceState.RUNNING;
> break;
> case RUNNING:
> break;
> case SHUTDOWN_ALREADY:
> break;
> case START_FAILED:
> throw new MQClientException("The Factory object[" + 
> this.getClientId() + "] has been created before, and failed.", null);
> default:
> break;
> }
> }
> }
> private void startScheduledTask() {
>   *{color:red} if (null == this.clientConfig.getNamesrvAddr()) {{color}*
> this.scheduledExecutorService.scheduleAtFixedRate(new Runnable() {
> @Override
> public void run() {
> try {
> 
> MQClientInstance.this.mQClientAPIImpl.fetchNameServerAddr();
> } catch (Exception e) {
> log.error("ScheduledTask fetchNameServerAddr 
> exception", e);
> }
> }
> }, 1000 * 10, 1000 * 60 * 2, TimeUnit.MILLISECONDS);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-253) Compress RegisterBrokerBody

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108294#comment-16108294
 ] 

ASF GitHub Bot commented on ROCKETMQ-253:
-

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/140
  
@lindzh Welcome to review this PR.


> Compress RegisterBrokerBody
> ---
>
> Key: ROCKETMQ-253
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-253
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-broker, rocketmq-commons, rocketmq-namesrv
>Reporter: Zhanhui Li
>Assignee: yukon
>
> RocketMQ Brokers periodically register itself against namesrv to maintain its 
> liveness.
> In case a broker has many topics, a 10 thousand or more, two major 
> problematic issues show up:
> 1) Current serialization of RegisterBrokerBody would create a large String 
> object, which stresses GC  a lot, especially when G1 is used.
> 2) Transmission this bulk of data takes up significant portion of bandwidth.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107103#comment-16107103
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12619313/badge)](https://coveralls.io/builds/12619313)

Coverage decreased (-0.5%) to 38.602% when pulling 
**42075612f2f103c2df54475e93c8ebfb5d6de133 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107102#comment-16107102
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12619313/badge)](https://coveralls.io/builds/12619313)

Coverage decreased (-0.5%) to 38.602% when pulling 
**42075612f2f103c2df54475e93c8ebfb5d6de133 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107075#comment-16107075
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

GitHub user lindzh opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/141

[ROCKETMQ-254] fix logger appender unit test too long with mock

LoggerAppender unit test cost much time, and in some cases it may cause 
test failure,fix this case this mockito.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lindzh/incubator-rocketmq logger_appender_test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #141


commit 42075612f2f103c2df54475e93c8ebfb5d6de133
Author: lindzh 
Date:   2017-07-31T09:58:27Z

fix logger appender unit test too long with mock




> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[lindzh (JIRA)]

lindzh created ROCKETMQ-254:
---

 Summary: LoggerAppender unit test cost much time and sometimes 
test failure
 Key: ROCKETMQ-254
 URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
 Project: Apache RocketMQ
  Issue Type: Bug
  Components: rocketmq-client
Affects Versions: 4.1.0-incubating
Reporter: lindzh
Assignee: Xiaorui Wang
 Fix For: 4.2.0-incubating


LoggerAppender unit test cost much time, and in some cases it may cause test 
failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-233) Apply pull interval when pull result contains no new matched msg

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107027#comment-16107027
 ] 

ASF GitHub Bot commented on ROCKETMQ-233:
-

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/127
  
@shroman This issue is to reduce fruitless polling for consumer clients. If 
a consumer subscribes topics which ship messages no that frequent, it may stop 
for a while in a smart way before performing the next round of polling, as  may 
relieve some pressure from brokers. 


> Apply pull interval when pull result contains no new matched msg
> 
>
> Key: ROCKETMQ-233
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-233
> Project: Apache RocketMQ
>  Issue Type: Bug
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
> Fix For: 4.2.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-253) Compress RegisterBrokerBody

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106869#comment-16106869
 ] 

ASF GitHub Bot commented on ROCKETMQ-253:
-

Github user lindzh commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/140
  
Wonderfull,it's a good idea to make package smaller.


> Compress RegisterBrokerBody
> ---
>
> Key: ROCKETMQ-253
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-253
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-broker, rocketmq-commons, rocketmq-namesrv
>Reporter: Zhanhui Li
>Assignee: yukon
>
> RocketMQ Brokers periodically register itself against namesrv to maintain its 
> liveness.
> In case a broker has many topics, a 10 thousand or more, two major 
> problematic issues show up:
> 1) Current serialization of RegisterBrokerBody would create a large String 
> object, which stresses GC  a lot, especially when G1 is used.
> 2) Transmission this bulk of data takes up significant portion of bandwidth.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)