[GitHub] [royale-asjs] Harbs commented on issue #1100: Fix ArrayView not sorted numerically from string fields

2021-04-13 Thread GitBox
Harbs commented on issue #1100: URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818923555 I'm sorry. My bad. Your solution seems to be the way to go. Please create a PR for that. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [royale-asjs] Harbs commented on issue #1100: Fix ArrayView not sorted numerically from string fields

2021-04-13 Thread GitBox
Harbs commented on issue #1100: URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818596440 The reason I'm suggesting the change in `sortOn` rather than `compareNumber` is that results in many fewer coercions. -- This is an automated message from the Apache Git

[GitHub] [royale-asjs] Harbs commented on issue #1100: Fix ArrayView not sorted numerically from string fields

2021-04-13 Thread GitBox
Harbs commented on issue #1100: URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818594746 If that works, please create a PR... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [royale-asjs] Harbs commented on issue #1100: Fix ArrayView not sorted numerically from string fields

2021-04-13 Thread GitBox
Harbs commented on issue #1100: URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818594564 Don't have time to test right now, but I'd probably fix it by modifying `sortOn` like so: if (opt2 & Array.NUMERIC) {

[GitHub] [royale-asjs] Harbs commented on issue #1100: Fix ArrayView not sorted numerically from string fields

2021-04-13 Thread GitBox
Harbs commented on issue #1100: URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818491957 What does `sortOn` cross-compile to? (I don't have the time right now to check.) -- This is an automated message from the Apache Git Service. To respond to the message, please