[GitHub] [royale-compiler] greg-dove opened a new issue #198: (JX) Some member-access and dynamic-access js outputs are missing closing parenthesis

2021-11-28 Thread GitBox
greg-dove opened a new issue #198: URL: https://github.com/apache/royale-compiler/issues/198 Example: var dateDiff:int = -(d.date); //where d is a Date instance var negated:int = -(collection[0]); //where collection is mx.collections.ArrayCollection (Proxy) Similar

[GitHub] [royale-asjs] yishayw merged pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-22 Thread GitBox
yishayw merged pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] mjesteve commented on pull request #1155: jewel ThreeCheckBox - first commit

2021-11-22 Thread GitBox
mjesteve commented on pull request #1155: URL: https://github.com/apache/royale-asjs/pull/1155#issuecomment-975501258 You are right, I will change it too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [royale-asjs] Harbs commented on pull request #1155: jewel ThreeCheckBox - first commit

2021-11-22 Thread GitBox
Harbs commented on pull request #1155: URL: https://github.com/apache/royale-asjs/pull/1155#issuecomment-975499006 I'm not using Jewel and haven't tested it. After quickly reading the code, overall it looks good. The only thing that jumped out at me is I think `indeterminated` should

[GitHub] [royale-asjs] mjesteve commented on pull request #1155: jewel ThreeCheckBox - first commit

2021-11-22 Thread GitBox
mjesteve commented on pull request #1155: URL: https://github.com/apache/royale-asjs/pull/1155#issuecomment-975421954 Hi Harbs, sure, no problem, can I change it on my PR? Are you looking at it?, how do you see it?, is there anything that could be done better? Piotr was going to

[GitHub] [royale-asjs] Harbs edited a comment on pull request #1155: jewel ThreeCheckBox - first commit

2021-11-22 Thread GitBox
Harbs edited a comment on pull request #1155: URL: https://github.com/apache/royale-asjs/pull/1155#issuecomment-975413567 What do you think of changing the name to `TriStateCheckbox`? I think that's the standard name for this kind of component. -- This is an automated message from the

[GitHub] [royale-asjs] Harbs commented on pull request #1155: jewel ThreeCheckBox - first commit

2021-11-22 Thread GitBox
Harbs commented on pull request #1155: URL: https://github.com/apache/royale-asjs/pull/1155#issuecomment-975413567 What do you think of changing the name to `TriStateCheckbox`. I think that's the standard name for this kind of component. -- This is an automated message from the Apache

[GitHub] [royale-asjs] jfmherokiller commented on issue #1166: Troubles with loading some resources from asdoc (ie. https://royale.apache.org/asdoc/#!mx.core/Application)

2021-11-21 Thread GitBox
jfmherokiller commented on issue #1166: URL: https://github.com/apache/royale-asjs/issues/1166#issuecomment-974701145 I have encountered this issue as well and attempted to use firefox webdev tools to see whats up. I think I saw a json asset failing to download on the pages that only say

[GitHub] [royale-asjs] jfmherokiller commented on issue #1166: Troubles with loading some resources from asdoc (ie. https://royale.apache.org/asdoc/#!mx.core/Application)

2021-11-20 Thread GitBox
jfmherokiller commented on issue #1166: URL: https://github.com/apache/royale-asjs/issues/1166#issuecomment-974701145 I have encountered this issue as well and attempted to use firefox webdev tools to see whats up. I think I saw a json asset failing to download on the pages that only say

[GitHub] [royale-compiler] greg-dove closed issue #197: has similar issues to issue 196 in compiler-jx emitter

2021-11-18 Thread GitBox
greg-dove closed issue #197: URL: https://github.com/apache/royale-compiler/issues/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-compiler] greg-dove opened a new issue #197: has similar issues to issue 196 in compiler-jx emitter

2021-11-18 Thread GitBox
greg-dove opened a new issue #197: URL: https://github.com/apache/royale-compiler/issues/197 Outputting nodes was incorrect in MXMLDescriptor data. Similar to #196, but slightly different in one case. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [royale-compiler] greg-dove closed issue #196: stack underflow errors inside dataProvider(-like) mxml assignments.

2021-11-18 Thread GitBox
greg-dove closed issue #196: URL: https://github.com/apache/royale-compiler/issues/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-compiler] greg-dove opened a new issue #196: stack underflow errors inside dataProvider(-like) mxml assignments.

2021-11-18 Thread GitBox
greg-dove opened a new issue #196: URL: https://github.com/apache/royale-compiler/issues/196 nodes can cause stack underflow errors (swf compiler) when inside mxml 'Arrays' or can sometimes have unexpected results if there is a successful compilation. This was determined to be

[GitHub] [royale-compiler] greg-dove closed issue #195: ResourceBundles are not output correctly in some cases.

2021-11-18 Thread GitBox
greg-dove closed issue #195: URL: https://github.com/apache/royale-compiler/issues/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-compiler] greg-dove opened a new issue #195: ResouceBundles are not output correctly in some cases.

2021-11-17 Thread GitBox
greg-dove opened a new issue #195: URL: https://github.com/apache/royale-compiler/issues/195 Original flex properties files do not always output cleanly in JS (assuming String only types, not ClassReferences or Embeds). Various issues relate to the use of backslash and things like

[GitHub] [royale-asjs] GitSheedy opened a new issue #1166: Troubles with loading some resources from asdoc (ie. https://royale.apache.org/asdoc/#!mx.core/Application)

2021-11-15 Thread GitBox
GitSheedy opened a new issue #1166: URL: https://github.com/apache/royale-asjs/issues/1166 Hi, Hopefully this is the right place to log an issue with the asdoc pages/app? It appears some pages from the Royale asdoc reference do not load successfully. The only ones I've found to

[GitHub] [royale-asjs] joshtynjala closed issue #1152: ApacheCon

2021-11-15 Thread GitBox
joshtynjala closed issue #1152: URL: https://github.com/apache/royale-asjs/issues/1152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] Harbs commented on pull request #1164: XML - Copy blank attribute values.

2021-11-13 Thread GitBox
Harbs commented on pull request #1164: URL: https://github.com/apache/royale-asjs/pull/1164#issuecomment-968219668 Exactly. My use case made extensive use of `copy`, so fixing it in `copy` made a big difference. I should have done a better job on the optimization the first time

[GitHub] [royale-asjs] estanglerbm commented on pull request #1164: XML - Copy blank attribute values.

2021-11-13 Thread GitBox
estanglerbm commented on pull request #1164: URL: https://github.com/apache/royale-asjs/pull/1164#issuecomment-968175580 To be clear, you're talking about excessive memory usage because there are many empty strings (as part of parsing XML using DOMParser.parseFromString) besides

[GitHub] [royale-asjs] Harbs closed pull request #1164: XML - Copy blank attribute values.

2021-11-13 Thread GitBox
Harbs closed pull request #1164: URL: https://github.com/apache/royale-asjs/pull/1164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] Harbs commented on pull request #1164: XML - Copy blank attribute values.

2021-11-13 Thread GitBox
Harbs commented on pull request #1164: URL: https://github.com/apache/royale-asjs/pull/1164#issuecomment-968128710 Resolved in 4c4e9ee4e5f69d30b8bf25f3b236cf35aae70c4c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [royale-asjs] Harbs commented on pull request #1164: XML - Copy blank attribute values.

2021-11-13 Thread GitBox
Harbs commented on pull request #1164: URL: https://github.com/apache/royale-asjs/pull/1164#issuecomment-968095911 In fact, we're probably setting empty values in more places than we should. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [royale-asjs] Harbs commented on pull request #1164: XML - Copy blank attribute values.

2021-11-13 Thread GitBox
Harbs commented on pull request #1164: URL: https://github.com/apache/royale-asjs/pull/1164#issuecomment-968095034 This causes empty attributes to use more memory. That commit made a very big difference in memory usage of XML. The values are not being set on purpose. -- This is

[GitHub] [royale-asjs] greg-dove closed issue #1165: Emulation Timer class does not match original behaviour of the native flash version

2021-11-12 Thread GitBox
greg-dove closed issue #1165: URL: https://github.com/apache/royale-asjs/issues/1165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] greg-dove opened a new issue #1165: Emulation Timer class does not match original behaviour of the native flash version

2021-11-12 Thread GitBox
greg-dove opened a new issue #1165: URL: https://github.com/apache/royale-asjs/issues/1165 The 'timerComplete' event is sent whenever stop() is called, and the end sequence of a repeat calls 'timerComplete' before the last 'timer' event, which is the opposite order of the original flash

[GitHub] [royale-asjs] estanglerbm opened a new pull request #1164: XML - Copy blank attribute values.

2021-11-12 Thread GitBox
estanglerbm opened a new pull request #1164: URL: https://github.com/apache/royale-asjs/pull/1164 Undoing a change made by @harbs in commit 6664fb4bb5308b376ba269635a48e63ba729ba7b. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [royale-compiler] greg-dove closed issue #194: SystemManager application factory subclass is not generated in JSRoyale in specific cases

2021-11-12 Thread GitBox
greg-dove closed issue #194: URL: https://github.com/apache/royale-compiler/issues/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-compiler] greg-dove opened a new issue #194: SystemManager application factory subclass is not generated in JSRoyale in specific cases

2021-11-12 Thread GitBox
greg-dove opened a new issue #194: URL: https://github.com/apache/royale-compiler/issues/194 The {ApplicationName}_mx_managers_SystemManager.js is not being generated for a any application that is not a direct subclass of mx.core.Application (it would be the same result with spark

[GitHub] [royale-asjs] Harbs commented on issue #1163: trace no longer stripped out

2021-11-07 Thread GitBox
Harbs commented on issue #1163: URL: https://github.com/apache/royale-asjs/issues/1163#issuecomment-962894426 I don't understand why `@nocollapse` is being added to methods at all. My understanding was that it's needed in some cases for accessors, but it seems like methods should be

[GitHub] [royale-asjs] Harbs commented on issue #1163: trace no longer stripped out

2021-11-07 Thread GitBox
Harbs commented on issue #1163: URL: https://github.com/apache/royale-asjs/issues/1163#issuecomment-962885866 It seems like it is the `@nocollapse` being inserted that's causing the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [royale-asjs] Harbs opened a new issue #1163: trace no longer stripped out

2021-11-07 Thread GitBox
Harbs opened a new issue #1163: URL: https://github.com/apache/royale-asjs/issues/1163 Here is a very simple app which uses trace. ``` http://ns.adobe.com/mxml/2009; xmlns:js="library://ns.apache.org/royale/basic"

[GitHub] [royale-compiler] greg-dove closed issue #193: @royalesuppressexport stopped working

2021-11-07 Thread GitBox
greg-dove closed issue #193: URL: https://github.com/apache/royale-compiler/issues/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] brianraymes commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons

2021-11-03 Thread GitBox
brianraymes commented on pull request #1147: URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-958586593 > @brianraymes Are you still planning on making changes to this PR? Yes! I will test out the other mouse event soon and update. Thank you for the reminder. ;-)

[GitHub] [royale-asjs] brianraymes commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons

2021-11-03 Thread GitBox
brianraymes commented on pull request #1147: URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-958586593 > @brianraymes Are you still planning on making changes to this PR? Yes! I will test out the other mouse event soon and update. Thank you for the reminder. ;-)

[GitHub] [royale-asjs] brianraymes commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons

2021-11-02 Thread GitBox
brianraymes commented on pull request #1147: URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-958586593 > @brianraymes Are you still planning on making changes to this PR? Yes! I will test out the other mouse event soon and update. Thank you for the reminder. ;-)

[GitHub] [royale-asjs] Harbs commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons

2021-11-02 Thread GitBox
Harbs commented on pull request #1147: URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-957142941 @brianraymes Are you still planning on making changes to this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [royale-asjs] yishayw commented on pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
yishayw commented on pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#issuecomment-957412875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [royale-asjs] estanglerbm commented on pull request #1135: Spark dynamic container layout

2021-11-02 Thread GitBox
estanglerbm commented on pull request #1135: URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-957112457 Merged develop, except the parts not needed on spark-dynamic-layout. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [royale-asjs] estanglerbm commented on a change in pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
estanglerbm commented on a change in pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#discussion_r740996972 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/core/UITextFormat.as ## @@ -587,8 +587,8 @@ public class UITextFormat extends

[GitHub] [royale-asjs] estanglerbm commented on pull request #1148: Uncomment skin states in Spark SkinnableContainerBase.

2021-11-02 Thread GitBox
estanglerbm commented on pull request #1148: URL: https://github.com/apache/royale-asjs/pull/1148#issuecomment-957059807 Is there something that is delaying getting these two line changes merged? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [royale-asjs] estanglerbm commented on pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
estanglerbm commented on pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#issuecomment-957429389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [royale-asjs] Harbs commented on pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
Harbs commented on pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#issuecomment-957148167 This Pr has been open a long time. I don't use MX classes. Should this be merged? Is it still needed? -- This is an automated message from the Apache Git Service. To

[GitHub] [royale-asjs] Harbs merged pull request #1148: Uncomment skin states in Spark SkinnableContainerBase.

2021-11-02 Thread GitBox
Harbs merged pull request #1148: URL: https://github.com/apache/royale-asjs/pull/1148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] yishayw commented on a change in pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
yishayw commented on a change in pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#discussion_r740980677 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/core/UITextFormat.as ## @@ -587,8 +587,8 @@ public class UITextFormat extends

[GitHub] [royale-asjs] Harbs closed issue #1131: Compile not catching missing states in skin MXML

2021-11-02 Thread GitBox
Harbs closed issue #1131: URL: https://github.com/apache/royale-asjs/issues/1131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] Harbs commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons

2021-11-02 Thread GitBox
Harbs commented on pull request #1147: URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-957142941 @brianraymes Are you still planning on making changes to this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [royale-asjs] yishayw commented on pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
yishayw commented on pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#issuecomment-957412875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [royale-asjs] estanglerbm commented on a change in pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
estanglerbm commented on a change in pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#discussion_r740996972 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/core/UITextFormat.as ## @@ -587,8 +587,8 @@ public class UITextFormat extends

[GitHub] [royale-asjs] estanglerbm commented on pull request #1148: Uncomment skin states in Spark SkinnableContainerBase.

2021-11-02 Thread GitBox
estanglerbm commented on pull request #1148: URL: https://github.com/apache/royale-asjs/pull/1148#issuecomment-957059807 Is there something that is delaying getting these two line changes merged? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [royale-asjs] estanglerbm commented on pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
estanglerbm commented on pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#issuecomment-957429389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [royale-asjs] Harbs commented on pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
Harbs commented on pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#issuecomment-957148167 This Pr has been open a long time. I don't use MX classes. Should this be merged? Is it still needed? -- This is an automated message from the Apache Git Service. To

[GitHub] [royale-asjs] Harbs merged pull request #1148: Uncomment skin states in Spark SkinnableContainerBase.

2021-11-02 Thread GitBox
Harbs merged pull request #1148: URL: https://github.com/apache/royale-asjs/pull/1148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] yishayw commented on a change in pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
yishayw commented on a change in pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#discussion_r740980677 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/core/UITextFormat.as ## @@ -587,8 +587,8 @@ public class UITextFormat extends

[GitHub] [royale-asjs] estanglerbm commented on pull request #1135: Spark dynamic container layout

2021-11-02 Thread GitBox
estanglerbm commented on pull request #1135: URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-957112457 Merged develop, except the parts not needed on spark-dynamic-layout. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [royale-asjs] Harbs closed issue #1131: Compile not catching missing states in skin MXML

2021-11-02 Thread GitBox
Harbs closed issue #1131: URL: https://github.com/apache/royale-asjs/issues/1131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] estanglerbm commented on pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
estanglerbm commented on pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#issuecomment-957806547 UITextField is in ADG, and it's used by SWF UITextFormat, and other uses. But actually, UITextFormat is the issue, not UITextField. UITextFormat (which has

[GitHub] [royale-asjs] yishayw commented on pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
yishayw commented on pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#issuecomment-957439298 > UITextField is way more widespread in MXRoyale than just charts. So I probably don't understand correctly... Where else is it constructed other than in AxisRenderer

[GitHub] [royale-asjs] estanglerbm commented on pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
estanglerbm commented on pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#issuecomment-957429389 UITextField is way more widespread in MXRoyale than just charts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [royale-asjs] estanglerbm commented on a change in pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
estanglerbm commented on a change in pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#discussion_r740996972 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/core/UITextFormat.as ## @@ -587,8 +587,8 @@ public class UITextFormat extends

[GitHub] [royale-asjs] yishayw commented on pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
yishayw commented on pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#issuecomment-957412875 If I understand correctly UITextFormat is used primarily by UITextField, which from a brief look is only used in charts in mx.charts.AxisRenderer. Generally speaking it

[GitHub] [royale-asjs] yishayw commented on a change in pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
yishayw commented on a change in pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#discussion_r740980677 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/core/UITextFormat.as ## @@ -587,8 +587,8 @@ public class UITextFormat extends

[GitHub] [royale-asjs] Harbs commented on pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-02 Thread GitBox
Harbs commented on pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034#issuecomment-957148167 This Pr has been open a long time. I don't use MX classes. Should this be merged? Is it still needed? -- This is an automated message from the Apache Git Service. To

[GitHub] [royale-asjs] Harbs commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons

2021-11-02 Thread GitBox
Harbs commented on pull request #1147: URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-957142941 @brianraymes Are you still planning on making changes to this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [royale-asjs] Harbs closed issue #1131: Compile not catching missing states in skin MXML

2021-11-02 Thread GitBox
Harbs closed issue #1131: URL: https://github.com/apache/royale-asjs/issues/1131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] Harbs merged pull request #1148: Uncomment skin states in Spark SkinnableContainerBase.

2021-11-02 Thread GitBox
Harbs merged pull request #1148: URL: https://github.com/apache/royale-asjs/pull/1148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] estanglerbm commented on pull request #1135: Spark dynamic container layout

2021-11-01 Thread GitBox
estanglerbm commented on pull request #1135: URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-957112457 Merged develop, except the parts not needed on spark-dynamic-layout. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [royale-asjs] estanglerbm commented on pull request #1148: Uncomment skin states in Spark SkinnableContainerBase.

2021-11-01 Thread GitBox
estanglerbm commented on pull request #1148: URL: https://github.com/apache/royale-asjs/pull/1148#issuecomment-957059807 Is there something that is delaying getting these two line changes merged? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [royale-asjs] yishayw closed issue #1019: Spark - padding causes an offset in SkinnableContainer (Group is OK)

2021-11-01 Thread GitBox
yishayw closed issue #1019: URL: https://github.com/apache/royale-asjs/issues/1019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] yishayw closed issue #1021: Emulation - Setting percentHeight prevents layout from happening on resize

2021-11-01 Thread GitBox
yishayw closed issue #1021: URL: https://github.com/apache/royale-asjs/issues/1021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-compiler] greg-dove opened a new issue #193: @royalesuppressexport stopped working

2021-10-31 Thread GitBox
greg-dove opened a new issue #193: URL: https://github.com/apache/royale-compiler/issues/193 @royalesuppressexport has stopped working since changes to how/when 'export related' code is generated. Whether the legacy approach via doc-comments can be maintained or not is uncertain. This

[GitHub] [royale-asjs] yishayw commented on a change in pull request #1135: Spark dynamic container layout

2021-10-31 Thread GitBox
yishayw commented on a change in pull request #1135: URL: https://github.com/apache/royale-asjs/pull/1135#discussion_r739856757 ## File path: frameworks/projects/SparkRoyale/src/main/royale/spark/components/SkinnableContainer.as ## @@ -991,9 +973,7 @@ public class

[GitHub] [royale-asjs] estanglerbm opened a new issue #1162: Two-way bind @ syntax breaks one-way bind

2021-10-31 Thread GitBox
estanglerbm opened a new issue #1162: URL: https://github.com/apache/royale-asjs/issues/1162 Perhaps two-way bind @ syntax (i.e. value="@{myprop}") is not supported yet, but it doesn't even work for one-way binding; it won't update at all when the source changes. (Broken in JS and SWF,

[GitHub] [royale-asjs] estanglerbm opened a new issue #1161: Initial value of bind of two-way bind of a bind is wrong in JS

2021-10-31 Thread GitBox
estanglerbm opened a new issue #1161: URL: https://github.com/apache/royale-asjs/issues/1161 In the attached example, the initial value next to "Text:" is "XX" when it should be "X:falseX", in JS. Works fine in SWF and Flex. No exception in JS. The issue only happens when "A" /

[GitHub] [royale-asjs] estanglerbm opened a new issue #1160: Two-way bind of Label.text has recursion issue on JS, wrong results on SWF

2021-10-31 Thread GitBox
estanglerbm opened a new issue #1160: URL: https://github.com/apache/royale-asjs/issues/1160 Two-way bind of (MX, and presumably Spark) Label.text has correct results (matches behavior under Flex), but gets this error on JS: ```Uncaught InternalError: too much recursion``` On

[GitHub] [royale-asjs] estanglerbm opened a new issue #1159: fx:Binding of variables (non-property) throws exception

2021-10-31 Thread GitBox
estanglerbm opened a new issue #1159: URL: https://github.com/apache/royale-asjs/issues/1159 Using variables (non-property) in fx:Binding causes exception on JS side. (SWF is fine, and compiling in Flex is fine.) It looks like properties and functions and xml and other things are

[GitHub] [royale-asjs] estanglerbm opened a new issue #1158: Text is blank when bind value = false

2021-10-31 Thread GitBox
estanglerbm opened a new issue #1158: URL: https://github.com/apache/royale-asjs/issues/1158 If a text is composed of just a bind value, and that bind value is false, then the text is blank on the JS side. (SWF side is fine.) See attached example (the label id="A" has the bug):

[GitHub] [royale-compiler] greg-dove closed issue #192: NullPointerException in JSEmitter.emitAssignmentCoercion

2021-10-30 Thread GitBox
greg-dove closed issue #192: URL: https://github.com/apache/royale-compiler/issues/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-compiler] greg-dove opened a new issue #192: NullPointerException in JSEmitter.emitAssignmentCoercion

2021-10-30 Thread GitBox
greg-dove opened a new issue #192: URL: https://github.com/apache/royale-compiler/issues/192 For the following example code, ``` var array:Array = [{something:[99]}]; var idx:Number = 0; var test:Number;

[GitHub] [royale-asjs] MuhammadTayyeb commented on issue #1112: mx:DateField Year Selection Not Working

2021-10-27 Thread GitBox
MuhammadTayyeb commented on issue #1112: URL: https://github.com/apache/royale-asjs/issues/1112#issuecomment-952725075 Hi you need do changes in SDK. i added year option in Exist DateField View if you need code i will provide you

[GitHub] [royale-asjs] Bilbosax opened a new issue #1157: DropDownList Colors for the List That Displays

2021-10-25 Thread GitBox
Bilbosax opened a new issue #1157: URL: https://github.com/apache/royale-asjs/issues/1157 How do you change the background and text colors of the List that displays once you click on a DropDownList? I have searched all of the code for the color that is currently displaying which is

[GitHub] [royale-asjs] greg-dove merged pull request #1126: Add support for function instances to getQualifiedClassName().

2021-10-24 Thread GitBox
greg-dove merged pull request #1126: URL: https://github.com/apache/royale-asjs/pull/1126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] estanglerbm commented on pull request #1126: Add support for function instances to getQualifiedClassName().

2021-10-24 Thread GitBox
estanglerbm commented on pull request #1126: URL: https://github.com/apache/royale-asjs/pull/1126#issuecomment-950276758 Either way is fine with me; I just wanted to make sure the decision ("." or "::") was made deliberately. It might be good to document the difference ("." in Royale

[GitHub] [royale-asjs] estanglerbm edited a comment on pull request #1126: Add support for function instances to getQualifiedClassName().

2021-10-24 Thread GitBox
estanglerbm edited a comment on pull request #1126: URL: https://github.com/apache/royale-asjs/pull/1126#issuecomment-946343078 No rush. By @greg-dove: Thanks. In terms of Function 'class' vs. function instance (or other Class), I had wondered if maybe Function needs to be

[GitHub] [royale-asjs] greg-dove commented on pull request #1126: Add support for function instances to getQualifiedClassName().

2021-10-23 Thread GitBox
greg-dove commented on pull request #1126: URL: https://github.com/apache/royale-asjs/pull/1126#issuecomment-950256697 I should be in a position to merge this tomorrow, but I also have changes to make subsequent to yours. The subsequent changes will remove the '::' from the qualified name

[GitHub] [royale-asjs] yishayw commented on pull request #1135: Spark dynamic container layout

2021-10-19 Thread GitBox
yishayw commented on pull request #1135: URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-946574778 Cool. As I said I’m really eager to have this merged because I know how problematic layout in emulation currently is. I just want to make sure we choose the most robust

[GitHub] [royale-asjs] estanglerbm commented on pull request #1135: Spark dynamic container layout

2021-10-19 Thread GitBox
estanglerbm commented on pull request #1135: URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-946495696 @yishayw I went through the bugs to examine them real quick... some of them are actually working on develop, and another is not. There are some things that ChildResize

[GitHub] [royale-asjs] estanglerbm commented on issue #1019: Spark - padding causes an offset in SkinnableContainer (Group is OK)

2021-10-19 Thread GitBox
estanglerbm commented on issue #1019: URL: https://github.com/apache/royale-asjs/issues/1019#issuecomment-946493929 @yishayw Just FYI: Not working in develop. Working in ChildResize because it has commit b34b163ce216b77fcd3da86e07ee7d6927686826, which you reverted on develop due to

[GitHub] [royale-asjs] estanglerbm commented on issue #994: Height 100% - Child Resize Inconsistent Behavior

2021-10-19 Thread GitBox
estanglerbm commented on issue #994: URL: https://github.com/apache/royale-asjs/issues/994#issuecomment-946487729 Works in develop, already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [royale-asjs] estanglerbm commented on issue #937: Skin Not Being Sized Correctly

2021-10-19 Thread GitBox
estanglerbm commented on issue #937: URL: https://github.com/apache/royale-asjs/issues/937#issuecomment-946484776 Actually, already works in develop. (PR #1135 changes the implementation, though, to try to make things better in other situations, too.) -- This is an automated

[GitHub] [royale-asjs] Harbs commented on pull request #1149: Fix preserving spaces in MX System.setClipboard().

2021-10-18 Thread GitBox
Harbs commented on pull request #1149: URL: https://github.com/apache/royale-asjs/pull/1149#issuecomment-946383861 A bit tricky to get it merged, but I managed. ;) Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [royale-asjs] Harbs merged pull request #1149: Fix preserving spaces in MX System.setClipboard().

2021-10-18 Thread GitBox
Harbs merged pull request #1149: URL: https://github.com/apache/royale-asjs/pull/1149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] estanglerbm edited a comment on pull request #1126: Add support for function instances to getQualifiedClassName().

2021-10-18 Thread GitBox
estanglerbm edited a comment on pull request #1126: URL: https://github.com/apache/royale-asjs/pull/1126#issuecomment-946343078 No rush. Thanks. In terms of Function 'class' vs. function instance (or other Class), I had wondered if maybe Function needs to be added to ExtraData as

[GitHub] [royale-asjs] estanglerbm commented on pull request #1126: Add support for function instances to getQualifiedClassName().

2021-10-18 Thread GitBox
estanglerbm commented on pull request #1126: URL: https://github.com/apache/royale-asjs/pull/1126#issuecomment-946343078 No rush. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [royale-asjs] greg-dove commented on pull request #1126: Add support for function instances to getQualifiedClassName().

2021-10-18 Thread GitBox
greg-dove commented on pull request #1126: URL: https://github.com/apache/royale-asjs/pull/1126#issuecomment-946342048 Are you ok if I look into this over the coming weekend? I'm going to struggle to look at it before then, I'm afraid. -- This is an automated message from the Apache

[GitHub] [royale-asjs] greg-dove commented on pull request #1126: Add support for function instances to getQualifiedClassName().

2021-10-18 Thread GitBox
greg-dove commented on pull request #1126: URL: https://github.com/apache/royale-asjs/pull/1126#issuecomment-946340185 > Any thoughts? For the '::', you are correct, this was simply a decision to align things between js and swf in the reflection library. The delimiter between

[GitHub] [royale-asjs] estanglerbm commented on pull request #1126: Add support for function instances to getQualifiedClassName().

2021-10-18 Thread GitBox
estanglerbm commented on pull request #1126: URL: https://github.com/apache/royale-asjs/pull/1126#issuecomment-946327373 Any thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [royale-asjs] estanglerbm commented on pull request #1149: Fix preserving spaces in MX System.setClipboard().

2021-10-18 Thread GitBox
estanglerbm commented on pull request #1149: URL: https://github.com/apache/royale-asjs/pull/1149#issuecomment-946326250 Merged latest back into this branch, and confirmed the changes, but GitHub erroneously saying there are unresolved conflicts. -- This is an automated message from the

[GitHub] [royale-asjs] estanglerbm commented on pull request #1148: Uncomment skin states in Spark SkinnableContainerBase.

2021-10-18 Thread GitBox
estanglerbm commented on pull request #1148: URL: https://github.com/apache/royale-asjs/pull/1148#issuecomment-946312912 Could someone merge this so we can close out #1131? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [royale-asjs] estanglerbm commented on pull request #1135: Spark dynamic container layout

2021-10-18 Thread GitBox
estanglerbm commented on pull request #1135: URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-946284656 @yishayw Well, I haven't had time to review exactly what's in ChildResize, but there were a lot more fundamental layout problems in SparkRoyale / MXRoyale than just

[GitHub] [royale-asjs] yishayw commented on pull request #1135: Spark dynamic container layout

2021-10-18 Thread GitBox
yishayw commented on pull request #1135: URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-945702474 @estanglerbm , I would very much like to merge this PR, or ChildResize into dev so it's there for version 0.9.9. All the bugs referenced above are working both for this PR

<    1   2   3   4   5   6   7   8   9   10   >