[jira] [Commented] (SENTRY-1477) Sentry clients should retry with another server when they get connection errors
[
https://issues.apache.org/jira/browse/SENTRY-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576359#comment-15576359
]
Hadoop QA commented on SENTRY-1477:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12833431/SENTRY-1477.1-sentry-ha-redesign.patch
against sentry-ha-redesign.
{color:red}Overall:{color} -1 due to 2 errors
{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestConcurrentClients
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/2071/console
This message is automatically generated.
> Sentry clients should retry with another server when they get connection
> errors
> ---
>
> Key: SENTRY-1477
> URL: https://issues.apache.org/jira/browse/SENTRY-1477
> Project: Sentry
> Issue Type: Sub-task
> Components: Core
>Affects Versions: sentry-ha-redesign
>Reporter: Alexander Kolbasov
>Assignee: Li Li
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1477.0-sentry-ha-redesign.patch,
> SENTRY-1477.1-sentry-ha-redesign.patch
>
>
> When Sentry clients get a connection error when talking to a server they
> should re-try connection with another server. This should be normal client
> behavior when one of the servers goes down.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-1422) JDO deadlocks while processing grant while a background thread processes Notificationlogs
[
https://issues.apache.org/jira/browse/SENTRY-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574657#comment-15574657
]
Hadoop QA commented on SENTRY-1422:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12833301/SENTRY-1422.012-sentry-ha-redesign.patch
against sentry-ha-redesign.
{color:red}Overall:{color} -1 due to 3 errors
{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestConcurrentClients
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestConcurrentClients
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/2069/console
This message is automatically generated.
> JDO deadlocks while processing grant while a background thread processes
> Notificationlogs
> -
>
> Key: SENTRY-1422
> URL: https://issues.apache.org/jira/browse/SENTRY-1422
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
>Reporter: Sravya Tirukkovalur
>Assignee: Colin Ma
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1422.008-sentry-ha-redesign.patch,
> SENTRY-1422.009-sentry-ha-redesign.patch,
> SENTRY-1422.010-sentry-ha-redesign.patch,
> SENTRY-1422.011-sentry-ha-redesign.patch,
> SENTRY-1422.012-sentry-ha-redesign.patch, sentry_deadlock.png,
> testDeadLock.patch
>
>
> As I was working on Sentry-1321. I see that test case
> TestDbPrivilegeCleanupOnDrop#testDropObjects fails while "Granting select on
> table" with following deadlock.
> {code}
> java.sql.SQLException: Error while processing statement: FAILED: Execution
> Error, return code 1 from
> org.apache.hadoop.hive.ql.exec.SentryGrantRevokeTask. Unknown error for
> request: TAlterSentryRoleGrantPrivilegeRequest(protocol_version:2,
> requestorUserName:admin1, roleName:select_tbl1,
> privileges:[TSentryPrivilege(privilegeScope:TABLE, serverName:server1,
> dbName:db_2, tableName:tb_1, URI:, action:select, createTime:1469562185573,
> grantOption:FALSE, columnName:)]), message: Iteration request failed : SELECT
> 'org.apache.sentry.provider.db.service.model.MSentryPrivilege' AS
> NUCLEUS_TYPE,A1.URI,A1."ACTION",A1."COLUMN_NAME",A1.CREATE_TIME,A1.DB_NAME,A1.WITH_GRANT_OPTION,A1.PRIVILEGE_SCOPE,A1."SERVER_NAME",A1."TABLE_NAME",A1.DB_PRIVILEGE_ID
> FROM SENTRY_ROLE_DB_PRIVILEGE_MAP A0 INNER JOIN SENTRY_DB_PRIVILEGE A1 ON
> A0.DB_PRIVILEGE_ID = A1.DB_PRIVILEGE_ID WHERE A0.ROLE_ID = ?. Server
> Stacktrace: javax.jdo.JDODataStoreException: Iteration request failed :
> SELECT 'org.apache.sentry.provider.db.service.model.MSentryPrivilege' AS
> NUCLEUS_TYPE,A1.URI,A1."ACTION",A1."COLUMN_NAME",A1.CREATE_TIME,A1.DB_NAME,A1.WITH_GRANT_OPTION,A1.PRIVILEGE_SCOPE,A1."SERVER_NAME",A1."TABLE_NAME",A1.DB_PRIVILEGE_ID
> FROM SENTRY_ROLE_DB_PRIVILEGE_MAP A0 INNER JOIN SENTRY_DB_PRIVILEGE A1 ON
> A0.DB_PRIVILEGE_ID = A1.DB_PRIVILEGE_ID WHERE A0.ROLE_ID = ?
> at
> org.datanucleus.api.jdo.NucleusJDOHelper.getJDOExceptionForNucleusException(NucleusJDOHelper.java:451)
> at
> org.datanucleus.api.jdo.JDOTransaction.commit(JDOTransaction.java:165)
> at
> org.apache.sentry.provider.db.service.persistent.SentryStore.commitTransaction(SentryStore.java:279)
> at
> org.apache.sentry.provider.db.service.persistent.SentryStore.commitUpdateTransaction(SentryStore.java:261)
> at
> org.apache.sentry.provider.db.service.persistent.SentryStore.alterSentryRoleGrantPrivileges(SentryStore.java:458)
> at
> org.apache.sentry.provider.db.service.thrift.SentryPolicyStoreProcessor.alter_sentry_role_grant_privilege(SentryPolicyStoreProcessor.java:261)
> at
> org.apache.sentry.provider.db.service.thrift.SentryPolicyService$Processor$alter_sentry_role_grant_privilege.getResult(SentryPolicyService.java:1237)
> at
> org.apache.sentry.provider.db.service.thrift.SentryPolicyService$Processor$alter_sentry_role_grant_privilege.getResult(SentryPolicyService.java:1222)
> at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39)
> at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39)
> at
> org.apache.sentry.provider.db.service.thrift.SentryProcessorWrapper.process(SentryProcessorWrapper.java:35)
> at
> org.apache.thrift.TMultiplexedProcessor.process(TMultiplexedProcessor.java:123)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:286)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> NestedThrowablesStackTrace:
>
[jira] [Assigned] (SENTRY-1503) Remove all sequence ID checks from TestSentryStore
[ https://issues.apache.org/jira/browse/SENTRY-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kolbasov reassigned SENTRY-1503: -- Assignee: Alexander Kolbasov > Remove all sequence ID checks from TestSentryStore > -- > > Key: SENTRY-1503 > URL: https://issues.apache.org/jira/browse/SENTRY-1503 > Project: Sentry > Issue Type: Test > Components: Sentry >Affects Versions: 1.7.0, sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Alexander Kolbasov > Attachments: SENTRY-1503.0.patch > > > TestSentryStore shouldn't assert or otherwise check sequence IDs in its tests > - sequence ID is not a functional interface and are, in fact, meaningless. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SENTRY-1505) CommitContext isn't used by anything and should be reoved
[ https://issues.apache.org/jira/browse/SENTRY-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kolbasov updated SENTRY-1505: --- Attachment: SENTRY-1505.0.patch > CommitContext isn't used by anything and should be reoved > - > > Key: SENTRY-1505 > URL: https://issues.apache.org/jira/browse/SENTRY-1505 > Project: Sentry > Issue Type: Improvement > Components: Sentry >Affects Versions: 1.7.0, sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Alexander Kolbasov >Priority: Minor > Attachments: SENTRY-1505.0.patch > > > Sentry code defines class CommitContext which keeps track of sequence ID for > transaction. It is passed around many places in the server code but isn't > actually used by anything, so it is a dead code that should be trimmed. It > just complicates things without any benefit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SENTRY-1505) CommitContext isn't used by anything and should be reoved
[
https://issues.apache.org/jira/browse/SENTRY-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15577383#comment-15577383
]
Hadoop QA commented on SENTRY-1505:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12833484/SENTRY-1505.0.patch
against master.
{color:red}Overall:{color} -1 due to 13 errors
{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.generic.service.thrift.TestAuditLogForSentryGenericService
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceFailureCase
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceForHAWithKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceClientPool
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestAuthorizingDDLAuditLogWithKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.tools.TestSentryShellHive
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceWithInvalidMsgSize
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceForPoolHAWithKerberos
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.generic.tools.TestSentryConfigToolSolr
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithoutSecurity
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/2073/console
This message is automatically generated.
> CommitContext isn't used by anything and should be reoved
> -
>
> Key: SENTRY-1505
> URL: https://issues.apache.org/jira/browse/SENTRY-1505
> Project: Sentry
> Issue Type: Improvement
> Components: Sentry
>Affects Versions: 1.7.0, sentry-ha-redesign
>Reporter: Alexander Kolbasov
>Assignee: Alexander Kolbasov
>Priority: Minor
> Attachments: SENTRY-1505.0.patch
>
>
> Sentry code defines class CommitContext which keeps track of sequence ID for
> transaction. It is passed around many places in the server code but isn't
> actually used by anything, so it is a dead code that should be trimmed. It
> just complicates things without any benefit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SENTRY-1504) NPE in log4j.properties parsing
Colm O hEigeartaigh created SENTRY-1504: --- Summary: NPE in log4j.properties parsing Key: SENTRY-1504 URL: https://issues.apache.org/jira/browse/SENTRY-1504 Project: Sentry Issue Type: Bug Affects Versions: 1.7.0 Reporter: Colm O hEigeartaigh Assignee: Colm O hEigeartaigh Fix For: 1.8.0 There is a NPE if the log4j.properties configuration file does not contain "log.threshold". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SENTRY-1503) Remove all sequence ID checks from TestSentryStore
[
https://issues.apache.org/jira/browse/SENTRY-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576941#comment-15576941
]
Hadoop QA commented on SENTRY-1503:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12833461/SENTRY-1503.0.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/2072/console
This message is automatically generated.
> Remove all sequence ID checks from TestSentryStore
> --
>
> Key: SENTRY-1503
> URL: https://issues.apache.org/jira/browse/SENTRY-1503
> Project: Sentry
> Issue Type: Test
> Components: Sentry
>Affects Versions: 1.7.0, sentry-ha-redesign
>Reporter: Alexander Kolbasov
>Assignee: Alexander Kolbasov
> Attachments: SENTRY-1503.0.patch
>
>
> TestSentryStore shouldn't assert or otherwise check sequence IDs in its tests
> - sequence ID is not a functional interface and are, in fact, meaningless.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SENTRY-1503) Remove all sequence ID checks from TestSentryStore
[ https://issues.apache.org/jira/browse/SENTRY-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kolbasov updated SENTRY-1503: --- Status: Patch Available (was: Open) > Remove all sequence ID checks from TestSentryStore > -- > > Key: SENTRY-1503 > URL: https://issues.apache.org/jira/browse/SENTRY-1503 > Project: Sentry > Issue Type: Test > Components: Sentry >Affects Versions: 1.7.0, sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Alexander Kolbasov > Attachments: SENTRY-1503.0.patch > > > TestSentryStore shouldn't assert or otherwise check sequence IDs in its tests > - sequence ID is not a functional interface and are, in fact, meaningless. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SENTRY-1504) NPE in log4j.properties parsing
[
https://issues.apache.org/jira/browse/SENTRY-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575966#comment-15575966
]
Hadoop QA commented on SENTRY-1504:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12833402/SENTRY-1504.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} mvn test exited 1
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/2070/console
This message is automatically generated.
> NPE in log4j.properties parsing
> ---
>
> Key: SENTRY-1504
> URL: https://issues.apache.org/jira/browse/SENTRY-1504
> Project: Sentry
> Issue Type: Bug
>Affects Versions: 1.7.0
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
> Fix For: 1.8.0
>
> Attachments: SENTRY-1504.patch
>
>
> There is a NPE if the log4j.properties configuration file does not contain
> "log.threshold".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SENTRY-1504) NPE in log4j.properties parsing
[ https://issues.apache.org/jira/browse/SENTRY-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated SENTRY-1504: Status: Patch Available (was: Open) > NPE in log4j.properties parsing > --- > > Key: SENTRY-1504 > URL: https://issues.apache.org/jira/browse/SENTRY-1504 > Project: Sentry > Issue Type: Bug >Affects Versions: 1.7.0 >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > Fix For: 1.8.0 > > Attachments: SENTRY-1504.patch > > > There is a NPE if the log4j.properties configuration file does not contain > "log.threshold". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SENTRY-1504) NPE in log4j.properties parsing
[ https://issues.apache.org/jira/browse/SENTRY-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated SENTRY-1504: Attachment: SENTRY-1504.patch > NPE in log4j.properties parsing > --- > > Key: SENTRY-1504 > URL: https://issues.apache.org/jira/browse/SENTRY-1504 > Project: Sentry > Issue Type: Bug >Affects Versions: 1.7.0 >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > Fix For: 1.8.0 > > Attachments: SENTRY-1504.patch > > > There is a NPE if the log4j.properties configuration file does not contain > "log.threshold". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SENTRY-1477) Sentry clients should retry with another server when they get connection errors
[ https://issues.apache.org/jira/browse/SENTRY-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Li Li updated SENTRY-1477: -- Attachment: SENTRY-1477.1-sentry-ha-redesign.patch > Sentry clients should retry with another server when they get connection > errors > --- > > Key: SENTRY-1477 > URL: https://issues.apache.org/jira/browse/SENTRY-1477 > Project: Sentry > Issue Type: Sub-task > Components: Core >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Li Li > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1477.0-sentry-ha-redesign.patch, > SENTRY-1477.1-sentry-ha-redesign.patch > > > When Sentry clients get a connection error when talking to a server they > should re-try connection with another server. This should be normal client > behavior when one of the servers goes down. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
