[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702556#comment-14702556
]
Yu Ishikawa commented on SPARK-6813:
We did it. I appreciate your support.
SparkR
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604333#comment-14604333
]
Vincent Warmerdam commented on SPARK-6813:
--
What is the current consensus on the
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604435#comment-14604435
]
Shivaram Venkataraman commented on SPARK-6813:
--
[~cantdutchthis] This style
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596256#comment-14596256
]
Shivaram Venkataraman commented on SPARK-6813:
--
Thats great to know. Thanks
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596238#comment-14596238
]
Yu Ishikawa commented on SPARK-6813:
[~shivaram] Jim Hester, the creator of lintr,
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596656#comment-14596656
]
Yu Ishikawa commented on SPARK-6813:
[~shivaram] I've just sent a PR as follows.
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596645#comment-14596645
]
Shivaram Venkataraman commented on SPARK-6813:
--
Yeah lets do that and then
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596678#comment-14596678
]
Shivaram Venkataraman commented on SPARK-6813:
--
I think we can start fixing
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596732#comment-14596732
]
Yu Ishikawa commented on SPARK-6813:
I got it. I am going to separate the fixing
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596515#comment-14596515
]
Yu Ishikawa commented on SPARK-6813:
Can I send a PR to add {{allow_single_line =
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595150#comment-14595150
]
Shivaram Venkataraman commented on SPARK-6813:
--
Yeah we could disable those
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595159#comment-14595159
]
Yu Ishikawa commented on SPARK-6813:
I got it. As you mentioned, disabling those two
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594928#comment-14594928
]
Yu Ishikawa commented on SPARK-6813:
I'm not sure I agree with that. Personally, I
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594873#comment-14594873
]
Shivaram Venkataraman commented on SPARK-6813:
--
In terms of fixing the style
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594239#comment-14594239
]
Shivaram Venkataraman commented on SPARK-6813:
--
Two things
1. For the
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594227#comment-14594227
]
Yu Ishikawa commented on SPARK-6813:
[~shivaram] Those two rules looks good!
I
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594281#comment-14594281
]
Yu Ishikawa commented on SPARK-6813:
That's sounds good! I created an issue to add a
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594263#comment-14594263
]
Shivaram Venkataraman commented on SPARK-6813:
--
The list looks good to me.
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594250#comment-14594250
]
Yu Ishikawa commented on SPARK-6813:
Sounds great!
h3. TODO
Please let me know if
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594419#comment-14594419
]
Yu Ishikawa commented on SPARK-6813:
JUST INFORMATION: I have asked a question about
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593090#comment-14593090
]
Yu Ishikawa commented on SPARK-6813:
[~shivaram] sounds interesting! I created a
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593584#comment-14593584
]
Shivaram Venkataraman commented on SPARK-6813:
--
[~yuu.ishik...@gmail.com]
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593655#comment-14593655
]
Shivaram Venkataraman commented on SPARK-6813:
--
FWIW I think the basic things
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592060#comment-14592060
]
Shivaram Venkataraman commented on SPARK-6813:
--
Yeah we don't need to merge
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591315#comment-14591315
]
Davies Liu commented on SPARK-6813:
---
The lint tools is only used by Jenkins (or
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591325#comment-14591325
]
Yu Ishikawa commented on SPARK-6813:
Thank you for your comment.
I got it. As you
[
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590862#comment-14590862
]
Yu Ishikawa commented on SPARK-6813:
Before discussing the details of coding style,
27 matches
Mail list logo
