Re: [PR] WW-5350 Implement OGNL Allowlist capability [struts]

2023-11-12 Thread via GitHub
kusalk commented on PR #781: URL: https://github.com/apache/struts/pull/781#issuecomment-1807079954 @lukaszlenart Yep I'll add something about the OgnlGuard too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Work logged] (WW-5350) Implement optional strict class/package allowlist for OGNL

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5350?focusedWorklogId=890108=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890108 ] ASF GitHub Bot logged work on WW-5350: -- Author: ASF GitHub Bot

[jira] [Created] (WW-5362) Remove type attribute out of tag

2023-11-12 Thread Lukasz Lenart (Jira)
Lukasz Lenart created WW-5362: - Summary: Remove type attribute out of tag Key: WW-5362 URL: https://issues.apache.org/jira/browse/WW-5362 Project: Struts 2 Issue Type: Improvement

[jira] [Work logged] (WW-5333) Refactor AttributeMap

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5333?focusedWorklogId=890107=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890107 ] ASF GitHub Bot logged work on WW-5333: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5141) Support for JEE 9+

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890106=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890106 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot

Re: [PR] [WW-5333] Refactors AttributeMap [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #779: URL: https://github.com/apache/struts/pull/779#issuecomment-1807079341 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[jira] [Work logged] (WW-5350) Implement optional strict class/package allowlist for OGNL

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5350?focusedWorklogId=890099=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890099 ] ASF GitHub Bot logged work on WW-5350: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5350) Implement optional strict class/package allowlist for OGNL

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5350?focusedWorklogId=890097=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890097 ] ASF GitHub Bot logged work on WW-5350: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5350) Implement optional strict class/package allowlist for OGNL

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5350?focusedWorklogId=890098=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890098 ] ASF GitHub Bot logged work on WW-5350: -- Author: ASF GitHub Bot

Re: [PR] WW-5350 Implement OGNL Allowlist capability [struts]

2023-11-12 Thread via GitHub
lukaszlenart commented on PR #781: URL: https://github.com/apache/struts/pull/781#issuecomment-1807072225 It would be good to document this new future to more visible to the users. Could you also add a section about this new _allow list_

[jira] [Work logged] (WW-5350) Implement optional strict class/package allowlist for OGNL

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5350?focusedWorklogId=890104=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890104 ] ASF GitHub Bot logged work on WW-5350: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5335) Adjusts Jenkins & Github build files to use JDK17

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5335?focusedWorklogId=890112=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890112 ] ASF GitHub Bot logged work on WW-5335: -- Author: ASF GitHub Bot

Re: [PR] [WW-5335] Prepares for Java 17 & Struts 7.x [struts]

2023-11-12 Thread via GitHub
lukaszlenart commented on code in PR #785: URL: https://github.com/apache/struts/pull/785#discussion_r1390381147 ## .github/workflows/codeql.yml: ## Review Comment: like this? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-12 Thread via GitHub
kusalk commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1807061357 @lukaszlenart I'm going to make it extensible as part of WW-5343 so that applications can add even stronger checks if they so desire - so will leave it not `final` -- This is an automated

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1807061451 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5350 Implement OGNL Allowlist capability [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #781: URL: https://github.com/apache/struts/pull/781#issuecomment-1807067473 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] [WW-5335] Prepares for Java 17 & Struts 7.x [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/struts/pull/785#issuecomment-1807088966 Please retry analysis of this Pull-Request directly on [SonarCloud](https://sonarcloud.io/project/issues?id=apache_struts=785). -- This is an automated message from the Apache Git

[jira] [Work logged] (WW-5335) Adjusts Jenkins & Github build files to use JDK17

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5335?focusedWorklogId=890113=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890113 ] ASF GitHub Bot logged work on WW-5335: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5335) Adjusts Jenkins & Github build files to use JDK17

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5335?focusedWorklogId=890114=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890114 ] ASF GitHub Bot logged work on WW-5335: -- Author: ASF GitHub Bot

Re: [PR] [WW-5335] Prepares for Java 17 & Struts 7.x [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/struts/pull/785#issuecomment-1807088768 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] [WW-5335] Prepares for Java 17 & Struts 7.x [struts]

2023-11-12 Thread via GitHub
kusalk commented on code in PR #785: URL: https://github.com/apache/struts/pull/785#discussion_r1390382421 ## .github/workflows/codeql.yml: ## Review Comment: I think so - let's see if the build goes green -- This is an automated message from the Apache Git Service. To

[jira] [Work logged] (WW-5350) Implement optional strict class/package allowlist for OGNL

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5350?focusedWorklogId=890102=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890102 ] ASF GitHub Bot logged work on WW-5350: -- Author: ASF GitHub Bot

Re: [PR] [WW-5141] Support for JakartaEE [struts]

2023-11-12 Thread via GitHub
lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1807078997 Astonish work  and feel free to remove the `EmbeddedJSP` and `OVal` plugins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Work logged] (WW-5333) Refactor AttributeMap

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5333?focusedWorklogId=890105=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890105 ] ASF GitHub Bot logged work on WW-5333: -- Author: ASF GitHub Bot

Re: [PR] [WW-5333] Refactors AttributeMap [struts]

2023-11-12 Thread via GitHub
lukaszlenart commented on code in PR #779: URL: https://github.com/apache/struts/pull/779#discussion_r1390375759 ## core/src/main/java/org/apache/struts2/dispatcher/DispatcherScope.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[jira] [Work logged] (WW-5335) Adjusts Jenkins & Github build files to use JDK17

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5335?focusedWorklogId=890109=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890109 ] ASF GitHub Bot logged work on WW-5335: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5335) Adjusts Jenkins & Github build files to use JDK17

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5335?focusedWorklogId=890110=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890110 ] ASF GitHub Bot logged work on WW-5335: -- Author: ASF GitHub Bot

Re: [PR] [WW-5335] Prepares for Java 17 & Struts 7.x [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/struts/pull/785#issuecomment-1807083409 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Work logged] (WW-5335) Adjusts Jenkins & Github build files to use JDK17

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5335?focusedWorklogId=890111=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890111 ] ASF GitHub Bot logged work on WW-5335: -- Author: ASF GitHub Bot

Re: [PR] [WW-5335] Prepares for Java 17 & Struts 7.x [struts]

2023-11-12 Thread via GitHub
kusalk commented on code in PR #785: URL: https://github.com/apache/struts/pull/785#discussion_r1390379575 ## .github/workflows/codeql.yml: ## Review Comment: Need to add `java-version` to these job(s) ## pom.xml: ## @@ -51,7 +51,7 @@

[jira] [Work logged] (WW-5335) Adjusts Jenkins & Github build files to use JDK17

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5335?focusedWorklogId=890115=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890115 ] ASF GitHub Bot logged work on WW-5335: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5333) Refactor AttributeMap

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5333?focusedWorklogId=890133=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890133 ] ASF GitHub Bot logged work on WW-5333: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5141) Support for JEE 9+

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890134=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890134 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot

Re: [PR] [WW-5141] Support for JakartaEE [struts]

2023-11-12 Thread via GitHub
tyme-dev commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1807217384 @jdyer1 I've went ahead and got Commons-Upload tests working and converted over to Fileupload2-jakarta. since your pr is the reference one, I've went ahead and did a pull request on

[jira] [Work logged] (WW-5335) Adjusts Jenkins & Github build files to use JDK17

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5335?focusedWorklogId=890137=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890137 ] ASF GitHub Bot logged work on WW-5335: -- Author: ASF GitHub Bot

Re: [PR] [WW-5335] Prepares for Java 17 & Struts 7.x [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #785: URL: https://github.com/apache/struts/pull/785#issuecomment-1807237055 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[jira] [Resolved] (WW-5333) Refactor AttributeMap

2023-11-12 Thread Lukasz Lenart (Jira)
[ https://issues.apache.org/jira/browse/WW-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukasz Lenart resolved WW-5333. --- Resolution: Fixed > Refactor AttributeMap > - > > Key: WW-5333 >

[jira] [Work logged] (WW-5333) Refactor AttributeMap

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5333?focusedWorklogId=890136=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890136 ] ASF GitHub Bot logged work on WW-5333: -- Author: ASF GitHub Bot

Re: [PR] [WW-5333] Refactors AttributeMap [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #779: URL: https://github.com/apache/struts/pull/779#issuecomment-1807185045 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[jira] [Work logged] (WW-5333) Refactor AttributeMap

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5333?focusedWorklogId=890126=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890126 ] ASF GitHub Bot logged work on WW-5333: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5333) Refactor AttributeMap

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5333?focusedWorklogId=890130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890130 ] ASF GitHub Bot logged work on WW-5333: -- Author: ASF GitHub Bot

Re: [PR] [WW-5333] Refactors AttributeMap [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #779: URL: https://github.com/apache/struts/pull/779#issuecomment-1807205481 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[jira] [Work logged] (WW-5333) Refactor AttributeMap

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5333?focusedWorklogId=890128=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890128 ] ASF GitHub Bot logged work on WW-5333: -- Author: ASF GitHub Bot

Re: [PR] [WW-5333] Refactors AttributeMap [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #779: URL: https://github.com/apache/struts/pull/779#issuecomment-1807198473 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] [WW-5333] Refactors AttributeMap [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #779: URL: https://github.com/apache/struts/pull/779#issuecomment-1807207571 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[jira] [Work logged] (WW-5333) Refactor AttributeMap

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5333?focusedWorklogId=890131=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890131 ] ASF GitHub Bot logged work on WW-5333: -- Author: ASF GitHub Bot

[jira] [Work logged] (WW-5333) Refactor AttributeMap

2023-11-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WW-5333?focusedWorklogId=890132=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890132 ] ASF GitHub Bot logged work on WW-5333: -- Author: ASF GitHub Bot

Re: [PR] [WW-5333] Refactors AttributeMap [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #779: URL: https://github.com/apache/struts/pull/779#issuecomment-1807211166 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] [WW-5333] Refactors AttributeMap [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #779: URL: https://github.com/apache/struts/pull/779#issuecomment-1807214005 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] Adds info about new notifications list [struts-site]

2023-11-12 Thread via GitHub
asf-ci commented on PR #212: URL: https://github.com/apache/struts-site/pull/212#issuecomment-1807561776 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Uses the new notifications@ list for all the messages form Github [struts]

2023-11-12 Thread via GitHub
sonarcloud[bot] commented on PR #788: URL: https://github.com/apache/struts/pull/788#issuecomment-1807537598 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality