coveralls commented on pull request #406:
URL: https://github.com/apache/struts/pull/406#issuecomment-619337271
[](https://coveralls.io/builds/30334750)
Coverage increased (+0.003%) to 49.184% when pulling
**19c71ff15
coveralls commented on pull request #407:
URL: https://github.com/apache/struts/pull/407#issuecomment-619489582
[](https://coveralls.io/builds/30344610)
Coverage decreased (-0.005%) to 49.176% when pulling
**4a8315fa1
coveralls commented on pull request #408:
URL: https://github.com/apache/struts/pull/408#issuecomment-619503812
[](https://coveralls.io/builds/30345949)
Coverage decreased (-0.01%) to 49.167% when pulling
**592c942c76
JCgH4164838Gh792C124B5 commented on pull request #409:
URL: https://github.com/apache/struts/pull/409#issuecomment-619570544
Hello Apache Struts Team. This PR is just a cherry-pick of two minor unit
test changes from 2.5.x into 2.6.x.
-
JCgH4164838Gh792C124B5 commented on pull request #400:
URL: https://github.com/apache/struts/pull/400#issuecomment-619571095
Hi @atkaiser. Thanks for discovering this issue, reporting it and providing
a PR for a fix. 👍
Th
coveralls commented on pull request #409:
URL: https://github.com/apache/struts/pull/409#issuecomment-619572364
[](https://coveralls.io/builds/30349573)
Coverage remained the same at 49.181% when pulling
**9faa39c8dc7
JCgH4164838Gh792C124B5 commented on a change in pull request #406:
URL: https://github.com/apache/struts/pull/406#discussion_r415353423
##
File path: plugins/json/src/main/java/org/apache/struts2/json/JSONResult.java
##
@@ -212,12 +211,22 @@ protected Object readRootObject(Acti
lukaszlenart commented on pull request #409:
URL: https://github.com/apache/struts/pull/409#issuecomment-619593941
LGTM 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
JCgH4164838Gh792C124B5 commented on a change in pull request #408:
URL: https://github.com/apache/struts/pull/408#discussion_r415400292
##
File path: plugins/junit/src/main/java/org/apache/struts2/util/TestUtils.java
##
@@ -85,13 +79,13 @@ public static boolean compare(URL url,
JCgH4164838Gh792C124B5 commented on a change in pull request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r415405262
##
File path: core/src/main/java/org/apache/struts2/ServletActionContext.java
##
@@ -26,23 +26,18 @@
import javax.servlet.http.HttpServletReq
lukaszlenart commented on pull request #407:
URL: https://github.com/apache/struts/pull/407#issuecomment-619739687
> A couple of the unit test changes dropped a few `@author` tags
It's a good practice to not to specify the tag. After my changes and
previous changes, the original auth
lukaszlenart commented on a change in pull request #406:
URL: https://github.com/apache/struts/pull/406#discussion_r415537558
##
File path: plugins/json/src/main/java/org/apache/struts2/json/JSONResult.java
##
@@ -68,8 +69,6 @@
*/
public class JSONResult implements Result {
coveralls edited a comment on pull request #407:
URL: https://github.com/apache/struts/pull/407#issuecomment-619489582
[](https://coveralls.io/builds/30359266)
Coverage decreased (-0.005%) to 49.176% when pulling
**13
lukaszlenart commented on a change in pull request #406:
URL: https://github.com/apache/struts/pull/406#discussion_r415539580
##
File path: plugins/json/src/main/java/org/apache/struts2/json/JSONResult.java
##
@@ -212,12 +211,22 @@ protected Object readRootObject(ActionInvocati
lukaszlenart commented on a change in pull request #406:
URL: https://github.com/apache/struts/pull/406#discussion_r415540412
##
File path: plugins/json/src/main/java/org/apache/struts2/json/JSONResult.java
##
@@ -286,7 +294,9 @@ public String getRoot() {
}
/**
-
coveralls edited a comment on pull request #406:
URL: https://github.com/apache/struts/pull/406#issuecomment-619337271
[](https://coveralls.io/builds/30359667)
Coverage increased (+0.003%) to 49.184% when pulling
**d8
davelnewton commented on a change in pull request #410:
URL: https://github.com/apache/struts/pull/410#discussion_r416066319
##
File path:
core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java
##
@@ -107,6 +107,7 @@
import com.opensymphon
coveralls commented on pull request #410:
URL: https://github.com/apache/struts/pull/410#issuecomment-620171962
[](https://coveralls.io/builds/30379383)
Coverage increased (+0.01%) to 49.195% when pulling
**d960e94820
davelnewton commented on a change in pull request #410:
URL: https://github.com/apache/struts/pull/410#discussion_r416071496
##
File path:
core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
##
@@ -192,7 +217,7 @@ protected String convertParam(String va
lukaszlenart commented on a change in pull request #410:
URL: https://github.com/apache/struts/pull/410#discussion_r41680
##
File path:
core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java
##
@@ -107,6 +107,7 @@
import com.opensympho
lukaszlenart commented on a change in pull request #410:
URL: https://github.com/apache/struts/pull/410#discussion_r416335442
##
File path:
core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
##
@@ -192,7 +217,7 @@ protected String convertParam(String v
coveralls edited a comment on pull request #410:
URL: https://github.com/apache/struts/pull/410#issuecomment-620171962
[](https://coveralls.io/builds/30390878)
Coverage increased (+0.01%) to 49.195% when pulling
**082
lukaszlenart commented on a change in pull request #408:
URL: https://github.com/apache/struts/pull/408#discussion_r416344768
##
File path: plugins/junit/src/main/java/org/apache/struts2/util/TestUtils.java
##
@@ -85,13 +79,13 @@ public static boolean compare(URL url, String te
lukaszlenart commented on a change in pull request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r416347889
##
File path: core/src/main/java/org/apache/struts2/ServletActionContext.java
##
@@ -26,23 +26,18 @@
import javax.servlet.http.HttpServletRequest;
imp
lukaszlenart commented on a change in pull request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r416348145
##
File path: core/src/main/java/org/apache/struts2/ServletActionContext.java
##
@@ -26,23 +26,18 @@
import javax.servlet.http.HttpServletRequest;
imp
lukaszlenart commented on a change in pull request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r416349031
##
File path:
core/src/main/java/org/apache/struts2/interceptor/ScopeInterceptor.java
##
@@ -262,7 +262,7 @@ static void unlock(Object o) {
}
lukaszlenart commented on a change in pull request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r416350023
##
File path:
core/src/main/java/org/apache/struts2/interceptor/ScopeInterceptor.java
##
@@ -271,18 +271,18 @@ protected void after(ActionInvocation in
lukaszlenart commented on a change in pull request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r416350761
##
File path: core/src/main/java/org/apache/struts2/result/PlainTextResult.java
##
@@ -47,7 +47,7 @@
* response type (eg. Content-Type=text/plain; ch
coveralls edited a comment on pull request #408:
URL: https://github.com/apache/struts/pull/408#issuecomment-619503812
[](https://coveralls.io/builds/30391170)
Coverage decreased (-0.02%) to 49.164% when pulling
**1e1
lukaszlenart commented on a change in pull request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r416353490
##
File path: core/src/main/resources/struts-default.xml
##
@@ -68,7 +68,6 @@
https://github.com/apache/struts/pull/371/files#diff-710b29900cea21e8
coveralls edited a comment on pull request #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-602049491
[](https://coveralls.io/builds/30455663)
Coverage increased (+0.03%) to 49.212% when pulling
**567
lukaszlenart commented on pull request #408:
URL: https://github.com/apache/struts/pull/408#issuecomment-622250771
LGTM 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
coveralls edited a comment on pull request #407:
URL: https://github.com/apache/struts/pull/407#issuecomment-619489582
[](https://coveralls.io/builds/30483960)
Coverage decreased (-0.02%) to 49.159% when pulling
**642
JCgH4164838Gh792C124B5 commented on a change in pull request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r418996746
##
File path: core/src/main/java/org/apache/struts2/ServletActionContext.java
##
@@ -26,23 +26,18 @@
import javax.servlet.http.HttpServletReq
JCgH4164838Gh792C124B5 commented on a change in pull request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r419008690
##
File path: core/src/main/resources/struts-default.xml
##
@@ -68,7 +68,6 @@
JCgH4164838Gh792C124B5 commented on pull request #411:
URL: https://github.com/apache/struts/pull/411#issuecomment-623019045
Hello Apache Struts Team.
Not much to this PR, just a simple bugfix. If approved, it will be easy to
cherry-pick into 2.6 as well.
-
coveralls commented on pull request #411:
URL: https://github.com/apache/struts/pull/411#issuecomment-623021314
[](https://coveralls.io/builds/30514397)
Coverage decreased (-0.002%) to 47.081% when pulling
**4786fba0d
lukaszlenart commented on a change in pull request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r419080401
##
File path: core/src/main/resources/struts-default.xml
##
@@ -68,7 +68,6 @@
coveralls edited a comment on pull request #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-602049491
[](https://coveralls.io/builds/30519247)
Coverage increased (+0.03%) to 49.193% when pulling
**375
lukaszlenart commented on a change in pull request #410:
URL: https://github.com/apache/struts/pull/410#discussion_r419095491
##
File path:
core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
##
@@ -192,7 +217,7 @@ protected String convertParam(String v
JCgH4164838Gh792C124B5 commented on pull request #412:
URL: https://github.com/apache/struts/pull/412#issuecomment-623134138
Hello Apache Struts Team. This PR is just a cherry-pick of the minor
Showcase application single file upload fix from 2.5.x into 2.6.x.
coveralls commented on pull request #412:
URL: https://github.com/apache/struts/pull/412#issuecomment-623136504
[](https://coveralls.io/builds/30522104)
Coverage decreased (-0.003%) to 49.173% when pulling
**6afcbf286
coveralls commented on pull request #413:
URL: https://github.com/apache/struts/pull/413#issuecomment-623146326
[](https://coveralls.io/builds/30522553)
Coverage remained the same at 49.176% when pulling
**a6711251a68
JCgH4164838Gh792C124B5 commented on pull request #413:
URL: https://github.com/apache/struts/pull/413#issuecomment-623146394
Hello Apache Struts Team.
This PR attempts to fix the ASM version conflict issue (two jars with
different versions, groupId changed after ASM 3.x) found after
lukaszlenart commented on pull request #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-623259205
Yupi!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
yasserzamani commented on pull request #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-623303167
Hi there,
I had added `java.io.` to exclusion list to mitigate an open issue in
our security list.
@lukaszlenart , @JCgH4164838Gh792C124B5, Could you please pas
lukaszlenart commented on pull request #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-623360744
@yasserzamani this is already resolved and `java.io` was excluded as well.
This is an automated message from t
JCgH4164838Gh792C124B5 commented on pull request #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-624397178
Hi @yasserzamani.
Thanks for reviewing the item concerning the `java.io` exclusion list. 👍
Your reasoning above is sound, and the Showcase upload action was
yasserzamani commented on pull request #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-624687993
Hi @JCgH4164838Gh792C124B5 ,
Thank you so much for your fix and clarification! No it's OK; I had
overlooked the revert commit owing to a pell-mell inbox ;)
Rega
coveralls commented on pull request #415:
URL: https://github.com/apache/struts/pull/415#issuecomment-629689550
[](https://coveralls.io/builds/30835586)
Coverage remained the same at 49.204% when pulling
**d29c2f6161b
JCgH4164838Gh792C124B5 commented on pull request #416:
URL: https://github.com/apache/struts/pull/416#issuecomment-629716479
Hello Apache Struts Team.
Looking at #414 it seems like the Dispatcher change there would make sense
for Struts 2.5.x as well.
So ... this PR is a parti
coveralls commented on pull request #416:
URL: https://github.com/apache/struts/pull/416#issuecomment-629717109
[](https://coveralls.io/builds/30837471)
Coverage decreased (-0.006%) to 47.076% when pulling
**59a6cbf6c
JCgH4164838Gh792C124B5 edited a comment on pull request #417:
URL: https://github.com/apache/struts/pull/417#issuecomment-629841098
Hello Apache Struts Team.
The PR #416 was already accepted and merged, but Coveralls pointed out that
code-coverage dropped. Due to the potentially bad
JCgH4164838Gh792C124B5 commented on pull request #417:
URL: https://github.com/apache/struts/pull/417#issuecomment-629841098
Hello Apache Struts Team.
The PR #416 was already accepted and merged, but Coveralls pointed out that
code-coverage dropped. Due to the potentially bad behavi
coveralls commented on pull request #417:
URL: https://github.com/apache/struts/pull/417#issuecomment-629841861
[](https://coveralls.io/builds/30845133)
Coverage increased (+0.02%) to 47.096% when pulling
**4457f03c70
coveralls commented on pull request #418:
URL: https://github.com/apache/struts/pull/418#issuecomment-630378414
[](https://coveralls.io/builds/30868950)
Coverage increased (+0.02%) to 49.223% when pulling
**0d3664f69d
lukaszlenart commented on pull request #418:
URL: https://github.com/apache/struts/pull/418#issuecomment-630386613
LGTM 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sepe81 commented on a change in pull request #419:
URL: https://github.com/apache/struts/pull/419#discussion_r428516840
##
File path:
core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
##
@@ -101,7 +104,7 @@ static private int countOGNLCharacters
lukaszlenart commented on a change in pull request #419:
URL: https://github.com/apache/struts/pull/419#discussion_r428535889
##
File path:
core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
##
@@ -101,7 +104,7 @@ static private int countOGNLChar
coveralls commented on pull request #419:
URL: https://github.com/apache/struts/pull/419#issuecomment-631997239
[](https://coveralls.io/builds/30940590)
Coverage increased (+0.001%) to 47.098% when pulling
**c290b0a36
sepe81 commented on a change in pull request #419:
URL: https://github.com/apache/struts/pull/419#discussion_r429569612
##
File path:
core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
##
@@ -18,20 +18,20 @@
*/
package com.opensymphony.xwork2.
lukaszlenart commented on a change in pull request #419:
URL: https://github.com/apache/struts/pull/419#discussion_r429606130
##
File path:
core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
##
@@ -18,20 +18,20 @@
*/
package com.opensymphony.x
coveralls edited a comment on pull request #419:
URL: https://github.com/apache/struts/pull/419#issuecomment-631997239
[](https://coveralls.io/builds/30994465)
Coverage increased (+0.001%) to 47.098% when pulling
**04
lukaszlenart commented on pull request #419:
URL: https://github.com/apache/struts/pull/419#issuecomment-633192968
Cherry-pick is ready https://github.com/apache/struts/pull/420
This is an automated message from the Apache Gi
coveralls commented on pull request #420:
URL: https://github.com/apache/struts/pull/420#issuecomment-633194854
[](https://coveralls.io/builds/30994601)
Coverage increased (+0.001%) to 49.224% when pulling
**880d3b7ab
dehghani-reza opened a new issue #421:
URL: https://github.com/apache/struts/issues/421
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
coveralls commented on pull request #422:
URL: https://github.com/apache/struts/pull/422#issuecomment-650998635
[](https://coveralls.io/builds/31742225)
Coverage increased (+0.08%) to 49.306% when pulling
**f15d85b496
coveralls commented on pull request #423:
URL: https://github.com/apache/struts/pull/423#issuecomment-653402920
[](https://coveralls.io/builds/31842037)
Coverage remained the same at 49.224% when pulling
**0d622cfa96d
yasserzamani commented on pull request #422:
URL: https://github.com/apache/struts/pull/422#issuecomment-653852288
Shouldn't we do something in configs, allowing developer to define this
result via struts.xml as well?
Already there is a PlainTextResult, shouldn't we amend it to extend th
lukaszlenart commented on pull request #422:
URL: https://github.com/apache/struts/pull/422#issuecomment-654033477
> Shouldn't we do something in configs, allowing developer to define this
result via struts.xml as well?
No, this result is a plain code-based-result, you cannot define
yasserzamani commented on pull request #422:
URL: https://github.com/apache/struts/pull/422#issuecomment-654893613
LGTM thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log o
coveralls commented on pull request #425:
URL: https://github.com/apache/struts/pull/425#issuecomment-657112090
[](https://coveralls.io/builds/32009288)
Coverage increased (+0.005%) to 47.102% when pulling
**1b0c743e8
lukaszlenart commented on a change in pull request #426:
URL: https://github.com/apache/struts/pull/426#discussion_r454244077
##
File path:
core/src/main/java/org/apache/struts2/interceptor/DefaultResourceIsolationPolicy.java
##
@@ -0,0 +1,49 @@
+package org.apache.struts2.int
salcho commented on a change in pull request #426:
URL: https://github.com/apache/struts/pull/426#discussion_r454251354
##
File path:
core/src/main/java/org/apache/struts2/interceptor/DefaultResourceIsolationPolicy.java
##
@@ -0,0 +1,49 @@
+package org.apache.struts2.intercept
salcho commented on a change in pull request #426:
URL: https://github.com/apache/struts/pull/426#discussion_r454252239
##
File path:
core/src/main/java/org/apache/struts2/interceptor/DefaultResourceIsolationPolicy.java
##
@@ -0,0 +1,49 @@
+package org.apache.struts2.intercept
coveralls commented on pull request #426:
URL: https://github.com/apache/struts/pull/426#issuecomment-658126974
[](https://coveralls.io/builds/32056263)
Coverage increased (+0.03%) to 49.342% when pulling
**5b27fc25d1
aaronshim commented on pull request #426:
URL: https://github.com/apache/struts/pull/426#issuecomment-658182958
Great job, @salcho !
This is an automated message from the Apache Git Service.
To respond to the message, please
yasserzamani commented on a change in pull request #426:
URL: https://github.com/apache/struts/pull/426#discussion_r455177518
##
File path:
core/src/main/java/org/apache/struts2/interceptor/FetchMetadataInterceptor.java
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Softwa
yasserzamani commented on a change in pull request #426:
URL: https://github.com/apache/struts/pull/426#discussion_r455179316
##
File path:
core/src/main/java/org/apache/struts2/interceptor/FetchMetadataInterceptor.java
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Softwa
yasserzamani commented on a change in pull request #425:
URL: https://github.com/apache/struts/pull/425#discussion_r455190015
##
File path:
core/src/main/java/com/opensymphony/xwork2/security/DefaultAcceptedPatternsChecker.java
##
@@ -35,7 +37,11 @@
private static final L
lukaszlenart commented on a change in pull request #425:
URL: https://github.com/apache/struts/pull/425#discussion_r455519018
##
File path:
core/src/main/java/com/opensymphony/xwork2/security/DefaultAcceptedPatternsChecker.java
##
@@ -35,7 +37,11 @@
private static final L
coveralls edited a comment on pull request #425:
URL: https://github.com/apache/struts/pull/425#issuecomment-657112090
[](https://coveralls.io/builds/32103442)
Coverage increased (+0.005%) to 47.102% when pulling
**32
yasserzamani commented on a change in pull request #425:
URL: https://github.com/apache/struts/pull/425#discussion_r455667021
##
File path:
core/src/main/java/com/opensymphony/xwork2/security/DefaultAcceptedPatternsChecker.java
##
@@ -35,7 +37,11 @@
private static final L
salcho commented on pull request #426:
URL: https://github.com/apache/struts/pull/426#issuecomment-659320781
Thanks for your review Yasser! The log statement will be useful for
debugging endpoints that should have been added to exempted paths.
-
salcho commented on a change in pull request #426:
URL: https://github.com/apache/struts/pull/426#discussion_r455683472
##
File path:
core/src/main/java/org/apache/struts2/interceptor/FetchMetadataInterceptor.java
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Fou
coveralls edited a comment on pull request #426:
URL: https://github.com/apache/struts/pull/426#issuecomment-658126974
[](https://coveralls.io/builds/32109926)
Coverage increased (+0.03%) to 49.345% when pulling
**193
yasserzamani commented on a change in pull request #426:
URL: https://github.com/apache/struts/pull/426#discussion_r455719812
##
File path:
core/src/main/java/org/apache/struts2/interceptor/FetchMetadataInterceptor.java
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Softwa
lukaszlenart commented on a change in pull request #426:
URL: https://github.com/apache/struts/pull/426#discussion_r456250213
##
File path:
core/src/main/java/org/apache/struts2/interceptor/FetchMetadataInterceptor.java
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Softwa
coveralls edited a comment on pull request #425:
URL: https://github.com/apache/struts/pull/425#issuecomment-657112090
[](https://coveralls.io/builds/32136441)
Coverage increased (+0.005%) to 47.102% when pulling
**9b
lukaszlenart commented on a change in pull request #425:
URL: https://github.com/apache/struts/pull/425#discussion_r456258675
##
File path:
core/src/main/java/com/opensymphony/xwork2/security/DefaultAcceptedPatternsChecker.java
##
@@ -35,7 +37,11 @@
private static final L
salcho commented on pull request #426:
URL: https://github.com/apache/struts/pull/426#issuecomment-659935747
Hi @lukaszlenart , sorry, I couldn't reply to your comment so here's my
reply:
I think this case is slightly different than usual in that there are two
outcomes for Fetch Met
lukaszlenart commented on pull request #426:
URL: https://github.com/apache/struts/pull/426#issuecomment-659975016
Yeah... I think it would be better to stop using `PreResultListener` and
just add the header on the beginning of the `intercept()` method.
---
coveralls edited a comment on pull request #426:
URL: https://github.com/apache/struts/pull/426#issuecomment-658126974
[](https://coveralls.io/builds/32139500)
Coverage increased (+0.03%) to 49.344% when pulling
**890
lukaszlenart commented on pull request #426:
URL: https://github.com/apache/struts/pull/426#issuecomment-660007438
🎉 great 🎉
LGTM 👍
This is an automated message from the Apache Git Service.
To respond to the message
JCgH4164838Gh792C124B5 commented on pull request #427:
URL: https://github.com/apache/struts/pull/427#issuecomment-660813094
Hello Apache Struts Team.
This activity took a lot longer than originally planned, but finally it is
at a state where a PR for 2.5.x seemed reasonable. Origin
JCgH4164838Gh792C124B5 commented on pull request #427:
URL: https://github.com/apache/struts/pull/427#issuecomment-660817461
Hmmm. The OSGi plugin builds are all failing for the same reason, unit test
failures because Felix cannot create its default cache directory
("/tmp.felix-cache").
lukaszlenart commented on a change in pull request #427:
URL: https://github.com/apache/struts/pull/427#discussion_r458546820
##
File path:
plugins/osgi/src/main/java/org/apache/struts2/osgi/BundlePackageLoader.java
##
@@ -45,24 +47,96 @@
private static final Logger LOG
yasserzamani commented on pull request #427:
URL: https://github.com/apache/struts/pull/427#issuecomment-663361353
Wow, thanks a lot!
Regarding felix cache permission issue, it seems you or user can use
[org.osgi.framework.storage](https://felix.apache.org/documentation/subprojects/a
yasserzamani commented on a change in pull request #427:
URL: https://github.com/apache/struts/pull/427#discussion_r459873684
##
File path: plugins/osgi/src/main/java/org/apache/struts2/osgi/OsgiUtil.java
##
@@ -92,4 +92,83 @@ public static boolean containsBean(Object beanFacto
JCgH4164838Gh792C124B5 commented on a change in pull request #427:
URL: https://github.com/apache/struts/pull/427#discussion_r460437780
##
File path:
plugins/osgi/src/main/java/org/apache/struts2/osgi/BundlePackageLoader.java
##
@@ -45,24 +47,96 @@
private static final
1 - 100 of 966 matches
Mail list logo
