[GitHub] [struts] sonarcloud[bot] commented on pull request #745: WW-5339 Misc clean up in CompoundRootAccessor and OgnlValueStackTest

2023-08-30 Thread via GitHub
sonarcloud[bot] commented on PR #745: URL: https://github.com/apache/struts/pull/745#issuecomment-1698711298 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] kusalk commented on a diff in pull request #741: WW-5341 Ensure exclusion list applies to objects from all ClassLoaders

2023-09-05 Thread via GitHub
kusalk commented on code in PR #741: URL: https://github.com/apache/struts/pull/741#discussion_r1309606372 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -84,16 +86,17 @@ public Object setup(Map context, Object target, Member member, String

[GitHub] [struts] lukaszlenart commented on a diff in pull request #748: Moves all CI notifications to commits@ list

2023-09-02 Thread via GitHub
lukaszlenart commented on code in PR #748: URL: https://github.com/apache/struts/pull/748#discussion_r1313825616 ## .asf.yaml: ## @@ -3,8 +3,8 @@ notifications: commits: comm...@struts.apache.org # Send all issue emails (new, closed, comments) to issues@ issues:

[GitHub] [struts-site] asf-ci commented on pull request #202: Adds release notes and announcement of Struts 6.3.0

2023-09-04 Thread via GitHub
asf-ci commented on PR #202: URL: https://github.com/apache/struts-site/pull/202#issuecomment-1705965298 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [struts-site] asf-ci commented on pull request #202: Adds release notes and announcement of Struts 6.3.0

2023-09-05 Thread via GitHub
asf-ci commented on PR #202: URL: https://github.com/apache/struts-site/pull/202#issuecomment-1705994547 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [struts-site] asf-ci commented on pull request #202: Adds release notes and announcement of Struts 6.3.0

2023-09-05 Thread via GitHub
asf-ci commented on PR #202: URL: https://github.com/apache/struts-site/pull/202#issuecomment-1705995269 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [struts] hepptho commented on pull request #754: replace BeanManager::createInjectionTarget

2023-09-11 Thread via GitHub
hepptho commented on PR #754: URL: https://github.com/apache/struts/pull/754#issuecomment-1713724266 Sure, I just requested an account and will create the ticket once I have access. I see one of the build checks failed. Is that a known issue? Doesn't seem like something I could have

[GitHub] [struts] lukaszlenart commented on pull request #754: replace BeanManager::createInjectionTarget

2023-09-11 Thread via GitHub
lukaszlenart commented on PR #754: URL: https://github.com/apache/struts/pull/754#issuecomment-1713726039 > Sure, I just requested an account and will create the ticket once I have access. Already approved :) > I see one of the build checks failed. Is that a known issue?

[GitHub] [struts] sepe81 commented on pull request #734: Bump opensymphony:sitemesh from 2.4.2 to 2.5.0

2023-08-28 Thread via GitHub
sepe81 commented on PR #734: URL: https://github.com/apache/struts/pull/734#issuecomment-1695959576 Removing the deprecation sounds great b/c there seems to be some activity again, so that sitemesh is not dead. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [struts] sonarcloud[bot] commented on pull request #742: WW-5342 Add option to block use of default package

2023-08-30 Thread via GitHub
sonarcloud[bot] commented on PR #742: URL: https://github.com/apache/struts/pull/742#issuecomment-1699147796 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #742: WW-5342 Add option to block use of default package

2023-08-30 Thread via GitHub
sonarcloud[bot] commented on PR #742: URL: https://github.com/apache/struts/pull/742#issuecomment-1699150777 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts-site] asf-ci commented on pull request #205: Adds missing outdated releases

2023-09-13 Thread via GitHub
asf-ci commented on PR #205: URL: https://github.com/apache/struts-site/pull/205#issuecomment-1718071754 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [struts] github-code-scanning[bot] commented on a diff in pull request #746: WW-5340 Preliminary refactor of OgnlUtil

2023-08-31 Thread via GitHub
github-code-scanning[bot] commented on code in PR #746: URL: https://github.com/apache/struts/pull/746#discussion_r131195 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -592,58 +582,55 @@ } public Object getValue(final String name, final

[GitHub] [struts] sonarcloud[bot] commented on pull request #746: WW-5340 Preliminary refactor of OgnlUtil

2023-08-31 Thread via GitHub
sonarcloud[bot] commented on PR #746: URL: https://github.com/apache/struts/pull/746#issuecomment-1700521337 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #746: WW-5340 Preliminary refactor of OgnlUtil

2023-08-31 Thread via GitHub
sonarcloud[bot] commented on PR #746: URL: https://github.com/apache/struts/pull/746#issuecomment-1700521581 Please retry analysis of this Pull-Request directly on [SonarCloud](https://sonarcloud.io/project/issues?id=apache_struts=746). -- This is an automated message from the Apache Git

[GitHub] [struts] sonarcloud[bot] commented on pull request #746: WW-5340 Preliminary refactor of OgnlUtil

2023-08-31 Thread via GitHub
sonarcloud[bot] commented on PR #746: URL: https://github.com/apache/struts/pull/746#issuecomment-1700655681 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #747: WW-5340 Introducing OGNL Guard

2023-08-31 Thread via GitHub
sonarcloud[bot] commented on PR #747: URL: https://github.com/apache/struts/pull/747#issuecomment-1700817668 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #741: WW-5341 Ensure exclusion list applies to objects from all ClassLoaders

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #741: URL: https://github.com/apache/struts/pull/741#issuecomment-1698422640 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] kusalk commented on a diff in pull request #741: WW-5341 Ensure exclusion list applies to objects from all ClassLoaders

2023-08-29 Thread via GitHub
kusalk commented on code in PR #741: URL: https://github.com/apache/struts/pull/741#discussion_r1309606372 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -84,16 +86,17 @@ public Object setup(Map context, Object target, Member member, String

[GitHub] [struts] sonarcloud[bot] commented on pull request #743: WW-5339 Enforce exclusion list in CompoundRootAccessor

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #743: URL: https://github.com/apache/struts/pull/743#issuecomment-1698457658 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #743: WW-5339 Enforce exclusion list in CompoundRootAccessor

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #743: URL: https://github.com/apache/struts/pull/743#issuecomment-1698459613 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #741: WW-5341 Ensure exclusion list applies to objects from all ClassLoaders

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #741: URL: https://github.com/apache/struts/pull/741#issuecomment-1698412147 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #747: WW-5340 Introducing OGNL Guard

2023-08-31 Thread via GitHub
sonarcloud[bot] commented on PR #747: URL: https://github.com/apache/struts/pull/747#issuecomment-1700883679 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] sonarcloud[bot] commented on pull request #747: WW-5340 Introducing OGNL Guard

2023-08-31 Thread via GitHub
sonarcloud[bot] commented on PR #747: URL: https://github.com/apache/struts/pull/747#issuecomment-1701190003 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #747: WW-5340 Introducing OGNL Guard

2023-08-31 Thread via GitHub
sonarcloud[bot] commented on PR #747: URL: https://github.com/apache/struts/pull/747#issuecomment-1701166574 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #747: WW-5340 Introducing OGNL Guard

2023-08-31 Thread via GitHub
sonarcloud[bot] commented on PR #747: URL: https://github.com/apache/struts/pull/747#issuecomment-1700982564 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #748: Moves all CI notifications to commits@ list

2023-09-02 Thread via GitHub
sonarcloud[bot] commented on PR #748: URL: https://github.com/apache/struts/pull/748#issuecomment-1703735200 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #748: Moves all CI notifications to commits@ list

2023-09-02 Thread via GitHub
sonarcloud[bot] commented on PR #748: URL: https://github.com/apache/struts/pull/748#issuecomment-1703740721 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sepe81 commented on a diff in pull request #748: Moves all CI notifications to commits@ list

2023-09-02 Thread via GitHub
sepe81 commented on code in PR #748: URL: https://github.com/apache/struts/pull/748#discussion_r1313748031 ## .asf.yaml: ## @@ -3,8 +3,8 @@ notifications: commits: comm...@struts.apache.org # Send all issue emails (new, closed, comments) to issues@ issues:

[GitHub] [struts] sonarcloud[bot] commented on pull request #744: WW-5334 Fix empty chained context names in VelocityManager

2023-08-29 Thread via GitHub
sonarcloud[bot] commented on PR #744: URL: https://github.com/apache/struts/pull/744#issuecomment-1698524370 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [struts] sonarcloud[bot] commented on pull request #743: WW-5339 Enforce exclusion list in CompoundRootAccessor

2023-08-30 Thread via GitHub
sonarcloud[bot] commented on PR #743: URL: https://github.com/apache/struts/pull/743#issuecomment-1698606037 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [struts] kusalk commented on pull request #743: WW-5339 Enforce exclusion list in CompoundRootAccessor

2023-08-30 Thread via GitHub
kusalk commented on PR #743: URL: https://github.com/apache/struts/pull/743#issuecomment-1698608418 Having done some further testing, I don't believe this mitigation to be necessary. There isn't anything inherently dangerous about just loading the class. Class members are still subject to

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-16 Thread via GitHub
lukaszlenart commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1360728599 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCacheFactory.java: ## @@ -19,12 +19,52 @@ * Used by {@link com.opensymphony.xwork2.ognl.OgnlUtil} to create

Re: [PR] Bump opensymphony:sitemesh from 2.4.2 to 2.5.0 [struts]

2023-10-11 Thread via GitHub
dependabot[bot] commented on PR #734: URL: https://github.com/apache/struts/pull/734#issuecomment-1758044223 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Add JDK 21 build [struts]

2023-10-11 Thread via GitHub
sonarcloud[bot] commented on PR #764: URL: https://github.com/apache/struts/pull/764#issuecomment-1758074598 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] List of companies providing commercial support [struts-site]

2023-10-11 Thread via GitHub
asf-ci commented on PR #207: URL: https://github.com/apache/struts-site/pull/207#issuecomment-1758173586 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add JDK 21 build [struts]

2023-10-11 Thread via GitHub
sonarcloud[bot] commented on PR #764: URL: https://github.com/apache/struts/pull/764#issuecomment-1758053209 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] List of companies providing commercial support [struts-site]

2023-10-13 Thread via GitHub
asf-ci commented on PR #207: URL: https://github.com/apache/struts-site/pull/207#issuecomment-1761143003 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] List of companies providing commercial support [struts-site]

2023-10-13 Thread via GitHub
asf-ci commented on PR #207: URL: https://github.com/apache/struts-site/pull/207#issuecomment-1761154359 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] WW-5355 Use LRU cache by default [struts]

2023-10-13 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1358120890 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlDefaultCache.java: ## @@ -30,10 +30,10 @@ public class OgnlDefaultCache implements OgnlCache { private final

Re: [PR] WW-5355 Use LRU cache by default [struts]

2023-10-13 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1358120083 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -705,29 +710,31 @@ public void copy(final Object from, final Object to, final Map c }

Re: [PR] WW-5355 Use LRU cache by default [struts]

2023-10-13 Thread via GitHub
kusalk commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1761335425 @JCgH4164838Gh792C124B5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] WW-5355 Use LRU cache by default [struts]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1761343911 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-16 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1361461252 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCacheFactory.java: ## @@ -19,12 +19,52 @@ * Used by {@link com.opensymphony.xwork2.ognl.OgnlUtil} to create

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-16 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1765603308 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-16 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1361463708 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCacheFactory.java: ## @@ -19,12 +19,52 @@ * Used by {@link com.opensymphony.xwork2.ognl.OgnlUtil} to create

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-16 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1361461252 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCacheFactory.java: ## @@ -19,12 +19,52 @@ * Used by {@link com.opensymphony.xwork2.ognl.OgnlUtil} to create

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-16 Thread via GitHub
kusalk commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1765614800 @lukaszlenart I've updated the PR description :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] WW-5355 Integrate W-TinyLfu cache and use by default [struts]

2023-10-17 Thread via GitHub
lukaszlenart commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1361697311 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCacheFactory.java: ## @@ -19,12 +19,52 @@ * Used by {@link com.opensymphony.xwork2.ognl.OgnlUtil} to create

Re: [PR] Adds script to track visitors with Matomo [struts-site]

2023-10-15 Thread via GitHub
asf-ci commented on PR #208: URL: https://github.com/apache/struts-site/pull/208#issuecomment-1763343034 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763391582 I found that previously, `struts.ognl.expressionCacheLRUMode=true` was not reliable due to setter injection not guaranteeing the order of operations. I've thus refactored the code to use

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359880540 ## core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java: ## @@ -125,6 +127,24 @@ */ public class DefaultConfiguration implements

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359882251 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) {

Re: [PR] Fix conflicting dependencies [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #767: URL: https://github.com/apache/struts/pull/767#issuecomment-1763379679 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763387927 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763394968 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359880540 ## core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java: ## @@ -125,6 +127,24 @@ */ public class DefaultConfiguration implements

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763380211 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763383378 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359879865 ## core/src/main/resources/org/apache/struts2/default.properties: ## @@ -243,25 +243,25 @@ struts.ognl.enableExpressionCache=true ### For expressionCacheLRUMode true, the

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359882251 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) {

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763400837 I've taken care to maintain full API compatibility given that these classes are extension points and thus public API -- This is an automated message from the Apache Git Service. To respond

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763378573 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359880961 ## core/src/main/java/com/opensymphony/xwork2/ognl/DefaultOgnlCacheFactory.java: ## @@ -15,52 +15,86 @@ */ package com.opensymphony.xwork2.ognl; -import

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359881125 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlLRUCache.java: ## @@ -81,7 +81,9 @@ public int getEvictionLimit() { @Override public void

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763396297 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
kusalk commented on code in PR #766: URL: https://github.com/apache/struts/pull/766#discussion_r1359882251 ## core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java: ## @@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) {

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763389989 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] WW-5355 Use W-TinyLfu cache by default [struts]

2023-10-15 Thread via GitHub
sonarcloud[bot] commented on PR #766: URL: https://github.com/apache/struts/pull/766#issuecomment-1763389644 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] [WW-5141] Support for JakartaEE [struts]

2023-10-31 Thread via GitHub
eschulma commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1787974120 @jdyer1 when the time comes I am happy to help test the struts-bootstrap plugin -- our app will likely break it very quickly if there are any problems. -- This is an automated message

Re: [PR] [WW-5141] Support for JakartaEE [struts]

2023-11-01 Thread via GitHub
lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1788701274 @jdyer1 I will prepare the branch in a few days, and then we can consider how to merge/rebase changes from the master branch. @eschulma we will have to release some RC versions

Re: [PR] List of companies providing commercial support [struts-site]

2023-11-01 Thread via GitHub
asf-ci commented on PR #207: URL: https://github.com/apache/struts-site/pull/207#issuecomment-1788781408 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] List of companies providing commercial support [struts-site]

2023-11-01 Thread via GitHub
asf-ci commented on PR #207: URL: https://github.com/apache/struts-site/pull/207#issuecomment-1788791557 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Clarifyes how to access parameters [struts-site]

2023-10-29 Thread via GitHub
gregh3269 commented on PR #210: URL: https://github.com/apache/struts-site/pull/210#issuecomment-1784032920 It has: You can access such params without using JSTL, just use ${param.ParamName} notation in Struts tags. Its not very clear "in Strust tags". I don't think you can

Re: [PR] List of companies providing commercial support [struts-site]

2023-10-28 Thread via GitHub
asf-ci commented on PR #207: URL: https://github.com/apache/struts-site/pull/207#issuecomment-1783879584 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] List of companies providing commercial support [struts-site]

2023-11-01 Thread via GitHub
asf-ci commented on PR #207: URL: https://github.com/apache/struts-site/pull/207#issuecomment-1788805093 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [WW-5333] Refactors AttributeMap [struts]

2023-11-04 Thread via GitHub
sonarcloud[bot] commented on PR #779: URL: https://github.com/apache/struts/pull/779#issuecomment-1793468436 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
kusalk commented on code in PR #780: URL: https://github.com/apache/struts/pull/780#discussion_r1382538745 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -104,126 +105,164 @@ public void restore(Map context, Object target, Member member,

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1793698505 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
kusalk commented on code in PR #780: URL: https://github.com/apache/struts/pull/780#discussion_r1382547971 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -104,126 +105,168 @@ public void restore(Map context, Object target, Member member,

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1793706015 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5350 Implement OGNL Allowlist capability [struts]

2023-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #781: URL: https://github.com/apache/struts/pull/781#issuecomment-1793728384 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] [WW-5333] Refactors AttributeMap [struts]

2023-11-05 Thread via GitHub
kusalk commented on code in PR #779: URL: https://github.com/apache/struts/pull/779#discussion_r1382538252 ## core/src/main/java/org/apache/struts2/dispatcher/DispatcherScope.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] [WW-5333] Refactors AttributeMap [struts]

2023-11-05 Thread via GitHub
kusalk commented on code in PR #779: URL: https://github.com/apache/struts/pull/779#discussion_r1382538252 ## core/src/main/java/org/apache/struts2/dispatcher/DispatcherScope.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1793701515 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
sonarcloud[bot] commented on PR #780: URL: https://github.com/apache/struts/pull/780#issuecomment-1793685163 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
kusalk commented on code in PR #780: URL: https://github.com/apache/struts/pull/780#discussion_r1382538846 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -104,126 +105,164 @@ public void restore(Map context, Object target, Member member,

Re: [PR] WW-5350 Refactor SecurityMemberAccess [struts]

2023-11-05 Thread via GitHub
kusalk commented on code in PR #780: URL: https://github.com/apache/struts/pull/780#discussion_r1382540169 ## core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java: ## @@ -104,126 +105,164 @@ public void restore(Map context, Object target, Member member,

Re: [PR] [WW-5141] Support for JakartaEE [struts]

2023-11-07 Thread via GitHub
jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1799585096 I added several new commits to my fork. Now all code compiles and all unit tests pass, with these 5 new caveats. 1. I ignored freemarker tests (REVERT these commits) -

Re: [PR] Clarifies how #attr works and other scopes [struts-site]

2023-10-31 Thread via GitHub
gregh3269 commented on PR #211: URL: https://github.com/apache/struts-site/pull/211#issuecomment-1786846389 Great, ...possibly the first time this is documented! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [WW-5141] Support for JakartaEE [struts]

2023-10-30 Thread via GitHub
lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1786500506 This is astonishing work  Thanks for taking time and looking into it it. I was planning to prepare a dedicated branch to start working on the Struts 7.x, see this

Re: [PR] Clarifies how to access parameters [struts-site]

2023-10-31 Thread via GitHub
gregh3269 commented on PR #210: URL: https://github.com/apache/struts-site/pull/210#issuecomment-1786783164 Worth remembering (and there is alot on this). Think I was only testing s:if for work fields, most of my fields are in the beans. Think we should be OK here (as I have gone a

Re: [PR] Clarifies how to access parameters [struts-site]

2023-10-31 Thread via GitHub
lukaszlenart commented on PR #210: URL: https://github.com/apache/struts-site/pull/210#issuecomment-1786796157 Great, I will merge this PR but I think clarifying how `#` & `#attr` works, will open another PR :) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Clarifies how #attr works and other scopes [struts-site]

2023-10-31 Thread via GitHub
asf-ci commented on PR #211: URL: https://github.com/apache/struts-site/pull/211#issuecomment-1786832861 Staged site is ready at https://struts.staged.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [WW-5141] Support for JakartaEE [struts]

2023-10-30 Thread via GitHub
lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1786501114 Also I plan to use JDK17 as base version for Struts 7.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Clarifies how #attr works and other scopes [struts-site]

2023-10-31 Thread via GitHub
lukaszlenart commented on PR #211: URL: https://github.com/apache/struts-site/pull/211#issuecomment-1786824423 @gregh3269 FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Clarifyes how to access parameters [struts-site]

2023-10-29 Thread via GitHub
gregh3269 commented on PR #210: URL: https://github.com/apache/struts-site/pull/210#issuecomment-1784050168 missed one #attr. first one on the page ${param.paramName} ...this would be a good interview question lol -- This is an automated message from the Apache Git

Re: [PR] Bump struts2.version from 6.2.0 to 6.3.0.1 [struts-examples]

2023-10-29 Thread via GitHub
lukaszlenart commented on PR #262: URL: https://github.com/apache/struts-examples/pull/262#issuecomment-1784112789 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump org.eclipse.jetty:jetty-maven-plugin from 9.4.46.v20220331 to 11.0.15 [struts-examples]

2023-10-30 Thread via GitHub
dependabot[bot] commented on PR #278: URL: https://github.com/apache/struts-examples/pull/278#issuecomment-1784536488 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

Re: [PR] Clarifyes how to access parameters [struts-site]

2023-10-29 Thread via GitHub
lukaszlenart commented on PR #210: URL: https://github.com/apache/struts-site/pull/210#issuecomment-1784047678 How about now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   3   4   5   >