sonarcloud[bot] commented on PR #745:
URL: https://github.com/apache/struts/pull/745#issuecomment-1698711298
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
kusalk commented on code in PR #741:
URL: https://github.com/apache/struts/pull/741#discussion_r1309606372
##
core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java:
##
@@ -84,16 +86,17 @@ public Object setup(Map context, Object target, Member
member, String
lukaszlenart commented on code in PR #748:
URL: https://github.com/apache/struts/pull/748#discussion_r1313825616
##
.asf.yaml:
##
@@ -3,8 +3,8 @@ notifications:
commits: comm...@struts.apache.org
# Send all issue emails (new, closed, comments) to issues@
issues:
asf-ci commented on PR #202:
URL: https://github.com/apache/struts-site/pull/202#issuecomment-1705965298
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
asf-ci commented on PR #202:
URL: https://github.com/apache/struts-site/pull/202#issuecomment-1705994547
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
asf-ci commented on PR #202:
URL: https://github.com/apache/struts-site/pull/202#issuecomment-1705995269
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
hepptho commented on PR #754:
URL: https://github.com/apache/struts/pull/754#issuecomment-1713724266
Sure, I just requested an account and will create the ticket once I have
access.
I see one of the build checks failed. Is that a known issue? Doesn't seem
like something I could have
lukaszlenart commented on PR #754:
URL: https://github.com/apache/struts/pull/754#issuecomment-1713726039
> Sure, I just requested an account and will create the ticket once I have
access.
Already approved :)
> I see one of the build checks failed. Is that a known issue?
sepe81 commented on PR #734:
URL: https://github.com/apache/struts/pull/734#issuecomment-1695959576
Removing the deprecation sounds great b/c there seems to be some activity
again, so that sitemesh is not dead.
--
This is an automated message from the Apache Git Service.
To respond to
sonarcloud[bot] commented on PR #742:
URL: https://github.com/apache/struts/pull/742#issuecomment-1699147796
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
sonarcloud[bot] commented on PR #742:
URL: https://github.com/apache/struts/pull/742#issuecomment-1699150777
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
asf-ci commented on PR #205:
URL: https://github.com/apache/struts-site/pull/205#issuecomment-1718071754
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-code-scanning[bot] commented on code in PR #746:
URL: https://github.com/apache/struts/pull/746#discussion_r131195
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java:
##
@@ -592,58 +582,55 @@
}
public Object getValue(final String name, final
sonarcloud[bot] commented on PR #746:
URL: https://github.com/apache/struts/pull/746#issuecomment-1700521337
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #746:
URL: https://github.com/apache/struts/pull/746#issuecomment-1700521581
Please retry analysis of this Pull-Request directly on
[SonarCloud](https://sonarcloud.io/project/issues?id=apache_struts=746).
--
This is an automated message from the Apache Git
sonarcloud[bot] commented on PR #746:
URL: https://github.com/apache/struts/pull/746#issuecomment-1700655681
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #747:
URL: https://github.com/apache/struts/pull/747#issuecomment-1700817668
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
sonarcloud[bot] commented on PR #741:
URL: https://github.com/apache/struts/pull/741#issuecomment-1698422640
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
kusalk commented on code in PR #741:
URL: https://github.com/apache/struts/pull/741#discussion_r1309606372
##
core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java:
##
@@ -84,16 +86,17 @@ public Object setup(Map context, Object target, Member
member, String
sonarcloud[bot] commented on PR #743:
URL: https://github.com/apache/struts/pull/743#issuecomment-1698457658
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
sonarcloud[bot] commented on PR #743:
URL: https://github.com/apache/struts/pull/743#issuecomment-1698459613
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
sonarcloud[bot] commented on PR #741:
URL: https://github.com/apache/struts/pull/741#issuecomment-1698412147
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
sonarcloud[bot] commented on PR #747:
URL: https://github.com/apache/struts/pull/747#issuecomment-1700883679
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
sonarcloud[bot] commented on PR #747:
URL: https://github.com/apache/struts/pull/747#issuecomment-1701190003
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #747:
URL: https://github.com/apache/struts/pull/747#issuecomment-1701166574
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #747:
URL: https://github.com/apache/struts/pull/747#issuecomment-1700982564
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #748:
URL: https://github.com/apache/struts/pull/748#issuecomment-1703735200
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #748:
URL: https://github.com/apache/struts/pull/748#issuecomment-1703740721
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sepe81 commented on code in PR #748:
URL: https://github.com/apache/struts/pull/748#discussion_r1313748031
##
.asf.yaml:
##
@@ -3,8 +3,8 @@ notifications:
commits: comm...@struts.apache.org
# Send all issue emails (new, closed, comments) to issues@
issues:
sonarcloud[bot] commented on PR #744:
URL: https://github.com/apache/struts/pull/744#issuecomment-1698524370
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #743:
URL: https://github.com/apache/struts/pull/743#issuecomment-1698606037
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
kusalk commented on PR #743:
URL: https://github.com/apache/struts/pull/743#issuecomment-1698608418
Having done some further testing, I don't believe this mitigation to be
necessary. There isn't anything inherently dangerous about just loading the
class. Class members are still subject to
lukaszlenart commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1360728599
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCacheFactory.java:
##
@@ -19,12 +19,52 @@
* Used by {@link com.opensymphony.xwork2.ognl.OgnlUtil} to create
dependabot[bot] commented on PR #734:
URL: https://github.com/apache/struts/pull/734#issuecomment-1758044223
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
sonarcloud[bot] commented on PR #764:
URL: https://github.com/apache/struts/pull/764#issuecomment-1758074598
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
asf-ci commented on PR #207:
URL: https://github.com/apache/struts-site/pull/207#issuecomment-1758173586
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
sonarcloud[bot] commented on PR #764:
URL: https://github.com/apache/struts/pull/764#issuecomment-1758053209
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
asf-ci commented on PR #207:
URL: https://github.com/apache/struts-site/pull/207#issuecomment-1761143003
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
asf-ci commented on PR #207:
URL: https://github.com/apache/struts-site/pull/207#issuecomment-1761154359
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1358120890
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlDefaultCache.java:
##
@@ -30,10 +30,10 @@
public class OgnlDefaultCache implements OgnlCache {
private final
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1358120083
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java:
##
@@ -705,29 +710,31 @@ public void copy(final Object from, final Object to,
final Map c
}
kusalk commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1761335425
@JCgH4164838Gh792C124B5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sonarcloud[bot] commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1761343911
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1361461252
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCacheFactory.java:
##
@@ -19,12 +19,52 @@
* Used by {@link com.opensymphony.xwork2.ognl.OgnlUtil} to create
sonarcloud[bot] commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1765603308
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1361463708
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCacheFactory.java:
##
@@ -19,12 +19,52 @@
* Used by {@link com.opensymphony.xwork2.ognl.OgnlUtil} to create
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1361461252
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCacheFactory.java:
##
@@ -19,12 +19,52 @@
* Used by {@link com.opensymphony.xwork2.ognl.OgnlUtil} to create
kusalk commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1765614800
@lukaszlenart I've updated the PR description :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lukaszlenart commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1361697311
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlCacheFactory.java:
##
@@ -19,12 +19,52 @@
* Used by {@link com.opensymphony.xwork2.ognl.OgnlUtil} to create
asf-ci commented on PR #208:
URL: https://github.com/apache/struts-site/pull/208#issuecomment-1763343034
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kusalk commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1763391582
I found that previously, `struts.ognl.expressionCacheLRUMode=true` was not
reliable due to setter injection not guaranteeing the order of operations. I've
thus refactored the code to use
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359880540
##
core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java:
##
@@ -125,6 +127,24 @@
*/
public class DefaultConfiguration implements
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359882251
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java:
##
@@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) {
sonarcloud[bot] commented on PR #767:
URL: https://github.com/apache/struts/pull/767#issuecomment-1763379679
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1763387927
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1763394968
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359880540
##
core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java:
##
@@ -125,6 +127,24 @@
*/
public class DefaultConfiguration implements
sonarcloud[bot] commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1763380211
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
sonarcloud[bot] commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1763383378
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359879865
##
core/src/main/resources/org/apache/struts2/default.properties:
##
@@ -243,25 +243,25 @@ struts.ognl.enableExpressionCache=true
### For expressionCacheLRUMode true, the
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359882251
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java:
##
@@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) {
kusalk commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1763400837
I've taken care to maintain full API compatibility given that these classes
are extension points and thus public API
--
This is an automated message from the Apache Git Service.
To respond
sonarcloud[bot] commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1763378573
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359880961
##
core/src/main/java/com/opensymphony/xwork2/ognl/DefaultOgnlCacheFactory.java:
##
@@ -15,52 +15,86 @@
*/
package com.opensymphony.xwork2.ognl;
-import
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359881125
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlLRUCache.java:
##
@@ -81,7 +81,9 @@ public int getEvictionLimit() {
@Override
public void
sonarcloud[bot] commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1763396297
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
kusalk commented on code in PR #766:
URL: https://github.com/apache/struts/pull/766#discussion_r1359882251
##
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlUtil.java:
##
@@ -143,12 +143,18 @@ protected void setEnableExpressionCache(String cache) {
sonarcloud[bot] commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1763389989
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #766:
URL: https://github.com/apache/struts/pull/766#issuecomment-1763389644
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
eschulma commented on PR #778:
URL: https://github.com/apache/struts/pull/778#issuecomment-1787974120
@jdyer1 when the time comes I am happy to help test the struts-bootstrap
plugin -- our app will likely break it very quickly if there are any problems.
--
This is an automated message
lukaszlenart commented on PR #778:
URL: https://github.com/apache/struts/pull/778#issuecomment-1788701274
@jdyer1 I will prepare the branch in a few days, and then we can consider
how to merge/rebase changes from the master branch.
@eschulma we will have to release some RC versions
asf-ci commented on PR #207:
URL: https://github.com/apache/struts-site/pull/207#issuecomment-1788781408
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
asf-ci commented on PR #207:
URL: https://github.com/apache/struts-site/pull/207#issuecomment-1788791557
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gregh3269 commented on PR #210:
URL: https://github.com/apache/struts-site/pull/210#issuecomment-1784032920
It has:
You can access such params without using JSTL, just use ${param.ParamName}
notation in Struts tags.
Its not very clear "in Strust tags". I don't think you can
asf-ci commented on PR #207:
URL: https://github.com/apache/struts-site/pull/207#issuecomment-1783879584
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
asf-ci commented on PR #207:
URL: https://github.com/apache/struts-site/pull/207#issuecomment-1788805093
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
sonarcloud[bot] commented on PR #779:
URL: https://github.com/apache/struts/pull/779#issuecomment-1793468436
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
kusalk commented on code in PR #780:
URL: https://github.com/apache/struts/pull/780#discussion_r1382538745
##
core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java:
##
@@ -104,126 +105,164 @@ public void restore(Map context, Object target, Member
member,
sonarcloud[bot] commented on PR #780:
URL: https://github.com/apache/struts/pull/780#issuecomment-1793698505
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
kusalk commented on code in PR #780:
URL: https://github.com/apache/struts/pull/780#discussion_r1382547971
##
core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java:
##
@@ -104,126 +105,168 @@ public void restore(Map context, Object target, Member
member,
sonarcloud[bot] commented on PR #780:
URL: https://github.com/apache/struts/pull/780#issuecomment-1793706015
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
sonarcloud[bot] commented on PR #781:
URL: https://github.com/apache/struts/pull/781#issuecomment-1793728384
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
kusalk commented on code in PR #779:
URL: https://github.com/apache/struts/pull/779#discussion_r1382538252
##
core/src/main/java/org/apache/struts2/dispatcher/DispatcherScope.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
kusalk commented on code in PR #779:
URL: https://github.com/apache/struts/pull/779#discussion_r1382538252
##
core/src/main/java/org/apache/struts2/dispatcher/DispatcherScope.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
sonarcloud[bot] commented on PR #780:
URL: https://github.com/apache/struts/pull/780#issuecomment-1793701515
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
sonarcloud[bot] commented on PR #780:
URL: https://github.com/apache/struts/pull/780#issuecomment-1793685163
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality Gate
kusalk commented on code in PR #780:
URL: https://github.com/apache/struts/pull/780#discussion_r1382538846
##
core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java:
##
@@ -104,126 +105,164 @@ public void restore(Map context, Object target, Member
member,
kusalk commented on code in PR #780:
URL: https://github.com/apache/struts/pull/780#discussion_r1382540169
##
core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java:
##
@@ -104,126 +105,164 @@ public void restore(Map context, Object target, Member
member,
jdyer1 commented on PR #778:
URL: https://github.com/apache/struts/pull/778#issuecomment-1799585096
I added several new commits to my fork. Now all code compiles and all unit
tests pass, with these 5 new caveats.
1. I ignored freemarker tests (REVERT these commits)
-
gregh3269 commented on PR #211:
URL: https://github.com/apache/struts-site/pull/211#issuecomment-1786846389
Great, ...possibly the first time this is documented!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lukaszlenart commented on PR #778:
URL: https://github.com/apache/struts/pull/778#issuecomment-1786500506
This is astonishing work Thanks for taking time and looking into it it.
I was planning to prepare a dedicated branch to start working on the Struts
7.x, see this
gregh3269 commented on PR #210:
URL: https://github.com/apache/struts-site/pull/210#issuecomment-1786783164
Worth remembering (and there is alot on this). Think I was only testing
s:if for work fields, most of my fields are in the beans.
Think we should be OK here (as I have gone a
lukaszlenart commented on PR #210:
URL: https://github.com/apache/struts-site/pull/210#issuecomment-1786796157
Great, I will merge this PR but I think clarifying how `#` & `#attr` works,
will open another PR :)
--
This is an automated message from the Apache Git Service.
To respond to
asf-ci commented on PR #211:
URL: https://github.com/apache/struts-site/pull/211#issuecomment-1786832861
Staged site is ready at https://struts.staged.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lukaszlenart commented on PR #778:
URL: https://github.com/apache/struts/pull/778#issuecomment-1786501114
Also I plan to use JDK17 as base version for Struts 7.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lukaszlenart commented on PR #211:
URL: https://github.com/apache/struts-site/pull/211#issuecomment-1786824423
@gregh3269 FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gregh3269 commented on PR #210:
URL: https://github.com/apache/struts-site/pull/210#issuecomment-1784050168
missed one #attr. first one on the page
${param.paramName}
...this would be a good interview question lol
--
This is an automated message from the Apache Git
lukaszlenart commented on PR #262:
URL: https://github.com/apache/struts-examples/pull/262#issuecomment-1784112789
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #278:
URL: https://github.com/apache/struts-examples/pull/278#issuecomment-1784536488
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
lukaszlenart commented on PR #210:
URL: https://github.com/apache/struts-site/pull/210#issuecomment-1784047678
How about now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1 - 100 of 457 matches
Mail list logo