[jira] [Commented] (WW-5024) HttpParameters.Builder can wrap objects in two layers of Parameters

2019-04-01 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806493#comment-16806493
 ] 

Hudson commented on WW-5024:


SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #248 (See 
[https://builds.apache.org/job/Struts-master-JDK8/248/])
Forward port fix for WW-5024 to 2.6: - NOTE: If the PR is accepted 
(43964333+jcgh4164838gh792c124b5: rev 3e11e1db4775a5f4f21d57f0361ea06ed06e1578)
* (edit) 
core/src/main/java/org/apache/struts2/interceptor/ActionMappingParametersInterceptor.java
* (edit) core/src/main/java/org/apache/struts2/dispatcher/HttpParameters.java
* (add) 
core/src/test/java/org/apache/struts2/interceptor/ActionMappingParametersInterceptorTest.java


> HttpParameters.Builder can wrap objects in two layers of Parameters
> ---
>
> Key: WW-5024
> URL: https://issues.apache.org/jira/browse/WW-5024
> Project: Struts 2
>  Issue Type: Bug
>  Components: Value Stack
>Affects Versions: 2.5.20
>Reporter: Robert Hollencamp
>Priority: Major
> Fix For: 2.5.21, 2.6
>
>
> Parameters added to ActionMapping can end up wrapped in Parameter twice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5024) HttpParameters.Builder can wrap objects in two layers of Parameters

2019-04-01 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806475#comment-16806475
 ] 

ASF GitHub Bot commented on WW-5024:


lukaszlenart commented on pull request #346: Forward port fix for WW-5024 to 
2.6:
URL: https://github.com/apache/struts/pull/346
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HttpParameters.Builder can wrap objects in two layers of Parameters
> ---
>
> Key: WW-5024
> URL: https://issues.apache.org/jira/browse/WW-5024
> Project: Struts 2
>  Issue Type: Bug
>  Components: Value Stack
>Affects Versions: 2.5.20
>Reporter: Robert Hollencamp
>Priority: Major
> Fix For: 2.5.21, 2.6
>
>
> Parameters added to ActionMapping can end up wrapped in Parameter twice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5024) HttpParameters.Builder can wrap objects in two layers of Parameters

2019-04-01 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806477#comment-16806477
 ] 

ASF subversion and git services commented on WW-5024:
-

Commit 91c6a6f88f3d2cd51163501cf4553e6ecb1115ea in struts's branch 
refs/heads/master from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=91c6a6f ]

Merge pull request #346 from JCgH4164838Gh792C124B5/localS2_26x_B4

Forward port fix for WW-5024 to 2.6:

> HttpParameters.Builder can wrap objects in two layers of Parameters
> ---
>
> Key: WW-5024
> URL: https://issues.apache.org/jira/browse/WW-5024
> Project: Struts 2
>  Issue Type: Bug
>  Components: Value Stack
>Affects Versions: 2.5.20
>Reporter: Robert Hollencamp
>Priority: Major
> Fix For: 2.5.21, 2.6
>
>
> Parameters added to ActionMapping can end up wrapped in Parameter twice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5024) HttpParameters.Builder can wrap objects in two layers of Parameters

2019-04-01 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806476#comment-16806476
 ] 

ASF subversion and git services commented on WW-5024:
-

Commit 3e11e1db4775a5f4f21d57f0361ea06ed06e1578 in struts's branch 
refs/heads/master from JCgH4164838Gh792C124B5
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=3e11e1d ]

Forward port fix for WW-5024 to 2.6:
- NOTE: If the PR is accepted please credit Robert Hollencamp (Github 
@rhollencamp) for this change
as he found the issue, proposed a solution for 2.6 (master), and opened 
the JIRA.
- Updated HttpParameters, ActionMappingParametersInterceptor to prevent 
multi-level Parameter wrapping from occuring.
- Updated HttpParameters create(), build() and buildNoNestedWrapping() to 
replace redundant type operators with <> based on IDE hint.
- Made HttpParameters parameters member final based on IDE hint.
- Added a new ActionMappingParametersInterceptorTest to verify the fix.


> HttpParameters.Builder can wrap objects in two layers of Parameters
> ---
>
> Key: WW-5024
> URL: https://issues.apache.org/jira/browse/WW-5024
> Project: Struts 2
>  Issue Type: Bug
>  Components: Value Stack
>Affects Versions: 2.5.20
>Reporter: Robert Hollencamp
>Priority: Major
> Fix For: 2.5.21, 2.6
>
>
> Parameters added to ActionMapping can end up wrapped in Parameter twice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5024) HttpParameters.Builder can wrap objects in two layers of Parameters

2019-03-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806364#comment-16806364
 ] 

ASF GitHub Bot commented on WW-5024:


JCgH4164838Gh792C124B5 commented on pull request #346: Forward port fix for 
WW-5024 to 2.6:
URL: https://github.com/apache/struts/pull/346
 
 
   Forward port fix for WW-5024 to 2.6:
   - **NOTE**: _If the PR is accepted_ **please credit Robert Hollencamp 
(Github @rhollencamp)** for this change
   as he found the issue, proposed a solution for 2.6 (master), and 
opened the JIRA.
   - Updated HttpParameters, ActionMappingParametersInterceptor to prevent 
multi-level Parameter wrapping from occuring.
   - Updated HttpParameters create(), build() and buildNoNestedWrapping() to 
replace redundant type operators with <> based on IDE hint.
   - Made HttpParameters parameters member final based on IDE hint.
   - Added a new ActionMappingParametersInterceptorTest to verify the fix.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HttpParameters.Builder can wrap objects in two layers of Parameters
> ---
>
> Key: WW-5024
> URL: https://issues.apache.org/jira/browse/WW-5024
> Project: Struts 2
>  Issue Type: Bug
>  Components: Value Stack
>Affects Versions: 2.5.20
>Reporter: Robert Hollencamp
>Priority: Major
>
> Parameters added to ActionMapping can end up wrapped in Parameter twice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5024) HttpParameters.Builder can wrap objects in two layers of Parameters

2019-03-29 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804620#comment-16804620
 ] 

ASF GitHub Bot commented on WW-5024:


lukaszlenart commented on pull request #340: WW-5024 
ActionMappingParametersInterceptor double wrapping
URL: https://github.com/apache/struts/pull/340
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HttpParameters.Builder can wrap objects in two layers of Parameters
> ---
>
> Key: WW-5024
> URL: https://issues.apache.org/jira/browse/WW-5024
> Project: Struts 2
>  Issue Type: Bug
>  Components: Value Stack
>Affects Versions: 2.5.20
>Reporter: Robert Hollencamp
>Priority: Major
>
> Parameters added to ActionMapping can end up wrapped in Parameter twice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5024) HttpParameters.Builder can wrap objects in two layers of Parameters

2019-03-29 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804618#comment-16804618
 ] 

ASF subversion and git services commented on WW-5024:
-

Commit 02625740952b1e673402e21d52320fe41dbda500 in struts's branch 
refs/heads/struts-2-5-x from JCgH4164838Gh792C124B5
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=0262574 ]

Proposed fix for WW-5024 in the 2.5.x branch: (#343)

- NOTE: If the PR is accepted please credit Robert Hollencamp (Github 
@rhollencamp) for this change
as he found the issue, proposed a solution for 2.6 (master), and opened 
the JIRA.
- Updated HttpParameters, ActionMappingParametersInterceptor to prevent 
multi-level Parameter wrapping from occuring.
- Added a new ActionMappingParametersInterceptorTest to verify the fix.

> HttpParameters.Builder can wrap objects in two layers of Parameters
> ---
>
> Key: WW-5024
> URL: https://issues.apache.org/jira/browse/WW-5024
> Project: Struts 2
>  Issue Type: Bug
>  Components: Value Stack
>Affects Versions: 2.5.20
>Reporter: Robert Hollencamp
>Priority: Major
>
> Parameters added to ActionMapping can end up wrapped in Parameter twice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5024) HttpParameters.Builder can wrap objects in two layers of Parameters

2019-03-29 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804617#comment-16804617
 ] 

ASF GitHub Bot commented on WW-5024:


lukaszlenart commented on pull request #343: Proposed fix for WW-5024 in the 
2.5.x branch:
URL: https://github.com/apache/struts/pull/343
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HttpParameters.Builder can wrap objects in two layers of Parameters
> ---
>
> Key: WW-5024
> URL: https://issues.apache.org/jira/browse/WW-5024
> Project: Struts 2
>  Issue Type: Bug
>  Components: Value Stack
>Affects Versions: 2.5.20
>Reporter: Robert Hollencamp
>Priority: Major
>
> Parameters added to ActionMapping can end up wrapped in Parameter twice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5024) HttpParameters.Builder can wrap objects in two layers of Parameters

2019-03-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803609#comment-16803609
 ] 

ASF GitHub Bot commented on WW-5024:


JCgH4164838Gh792C124B5 commented on pull request #343: Proposed fix for WW-5024 
in the 2.5.x branch:
URL: https://github.com/apache/struts/pull/343
 
 
   Proposed fix for WW-5024 in the 2.5.x branch:
   - **NOTE**: If the PR is accepted **_please credit_ Robert Hollencamp 
(Github @rhollencamp) for this change**
   as he found the issue, proposed a solution for 2.6 (master), and 
opened the JIRA.
   - Updated HttpParameters, ActionMappingParametersInterceptor to prevent 
multi-level Parameter wrapping from occuring.
   - Added a new ActionMappingParametersInterceptorTest to verify the fix.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HttpParameters.Builder can wrap objects in two layers of Parameters
> ---
>
> Key: WW-5024
> URL: https://issues.apache.org/jira/browse/WW-5024
> Project: Struts 2
>  Issue Type: Bug
>  Components: Value Stack
>Affects Versions: 2.5.20
>Reporter: Robert Hollencamp
>Priority: Major
>
> Parameters added to ActionMapping can end up wrapped in Parameter twice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WW-5024) HttpParameters.Builder can wrap objects in two layers of Parameters

2019-03-13 Thread Robert Hollencamp (JIRA)


[ 
https://issues.apache.org/jira/browse/WW-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791987#comment-16791987
 ] 

Robert Hollencamp commented on WW-5024:
---

https://github.com/apache/struts/pull/340

> HttpParameters.Builder can wrap objects in two layers of Parameters
> ---
>
> Key: WW-5024
> URL: https://issues.apache.org/jira/browse/WW-5024
> Project: Struts 2
>  Issue Type: Bug
>  Components: Value Stack
>Affects Versions: 2.5.20
>Reporter: Robert Hollencamp
>Priority: Major
>
> Parameters added to ActionMapping can end up wrapped in Parameter twice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)