[jira] [Commented] (SVN-4655) configure: add zlib discovery through pkg-config
[
https://issues.apache.org/jira/browse/SVN-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503938#comment-15503938
]
Michael Osipov commented on SVN-4655:
-
Fine, I will report it to the list. Seems like every Apache project has
different rules.
> configure: add zlib discovery through pkg-config
>
>
> Key: SVN-4655
> URL: https://issues.apache.org/jira/browse/SVN-4655
> Project: Subversion
> Issue Type: Improvement
> Components: compile, install
>Affects Versions: 1.9.4, 1.10.0
> Environment: HP-UX 11.31
>Reporter: Michael Osipov
> Attachments: SVN-4655.patch
>
>
> {{configure}} does not find zlib even if {{--with-zlib=/path...}} is provided
> because {{$zlib_prefix/lib}} does not exist on HP-UX but only
> {{$zlib_prefix/lib/hpux32}}. By using {{pkg-config}} this can actually easily
> solved.
> See attached patch which fixes the issue by probing provided prefix, if not
> try {{pkg-config}} and builtin. The idea was borrowed from {{serf.m4}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SVN-4655) configure: add zlib discovery through pkg-config
[
https://issues.apache.org/jira/browse/SVN-4655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503739#comment-15503739
]
Ivan Zhakov commented on SVN-4655:
--
Hi Mike,
Recommended way for submitting patches is post them to dev@s.a.o mailing list:
http://subversion.apache.org/docs/community-guide/general.html#patches-submission
> configure: add zlib discovery through pkg-config
>
>
> Key: SVN-4655
> URL: https://issues.apache.org/jira/browse/SVN-4655
> Project: Subversion
> Issue Type: Improvement
> Components: compile, install
>Affects Versions: 1.9.4, 1.10.0
> Environment: HP-UX 11.31
>Reporter: Michael Osipov
> Attachments: SVN-4655.patch
>
>
> {{configure}} does not find zlib even if {{--with-zlib=/path...}} is provided
> because {{$zlib_prefix/lib}} does not exist on HP-UX but only
> {{$zlib_prefix/lib/hpux32}}. By using {{pkg-config}} this can actually easily
> solved.
> See attached patch which fixes the issue by probing provided prefix, if not
> try {{pkg-config}} and builtin. The idea was borrowed from {{serf.m4}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SVN-4654) configure: command substitution for SVN_REMOVE_STANDARD_LIB_DIRS fails with POSIX backticks on HP-UX
[
https://issues.apache.org/jira/browse/SVN-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502719#comment-15502719
]
Daniel Shahaf commented on SVN-4654:
It's trying to execute "/lib64" with arguments "/usr/lib" and
"/usr/lib64".
I think your shell parses the code
LDFLAGS="$LDFLAGS ` input_flags="$apr_ldflags" output_flags=""
filtered_dirs="/lib /lib64 /usr/lib /usr/lib64"
as a pre-command assignment «LDFLAGS="…" /lib64 /usr/lib /usr/lib64»,
i.e., an instance of the "set an environment variable for one command"
syntax.
> configure: command substitution for SVN_REMOVE_STANDARD_LIB_DIRS fails with
> POSIX backticks on HP-UX
>
>
> Key: SVN-4654
> URL: https://issues.apache.org/jira/browse/SVN-4654
> Project: Subversion
> Issue Type: Bug
> Components: compile, install
>Affects Versions: 1.9.4, trunk
> Environment: $ uname -a
> HP-UX blnn724x B.11.31 U ia64 HP-UX
>Reporter: Michael Osipov
> Attachments: SVN-4654.patch, configure-reduced.tar.gz,
> configure.err.tar.gz
>
>
> When running {{configure}} on HP-UX, you see several times
> {{./configure\[4880\]: : Execute permission denied.}} and
> {{./configure\[4880\]: /lib64: not found.}}.
> This is caused by having the command substitution perfomed by backticks
> {{LDFLAGS="`SVN_REMOVE_STANDARD_LIB_DIR(...)`"}} and not with standard POSIX
> {{$()}}.
> See attached trace output w/o patch and with patch applied.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SVN-4654) configure: command substitution for SVN_REMOVE_STANDARD_LIB_DIRS fails with POSIX backticks on HP-UX
[
https://issues.apache.org/jira/browse/SVN-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SVN-4654:
Attachment: configure-reduced.tar.gz
As promised, I have reduced the macro to a minimal reproducible amount of code:
{code:none}
Index: build/ac-macros/svn-macros.m4
===
--- build/ac-macros/svn-macros.m4 (Revision 1761392)
+++ build/ac-macros/svn-macros.m4 (Arbeitskopie)
@@ -106,21 +106,6 @@
input_flags="$1"
output_flags=""
filtered_dirs="/lib /lib64 /usr/lib /usr/lib64"
- for flag in $input_flags; do
-filter="no"
-for dir in $filtered_dirs; do
- if test "$flag" = "-L$dir" || test "$flag" = "-L$dir/"; then
-filter="yes"
-break
- fi
-done
-if test "$filter" = "no"; then
- output_flags="$output_flags $flag"
-fi
- done
- if test -n "$output_flags"; then
-printf "%s" "${output_flags# }"
- fi
])
AC_DEFUN([SVN_CHECK_FOR_ATOMIC_BUILTINS],
{code}
Attached is the trace file along with the genereated {{configure}} script.
> configure: command substitution for SVN_REMOVE_STANDARD_LIB_DIRS fails with
> POSIX backticks on HP-UX
>
>
> Key: SVN-4654
> URL: https://issues.apache.org/jira/browse/SVN-4654
> Project: Subversion
> Issue Type: Bug
> Components: compile, install
>Affects Versions: 1.9.4, trunk
> Environment: $ uname -a
> HP-UX blnn724x B.11.31 U ia64 HP-UX
>Reporter: Michael Osipov
> Attachments: SVN-4654.patch, configure-reduced.tar.gz,
> configure.err.tar.gz
>
>
> When running {{configure}} on HP-UX, you see several times
> {{./configure\[4880\]: : Execute permission denied.}} and
> {{./configure\[4880\]: /lib64: not found.}}.
> This is caused by having the command substitution perfomed by backticks
> {{LDFLAGS="`SVN_REMOVE_STANDARD_LIB_DIR(...)`"}} and not with standard POSIX
> {{$()}}.
> See attached trace output w/o patch and with patch applied.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SVN-4654) configure: command substitution for SVN_REMOVE_STANDARD_LIB_DIRS fails with POSIX backticks on HP-UX
[
https://issues.apache.org/jira/browse/SVN-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502576#comment-15502576
]
Michael Osipov commented on SVN-4654:
-
Daniel, the problems aren't the for loops but solely {{filtered_dirs}}. I will
create a recuded macro with that error and upload the generated {{configure}}
script along with the trace.
> configure: command substitution for SVN_REMOVE_STANDARD_LIB_DIRS fails with
> POSIX backticks on HP-UX
>
>
> Key: SVN-4654
> URL: https://issues.apache.org/jira/browse/SVN-4654
> Project: Subversion
> Issue Type: Bug
> Components: compile, install
>Affects Versions: 1.9.4, trunk
> Environment: $ uname -a
> HP-UX blnn724x B.11.31 U ia64 HP-UX
>Reporter: Michael Osipov
> Attachments: SVN-4654.patch, configure.err.tar.gz
>
>
> When running {{configure}} on HP-UX, you see several times
> {{./configure\[4880\]: : Execute permission denied.}} and
> {{./configure\[4880\]: /lib64: not found.}}.
> This is caused by having the command substitution perfomed by backticks
> {{LDFLAGS="`SVN_REMOVE_STANDARD_LIB_DIR(...)`"}} and not with standard POSIX
> {{$()}}.
> See attached trace output w/o patch and with patch applied.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
