[jira] [Closed] (SYSTEMML-2480) Too aggressive reuse of vectors in codegen row templates
[ https://issues.apache.org/jira/browse/SYSTEMML-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Boehm closed SYSTEMML-2480. Resolution: Fixed Assignee: Matthias Boehm Fix Version/s: SystemML 1.2 > Too aggressive reuse of vectors in codegen row templates > > > Key: SYSTEMML-2480 > URL: https://issues.apache.org/jira/browse/SYSTEMML-2480 > Project: SystemML > Issue Type: Bug >Reporter: Matthias Boehm >Assignee: Matthias Boehm >Priority: Major > Fix For: SystemML 1.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SYSTEMML-2067) Add support for convolution operations (forward/backward)
[ https://issues.apache.org/jira/browse/SYSTEMML-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Boehm closed SYSTEMML-2067. Resolution: Fixed Fix Version/s: SystemML 1.2 > Add support for convolution operations (forward/backward) > - > > Key: SYSTEMML-2067 > URL: https://issues.apache.org/jira/browse/SYSTEMML-2067 > Project: SystemML > Issue Type: Sub-task >Reporter: Matthias Boehm >Assignee: Matthias Boehm >Priority: Major > Fix For: SystemML 1.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SYSTEMML-2482) Unexpected cleanup of list object
[
https://issues.apache.org/jira/browse/SYSTEMML-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567477#comment-16567477
]
LI Guobao commented on SYSTEMML-2482:
-
I just saw your latest commit. Thanks for helping me. And yes. So we keep the
current behavior.
> Unexpected cleanup of list object
> -
>
> Key: SYSTEMML-2482
> URL: https://issues.apache.org/jira/browse/SYSTEMML-2482
> Project: SystemML
> Issue Type: Bug
>Reporter: LI Guobao
>Priority: Major
>
> Some unexpected overhead occurred when running the
> {{*testParamservASPEpochDisjointContiguous*}} in test
> {{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
> It took more time to finish the test in the case that the output of
> instruction is a list which will be cleaned up after the execution. However,
> the matrices referenced by the list should be pinned to avoid being cleaned
> up. And this issue is related to
> [SYSTEMML-2481|https://issues.apache.org/jira/browse/SYSTEMML-2481]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SYSTEMML-2482) Unexpected cleanup of list object
[
https://issues.apache.org/jira/browse/SYSTEMML-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567470#comment-16567470
]
LI Guobao commented on SYSTEMML-2482:
-
[~mboehm7] well, sorry about the unspecific description. Actually, I just found
that the data status in list object is no longer used (i.e., null or array of
false). Because, before that commit, all the matrices of the list output will
be pinned in the vars table and the pinned status will be saved in this boolean
array. And I just fix the problem of eviction by changing the logic of
cleanning up the list object with its data status.
> Unexpected cleanup of list object
> -
>
> Key: SYSTEMML-2482
> URL: https://issues.apache.org/jira/browse/SYSTEMML-2482
> Project: SystemML
> Issue Type: Bug
>Reporter: LI Guobao
>Priority: Major
>
> Some unexpected overhead occurred when running the
> {{*testParamservASPEpochDisjointContiguous*}} in test
> {{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
> It took more time to finish the test in the case that the output of
> instruction is a list which will be cleaned up after the execution. However,
> the matrices referenced by the list should be pinned to avoid being cleaned
> up. And this issue is related to
> [SYSTEMML-2481|https://issues.apache.org/jira/browse/SYSTEMML-2481]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SYSTEMML-2482) Unexpected cleanup of list object
[
https://issues.apache.org/jira/browse/SYSTEMML-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567464#comment-16567464
]
Matthias Boehm commented on SYSTEMML-2482:
--
OK I think you were talking about unnecessary evictions. The reason was that
paramserv relies on the status of list objects which is no longer used or
maintained. However, I now temporarily enabled it again for paramserv to
restore the original behavior. Down the road we should completely remove this
status and all related usage.
> Unexpected cleanup of list object
> -
>
> Key: SYSTEMML-2482
> URL: https://issues.apache.org/jira/browse/SYSTEMML-2482
> Project: SystemML
> Issue Type: Bug
>Reporter: LI Guobao
>Priority: Major
>
> Some unexpected overhead occurred when running the
> {{*testParamservASPEpochDisjointContiguous*}} in test
> {{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
> It took more time to finish the test in the case that the output of
> instruction is a list which will be cleaned up after the execution. However,
> the matrices referenced by the list should be pinned to avoid being cleaned
> up. And this issue is related to
> [SYSTEMML-2481|https://issues.apache.org/jira/browse/SYSTEMML-2481]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SYSTEMML-2482) Unexpected cleanup of list object
[
https://issues.apache.org/jira/browse/SYSTEMML-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567381#comment-16567381
]
Matthias Boehm commented on SYSTEMML-2482:
--
Could you please be more specific what issue you encountered and how it
manifests itself as it's important to properly cleanup these lists; otherwise
there are unnecessary evictions in the general case. In any case, we might need
to adapt the cleanup logic in paramserv accordingly.
> Unexpected cleanup of list object
> -
>
> Key: SYSTEMML-2482
> URL: https://issues.apache.org/jira/browse/SYSTEMML-2482
> Project: SystemML
> Issue Type: Bug
>Reporter: LI Guobao
>Priority: Major
>
> Some unexpected overhead occurred when running the
> {{*testParamservASPEpochDisjointContiguous*}} in test
> {{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
> It took more time to finish the test in the case that the output of
> instruction is a list which will be cleaned up after the execution. However,
> the matrices referenced by the list should be pinned to avoid being cleaned
> up. And this issue is related to
> [SYSTEMML-2481|https://issues.apache.org/jira/browse/SYSTEMML-2481]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SYSTEMML-2482) Unexpected cleanup of list object
[
https://issues.apache.org/jira/browse/SYSTEMML-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
LI Guobao updated SYSTEMML-2482:
Description: Some unexpected overhead occurred when running the
{{*testParamservASPEpochDisjointContiguous*}} in test
{{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
It took more time to finish the test in the case that the output of
instruction is a list which will be cleaned up after the execution. And this
issue is related to
[SYSTEMML-2481|https://issues.apache.org/jira/browse/SYSTEMML-2481] (was:
Some unexpected overhead occurred when running the
{{*testParamservASPEpochDisjointContiguous*}} in test
{{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
It took more time to finish the test in the case that the output of
instruction is a list which will be cleaned up after the execution. And this
issue is related to
[ticket|https://issues.apache.org/jira/browse/SYSTEMML-2481] )
> Unexpected cleanup of list object
> -
>
> Key: SYSTEMML-2482
> URL: https://issues.apache.org/jira/browse/SYSTEMML-2482
> Project: SystemML
> Issue Type: Bug
>Reporter: LI Guobao
>Priority: Major
>
> Some unexpected overhead occurred when running the
> {{*testParamservASPEpochDisjointContiguous*}} in test
> {{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
> It took more time to finish the test in the case that the output of
> instruction is a list which will be cleaned up after the execution. And this
> issue is related to
> [SYSTEMML-2481|https://issues.apache.org/jira/browse/SYSTEMML-2481]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SYSTEMML-2482) Unexpected cleanup of list object
[
https://issues.apache.org/jira/browse/SYSTEMML-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
LI Guobao updated SYSTEMML-2482:
Description: Some unexpected overhead occurred when running the
{{*testParamservASPEpochDisjointContiguous*}} in test
{{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
It took more time to finish the test in the case that the output of
instruction is a list which will be cleaned up after the execution. And this
issue is related to
[ticket|https://issues.apache.org/jira/browse/SYSTEMML-2481] (was: Some
unexpected overhead occurred when running the
{{*testParamservASPEpochDisjointContiguous*}} in test
{{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
It took more time to finish the test in the case that the output of
instruction is a list which will be cleaned up after the execution.)
> Unexpected cleanup of list object
> -
>
> Key: SYSTEMML-2482
> URL: https://issues.apache.org/jira/browse/SYSTEMML-2482
> Project: SystemML
> Issue Type: Bug
>Reporter: LI Guobao
>Priority: Major
>
> Some unexpected overhead occurred when running the
> {{*testParamservASPEpochDisjointContiguous*}} in test
> {{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
> It took more time to finish the test in the case that the output of
> instruction is a list which will be cleaned up after the execution. And this
> issue is related to
> [ticket|https://issues.apache.org/jira/browse/SYSTEMML-2481]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SYSTEMML-2482) Unexpected cleanup of list object
[
https://issues.apache.org/jira/browse/SYSTEMML-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
LI Guobao updated SYSTEMML-2482:
Description: Some unexpected overhead occurred when running the
{{*testParamservASPEpochDisjointContiguous*}} in test
{{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
It took more time to finish the test in the case that the output of
instruction is a list which will be cleaned up after the execution. (was: Some
unexpected overhead occurred when running the
{{testParamservASPEpochDisjointContiguous}} in test
{{org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest}}.
It took more time to finish the test in the case that the output of instruction
is a list which will be cleaned up after the execution.)
> Unexpected cleanup of list object
> -
>
> Key: SYSTEMML-2482
> URL: https://issues.apache.org/jira/browse/SYSTEMML-2482
> Project: SystemML
> Issue Type: Bug
>Reporter: LI Guobao
>Priority: Major
>
> Some unexpected overhead occurred when running the
> {{*testParamservASPEpochDisjointContiguous*}} in test
> {{*org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest*}}.
> It took more time to finish the test in the case that the output of
> instruction is a list which will be cleaned up after the execution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SYSTEMML-2482) Unexpected cleanup of list object
[
https://issues.apache.org/jira/browse/SYSTEMML-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
LI Guobao updated SYSTEMML-2482:
Description: Some unexpected overhead occurred when running the
{{testParamservASPEpochDisjointContiguous}} in test
{{org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest}}.
It took more time to finish the test in the case that the output of instruction
is a list which will be cleaned up after the execution.
> Unexpected cleanup of list object
> -
>
> Key: SYSTEMML-2482
> URL: https://issues.apache.org/jira/browse/SYSTEMML-2482
> Project: SystemML
> Issue Type: Bug
>Reporter: LI Guobao
>Priority: Major
>
> Some unexpected overhead occurred when running the
> {{testParamservASPEpochDisjointContiguous}} in test
> {{org.apache.sysml.test.integration.functions.paramserv.ParamservSparkNNTest}}.
> It took more time to finish the test in the case that the output of
> instruction is a list which will be cleaned up after the execution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SYSTEMML-2482) Unexpected cleanup of list object
LI Guobao created SYSTEMML-2482: --- Summary: Unexpected cleanup of list object Key: SYSTEMML-2482 URL: https://issues.apache.org/jira/browse/SYSTEMML-2482 Project: SystemML Issue Type: Bug Reporter: LI Guobao -- This message was sent by Atlassian JIRA (v7.6.3#76005)
