[GitHub] tajo pull request #1055: Dictionary encoded text in ORC scanner may cause in...

2018-07-12 Thread jinossy
Github user jinossy closed the pull request at: https://github.com/apache/tajo/pull/1055 ---

[GitHub] tajo issue #1055: Dictionary encoded text in ORC scanner may cause incorrect...

2018-07-12 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1055 Thank you for your quick review! ---

[GitHub] tajo pull request #1055: Dictionary encoded text in ORC scanner may cause in...

2018-07-12 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/1055 Dictionary encoded text in ORC scanner may cause incorrect result. See the issue: https://issues.apache.org/jira/browse/TAJO-2189 You can merge this pull request into a Git repository by running

[GitHub] tajo pull request #1054: TAJO-2188: Can't start tajo daemon on HDP,CDH

2018-07-11 Thread jinossy
Github user jinossy closed the pull request at: https://github.com/apache/tajo/pull/1054 ---

[GitHub] tajo pull request #1054: TAJO-2188: Can't start tajo daemon on HDP,CDH

2018-07-10 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/1054 TAJO-2188: Can't start tajo daemon on HDP,CDH https://issues.apache.org/jira/browse/TAJO-2188 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] tajo issue #1046: TAJO-2179: Add a regular expression scanner and appender.

2016-08-29 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1046 Thank you for your review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tajo issue #1048: TAJO-2180: Disable unsetting timezone property in HiveCata...

2016-08-29 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1048 +1 related to https://github.com/apache/tajo/pull/1045 Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tajo issue #1044: TAJO-1488: Implement KafkaTablespace

2016-08-29 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1044 +1 travis failure is not related this PR. I was create to https://issues.apache.org/jira/browse/TAJO-1635 Thank you for your contribution!! --- If your project is set up for it, you can

[GitHub] tajo issue #1043: TAJO-1487: Kafka Scanner for kafka strage.

2016-08-28 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1043 +1 LGTM!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tajo issue #1024: TAJO-2069: Implement finding the total size of all objects...

2016-08-28 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1024 rebase please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tajo issue #1047: TAJO-2174: Implement HiveCatalogStore#alterTable

2016-08-28 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1047 +1 Thank you for your quick fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tajo issue #1045: TAJO-2170: Disable unsetting timezone property

2016-08-28 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1045 +1 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tajo issue #1047: TAJO-2174: Implement HiveCatalogStore#alterTable

2016-08-28 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1047 Thank you for contribution! Looks good to me! I left a trivial comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tajo pull request #1047: TAJO-2174: Implement HiveCatalogStore#alterTable

2016-08-28 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1047#discussion_r76527398 --- Diff: tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java --- @@ -789,6 +793,44 @@ private void

[GitHub] tajo pull request #1045: TAJO-2170: Disable unsetting timezone property

2016-08-28 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1045#discussion_r76527387 --- Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java --- @@ -1110,12 +1113,20 @@ private void

[GitHub] tajo issue #1046: TAJO-2179: Add a regular expression scanner and appender.

2016-08-28 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1046 Could anyone review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tajo issue #1044: TAJO-1488: Implement KafkaTablespace

2016-08-28 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1044 rebase please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tajo issue #1043: TAJO-1487: Kafka Scanner for kafka strage.

2016-08-28 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1043 rebase please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tajo issue #1041: TAJO-1480: Kafka Consumer for kafka strage.

2016-08-28 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1041 +1 Looks great to me! Thank you for contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tajo pull request #1043: TAJO-1487: Kafka Scanner for kafka strage.

2016-08-17 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1043#discussion_r75111322 --- Diff: tajo-storage/tajo-storage-kafka/src/main/java/org/apache/tajo/storage/kafka/KafkaScanner.java --- @@ -0,0 +1,274 @@ +/** + * Licensed

[GitHub] tajo pull request #1043: TAJO-1487: Kafka Scanner for kafka strage.

2016-08-17 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1043#discussion_r75110466 --- Diff: tajo-storage/tajo-storage-kafka/src/main/java/org/apache/tajo/storage/kafka/KafkaFragment.java --- @@ -0,0 +1,199 @@ +/** + * Licensed

[GitHub] tajo pull request #1041: TAJO-1480: Kafka Consumer for kafka strage.

2016-08-17 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1041#discussion_r75109669 --- Diff: tajo-storage/tajo-storage-kafka/pom.xml --- @@ -0,0 +1,195 @@ + --- End diff -- You should add tajo-storage-kafk module to tajo

[GitHub] tajo issue #1041: TAJO-1480: Kafka Consumer for kafka strage.

2016-08-17 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1041 Thanks you for your contribution! I left trivial comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tajo pull request #1041: TAJO-1480: Kafka Consumer for kafka strage.

2016-08-17 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1041#discussion_r75107466 --- Diff: tajo-storage/tajo-storage-kafka/src/test/java/org/apache/tajo/storage/kafka/server/EmbeddedZookeeper.java --- @@ -0,0 +1,90

[GitHub] tajo pull request #1041: TAJO-1480: Kafka Consumer for kafka strage.

2016-08-17 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1041#discussion_r75107066 --- Diff: tajo-storage/tajo-storage-kafka/src/test/java/org/apache/tajo/storage/kafka/server/EmbeddedKafka.java --- @@ -0,0 +1,135

[GitHub] tajo pull request #1041: TAJO-1480: Kafka Consumer for kafka strage.

2016-08-17 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1041#discussion_r75106709 --- Diff: tajo-storage/tajo-storage-kafka/src/main/java/org/apache/tajo/storage/kafka/SimpleConsumerManager.java --- @@ -0,0 +1,184

[GitHub] tajo pull request #1041: TAJO-1480: Kafka Consumer for kafka strage.

2016-08-17 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1041#discussion_r75105735 --- Diff: tajo-storage/tajo-storage-kafka/src/test/java/org/apache/tajo/storage/kafka/TestConstants.java --- @@ -0,0 +1,56 @@ +/** + * Licensed

[GitHub] tajo issue #1044: TAJO-1488: Implement KafkaTablespace

2016-08-16 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1044 Thanks for your quick fix. I'll review soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo issue #1044: TAJO-1488: Implement KafkaTablespace

2016-08-16 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1044 @combineads Hi Thanks for your contirbution! Could you fix broken build ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tajo pull request #1046: TAJO-2179: Add a regular expression scanner and app...

2016-08-15 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/1046 TAJO-2179: Add a regular expression scanner and appender. I refer to the hive for compatibility. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] tajo issue #1036: TAJO-2165: Add 'ALTER TABLE UNSET PROPERTY' statement to T...

2016-07-11 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1036 +1 @dongjinleekr Thanks for your contribution!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tajo pull request #1036: TAJO-2165: Add 'ALTER TABLE UNSET PROPERTY' stateme...

2016-07-06 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1036#discussion_r69849676 --- Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java --- @@ -88,6 +89,36 @@ public final void testAlterTableSetProperty

[GitHub] tajo issue #1029: TAJO-2160: Implement string_agg function.

2016-07-06 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1029 @jihoonson No. +1 The patch looks good to me. @combineads Thanks for your contribution! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tajo issue #1035: TAJO-2168: NullPointerException occurs when a simple query...

2016-07-03 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1035 +1 LGTM! Ship it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tajo issue #1034: TAJO-2148: Implement an example HTTP tablespace

2016-06-28 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1034 +1 Looks great to me Would you add a document to wiki for a developer? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tajo issue #1033: TAJO-2164: SequenceFile print wrong values with TextSerial...

2016-06-20 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1033 +1 LGTM I'm sorry for late review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo issue #1027: TAJO-2156: Create GeoIP functions taking various types ins...

2016-06-14 Thread jinossy
Github user jinossy commented on the issue: https://github.com/apache/tajo/pull/1027 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tajo pull request: TAJO-2164: SequenceFile print wrong values with...

2016-05-30 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1033#discussion_r65037985 --- Diff: tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java --- @@ -104,7 +105,15 @@ public void

[GitHub] tajo pull request: TAJO-2164: SequenceFile print wrong values with...

2016-05-30 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1033#discussion_r65037770 --- Diff: tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java --- @@ -105,6 +105,11 @@ public void

[GitHub] tajo pull request: TAJO-2160: Implement string_agg function.

2016-05-29 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1029#discussion_r65019730 --- Diff: tajo-core/src/main/proto/InternalTypes.proto --- @@ -45,3 +45,8 @@ message CorrProto { required double yvar = 5; required double covar

[GitHub] tajo pull request: TAJO-2160: Implement string_agg function.

2016-05-29 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1029#discussion_r65018556 --- Diff: tajo-core/src/main/proto/InternalTypes.proto --- @@ -45,3 +45,8 @@ message CorrProto { required double yvar = 5; required double covar

[GitHub] tajo pull request: TAJO-2069: Implement finding the total size of ...

2016-05-29 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1024#issuecomment-222400539 Guys, I found the improved performance reason. If there is not set the delimiter, the listObjects return a list of summary information about the objects

[GitHub] tajo pull request: TAJO-2164: SequenceFile print wrong values with...

2016-05-29 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1033#discussion_r65017026 --- Diff: tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java --- @@ -105,6 +105,11 @@ public void

[GitHub] tajo pull request: TAJO-2162: Internal error is occured while runn...

2016-05-26 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1031#issuecomment-222065279 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo pull request: TAJO-2156: Create GeoIP functions taking variou...

2016-05-19 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1027#issuecomment-220500912 @eminency Geoip2 seems to need to add a mock DataReader. If we add a geoip2 function by new jira issue, It would be better. What do you think? --- If your

[GitHub] tajo pull request: TAJO-2156: Create GeoIP functions taking variou...

2016-05-17 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1027#issuecomment-219928681 The Initial code did not add a tests. because geoip is GPL. Now, geoip function is breaking changes. we should add a tests. GeoIP2 is Apache 2.0 license. so we can

[GitHub] tajo pull request: TAJO-2069: Implement finding the total size of ...

2016-05-17 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1024#issuecomment-219903643 Why you close the PR? the conversation is lost. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tajo pull request: TAJO-2156: Create GeoIP functions taking variou...

2016-05-17 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1027#issuecomment-219903294 This changes should be added tests. If you change GeoIP to GeoIP2, it would be better for tests. please see the lincese and csv database for testing http

[GitHub] tajo pull request: TAJO-2151: Fix broken CI

2016-05-16 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1022#issuecomment-219379017 +1 LGTM!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo pull request: TAJO-2150: Fix invalid implementation of date t...

2016-05-16 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/1025 TAJO-2150: Fix invalid implementation of date time in jdbc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2150

[GitHub] tajo pull request: TAJO-2143: Fix race condition in task history w...

2016-05-09 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/1013 TAJO-2143: Fix race condition in task history writer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2143 Alternatively you

[GitHub] tajo pull request: TAJO-2135: Invalid join result when join key co...

2016-05-04 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1009#issuecomment-216799346 +1 The change looks great to me. Thanks for you effort! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] tajo pull request: TAJO-2135: Invalid join result when join key co...

2016-05-04 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1009#discussion_r61996618 --- Diff: tajo-cluster-tests/src/test/java/org/apache/tajo/TpchTestBase.java --- @@ -92,6 +92,7 @@ private void setUp() throws Exception { util = new

[GitHub] tajo pull request: TAJO-2116: Simplify rpc address in default conf...

2016-04-28 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/997#issuecomment-215350876 I've change the logger to static variable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] tajo pull request: TAJO-2140: TajoInternalError does not contains ...

2016-04-27 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/1008 TAJO-2140: TajoInternalError does not contains reason stack trace. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2140

[GitHub] tajo pull request: TAJO-2122: PullServer as an Auxiliary service o...

2016-04-24 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1001#issuecomment-214130995 @jihoonson I've test on hadoop-2.7.2 and I found following error ``` 2016-04-25 13:49:36,698 WARN org.apache.tajo.pullserver.PullServerUtil: Failed to manage

[GitHub] tajo pull request: TAJO-2122: PullServer as an Auxiliary service o...

2016-04-24 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1001#discussion_r60860272 --- Diff: tajo-yarn/pom.xml --- @@ -0,0 +1,185 @@ + + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org

[GitHub] tajo pull request: TAJO-2122: PullServer as an Auxiliary service o...

2016-04-24 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1001#discussion_r60856908 --- Diff: tajo-yarn/pom.xml --- @@ -0,0 +1,185 @@ + + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org

[GitHub] tajo pull request: TAJO-2125: Detect default java binary, if JAVA_...

2016-04-21 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1002#issuecomment-213221061 I've update the patch that borrow from hadoop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tajo pull request: TAJO-2125: Detect default java binary, if JAVA_...

2016-04-21 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1002#issuecomment-213217438 @hyunsik I agree @jihoonson I don’t know clearly but less mistake are better --- If your project is set up for it, you can reply to this email

[GitHub] tajo pull request: TAJO-2122: PullServer as an Auxiliary service o...

2016-04-21 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1001#discussion_r60542686 --- Diff: tajo-core/src/main/java/org/apache/tajo/worker/LocalFetcher.java --- @@ -0,0 +1,451 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] tajo pull request: TAJO-2122: PullServer as an Auxiliary service o...

2016-04-21 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1001#discussion_r60535225 --- Diff: tajo-core/src/main/java/org/apache/tajo/worker/LocalFetcher.java --- @@ -0,0 +1,451 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] tajo pull request: TAJO-2122: PullServer as an Auxiliary service o...

2016-04-21 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/1001#discussion_r60535035 --- Diff: tajo-core/src/main/java/org/apache/tajo/worker/TaskImpl.java --- @@ -696,44 +696,48 @@ private synchronized void fetcherFinished(TaskAttemptContext

[GitHub] tajo pull request: TAJO-2120 Change tajo.master.info-http.address ...

2016-04-20 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/999#issuecomment-212733788 Guys, tao-site.xml.template should be simplification. Most case info server configuration are not changed. If you are add the description in tajo docs

[GitHub] tajo pull request: TAJO-2110: Fix incorrect DateTime and remove ha...

2016-04-20 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/993#issuecomment-212714373 I created new ticket about validator https://issues.apache.org/jira/browse/TAJO-2128 --- If your project is set up for it, you can reply to this email and have your

[GitHub] tajo pull request: TAJO-2110: Fix incorrect DateTime and remove ha...

2016-04-20 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/993#discussion_r60519338 --- Diff: tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java --- @@ -327,6 +328,11 @@ public void execNonFromQuery(QueryContext

[GitHub] tajo pull request: TAJO-2125: Detect default java binary, if JAVA_...

2016-04-20 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1002#issuecomment-212695283 @hyunsik Now that master branch is based on JDK 1.8. if someone try to run the tajo on other JDK (1.7), tajo are throw ‘Unsupported major.minor version 52.0â

[GitHub] tajo pull request: TAJO-2110: Fix incorrect DateTime and remove ha...

2016-04-20 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/993#issuecomment-212274357 Never mind! I've update the patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tajo pull request: TAJO-2110: Fix incorrect DateTime and remove ha...

2016-04-19 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/993#issuecomment-212265382 You should change to interval '5 day' It looks like alias bug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] tajo pull request: TAJO-2110: Fix incorrect DateTime and remove ha...

2016-04-19 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/993#discussion_r60346629 --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/DatePartFromTimestamp.java --- @@ -59,8 +55,9 @@ public DatePartFromTimestamp

[GitHub] tajo pull request: TAJO-2110: Fix incorrect DateTime and remove ha...

2016-04-19 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/993#discussion_r60346243 --- Diff: tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/TextSerializerDeserializer.java --- @@ -101,12 +102,12 @@ public int

[GitHub] tajo pull request: TAJO-2110: Fix incorrect DateTime and remove ha...

2016-04-19 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/993#issuecomment-212237190 @jihoonson I've convert your testing example to pgsql please refer to following sequence: ``` postgres=# set time zone -5; postgres=# insert into test

[GitHub] tajo pull request: TAJO-2110: Fix incorrect DateTime and remove ha...

2016-04-19 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/993#discussion_r60341468 --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/function/datetime/AddDays.java --- @@ -52,8 +56,16 @@ public AddDays

[GitHub] tajo pull request: TAJO-2110: Fix incorrect DateTime and remove ha...

2016-04-19 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/993#issuecomment-211974078 Thanks for your detailed review! I’ve update the patch that reflects your comments but IMO, we should add a validator of datetime parser to the other ticket

[GitHub] tajo pull request: TAJO-2125: Detect default java binary, if JAVA_...

2016-04-19 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/1002 TAJO-2125: Detect default java binary, if JAVA_HOME is not set. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2125

[GitHub] tajo pull request: TAJO-2108: Refactor Schema to be immutable.

2016-04-18 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/1000#issuecomment-211679429 +1 The patch looks straightforward. Thanks for your effort! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] tajo pull request: TAJO-2109: Implement Radix sort

2016-04-17 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/992#issuecomment-211148856 +1 LGTM. Thanks for your effort! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tajo pull request: TAJO-2119: Invalid sort result when sort key co...

2016-04-14 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/998#issuecomment-210290864 +1 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo pull request: TAJO-2109: Implement Radix sort

2016-04-11 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/992#discussion_r59167325 --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java --- @@ -133,6 +140,22 @@ private ExternalSortExec(final

[GitHub] tajo pull request: TAJO-2109: Implement Radix sort

2016-04-11 Thread jinossy
Github user jinossy commented on a diff in the pull request: https://github.com/apache/tajo/pull/992#discussion_r59166686 --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java --- @@ -133,6 +140,22 @@ private ExternalSortExec(final

[GitHub] tajo pull request: TAJO-2109: Implement Radix sort

2016-04-11 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/992#issuecomment-208204244 OK, thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tajo pull request: TAJO-2109: Implement Radix sort

2016-04-11 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/992#issuecomment-208190209 @jihoonson Is this ready to review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] tajo pull request: TAJO-2110: Fix incorrect DateTime and remove ha...

2016-04-11 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/993#issuecomment-208189663 I’ve change time type to time type without timezone because it can't +/- operation. Actually we should add timetz type. --- If your project is set up for it, you

[GitHub] tajo pull request: TAJO-2116: Simplify rpc address in default conf...

2016-04-08 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/997 TAJO-2116: Simplify rpc address in default configuration. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2116 Alternatively

[GitHub] tajo pull request: TAJO-2112: Improve disk load, when queries run ...

2016-04-06 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/995 TAJO-2112: Improve disk load, when queries run simultaneously. I've remove the ``tajo.worker.resource.disks`` You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] tajo pull request: TAJO-2110: Fix incorrect DateTime and remove ha...

2016-04-04 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/993 TAJO-2110: Fix incorrect DateTime and remove hard coded tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2110

[GitHub] tajo pull request: TAJO-2105: Apply new identifier system to new s...

2016-03-29 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/989#issuecomment-202734399 +1 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo pull request: TAJO-2099: Implement an Adapter for the legacy ...

2016-03-27 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/981#issuecomment-202220628 +1 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo pull request: TAJO-2099: Implement an Adapter for the legacy ...

2016-03-22 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/981#issuecomment-200121613 rebase please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo pull request: TAJO-1929: Can't read ORC file on hive-meta

2016-03-22 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/974#issuecomment-200121122 Hi guys, This issue is solved by https://github.com/apache/tajo/pull/985 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] tajo pull request: TAJO-2102: Migrate to Apache Orc from Presto's ...

2016-03-22 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/985#issuecomment-200111707 +1 LGTM! Thanks for your efforts! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tajo pull request: TAJO-2091: Error or progress update should use ...

2016-03-21 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/977#issuecomment-199138510 +1 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tajo pull request: TAJO-2092: TestStorages.testNullHandlingTypesWi...

2016-03-19 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/982#issuecomment-197703547 I've remove the NULL type in file schema --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] tajo pull request: TAJO-2092: TestStorages.testNullHandlingTypesWi...

2016-03-19 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/982 TAJO-2092: TestStorages.testNullHandlingTypesWithProjection occasiona… …lly fail. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo

[GitHub] tajo pull request: TAJO-2100: Add missing cancellation in defaultT...

2016-03-19 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/983 TAJO-2100: Add missing cancellation in defaultTaskScheduler when a wo… …rker is no respond. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] tajo pull request: TAJO-2095: HiveCatalogStore::existIndexesByTabl...

2016-03-15 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/976#issuecomment-197165570 +1 LGTM! Travis failure is not related this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tajo pull request: TAJO-2096: Apply offheap to the join operator.

2016-03-15 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/978 TAJO-2096: Apply offheap to the join operator. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2096 Alternatively you can

[GitHub] tajo pull request: TAJO-2089: Improve null handling in UDF.

2016-03-06 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/972 TAJO-2089: Improve null handling in UDF. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2089 Alternatively you can review

[GitHub] tajo pull request: TAJO-2088: Change QueryTestCaseBase.runSimpleTe...

2016-03-03 Thread jinossy
Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/971#issuecomment-192055880 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] tajo pull request: TAJO-2081: Incorrect task locality on single no...

2016-02-24 Thread jinossy
GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/968 TAJO-2081: Incorrect task locality on single node. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-2081 Alternatively you can

  1   2   3   4   5   6   7   >